[koha-commits] main Koha release repository branch master updated. v19.11.00-783-g6e49d50d83
Git repo owner
gitmaster at git.koha-community.org
Wed Feb 19 13:02:43 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 6e49d50d83d0c32107b23b9b3a79cb87ba4bda73 (commit)
via 33e33345b0a13b98759759b0ad9500d82f52afd2 (commit)
via aa83cb59ced347ac909444a99ac43058d6ad7b1e (commit)
via 2cf4496dd6e98f69baafe1e23ff418b2855f8f49 (commit)
via f2cbcdbb99f871b64ee79c3679c453262302d17e (commit)
via 43dd880d4fc4cd4e1214113c31f9a865b183b75b (commit)
via 3c382e1f35bdc6e07c2303e1002bb20e06127751 (commit)
via fa8225feb344eb224cd59eace0cb18370d9e547e (commit)
via 6d55462f1b2cb4840333f9e3830de3084a39a30e (commit)
via 946d1dff1a428217cb825787c341563ef1e97289 (commit)
via 38b95b5122a8448bbf84c96450fd1906d4fffaec (commit)
via 4a9330df408bd7bfd6bfafbedeeb1cb9ce858d9a (commit)
via f3d8a3b91aef7debb66d064d8150843ed448b1fe (commit)
via 18eeaed95feb8ccd5ff2598c4e6511a814d8a370 (commit)
via 74729776551c68a3bab9693f082ef22822864e4d (commit)
via afb3d36c3e5ccda5cc1bb562d2fd07a218fdcb32 (commit)
via 7d78c57d97b6e5e8e06a753edb8da2e68aab3c4e (commit)
via 515df43af8dddd493616dfe9efc83373c8d2f50b (commit)
via 07ad62380ececb2dda591fcf495d67ee71d890d1 (commit)
via ccf4dfc3e9f4819c2317a533a68ddce7395d7035 (commit)
via fe43d98bd1492a1aeb94d2a3df987ca6c5ed7150 (commit)
via 5ecabb315add6fd27772178bb8aed745c59e4cf3 (commit)
via 0fdc9377d73d2cf1759d88029114e29f8faa8097 (commit)
via e3c8ba65cff48d598c810f9def4f654c79dd0669 (commit)
via db019fa6628c147c716a1dc1cad903f025775ee4 (commit)
via c801ea3c69e6d6db524f568372a8685622ee90cf (commit)
via 76a4753dfe9bf2f541eb7cb40bfaab8a9605c9db (commit)
via 9363ff96b59155ea4e3bde5a3498ac4b189b287b (commit)
via d3f50b246db813caeb2d030488231c30a79650fe (commit)
via ee8a9a6af57300c4cf7b629492cc3c31bf901933 (commit)
via 93a5e162d6e1049dca7216eecdbc6ec39d9fba06 (commit)
via ea09ef36e84e0f217b1c071f110089fddb1a311c (commit)
via 29c09991e7d7e4a00ba18163d28e9545bd4325ce (commit)
via 7cd00c77d4305758e438f09aaeb1aaad65464aec (commit)
via d0a8df6214e68d9fbdbac43e5b73e6c5bb155cb3 (commit)
via 9446b894b863fd3db0dbc22536895a4ef754ca7e (commit)
via 79dbd633695527d3a6d6e5bd8327fd3c26f2f639 (commit)
from fc1db6b9948ba06cd6497ff64248451078fffedc (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 6e49d50d83d0c32107b23b9b3a79cb87ba4bda73
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Feb 19 11:36:50 2020 +0000
Bug 21633: DBRev 19.12.00.024
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 33e33345b0a13b98759759b0ad9500d82f52afd2
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jan 23 12:06:21 2020 +0000
Bug 21633: (follow-up) Cleanup other values for finesMode
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit aa83cb59ced347ac909444a99ac43058d6ad7b1e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 3 14:56:53 2020 +0000
Bug 21633: Remove finesMode 'test'
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2cf4496dd6e98f69baafe1e23ff418b2855f8f49
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 31 14:18:24 2020 +0000
Bug 24094: Strip trailing spaces and punctuation from authority headings
Both when searching for and creating new authorities we need to remove
punctuation that exists in the bibliographic record but does not belong in
the authority record.
For example, a series with a volume contains a semicolon in the bib record,
however, this should not be passed to the authority as the volume is not
included in the authority record.
To test:
1 - Set AutoCreateAuthorities to 'generate'
2 - Set BiblioAddsAuthorities to 'true'
3 - Set CatalogModuleRelink to 'Do'
4 - Find or create a record with:
a 100 field with a subfield e preceded by a comma: 100 $aBoring, M. Eugene M ,$e author
an 830 field with a volume preceded by a semicolon: 650$aLord of the rings ;$v 3.
5 - Save the records and check the links
6 - Note punctuation is passed through
7 - Save again, auth records are created again
8 - Apply patch
9 - Save again, new auth records are created again
10 - Check the records, punctuation has been removed
11 - Save again, no more records created.
Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f2cbcdbb99f871b64ee79c3679c453262302d17e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 31 14:18:14 2020 +0000
Bug 24094: Unit tests
Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 43dd880d4fc4cd4e1214113c31f9a865b183b75b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 13 17:01:06 2020 +0100
Bug 24494: Make the regex more exact
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3c382e1f35bdc6e07c2303e1002bb20e06127751
Author: Victor Grousset/tuxayo <victor at tuxayo.net>
Date: Thu Jan 23 15:55:18 2020 +0100
Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules
== Test plan ==
- work with SCSS (just recompile it if you never did)
- https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS
- now you have a node_modules directory
- prove -r t/00-valid-xml.t
- it should fail on files in node_modules
- apply this patch
- prove -r t/00-valid-xml.t
- it should work
- sabotage a legitimate XML file, like etc/SIPconfig.xml
- prove -r t/00-valid-xml.t
- it should fail, good the test is still useful
- undo the sabotage
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fa8225feb344eb224cd59eace0cb18370d9e547e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Feb 14 11:44:44 2020 +0100
Bug 19791: Keep user in circ when viewing patron's logs
When a librarian is viewing the log for a given patron (tab "modification log"
from the circulation module), the "object" and "modules" parameter can
be modified. It does not make sense, we should stay in the circulation
module and avoid those fields to be modified.
Test plan:
- Modify several patrons (in order to have several modification logs)
- Go to the modification log tab of one of them
- Notice that the "Object" input is not a "Borrowernumber" labelled
input and that you cannot modify it.
Also notice that the "modules" is hidden.
- Go to the log viewer tool and notice that the view is still the same
as before this patch.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6d55462f1b2cb4840333f9e3830de3084a39a30e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 18 11:29:46 2019 +0100
Bug 24051: Remove "search( %condition ) is deprecated" warning from batchMod.pl
Test plan:
Go to Home › Tools › Batch item modification
Insert barcodes and continue
=> Without this patch you will get warning in the log
=> With this patch applied you warning does no longer appear
Confirm that the number of holds is correct
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 946d1dff1a428217cb825787c341563ef1e97289
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sat Feb 16 11:46:08 2019 -0300
Bug 22245: Allow copy/move from and to control fields
The JS conditions were wrong, we want to allow copy and move between
control fields.
Test plan:
Create a new MARC modification template action using control fields.
Confirm that you are allowed to copy/move a control field to another one
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 38b95b5122a8448bbf84c96450fd1906d4fffaec
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Mon Feb 17 10:32:26 2020 +0000
Bug 24669: Show "Unlimited" values correctly in smart-rules.pl
The rules "Holds allowed (total)", "Holds allowed (daily)", "Holds per
record (count)" were not set empty when in rule editing. Also, the
text "Unlimited" was not shown for rule "Holds per record (count)"
even though it should have been since empty value means unlimited
holds per record.
To test:
1. Apply patch
2. Edit the rules "Holds allowed (total)", "Holds allowed (daily)", "Holds per
record (count)" to be empty and save
3. Make sure all of the above rules now say Unlimited
4. Edit the rules again and make sure the above rules are now in the
rule editing empty.
Sponsored-by: The National Library of Finland
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 4a9330df408bd7bfd6bfafbedeeb1cb9ce858d9a
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Mon Feb 17 09:48:22 2020 +0000
Bug 24669: Improve numeric input handling in smart-rules.pl
This removes code duplication by introducing a new subroutine
strip_non_numeric() that removes whitespace and makes the rule value
'' if it is a string value instead of a digit. The call to
strip_non_numeric() is now added also to all the rules it is needed
in.
To test:
1. Write some string like "test" to rules:
- Current checkouts allowed
- Current on-site checkouts allowed
- Holds allowed (total)
- Holds allowed (daily)
- Holds per record (count)
- Holds per record (count) – can be found in default policy
2. Save rules
3. Apply patch
4. Edit the rule line where you just typed all those strings and save
5. Notice how the values are now empty strings (some say "unlimited" but
if you go check from DB it should show empty value there)
Sponsored-by: The National Library of Finland
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f3d8a3b91aef7debb66d064d8150843ed448b1fe
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Feb 18 18:32:02 2020 +0000
Bug 24666: (QA follow-up) Add missing filters
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 18eeaed95feb8ccd5ff2598c4e6511a814d8a370
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Feb 17 14:39:50 2020 +0100
Bug 24666: Display not registered guarantors on the patron detail page
There was no way to see the not registered guarantors apart of editing
the patron.
Test plan:
- Create a patron with category type "Child"
- Define a "guarantor surname" and/or "guarantor firstname" in the
"Contact" block (the patron is not registered)
- See the patron's detail page and notice that the info appear
- Edit and add a registered guarantor
- See the patron's detail page and notice that the 2 guarantors info appear
Note that the relationship has been added.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 74729776551c68a3bab9693f082ef22822864e4d
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Nov 24 13:01:20 2019 +0100
Bug 5016: Fix some translation issues with English PDF order templates
Changes made:
- Instead of n° print no.
- Market Identification => Market identification
- GST => Tax
To test:
- Create at least 2 baskets with one or more orders
- Create a basket group with those baskets
- Print the PDF using
- the 2 page layout
- the 3 page layout
- Verify that the changes made appear and everything looks correct
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit afb3d36c3e5ccda5cc1bb562d2fd07a218fdcb32
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Jan 12 03:55:41 2020 +0000
Bug 17221: (follow-up) Orphan comma in shelf browser
This further improves the display if no location or no
collection has been set. Example output:
Browsing Centerville shelves, Collection: Non-fiction
Also changes 'Collection code' to 'collection' and takes
care of additional spaces before the comma.
To test:
- Make sure your OpacShelfBrowser pref is set to "Show"
- Search for a record with items and callnumbers in your OPAC
- "Browse shelf"
- Navigate back and forth, verify the information showing on
top of the list is correctly formatted
- Try different combinations for the following prefs:
- ShelfBrowserUsesCcode
- ShelfBrowserUsesHomeBranch
- ShelfBrowserUsesLocation
- Verify the display is always nicely formatted
Note: fixing capitalization here is tricky, as it also
depends on what was displayed before. If you have no
homebranch, you would want "Shelving...", if you have one
we'd like "shelving...". Left as I found it for now.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7d78c57d97b6e5e8e06a753edb8da2e68aab3c4e
Author: phette23 <phette23 at gmail.com>
Date: Sun Jan 12 11:32:53 2020 +0100
Bug 17221: Remove orphan commas in shelf browser
This patch adds more conditions to the shelf browser template
such that the displayed text reads as a proper list no matter
what combination of system preferences are utilized
Sponsored-by: California College of the Arts
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 515df43af8dddd493616dfe9efc83373c8d2f50b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Dec 3 11:03:18 2019 -0500
Bug 21944: Improve efficiency of code
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 07ad62380ececb2dda591fcf495d67ee71d890d1
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date: Tue Dec 4 16:38:34 2018 +0000
Bug 21944: Reroute waiting hold from wrong branch
To Test:
1) Place a hold on an item.
2) Check in the item to trigger the hold. Item is now listed as
waiting.
3) Set branch to a different library.
4) Check in the item to trigger the hold. Notice that nothing but a
local use is recorded.
5) Apply the patch.
6) Repeat steps 1-4. Notice that the hold is triggered around routed to
its original pickup location. A transfer is set and the hold status
is changed from waiting to correctly showing the item as in transit.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ccf4dfc3e9f4819c2317a533a68ddce7395d7035
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date: Thu Dec 13 00:08:54 2018 +0000
Bug 21944: Test for Circulation.pm
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fe43d98bd1492a1aeb94d2a3df987ca6c5ed7150
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 26 09:27:21 2019 +0100
Bug 24110: Do not html filter TT vars when dumped
DumpTemplateVarsIntranet and DumpTemplateVarsOpac are devs tools to
display the variables sent to the template. They should not be filtered
otherwise it's getting complicate to read.
For instance: $VAR1 = { var => val }
Test plan:
Turn DumpTemplateVarsIntranet on
Go to the main page
Show the source of the page
Confirm that the variable are displayed as it and not filtered
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5ecabb315add6fd27772178bb8aed745c59e4cf3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Feb 17 16:59:15 2020 +0100
Bug 24367: May fix another warning
May fix the following warning:
Use of uninitialized value in concatenation (.) or string at
/kohadevbox/koha/C4/Search.pm line 1818.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0fdc9377d73d2cf1759d88029114e29f8faa8097
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jan 10 08:51:51 2020 +0000
Bug 24367: Resolve other uninitialized warns in Search.pm
Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line 2074.
Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line 2137.
Use of uninitialized value in concatenation (.) or string at /usr/share/koha/C4/Search.pm line 2189.
Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line 2213.
Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line 2215.
Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line 2225.
Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line 2226.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e3c8ba65cff48d598c810f9def4f654c79dd0669
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jan 10 08:27:39 2020 +0000
Bug 24367: Resolve warn Use of uninitialized value within [arrays]
Use of uninitialized value within @operators in string eq at /usr/share/koha/C4/Search.pm line 1362.
Use of uninitialized value within @indexes in pattern match (m//) at /usr/share/koha/C4/Search.pm line 1367.
Trivial tests added.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit db019fa6628c147c716a1dc1cad903f025775ee4
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jan 10 08:07:05 2020 +0000
Bug 24367: Resolve warn Negative repeat count does nothing
Negative repeat count does nothing at /usr/share/koha/Koha/QueryParser/Driver/PQF/query_plan.pm line 53.
Negative repeat count does nothing at /usr/share/koha/Koha/QueryParser/Driver/PQF/query_plan/node.pm line 102.
I am not sure if this statement actually does what the author intended,
but adding the test on node_count/atom_count removes the warn.
Repeating this change on query_plan.pm line 62.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c801ea3c69e6d6db524f568372a8685622ee90cf
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jan 10 07:54:33 2020 +0000
Bug 24367: Resolve warn Argument available is not numeric in delete
Argument "available" isn't numeric in delete at /usr/share/koha/C4/Search.pm line 1480.
The construction delete array[string] simply does not work.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 76a4753dfe9bf2f541eb7cb40bfaab8a9605c9db
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 7 16:53:50 2020 +0100
Bug 24367: Remove warnings from Search.t
* Set defaults for index to 'kw'
* Check that priority is defined before using it.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9363ff96b59155ea4e3bde5a3498ac4b189b287b
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 24 17:33:48 2020 +0000
Bug 24514: Add option to exclude title from patron-title.inc
Without this patch sorting by patron name on the 'holds awaiting
pickup' report sorted by title, surname, firstname. With this
patch the list will sort by surname, firstname, ignoring the title.
To test:
- generate and capture a hold for a patron named "Mr. A A"
- generate and capture a hold for a patron named "A A"
- generste and capture a hold for patron named "Mr. B B"
- generste and capture a hold for patron named "B B"
- go to holds awaiting pickup
- sort by patron name ascending
- holds sort Mr. A, Mr. B, A, B
- sort by patron name descending
- holds sort B, A, Mr. B, Mr. A
- APPLY PATCH
- Reload holds awaiting pickup
- Confirm holds sort on Surname
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d3f50b246db813caeb2d030488231c30a79650fe
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Sun Feb 9 21:55:01 2020 +0000
Bug 18933: Allow OPAC messaging SMS number to be set to empty
To test:
1) Ensure EnhancedMessagingPreferences is enabled and
EnhancedMessagingPreferencesOPAC is set to Show. Set SMSSendDriver to
Email
2) Log in to OPAC, go to your messaging tab
3) Set an SMS number if you havent already
4) Try to remove it (set to empty)
5) Notice that it says the number has been updated, but it has not
been set to empty
6) Apply patch and refresh page
7) Attempt to set the number to empty
8) Confirm this is successful
Sponsored-by: Catalyst IT
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ee8a9a6af57300c4cf7b629492cc3c31bf901933
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Dec 16 17:41:42 2019 +0000
Bug 24249: OPAC lists page should require login for login-dependent operations
This patch modifies opac-shelves.pl so that login is required if the
requested operation is anything but "view" and "list."
The patch also modifies a couple of "Log in to create a new list" links
so that they point to the list creation form instead of opac-user.pl.
To test, apply the patch and go to the main lists page (the list of
lists) in the OPAC while not logged in.
- Click the "Log in to create a new list" link.
- Log in.
- You should be taken to the "Create a new list" form.
- Also test the "New list" link shown in the toolbar when you're
viewing the contents of a list.
- When not logged in click the "Lists" menu in the page's header menu.
Clicking "Log in to create a new list" should take you to the login
form and then to the list creation form.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 93a5e162d6e1049dca7216eecdbc6ec39d9fba06
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 16 18:50:16 2019 +0100
Bug 24388: Remove uneeded test in lateorders.tt
The budget_lock is never set (and has never been).
Test plan:
For QAer only, make sure this never worked
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ea09ef36e84e0f217b1c071f110089fddb1a311c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 12 15:49:17 2020 +0100
Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled
If the showLastPatron syspref is disabled, we should not store the 3
cookies we use for this feature.
Test plan:
0/ Do not apply this patch
1/ Turn off showLastPatron
2/ Search for a patron, click on a result
3/ Open the cookie list of your browser
=> You see 3 cookies named lastborrowercard, lastborrowername,
lastborrowernumber
4/ Remove them
5/ Apply the patch
6/ Reload the patron detail page
=> The 3 cookies are not created
7/ Turn the pref on
8/ Reload the patron detail page
=> The 3 cookies are created
9/ Eat one of them.
QA note: it's a bit dirty, we should do that JS side, but
staff-global.js is too widely used to make the change easy. Any other
suggestions welcomed.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 29c09991e7d7e4a00ba18163d28e9545bd4325ce
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Feb 12 21:24:58 2020 +0100
Bug 24647: Remove PDF::API2::Simple from cpanfile
It is not used anywhere.
Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile.
These modules are included in PDF::API2 which is already in cpanfile.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7cd00c77d4305758e438f09aaeb1aaad65464aec
Author: David Kuhn <techservspec at gmail.com>
Date: Sat Aug 31 16:23:16 2019 -0700
Bug 23527: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
Changing the template toolkit filter for rendering the value of
BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri
to url fixes the problem.
To test (requires a Baker & Taylor username and password):
1. Enter the B&T url into BakerTaylorBookstoreURL.
2. Set BakerTaylorEnabled to "add" and enter your username and password.
3. Look up a title in the OPAC.
4. Locate a title with a cover image.
5. Click on the cover image. You are not redirected to the url stored
in BakerTaylorBookstoreURL.
6. Display the full record for the title
7. Click on the cover image. You are not redirected to the url stored
in BakerTaylorBookstoreURL.
8. Apply the patch.
9. Refresh the OPAC display.
10. Click on the cover image. You are now redirected to the specified url.
11. Return to the results list.
12. Click on a cover image. You are now redirected to the specified url.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Although I don't have valid Baker & Taylor credentials I was able to use
dummy data to verify that the links in the template are correctly
encoded with this patch.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d0a8df6214e68d9fbdbac43e5b73e6c5bb155cb3
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Feb 19 11:09:41 2020 +0000
Bug 24640: DBRev 19.12.00.023
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9446b894b863fd3db0dbc22536895a4ef754ca7e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 12 12:26:25 2020 +0100
Bug 24640: Allow quotes.timestamp to be NULL
It is broken with strict mode enable, timestamp is created without
default value.
Note that the .sql installer file init the value with NOW(), which is
wrong.
DBD::mysql::st execute failed: Field 'timestamp' doesn't have a default
value [for Statement "INSERT INTO quotes (source, text) VALUES (?, ?);"
with ParamValues: 0="poeut", 1="pouet"] at
/kohadevbox/koha/tools/quotes/quotes_ajax.pl line 49.
Test plan:
Create a new quote of the day
=> Without this patch you will get an error
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 79dbd633695527d3a6d6e5bd8327fd3c26f2f639
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Feb 13 15:43:30 2020 +0000
Bug 24654: Remove trailing quote in rda264 XSLT
To test:
1 - Find or add a recod with a 264 field
2 - Make sure there is a subfield b
3 - View the record in opac
4 - Right click on publisher link and copy and paste into a text editor
5 - Note the trailing " in the search
6 - Apply patch
7 - Refresh
8 - Link is correctly formed now
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 24 +++++---
C4/Circulation.pm | 8 ++-
C4/Heading/MARC21.pm | 2 +-
C4/Reserves.pm | 28 ++++-----
C4/Search.pm | 68 ++++++++++++---------
Koha.pm | 2 +-
Koha/QueryParser/Driver/PQF/query_plan.pm | 4 +-
Koha/QueryParser/Driver/PQF/query_plan/node.pm | 2 +-
Koha/Schema/Result/Quote.pm | 8 +--
Koha/pdfformat/layout2pages.pm | 2 +-
Koha/pdfformat/layout3pages.pm | 4 +-
admin/smart-rules.pl | 41 ++++++-------
cpanfile | 3 -
installer/data/mysql/kohastructure.sql | 2 +-
installer/data/mysql/sysprefs.sql | 2 +-
installer/data/mysql/updatedatabase.pl | 23 +++++++
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 8 ++-
.../prog/en/includes/doc-head-open.inc | 3 +-
.../prog/en/includes/patron-title.inc | 1 +
.../prog/en/includes/waiting_holds.inc | 2 +-
.../prog/en/modules/acqui/lateorders.tt | 4 +-
.../en/modules/admin/preferences/circulation.pref | 1 -
.../prog/en/modules/admin/smart-rules.tt | 12 +++-
.../prog/en/modules/members/moremember.tt | 9 ++-
.../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 47 ++++++++------
.../prog/js/marc_modification_templates.js | 4 +-
koha-tmpl/intranet-tmpl/prog/pdf/layout2pages.odt | Bin 12728 -> 11630 bytes
koha-tmpl/intranet-tmpl/prog/pdf/layout2pages.pdf | Bin 25887 -> 25264 bytes
koha-tmpl/intranet-tmpl/prog/pdf/layout3pages.odt | Bin 13023 -> 11913 bytes
koha-tmpl/intranet-tmpl/prog/pdf/layout3pages.pdf | Bin 27293 -> 26626 bytes
.../bootstrap/en/includes/doc-head-open.inc | 3 +-
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 7 +--
.../bootstrap/en/includes/shelfbrowser.inc | 8 ++-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 4 +-
.../bootstrap/en/xslt/MARC21slimUtils.xsl | 2 +-
misc/cronjobs/fines.pl | 2 +-
misc/cronjobs/staticfines.pl | 1 -
opac/opac-messaging.pl | 11 ++--
opac/opac-shelves.pl | 27 +++++---
t/00-valid-xml.t | 1 +
t/db_dependent/Biblio.t | 24 +++++++-
t/db_dependent/Circulation.t | 14 ++++-
t/db_dependent/Heading_MARC21.t | 8 ++-
tools/batchMod.pl | 2 +-
46 files changed, 265 insertions(+), 169 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list