[koha-commits] main Koha release repository branch master updated. v19.11.00-825-gfbd0687718
Git repo owner
gitmaster at git.koha-community.org
Thu Feb 20 10:38:39 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via fbd0687718a607aa3881298ff70c2101e8cf9cb8 (commit)
via acc38cbc043858a1af6dffc66709eaa73946e6fb (commit)
via 06b5535de6564385fb920786d1fb8e42094d2b4d (commit)
via 2b4c70dd864b14131c7294f2563d52ec8a8f4deb (commit)
via 0e7f7ab051c8a23705ea802005f15877ca40d16f (commit)
via 24154f2ec91eed4d9f28f5008d74013de2b48196 (commit)
via b459df2bcf0a9d69bc591f1b64db5b25a98251b6 (commit)
via a7b7d63db1db41b5ffc7a7cfd5d395b868a4cf4a (commit)
via c42097685da4d6bb361a5e51bacc1777422a89da (commit)
via ebb57cd6c5114241b93b7f474057fbff5b60c48c (commit)
from bf0f6a2b8f9e78a7548f27a6430d187b0e9f08b7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit fbd0687718a607aa3881298ff70c2101e8cf9cb8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Feb 14 10:23:39 2020 +0100
Bug 24657: Do not explicitely pass a branchcode
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit acc38cbc043858a1af6dffc66709eaa73946e6fb
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Thu Feb 13 14:16:20 2020 -0300
Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t
on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups like this
my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } );
I didn't realize this was creating 2 new libraries that sometimes messed up with tests, so I changed it to this
my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this
my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
but they needed to be pickup_locations, and sometimes they wheren't set as such, so I changed it to this
my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
To test:
1. do not apply this patch
2. in bash:
for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done
3. Grab a cup of coffee (or tea if you are healthy) and wait for a while
4. Whithin 300 iterations there should be an error in any of both scripts and for loop should exit
5. Apply this patch
6. repeat step 2 and 3 (decaff this time!)
7. All 300 loops should pass
8. Sign off
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 06b5535de6564385fb920786d1fb8e42094d2b4d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Feb 20 09:12:35 2020 +0000
Bug 14567: DBRev 19.12.00.028
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2b4c70dd864b14131c7294f2563d52ec8a8f4deb
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Feb 20 09:09:45 2020 +0000
Bug 14567: Compiled CSS
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0e7f7ab051c8a23705ea802005f15877ca40d16f
Author: Robin Sheat <robin at catalyst.net.nz>
Date: Tue Jul 21 17:14:09 2015 +1200
Bug 14567: Add a browse interface to the OPAC
This is an interface for quick and efficient browsing through records.
It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to
enter the prefix of an author, title, or subject and it'll give you a
list of the options that match that. You can then scroll through these
and select the one you're after. Selecting it provides a list of records
that match that particular search.
To Test:
1 - Apply patches
2 - Update database (updatedatabase on kohadevbox)
3 - Compile the CSS
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
yarn build --view=opac on kohadevbox
4 - Enable the new syspref OpacBrowseSearch
5 - Have ES running and some records in it
SearchEngine syspref set to Elasticsearch
6 - Browse to opac home, click 'Browse search' link
for your site)
7 - Test searching for author, title, and subject
8 - Verify that results are returned in expected order
9 - Experiment with fuzziness
https://www.elastic.co/guide/en/elasticsearch/reference/5.6/common-options.html#fuzziness
Options are: exact (0 edits), fuzzy (1 edit), very fuzzy (2 edits)
10 - Click any result and verify specific titles are correct
11 - Click through title to record and verify it is the correct record
12 - Test that disabling pref removes the link on the opac home
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 24154f2ec91eed4d9f28f5008d74013de2b48196
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Feb 5 15:07:23 2020 +0100
Bug 14898: Add button at manual invoice to redirect to pay tab
Test plan:
1. Create manual invoice for any patron and click on "Save", you should
be redirected to Account tab
2. Create manual invoice for any patron and click on "Save and pay", you
should be redirected to Account tab
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b459df2bcf0a9d69bc591f1b64db5b25a98251b6
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Feb 16 05:41:46 2020 +0000
Bug 14647: Make spelling in file format pull downs match
While bibliographic had XML and MARC, authorities had xml and marc
in the pull down. This just makes both the same.
To test:
- Look at the pull downs on both tabs and verify they are
now using the same spelling
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a7b7d63db1db41b5ffc7a7cfd5d395b868a4cf4a
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Sun Feb 9 21:32:12 2020 +0000
Bug 14647: (follow-up) Fix script not detecting XML output format
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c42097685da4d6bb361a5e51bacc1777422a89da
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Mon Jul 10 02:07:38 2017 +0000
Bug 14647: (follow-up) Changes to script
This patch adds the necessary changes to the script so that the filename
extensions works for exporting authorities.
To test:
1) Attempt to export with all filetypes for biblios and authorities
2) Confirm the extension for the exported file (after clicking the
Export button) is correct for each one
Sponsored-by: Catalyst IT
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ebb57cd6c5114241b93b7f474057fbff5b60c48c
Author: Gus <gel1163 at stacmail.net>
Date: Tue Jan 19 23:33:14 2016 +0000
Bug 14647: Make the file name extension dynamic on exporting records
Test -
1. go to cgi-bin/koha/tools/export.pl
2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following
3. In Output format
4. When changing "File format" from dropdown it update "file name"
5. Still works with user inputted names
Works as expected.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
Koha.pm | 2 +-
Koha/SearchEngine/Elasticsearch/Browse.pm | 183 +++++++++++++++++++++
admin/searchengine/elasticsearch/field_config.yaml | 1 +
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 11 ++
.../prog/en/modules/admin/preferences/opac.pref | 7 +
.../prog/en/modules/members/maninvoice.tt | 4 +-
.../intranet-tmpl/prog/en/modules/tools/export.tt | 27 ++-
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 101 ++++++++++++
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 1 +
.../opac-tmpl/bootstrap/en/modules/opac-browse.tt | 94 +++++++++++
koha-tmpl/opac-tmpl/bootstrap/js/browse.js | 172 +++++++++++++++++++
members/maninvoice.pl | 13 +-
opac/opac-browse.pl | 112 +++++++++++++
t/Koha_SearchEngine_Elasticsearch_Browse.t | 68 ++++++++
t/db_dependent/Holds.t | 6 +-
t/db_dependent/Koha/Item.t | 15 +-
tools/export.pl | 7 +-
19 files changed, 804 insertions(+), 23 deletions(-)
create mode 100644 Koha/SearchEngine/Elasticsearch/Browse.pm
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/js/browse.js
create mode 100755 opac/opac-browse.pl
create mode 100755 t/Koha_SearchEngine_Elasticsearch_Browse.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list