[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.14-1-g89ab97da99

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  89ab97da996acbe7ead156f03a8f72b520301669 (commit)
      from  610a6cf78bdced8b43a4dcb275b9b858f536ac11 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 89ab97da996acbe7ead156f03a8f72b520301669
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 20 12:22:58 2019 +0100

    Bug 23064: Use Koha::Subscription in ModSubscription
    
    We must use Koha::Subscription instead of raw SQL.
    It will fix issue with default and integer values.
    
    Test plan:
    Edit a subscription and set number of issues = "f"
    Save
    => Without this patch there is a SQL error in the log:
      Incorrect integer value: 'f' for column 'numberlength'
    => With this patch the other changes are effective.
    
    Note: We also could change the type attribute of the input to "number",
    to have a client-side check
    
    Also, the return value of ModSuggestion is never used, so we are safe
    with that.
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    The <strict_sql_modes> flag must be present and set to 1 in the <config> section of koha-conf.xml
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Serials.pm | 73 +++++++++++++++++++++++++++++++++++------------------------
 1 file changed, 44 insertions(+), 29 deletions(-)


hooks/post-receive
-- 
main Koha release repository