[koha-commits] main Koha release repository branch master updated. v19.11.00-867-gb2ad635825
Git repo owner
gitmaster at git.koha-community.org
Mon Feb 24 14:48:04 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via b2ad63582520f49ad3c03ca29975d99fa2ef2ecf (commit)
via a7bf8a488f4357e016ef1f43d89a241ff2fbb3bf (commit)
via e875e3980605f406bb62fbc5f2eacb9ff5c7c0de (commit)
via 612887d46fbed7811aed055367ac61f1bfde68f6 (commit)
via 721c8bcd18cec819ed35c60949b81cfa5c243f90 (commit)
via 825741aa430db9b3d15b0d8ecd65b62f3166fb2a (commit)
via cd2a99e456efd4ea7e92be2fd33e4683ad6205c7 (commit)
via 88d1ad0c35af9415d24037f408dd312e885250be (commit)
via 7e1db56dd8a0f70792fc9c1f8eb66423a9611944 (commit)
via db2cf80a7a85e3d9db0965509c11411c53b997c4 (commit)
via 18afaf438b2f1d8ae602dae1531d08bc41e4e241 (commit)
from 2164a4d427e7693effd44d310e1bf3e37904dc95 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b2ad63582520f49ad3c03ca29975d99fa2ef2ecf
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Tue Jan 21 12:39:49 2020 -0300
Bug 24356: Make objects.search prefetch embedded relations
This patch makes the Koha::Object(s) derived classes expose information
about prefetch-able relations. This is then used by a new helper to
generate the prefetch information for the DBIC query.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object* \
t/db_dependent/Koha/REST/Plugin/Objects.t \
t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a7bf8a488f4357e016ef1f43d89a241ff2fbb3bf
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 21 15:46:53 2020 -0300
Bug 24356: prefetch_whitelist tests
This patch adds tests for the introduced methods.
To test:
1. Run the tests :-D
=> SUCCESS: They pass!
2. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e875e3980605f406bb62fbc5f2eacb9ff5c7c0de
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Tue Dec 10 21:02:41 2019 -0300
Bug 24211: Compress/uncompress translation files
This patch adds the ability to compress/uncompress
translations files.
On update/install the files are uncompressed first
The only gain is to use less space.
To test:
1) Apply the patch
2) Go to misc/translator
3) Try it
$ ./translate compress fr-FR (check po/*.gz)
$ ./translate uncompress fr-FR ( check normal files)
4) Try again with verbose mode
$ ./translate compress fr-FR -v (list compressed files)
$ ./translate uncompress fr-FR -v (list uncompressed files)
5) Try update compressed files
$ ./translate compress fr-FR
$ ./translate update fr-FR (result is uncompressed)
6) Try install compressed files
$ ./translate compress fr-FR
$ ./translate install fr-FR
7) Try compress all
$ ./translate compress (add '-v' for verbose output)
8) Try uncompress all
$ ./translate uncompress (add '-v' for verbose output)
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 612887d46fbed7811aed055367ac61f1bfde68f6
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Feb 21 12:28:30 2020 +0000
Bug 24629: SIP patron items contains an array of hashes
$patron->{items} contains the borrowers checkouts as an array of hashes
{ barcode => $item->barcode }
When printing to log we assumed these were only barcodes
This patch pushes the current checkout as a hash and maps the values retrieved to a string
To test:
1 - Enable SIP debug mode
2 - Perform multiple checkouts for a patron
3 - Note the messages like:
koha koha_sip_koha[13575]: ILS::Checkout: patron 123 has checked out HASH(0x55a5b187f858), HASH(0x55a5b1896ad0), HASH(0x55a5b18a6cf0), 7826832
4 - Apply patch
5 - Restart all the things
6 - Do some checkouts via SIP
6 - Messages should now have barcodes
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 721c8bcd18cec819ed35c60949b81cfa5c243f90
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 12 10:22:29 2020 +0100
Bug 24629: SIP log - Display barcode instead of hash
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 825741aa430db9b3d15b0d8ecd65b62f3166fb2a
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Thu Feb 20 08:29:37 2020 +0100
Bug 24693: Move GD from recommends to requires in cpanfile
Without it, catalogue/detail.pl dies (and probably other scripts too)
Test plan:
1. Uninstall GD, reload starman
2. Go to catalogue/detail.pl. Confirm that it dies
3. Reinstall GD, reload starman
4. Go to catalogue/detail.pl. Confirm that it work normally
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cd2a99e456efd4ea7e92be2fd33e4683ad6205c7
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Nov 29 09:45:48 2019 +0000
Bug 24114: (QA follow-up) Fix counts for lock, anonymize and delete
Since these operations impact on the resultset, the counts should be
saved before.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 88d1ad0c35af9415d24037f408dd312e885250be
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Nov 29 09:17:19 2019 +0000
Bug 24114: (follow-up) Resolve warning on non-numeric subtraction
Argument "" isn't numeric in subtraction (-) at /usr/share/koha/Koha/Patrons.pm line 290.
Coming from an empty or undefined FailedLoginAttempts.
Test plan:
Verify that Koha/Patrons.t still passes.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7e1db56dd8a0f70792fc9c1f8eb66423a9611944
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 26 11:11:35 2019 +0100
Bug 24114: Remove warn statements from Koha::Patrons
The warn must be done in the cronjob.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Followed this test plan (with two follow-ups applied):
[1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef
[2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job:
Locked 0 patrons
Anonymized 1 patrons
Deleted 0 patrons
[3] Pick borrower, set expiry to NOW-3. Run cleanup job:
Locked 0 patrons
Anonymized 0 patrons
Deleted 1 patrons
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit db2cf80a7a85e3d9db0965509c11411c53b997c4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Feb 21 10:31:54 2020 +0100
Bug 24682: Make UsageStatsGeolocation readonly (and redirect to the config page)
To prevent invalid values in this pref (and so on the server), we should
make this input readonly on the syspref page.
The sysprefs related to Hea should be edited from the dedicated page, so
also adding a note about that.
Test plan:
Search syspref with "UsageStats"
Notice the note about the admin page
Notice the UsageStatsGeolocation input is now readonly (and resized, to
display the whole value when filled)
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 18afaf438b2f1d8ae602dae1531d08bc41e4e241
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Jan 28 16:09:20 2020 +0100
Bug 24527: misc/cronjobs/update_totalissues.pl problem with multiple items
misc/cronjobs/update_totalissues.pl when issuing statistics table, no-incremental, has a problem for biblio with multiple items.
The first SQL query gets the biblios linked to items with issues in statistics :
SELECT
biblio.biblionumber, COUNT(statistics.itemnumber)
FROM
biblio
LEFT JOIN
items
ON
(biblio.biblionumber=items.biblionumber)
LEFT JOIN
statistics
ON
(items.itemnumber=statistics.itemnumber)
WHERE
statistics.type = 'issue'
$limit
GROUP BY
biblio.biblionumber
The second SQL query is :
SELECT
biblio.biblionumber, 0
FROM
biblio
LEFT JOIN
items
ON
(biblio.biblionumber=items.biblionumber)
LEFT JOIN
statistics
ON
(items.itemnumber=statistics.itemnumber)
WHERE
statistics.itemnumber IS NULL
GROUP BY
biblio.biblionumber
The problem is that this second query will set to 0 where ANY item has no entry in statistics table.
So when running it sets 0 to the biblio that had a value from first
query.
I think the best fix is to use "WHERE statistics.type = 'issue'" inside que JOIN :
LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber AND statistics.type = 'issue')
Test plan :
1) Begin with an empty database
2) Create a biblio 1 with no items
3) Create a biblio 2 with 3 items
4) Create a biblio 3 with 2 items
5) Checkout and checkin all items of biblio 2
6) Checkout and checkin the firt item of biblio 3
7) run misc/cronjobs/update_totalissues.pl --use-stats -v
8) Check biblio 1 has biblioitems.totalissues = 0
9) Check biblio 2 has biblioitems.totalissues = 3
10) Without patch the biblio 3 has biblioitems.totalissues = 0
11) With patch the biblio 3 has biblioitems.totalissues = 1
12) Check misc/cronjobs/update_totalissues.pl --incremental is OK
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/SIP/ILS.pm | 4 +-
C4/SIP/Sip/MsgType.pm | 2 +-
Koha/Object.pm | 29 +++++++++++++
Koha/Objects.pm | 16 ++++++++
Koha/Patrons.pm | 19 +++------
Koha/REST/Plugin/Objects.pm | 8 ++++
Koha/REST/Plugin/Query.pm | 48 ++++++++++++++++++++++
cpanfile | 2 +-
.../prog/en/modules/admin/preferences.tt | 6 ++-
.../prog/en/modules/admin/preferences/admin.pref | 2 +
misc/cronjobs/cleanup_database.pl | 23 +++++++++--
misc/cronjobs/update_totalissues.pl | 18 +++-----
misc/translator/LangInstaller.pm | 38 ++++++++++++++++-
misc/translator/translate | 15 ++++++-
t/Koha/REST/Plugin/Query.t | 33 ++++++++++++++-
t/db_dependent/Koha/Object.t | 25 ++++++++++-
t/db_dependent/Koha/Objects.t | 28 ++++++++++++-
t/db_dependent/Koha/Patrons.t | 11 ++++-
18 files changed, 284 insertions(+), 43 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list