[koha-commits] main Koha release repository branch master updated. v19.11.00-907-gd296876626
Git repo owner
gitmaster at git.koha-community.org
Wed Feb 26 22:09:08 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via d296876626d30f89fc92e66804ad9fe8270001ad (commit)
via d4509897e1613e8239b5d27ffb9bc121ad842c5d (commit)
via 1f16881f28146a9a01ed0d599087f1c612ba9b7d (commit)
via 4f3b4dae2740113a022ca4b44ff5e4881f706a1c (commit)
via 0dc6f329992697bd5bfa6906df2d891b1615c8cc (commit)
via 64855886b8e4eb71d03fa902762c3f3f1f79b5ed (commit)
via dd9a965ed58208075efa1bc51a2364096f04cda3 (commit)
via f4077149075d89dd1db284e8984c71b6a1bbeac5 (commit)
from ba4fb0fdeec33dea91316b220ba24bd6b7b6d9a8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d296876626d30f89fc92e66804ad9fe8270001ad
Author: Nazlı Çetin <nazli at devinim.com.tr>
Date: Fri Feb 21 14:33:42 2020 +0000
Bug 21879: Code cleaning in printinvoice.pl
Coming from
commit 51aa6db46c604aa202a3d8f8e5028557480efbd5
Bug 12001: Move GetMemberAccountRecords to the Koha namespace
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d4509897e1613e8239b5d27ffb9bc121ad842c5d
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date: Wed Feb 19 11:45:04 2020 +0200
Bug 24680: Fix end_date returned from api/v1/holds/{hold_id}/suspension endpoint
Before this patch the response would return current date as the suspension end date for a hold that is suspended with no end date.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 1f16881f28146a9a01ed0d599087f1c612ba9b7d
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date: Wed Feb 19 11:43:08 2020 +0200
Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also when priority is not provided
Before this fix the endpoint would accept the request but fail to actually update the hold if the request does not contain a priority parameter.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 4f3b4dae2740113a022ca4b44ff5e4881f706a1c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Feb 26 03:16:26 2020 +0000
Bug 24733: created_by param should be an arrayref
We allow for the user to add multiple users to this field, and the
search function expects and array. We have been treating it as a scalar
TO test:
1 - Have an open basket in acquisitions
2 - Add to basket - from an existing order (copy)
3 - Enter a name in the 'Basket created by' field and select a user
4 - Hit search
5 - ISE (Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/share/koha/lib/C4/Acquisition.pm line 2482.)
6 - Apply patch
7 - Repeat 1-4
8 - Success!
9 - Test with mutiple 'created by' entries as well
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0dc6f329992697bd5bfa6906df2d891b1615c8cc
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Feb 25 13:40:52 2020 +0000
Bug 24294: (QA follow-up) Add rollback and 008 default test
Default for 008 was not tested yet.
Only wondering if we should insert default values only when we meet an
undefined value. Or should we also add if we meet an empty string? Is the
latter not more realistic in MARC?
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 64855886b8e4eb71d03fa902762c3f3f1f79b5ed
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 2 12:09:27 2020 +0100
Bug 24294: Add default value support for control fields in ACQ framework
When trying to add an order using the ACQ framework with a 008@ tag,
Koha explodes:
Control fields (generally, just tags below 010) do not have subfields,
use data() at /home/vagrant/kohaclone/C4/Acquisition.pm line 3272.
Test plan:
Set a default value for a control field in the ACQ framework
Turn on UseACQFrameworkForBiblioRecords
Create a new order from a new record
The default value should be displayed
Save
=> No crash
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dd9a965ed58208075efa1bc51a2364096f04cda3
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Feb 23 21:25:00 2020 +0000
Bug 24605: (QA follow-up) Fix unencoded series link in staff interface
Same change as the first patch, but for the staff detail page.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f4077149075d89dd1db284e8984c71b6a1bbeac5
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Feb 6 17:45:07 2020 +0000
Bug 24605: Fix unencoded series link
To test:
1 - Add an 830 to a record with a volume subfield separated by a semicolon
830$aThe series ;$vvol 8.
2 - View the record in the opac
3 - Click the series link, no results
4 - View the link url - the semicolon is not encoded
5 - Apply patch
6 - link works
7 - URL is corrrectly encoded
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 24 +++++++---
Koha/REST/V1/Holds.pm | 29 ++++++------
acqui/duplicate_orders.pl | 3 +-
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 2 +-
.../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 +-
members/printinvoice.pl | 12 -----
t/db_dependent/Acquisition/FillWithDefaultValues.t | 18 +++++++-
t/db_dependent/api/v1/holds.t | 51 +++++++++++++++++-----
8 files changed, 95 insertions(+), 46 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list