From gitmaster at git.koha-community.org Thu Jan 2 13:43:57 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Jan 2020 12:43:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-104-g91bf28c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 91bf28ced90470addb6aee265cabf442fb645be8 (commit) via 3078524db838170d9d5f99a32360fe5b0b2d9325 (commit) via ee4d99cc76a79ad11c1b0a2b096abb2f9b85bf0e (commit) via 611cb461893cf09481895ee23b769cb5ee078bed (commit) via 0d52062219bc898e46aff1920f1ccc4e61d4c604 (commit) from c1d56dde9300dfed53e72612276717cce0f65de2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 91bf28ced90470addb6aee265cabf442fb645be8 Author: Martin Renvoize Date: Thu Jan 2 12:18:48 2020 +0000 Bug 24282: Compiled CSS Signed-off-by: Martin Renvoize commit 3078524db838170d9d5f99a32360fe5b0b2d9325 Author: Fridolin Somers Date: Fri Dec 20 08:40:37 2019 +0100 Bug 24282: SCSS conversion broke style in search results item status Before SCSS conversion, there was a style for search results item status : #searchresults span.status { Conversion to SCSS added ul : #searchresults ul span.status { Now style does not apply anymore. You can see that items on loan are not red anymore. To test, apply the patch and regenerate your CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. All rules using #searchresults in 17.11 : font-size : 90%; list-style: url(../img/item-bullet.gif); padding : .2em 0; clear : left; } clear : left; color : #900; display : block; } clear : left; display : block; } display : block; } float : left; margin : 3px 5px 3px -5px; } vertical-align : top; } Apply patch update intranet CSS file and check you see the same rules. Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize commit ee4d99cc76a79ad11c1b0a2b096abb2f9b85bf0e Author: Nick Clemens Date: Fri Dec 13 19:58:52 2019 +0000 Bug 24244: Send null instead of empty string if branch not set Fix NewSuggestion if branchcode is passed with an empty string. Error was "Broken FK constraint" Test plan: Create a new suggestion, select "any" for the library. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 611cb461893cf09481895ee23b769cb5ee078bed Author: Jonathan Druart Date: Sun Dec 15 12:43:25 2019 +0100 Bug 24244: Add test Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0d52062219bc898e46aff1920f1ccc4e61d4c604 Author: Kyle M Hall Date: Mon Dec 30 06:52:03 2019 -0500 Bug 24317: Sample patron data not loading for non-English installations Bug 14570 removed the guarantorid column from the English sample data but missed the other translated installers. This means the sample patrons can no longer be installed for other languages. Test Plan: 1) Attempt to install the sample patron data in German, Spanish, Norwegian, and Polish 2) Note the error 3) Apply this patch 4) Repeat step 1 5) No error! Signed-off-by: Bernardo Gonzalez Kriegel On top of Bug 24316 + followup Tested doing clean install for de-DE es-ES fr-CA it-IT nb-NO pl-PL up to loading of all mandatory & optional data. All languages load without problems. A small qa error fixed in commit message. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Suggestions.pm | 2 + .../data/mysql/de-DE/optional/sample_patrons.sql | 102 ++++++++++---------- .../data/mysql/es-ES/optional/sample_patrons.sql | 102 ++++++++++---------- .../mysql/nb-NO/2-Valgfritt/sample_patrons.sql | 102 ++++++++++---------- .../data/mysql/pl-PL/optional/sample_patrons.sql | 102 ++++++++++---------- .../intranet-tmpl/prog/css/src/staff-global.scss | 28 +++--- koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- t/db_dependent/Suggestions.t | 1 + 8 files changed, 222 insertions(+), 219 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jan 2 14:10:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Jan 2020 13:10:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-112-g93a0610 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 93a06105a825e9ef585d7acb0b7cad319580dce5 (commit) via 52196919f22cb4e72dc61b670ea400f15c4a9cf6 (commit) via 4fe524c93f3ec882620c1c00d2338b3826a66f9e (commit) via 8111e4c116bbdcb5e03040e1c90ab48531eeaefb (commit) via d6400a7024eceb8a234de78c23b9eac5f5674385 (commit) via 5e5e50ac177b4d29b24c58ce08516a08a0ced503 (commit) via 880fc53d741308ff8148d0be976009ee00896322 (commit) via ffeda45d23c578bd36bf7ba3ca542bcab403fa23 (commit) from 91bf28ced90470addb6aee265cabf442fb645be8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 93a06105a825e9ef585d7acb0b7cad319580dce5 Author: Jonathan Druart Date: Mon Nov 18 16:53:41 2019 +0100 Bug 14973: Fix edit a suggestion and dup found The find duplicate call must only be done when the suggestion is new. It does not make sense to search for a duplicate when the suggestion already exists. This patch also fixes a side-effect: - Create a suggestion using an existing biblio title - Ignore the warning and save - Edit again and save => BOOM on date Template process failed: undef error - The given date (18/11/2019) does not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 168 The dates are not processed and so badly formatted when sent to the template. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 52196919f22cb4e72dc61b670ea400f15c4a9cf6 Author: Jonathan Druart Date: Wed Nov 6 17:25:57 2019 +0100 Bug 14973: Add missing filters in templates Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 4fe524c93f3ec882620c1c00d2338b3826a66f9e Author: Jonathan Druart Date: Wed Nov 6 17:23:33 2019 +0100 Bug 14973: Remove double declaration of suggestions_loop Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 8111e4c116bbdcb5e03040e1c90ab48531eeaefb Author: Jonathan Druart Date: Wed Oct 16 15:54:39 2019 +0200 Bug 14973: Remove double textarea for notes Certainly a bad merge conflict resolution (I am certainly the one to blame). However I do not understand where this "note" variable come from. Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit d6400a7024eceb8a234de78c23b9eac5f5674385 Author: Jonathan Druart Date: Wed Oct 16 15:46:56 2019 +0200 Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 5e5e50ac177b4d29b24c58ce08516a08a0ced503 Author: Alex Arnaud Date: Wed Mar 8 11:23:12 2017 +0000 Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 880fc53d741308ff8148d0be976009ee00896322 Author: Alex Arnaud Date: Wed Oct 7 17:34:33 2015 +0200 Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing Signed-off-by: Nicole Engard Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit ffeda45d23c578bd36bf7ba3ca542bcab403fa23 Author: Katrin Fischer Date: Sat Nov 2 00:19:33 2019 +0000 Bug 23783: Show languages from MARC21 field 041 in OPAC This copies the changes made in bug 20364 for the staff interface to the OPAC. Some slight changes have been made in comparison: - OPAC uses the class "separator" for the characters that are used between repeatable tags. "sep" as used in the original patch set has some CSS rules attached to it that break display, so it makes double sense to change it. - We revently removed ending . from the display in OPAC - so it's done here too. To test: 1) Apply patch 2) Do a search in the OPAC and check the results look correct 3) Check some biblio detail pages and verify that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Suggestions.pm | 42 ++++++++ .../prog/en/modules/suggestion/suggestion.tt | 32 ++++++- .../bootstrap/en/modules/opac-suggestions.tt | 52 ++++++---- .../bootstrap}/en/xslt/MARC21Languages.xsl | 0 .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 + .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 2 + .../bootstrap/en/xslt/MARC21slimUtils.xsl | 52 ++++++++++ opac/opac-suggestions.pl | 18 +++- suggestion/suggestion.pl | 100 ++++++++++++-------- t/db_dependent/Suggestions.t | 20 +++- 10 files changed, 258 insertions(+), 62 deletions(-) copy koha-tmpl/{intranet-tmpl/prog => opac-tmpl/bootstrap}/en/xslt/MARC21Languages.xsl (100%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jan 2 14:40:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Jan 2020 13:40:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-116-gddfeea9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ddfeea9c57e2af5b01e86b9790480f79f851044f (commit) via 3fc405ab40e20abb3f8a41e2364663f618b89cc5 (commit) via c1f7eb84294cd48c7975f21a732834e6763f5808 (commit) via dd9be62a2ae6b247aeee25290e1199bea16f79db (commit) from 93a06105a825e9ef585d7acb0b7cad319580dce5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ddfeea9c57e2af5b01e86b9790480f79f851044f Author: Martin Renvoize Date: Thu Jan 2 13:15:05 2020 +0000 Bug 14973: Compiled CSS Signed-off-by: Martin Renvoize commit 3fc405ab40e20abb3f8a41e2364663f618b89cc5 Author: Jonathan Druart Date: Thu Nov 7 19:15:08 2019 +0100 Bug 14963: Fix ergonomic issue on small screen Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit c1f7eb84294cd48c7975f21a732834e6763f5808 Author: Jonathan Druart Date: Thu Nov 7 18:18:31 2019 +0100 Bug 14963: Set status=ORDERED for suggestions created from existing record Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit dd9be62a2ae6b247aeee25290e1199bea16f79db Author: Jonathan Druart Date: Tue Nov 5 19:42:43 2019 +0100 Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: acqui/addorder.pl | 16 ++++++++++++---- acqui/neworderempty.pl | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 1 + .../bootstrap/en/includes/opac-detail-sidebar.inc | 4 ++++ .../opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 13 +++++++++---- opac/opac-suggestions.pl | 16 +++++++++++++++- 7 files changed, 43 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jan 2 15:30:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Jan 2020 14:30:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-121-gf480ca8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f480ca803ba9d4552678b3e326b3c19b9c6aec00 (commit) via 42cca4afc718dacd93bc66be50f82ca32006a164 (commit) via 7abb7350ef63cb81e87b2c07141e800ed542cc8a (commit) via ac29b2029de81a24897f4fdfb88bdfddbb01c954 (commit) via 1887d0a8cc5554574ca05ccc40b892a838f2a690 (commit) from ddfeea9c57e2af5b01e86b9790480f79f851044f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f480ca803ba9d4552678b3e326b3c19b9c6aec00 Author: Marcel de Rooy Date: Fri Dec 20 07:14:32 2019 +0000 Bug 24267: (QA follow-up) Remove two calls, add transaction Call to GetAuthorizedHeading is already done just before calling ImportBreedingAuth. Call to GuessAuthTypeCode is not used. Adding transaction to test (check your database, kidclamp ;) Test plan: Add new authority via Z3950 in the interface. Run t/db_dependent/Breeding.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 42cca4afc718dacd93bc66be50f82ca32006a164 Author: Nick Clemens Date: Thu Dec 19 17:37:23 2019 +0000 Bug 24267: Unit tests Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 7abb7350ef63cb81e87b2c07141e800ed542cc8a Author: Nick Clemens Date: Wed Dec 18 18:27:33 2019 +0000 Bug 24267: Improve ImportBreedingAuth git grep ImportBreedingAuth - there is only one call to this routine from SearchZ3950Auth We pass it a MARC record, '2' for overwrite_auth We then check for this record in the DB and get the breeding id, however, when overwrite_auth is 2 we always add the auth to the batch and return the new breeding id. We don't actually use any of the other parameters returned here either To recreate: 1 - Browse to Authorities 2 - Select New form Z3950 3 - Perform a search that returns results 4 - SELECT COUNT(*) FROM import_auths 5 - Repeat the search 6 - SELECT COUNT(*) FROM import_auths 7 - There are 20 more records 8 - SELECT * FROM import_auths - note the repeated rows Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ac29b2029de81a24897f4fdfb88bdfddbb01c954 Author: Bernardo Gonzalez Kriegel Date: Mon Dec 30 20:55:41 2019 -0300 Bug 24316: (follow up) Fix es-ES web installer Same correction, as other languages, removing obsolete authorised value MANUAL_INV. Same test Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 1887d0a8cc5554574ca05ccc40b892a838f2a690 Author: Katrin Fischer Date: Sun Dec 29 23:21:06 2019 +0100 Bug 24316: Remove obsolete sample data for MANUAL_INV authorised value Bug 23049 replaced the MANUAL_INV authorised value by a dedicated table, but missed to remove the authorised value sample data from the non-English installers. This patch corrects this oversight. Note: The German (de-DE) file was changed a bit more, adding 2 missing translations for the new RETURN_CLAIM_RESOLUTION and to match the sequence of the en file. To test: - Verify the SQL file changes are valid by loading those files OR - Run the installers for each language on an empty database - Verify there is no error loading the optional authorised value data Signed-off-by: Bernardo Gonzalez Kriegel Tested with 24317 and a small followup for this bug for es-ES Tested doing clean install for de-DE es-ES fr-CA it-IT nb-NO pl-PL up to loading of all mandatory & optional data. All languages load without problems. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Breeding.pm | 67 ++++---------------- installer/data/mysql/de-DE/optional/auth_val.sql | 21 +++--- installer/data/mysql/es-ES/optional/auth_val.sql | 3 - installer/data/mysql/fr-CA/facultatif/auth_val.sql | 3 - installer/data/mysql/it-IT/necessari/auth_val.sql | 3 - .../data/mysql/nb-NO/2-Valgfritt/auth_val.sql | 3 - installer/data/mysql/pl-PL/optional/auth_val.sql | 3 - t/db_dependent/Breeding.t | 45 ++++++++++--- 8 files changed, 58 insertions(+), 90 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jan 2 16:10:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Jan 2020 15:10:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-125-gbebdbd5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bebdbd535b9e28b982f615a301a2817aa1454951 (commit) via 8dd4bf35a96bf7543e8eaa66794963136e29b627 (commit) via c5fdc5e10f6d45b83068757549cb98ccc2fb3eec (commit) via e357bc6a9d770ead4e24436ec625a8b78daa603b (commit) from f480ca803ba9d4552678b3e326b3c19b9c6aec00 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bebdbd535b9e28b982f615a301a2817aa1454951 Author: Owen Leonard Date: Mon Oct 28 16:02:35 2019 +0000 Bug 23913: Use a single menu to sort lists in the OPAC This patch modifies the sorting form on the OPAC list contents view so that the two menus (sort field and direction) are combined into one. This makes it consistent with the sort menu on the search results page. To test, apply the patch and view a list with multiple titles on it. Test the "Sort by" menu, trying all the various options. Confirm that the pre-selected item in the sorting menu is correct after each re-sort. Edit the list to change the default sorting and verify that the "Sort by" menu reflects your selection. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8dd4bf35a96bf7543e8eaa66794963136e29b627 Author: Martin Renvoize Date: Thu Jan 2 14:38:03 2020 +0000 Bug 23889: Compiled CSS Signed-off-by: Martin Renvoize commit c5fdc5e10f6d45b83068757549cb98ccc2fb3eec Author: Jonathan Druart Date: Mon Dec 16 15:11:27 2019 +0100 Bug 23889: Use same css class on the basic editor view Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e357bc6a9d770ead4e24436ec625a8b78daa603b Author: Owen Leonard Date: Thu Oct 24 14:15:41 2019 +0000 Bug 23889: Improve style of menu header in advanced cataloging editor This patch updates the style of dropdown menu headers to make it apply more globally and changes the advanced cataloging editor template so that the correct class is applied to the menu header. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test the interfaces where these kinds of menu headers can be found: - Catalog search results: The "Sort" menu (Popularity, Author, etc. headings). - Saved report results: Run a report which returns a column of biblionumbers or itemnumbers. Check the "Batch operations" menu (Bibliographic records or item records headings). - Advanced cataloging editor: The settings menu (Change framework header). Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/css/src/staff-global.scss | 20 ++-- koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../prog/en/modules/cataloguing/addbiblio.tt | 3 +- .../prog/en/modules/cataloguing/editor.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 110 ++++++++++++-------- opac/opac-shelves.pl | 9 +- 6 files changed, 87 insertions(+), 59 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jan 2 17:43:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Jan 2020 16:43:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-130-g65fb973 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 65fb97389b229c0a4de2a09570168ee4a48359bc (commit) via 500400077e471567197d1ad6a551c441d889e9c8 (commit) via 31e5359a6cd0dc1b5f02ec1930f418a1344f6478 (commit) via bcd7e4c94ccc1ec14ea04d66c80b20a7aecddf96 (commit) via d917d4eb9d9d1c19330710868909b50a0d715876 (commit) from bebdbd535b9e28b982f615a301a2817aa1454951 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 65fb97389b229c0a4de2a09570168ee4a48359bc Author: Joonas Kylmälä Date: Tue Dec 17 13:59:55 2019 +0000 Bug 24016: (QA follow-up) Format code to adhere to perltidy format Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 500400077e471567197d1ad6a551c441d889e9c8 Author: Lari Taskula Date: Tue Nov 12 12:18:27 2019 +0000 Bug 24016: manager_id in Koha::Patron::Message->store should not depend on userenv alone Koha::Patron::Message->store has this my $userenv = C4::Context->userenv; $self->manager_id( $userenv ? $userenv->{number} : undef); This breaks in REST API when userenv is not set. Let API user pass manager_id without relying on C4::Context->userenv. To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe success Sponsored-by: Koha-Suomi Oy Signed-off-by: Maryse Simard Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 31e5359a6cd0dc1b5f02ec1930f418a1344f6478 Author: Lari Taskula Date: Tue Nov 12 12:24:30 2019 +0000 Bug 24016: Add a failing test for overwrite-able manager_id in Koha::Patron::Message To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe failure t/db_dependent/Koha/Patron/Messages.t .. 2/12 Failed test 'Manager id should be overwrite-able even if defined in userenv' at t/db_dependent/Koha/Patron/Messages.t line 90. got: '1100' expected: '1101' Looks like you failed 1 test of 12. t/db_dependent/Koha/Patron/Messages.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/12 subtests Sponsored-by: Koha-Suomi Oy Signed-off-by: Maryse Simard Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit bcd7e4c94ccc1ec14ea04d66c80b20a7aecddf96 Author: Nick Date: Tue Dec 17 02:07:47 2019 +0000 Bug 23261: (follow-up) Use logged_in_user and move test Signed-off-by: Martin Renvoize commit d917d4eb9d9d1c19330710868909b50a0d715876 Author: Nick Clemens Date: Wed Jul 3 19:11:54 2019 +0000 Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Signed-off-by: Jessica Zairo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Patron/Message.pm | 6 +++-- .../en/modules/opac-recordedbooks-search.tt | 11 +++++++-- t/db_dependent/Koha/Patron/Messages.t | 26 ++++++++++++++------ 3 files changed, 32 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jan 2 18:59:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Jan 2020 17:59:27 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.01-10-gb5ef6be Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b5ef6bea2db7a65de489db8831a26b5f923ffe04 (commit) via 1d57597e7334e6e183bbad1aa01c6eb9ff44f306 (commit) via bb4be7805111541564c2e97be2ea52d9eba51ddd (commit) via 301fab872e272d4e3c322a154aecde13d155ba10 (commit) via 6f9367e848f0a7c8d6a7aafb4b2e1d916506aeba (commit) from 0e1d6ffcf7fac1894abc097fa37f2704b22ca4d9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5ef6bea2db7a65de489db8831a26b5f923ffe04 Author: Lucas Gass Date: Sat Dec 14 00:55:39 2019 +0000 Bug 24245: rename self reg confirm page body id Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1d57597e7334e6e183bbad1aa01c6eb9ff44f306 Author: Nick Clemens Date: Fri Dec 13 14:24:33 2019 +0000 Bug 24240: Move form closing tag outside of conditional To test: 1 - Create a public list 2 - View the list as a user not signed in 3 - Validate the HTML, note the div closed with open elements, and a form tag unclosed 4 - Apply patch 5 - Those errors are fixed Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit bb4be7805111541564c2e97be2ea52d9eba51ddd Author: Nick Clemens Date: Fri Dec 13 23:01:05 2019 +0000 Bug 24085: Make print and cancel-hold buttons instead of submit To test: 1 - Place a hold on an item 2 - Check in the item to trigger the hold 3 - Test both the print and cancel buttons to make sure all looks correct Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 301fab872e272d4e3c322a154aecde13d155ba10 Author: Jonathan Druart Date: Fri Dec 13 17:50:59 2019 +0100 Bug 24241: (bug 23049 follow-up) Add description for manage_accounts Test plan: Edit permissions for a patron Unfold "Manage Koha system settings (Administration panel)" => Without this patch a checkbox appears without description => With this patch you see the description for manage_accounts Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 6f9367e848f0a7c8d6a7aafb4b2e1d916506aeba Author: Lucas Gass Date: Thu Dec 5 21:52:31 2019 +0000 Bug 24184: Reword FallbackToSMSIfNoEmail syspref text Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc | 5 +++++ .../prog/en/modules/admin/preferences/patrons.pref | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 10 +++++----- .../bootstrap/en/modules/opac-registration-confirmation.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 3 +-- 5 files changed, 13 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jan 3 12:14:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jan 2020 11:14:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-132-g42d40e3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 42d40e372e25cc4790290dcd0bb31c50f237f5fe (commit) via dc5fe323d2e8393caa76103c1402a0448003f61e (commit) from 65fb97389b229c0a4de2a09570168ee4a48359bc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 42d40e372e25cc4790290dcd0bb31c50f237f5fe Author: Martin Renvoize Date: Fri Jan 3 10:49:15 2020 +0000 Bug 23261: (RM follow-up) Add missing uri filter Signed-off-by: Martin Renvoize commit dc5fe323d2e8393caa76103c1402a0448003f61e Author: Jonathan Druart Date: Wed Dec 11 13:02:07 2019 +0100 Bug 24217: use Modern::Perl for modules when strict is missing We absolutely need that for modules. We are enabling strict by using Modern::Perl. Note that other modules from C4 use strict and warnings, instead of Modern::Perl Test plan: git grep 2505 **/*.pm should not return any results And let's see later what needs to be fixed. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Accounts.pm | 3 +-- C4/Auth_with_ldap.pm | 3 +-- C4/AuthoritiesMarc/MARC21.pm | 3 +-- C4/AuthoritiesMarc/UNIMARC.pm | 3 +-- C4/BackgroundJob.pm | 3 +-- C4/Budgets.pm | 3 +-- C4/Circulation.pm | 4 +--- C4/Contract.pm | 2 -- C4/InstallAuth.pm | 3 +-- C4/Installer/UpgradeBackup.pm | 3 +-- C4/Items.pm | 3 +-- C4/Koha.pm | 3 +-- C4/Members.pm | 3 +-- C4/Members/AttributeTypes.pm | 3 +-- C4/Output.pm | 3 +-- C4/Overdues.pm | 3 +-- C4/Print.pm | 3 +-- C4/Record.pm | 6 ++---- C4/Reports.pm | 3 +-- C4/Reserves.pm | 3 +-- C4/Scheduler.pm | 3 +-- C4/Search.pm | 3 +-- C4/Search/PazPar2.pm | 3 +-- C4/Suggestions.pm | 4 +--- C4/TmplTokenType.pm | 3 +-- C4/XISBN.pm | 3 +-- .../opac-tmpl/bootstrap/en/modules/opac-recordedbooks-search.tt | 2 +- misc/translator/TmplTokenizer.pm | 3 +-- misc/translator/VerboseWarnings.pm | 3 +-- 29 files changed, 29 insertions(+), 61 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jan 3 12:31:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jan 2020 11:31:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-136-g309754a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 309754a143cb2f4ce1adc9b4bfeeca3e9af900a0 (commit) via 52a9dee300e43873268bcd87b1908dc9f89fe9a2 (commit) via 3dd6a2cb934c3a4ae8540dfb2e0a05cbecb45a13 (commit) via cd4dfc6e121a8f867fee5fcf8ccfd594bf163ba7 (commit) from 42d40e372e25cc4790290dcd0bb31c50f237f5fe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 309754a143cb2f4ce1adc9b4bfeeca3e9af900a0 Author: Jonathan Druart Date: Fri Dec 13 16:01:46 2019 +0100 Bug 21684: Adjust some tests Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 52a9dee300e43873268bcd87b1908dc9f89fe9a2 Author: Jonathan Druart Date: Thu Dec 12 14:28:03 2019 +0100 Bug 21684: Fix delete methods and add more tests Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 3dd6a2cb934c3a4ae8540dfb2e0a05cbecb45a13 Author: Jonathan Druart Date: Fri Oct 26 13:54:47 2018 -0300 Bug 21684: Add tests to show some of the discrepancies Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit cd4dfc6e121a8f867fee5fcf8ccfd594bf163ba7 Author: Jonathan Druart Date: Tue Sep 24 18:00:00 2019 -0300 Bug 24150: Add Koha::Old::*[s] This bug report will add new classes for: * Koha::Old::Patron[s] * Koha::Old::Biblio[s] * Koha::Old::Item[s] * Koha::Old::Biblioitem[s] Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Object.pm | 6 +- Koha/{Tags/Approval.pm => Old/Biblio.pm} | 12 +- Koha/{Tags/Approval.pm => Old/Biblioitem.pm} | 12 +- Koha/{ActionLogs.pm => Old/Biblioitems.pm} | 14 +- Koha/{ActionLogs.pm => Old/Biblios.pm} | 14 +- Koha/{Tag.pm => Old/Item.pm} | 12 +- Koha/{ActionLogs.pm => Old/Items.pm} | 14 +- Koha/{Tags/Approval.pm => Old/Patron.pm} | 12 +- Koha/{ActionLogs.pm => Old/Patrons.pm} | 14 +- Koha/Patron.pm | 5 +- Koha/Patrons.pm | 8 +- Koha/REST/V1/Patrons.pm | 2 +- t/db_dependent/Koha/Objects.t | 344 +++++++++++++++++++- t/db_dependent/Koha/{KeyboardShortcuts.t => Old.t} | 40 ++- t/db_dependent/Koha/Patrons.t | 24 +- t/db_dependent/Virtualshelves.t | 4 +- 16 files changed, 429 insertions(+), 108 deletions(-) copy Koha/{Tags/Approval.pm => Old/Biblio.pm} (87%) copy Koha/{Tags/Approval.pm => Old/Biblioitem.pm} (85%) copy Koha/{ActionLogs.pm => Old/Biblioitems.pm} (81%) copy Koha/{ActionLogs.pm => Old/Biblios.pm} (81%) copy Koha/{Tag.pm => Old/Item.pm} (87%) copy Koha/{ActionLogs.pm => Old/Items.pm} (81%) copy Koha/{Tags/Approval.pm => Old/Patron.pm} (86%) copy Koha/{ActionLogs.pm => Old/Patrons.pm} (81%) copy t/db_dependent/Koha/{KeyboardShortcuts.t => Old.t} (58%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jan 3 14:30:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jan 2020 13:30:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-152-g642f738 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 642f7386924bc799f0855ecf7baff6197c1ffaa6 (commit) via 23bddb729dc2655958b6860c8f2d9f9872754ccf (commit) via 1072e364bd93419ead69c85222eb21d76a6b9060 (commit) via b91b53a10388446ace1907d41f1bbc1c2a8352a6 (commit) via 01cf725b990baf30b3f98406593eaa003b91862c (commit) via 3b25ea7c94b4b23632e2bb0971dd3cf3e7c4f5c7 (commit) via da620fdf91278d7a5d9d57ff75a2659565aa995d (commit) via fb36449fa9b1a43d3233fa58f3eeb09063edbe4b (commit) via 546a3b6d4d6333fe938572f0247dfcbe4a4d35a8 (commit) via 28b155ca1e33832f9aebc7aa6937fbe2f0e2f54c (commit) via f668fecec3771b633068f89dcead2312471f9425 (commit) via 13322855088ed073acce531742460e57e109ef0e (commit) via a998ba5714c8dc1b78062e95bd78e2738112737d (commit) via 8141ebbac6e65f7c76a9ec70ab7329564404b738 (commit) via 7c731050337afdcc509cdfb39fa31ed537b495ab (commit) via 59d5ada70e6abe7c9bdbf53450e5e7c11c9d3099 (commit) from 309754a143cb2f4ce1adc9b4bfeeca3e9af900a0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 642f7386924bc799f0855ecf7baff6197c1ffaa6 Author: Martin Renvoize Date: Fri Jan 3 13:05:39 2020 +0000 Bug 22284: DBRev 19.12.00.003 Signed-off-by: Martin Renvoize commit 23bddb729dc2655958b6860c8f2d9f9872754ccf Author: Tomas Cohen Arazi Date: Sat Dec 21 00:14:10 2019 -0300 Bug 22284: (QA follow-up) Make pickup locations be Koha::Library objects This patch makes the following methods return array references of Koha::Library objects instead or unblessed objects; - Koha::Item->pickup_locations - Koha::Biblio->pickup_locations - Koha::Libraries->pickup_locations Bonus: - The template plugin is adjusted to unbless things to keep behavior - Tests are moved to the right .t file. - Tests for the new behavior are added. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 1072e364bd93419ead69c85222eb21d76a6b9060 Author: Agustin Moyano Date: Wed Dec 18 14:50:31 2019 -0300 Bug 22284: (follow-up) Anotate boolean values in Koha::Schema::Result::LibraryGroup Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit b91b53a10388446ace1907d41f1bbc1c2a8352a6 Author: Josef Moravec Date: Wed Jul 3 22:29:42 2019 +0000 Bug 22284: Schema update Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 01cf725b990baf30b3f98406593eaa003b91862c Author: Agustin Moyano Date: Wed May 29 02:06:46 2019 -0300 Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations * Bug 22284: (follow-up) Fix tests * Bug 22284: (follow-up) Fix typo in request.tt * Bug 22284: (follow-up) Filter pickup on specific item click * Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 3b25ea7c94b4b23632e2bb0971dd3cf3e7c4f5c7 Author: Agustin Moyano Date: Mon May 27 23:49:05 2019 -0300 Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit da620fdf91278d7a5d9d57ff75a2659565aa995d Author: Agustin Moyano Date: Tue Apr 23 16:18:59 2019 -0300 Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Remove commented warn and address test failures * Bug 22284: (follow-up) fix test count after merge * Bug 22284: (follow-up) fixes after 15496 * Bug 22284: (follow-up) fixes after 18936 * Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit fb36449fa9b1a43d3233fa58f3eeb09063edbe4b Author: Agustin Moyano Date: Tue Apr 30 08:05:17 2019 -0300 Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 546a3b6d4d6333fe938572f0247dfcbe4a4d35a8 Author: Agustin Moyano Date: Thu Apr 4 01:10:16 2019 -0300 Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 28b155ca1e33832f9aebc7aa6937fbe2f0e2f54c Author: Agustin Moyano Date: Mon Apr 29 23:07:28 2019 -0300 Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit f668fecec3771b633068f89dcead2312471f9425 Author: Agustin Moyano Date: Fri Apr 12 10:32:48 2019 +0000 Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 13322855088ed073acce531742460e57e109ef0e Author: Agustin Moyano Date: Sun Mar 24 23:00:36 2019 -0300 Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit a998ba5714c8dc1b78062e95bd78e2738112737d Author: Agustin Moyano Date: Mon Mar 25 00:45:58 2019 -0300 Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 8141ebbac6e65f7c76a9ec70ab7329564404b738 Author: Agustin Moyano Date: Mon Mar 25 00:43:05 2019 -0300 Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 7c731050337afdcc509cdfb39fa31ed537b495ab Author: Agustin Moyano Date: Sun Mar 24 22:56:06 2019 -0300 Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 59d5ada70e6abe7c9bdbf53450e5e7c11c9d3099 Author: Agustin Moyano Date: Sun Mar 24 22:50:42 2019 -0300 Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 38 +- Koha.pm | 2 +- Koha/Biblio.pm | 27 ++ Koha/Item.pm | 57 ++- Koha/Libraries.pm | 33 +- Koha/Library.pm | 51 ++ Koha/Library/Groups.pm | 17 + Koha/Schema/Result/LibraryGroup.pm | 19 +- Koha/Template/Plugin/Branches.pm | 6 +- admin/library_groups.pl | 4 + installer/data/mysql/kohastructure.sql | 3 +- installer/data/mysql/updatedatabase.pl | 12 + .../intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- .../prog/en/modules/admin/library_groups.tt | 25 +- .../prog/en/modules/admin/smart-rules.tt | 54 ++- .../prog/en/modules/reserve/request.tt | 12 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 +- reserve/request.pl | 19 +- t/db_dependent/Holds.t | 490 +++++++++++++++++++- t/db_dependent/Koha/Biblio.t | 266 ++++++++++- t/db_dependent/Koha/Biblios.t | 2 + t/db_dependent/Koha/Item.t | 189 +++++++- t/db_dependent/Koha/Items.t | 4 +- t/db_dependent/Koha/Libraries.t | 130 ++++-- t/db_dependent/LibraryGroups.t | 21 +- 25 files changed, 1385 insertions(+), 102 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jan 3 17:13:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jan 2020 16:13:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-158-g6c9d6bf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6c9d6bf940beb67e1f226dffba0831fc234528fb (commit) via 4b1ced97ff98e4aeba23429beb7ded645551fc5b (commit) via d43b01ba1302fa99e7d8f396af5a3137333995e0 (commit) via 40bae6db38a4eb2d15ca9f7a1abfab46cc756239 (commit) via 6051f8686b58054446f26e2ba2e5c71bf2b53873 (commit) via 886c8c593dadc83d92d0d066a15861b3ad11e26a (commit) from 642f7386924bc799f0855ecf7baff6197c1ffaa6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c9d6bf940beb67e1f226dffba0831fc234528fb Author: Owen Leonard Date: Fri Nov 22 13:23:21 2019 +0000 Bug 24089: Upgrade jQuery Validate plugin in the staff client This patch upgrades the jQuery Validate plugin in the staff client from v1.10.0 to v1.19.1. To test, apply the patch and clear your browser cache if necessary. Test various pages to confirm that form validation works as expected: - Patron password change form: - Password must conform to minPasswordLength - Password must not contain leading/trailing spaces - Passwords must match - Administration -> Add or edit budget: - Description, start date, and end date are required - Start date must be before end date - Administration -> Add or edit Z39.50/SRU server: - Server name, hostname, port, and database are required - Port, rank, and timeout must be a number Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 4b1ced97ff98e4aeba23429beb7ded645551fc5b Author: Martin Renvoize Date: Fri Jan 3 15:44:09 2020 +0000 Bug 23957: Compiled CSS Signed-off-by: Martin Renvoize commit d43b01ba1302fa99e7d8f396af5a3137333995e0 Author: Owen Leonard Date: Tue Dec 10 13:36:19 2019 +0000 Bug 23957: (follow-up) Disable both place hold buttons This follow-up adds the correct markup to the second of two "Place hold" buttons so that it is disabled when the first is disabled. Signed-off-by: Martin Renvoize commit 40bae6db38a4eb2d15ca9f7a1abfab46cc756239 Author: Owen Leonard Date: Sun Nov 3 23:45:44 2019 +0000 Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. s are replaced with