[koha-commits] main Koha release repository branch master updated. v19.11.00-112-g93a0610

Thu Jan 2 14:10:16 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  93a06105a825e9ef585d7acb0b7cad319580dce5 (commit)
       via  52196919f22cb4e72dc61b670ea400f15c4a9cf6 (commit)
       via  4fe524c93f3ec882620c1c00d2338b3826a66f9e (commit)
       via  8111e4c116bbdcb5e03040e1c90ab48531eeaefb (commit)
       via  d6400a7024eceb8a234de78c23b9eac5f5674385 (commit)
       via  5e5e50ac177b4d29b24c58ce08516a08a0ced503 (commit)
       via  880fc53d741308ff8148d0be976009ee00896322 (commit)
       via  ffeda45d23c578bd36bf7ba3ca542bcab403fa23 (commit)
      from  91bf28ced90470addb6aee265cabf442fb645be8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 93a06105a825e9ef585d7acb0b7cad319580dce5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Nov 18 16:53:41 2019 +0100

    Bug 14973: Fix edit a suggestion and dup found

    The find duplicate call must only be done when the suggestion is new. It
    does not make sense to search for a duplicate when the suggestion
    already exists.

    This patch also fixes a side-effect:
    - Create a suggestion using an existing biblio title
    - Ignore the warning and save
    - Edit again and save
    => BOOM on date

    Template process failed: undef error - The given date (18/11/2019) does
    not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm
    line 168

    The dates are not processed and so badly formatted when sent to the
    template.

    Sponsored-by: BULAC - http://www.bulac.fr/
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 52196919f22cb4e72dc61b670ea400f15c4a9cf6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 6 17:25:57 2019 +0100

    Bug 14973: Add missing filters in templates

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4fe524c93f3ec882620c1c00d2338b3826a66f9e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 6 17:23:33 2019 +0100

    Bug 14973: Remove double declaration of suggestions_loop

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8111e4c116bbdcb5e03040e1c90ab48531eeaefb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 16 15:54:39 2019 +0200

    Bug 14973: Remove double textarea for notes

    Certainly a bad merge conflict resolution (I am certainly the one to
    blame).
    However I do not understand where this "note" variable come from.

    Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d6400a7024eceb8a234de78c23b9eac5f5674385
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 16 15:46:56 2019 +0200

    Bug 14973: Do not skip validation step when submiting a suggestion - OPAC

    Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5e5e50ac177b4d29b24c58ce08516a08a0ced503
Author: Alex Arnaud <alex.arnaud at biblibre.com>
Date:   Wed Mar 8 11:23:12 2017 +0000

    Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side)

    Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 880fc53d741308ff8148d0be976009ee00896322
Author: Alex Arnaud <alex.arnaud>
Date:   Wed Oct 7 17:34:33 2015 +0200

    Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side)

    Test plan:
    - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion",
    - type the title (and author?) of a document that stand in you database
    - you should get a warning message about an exiting biblio.
    - clicking on confirm your suggestion add it, cancel does nothing

    Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>
    Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ffeda45d23c578bd36bf7ba3ca542bcab403fa23
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Nov 2 00:19:33 2019 +0000

    Bug 23783: Show languages from MARC21 field 041 in OPAC

    This copies the changes made in bug 20364 for the staff
    interface to the OPAC.

    Some slight changes have been made in comparison:
    - OPAC uses the class "separator" for the characters
      that are used between repeatable tags. "sep" as
      used in the original patch set has some CSS rules
      attached to it that break display, so it makes
      double sense to change it.
    - We revently removed ending . from the display in
      OPAC - so it's done here too.

    To test:
    1) Apply patch
    2) Do a search in the OPAC and check the results look correct
    3) Check some biblio detail pages and verify that they look correct
    4) Add some 041 subfields (a, b, d, h, j) in any combinations
    5) Repeat 2 and 3

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Suggestions.pm                                  |   42 ++++++++
 .../prog/en/modules/suggestion/suggestion.tt       |   32 ++++++-
 .../bootstrap/en/modules/opac-suggestions.tt       |   52 ++++++----
 .../bootstrap}/en/xslt/MARC21Languages.xsl         |    0
 .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    |    2 +
 .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl   |    2 +
 .../bootstrap/en/xslt/MARC21slimUtils.xsl          |   52 ++++++++++
 opac/opac-suggestions.pl                           |   18 +++-
 suggestion/suggestion.pl                           |  100 ++++++++++++--------
 t/db_dependent/Suggestions.t                       |   20 +++-
 10 files changed, 258 insertions(+), 62 deletions(-)
 copy koha-tmpl/{intranet-tmpl/prog => opac-tmpl/bootstrap}/en/xslt/MARC21Languages.xsl (100%)

hooks/post-receive
-- 
main Koha release repository