[koha-commits] main Koha release repository branch master updated. v19.11.00-121-gf480ca8

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f480ca803ba9d4552678b3e326b3c19b9c6aec00 (commit)
       via  42cca4afc718dacd93bc66be50f82ca32006a164 (commit)
       via  7abb7350ef63cb81e87b2c07141e800ed542cc8a (commit)
       via  ac29b2029de81a24897f4fdfb88bdfddbb01c954 (commit)
       via  1887d0a8cc5554574ca05ccc40b892a838f2a690 (commit)
      from  ddfeea9c57e2af5b01e86b9790480f79f851044f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f480ca803ba9d4552678b3e326b3c19b9c6aec00
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Dec 20 07:14:32 2019 +0000

    Bug 24267: (QA follow-up) Remove two calls, add transaction
    
    Call to GetAuthorizedHeading is already done just before calling ImportBreedingAuth.
    Call to GuessAuthTypeCode is not used.
    Adding transaction to test (check your database, kidclamp ;)
    
    Test plan:
    Add new authority via Z3950 in the interface.
    Run t/db_dependent/Breeding.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 42cca4afc718dacd93bc66be50f82ca32006a164
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Dec 19 17:37:23 2019 +0000

    Bug 24267: Unit tests
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7abb7350ef63cb81e87b2c07141e800ed542cc8a
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Dec 18 18:27:33 2019 +0000

    Bug 24267: Improve ImportBreedingAuth
    
    git grep ImportBreedingAuth - there is only one call to this routine
    from SearchZ3950Auth
    
    We pass it a MARC record, '2' for overwrite_auth
    
    We then check for this record in the DB and get the breeding id,
    however, when overwrite_auth is 2 we always add the auth to the batch
    and return the new breeding id.
    
    We don't actually use any of the other parameters returned here either
    
    To recreate:
    1 - Browse to Authorities
    2 - Select New form Z3950
    3 - Perform a search that returns results
    4 - SELECT COUNT(*) FROM import_auths
    5 - Repeat the search
    6 - SELECT COUNT(*) FROM import_auths
    7 - There are 20 more records
    8 - SELECT * FROM import_auths - note the repeated rows
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ac29b2029de81a24897f4fdfb88bdfddbb01c954
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date:   Mon Dec 30 20:55:41 2019 -0300

    Bug 24316: (follow up) Fix es-ES web installer
    
    Same correction, as other languages, removing
    obsolete authorised value MANUAL_INV.
    
    Same test
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1887d0a8cc5554574ca05ccc40b892a838f2a690
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Dec 29 23:21:06 2019 +0100

    Bug 24316: Remove obsolete sample data for MANUAL_INV authorised value
    
    Bug 23049 replaced the MANUAL_INV authorised value by a dedicated table,
    but missed to remove the authorised value sample data from the non-English
    installers.
    
    This patch corrects this oversight.
    
    Note:
    The German (de-DE) file was changed a bit more, adding 2 missing translations
    for the new RETURN_CLAIM_RESOLUTION and to match the sequence of the en
    file.
    
    To test:
    - Verify the SQL file changes are valid by loading those files OR
    - Run the installers for each language on an empty database
    - Verify there is no error loading the optional authorised value data
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    Tested with 24317 and a small followup for this bug for es-ES
    
    Tested doing clean install for de-DE es-ES fr-CA it-IT nb-NO pl-PL
    up to loading of all mandatory & optional data.
    All languages load without problems.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Breeding.pm                                     |   67 ++++----------------
 installer/data/mysql/de-DE/optional/auth_val.sql   |   21 +++---
 installer/data/mysql/es-ES/optional/auth_val.sql   |    3 -
 installer/data/mysql/fr-CA/facultatif/auth_val.sql |    3 -
 installer/data/mysql/it-IT/necessari/auth_val.sql  |    3 -
 .../data/mysql/nb-NO/2-Valgfritt/auth_val.sql      |    3 -
 installer/data/mysql/pl-PL/optional/auth_val.sql   |    3 -
 t/db_dependent/Breeding.t                          |   45 ++++++++++---
 8 files changed, 58 insertions(+), 90 deletions(-)


hooks/post-receive
-- 
main Koha release repository