[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.01-24-g9726076

Sat Jan 4 00:01:26 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  972607628e0b67edf3dbd9536e7aafb5007a7e8f (commit)
       via  a7e5c5cfd17ca02c3b1c821bb458831b9a2494db (commit)
       via  866b81ae18be5f0f257a05229920268c4ca8895c (commit)
       via  964835927cdcd0a08d4f3da5733bb7b915e9f9e7 (commit)
       via  9a860bbf43600feea51aada5a3c45c3bf9df22f3 (commit)
       via  3d9e1e4603a1371d44868c42f4b7a29c58b5c20f (commit)
      from  f74f76169cf849b0155bf395a930f71649a0a749 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 972607628e0b67edf3dbd9536e7aafb5007a7e8f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 18 09:46:51 2019 +0100

    Bug 24232: Hide the "Delete biblio" if permission edit_catalogue not set

    The script moveitem.pl requires editcatalogue => 'edit_items', the
    deletion of a biblio editcatalogue => edit_catalogue. Even if weird I
    guess we could have a librarian with edit_items but edit_catalogue.

    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit a7e5c5cfd17ca02c3b1c821bb458831b9a2494db
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Dec 17 14:43:54 2019 -0300

    Bug 24232: Fix required permissions in DELETE /biblios/:biblio_id

    This patch fixes the required permissions defined on the spec for the
    mentioned endpoint.

    To test:
    1. Apply the tests patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/api/v1/biblios.t
    => FAIL: Tests fail due to badly defined permissions
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests pass! Notice parameters: edit_catelogue didn't exist
    5. Sign off :-D

    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 866b81ae18be5f0f257a05229920268c4ca8895c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Dec 17 14:38:41 2019 -0300

    Bug 24232: Regression tests

    This patch enhances the tests for the DELETE /biblios/:biblio_id
    endpoint so more fine grained permissions are tested.

    It highlights the fact that the required permissions defined on the spec
    are not correcttly defined.

    To test:
    1. Run:
       $ kshell
      k$ prove t/db_dependent/api/v1/biblios.t
    => FAIL: Tests fail because the user (that now has subpermissions only)
    does not have enough permissions for a non-existent subpermission

    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 964835927cdcd0a08d4f3da5733bb7b915e9f9e7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Dec 19 07:41:11 2019 +0100

    Bug 24169: Add a comment to clarify the use of the dataTable class

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 9a860bbf43600feea51aada5a3c45c3bf9df22f3
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Dec 17 15:53:38 2019 +0000

    Bug 24169: Advanced editor: icons/buttons for sorting the search results are missing

    This patch "manually" adds the "dataTable" class to the table of search
    results in the advanced cataloging editor. This allows the correct
    styles to get picked up from existing CSS.

    To test, go to Cataloging and open the advanced editor. Perform a search
    using the sidebar search form. In the table of results, confirm that
    table sorting indicators look correct and that sorting works correctly.

    Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 3d9e1e4603a1371d44868c42f4b7a29c58b5c20f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 18 10:50:43 2019 +0100

    Bug 24259: Handle non existing default circ rule in Charges::Fees

    Can't call method "lengthunit" on an undefined value at
    /usr/share/koha/lib/Koha/Charges/Fees.pm line 101.

    Test plan:
    1 - Remove all/all rule form circulation rules
    2 - Define a rental fee per day for an itemtype
    3 - Checkout an item of this type ot patron
    4 - Should get note of no circ rule defined
    5 - Confirm the checkout
    => item is checked out

    Signed-off-by: hc <hc at interleaf.ie>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Charges/Fees.pm                               |    2 ++
 api/v1/swagger/paths/biblios.json                  |    2 +-
 .../prog/en/modules/cataloguing/editor.tt          |    2 +-
 .../prog/en/modules/cataloguing/moveitem.tt        |    2 +-
 t/db_dependent/api/v1/biblios.t                    |   20 ++++++++++++++++++--
 5 files changed, 23 insertions(+), 5 deletions(-)

hooks/post-receive
-- 
main Koha release repository