[koha-commits] main Koha release repository branch master updated. v19.11.00-179-g094f062
Git repo owner
gitmaster at git.koha-community.org
Tue Jan 7 15:25:07 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 094f0623c2c740aa2be5fb6364694b88442e03cf (commit)
via 60e5f77770e45be9af2b1408a7a08a107e4fd835 (commit)
from af50ec6e5fa1f9d415af6b8655c927a20b86b705 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 094f0623c2c740aa2be5fb6364694b88442e03cf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 7 12:26:01 2020 +0100
Bug 24361: (bug 24217 follow-up) Fix several warnings in C4 modules
With bug 24217 pushed, lot of warnings appears during the tests are run.
Most of them are "Use of uninitialized value in "
Test plan:
Take a look at the output of run 1049
https://jenkins.koha-community.org/job/Koha_Master_D9/1049/consoleFull
Most of the warnings from this run will be removed by this patch
At least 2 are not fixed:
Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 791.
t/db_dependent/Items_DelItemCheck.t => see 23463
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 60e5f77770e45be9af2b1408a7a08a107e4fd835
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 7 12:26:01 2020 +0100
Bug 24361: Fix warning in C4::Record line 435
Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Record.pm line 435
Caught by a failing test:
# Failed test 'Export csv with wrong marcxml should raise a warning'
# at t/db_dependent/Exporter/Record.t line 113.
# found warning: problem with :721 : :1: parser error : Start tag expected, '<' not found
# found warning: Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Record.pm line 435.
# expected to find warning: (?^u:.*Start tag expected.*)
Test plan:
Make sure the tests pass now
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Budgets.pm | 36 +++++++++++++++++++-----------------
C4/Circulation.pm | 21 +++++++++++----------
C4/Items.pm | 16 +++++++++-------
C4/Koha.pm | 2 +-
C4/Overdues.pm | 6 +++---
C4/Record.pm | 6 +++---
C4/Reserves.pm | 16 ++++++++++------
C4/Serials.pm | 2 +-
Koha/Plugins/Base.pm | 2 +-
9 files changed, 58 insertions(+), 49 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list