[koha-commits] main Koha release repository branch master updated. v19.11.00-260-g909caec

Fri Jan 10 10:03:42 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  909caec446b936023158fe99aa8ecf56e775cb6d (commit)
       via  b96b3eceef2b4db3ae88c26f8096f8f2925228ae (commit)
       via  3d99d21a2fe48609902849352ef7eb7acc1e58a8 (commit)
       via  602d9c836bd92ccf5e64915ee113632bc690c1b9 (commit)
       via  3015fc1bae473d897b232cca7625413db8c221eb (commit)
       via  c121a53dd73b506e4405356cbd1a540ac882176b (commit)
       via  7df88be2a47f0163c4f1a1e0a8dcd57ae91fdb7d (commit)
       via  5b8a582b0572517e8b02f42963db76caca5aadcd (commit)
       via  0b619db20d5341fa9c907a8623484b4c97917751 (commit)
       via  75b2586cb7ecaa48ae88598850019e22542c4a5b (commit)
       via  b6872ccbd52ee3e7b5b7e30b0a120f83b365e85a (commit)
       via  a4f8daacb9e49ce5ddf2c3cd0a72a03214580a09 (commit)
       via  e0f22d36c675d171e890536f77d2e117a5d80540 (commit)
       via  5029ed9bd2b248d123b30ec7a02bbbb5ae1203e5 (commit)
       via  7f506d4163e02b2e384d75723ee753acce7544d2 (commit)
      from  96ab49823291d441fd43ed0cbef242f7beb58d37 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 909caec446b936023158fe99aa8ecf56e775cb6d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Dec 13 17:08:58 2019 +0000

    Bug 10352: Get add operations too

    When an add for biblio or item is recorded there is no space in the info field

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b96b3eceef2b4db3ae88c26f8096f8f2925228ae
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Nov 25 12:09:45 2019 +0000

    Bug 10352: (follow-up) Show the biblionumber for items in modification logs

    This patch adds a link to the the biblio that shows the biblionumber of the item. It makes things a little more obvious

    To test:
    1 - Find a biblio with an item where an itemnumber on another biblio is equal to that biblionumber
       i.e. In the sample data:
            biblionumber 59 with item with itemnumber 127
            item with itemnumber  59 on biblionumber 23
    2 - Edit both items however you wish
    3 - On biblionumber 59 click the modification log
    4 - You should see "Item 127"
    5 - Click "Submit" on the form - this searches as itemnumber
    6 - You should see "Item 59"
    7 - Apply patch
    8 - On biblionumber 59 click the modification log
    9 - You should see "Item 127 from Biblio 59"
    10 - Click "Submit" on the form - this searches as itemnumber
    11 - You should see "Item 59 from Biblio 23"

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3d99d21a2fe48609902849352ef7eb7acc1e58a8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Nov 25 11:28:40 2019 +0100

    Bug 10352: Use a new object_type parameter instead of the module's name

    To dissociate a search on biblio and item, we pass a new "object_type"
    parameter to viewlog.pl. If equals 'biblio' we will assume that "object"
    contains a biblionumber

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 602d9c836bd92ccf5e64915ee113632bc690c1b9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 13 10:36:14 2019 -0500

    Bug 10352: Display the correct modification logs for bibliographic records

    The 'Modification log" link in the cataloguing module returns confusing
    results. The 'object' parameter is the biblionumber, but the all log
    from itemnumber=biblionumber will be displayed as well.
    Since bug 11473 we have the action_logs.info column that is prefixed by
    'item ' or 'biblio ' to disociated an item modification from a biblio
    modif.
    This patch suggests a quick and dirty approach, use this column to make
    sure we are searching for the correct logs.
    /!\ As bug 11473 did not update the existing rows, we will no longer display
    the logs created prior to this change.

    Test plan:
    Make sure you have at least 2 bibliographic records with some items
    Make sure you have the biblionumbers of those records that match
    existing itemnumbers
    Edit them (no matter what you change)
    Go to the bibliographic detail page (staff) and click "Modification log"
    You should see the correct changes.

    Signed-off-by: hc <hc at interleaf.ie>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3015fc1bae473d897b232cca7625413db8c221eb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Dec 27 14:55:36 2019 +0100

    Bug 24313: Always display XSLT errors in logs

    From
      commit 295ae33800a322facfdf56795f4c02b2fd53432b
      Bug 20272: Replace error numbers by codes in XSLT_Handler

    """
        Make XSLT_Handler a little bit less noisy by defaulting print_warns to
        false unless $ENV{DEBUG} is set. (See also bug 19018).
    """

    I think we should warn the errors in the logs. They are not debug messages here, we should not rely on DEBUG.
    If too noisy we should fix the original issues, not hide all the errors (which make the XSLT debugging super hard)

    Test plan:
    Break a XSLT, reload the page and confirm that there are useful errors in the Koha log file

    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c121a53dd73b506e4405356cbd1a540ac882176b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Dec 10 15:24:36 2019 +0100

    Bug 24123: Fix import of UTF-8 encoded MARC21 MARCXML using bulkmarcimport (elastic only)

    If elastic is used as search engine, the bulkmarcimport.pl will not
    handle correctly UTF-8 encoded MARCXML

    Koha::SearchEngine::Search->new uses a require statement to load the correct Search module.
    This is done l.257 of bulkmarcimport.pl:
      257 my $searcher = Koha::SearchEngine::Search->new

    Koha::SearchEngine::Elasticsearch::Search will `use MARC::File::XML`, and so resets the arguments set before:
      216     $MARC::File::XML::_load_args{BinaryEncoding} = 'utf-8';

      220     $MARC::File::XML::_load_args{RecordFormat} = $recordformat;

    An easy (but dirty) fix could be to move the declaration of my $searcher before in the script.
    The tricky (but correct) fix would be to remove the long standing "ugly hack follows" comment.

    This patch is the easy, and dirty, fix

    Test plan:
    Use the command line tool to import MARXCML records that contains unicode characters into Koha

    Something like `misc/migration_tools/bulkmarcimport.pl -biblios -file record.marcxml -m=MARCXML`

    Without this patch you will notice that unicode characters will not be displayed correctly

    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7df88be2a47f0163c4f1a1e0a8dcd57ae91fdb7d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Dec 2 09:22:31 2019 +0000

    Bug 23974: Add test descriptions

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5b8a582b0572517e8b02f42963db76caca5aadcd
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Dec 2 09:00:18 2019 +0000

    Bug 23974: Add tests for issue on closed day

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0b619db20d5341fa9c907a8623484b4c97917751
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Nov 29 17:09:06 2019 +0000

    Bug 23974: Test Notes

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 75b2586cb7ecaa48ae88598850019e22542c4a5b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Nov 29 16:44:45 2019 +0000

    Bug 23974: Add POD for hours_between

    Add a bit of missing POD whilst we're working in here

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b6872ccbd52ee3e7b5b7e30b0a120f83b365e85a
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Nov 8 13:37:17 2019 +0000

    Bug 23974: (follow-up) Add same day loan tests

    Hourly loans can be short enough to not cross a day boundary and as such
    we should test for that scenario in the hour_between tests too.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a4f8daacb9e49ce5ddf2c3cd0a72a03214580a09
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Nov 5 17:44:36 2019 +0100

    Bug 23974: Both methods should have the same logic/construction

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e0f22d36c675d171e890536f77d2e117a5d80540
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Nov 5 17:13:53 2019 +0100

    Bug 23974: Add tests for days_between

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5029ed9bd2b248d123b30ec7a02bbbb5ae1203e5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Nov 5 16:23:00 2019 +0100

    Bug 23974: Add new tests for hours_between

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7f506d4163e02b2e384d75723ee753acce7544d2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Nov 5 15:18:38 2019 +0100

    Bug 23974: Improve readability

    This patch does not change anything, just a bit of cleaning

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Calendar.pm                                   |   34 ++-
 Koha/XSLT_Handler.pm                               |    4 +-
 .../prog/en/includes/biblio-view-menu.inc          |    2 +-
 .../intranet-tmpl/prog/en/modules/tools/viewlog.tt |    3 +-
 misc/migration_tools/bulkmarcimport.pl             |   21 +-
 t/db_dependent/Calendar.t                          |  271 +++++++++++++++++---
 tools/viewlog.pl                                   |   16 +-
 7 files changed, 291 insertions(+), 60 deletions(-)

hooks/post-receive
-- 
main Koha release repository