[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.06-28-gf2462e9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  f2462e9216cad2bdbe8e383125b5a6d5ed81d406 (commit)
      from  54283ced77f27d375a27efa1d78e935fca90c462 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f2462e9216cad2bdbe8e383125b5a6d5ed81d406
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Jul 2 11:58:49 2019 +0000

    Bug 14419: [19.05.x] (squashed) Expanding facets (Show more) performs a new search
    
    This patch removes the constraint of only passing 5 facets to the template unless the list is expanded, in fact, it removes the 'expanded' attribute from Search.pm
    Now that all facets are passed to page it adds a 'show more' link at the bottom of lists and allows user to expand or collapse any facet set without reloading page.
    
    Updated tests included.
    
    To test:
    1  - Perform an OPAC search that returns more than 5 of any given facet type
    2  - Click the "Show more" link on the facets and see that the search is reloaded
    3  - Apply patch
    4  - Repeat search
    5  - Note that you can click "Show more" without reloading page
    6  - Test that page load is not greatly affected
    7  - Ensure that all facet links function normally
    8  - Ensure that facets are the same a prior to patch
    9  - Repeat for staff client
    10 - Prove t/Search.t
    
    NOTE: This patch makes it much easier to see that there is an existing issue with marking the "active" facet.  Ending punctuation seems to confuse the matcher.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Bug 14419: (QA follow-up) Restore the link styling
    
    Test plan:
    Look at Show more/less links in facets, in opac and staff client
    --> without this patch they are pure text, no styling, no hand cursor
    --> with this patch it is link, but continues to work as before
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Search.pm                                       |  161 +++++++++-----------
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    |   21 ++-
 Koha/SearchEngine/Elasticsearch/Search.pm          |   21 +--
 catalogue/search.pl                                |    5 +-
 .../intranet-tmpl/prog/en/includes/facets.inc      |   13 +-
 .../prog/en/modules/catalogue/results.tt           |    8 +
 .../bootstrap/en/includes/opac-facets.inc          |   13 +-
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |    8 +
 opac/opac-detail.pl                                |    3 +-
 opac/opac-search.pl                                |    6 +-
 .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t |    7 +-
 t/db_dependent/Search.t                            |  133 +++++++---------
 12 files changed, 192 insertions(+), 207 deletions(-)


hooks/post-receive
-- 
main Koha release repository