[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.01-43-g2e11fc4

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  2e11fc4ef9087ee9f28fd12ae80eff74e604b9a5 (commit)
       via  1923502ff73b225f2d32c989659714f1434f9f0f (commit)
      from  d2e1034084c9310498607e1d5e4156c40d7b2245 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2e11fc4ef9087ee9f28fd12ae80eff74e604b9a5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Dec 22 13:30:02 2019 +0000

    Bug 24208: (follow-up) Change page title from payment to writeoff
    
    This makes a change requested by the first tester:
    Also change the page title when a writeoff is done vs
    a payment.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1923502ff73b225f2d32c989659714f1434f9f0f
Author: Maryse Simard <maryse.simard at inlibro.com>
Date:   Tue Dec 10 13:58:45 2019 -0500

    Bug 24208: Remove change calculation for writeoffs
    
    Bug 11373 added change calculation to the payment page.
    
    This doesn't work very well in the case of writeoffs:
        - The "Amount paid" and "Change to give" fields don't make much
        sense in the case of writeoffs.
        - The amount for a partial writeoff has to be entered in the
        "Amount paid" field instead of the one labeled "Writeoff amount"
        just underneath.
    
    This patch removes these unwanted fields and use the "Writeoff amount"
    label on the right input.
    
    Test plan:
    1) Choose a patron who has fees.
        You can add a manual invoice if necessary.
    2) Go to Accounting > Make a payment.
    3) Select some fines and click "Write off selected".
    4) Note the form has a lot of inputs, not all are necessary for a
    writeoff.
    5) Make a partial writeoff by entering a different amount in the
    "Writeoff amount" field.
        => The amount written off is the amount entered in the "Amount
        paid" field.
    6) Apply patch.
    7) Repeat steps 1-3.
    8) Notice the form only has "Amount outstanding", "Writeoff amount"
    and "Note" fields, which are enough for a writeoff.
    9) Entering any amount lower than or equal to the amount outstanding
    in the "Writeoff amount" field should create a writeoff of the selected
    amount.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/members/paycollect.tt          |   36 ++++++++++++--------
 1 file changed, 21 insertions(+), 15 deletions(-)


hooks/post-receive
-- 
main Koha release repository