[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.06-32-g4a059f2

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  4a059f220cdddec4f992101d38a8264714b701dd (commit)
       via  9f312ebc91834dcf9a0355c2bf5704047786e35a (commit)
       via  9c03f710221a4d17ee6e861fc0f3b3507716d249 (commit)
       via  7be05a35debeaca73ddc1b3fe810d6213dd57d93 (commit)
      from  f2462e9216cad2bdbe8e383125b5a6d5ed81d406 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4a059f220cdddec4f992101d38a8264714b701dd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 6 23:08:55 2020 +0100

    Bug 24358: (bug 21232) Make the alert string translatable
    
    "Bibliographic record does not exist!" was not translatable as it was
    defined in the .js file
    
    Test plan:
    Repeat test plan from bug 21232
    
    Bonus point: update and install a localized version and confirm that the
    message is translatable
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit c86882f2aefe3bf2e567dbf59f5ca2d396351cf4)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 9f312ebc91834dcf9a0355c2bf5704047786e35a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Dec 13 12:41:20 2019 +0100

    Bug 21232: Add a client-side check on biblionumber when creating a subscription
    
    This patch adds an AJAX call to the REST API (/api/v1/biblios/) to
    retrieve and display the biblio's title.
    On clicking the "next" button a check is done to make sure the title
    exists, which means the biblionumber we manually entered is valid (can
    we assume a title is mandatory?)
    
    Test plan:
    - Create or edit a new subscription
    - Enter an invalid biblionumber in the input
    => A friendly note is telling you that the biblio does not exist
    - Try to switch to the next screen
    => You get an alert
    - Enter a valid biblionumber in the input
    => The title is displayed
    => Try to switch to the next screen
    => It works!
    
    Signed-off-by: hc <hc at interleaf.ie>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 90374dacb97a69d5774234cedeeb7d741232cb53)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 9c03f710221a4d17ee6e861fc0f3b3507716d249
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Dec 17 14:43:54 2019 -0300

    Bug 24232: Fix required permissions in DELETE /biblios/:biblio_id
    
    This patch fixes the required permissions defined on the spec for the
    mentioned endpoint.
    
    To test:
    1. Apply the tests patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/api/v1/biblios.t
    => FAIL: Tests fail due to badly defined permissions
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests pass! Notice parameters: edit_catelogue didn't exist
    5. Sign off :-D
    
    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit a7e5c5cfd17ca02c3b1c821bb458831b9a2494db)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 7be05a35debeaca73ddc1b3fe810d6213dd57d93
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Dec 17 14:38:41 2019 -0300

    Bug 24232: Regression tests
    
    This patch enhances the tests for the DELETE /biblios/:biblio_id
    endpoint so more fine grained permissions are tested.
    
    It highlights the fact that the required permissions defined on the spec
    are not correcttly defined.
    
    To test:
    1. Run:
       $ kshell
      k$ prove t/db_dependent/api/v1/biblios.t
    => FAIL: Tests fail because the user (that now has subpermissions only)
    does not have enough permissions for a non-existent subpermission
    
    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 866b81ae18be5f0f257a05229920268c4ca8895c)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 api/v1/swagger/paths/biblios.json                  |    2 +-
 .../prog/en/modules/serials/subscription-add.tt    |    2 ++
 .../intranet-tmpl/prog/js/subscription-add.js      |   32 ++++++++++++++++++--
 t/db_dependent/api/v1/biblios.t                    |   20 ++++++++++--
 4 files changed, 50 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository