[koha-commits] main Koha release repository branch master updated. v19.11.00-346-gfd35064
Git repo owner
gitmaster at git.koha-community.org
Tue Jan 14 15:37:54 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via fd3506465737a388679b905b73d8310f7014ba1d (commit)
via 52bb48ab4500a5bf507e0a3083710dfeeec52f4b (commit)
via 52d3b5439ddf5efd374749548a523a4a8e7ccd8a (commit)
via 0d634ca43057f679009294bb11931f831914fff9 (commit)
from 9c07a433a188ea72814d9efb91c63835b4a60dd6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit fd3506465737a388679b905b73d8310f7014ba1d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jan 13 16:45:58 2020 -0300
Bug 24366: Make sure accessors are used on the right object
This patch makes the Koha::Biblio->to_api method try the accessors on
$self first, and fallback to $self->biblioitem on those he can't.
This way it won't happen that (for example) ->holds will be tried
against ->biblioitem.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 52bb48ab4500a5bf507e0a3083710dfeeec52f4b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 13 15:16:20 2020 +0100
Bug 24366: Improve hashref construction
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 52d3b5439ddf5efd374749548a523a4a8e7ccd8a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 7 14:41:50 2020 -0300
Bug 24366: Merge biblioitem in Koha::Biblio->to_api
This patch moves the bilbioitem object merge into the
Koha::Biblio->to_api method, as opposed to doing it in the controller.
This is an inevitable change as other endpoints might require to embed
biblio objects, and they need to carry the biblioitem information.
Also, if we merge the tables, the transition will be straightforward
(remove the tests this patch introduces, and merge the mappings from
Koha::Biblioitem into Koha::Biblio).
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Biblio.t \
t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass! i.e. the new to_api method is tested, and the
API tests don't expect any behavior change.
3. Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0d634ca43057f679009294bb11931f831914fff9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 7 14:45:41 2020 -0300
Bug 24366: Unit tests
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/Biblio.pm | 27 +++++++++++++++++++++++++++
Koha/Biblioitem.pm | 1 +
Koha/REST/V1/Biblios.pm | 25 +------------------------
t/db_dependent/Koha/Biblio.t | 24 +++++++++++++++++++++++-
4 files changed, 52 insertions(+), 25 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list