[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.01-87-gd6f70a7619

Wed Jan 15 01:43:47 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  d6f70a76192182f30627e86405eca69655ec6397 (commit)
       via  0b7f70c2d5712460aef44ba35838d5a88cf25598 (commit)
       via  567da67606f82a720ea4ec074f7fe47a4b9d8ddf (commit)
       via  23b7cc37626a90ee596e24f5439f1739ee739727 (commit)
       via  723fb3ac415551d3c9049500c6e2efe9d44f4096 (commit)
       via  aa5418dca6ae20e70e92ecf662a1f5b83c86cd3e (commit)
       via  dc769fd06577e54695cee11a0de917d6fb4c8569 (commit)
       via  5476e77021e8abd0c733780bb825938a7608ff76 (commit)
      from  a3ace8143a601f8f546f9384affbba55b77fa8b6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d6f70a76192182f30627e86405eca69655ec6397
Author: Joy Nelson <joy at bywatersolutions.com>
Date:   Wed Jan 15 00:18:59 2020 +0000

    Bug 23233: DBRev 19.11.01.001

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 0b7f70c2d5712460aef44ba35838d5a88cf25598
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Dec 17 09:07:44 2019 +0000

    Bug 23233: (RM follow-up) Rename syspref in test

    The AllowItemsOnHoldCheckout system preference was renamed to
    AllowItemsOnHoldCheckoutSIP to clarify it's use, but one case was missed
    in the test suit.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 567da67606f82a720ea4ec074f7fe47a4b9d8ddf
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date:   Tue Oct 22 11:20:39 2019 +0000

    Bug 23233: (follow-up) Correct test description

    AllowItemsOnHoldCheckout is not checked anymore but instead only
    whether the tmp_holdsqueue is empty or not.

    Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 23b7cc37626a90ee596e24f5439f1739ee739727
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date:   Tue Oct 22 11:04:48 2019 +0000

    Bug 23233: (follow-up) Add description to atomic upgrade

    Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 723fb3ac415551d3c9049500c6e2efe9d44f4096
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date:   Tue Oct 22 11:00:51 2019 +0000

    Bug 23233: (follow-up) Remove accidentally left comment

    The line

    t::lib::Mocks::mock_preference( 'AllowItemsOnHoldCheckout', 0 );

    was removed from below this comment line but the comment explaining
    what it does was forgotten.

    Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit aa5418dca6ae20e70e92ecf662a1f5b83c86cd3e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Jul 1 08:56:09 2019 -0400

    Bug 23233: Remove use of AllowItemsOnHoldCheckout from C4::Items::GetItemsInfo

    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit dc769fd06577e54695cee11a0de917d6fb4c8569
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Jul 1 07:19:33 2019 -0400

    Bug 23233: Remove use of AllowItemsOnHoldCheckout from Koha::Item::has_pending_hold, it can cause false data to be returned

    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 5476e77021e8abd0c733780bb825938a7608ff76
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Jun 28 14:07:39 2019 -0400

    Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only

    The system preference AllowItemsOnHoldCheckout only affects SIP based checkouts. I believe we should rename it AllowItemsOnHoldCheckoutSIP so it matches AllowItemsOnHoldCheckoutSCO. We should also update the description as well.

    As far as I know AllowItemsOnHoldCheckout has never affected anything except SIP traffic. That does not preclude the addition of another AllowItemsOnHoldCheckout syspref that would affect the staff interface, but that would be an enhancement and is outside the scope of this bug report.

    Test Plan:
    1) Test AllowItemsOnHoldCheckout via SIP
    2) Apply this patch
    3) Test AllowItemsOnHoldCheckoutSIP via SIP
    4) Note there is no difference!
    5) Note the syspref description has been update to mention SIP

    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Items.pm                                                  |  9 +++------
 C4/SIP/ILS/Transaction/Checkout.pm                           |  2 +-
 C4/UsageStats.pm                                             |  2 +-
 Koha.pm                                                      |  2 +-
 Koha/Item.pm                                                 |  2 +-
 installer/data/mysql/sysprefs.sql                            |  2 +-
 installer/data/mysql/updatedatabase.pl                       |  7 +++++++
 .../prog/en/modules/admin/preferences/circulation.pref       |  6 ++++--
 t/db_dependent/Items.t                                       | 12 +++++-------
 t/db_dependent/Koha/Item.t                                   |  7 +------
 t/db_dependent/UsageStats.t                                  |  2 +-
 11 files changed, 26 insertions(+), 27 deletions(-)

hooks/post-receive
-- 
main Koha release repository