[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.06-57-gba1e7c42e0

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  ba1e7c42e067edab45d12e5a7c4940ef2b1d2e11 (commit)
       via  ff114d6bfa020eadbcfedf3f0591e1aba8bd63e9 (commit)
       via  42f423675a3989b88717d085c4ae760b612c8090 (commit)
      from  d83c15422040b6ceb2b02ea203de3b803a107353 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ba1e7c42e067edab45d12e5a7c4940ef2b1d2e11
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Dec 20 07:14:32 2019 +0000

    Bug 24267: (QA follow-up) Remove two calls, add transaction
    
    Call to GetAuthorizedHeading is already done just before calling ImportBreedingAuth.
    Call to GuessAuthTypeCode is not used.
    Adding transaction to test (check your database, kidclamp ;)
    
    Test plan:
    Add new authority via Z3950 in the interface.
    Run t/db_dependent/Breeding.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit a73cb7ec6f2cb5bb52fb1acd605e3385002e7ea2)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit ff114d6bfa020eadbcfedf3f0591e1aba8bd63e9
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Dec 19 17:37:23 2019 +0000

    Bug 24267: Unit tests
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 1d457f370cd4a7d8b614549f69d850d48b07caf9)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 42f423675a3989b88717d085c4ae760b612c8090
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Dec 18 18:27:33 2019 +0000

    Bug 24267: Improve ImportBreedingAuth
    
    git grep ImportBreedingAuth - there is only one call to this routine
    from SearchZ3950Auth
    
    We pass it a MARC record, '2' for overwrite_auth
    
    We then check for this record in the DB and get the breeding id,
    however, when overwrite_auth is 2 we always add the auth to the batch
    and return the new breeding id.
    
    We don't actually use any of the other parameters returned here either
    
    To recreate:
    1 - Browse to Authorities
    2 - Select New form Z3950
    3 - Perform a search that returns results
    4 - SELECT COUNT(*) FROM import_auths
    5 - Repeat the search
    6 - SELECT COUNT(*) FROM import_auths
    7 - There are 20 more records
    8 - SELECT * FROM import_auths - note the repeated rows
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit dcb7e9cb50c18a113472d5cd8405ba082bce6ec2)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Breeding.pm            | 67 +++++++++--------------------------------------
 t/db_dependent/Breeding.t | 45 +++++++++++++++++++++++++------
 2 files changed, 49 insertions(+), 63 deletions(-)


hooks/post-receive
-- 
main Koha release repository