[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.06-85-gd2466f90a5

Fri Jan 17 17:32:15 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  d2466f90a5d9aa5f600acd1fa584af3499ba3df0 (commit)
       via  21b9c0b4d13757f1ce2a0119aba7630002e420b7 (commit)
       via  2419a083fd2f50898ff199fbdb437155e08cef9d (commit)
       via  56a1c93ffc471dc7832a20d81fe0034128823b03 (commit)
       via  cb4bbdda5d6cbb634d92fee2c09c52097943a8b6 (commit)
       via  34965273b1854b6cf645f3b53fc6f304922e0c01 (commit)
       via  f34f979aee256eab8d1480729eb7a2f4ad3f2e7c (commit)
       via  4301f8327877e7897bb4917d3e816884e0657538 (commit)
       via  7dbad8e210ab18e2323e8557e50680832a54cdce (commit)
       via  9744690da41ba2977805806c937ebd3714a1d131 (commit)
       via  846bab1a7cde25d0921fbcc5f9395b03757849b3 (commit)
       via  c43904e75858512e89c7c772f13f48568802ffe5 (commit)
       via  b87e863b353fff0f0ed3fd176812086349aa6bdd (commit)
      from  0332b4842b66e8de8792f19420879f393a8ffa6b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d2466f90a5d9aa5f600acd1fa584af3499ba3df0
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Fri Jan 17 15:09:04 2020 +0000

    Bug 23382: (follow-up) Fix typo

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 21b9c0b4d13757f1ce2a0119aba7630002e420b7
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Oct 28 12:18:04 2019 +0000

    Bug 23382: (RM follow-up) Days of the week discrepancies

    DateTime and C4::Calander have different notions of 'days of the week'.

    DateTime days go from 1..7 (Mon..Sun) whilst C4::Calendar expects 0..6
    (Sun..Sat).  This patch adapts the holday setting in the tests to ensure
    we work when testing Saturdays and Sundays.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 1823316503331bcfffbf1e96528f53b66a8893b7)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 2419a083fd2f50898ff199fbdb437155e08cef9d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 25 15:28:49 2019 +0200

    Bug 23382: Use floating time zone to prevent tests to fail because of DST

    Today Friday Oct 25th, DST next Sunday => Date math are wrong, 96 hours
    diff becomes 95.
    To avoid that we use the floating timezone

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d4af82d411613f4d12d5e3e31de399aa43355cb4)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 56a1c93ffc471dc7832a20d81fe0034128823b03
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Oct 25 11:29:58 2019 +0100

    Bug 23382: (follow-up) Ensure closed day is inside charge window

    We're testing with an hourly loan of 96 hours to catch a closed day.
    However, our closed day was hard coded to be a Wednesday so if you ran
    the tests on a Friday the 96 hour loan would not catch a Wednesday.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a5bf7b1e558ea38998d4661f074e99d028178c96)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit cb4bbdda5d6cbb634d92fee2c09c52097943a8b6
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Oct 16 13:10:43 2019 +0100

    Bug 23382: hours_between should match the logic of days_between

    The loops for subtraction holiday dates in hours_between and
    days_between differed and as such their handling of start and end
    boundaries for days also differed.  This patch makes them handle the
    boundary days consistently.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a693c7243c23f888e2fad38a4fff9f37ff4a9301)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 34965273b1854b6cf645f3b53fc6f304922e0c01
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Oct 16 13:08:23 2019 +0100

    Bug 23382: Truncate dates to minutes for comparison.

    It's somewhat of a mess in C4::Circulation as to when dates are
    truncated and when they are not and as such Koha::Charges::Fees could
    not reliably assume that the dates passed in were consistent with each
    other. As such, we take the approach of always truncating to the
    greatest minute smaller than the passed in dates so we are comparing
    like for like.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit bbdee010aa192ec0df436a79730343df2b855ff4)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit f34f979aee256eab8d1480729eb7a2f4ad3f2e7c
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Oct 16 11:44:11 2019 +0100

    Bug 23382: (follow-up) Further improve test coverage

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 8f3093c9a09c9c88b6885ac79b8273cf212f6f65)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 4301f8327877e7897bb4917d3e816884e0657538
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Oct 2 11:20:27 2019 +0100

    Bug 23382: (follow-up) Ensure tests pass on Wednesdays

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 080958231e02c7e1139aea33cbe20baa184d4c4b)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 7dbad8e210ab18e2323e8557e50680832a54cdce
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Sep 19 14:48:45 2019 +0100

    Bug 23382: (follow-up) Clarify variable names

    This patch updates the variable name '$branch' to '$branchcode' in a
    number of places to make it clearer what the variable contains.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit af9333292799695b5322a5cf1598e12f08f0a66c)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 9744690da41ba2977805806c937ebd3714a1d131
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Aug 16 08:32:55 2019 +0100

    Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued

    It looks like over progressive rebases of bug 20912 a clause was lost
    within CanBookBeIssued such that a fatal error may be triggered if an
    item with no corresponding itemtype was passed into the routine.

    Additionally the we were passing a Koha::Library object to CalcDateDue
    rather than a branchcode which resulted in a different duedate being
    used in 'CanBookBeIssued' when compared to 'AddIssue'.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit f8e2c489cb668aab9e7484c2dd67c1c05f37b2a5)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 846bab1a7cde25d0921fbcc5f9395b03757849b3
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Aug 15 14:57:08 2019 +0100

    Bug 23382: Add hourly tests for Circulation

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 9063d05662ead802ebb8bbb53730834e6ea5e458)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit c43904e75858512e89c7c772f13f48568802ffe5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Aug 6 15:23:39 2019 +0100

    Bug 23382: Add tests for hourly calculations

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 34e5391d9080f6e9c7bef48878ab888510aca7d0)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit b87e863b353fff0f0ed3fd176812086349aa6bdd
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Aug 6 14:38:28 2019 +0100

    Bug 23382: Improve test coverage

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 28055d334741f8045423f9ac54106050e6b40d01)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                  |  44 ++---
 Koha/Calendar.pm                   |  12 +-
 Koha/Charges/Fees.pm               |  48 ++++--
 t/db_dependent/Circulation.t       | 163 +++++++++++++++----
 t/db_dependent/Koha/Charges/Fees.t | 318 ++++++++++++++++++++++++++++++++++---
 5 files changed, 491 insertions(+), 94 deletions(-)

hooks/post-receive
-- 
main Koha release repository