[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.01-112-g502c8d046a

Sat Jan 18 17:27:38 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  502c8d046aee82bd82fd894615a6d32ec5e635bc (commit)
       via  706a8f7d318359d1b1d04d7449c0a1687f8d56df (commit)
       via  236fb97d866ae6d9e7bb8a0ac3b64b99a0ea0de9 (commit)
       via  774005e3c994f8ea28d2a22148a883d3415269d4 (commit)
       via  77cc1041d88baab4354b198505229f3746d271b7 (commit)
       via  0dad1c6601493c58fae887439d32d8a152b0d1d3 (commit)
       via  aab56b89f5489ed86b7059910c063b6d3641c3ce (commit)
       via  d31ffed5a41db165194dc255e739b6c3c64bb237 (commit)
       via  1726c98c25a38dab545834160c8a7f7d0d519ea6 (commit)
       via  8abf6d54c2360d013b04bbb4614a57a5e75c3c2e (commit)
      from  028a77abce1aa0c9dc9f1bab8fc3069df811c2a1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 502c8d046aee82bd82fd894615a6d32ec5e635bc
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Jan 15 09:45:24 2020 -0300

    Bug 23893: Special care for booleans

    This patch acknowledges the fact that in D8 the Mojo::JSON->true and
    Mojo::JSON->false values don't translate into integers when passed to
    DBIC. It works correctly on D9 onwards, but we haven't formally
    deprecated Jessie. This is adding back this translation, in the right
    place now that all mappings code has been integrated into
    Koha::Object(s) directly.

    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Object.t
    => SUCCESS: Tests pass!
    3. Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 706a8f7d318359d1b1d04d7449c0a1687f8d56df
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Dec 27 15:21:30 2019 -0300

    Bug 23893: Catch dt_from_string exceptions

    This patch adds exception handling to the attributes_from_api() method.
    This can happen with invalid date/datetimes, for example.

    Tests are added:

    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Object.t
    => SUCCESS: Tests pass!
    3. Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 236fb97d866ae6d9e7bb8a0ac3b64b99a0ea0de9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Dec 27 17:03:16 2019 +0100

    Bug 23893: Remove Overloaded method from Koha::Patron

    That way we are dealing with any date fields for any Koha::Object

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 774005e3c994f8ea28d2a22148a883d3415269d4
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Dec 27 12:15:39 2019 -0300

    Bug 23893: (QA follow-up) Explicit date format

    This patch makes the input date format explicit. It also adds a missing
    POD.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 77cc1041d88baab4354b198505229f3746d271b7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Dec 27 15:21:27 2019 +0100

    Bug 23893: No special care for booleans

    Tests pass without that changes. If we need them they should be at
    Koha::Object anyway.

    About the date, I also think that that should be moved to Koha::Object
    (we can guess it, like we do in Koha::Object->store, retrieve the
    datatype and adjust). Also we can send a DT object to DBIC, no need for
    an sql formatted date

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 0dad1c6601493c58fae887439d32d8a152b0d1d3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Nov 12 10:00:14 2019 -0300

    Bug 23893: Use in /patrons

    This patch makes the patrons endpoint use the new methods from
    Koha::Object.

    To test:
    1. Apply this patch
    2. Run:
      $ kshell
     k$ prove t/db_dependent/api/v1/patrons.t
    => SUCCESS: Tests pass!
    3. Sign off :-D

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit aab56b89f5489ed86b7059910c063b6d3641c3ce
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Nov 12 09:59:53 2019 -0300

    Bug 23893: Use in /cities

    This patch makes the cities controller use the new methods from
    Koha::Object.

    To test:
    1. Apply this patch
    2. Run:
      $ kshell
     k$ prove t/db_dependent/api/v1/cities.t
    => SUCCESS: Tests pass!
    3. Sign off :-D

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit d31ffed5a41db165194dc255e739b6c3c64bb237
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Nov 11 16:07:03 2019 -0300

    Bug 23893: Add new_from_api and set_from_api to Koha::Object

    This patch introduces the following methods to the Koha::Object class:
    - set_from_api
    - new_from_api

    This methods are going to be used when writing API controllers that map
    to the attributes to the DB schema ones.

    To test:
    1. Apply this patchset
    2. Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Object.t
    => SUCCESS: Tests pass!
    3. Sign off :-D

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 1726c98c25a38dab545834160c8a7f7d0d519ea6
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Nov 11 15:03:28 2019 -0300

    Bug 23893: Implement Koha::Object->from_api_mapping

    This patch implements the from_api_mapping method, that calculates (and
    caches) the reserve mapping from the to_api_mapping method.

    A generic to_api_mapping is added to simplify things a bit in the generic
    to_api method and so the mappings are reusable in the way they are in
    from_api_mapping.

    To test:
    1. Apply this patches
    2. Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Object.t
    => SUCCESS: Tests pass!
    3. Sign off :-D

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 8abf6d54c2360d013b04bbb4614a57a5e75c3c2e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Nov 11 15:03:29 2019 -0300

    Bug 23893: Unit tests

    This patch introduces tests for the implemented methods.

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Object.pm               | 143 ++++++++++++++++++++++++++----
 Koha/REST/V1/Cities.pm       |   5 +-
 Koha/REST/V1/Patrons.pm      |   9 +-
 t/db_dependent/Koha/Object.t | 203 ++++++++++++++++++++++++++++++++++++++++++-
 4 files changed, 334 insertions(+), 26 deletions(-)

hooks/post-receive
-- 
main Koha release repository