[koha-commits] main Koha release repository branch master updated. v19.11.00-395-gd0446c835c
Git repo owner
gitmaster at git.koha-community.org
Mon Jan 20 18:02:04 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via d0446c835c88c44711cc98dba95ccc757bada54b (commit)
via 000cf4eba32fe67fb41d797583f3a13e3896c3d6 (commit)
via 4c10b49b5df8d71ac11967b759fcd7473d67f883 (commit)
via 8d2642d33e08d85d8a215a09100886d1e94a43c8 (commit)
via c0e2912ee6e16c1236688f10b60454689d9405e5 (commit)
via 032e09a7b387ebb219c1944c6834abc64b5a8b5a (commit)
via e4860aeeede07a30ddb425a075a26b442a13a538 (commit)
via 34dfe783c6e13f8298c4e296860711e44889980d (commit)
via ebb2b54d3498ec81d656ffe654bc9534a9aa8e9b (commit)
via fb526fb155143a62ea24a8433f58c1c79c1a0179 (commit)
via 7b25cc903e21fae100453e079ac79516631b3f6b (commit)
via bcc537db059076ebed648846f40b59ddce27dace (commit)
via 2f2f02297fbd09821f99544ba4d5027f08169fc8 (commit)
from d8726c2e46b62a599a031dad442c45a6cfde0179 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d0446c835c88c44711cc98dba95ccc757bada54b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 14 12:47:19 2020 -0300
Bug 24419: Add Koha::Suggestion->suggester accessor
This patch adds a ->suggester accessor to the Koha::Suggestion class. It
will return undef if no suggester, and a Koha::Patron object otherwise.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Suggestion.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 000cf4eba32fe67fb41d797583f3a13e3896c3d6
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 14 10:09:12 2020 -0300
Bug 24418: Unit tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 4c10b49b5df8d71ac11967b759fcd7473d67f883
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 14 10:11:00 2020 -0300
Bug 24418: Add koha_object(s)_class methods to Suggestion
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8d2642d33e08d85d8a215a09100886d1e94a43c8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 14 10:09:40 2020 -0300
Bug 24418: Add Koha::Biblio->suggestions
This patch adds the mentioned accessor. To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c0e2912ee6e16c1236688f10b60454689d9405e5
Author: Maryse Simard <maryse.simard at inlibro.com>
Date: Thu Nov 14 08:50:30 2019 -0500
Bug 12502: (follow-up) Adds formatting for datatables export
Add a format option to the datatables export that remove .noExport
elements present in a data cell, just as .noExport columns are
not exported.
To test:
1. For late orders (which uses .noExport elements in data cells) :
Export data in any format using the export button at the top
of the datatable.
=> data should exclude "Add/Edit note" label, but
otherwise look the same as before the patch.
2. Try exporting data in other datatables in Koha and make sure
exported data is the same before and after applying the patch.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 032e09a7b387ebb219c1944c6834abc64b5a8b5a
Author: Maryse Simard <maryse.simard at inlibro.com>
Date: Thu Nov 14 08:48:13 2019 -0500
Bug 12502: (QA follow-up) Remove the Save button
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e4860aeeede07a30ddb425a075a26b442a13a538
Author: Maryse Simard <maryse.simard at inlibro.com>
Date: Tue Jul 16 15:24:51 2019 -0400
Bug 12502: (follow-up) Use modal to add/edit order notes
Replace inputs to edit notes by a link opening a modal, similar
to the basket summary page. This makes it possible for the notes
to appear in the datatable exports.
Also fix exporting with the export as csv button at the bottom
of the page to export notes.
Test plan :
1) In the late orders table (acqui/lateorders.pl), a link should
appear in both the internal and vendor note column, following the
current value if it exist.
-> This link should read "Add ..." if there is no existing note
or "Edit ..." if there is.
2) Click on the link. A modal should appear. Confirm that saving a
note works as expected.
3) Try exporting to any format using either the button at the top
of the table or the one at the bottom of the page.
-> The three new columns and their values should appear in the
export.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 34dfe783c6e13f8298c4e296860711e44889980d
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Mon Sep 25 15:18:38 2017 -0400
Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders page
Test plan:
0) Make sure you have a late order
a) Create a test vendor unless you have one
b) Create a test basket unless you have one
c) Close the basket to mark the order as late
1) Go to the late orders table
Before patch : Orderno, ISBN, vendor notes, internal notes are absent
After patch: fields are present
2) Edit the vendor note and/or the internal note
3) Press the save notes button
4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your modifications should be displayed.
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ebb2b54d3498ec81d656ffe654bc9534a9aa8e9b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jan 15 18:00:18 2020 +0000
Bug 16784: (follow-up) Add missing filter
This follow-up adds a missing template filter quiet qa tool warning.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fb526fb155143a62ea24a8433f58c1c79c1a0179
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sun Jan 12 20:28:16 2020 +0000
Bug 16784: Add table configuration on suggestions table
This patch adds DataTables column configuration and export options to
the suggestions management tables in the staff interface.
The columns settings made via the administrative interface will affect
tables under each tab in the interface whether it be organized by
status, library, etc. However because of the way the KohaTable function
is currently written, changes made via the "Columns" button will only
affect the visible table.
To test, apply the patch and go to Acquisitions -> Suggestions.
- Under each tab, the table of suggestions should have a DataTables
toolbar with export and columns buttons. These controls should work
correctly:
- Showing and hiding columns should work as expected
- Exports should work, excluding the first and last columns
- Test the tables when using the various "Organize by" settings.
- Test changing the settings in Administration -> Columns settings.
- Verify that the changes you make to that configuration are
reflected in the suggestions tables.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7b25cc903e21fae100453e079ac79516631b3f6b
Author: Lisette Scheer <lisettes at latahlibrary.org>
Date: Fri Jan 10 21:26:16 2020 +0000
Bug 15686: Rename "item level holds" circ rule column to "OPAC item level holds"
This patch changes the column heading on smart-rules.pl to indicate that it only effects item level holds on the OPAC side, rather than the intranet.
To test:
1. Go to Administration, circulation and fine rules.
2. Observe incorrect heading on both the top and bottom of the table.
3. Apply the patch.
4. Repeat step 1.
5. Observe new headings.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit bcc537db059076ebed648846f40b59ddce27dace
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sat Jan 4 21:53:45 2020 +0000
Bug 24343: Show subtitle, number and parts in course reserves list of titles in staff client
Adapted from Bug 23784: At the moment only the title will display in the
course reserves details, but not the information from other title
fields. For series with multiple volumes that can lead to confusing
display. The patch makes use of the new include to display 245$abnp.
To test:
- Add mulitple records to a course reserve course
Make sure you have titles with different combinations of 245$b$n$p
- Look at the course details in the staff client
- Verify only $a displays
- Apply patch
- Reload
- Verify now the full information displays
Depending on your installation, you might want ot check that the 245
are correctly mapped and save the record once so the database
fields are correctly filled.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2f2f02297fbd09821f99544ba4d5027f08169fc8
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sat Jan 4 23:12:25 2020 +0000
Bug 24344: Modify OPAC link to suggest existing record for purchase
This patch modifies the link to suggest purchase of an existing record
from the OPAC. The icon is changed to "gift" and the text shortened to
"Suggest for purchase."
To test, apply the patch and view the detail page of any record in the
OPAC. Confirm that the modifications look good.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 5 +-
Koha/Biblio.pm | 16 ++++
Koha/Schema/Result/Suggestion.pm | 20 ++++-
Koha/Suggestion.pm | 24 +++++-
acqui/lateorders-export.pl | 3 +
acqui/lateorders.pl | 1 +
admin/columns_settings.yml | 36 +++++++++
.../prog/en/includes/columns_settings.inc | 25 ++++++-
.../en/includes/csv_headers/acqui/lateorders.tt | 2 +-
.../prog/en/modules/acqui/csv/lateorders.tt | 5 +-
.../prog/en/modules/acqui/lateorders.tt | 86 +++++++++++++++++++++-
.../prog/en/modules/admin/smart-rules.tt | 4 +-
.../en/modules/course_reserves/course-details.tt | 2 +-
.../prog/en/modules/suggestion/suggestion.tt | 42 ++++++-----
.../bootstrap/en/includes/opac-detail-sidebar.inc | 2 +-
t/db_dependent/Koha/Biblio.t | 36 ++++++++-
.../Koha/{Acquisition/Fund.t => Suggestion.t} | 26 ++++---
17 files changed, 289 insertions(+), 46 deletions(-)
copy t/db_dependent/Koha/{Acquisition/Fund.t => Suggestion.t} (53%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list