[koha-commits] main Koha release repository branch master updated. v19.11.00-414-g9e432877cd
Git repo owner
gitmaster at git.koha-community.org
Tue Jan 21 13:02:50 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 9e432877cd48e6b9cdd87385b92cb93b58ca8d29 (commit)
via 417e76d7e087be4f4d29a95fcaaaf43c19a812d3 (commit)
via 5733398a596953d9f23c92583a25416c9f89c1a1 (commit)
via 9a07842b2d860e4160dbaf6f7256250906669643 (commit)
via b45e43b3c52d1f95ad82dc5d37dc5f9d6a370d8a (commit)
via 0296ba2755915e73a2ae71851a190781febd0edd (commit)
via 7d6740cf57336e75072b1337eee903969057a7c0 (commit)
via 0b2261a766bffe542774b9c3b03794354bb26753 (commit)
via de20a6fbfdb215d462f07d7f960506ca2f6ecb8b (commit)
via dc68633a1f2a8410c949c595dcebb66ada2e2cfb (commit)
via 6a7ef5c96550ac9eefa15ca841c4296e2fd24e8b (commit)
via 89b658885f53fbc8836080b83ae1e67c945f1aa0 (commit)
via d653251562e75a3da5a5df287a126e9a33707320 (commit)
via 2aa49ebab4cb4d36bea42f094df9ccb03945454e (commit)
via 637e82729b76e406517c140f69e9071cc48ca199 (commit)
via 293f9565d05293aee53a999992e75487e61300bc (commit)
via f31993d126ed97fdc80605931f41ed29b1dac5d1 (commit)
via f30c2874cdcbaf008ecc44fafccb89d44403e5f6 (commit)
via f06578b34e9a31ff9b2ee3575b3770a88fccdece (commit)
from d0446c835c88c44711cc98dba95ccc757bada54b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9e432877cd48e6b9cdd87385b92cb93b58ca8d29
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Jan 16 01:50:07 2020 +0000
Bug 19793: Change label to match patron record: Primary email
As we have multiple email fields in the patron record, we should
be clear which one can be changed from the batch mod now. Easiest
is to use the same label.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 417e76d7e087be4f4d29a95fcaaaf43c19a812d3
Author: David Roberts <david.roberts at ptfs-europe.com>
Date: Mon Jan 13 22:43:46 2020 +0000
Bug 19793: Add a field for email in batch patron modification
This adds the email field to the patron batch modification tool.
To test:
1) Install patch
2) Open Batch Patron Modification tool, and input a borrowernumber to edit
3) Add some data (e.g. test at foobar.com) into the Email address field, and click Save
4) The Primary Email address in the user record should now contain your email address
5) Test that running the tool again with the option to delete the data clears the field correctly
6) Repeat steps 1-5 with a file of user borrowernumbers
Sponsored-by: PTFS Europe
Signed-off-by: Sal <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5733398a596953d9f23c92583a25416c9f89c1a1
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jan 3 15:58:53 2020 +0000
Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC
This patch modifies the OPAC suggestions interface so that patrons will
be asked for confirmation before deleting suggestions.
The patch also makes some minor markup changes to improve consistency
between this interface and others in the OPAC.
To test, apply the patch and log in to the OPAC as a user who has
submitted multiple suggestions.
- From the list of your suggestions, confirm that the "New purchase
suggestion" and "Delete" links have Font Awesome icons.
- Check the checkbox corresponding to one of your suggestions. You can
also now click the title of the suggestions to control the checkbox.
- When you check a box the "Delete" link at the top of the page should
activate.
- Clicking the delete link should trigger a confirmation modal showing
the title(s) you selected.
- The message and button labels should reflect whether one or
multiple titles are being deleted.
- Test that the confirm and cancel controls work correctly.
- Also test this process via the delete button at the bottom of the
table of suggestions.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9a07842b2d860e4160dbaf6f7256250906669643
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Jan 16 01:34:35 2020 +0000
Bug 7468: Use Modern::Perl
Just a tiny coding guidelines fix.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b45e43b3c52d1f95ad82dc5d37dc5f9d6a370d8a
Author: Maryse Simard <maryse.simard at inlibro.com>
Date: Thu Jan 16 09:19:39 2020 -0500
Bug 7468: fix the export labels popup header
When exporting a barcode range, the export popup should display "1 batch
to export" instead of "0 batches to export". In this context, it can be
considered a label batch and should be counted as such.
To test:
When clicking the "Print range" button, the popup should show "1 batch
to export".
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0296ba2755915e73a2ae71851a190781febd0edd
Author: Maryse Simard <maryse.simard at inlibro.com>
Date: Wed Jul 17 11:51:26 2019 -0400
Bug 7468: (follow-up) Add missing filters
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7d6740cf57336e75072b1337eee903969057a7c0
Author: Maryse Simard <maryse.simard at inlibro.com>
Date: Wed Jul 17 09:41:09 2019 -0400
Bug 7468: (follow-up) fix label-edit-range template
Edit the labels/label-edit-range.tt template to follow current
standards :
- Use footer javascript
- Use bootstrap grid
- Use jQuery Validation plugin for validation
Also fixes breadcrumbs to be more specific.
To test:
Make sure the page looks correct and still works as expected.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0b2261a766bffe542774b9c3b03794354bb26753
Author: Charles Farmer <charles.farmer at inLibro.com>
Date: Wed Aug 8 16:20:40 2018 -0400
Bug 7468: (follow-up) Make sure only integers are accepted as from/to values
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit de20a6fbfdb215d462f07d7f960506ca2f6ecb8b
Author: Charles Farmer <charles.farmer at inLibro.com>
Date: Fri Jan 26 15:49:48 2018 -0500
Bug 7468: Showing the error message according to the community interface patterns, fixing a javascript condition
TEST PLAN++
1) Apply all the patches
2) Connect to the intranet with an account with permissions to visit the "Tools" page
3) Go to /cgi-bin/koha/labels/label-home.pl
. Either by entering the URL directly
. OR, from the front page, by clicking "Tools", followed by the hyperlink "Label creator" under the "Catalog" section
4) Under the "+ New" button, a new option should be available: "Barcode range"
5) Fill the "From:" and the "To:" fields of the "Print barcode range" form
. Keeping both fields at "0" should trigger a warning beside the first field: "*Cannot be smaller than 1"
. If the value "From:" is greater the "To:" value, a warning should appear beside the second field: "*Cannot be smaller than the starting value"
. Make sure the form doesn't let you enter non-numerical values
. For a casual test, use "From: 1000" and "To: 1100"
6) After pressing the "Print Range" button, choose a template, a layout, and a starting position
. The "DEFAULT TEMPLATE 01" has a page height of 5pt and a page width of 0pt, don't use it
. All the default layouts should look alike, since we're only printing a barcode over a number, and not bibliographic information
. Using a layout not defined as 'Barcode' will show a warning message
7) Clicking the "Export" button should lead to a second dialog window with a "Download as PDF" hyperlink. Clicking the link should prop up a download dialog box
8) Save the PDF locally, or simply open it, and make sure the options you used were taken into account
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dc68633a1f2a8410c949c595dcebb66ada2e2cfb
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Thu Oct 5 09:40:19 2017 -0400
Bug 7468: Add warning when range has non-existent barcodes
+ Added a warning when the user selects a range with some non-existent barcodes, and a layout without barcodes.
This allows the user to print barcodes of items not in the database if he so desires, but will warn him if he tries to print only biblios (which results in missing entries or a blank page).
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6a7ef5c96550ac9eefa15ca841c4296e2fd24e8b
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Wed Oct 4 09:12:11 2017 -0400
Bug 7468: Fix 'false' message on Firefox
It seems I was using an href to a javascript function in the 'Print Range' button, which Chrome didn't mind, but Firefox did understand.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 89b658885f53fbc8836080b83ae1e67c945f1aa0
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Mon Sep 18 10:55:05 2017 -0400
Bug 7468: Print barcodes by range
Adds an option to the label creator to print a range of barcodes.
Only allows printing to PDF.
C4/Label.pm had to get minor changes to override database-based barcode
generation. Same with labels/label-create-pdf.pl. By default, the
barcode is fetched from the database using the itemnumber, but when
printing ranges, you might not have a corresponding database entry.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d653251562e75a3da5a5df287a126e9a33707320
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Jan 16 01:00:28 2020 +0000
Bug 3426: Keep note about sequence of subfields
Bug 9156 changed the wording of the pref slightly to make it
clear that the subfield sequence of the record will be used,
not the sequence of the subfields defined in the pref.
This just reinstates the note:
The order of the subfields in the record will be preserved.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2aa49ebab4cb4d36bea42f094df9ccb03945454e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Dec 19 05:29:47 2019 +0000
Bug 3426: Allow for multiple fields in itemcallnumber syspref
Note that we change both cataloguing/additem.pl and C4/Items->PrepareItemrecordfordisplay
I can find no code that uses callnumber from the C4/Items sub, except for the itemrecorddisplay script
which is not called with an itemnumber from Koha and should be deprecated for REST or ILSDI or OAI (imho)
To test:
1 - Define itemcallnumber syspref as "082ab,092ab,9520,245a"
2 - Find a record with no items
3 - Ensure it has no 082 field, but an 092 field
4 - Go to add an item - itemcallnumber is empty
5 - Apply patch
6 - Go to add item, itemcallnumber should be the 092ab fields
7 - Delete the 092 field
8 - Go to add item, itemcallnumber should be the 245a
9 - Edit the callnumber to be "testing" and save item
10 - For should now show itemcallnumber="testing" as default
11 - Browse to http://localhost:8081/cgi-bin/koha/services/itemrecorddisplay.pl?itemnumber=## subbing the correct itemnumber
12 - Ensure the callnumber is defaulting to testing
13 - delete the item you created
14 - browse to URL above - callnumber should now be 245 again
15 - Add an 092 field to record and ensure it is now default callnumber
16 - Add an 082 field, it should now be default
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 637e82729b76e406517c140f69e9071cc48ca199
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jan 16 13:32:25 2020 -0300
Bug 24435: Add Koha::Biblio->items_count
This patch introduces a handy shortcut to get the items count for a
biblio. So instead of calling:
$count = $biblio->items->count;
you can call:
$count = $biblio->items_count;
The use case for this, is when we want to embed information on objects
to be sent as API responses. In that case, calling ->items->count needs
to be done manually on the controller script, with interesting added
complexity. With this kind of method, we can just require it to be
embedded automagically by calling the following on the API:
$biblio->to_api({ embed => { items_count => {} } });
If there are several nested layers of objects, doing manually can get
really tricky and error prone.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 293f9565d05293aee53a999992e75487e61300bc
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jan 16 13:32:04 2020 -0300
Bug 24435: Unit tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f31993d126ed97fdc80605931f41ed29b1dac5d1
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jan 15 16:28:00 2020 -0300
Bug 24430: Remove CountBiblioInOrders and its traces
This patch replaces the only uses of CountBiblioInOrders and makes that
code use $biblio->orders->count instead.
Test nothing breaks in basket.pl and parcel.pl
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f30c2874cdcbaf008ecc44fafccb89d44403e5f6
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jan 15 16:25:52 2020 -0300
Bug 24430: Add ->orders and ->active_orders_count to Koha::Biblio
This patch introduces an accessor to the related orders, and a method
that returns the active orders count. The target usage for the count is the
API. In the rest of the codebase, we would just call:
$biblio->orders->count
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f06578b34e9a31ff9b2ee3575b3770a88fccdece
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jan 15 16:25:19 2020 -0300
Bug 24430: Unit tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 21 -----
C4/Items.pm | 12 +--
C4/Labels/Label.pm | 4 +-
Koha/Biblio.pm | 46 +++++++++++
Koha/Schema/Result/Biblio.pm | 7 ++
acqui/basket.pl | 5 +-
acqui/parcel.pl | 2 +-
cataloguing/additem.pl | 12 +--
.../prog/en/includes/labels-toolbar.inc | 1 +
.../en/modules/admin/preferences/cataloguing.pref | 4 +-
.../prog/en/modules/labels/label-edit-range.tt | 91 ++++++++++++++++++++++
.../prog/en/modules/labels/label-print.tt | 15 +++-
.../prog/en/modules/tools/modborrowers.tt | 4 +
.../bootstrap/en/modules/opac-suggestions.tt | 62 ++++++++++-----
labels/label-create-pdf.pl | 10 ++-
patroncards/home.pl => labels/label-edit-range.pl | 5 +-
labels/label-print.pl | 33 +++++++-
t/db_dependent/Koha/Biblio.t | 57 +++++++++++++-
tools/modborrowers.pl | 8 +-
19 files changed, 329 insertions(+), 70 deletions(-)
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-range.tt
copy patroncards/home.pl => labels/label-edit-range.pl (89%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list