[koha-commits] main Koha release repository branch master updated. v19.11.00-438-g1c07cacff2

Thu Jan 23 10:35:58 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  1c07cacff2b41a9b58f8999b3565a888b018fbf9 (commit)
       via  c61876322213d9a70edc12b033894217d2116391 (commit)
       via  ed5ec62cac48a96413a9e468d8bacc2a4ef80ea5 (commit)
       via  991f51b27240bd5d5e2ce302db7260f17d7e680c (commit)
       via  1e52cb442b57248b837a73a5e2d7a59fb10ee42e (commit)
       via  e003a3c16495c8f488a2970b57e00e1070f64e7d (commit)
       via  cf038dd938636303c3936ce186f1a64ae9cf10db (commit)
       via  f8e399b62e78d56d7437597ea589af64954005ca (commit)
       via  78190371d00cb91ae668eb3d28a48ef33c112676 (commit)
       via  0dbf76c290f031e58dcb04e16047f1bd984560ef (commit)
       via  3760af11f7b098b8de68ce4429d348737caf4be1 (commit)
       via  367df45840cf4b829c0757144a83db42c9ada92f (commit)
      from  451bc0fca595f426257b4a790fc6f83cc10f32f9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1c07cacff2b41a9b58f8999b3565a888b018fbf9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 20 12:22:58 2019 +0100

    Bug 23064: Use Koha::Subscription in ModSubscription

    We must use Koha::Subscription instead of raw SQL.
    It will fix issue with default and integer values.

    Test plan:
    Edit a subscription and set number of issues = "f"
    Save
    => Without this patch there is a SQL error in the log:
      Incorrect integer value: 'f' for column 'numberlength'
    => With this patch the other changes are effective.

    Note: We also could change the type attribute of the input to "number",
    to have a client-side check

    Also, the return value of ModSuggestion is never used, so we are safe
    with that.

    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c61876322213d9a70edc12b033894217d2116391
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jan 21 10:26:04 2020 +0100

    Bug 24345: Fix OPACViewOthersSuggestions

    Default value for $op needs to be set before the get_template_and_user lines as
    it's tested for OPACViewOthersSuggestions.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ed5ec62cac48a96413a9e468d8bacc2a4ef80ea5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun Jan 5 22:02:18 2020 +0100

    Bug 24345: Fix process of suggesting purchase of existing title for non-logged-in users

    The 'op' parameter is removed from the CGI object ($input) before
    get_template_and_user is called. When the user is redirected to the
    login form (from checkauth, called from get_template_and_user), the
    op is lost.

    Moving down the deletion fixes the problem.

    Test plan:
    Logout at the OPAC
    Go the detail page of a bibliographic record
    Click the "Suggest for purchase" link
    Fill the login form
    => Without this patch you will see your suggestion list
    => With this patch applied the new suggestion form will be displayed,
    prefilled with the biblio's info

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 991f51b27240bd5d5e2ce302db7260f17d7e680c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jan 10 14:16:56 2020 +0100

    Bug 24397: Remove out of sync script populate_db.pl

    populate_db.pl from koha-misc4dev must be used instead.
    This script existed before the creation of koha-misc4dev, it does no
    longer make sense to have it in Koha.

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1e52cb442b57248b837a73a5e2d7a59fb10ee42e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jan 20 09:48:03 2020 -0300

    Bug 24459: Make ->to_api pass $params through

    This patch makes the to_api method in Koha::Acquisition::Inovice and
    Koha::Patron pass the passed parameters to the base class to_api method.
    This is required for things like embedding related objects.

    To test:
    1. Apply the regression tests patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Patron.t \
               t/db_dependent/Koha/Acquisition/Invoice.t
    => FAIL: Tests fail!
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests pass!
    5. Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e003a3c16495c8f488a2970b57e00e1070f64e7d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jan 20 09:47:18 2020 -0300

    Bug 24459: Regression tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit cf038dd938636303c3936ce186f1a64ae9cf10db
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Sun Jan 19 02:06:00 2020 -0300

    Bug 24457: Make overloaded ->to_api pass the params to parent method

    This patch makes the overloaded to_api method for baskets care about the
    remaining parameters, and pass them to SUPER::to_api.

    To test:
    1. Apply the regression tests
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Acquisition/Basket.t
    => FAIL: Tests fail! No embedded bookseller!
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests pass!
    5. Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f8e399b62e78d56d7437597ea589af64954005ca
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Sun Jan 19 02:05:40 2020 -0300

    Bug 24457: Regression tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 78190371d00cb91ae668eb3d28a48ef33c112676
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Dec 20 13:33:28 2019 +0000

    Bug 24286: Escape forward slash in GENRE/FORM (and any authtype)

    Note that bug 24267 will fix the issue during Z39 searching for new auth, but the duplicate check at saving will still fail

    To test:
     0 - Set SearchEngine to Elasticsearch,  QueryRegexEscapeOptions  to 'Don't Escape'
     1 - Browse to Authorities
     2 - Select New->New from Z3950
     3 - Search for subject 'Short stories'
     4 - Auth search explodes
     5 - Apply patch
     6 - Repeat and confirm the search results return
     7 - Import and save the GENRE/FORM record for Short stories
     8 - Repeat the search and import the same record
     9 - Confirm that upon save you are notified of duplicate, don't save
    10 - set  QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works and importing/save notifies of duplicate
    11 - set SearchEngine to Zebra and confirm Z39 searching works and importing/save notifies of duplicate

    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
    Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0dbf76c290f031e58dcb04e16047f1bd984560ef
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Jan 16 14:10:18 2020 -0500

    Bug 24441: Error when checking in an item with BranchTansferLimitsType set to itemtype

    It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!".

    Test Plan:
    1) Enable Branch Transfer Limits via itemtype
    2) Check in an item
    3) Note the error
    4) Apply this patch
    5) Restart all the things!
    6) Check in an item
    7) No error!

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Maribeth (Turner) Shafer <mshafer at ckls.org>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3760af11f7b098b8de68ce4429d348737caf4be1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jan 21 16:08:12 2020 +0100

    Bug 24441: Add tests

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 367df45840cf4b829c0757144a83db42c9ada92f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Dec 13 16:08:16 2019 +0000

    Bug 24236: Fix pagination to use query_cgi

    This is still wrong, we should use page-numbers.inc, but that is a larger refactoring
    This patch fixes non-QueryParser searches by simple getting an using the escaped query (query_cgi)

    For QueryParser, we do what the QP code does, just uri escape the query - the way that SimpleSearch does the query parsing instead of the usual buildQuery suggest to me that we should probably switch all of this to use the general Zebra search.

    The issues with reservoir should be their own bug

    To test:
    1 - Search for cat in cataloging search
    2 - Get results and see you can paginate
    3 - Search for "cat"
    4 - Get results but subsequent pages empty
    5 - Apply patch
    6 - Repeat search for "cat"
    7 - You can paginate
    8 - Enable UseQueryParser syspref (don't worry about installing)
    9 - Confirm can still search with quotes and paginate

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: George Williams <george at nekls.org>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/AuthoritiesMarc.pm                     |   1 +
 C4/Circulation.pm                         |   2 +-
 C4/Serials.pm                             |  74 ++++++-----
 Koha/Acquisition/Basket.pm                |   4 +-
 Koha/Acquisition/Invoice.pm               |   4 +-
 Koha/Patron.pm                            |   4 +-
 cataloguing/addbooks.pl                   |   7 +-
 misc/devel/populate_db.pl                 | 200 ------------------------------
 opac/opac-suggestions.pl                  |  14 +--
 t/db_dependent/Circulation/Returns.t      |  32 ++++-
 t/db_dependent/Koha/Acquisition/Basket.t  |  36 +++++-
 t/db_dependent/Koha/Acquisition/Invoice.t |  70 +++++++++++
 t/db_dependent/Koha/Patron.t              |  40 +++++-
 13 files changed, 239 insertions(+), 249 deletions(-)
 delete mode 100755 misc/devel/populate_db.pl
 create mode 100644 t/db_dependent/Koha/Acquisition/Invoice.t

hooks/post-receive
-- 
main Koha release repository