[koha-commits] main Koha release repository branch master updated. v19.11.00-540-g6d456df81a

Thu Jan 30 17:17:46 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  6d456df81a03096342dd72df99284e23603a7bbc (commit)
       via  cca2a0827043770877e6db3c7b13a2d6f263d4e6 (commit)
       via  3134736a841175755b9b30cbda16ee552798a82d (commit)
       via  812a863d86686350243725f5bbfd2718022eee2d (commit)
       via  09ac74baca826670e7d1229d1b596c2c11e5059a (commit)
       via  9384ed4aa8fa833c8a2ab5f1e237e5858feea6c1 (commit)
       via  de6d12edfa02dde87d90b1f0f3d1225f80c73162 (commit)
       via  bc05a90aa78ca014d22d9c5c67058220e541fdc4 (commit)
       via  fd1ade2a6768cd845ebefce471883a2d7555f6fd (commit)
       via  1e5fca80e6f7967d0fe65e2010fcce9836e34c75 (commit)
       via  4584d36df43219a070bc542dba56ec065ad5b769 (commit)
      from  1132889dc9fc5dccabbca51460e3bfb32a9f5fbd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6d456df81a03096342dd72df99284e23603a7bbc
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Jan 2 10:30:54 2020 -0500

    Bug 24330: When importing patrons from CSV, automatically strip BOM from file if it exists

    We have a partner that exports UTF-8 CSV files, and is experiencing the same thing as the author of this article: https://www.freecodecamp.org/news/a-quick-tale-about-feff-the-invisible-character-cd25cd4630e7/

    In short, Excel is inserting an invisible UTF-8 character at the start of the file, so that the column name "cardnumber" is actually named "\x{feff}cardnumber", causing "cardnumber" to be blank.

    A simple solution is provided here: https://stackoverflow.com/questions/24390034/remove-bom-from-string-with-perl

    Test Plan:
    1) Download the example.csv file
    2) Attempt to import it using the patron import tool
    3) Note the invalid column name error
    4) Apply this patch, restart all the things!
    5) Attempt the import again
    6) Assuming you have a branchcode MPL and a cataegory code S, the patron should import!

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Maggie Wong <maggie.wong at yccece.edu.hk>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit cca2a0827043770877e6db3c7b13a2d6f263d4e6
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Jan 30 15:44:17 2020 +0000

    Bug 21674: DBRev 19.12.00.017

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3134736a841175755b9b30cbda16ee552798a82d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jan 21 15:01:51 2020 +0100

    Bug 21674: Remove duplicates from library_groups before adding the uniq constraint

    To avoid to make it fails if duplicates existed prior to this change

    Credit for the SQL query goes to Nick, thanks!

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 812a863d86686350243725f5bbfd2718022eee2d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 11 12:51:23 2019 +0100

    Bug 21674: Prevent to insert twice the same library in a group

    When you create hierarchical groups of libraries you are not allowed to add
    several times the same library to a given group/subgroup. The libraries
    that are part of the group is not displayed on the interface, to prevent
    the user to select it.

    However this restriction is only done template-side, the controller and
    module does not handle it.

    To prevent that this patchset enforces the constraint at DB level, and
    display a message to the end user.

    Test plan:
    - Go to Home › Administration › Library groups
    - Add a group
    - Add a library
    - reload the page several times
    => Without this patch the same library appears several times in the group
    => With this patch applied you will see a friendly error message

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 09ac74baca826670e7d1229d1b596c2c11e5059a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 11 12:51:14 2019 +0100

    Bug 21674: DB changes

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9384ed4aa8fa833c8a2ab5f1e237e5858feea6c1
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Jan 16 13:09:58 2020 +0000

    Bug 24377: Record passed branch if renewing via cron

    To test:
    1 - Checkout an item with auto renewal set and eligible for auto renew
    2 - Set no renewal before in the circ rules to 99 (something greater than the checkout period)
    3 - perl misc/cronjobs/automatic_renewals.pl
    4 - Check the statistics table, note the branch for renewal is null
        SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL'
    5 - Apply patch
    6 - Repeat 1-4
    7 - Note the branch is set to the issuing branch

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Ed Veal <eveal at mckinneytexas.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit de6d12edfa02dde87d90b1f0f3d1225f80c73162
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Jan 16 13:09:50 2020 +0000

    Bug 24377: Unit test

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit bc05a90aa78ca014d22d9c5c67058220e541fdc4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jan 30 11:51:25 2020 +0100

    Bug 24543: Fix wrong test in api/v1/checkouts.t

    In t/db_dependent/api/v1/checkouts.t we define a circulation rule with renewalperiod=7.
    But then the expected due date is today+14 days.
    However, at the beginning of the script, the due_date of the issue is today+14 days.

    That highlight that the renewal period is not taken into account.

    The circulation rule is created with renewalperiod and renewalsallowed,
    however GetLoanLength check the existence of issuelength to return the rule.
    GetLoanLength finally return the default rule, with renewalperiod=0

    Note that this has been found working on bug 18936, code will be cleaned on that patchset.

    Test plan:
     % prove t/db_dependent/api/v1/checkouts.t
    must return green before and after this patch

    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fd1ade2a6768cd845ebefce471883a2d7555f6fd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jan 23 10:47:17 2020 +0100

    Bug 24487: Add 2 more tests

    And make sure tests pass if there is no patron with borrowernumber=10 in
    DB.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Ammended test description
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1e5fca80e6f7967d0fe65e2010fcce9836e34c75
Author: Agustin Moyano <agustinmoyano at theke.io>
Date:   Thu Jan 23 01:50:29 2020 -0300

    Bug 24487: Don't apply matching criteria to path parameters

    This patch separates query parameters from path parameters, and uses exact matching for the later.

    To test:
    1. Apply this patch
    2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t
    SUCCESS => tests ok
    3. Sign off

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4584d36df43219a070bc542dba56ec065ad5b769
Author: Agustin Moyano <agustinmoyano at theke.io>
Date:   Wed Jan 22 20:44:04 2020 -0300

    Bug 24487: Regresion test

    This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria

    To test:
    1. apply this patch
    2. prove t/db_dependent/Koha/REST/Plugin/Objects.t

    Test should fail at this point.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |  2 +-
 Koha.pm                                            |  2 +-
 Koha/Patrons/Import.pm                             |  1 +
 Koha/REST/Plugin/Objects.pm                        | 12 +++++-
 Koha/REST/Plugin/Query.pm                          |  9 ++++-
 Koha/Schema/Result/LibraryGroup.pm                 | 18 ++++++++-
 admin/library_groups.pl                            | 37 ++++++++++-------
 installer/data/mysql/kohastructure.sql             |  3 +-
 installer/data/mysql/updatedatabase.pl             | 23 +++++++++++
 .../prog/en/modules/admin/library_groups.tt        | 11 ++++++
 t/Koha/REST/Plugin/Query.t                         | 37 ++++++++---------
 t/db_dependent/Circulation.t                       | 12 +++++-
 t/db_dependent/Koha/REST/Plugin/Objects.t          | 46 +++++++++++++++++++++-
 t/db_dependent/api/v1/checkouts.t                  | 16 ++++----
 14 files changed, 175 insertions(+), 54 deletions(-)

hooks/post-receive
-- 
main Koha release repository