[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-36-g439c73a2ed

Fri Jan 31 01:43:51 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  439c73a2ed167f031741a2946bd04ade39d9d581 (commit)
       via  4fe82250938072156b2d03027e3d03252e79f679 (commit)
       via  b253cf3f66f54f5df04faf0a01d26c5dc4716dd4 (commit)
       via  0c68b3a171c07025a0bb9e48245444a44b30d196 (commit)
       via  2211b170f1eb95118ebcb4f923048f3562b7040b (commit)
       via  1d231aedb13691a48afb61339e98c4892db48e49 (commit)
       via  76f5ec182122d256b585a3369616f6243178f51f (commit)
       via  398281e0e486f6473353f36c0c1f2beb00706ae4 (commit)
       via  dcc238f05b916b0225e937730f51d780ea18b29e (commit)
       via  0c50804f4b2d82329e0bfb591b2add048594691a (commit)
      from  a8659229be16dc8d8b2beaae370528afd373192e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 439c73a2ed167f031741a2946bd04ade39d9d581
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Jun 17 16:09:38 2019 +0200

    Bug 22426: Map 'loc' to 'location' when building ES queries

    A search made on Shelving location tab in advanced search gives 0 result.

    Test plan :
    Without patch:
        - in advanced search, choose a location in shelving location tab and start search (opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc)
        - 0 result
        - check that location exist by doing a simple search and filtering on the    location facet
        - have some results
    With patch:
        - in advanced search, choose a location in shelving location tab and start search (opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc)
        - found results

    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 4fe82250938072156b2d03027e3d03252e79f679
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Jan 13 09:27:35 2020 +0000

    Bug 23676: (RM follow-up) Test Correction

    We altered the query form passed by the ElasticSearch Query Builder
    but neglected to update the test.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit b253cf3f66f54f5df04faf0a01d26c5dc4716dd4
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Sep 25 19:04:13 2019 +0000

    Bug 23676: Use 'false' for opac suppression

    To test:
     1 - Enable ES
     2 - Enable OpacSuppression
     3 - Suppress a bib in staff client
         Edit 942n to be 1
     4 - Search the opac for anything
     5 - Tail the plack logs and note a deprecation warning
     6 - Apply patch
     7 - Restart all the things
     8 - Repeat search on opac
     9 - No error/warn in logs
    10 - Record is correctly suppressed

    Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 0c68b3a171c07025a0bb9e48245444a44b30d196
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date:   Fri Aug 31 15:32:20 2018 +0300

    Bug 17885: Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions

    When executing
    Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings()
    against populated search engine mappings tables, one gets this
    exception:

    DBD::mysql::st execute failed: Duplicate entry '388-73' for key
    'PRIMARY' [for Statement \"INSERT INTO `search_marc_to_field` ( `facet`,
    `search_field_id`, `search_marc_map_id`, `sort`, `suggestible`) VALUES (
    ?, ?, ?, ?, ? )\" with ParamValues: 0='', 1='73', 2='388', 3=undef,
    4=''] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
    1834.\nDBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry
    '388-73' for key 'PRIMARY' at /home/koha/Koha/Koha/SearchField.pm line
    38"

    This patch fixes this, by first deleting all entries, then adding the
    default ones.

    If a subroutine says reset_elasticsearch_mappings(), I expect it to
    reset the elasticsearch mappings without errors.  When writing tests it
    is better to call that one subroutine reset_elasticsearch_mappings
    instead of the bunch of code in
    admin/searchengine/elasticsearch/mappings.pl?op=reset_confirmed
    Also this promotes code reuse.

    TEST PLAN:

    a. perl -e 'use Koha::SearchEngine::Elasticsearch; Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings'
    b. Run misc/devel/populate_db.pl on an already populated DB and you eventually
    face this problem.

    After this patch, step a. works.

    This patch is adapted from the original patch made by Olli-Antti
    Kivilahti <olli-antti.kivilahti at jns.fi>.

    Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 2211b170f1eb95118ebcb4f923048f3562b7040b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Oct 31 13:52:05 2019 -0400

    Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue

    Test plan:
    - Set LocalHoldsPriority to "Give priority for filling holds to patrons
    whose pickup library matches the item's holding library"
    - set yourself at Library A
    - find at item at Library A
    - place an item-level hold (Hold 1) for item for pickup at Library B
    - set an item-level hold (Hold 2) for item for pickup at Library A
    - Confirm Hold 1 shows priority=1
    - Check in item
    - confirm item would be captured for Hold 2, ignore hold
    - run holds queue
    - check item in
    - confirm item is captured for Hold 2

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 1d231aedb13691a48afb61339e98c4892db48e49
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Oct 31 13:51:33 2019 -0400

    Bug 23934: Unit test

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 76f5ec182122d256b585a3369616f6243178f51f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Jan 13 09:22:20 2020 +0000

    Bug 15142: (RM follow-up) Fix tests

    We removed the su-ut facet from zebra config for UNIMARC as it makes no
    sense for that case, but we neglected to remove it form the test that
    checks the config response.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 398281e0e486f6473353f36c0c1f2beb00706ae4
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Tue Dec 31 10:30:32 2019 +0100

    Bug 15142: (follow-up) Remove facet configuration from .xsl file

    Removes last remaining bit of configuration for the Titles facet
    configuration.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit dcc238f05b916b0225e937730f51d780ea18b29e
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Nov 26 09:44:08 2019 +0100

    Bug 15142: (follow-up) remove from Zebra UNIMARC config files

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 0c50804f4b2d82329e0bfb591b2add048594691a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Nov 22 15:16:51 2019 +0100

    Bug 15142: Remove titles facet for UNIMARC

    There is a facet using 500$a, 501$a and 503$a and Subject index.
    In UNIMARC 500$a, 501$a and 503$a are not indexed as Subject.
    I propose to remove this facet for UNIMARC, looks like it does not make
    sens.

    Test plan:
    1) Install UNIMARC database
    2) Edit some records to have 500$a
    3) Perform a search to find those records
    4) Check you dont see the titles facet

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/HoldsQueue.pm                                   |   1 -
 C4/Koha.pm                                         |   6 -
 Koha/SearchEngine/Elasticsearch.pm                 |   3 +
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    |   3 +-
 admin/searchengine/elasticsearch/mappings.pl       |   2 -
 .../unimarc/biblios/biblio-koha-indexdefs.xml      |   9 -
 .../unimarc/biblios/biblio-zebra-indexdefs.xsl     |  21 --
 t/db_dependent/HoldsQueue.t                        | 229 +++++++++++++++++++--
 .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t |   4 +-
 t/db_dependent/Search.t                            |   3 +-
 10 files changed, 216 insertions(+), 65 deletions(-)

hooks/post-receive
-- 
main Koha release repository