From gitmaster at git.koha-community.org Fri Jul 3 02:04:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jul 2020 00:04:10 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-6-g525ca46cc7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 525ca46cc7a89f23d816de7e5aee9c3a67b8392d (commit) from 009794008c30c4321c8ef417888ba7f682590aa2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 525ca46cc7a89f23d816de7e5aee9c3a67b8392d Author: Tomas Cohen Arazi Date: Fri May 29 14:41:25 2020 -0300 Bug 25623: Make sure oauth.t rolls back the db This patch adds a missing transaction wrapping one of the subtests. This is probably an oversight when refactoring this file. To test: 1. Open the patron categories page 2. Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass 3. Reload the patron categories page => FAIL: There's random data in there 4. Apply this patch and repeat 2 5. Reload the patron categories page => SUCCESS: The random data from the previous tests is still there, but no new random data => SUCCESS: Tests still pass 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit f898cef4f4b5a9f424f968a58b96898f26f80035) Signed-off-by: Lucas Gass (cherry picked from commit 0734017ab62e05ee4b365ac4546dc68acefa86ca) Signed-off-by: Aleisha Amohia (cherry picked from commit 4c536ffbcecfeeb9e6d6473e7c7c4cddfe4c5006) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: t/db_dependent/api/v1/oauth.t | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 3 01:15:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Jul 2020 23:15:26 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-3-g0528d42f71 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0528d42f711bb091b19ba7880d74b806b8377820 (commit) from bc822009481b7ad38db06c2d55b64ec7e0c25ae9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0528d42f711bb091b19ba7880d74b806b8377820 Author: Jonathan Druart Date: Wed Nov 20 15:40:10 2019 +0100 Bug 23276: Do not display tag if pref TagsEnabled is off If the pref TagsEnabled is off we should not display the tags at the OPAC. There is a message to tell that tags system is disabled, but the tags are displayed. We should redirect to 404 like we do in opac-topissues.pl and opac-suggestions.pl. Test plan: - Turn TagsEnabled on - Add some tags - Turn TagsEnabled off - Hit /cgi-bin/koha/opac-tags.pl => Without this patch you see a warning messaging saying that the tag system is disabled, but the tags are displayed => With this patch you get a 404 redirect Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 6fc316d2eef5945b20a14bec81e2daa57696dd81) Signed-off-by: Lucas Gass (cherry picked from commit 9893fb4ec5a480b7adcbb27f321f7387a4f38f45) Signed-off-by: Aleisha Amohia (cherry picked from commit d0336378897e33bdd31975c2c126a4ce36ac79a9) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-tags.tt | 4 +-- opac/opac-tags.pl | 38 +++++++++++----------- 2 files changed, 20 insertions(+), 22 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 3 08:21:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jul 2020 06:21:01 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-10-gecc3d1957f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via ecc3d1957fa979dec98f518921f0895a6adb84ac (commit) from d3796afa6e812700caf9fbe06e5f42b44453aefb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ecc3d1957fa979dec98f518921f0895a6adb84ac Author: Kyle M Hall Date: Thu May 21 13:52:32 2020 -0400 Bug 25537: Page reload at branchtransfers.pl loses destination branch At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page? Test Plan: 1) Place a hold on an item and set it to waiting 2) Initiate a branch transfer from branchtransfers.pl for any branch but the first in the pulldown branch selector 3) Choose to cancel the hold and transfer 4) Note the pulldown reverts to the first option 5) Apply this patch 6) Repeat steps 1-3 7) Note the pulldown retains your preveiously selected branch! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 8ab8df3866352568509ed34f02a5566e750dee21) Signed-off-by: Lucas Gass (cherry picked from commit c8c394d1704acab20717ac3939ee1e5d45343e92) Signed-off-by: Aleisha Amohia (cherry picked from commit 9402b7c24cac53003f5ddb22b021d10016e4f2c1) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 3 08:30:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jul 2020 06:30:16 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-12-g3c6bd758b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 3c6bd758b8b812afc0c43c4907d82f6d4fae9aac (commit) from 2033a297cb49f06ef5cc262854307edea99e71ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3c6bd758b8b812afc0c43c4907d82f6d4fae9aac Author: David Roberts Date: Sat May 9 16:07:03 2020 +0000 Bug 22470: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl This patch adds the table name to the SQL update statements. To test: 1) Apply the patch 2) Run the script. Check that there are no errors, and that the script behaves as expected. Signed-off-by: Andreas Roussos Created a test record with values in field 440. Applied the patch, ran the script with the -c -f flags and observed that the values were moved to field 490. Also, the relevant Koha to MARC mappings were changed accordingly. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 051b0b8d2fb3dc3593147e5ac80bc394dcf48e58) Signed-off-by: Lucas Gass (cherry picked from commit 0ee5a38798a170e2e996ee330b3f2101a9ae59be) Signed-off-by: Aleisha Amohia (cherry picked from commit bcf40fe9721eec418bf415334aeec50a67d64914) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: misc/migration_tools/switch_marc21_series_info.pl | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 3 07:44:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jul 2020 05:44:03 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-8-gd972e5fb87 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via d972e5fb878fcdc698d399bce1902560458cee00 (commit) from 2ddae7366c4247609b9ea561f655b4e5267ddbf1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d972e5fb878fcdc698d399bce1902560458cee00 Author: Petro Vashchuk Date: Fri May 22 18:11:28 2020 +0300 Bug 25587: fix for "clear" button to reset all selects Button "clear" on cgi-bin/koha/admin/smart-rules.pl did not reset fields with a dropdown selector except the first one. This happens because jQuery selector .find("select option:first") in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt selects only single first element in the whole group, as from jquery doc: > The :first pseudo-class is equivalent to :eq( 0 ). It could also be > written as :lt( 1 ). While this matches only a single element, > :first-child can match more than one: One for each parent. > (https://api.jquery.com/first-selector/) And it works if replaced by: .find("select option:first-child") To reproduce: 1) Go to /cgi-bin/koha/admin/smart-rules.pl 2) Start editing one of existing rules or filling a new one, change all selects to have non-first option selected. Fill text input fields with sample data. 3) Reset all fields with the "clear" button. 4) Observe that only the first dropdown field was reset to the first option while all others still contain previously given values, meanwhile all text input fields are cleared as expected. 5) Apply the patch. 6) Repeat steps 1, 2 and 3. 7) Check that all dropdown fields were reset to first option, as expected. Mentored-by: Andrew Nugged Signed-off-by: Lucas Gass Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 58c389bf279ca6ffdea199ada8d65ce92baaf952) Signed-off-by: Lucas Gass (cherry picked from commit 585b481cf0a9371f7808602a6d8ec9b81fa1a9c4) Signed-off-by: Aleisha Amohia (cherry picked from commit 26ebfc32721474b89a8e970b5cd6277c94c7c276) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 3 01:55:57 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Jul 2020 23:55:57 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-5-g009794008c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 009794008c30c4321c8ef417888ba7f682590aa2 (commit) from eeb9c8b9c23d7aa5bacae81fe4e8c5c8d9b28da9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 009794008c30c4321c8ef417888ba7f682590aa2 Author: Andrew Fuerste-Henry Date: Thu Jun 4 16:21:27 2020 +0000 Bug 25675: Reword and reorganize sysprefs related to patron self modification To Test: 1: apply patch 2: restart all 3: go to System Preferences > OPAC 4: confirm "Self registration" section is now labeled "Self registration and modification" 5: confirm OPACPatronDetails is now in the "Self registration and modification" section 6: confirm PatronSelfRegistration now reads "(Allow / Don't allow) library patrons to register for an account via the OPAC." 7: set OPACPatronDetails to Don't allow 8: set PatronSelfRegistration to Allow 9: log into the opac and verify you're not able to edit your patron details on an existing account Signed-off-by: DonnaB Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3e4b92d84c50bee27b2f331e5fbbc04813e469bb) Signed-off-by: Lucas Gass (cherry picked from commit 566a9f5a214c38935a65fa4392d24edef2052d85) Signed-off-by: Aleisha Amohia (cherry picked from commit 083ce15dee7b7108a3103c2d4c90fca8df28230b) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/preferences/opac.pref | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 3 08:00:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jul 2020 06:00:26 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-9-gd3796afa6e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via d3796afa6e812700caf9fbe06e5f42b44453aefb (commit) from d972e5fb878fcdc698d399bce1902560458cee00 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d3796afa6e812700caf9fbe06e5f42b44453aefb Author: Jonathan Druart Date: Fri May 22 10:23:55 2020 +0200 Bug 25576: Add link to the manual for the ILL module Test plan: Enable ILLModule system preference. Go to ILL requests Click Help Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 50b6e447735ee31a2fbba5b116959cdb6d451c19) Signed-off-by: Lucas Gass (cherry picked from commit abc259607eb9b0a8e9781e29c664fecfce103ac2) Signed-off-by: Aleisha Amohia (cherry picked from commit 0bc4e414593b4d57576d2f9615ed3146b4acb6b3) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: Koha/Manual.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 3 07:41:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jul 2020 05:41:47 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-7-g2ddae7366c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 2ddae7366c4247609b9ea561f655b4e5267ddbf1 (commit) from 525ca46cc7a89f23d816de7e5aee9c3a67b8392d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2ddae7366c4247609b9ea561f655b4e5267ddbf1 Author: Jonathan Druart Date: Thu May 28 12:11:37 2020 +0200 Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull" On the "Holds to pull" view there are filters that are built on the value of the cells. Bug 22536 improved the ergonomic by adding a ul list, but the filters are now broken, the ul and li tags are retrieved and put in the filter list. The idea of this patch is to remove the HTML tags and skip if the value is then empty. Test plan: Place a hold on an item Go to Home › Circulation › Holds to pull Open the "libraries" filter => Without this patch you see empty entries => With this patch the filter contain only the libraries Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 4f70682c56dddd42f24c62d7634f5cd3b7119702) Signed-off-by: Lucas Gass (cherry picked from commit 58c071fad3f63de8e069baa84ddea9656e689913) Signed-off-by: Aleisha Amohia (cherry picked from commit d680ae35f39c0eb413b45339aadfa9148a58ed55) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 3 08:24:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Jul 2020 06:24:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-11-g2033a297cb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 2033a297cb49f06ef5cc262854307edea99e71ab (commit) from ecc3d1957fa979dec98f518921f0895a6adb84ac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2033a297cb49f06ef5cc262854307edea99e71ab Author: Caroline Cyr La Rose Date: Wed May 6 16:22:57 2020 -0400 Bug 25394: Cronjob path in the AuthorityMergeLimit syspref description is wrong Test plan: 1- Apply patch 2- Go to Administration > Global system preferences > Authorities 3- The path to merge_authorities.pl in the AuthorityMergeLimit description should now read misc/cronjobs/merge_authorities.pl Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 772205bab5c7d6720ca6d25244c04cdf7649a96f) Signed-off-by: Lucas Gass (cherry picked from commit 8deb5f874ef719db04f37e9741e88fd6ba200515) Signed-off-by: Aleisha Amohia (cherry picked from commit b10e9ce6ab675067d8b78600ebe86d2a4735deb4) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 3 01:45:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Jul 2020 23:45:34 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-4-geeb9c8b9c2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via eeb9c8b9c23d7aa5bacae81fe4e8c5c8d9b28da9 (commit) from 0528d42f711bb091b19ba7880d74b806b8377820 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eeb9c8b9c23d7aa5bacae81fe4e8c5c8d9b28da9 Author: David Cook Date: Tue Jun 9 15:38:27 2020 +1000 Bug 25696: Correct "Test prediction pattern" HTML button This patch corrects the closing tag for the "Test prediction pattern" button from "" to "" Test plan: 1. Apply the patch 2. Create a serial subscription from a new or existing bib record 3. Choose any frequency, numbering pattern, and subscription start date you choose (ie fill out all mandatory subscription fields) 4. Click "Test prediction pattern" 5. Note that the prediction pattern appears on the right of the screen Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 4116ca4097732977d7b954a881f191174c28d651) Signed-off-by: Lucas Gass (cherry picked from commit 4001d4a9a0e0a8c2523aa82d7f042caa64409257) Signed-off-by: Aleisha Amohia (cherry picked from commit 7c0b9d9108b5e63d0c1ee6a6438f453fec136656) Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Jul 5 05:04:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 05 Jul 2020 03:04:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-13-g9b6e78fd24 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 9b6e78fd249a561cef762193b6cf8cccb12da558 (commit) from 3c6bd758b8b812afc0c43c4907d82f6d4fae9aac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9b6e78fd249a561cef762193b6cf8cccb12da558 Author: Katrin Fischer Date: Sat May 23 04:41:59 2020 +0000 Bug 24353: [19.05] Correct display of privacy_guarantor_checkouts on moremember.pl The variable for 'Show checkouts to guarantor' was incorrect so it would always show as 'No' on the Details tab in the patron account in staff. To test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl (Details tab) - Apply patch - Confirm the display changes to "Yes" - Change the value to "No" in the patron record - Verify that the display changed accordingly Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Alex Arnaud RMaint: pushed to 19.05.x Signed-off-by: Victor Grousset/tuxayo ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 8 05:58:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Jul 2020 03:58:05 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-1-g6ca279130e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 6ca279130eacb98c2eb7ea8c4559b5ef4fd51af8 (commit) from 21c94b6144dd5ec7970911a811595dfb05dc15e1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6ca279130eacb98c2eb7ea8c4559b5ef4fd51af8 Author: Aleisha Amohia Date: Thu Jun 25 09:08:16 2020 +1200 Bug 25861: Removing non-existent 'important' field from SQL Bug 17232 updated some SQL queries used when adding new MARC bibliographic frameworks. When backported to 19.11.x, it referenced a column `important` that does not exist in marc_tag_structure or marc_subfield_structure in 19.11.x. This patch removes the references to `important` so that adding new bibliographic frameworks works again. To test: 1) Ensure you have checked out 19.11.x branch 2) Go to Admin -> MARC bibliographic frameworks 3) Add a new framework and save 4) Go to Actions -> MARC structure for your new framework 5) Use the 'create framework using' dropdown to import the structure from an existing framework 6) Note that the structure does not populate, and there is now an error in the logs "Unknown column 'important'" 7) Apply this patch and restart services 8) Repeat steps 3-5 9) Confirm the structure is populated correctly and there is no error in the logs Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Aleisha Amohia ----------------------------------------------------------------------- Summary of changes: admin/marctagstructure.pl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 9 12:33:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Jul 2020 10:33:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-216-g46d3ec264c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 46d3ec264c4e46cc73ee1713b5c39e6c564e5a1a (commit) via d53b58cab858f06be7f9762b16b89c8bfbce5625 (commit) via 6250c2dc1556dbf0ef87f2bb36f13534cb2e2368 (commit) via 5c581265abff940350df83a52228085aa0792fe0 (commit) via 0b69ff1ed7a775b6fdca8513d1ec5a692e30bbe9 (commit) via 7b66b90fe707e8ac650a1c85d87560fc2f4a223d (commit) via 7555ecaafa3bd8bbf0514f3c2672cb41ff7e0aa7 (commit) via 2ab6018b6e14ae2153093db148f04f71405f4493 (commit) via 579a3c11edf77d36488f352d88ae373cc4cbfa21 (commit) via c1e1c233ca69fe9f73efb1c939148f8c7afcf11e (commit) from d3f0fc135b0b73b7dcf7fee09ca30a42e2e514a3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 46d3ec264c4e46cc73ee1713b5c39e6c564e5a1a Author: Bernardo Gonzalez Kriegel Date: Sun May 24 08:51:27 2020 -0300 Bug 25443: (follow-up) surround strings with Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit d53b58cab858f06be7f9762b16b89c8bfbce5625 Author: Katrin Fischer Date: Sun May 24 02:04:03 2020 +0200 Bug 25443: Improve translation of 'Select the record to link%s to' Before this patch the title was set in italic, which caused the translation string to be cut off. Removing the italic formatting in favor of quotes and splitting the string into 2 sentences (dealing with title existing and not existing: Select the host record to link to '[% bibliotitle | html %]' Select the host record to link To test: - Activate EasyAnalyticalRecords system preference - Search for a record in staff - Use Edit > Link to host record - Verify the text is shown as above with the reord's title - The second case is a bit theoretical: - Delete 245$a from the record or empty out biblio.title using SQL - Verify the string still shows but without the 'to...' part. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 6250c2dc1556dbf0ef87f2bb36f13534cb2e2368 Author: Nick Clemens Date: Mon Jun 29 11:04:59 2020 +0000 Bug 25890: Update sorting column for checkouts table Test plan: - Check some items out, all from different libraries - Modify the checkout and due dates, like: 2018-10-22 2018-01-23 2018-05-27 - Sort by checkout date, verify it is actually sorting on homebranch - Apply patch - Reload page - Note you can now sort items correctly Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 5c581265abff940350df83a52228085aa0792fe0 Author: Slava Shishkin Date: Thu Jun 18 12:11:29 2020 +0300 Bug 25695: merge of similar code blocks after circulation_rules update In onboarding.pl we have second block with adding just one more rule parameter (maxissueqty) which can be merged to first one after all parameters now stored in circulation_rules table. Also this eliminates the need of adding forgotten "warn $@" after the second eval block. Mentored-by: Andrew Nugged Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 0b69ff1ed7a775b6fdca8513d1ec5a692e30bbe9 Author: Kyle M Hall Date: Thu Jul 2 08:32:51 2020 -0400 Bug 25914: Fix incorrect variable name causing relative's checkouts column to be empty in OPAC In the OPAC, the title column in the relatives checkouts table is always empty. Test Plan: 1) Enable viewing of relative's checkouts in OPAC 2) Check some items out to a patron 3) Log into the OPAC as a relative of that patron that should be able to view them 4) Note the title column is empty in the relative's checkouts tab 5) Apply this patch 6) Reload the page 7) Titles should appear in the title column! Signed-off-by: Owen Leonard Signed-off-by: Alex Arnaud Signed-off-by: Jonathan Druart commit 7b66b90fe707e8ac650a1c85d87560fc2f4a223d Author: Alex Buckley Date: Sun Jun 14 22:41:03 2020 +0000 Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded If 'Actual cost' has not been set then it has the value of 0.00 which Perl evaluates to true so this patchset resets it to 0, so the fallback to ecost_tax_included/ecost_tax_excluded happens. Test plan: 1. Add item to acquisition basket (make sure the vendor has: tax rate: 15%, 'List prices: Include tax', 'Invoice prices: Include tax') 2. Set 'Vendor price' = 10 and do not set 'Actual cost' 3. Save order 4. Observe basket.pl shows 'Total tax exc.' has a value of 0.00 and GST column has value of -8.70 5. Jump into the database: select tax_value_on_ordering from aqorders where ordernumber=; [You can get the ordernumber from clicking on the 'Modify' line the item is listed in] 6. Observe a negative value: -8.70 7. Apply patch and restart plack 8. Add a second item to the basket 9. Set 'Vendor price' = 10 and don't set 'Actual cost' 10. Save order 11. Observe basket.pl shows 'Total tax exc' has value of 8.70 and GST has value of 1.30 12. Repeat step 5 and observe tax_value_on_ordering = 1.30 13. Run t/Prices.t unit test: sudo koha-shell prove t/Prices.t Sponsored-by: Horowhenua District Council, NZ Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 7555ecaafa3bd8bbf0514f3c2672cb41ff7e0aa7 Author: Jonathan Druart Date: Mon Jun 15 16:11:49 2020 +0200 Bug 25752: Stay in cwd after koha-shell After bug 25538, after a koha-shell we are not longer in the current directory: root at cec7bffd8100:koha(master)$ pwd /kohadevbox/koha root at cec7bffd8100:koha(master)$ sudo koha-shell kohadev kohadev-koha at cec7bffd8100:~$ pwd /var/lib/koha/kohadev Test plan: Repeat the commands above and confirm that with this version of the script you get /kohadevbox/koha inside the koha-shell Search for possible regressions Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 2ab6018b6e14ae2153093db148f04f71405f4493 Author: Nick Clemens Date: Wed Jun 24 12:20:03 2020 +0000 Bug 25864: Lower case fields for searching To recreate: 1 - Have Koha using ES5 and Elasticsearch as search engine 2 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate 3 - Do a search in authorities using 'Search entire record' (abduction if using sample db) 4 - Note no results 5 - View the page source and find 'search_query' 6 - Note the uppercased fields 7 - curl 'es:9200/koha_kohadev_authorities/data/417?pretty' 8 - Note all fields lower-cased 9 - Apply patch 10 - Repeat search 11 - It works! Signed-off-by: Heather Hernandez Signed-off-by: Alex Arnaud Signed-off-by: Jonathan Druart commit 579a3c11edf77d36488f352d88ae373cc4cbfa21 Author: Nick Clemens Date: Wed Jun 24 12:22:48 2020 +0000 Bug 25864: Unit test adjustment Signed-off-by: Alex Arnaud Signed-off-by: Jonathan Druart commit c1e1c233ca69fe9f73efb1c939148f8c7afcf11e Author: Jonathan Druart Date: Wed Jun 24 08:37:18 2020 +0200 Bug 25851: (bug 18928 follow-up) Remove holdallowed rule is value is an empty string On the interface, if "Hold policy" is "Not set", the rule does not exist in the table. We should reflect that during the update DB process. Test plan: 1. Set "Hold policy" to "Not set" 2. Confirm that you can place holds 3. Confirm that the rule does not exist in the DB table 4. Set the value to an empty string (manually) 5. Confirm that you cannot longer place holds 6. Go to the circulation rules page and confirm that the value of "Hold policy" is "Not set" 7. Execute the update DB entry 8. Confirm that you can place holds 9. Confirm that the rule does not exist in the DB table Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 1 + Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +- acqui/basket.pl | 2 + debian/scripts/koha-shell | 3 +- installer/data/mysql/atomicupdate/bug_25851.perl | 7 +++ installer/data/mysql/updatedatabase.pl | 3 ++ installer/onboarding.pl | 23 +--------- .../prog/en/modules/cataloguing/linkitem.tt | 8 +++- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +- t/Prices.t | 52 +++++++++++++++++++++- .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 4 +- 12 files changed, 81 insertions(+), 30 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_25851.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 17:44:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 15:44:34 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-2-gf918bee5f6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via f918bee5f612b3eef54bd81999373ed023e737b4 (commit) from 2285a11a2be5479847335a02790a1c09ee31f1e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f918bee5f612b3eef54bd81999373ed023e737b4 Author: Owen Leonard Date: Mon May 11 19:17:57 2020 +0000 Bug 25447: Terminology: Fix button text "Edit biblio" This patch changes the cataloging main page so that in the menu for reach search result the "Edit biblio" link is now "Edit record." To test, apply the patch and do a search in cataloging. In the list of search results verify that the "Actions" menu contains a link labeled "Edit record." Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 679dcd1574de88cb8b7002c5020e0b4488233943) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 17:49:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 15:49:05 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-3-gca74f037d8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ca74f037d83a7c406f187bdfe77cbed7b2f4aade (commit) from f918bee5f612b3eef54bd81999373ed023e737b4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ca74f037d83a7c406f187bdfe77cbed7b2f4aade Author: Jonathan Druart Date: Fri May 22 11:02:39 2020 +0200 Bug 25553: Make date columns sortable on the edit items table When editing items, the table at the top contain several columns that have date values, but they cannot be sorted by dates correctly. Test plan: Have several items with different dates in columns that contain dates, like items.dateaccessioned, items.datelastseen) Sort the column and confirm that with this patch the lines are sorted correctly Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 31800ba46b2ed03cc2e4431c4d3c56fce678a0ec) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: cataloguing/additem.pl | 2 +- .../intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 14 ++++++++++++-- 2 files changed, 13 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 17:52:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 15:52:16 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-4-g41ad2ba4db Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 41ad2ba4db8d70f5010f530883ded02c0641329d (commit) from ca74f037d83a7c406f187bdfe77cbed7b2f4aade (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 41ad2ba4db8d70f5010f530883ded02c0641329d Author: Kyle M Hall Date: Tue Jun 16 08:00:45 2020 -0400 Bug 25769: Patron self modification triggers change request for date of birth to null If PatronSelfModificationBorrowerUnwantedField contains dateofbirth, all patron self modification requests will attempt to set dateofbirth to null instead of ignoring the field. Test Plan: 1) Add dateofbirth to PatronSelfModificationBorrowerUnwantedField 2) Run a patron self modification 3) Note the request sets dateofbirth to null on the staff side 4) Apply this patch 5) Restart all the things! 6) Run another self-modification 7) Note of the staff side that dateofbirth is unaffected Signed-off-by: Emmi Takkinen Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 73c421a5164a3af4b2b8e1001b49f29213a94e3a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: opac/opac-memberentry.pl | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 18:02:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 16:02:17 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-6-gec269b88d9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ec269b88d91091948ec4507de59c2a3edbb0cfe1 (commit) via cf57b25264ffb17ac0d480acc5b3e616aeb4378d (commit) from 41ad2ba4db8d70f5010f530883ded02c0641329d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ec269b88d91091948ec4507de59c2a3edbb0cfe1 Author: Katrin Fischer Date: Sun Jun 14 14:02:49 2020 +0200 Bug 12093: (QA follow-up) Fix typo 'noteforloan' Just changes one character in the noteforloan class to notforloan. Signed-off-by: Jonathan Druart (cherry picked from commit 9681b8a1ca4cf4a92642ca262778a28af05b93d1) Signed-off-by: Lucas Gass commit cf57b25264ffb17ac0d480acc5b3e616aeb4378d Author: David Roberts Date: Sat May 9 22:14:10 2020 +0000 Bug 12093: Add CSS classes to item statuses in detail view This patch adds classes where necessary to detail.pl To test: 1) Apply patch 2) View source of /cgi-bin/koha/catalogue/detail.pl to check that there are no orphaned statuses without classes. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit ee657b6e5aa0dc9a292260b01dc810fe3d5e2f50) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/catalogue/detail.tt | 36 ++++++++++++---------- 1 file changed, 19 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 18:06:35 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 16:06:35 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-7-ge6d22b9e9f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e6d22b9e9fa4169a8fb0e283e460d05c09276498 (commit) from ec269b88d91091948ec4507de59c2a3edbb0cfe1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e6d22b9e9fa4169a8fb0e283e460d05c09276498 Author: Owen Leonard Date: Thu Jun 18 11:56:38 2020 +0000 Bug 25804: Remove HTML from title tag of bibliographic detail page This patch removes tags from the bibliographic detail page's tag. To test, apply the patch and view the bibliographic detail page for any title in the staff interface. In the page title shown in the browser tab you should see no <span> tags. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c0f6f3c635170b6183bfa34244ffebad537e1e0b) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 18:15:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 16:15:33 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-10-g18051cb02a Message-ID: <E1jtvgT-0003eq-S7@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 18051cb02a483dc020afc31b82e3897daba8a793 (commit) via 16530f09687f48cb621c1a1dfc1559fc35979d51 (commit) via fc8bde417820d2f287df997a44136ea0b504b0f7 (commit) from e6d22b9e9fa4169a8fb0e283e460d05c09276498 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 18051cb02a483dc020afc31b82e3897daba8a793 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu May 21 18:25:46 2020 -0300 Bug 25570: (follow-up) Fix tests This patch fixes the libraries tests, that expected the old behaviour To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/libraries.t => FAIL: Tests fail 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit b115dfeca649f2f35e0290ead85f2626eabd0829) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 16530f09687f48cb621c1a1dfc1559fc35979d51 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu May 21 18:23:01 2020 -0300 Bug 25570: Paginate results by default in objects->search This patch makes the helper paginate the resultsif no pagination parameters are passed. Page number defaults to 1, and the page size to the RESTdefaultPageSize syspref value. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Pagination is not enforced by default 3. Apply this patch 4. Repeat 2 => SUCCESS: Results are paginated 5. Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 451ae76431d3d580494f917ed397f259cd96a876) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit fc8bde417820d2f287df997a44136ea0b504b0f7 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu May 21 17:48:21 2020 -0300 Bug 25570: Regression tests This tests verify that the default behaviour is to paginate the results. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: $c->objects->search doesn't paginate results by default Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 2220ce4d50998bef1dcea787d212a287a802b0aa) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha/REST/Plugin/Objects.pm | 4 ++++ t/db_dependent/Koha/REST/Plugin/Objects.t | 22 +++++++++++++++++++++- t/db_dependent/api/v1/libraries.t | 13 ++++++++----- 3 files changed, 33 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 18:19:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 16:19:46 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-11-g898bd1256a Message-ID: <E1jtvkY-0003pK-D7@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 898bd1256af37f5c4ec945e1d99b5146eecc2231 (commit) from 18051cb02a483dc020afc31b82e3897daba8a793 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 898bd1256af37f5c4ec945e1d99b5146eecc2231 Author: David Cook <dcook at prosentient.com.au> Date: Fri May 15 14:55:49 2020 +1000 Bug 25509: Remove useless libjs-jquery dependency We don't use the libjs-jquery package, so we should remove the dependency. To Test: 1) Build package (out of scope of test plan) 2) Install package 3) Note that libjs-jquery is marked by apt as no longer required 4) Remove libjs-jquery package from system and note how it doesn't take koha-common with it Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 9e923e57ed18a104c33cc10a4704450ec4c71c28) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: debian/control.in | 2 -- 1 file changed, 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 18:24:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 16:24:36 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-13-ge5baeac0fd Message-ID: <E1jtvpE-0003wM-Nf@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e5baeac0fdbc5fc83256effeff304e736c7dc154 (commit) via 6a395eab2d3ce6c9564b387eaa8f863632518997 (commit) from 898bd1256af37f5c4ec945e1d99b5146eecc2231 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e5baeac0fdbc5fc83256effeff304e736c7dc154 Author: Nick Clemens <nick at bywatersolutions.com> Date: Tue Apr 28 15:34:20 2020 +0000 Bug 25189: Don't create authority if results found Automatic authority creation assumes that if we don't match we need a new authority. Using the Default linker, however, we don't match if there exists more than one match. This leads to repeatedly generating authorities once there is a duplicate in the system We shoudl instead only create a new authority if there are no results To test: 1 - Set Linker Module to 'Default' 2 - Enable AutoCreateAuthorities and BiblioAddsAuthorities and CatalogModuleRelink and LinkerRelink 3 - Add two copies of a single authority via Z39 4 - Add a heading for that authority to a bib record 5 - Save the record and note a new authority is generated 6 - Repeat and see another is generated 7 - Apply patch 8 - Restart all the things 9 - Save the record again, no new authority created Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 980419ed15cd4e5ae8be552218f939f5faea18c4) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 6a395eab2d3ce6c9564b387eaa8f863632518997 Author: Nick Clemens <nick at bywatersolutions.com> Date: Tue Apr 28 13:29:52 2020 +0000 Bug 25189: Unit tests Adds new test for not adding authority if some already exist Also replaces use of 'SearchAuthorities' as it is Zebra specific Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 258d0b0ecd6450fea09677f0607efdedb33cc16c) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 4 ++-- C4/Linker/Default.pm | 4 +++- t/db_dependent/Biblio.t | 36 ++++++++++++++++++++++++++++++++---- 3 files changed, 37 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 18:28:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 16:28:49 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-14-g0aa981c913 Message-ID: <E1jtvtJ-00043Z-1h@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 0aa981c91319450b4c4c8641845c2098f3f73d0b (commit) from e5baeac0fdbc5fc83256effeff304e736c7dc154 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0aa981c91319450b4c4c8641845c2098f3f73d0b Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Jun 16 19:48:48 2020 +0000 Bug 24352: Correct location and collection labels in OPAC search results This patch modifies the OPAC's MARC21 search results XSLT so that OPAC search result information is correctly labeled based on the OpacItemLocation preference. Previously, search results showed the label "Location(s)" whether the setting was "collection code" or "location." To test, apply the patch and set the OPACXSLTResultsDisplay system preference to 'default.' On the OPAC search results page, each result with items should show information in this format: With the OpacItemLocation preference set to 'call number only,' - "Availability: Items available for loan: {library} [Call number: {call number} ] With the OpacItemLocation preference set to 'collection code,' - "Availability: Items available for loan: {library} Collection(s): {collection description} [{ call number }]" With the OpacItemLocation preference set to 'location,' - "Availability: Items available for loan: {library} Location(s): {shelving location} [{ call number }]" Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 897948cff5812a67144355829cf8915af17465d0) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 18:34:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 16:34:25 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-17-g42e8c0185c Message-ID: <E1jtvyj-0004Ax-Dt@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 42e8c0185cf50b93789f3cfe6d4532565e084aeb (commit) via e15992e4eb1e194a8ecc3bf8f04b5a74e6e5520a (commit) via 6f9b44c95a02e5f24d4441622949225757db1b95 (commit) from 0aa981c91319450b4c4c8641845c2098f3f73d0b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 42e8c0185cf50b93789f3cfe6d4532565e084aeb Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Fri May 1 20:11:29 2020 +0000 Bug 11994: (follow-up) Make things work when LibraryName is empty When LibraryName system preference was not set, the installation of the plugin would fail with: Firefox could not download the search plugin from: ... Now if the pref is empty, the description 'Library catalog' will be used instead. To test: - Empty your LibraryName pref - Verify the search plugin can still be installed (see first patch for further instructions) Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 1e0dd6d0783a66514fc92cc0a34ca0882a5ce62f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit e15992e4eb1e194a8ecc3bf8f04b5a74e6e5520a Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Fri May 1 17:20:43 2020 +0000 Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml https://developer.mozilla.org/en-US/docs/Web/OpenSearch Your server should serve OpenSearch plugins using Content-Type: application/opensearchdescription+xml. To test: - Verify the Content-Type the file is delivered with is correct, for example using wget http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?format=opensearchdescription Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f090c1d2cb9253d77c5bac3b8fa03c775af2f0f6) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 6f9b44c95a02e5f24d4441622949225757db1b95 Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Apr 28 14:41:47 2020 +0000 Bug 11994: Fix OpenSearch discovery in the OPAC This patch corrects the markup for the OpenSearchDescription XML document and adds (back) the link in the OPAC header which points to it. This will enable compatible browsers to offer the addition of the OPAC's keyword search as a search engine option. I've found documentation suggesting this feature is available (or at least was at one time) in Chrome and Safari, but in my test it only works in Firefox. To test, apply the patch and make sure the OPACBaseURL preference is set correctly. - Open the OPAC in Firefox (these instructions assume the latest version, currently v.75). - On the right side of the address bar you should see ". . ." Click it to trigger the menu. - You should see an "Add search engine" entry with your OPAC's icon. - Click to add the search engine. - Type a keyword to search in the address bar - A box should pop up below the address bar showing icons at the bottom for performing a search in various search engines. One of these icons should be the icon for your Koha OPAC. - Click the Koha OPAC icon and confirm that it triggers a keyword search in your OPAC. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0ef7b3db4cab73797ba3386b4951c0d86addf871) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Output.pm | 5 ++-- .../bootstrap/en/includes/doc-head-close.inc | 1 + .../bootstrap/en/modules/opac-opensearch.tt | 33 +++++++++++++--------- opac/opac-search.pl | 2 +- 4 files changed, 24 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 18:37:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 16:37:52 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-18-gb2514759bc Message-ID: <E1jtw24-0004HY-TP@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via b2514759bcd4b5d3cb5758bf66890f1d84a2c586 (commit) from 42e8c0185cf50b93789f3cfe6d4532565e084aeb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b2514759bcd4b5d3cb5758bf66890f1d84a2c586 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Jun 5 11:15:33 2020 +0200 Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor Reported-by: Kelly McElligott <kelly at bywatersolutions.com> Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit cd716269a7b2b1b6165154ea7e85844201402a8d) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: acqui/basketheader.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 18:41:02 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 16:41:02 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-19-g3fdec87057 Message-ID: <E1jtw58-0004Ly-2Y@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3fdec870573700d2d0d585b7453f279c25e116a1 (commit) from b2514759bcd4b5d3cb5758bf66890f1d84a2c586 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3fdec870573700d2d0d585b7453f279c25e116a1 Author: Andreas Roussos <a.roussos at dataly.gr> Date: Mon Jun 15 16:58:38 2020 +0200 Bug 25756: remove erroneous hyphen In the Staff Client, the OPAC "Appearance" preferences table has an extra, empty HTML table row at the end. Test plan: 0) Observe the empty HTML table row at the end of the table that lists OPAC "Appearance" system preferences. 1) Apply this patch. 2) Observe that the empty table row is now gone. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 251197ad73ba2be88ac2154db46748b58a0597f8) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 18:57:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 16:57:46 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-20-g773dd857ee Message-ID: <E1jtwLK-0004fY-Kd@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 773dd857eed7e6eca01a8c098b973e20356157a3 (commit) from 3fdec870573700d2d0d585b7453f279c25e116a1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 773dd857eed7e6eca01a8c098b973e20356157a3 Author: Emmi Takkinen <emmi.takkinen at outlook.com> Date: Thu Jun 18 09:36:55 2020 +0300 Bug 25789: Don't allow past date as holds expiration date When editing existing holds expiration date it's possible to select past date from datepicker. This patch changes expiration inputs class as "datepickerto" to make past dates unselectable. To test: 1. Find item with holds 2. Edit holds expiration date => Note that past dates are selectable 3. Apply patch 4. Edit again => Past dates are no longer selectable Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c3365a35963742b294a4c8631b22aa34dac228d9) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 19:00:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 17:00:40 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-21-g7d4d03d1be Message-ID: <E1jtwO8-0004oH-AI@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7d4d03d1bef5e14760e0ea639a8edeb796c633a7 (commit) from 773dd857eed7e6eca01a8c098b973e20356157a3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7d4d03d1bef5e14760e0ea639a8edeb796c633a7 Author: Owen Leonard <oleonard at myacpl.org> Date: Mon Jun 15 11:14:22 2020 +0000 Bug 25747: Don't display a comma when patron has no firstname This patch adds a check for the existence of "firstname" to patron-title.inc so that if the patron has no firstname the "invert name" setting doesn't cause an unnecessary comma to appear. To test, apply the patch and locate or create a patron with no first name. - When checking out to the patron, examine the page title. It should say "Checking out to <lastname> (<cardnumber>). - When checking out to a patron with first and last name it should show as before, "Checking out to <lastname>, <firstname> (<cardnumber) Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d2f136713e814d4e33e18d1cdad88f3675a9ec3a) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 19:03:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 17:03:41 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-22-g8d1494ba5c Message-ID: <E1jtwR4-0004w0-05@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 8d1494ba5c84cab6361f355b1c84c4ac1456a697 (commit) from 7d4d03d1bef5e14760e0ea639a8edeb796c633a7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d1494ba5c84cab6361f355b1c84c4ac1456a697 Author: Petro Vashchuk <stalkernoid at gmail.com> Date: Wed Jun 10 15:36:01 2020 +0300 Bug 25699: Add edition information to "Holds to pull" report Added a feature that displays edition information of the book together with title in "Holds to pull" report. Edition information is fetched from "biblioitem" table as "editionstatement" and transferred to template. Those changes don't have performance impact as all tables including "biblioitem" were already used and joined in this request. Mentored-by: Andrew Nugged <nugged at gmail.com> Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 2e14a0a3fa317191bf0ee735988a83b8f59d4ed5) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: circ/pendingreserves.pl | 52 +++++++++++----------- .../prog/en/modules/circ/pendingreserves.tt | 1 + 2 files changed, 28 insertions(+), 25 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 19:07:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 17:07:17 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-23-ge68d2e9079 Message-ID: <E1jtwUX-00050l-J9@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e68d2e9079b498d214441f8d22119d873c8b4e1e (commit) from 8d1494ba5c84cab6361f355b1c84c4ac1456a697 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e68d2e9079b498d214441f8d22119d873c8b4e1e Author: Owen Leonard <oleonard at myacpl.org> Date: Tue May 12 21:27:05 2020 +0000 Bug 25471: Add DataTables to MARC subfield structure admin page This patch adds DataTables sorting and filtering to the table of subfields shown on the MARC subfield structure administration page. To test, apply the patch and go to Administration -> MARC bibliographic framework. - From the 'Actions' menu, select 'MARC structure.' - From the 'Actions' menu, select the 'View subfields' link for a tag with multiple subfields. - On the page showing all the subfields for the tag, confirm that the table is sorted by default by subfield and that sorting works correctly. - Confirm that the search form at the top of the table works. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 7ff774509d8c3fc4747857dcfeee7a2cf7557921) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/marc_subfields_structure.tt | 9 +++++++-- koha-tmpl/intranet-tmpl/prog/js/marc_subfields_structure.js | 8 +++++++- 2 files changed, 14 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 19:27:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 17:27:14 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-25-g64394eaac6 Message-ID: <E1jtwnq-0005PB-Fm@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 64394eaac69c8c8e2b81adf13b55772dcd7ab4b0 (commit) via 967c930b01e8364dae12585d749cd5aef84c58e4 (commit) from e68d2e9079b498d214441f8d22119d873c8b4e1e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 64394eaac69c8c8e2b81adf13b55772dcd7ab4b0 Author: Owen Leonard <oleonard at myacpl.org> Date: Thu Jun 18 11:31:40 2020 +0000 Bug 25402: (QA follow-up) Remove unused downloadBasket function This patch removes the now-unused downloadBasket function from basket.js. The patch should have no effect on the functionality of the download process. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 6d73c08e7351a772a388b1e1c6157b307fcbc1a8) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 967c930b01e8364dae12585d749cd5aef84c58e4 Author: Owen Leonard <oleonard at myacpl.org> Date: Wed May 6 20:30:32 2020 +0000 Bug 25402: Put OPAC cart download options into dropdown menu This patch modifies the process of downloading a cart so that it doesn't involve a separate popup window. To test, apply the patch and add some titles to the cart in the OPAC. - Open the cart - The "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 174ea44dccd8f0a151a82ba5f8c70e3194065539) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 27 +++++++++++++++++++--- koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 10 -------- opac/opac-basket.pl | 3 ++- 3 files changed, 26 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 19:36:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 17:36:21 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-31-g19efe6d862 Message-ID: <E1jtwwf-0005aZ-T0@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 19efe6d86216301cd03654f358c0171822f07b58 (commit) via e6cd1ced668bdf25307dc041c95557ec71dfff02 (commit) via 0a01f91887ee5ca24c7950cbd59984dbd335404d (commit) via cc75932f3eca746e8e2c08125306a94952b8a87d (commit) via 0e711e024e2ac25347a17d6499289d90c6da29de (commit) via 5574a5850f2a55a3544b3f9d5c95bf491aae4e03 (commit) from 64394eaac69c8c8e2b81adf13b55772dcd7ab4b0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 19efe6d86216301cd03654f358c0171822f07b58 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri Jul 10 17:05:31 2020 +0000 Bug 25236: Compile CSS Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit e6cd1ced668bdf25307dc041c95557ec71dfff02 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 11:54:22 2020 +0100 Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0550e0b7f788b65b50ed4689d677600be3f9c7c2) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 0a01f91887ee5ca24c7950cbd59984dbd335404d Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 11:44:53 2020 +0100 Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 62795521eedc02e11bef520c8b980d480b7e02ae) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit cc75932f3eca746e8e2c08125306a94952b8a87d Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 11:37:26 2020 +0100 Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f88d56f689e514b47930d617049358fdf9b68608) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 0e711e024e2ac25347a17d6499289d90c6da29de Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 12:15:21 2020 +0100 Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 3e18402c240814d7f00a62c3f2359bd9b9d0a098) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 5574a5850f2a55a3544b3f9d5c95bf491aae4e03 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 13:05:31 2020 +0100 Bug 25239: Fix semantic heading for opac-reserve.tt Prior to this patch, the opac-reserve contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Attempt to place a hold on an item. 3/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 4/ Apply this patch and reload the page 5/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 1a96ede5f114bd90fe1735702ca4bab77dfed9d4) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 6 ++++- .../bootstrap/en/includes/opac-facets.inc | 26 +++++++++++----------- .../bootstrap/en/includes/opac-topissues.inc | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- .../en/modules/opac-full-serial-issues.tt | 12 +++++----- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 6 ++--- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 8 +++---- .../bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl | 4 ++-- .../bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 4 ++-- 10 files changed, 39 insertions(+), 33 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 19:50:02 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 17:50:02 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-32-g42e3ce7e92 Message-ID: <E1jtx9u-0005vR-Ee@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 42e3ce7e921e4bd1b54095fd0631bdea2f24d73f (commit) from 19efe6d86216301cd03654f358c0171822f07b58 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 42e3ce7e921e4bd1b54095fd0631bdea2f24d73f Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 13:23:32 2020 +0100 Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 972aeaa0143dcdedc7ae23314a72991d5e4a6490) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 25 ++++++++++------------ 1 file changed, 11 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 19:54:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 17:54:40 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-33-g987eb51a33 Message-ID: <E1jtxEO-00062J-BZ@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 987eb51a3330e69b018633d01ed987d9cf04dfb7 (commit) from 42e3ce7e921e4bd1b54095fd0631bdea2f24d73f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 987eb51a3330e69b018633d01ed987d9cf04dfb7 Author: Hayley Mapley <hayleymapley at catalyst.net.nz> Date: Thu Jun 11 11:48:54 2020 +1200 Bug 25151: Fixing semantic headings in opac-basket.tt Test plan: 1) Apply the patch 2) Add items to your cart/folder/basket 3) Open up the basket and check that the main heading is now an h1 4) Check that the page looks fine Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f002bd17105bab2d16aee8db8ed4f6d688192fc3) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 10 20:01:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Jul 2020 18:01:45 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-39-gc561fda1fb Message-ID: <E1jtxLF-0006BT-Bh@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via c561fda1fb166dd2130b02fbb96c47be771d9b7a (commit) via 30cc30bb996567dc5491f06c5224f1db1163d324 (commit) via b46e0e6771e6a4be965efba3eb9dfb86668c76ca (commit) via 0923ccef50d5052d6e14812eaa20e1e4c37dec89 (commit) via 38bdbb4d5528c68e2ca2d69dfc922a790f09a991 (commit) via c8da2d3278a89df4d670465bfc55e269a4472f4e (commit) from 987eb51a3330e69b018633d01ed987d9cf04dfb7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c561fda1fb166dd2130b02fbb96c47be771d9b7a Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri Jul 10 17:31:08 2020 +0000 Bug 22807: Compile CSS Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 30cc30bb996567dc5491f06c5224f1db1163d324 Author: Owen Leonard <oleonard at myacpl.org> Date: Wed Jun 10 18:30:50 2020 +0000 Bug 22807: (follow-up) Update style of skip button This patch updates the markup and style of the skip button, adapting (i.e. stealing) the style of the skip link at https://webaim.org. To test, apply the patch and rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Go to any page in the OPAC and hit the tab key. The "Skip to main content" link should appear. Tabbing away from it should cause the link to hide. Hitting the ENTER key when the link is highlighted should cause the page to scroll to the main content. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 2e94cb26a8267df72f657fb7c1097d08318e8a21) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit b46e0e6771e6a4be965efba3eb9dfb86668c76ca Author: Owen Leonard <oleonard at myacpl.org> Date: Wed Jun 10 18:42:06 2020 +0000 Bug 22807: (follow-up) Add .maincontent class to libraries page This patch adds a missing "maincontent" class to the "all libraries" view. Previously it was only present on the single library view. To test, apply the patch and go to the "Libraries" page in the OPAC. - Hit the "tab" key to highlight the "Skip to main content" link. - Hit "Enter." - The page should scroll to the top of the list of libraries. - Open one of the library detail pages and confirm that the "Skip to main content" link works on that page too. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 78cfac8dd5d089960e7d34068415b8c7f0bd7775) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 0923ccef50d5052d6e14812eaa20e1e4c37dec89 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed Jun 10 16:56:40 2020 +0100 Bug 22807: Ensure .maincontent appears on all pages Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c5b173f7dec5d94c29249dfa00e61861d5645998) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 38bdbb4d5528c68e2ca2d69dfc922a790f09a991 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed Jun 10 13:57:42 2020 +0100 Bug 22807: Ensure only one maincontent on searcresults Prior to this patch, if you entered a search that returned zero results, you would end up with two 'maincontent' classes on the page Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 6b0887f76e2f561187f6eae78f932987520a9cb6) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit c8da2d3278a89df4d670465bfc55e269a4472f4e Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jun 9 14:10:53 2020 +0100 Bug 22807: Add 'Skip to content' option This patch adds a 'Skip to content' link to the header bar which will only appear upon the first use of 'tab' to navigate after any fresh page load in the OPAC. Test plan 1/ Load any page in the OPAC 2/ Hit the `tab` key 3/ Note the new 'Skip to main content' link appears at the top left of the screen. 4/ Hit `Enter` or Click the button 5/ Note the page scrolls to the area of the page that has the first block containing a .maincontent class. 6/ Note that the next available focusable element after the first .maincontent block has been given focus. 7/ Note that the link has been hidden Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c36560a1ad731af955c005306c2c2800057cd890) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 25 ++++ .../opac-tmpl/bootstrap/en/includes/masthead.inc | 1 + .../opac-tmpl/bootstrap/en/modules/maintenance.tt | 2 +- .../bootstrap/en/modules/opac-addbybiblionumber.tt | 2 +- .../bootstrap/en/modules/opac-alert-subscribe.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-blocked.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-browse.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-browser.tt | 2 +- .../bootstrap/en/modules/opac-course-details.tt | 141 +++++++++++---------- .../bootstrap/en/modules/opac-course-reserves.tt | 3 +- .../bootstrap/en/modules/opac-discharge.tt | 2 +- .../bootstrap/en/modules/opac-imageviewer.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-library.tt | 29 +++-- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 8 +- .../modules/opac-memberentry-update-submitted.tt | 2 +- .../bootstrap/en/modules/opac-memberentry.tt | 4 +- .../bootstrap/en/modules/opac-messaging.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 2 +- .../bootstrap/en/modules/opac-password-recovery.tt | 2 +- .../bootstrap/en/modules/opac-patron-consent.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 2 +- .../bootstrap/en/modules/opac-readingrecord.tt | 2 +- .../en/modules/opac-registration-confirmation.tt | 2 +- .../en/modules/opac-registration-email-sent.tt | 2 +- .../en/modules/opac-registration-invalid.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- .../bootstrap/en/modules/opac-results-grouped.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 14 +- .../opac-tmpl/bootstrap/en/modules/opac-review.tt | 2 +- .../bootstrap/en/modules/opac-serial-issues.tt | 2 +- .../bootstrap/en/modules/opac-tags_subject.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/js/global.js | 46 +++++++ 33 files changed, 203 insertions(+), 116 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 00:28:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 12 Jul 2020 22:28:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-2-gf208817b13 Message-ID: <E1jukSt-0004sK-SL@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via f208817b13636e0b4746b1bfe5d5e5a13de39b88 (commit) from 6ca279130eacb98c2eb7ea8c4559b5ef4fd51af8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f208817b13636e0b4746b1bfe5d5e5a13de39b88 Author: Owen Leonard <oleonard at myacpl.org> Date: Mon May 11 19:17:57 2020 +0000 Bug 25447: Terminology: Fix button text "Edit biblio" This patch changes the cataloging main page so that in the menu for reach search result the "Edit biblio" link is now "Edit record." To test, apply the patch and do a search in cataloging. In the list of search results verify that the "Actions" menu contains a link labeled "Edit record." Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 679dcd1574de88cb8b7002c5020e0b4488233943) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit f918bee5f612b3eef54bd81999373ed023e737b4) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 00:47:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 12 Jul 2020 22:47:49 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-3-g99a27050d8 Message-ID: <E1juklB-0005Ja-Kq@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 99a27050d84281643f40bbdb5d0adb4edbf32e15 (commit) from f208817b13636e0b4746b1bfe5d5e5a13de39b88 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 99a27050d84281643f40bbdb5d0adb4edbf32e15 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri May 22 11:02:39 2020 +0200 Bug 25553: Make date columns sortable on the edit items table When editing items, the table at the top contain several columns that have date values, but they cannot be sorted by dates correctly. Test plan: Have several items with different dates in columns that contain dates, like items.dateaccessioned, items.datelastseen) Sort the column and confirm that with this patch the lines are sorted correctly Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 31800ba46b2ed03cc2e4431c4d3c56fce678a0ec) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit ca74f037d83a7c406f187bdfe77cbed7b2f4aade) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: cataloguing/additem.pl | 2 +- .../intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 14 ++++++++++++-- 2 files changed, 13 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 00:53:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 12 Jul 2020 22:53:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-4-gc21ae5e517 Message-ID: <E1jukqQ-0005i7-6U@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c21ae5e5177ec9180f07fd5639b7e9912aadfdc1 (commit) from 99a27050d84281643f40bbdb5d0adb4edbf32e15 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c21ae5e5177ec9180f07fd5639b7e9912aadfdc1 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Tue Jun 16 08:00:45 2020 -0400 Bug 25769: Patron self modification triggers change request for date of birth to null If PatronSelfModificationBorrowerUnwantedField contains dateofbirth, all patron self modification requests will attempt to set dateofbirth to null instead of ignoring the field. Test Plan: 1) Add dateofbirth to PatronSelfModificationBorrowerUnwantedField 2) Run a patron self modification 3) Note the request sets dateofbirth to null on the staff side 4) Apply this patch 5) Restart all the things! 6) Run another self-modification 7) Note of the staff side that dateofbirth is unaffected Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 73c421a5164a3af4b2b8e1001b49f29213a94e3a) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 41ad2ba4db8d70f5010f530883ded02c0641329d) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: opac/opac-memberentry.pl | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 01:17:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 12 Jul 2020 23:17:47 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-7-gafcd1902c0 Message-ID: <E1julEB-0006NE-P7@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via afcd1902c03f72ef61846d3a034c7b5086b3c812 (commit) via 55fba122759a85ea5b45a36908d67c310af1ea0c (commit) via 429d56d3894cffb4febe45616a3073e95191af67 (commit) from c21ae5e5177ec9180f07fd5639b7e9912aadfdc1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit afcd1902c03f72ef61846d3a034c7b5086b3c812 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu May 21 18:25:46 2020 -0300 Bug 25570: (follow-up) Fix tests This patch fixes the libraries tests, that expected the old behaviour To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/libraries.t => FAIL: Tests fail 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit b115dfeca649f2f35e0290ead85f2626eabd0829) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 18051cb02a483dc020afc31b82e3897daba8a793) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 55fba122759a85ea5b45a36908d67c310af1ea0c Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu May 21 18:23:01 2020 -0300 Bug 25570: Paginate results by default in objects->search This patch makes the helper paginate the resultsif no pagination parameters are passed. Page number defaults to 1, and the page size to the RESTdefaultPageSize syspref value. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Pagination is not enforced by default 3. Apply this patch 4. Repeat 2 => SUCCESS: Results are paginated 5. Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 451ae76431d3d580494f917ed397f259cd96a876) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 16530f09687f48cb621c1a1dfc1559fc35979d51) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 429d56d3894cffb4febe45616a3073e95191af67 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu May 21 17:48:21 2020 -0300 Bug 25570: Regression tests This tests verify that the default behaviour is to paginate the results. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: $c->objects->search doesn't paginate results by default Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 2220ce4d50998bef1dcea787d212a287a802b0aa) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit fc8bde417820d2f287df997a44136ea0b504b0f7) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: Koha/REST/Plugin/Objects.pm | 4 ++++ t/db_dependent/Koha/REST/Plugin/Objects.t | 22 +++++++++++++++++++++- t/db_dependent/api/v1/libraries.t | 13 ++++++++----- 3 files changed, 33 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 01:20:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 12 Jul 2020 23:20:17 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-8-g46b96996c1 Message-ID: <E1julGb-0006SL-HP@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 46b96996c1643e62f77c62aa12d0f62310498a2e (commit) from afcd1902c03f72ef61846d3a034c7b5086b3c812 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 46b96996c1643e62f77c62aa12d0f62310498a2e Author: David Cook <dcook at prosentient.com.au> Date: Fri May 15 14:55:49 2020 +1000 Bug 25509: Remove useless libjs-jquery dependency We don't use the libjs-jquery package, so we should remove the dependency. To Test: 1) Build package (out of scope of test plan) 2) Install package 3) Note that libjs-jquery is marked by apt as no longer required 4) Remove libjs-jquery package from system and note how it doesn't take koha-common with it Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 9e923e57ed18a104c33cc10a4704450ec4c71c28) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 898bd1256af37f5c4ec945e1d99b5146eecc2231) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: debian/control.in | 2 -- 1 file changed, 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 04:26:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 02:26:17 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-9-gfa610981b7 Message-ID: <E1juoAb-0007Jj-OX@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via fa610981b7ef4f3c59527c7d40d84c84167f62a2 (commit) from 46b96996c1643e62f77c62aa12d0f62310498a2e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fa610981b7ef4f3c59527c7d40d84c84167f62a2 Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Jun 16 19:48:48 2020 +0000 Bug 24352: Correct location and collection labels in OPAC search results This patch modifies the OPAC's MARC21 search results XSLT so that OPAC search result information is correctly labeled based on the OpacItemLocation preference. Previously, search results showed the label "Location(s)" whether the setting was "collection code" or "location." To test, apply the patch and set the OPACXSLTResultsDisplay system preference to 'default.' On the OPAC search results page, each result with items should show information in this format: With the OpacItemLocation preference set to 'call number only,' - "Availability: Items available for loan: {library} [Call number: {call number} ] With the OpacItemLocation preference set to 'collection code,' - "Availability: Items available for loan: {library} Collection(s): {collection description} [{ call number }]" With the OpacItemLocation preference set to 'location,' - "Availability: Items available for loan: {library} Location(s): {shelving location} [{ call number }]" Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 897948cff5812a67144355829cf8915af17465d0) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 0aa981c91319450b4c4c8641845c2098f3f73d0b) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 04:48:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 02:48:28 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-12-gda97436614 Message-ID: <E1juoW4-0007js-SM@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via da97436614ce8b1ddb9aa2e7f1861d1e82deea84 (commit) via c1ef8a49de0dab37cfb94de9c3e13410989a2de7 (commit) via 8019711adf319483f4baa4b4bc3b78972d9715ec (commit) from fa610981b7ef4f3c59527c7d40d84c84167f62a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit da97436614ce8b1ddb9aa2e7f1861d1e82deea84 Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Fri May 1 20:11:29 2020 +0000 Bug 11994: (follow-up) Make things work when LibraryName is empty When LibraryName system preference was not set, the installation of the plugin would fail with: Firefox could not download the search plugin from: ... Now if the pref is empty, the description 'Library catalog' will be used instead. To test: - Empty your LibraryName pref - Verify the search plugin can still be installed (see first patch for further instructions) Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 1e0dd6d0783a66514fc92cc0a34ca0882a5ce62f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 42e8c0185cf50b93789f3cfe6d4532565e084aeb) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit c1ef8a49de0dab37cfb94de9c3e13410989a2de7 Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Fri May 1 17:20:43 2020 +0000 Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml https://developer.mozilla.org/en-US/docs/Web/OpenSearch Your server should serve OpenSearch plugins using Content-Type: application/opensearchdescription+xml. To test: - Verify the Content-Type the file is delivered with is correct, for example using wget http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?format=opensearchdescription Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f090c1d2cb9253d77c5bac3b8fa03c775af2f0f6) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit e15992e4eb1e194a8ecc3bf8f04b5a74e6e5520a) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 8019711adf319483f4baa4b4bc3b78972d9715ec Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Apr 28 14:41:47 2020 +0000 Bug 11994: Fix OpenSearch discovery in the OPAC This patch corrects the markup for the OpenSearchDescription XML document and adds (back) the link in the OPAC header which points to it. This will enable compatible browsers to offer the addition of the OPAC's keyword search as a search engine option. I've found documentation suggesting this feature is available (or at least was at one time) in Chrome and Safari, but in my test it only works in Firefox. To test, apply the patch and make sure the OPACBaseURL preference is set correctly. - Open the OPAC in Firefox (these instructions assume the latest version, currently v.75). - On the right side of the address bar you should see ". . ." Click it to trigger the menu. - You should see an "Add search engine" entry with your OPAC's icon. - Click to add the search engine. - Type a keyword to search in the address bar - A box should pop up below the address bar showing icons at the bottom for performing a search in various search engines. One of these icons should be the icon for your Koha OPAC. - Click the Koha OPAC icon and confirm that it triggers a keyword search in your OPAC. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0ef7b3db4cab73797ba3386b4951c0d86addf871) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 6f9b44c95a02e5f24d4441622949225757db1b95) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: C4/Output.pm | 5 ++-- .../bootstrap/en/includes/doc-head-close.inc | 1 + .../bootstrap/en/modules/opac-opensearch.tt | 33 +++++++++++++--------- opac/opac-search.pl | 2 +- 4 files changed, 24 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 04:52:00 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 02:52:00 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-13-gc260c6c6ff Message-ID: <E1juoZU-0007rq-7C@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c260c6c6ffd74151c08f85b5bf53da9095e0a324 (commit) from da97436614ce8b1ddb9aa2e7f1861d1e82deea84 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c260c6c6ffd74151c08f85b5bf53da9095e0a324 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Jun 5 11:15:33 2020 +0200 Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor Reported-by: Kelly McElligott <kelly at bywatersolutions.com> Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit cd716269a7b2b1b6165154ea7e85844201402a8d) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit b2514759bcd4b5d3cb5758bf66890f1d84a2c586) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: acqui/basketheader.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 04:55:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 02:55:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-14-g0425f6702f Message-ID: <E1juocy-00083I-Uu@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 0425f6702f3b5d1e368e1fd557fd1d1c14993e93 (commit) from c260c6c6ffd74151c08f85b5bf53da9095e0a324 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0425f6702f3b5d1e368e1fd557fd1d1c14993e93 Author: Andreas Roussos <a.roussos at dataly.gr> Date: Mon Jun 15 16:58:38 2020 +0200 Bug 25756: remove erroneous hyphen In the Staff Client, the OPAC "Appearance" preferences table has an extra, empty HTML table row at the end. Test plan: 0) Observe the empty HTML table row at the end of the table that lists OPAC "Appearance" system preferences. 1) Apply this patch. 2) Observe that the empty table row is now gone. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 251197ad73ba2be88ac2154db46748b58a0597f8) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 3fdec870573700d2d0d585b7453f279c25e116a1) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 05:04:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 03:04:05 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-15-g842346db03 Message-ID: <E1juolB-0008IH-UI@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 842346db0311e710c25f8c48ffa5b2242a272513 (commit) from 0425f6702f3b5d1e368e1fd557fd1d1c14993e93 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 842346db0311e710c25f8c48ffa5b2242a272513 Author: Emmi Takkinen <emmi.takkinen at outlook.com> Date: Thu Jun 18 09:36:55 2020 +0300 Bug 25789: Don't allow past date as holds expiration date When editing existing holds expiration date it's possible to select past date from datepicker. This patch changes expiration inputs class as "datepickerto" to make past dates unselectable. To test: 1. Find item with holds 2. Edit holds expiration date => Note that past dates are selectable 3. Apply patch 4. Edit again => Past dates are no longer selectable Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c3365a35963742b294a4c8631b22aa34dac228d9) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 773dd857eed7e6eca01a8c098b973e20356157a3) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 05:27:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 03:27:59 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-16-g7519f4d065 Message-ID: <E1jup8J-0000Wg-Sd@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 7519f4d065d258653a08cf46a8b142e702ca5af0 (commit) from 842346db0311e710c25f8c48ffa5b2242a272513 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7519f4d065d258653a08cf46a8b142e702ca5af0 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 12:15:21 2020 +0100 Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 3e18402c240814d7f00a62c3f2359bd9b9d0a098) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 0e711e024e2ac25347a17d6499289d90c6da29de) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 8 ++++---- koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 05:43:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 03:43:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-20-gd669c66e80 Message-ID: <E1jupNW-00010k-5m@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via d669c66e80ccd3d999ffaff9b0ef397099bc4e8f (commit) via 9b39c1ec253eb8bf00e31cbed6467f42844e2e31 (commit) via 35e1f053f9fa0d62b004526e7d55a3481b8be7ea (commit) via 3bb05edced373175227d4c2fb704db75519ae78c (commit) from 7519f4d065d258653a08cf46a8b142e702ca5af0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d669c66e80ccd3d999ffaff9b0ef397099bc4e8f Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri Jul 10 17:05:31 2020 +0000 Bug 25236: Compile CSS Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 19efe6d86216301cd03654f358c0171822f07b58) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 9b39c1ec253eb8bf00e31cbed6467f42844e2e31 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 11:54:22 2020 +0100 Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0550e0b7f788b65b50ed4689d677600be3f9c7c2) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit e6cd1ced668bdf25307dc041c95557ec71dfff02) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 35e1f053f9fa0d62b004526e7d55a3481b8be7ea Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 11:44:53 2020 +0100 Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 62795521eedc02e11bef520c8b980d480b7e02ae) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 0a01f91887ee5ca24c7950cbd59984dbd335404d) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 3bb05edced373175227d4c2fb704db75519ae78c Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 11:37:26 2020 +0100 Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f88d56f689e514b47930d617049358fdf9b68608) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit cc75932f3eca746e8e2c08125306a94952b8a87d) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 6 ++++- .../bootstrap/en/includes/opac-facets.inc | 26 +++++++++++----------- .../bootstrap/en/includes/opac-topissues.inc | 2 +- .../en/modules/opac-full-serial-issues.tt | 12 +++++----- 5 files changed, 27 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 05:58:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 03:58:05 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-21-gfeff61b027 Message-ID: <E1jupbR-0001G4-On@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via feff61b027eea1b1eccb0814dc69ec107ada48ad (commit) from d669c66e80ccd3d999ffaff9b0ef397099bc4e8f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit feff61b027eea1b1eccb0814dc69ec107ada48ad Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 13:23:32 2020 +0100 Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 972aeaa0143dcdedc7ae23314a72991d5e4a6490) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 42e3ce7e921e4bd1b54095fd0631bdea2f24d73f) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 25 ++++++++++------------ 1 file changed, 11 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 06:00:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 04:00:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-22-g94688f9251 Message-ID: <E1jupdz-0001Kh-5r@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 94688f92512cb69812f558b74e283f0ae585dfea (commit) from feff61b027eea1b1eccb0814dc69ec107ada48ad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 94688f92512cb69812f558b74e283f0ae585dfea Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 13:05:31 2020 +0100 Bug 25239: Fix semantic heading for opac-reserve.tt Prior to this patch, the opac-reserve contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Attempt to place a hold on an item. 3/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 4/ Apply this patch and reload the page 5/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 1a96ede5f114bd90fe1735702ca4bab77dfed9d4) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 5574a5850f2a55a3544b3f9d5c95bf491aae4e03) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 06:04:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 04:04:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-23-g9c3412747c Message-ID: <E1juphL-0001QB-2k@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 9c3412747c9a118345690a69feb4c15a7c757195 (commit) from 94688f92512cb69812f558b74e283f0ae585dfea (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9c3412747c9a118345690a69feb4c15a7c757195 Author: Hayley Mapley <hayleymapley at catalyst.net.nz> Date: Thu Jun 11 11:48:54 2020 +1200 Bug 25151: Fixing semantic headings in opac-basket.tt Test plan: 1) Apply the patch 2) Add items to your cart/folder/basket 3) Open up the basket and check that the main heading is now an h1 4) Check that the page looks fine Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f002bd17105bab2d16aee8db8ed4f6d688192fc3) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 987eb51a3330e69b018633d01ed987d9cf04dfb7) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 06:21:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 04:21:34 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-28-g31b55f635a Message-ID: <E1jupyA-0001lN-3f@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 31b55f635a07a55c4d1a413dd3b1d48971bc762b (commit) via a53d05278095bb244636166f7d1ff7f15506f578 (commit) via 92742425ddc048eb9796d8bb4d4544138c5f1dde (commit) via 36b9a1bf1bc29b6e7c5e76c34f4bdd1dc5e8fecf (commit) via a0688b684d12687acbbd4f0a27ea019c3474ed0a (commit) from 9c3412747c9a118345690a69feb4c15a7c757195 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 31b55f635a07a55c4d1a413dd3b1d48971bc762b Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri Jul 10 17:31:08 2020 +0000 Bug 22807: Compile CSS Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit c561fda1fb166dd2130b02fbb96c47be771d9b7a) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit a53d05278095bb244636166f7d1ff7f15506f578 Author: Owen Leonard <oleonard at myacpl.org> Date: Wed Jun 10 18:30:50 2020 +0000 Bug 22807: (follow-up) Update style of skip button This patch updates the markup and style of the skip button, adapting (i.e. stealing) the style of the skip link at https://webaim.org. To test, apply the patch and rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Go to any page in the OPAC and hit the tab key. The "Skip to main content" link should appear. Tabbing away from it should cause the link to hide. Hitting the ENTER key when the link is highlighted should cause the page to scroll to the main content. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 2e94cb26a8267df72f657fb7c1097d08318e8a21) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 30cc30bb996567dc5491f06c5224f1db1163d324) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 92742425ddc048eb9796d8bb4d4544138c5f1dde Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed Jun 10 16:56:40 2020 +0100 Bug 22807: Ensure .maincontent appears on all pages Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c5b173f7dec5d94c29249dfa00e61861d5645998) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 0923ccef50d5052d6e14812eaa20e1e4c37dec89) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 36b9a1bf1bc29b6e7c5e76c34f4bdd1dc5e8fecf Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed Jun 10 13:57:42 2020 +0100 Bug 22807: Ensure only one maincontent on searcresults Prior to this patch, if you entered a search that returned zero results, you would end up with two 'maincontent' classes on the page Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 6b0887f76e2f561187f6eae78f932987520a9cb6) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 38bdbb4d5528c68e2ca2d69dfc922a790f09a991) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit a0688b684d12687acbbd4f0a27ea019c3474ed0a Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jun 9 14:10:53 2020 +0100 Bug 22807: Add 'Skip to content' option This patch adds a 'Skip to content' link to the header bar which will only appear upon the first use of 'tab' to navigate after any fresh page load in the OPAC. Test plan 1/ Load any page in the OPAC 2/ Hit the `tab` key 3/ Note the new 'Skip to main content' link appears at the top left of the screen. 4/ Hit `Enter` or Click the button 5/ Note the page scrolls to the area of the page that has the first block containing a .maincontent class. 6/ Note that the next available focusable element after the first .maincontent block has been given focus. 7/ Note that the link has been hidden Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c36560a1ad731af955c005306c2c2800057cd890) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit c8da2d3278a89df4d670465bfc55e269a4472f4e) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 25 ++++ .../opac-tmpl/bootstrap/en/includes/masthead.inc | 1 + .../opac-tmpl/bootstrap/en/modules/maintenance.tt | 2 +- .../bootstrap/en/modules/opac-addbybiblionumber.tt | 2 +- .../bootstrap/en/modules/opac-alert-subscribe.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-blocked.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-browser.tt | 2 +- .../bootstrap/en/modules/opac-course-details.tt | 141 +++++++++++---------- .../bootstrap/en/modules/opac-course-reserves.tt | 3 +- .../bootstrap/en/modules/opac-discharge.tt | 2 +- .../bootstrap/en/modules/opac-imageviewer.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 8 +- .../modules/opac-memberentry-update-submitted.tt | 2 +- .../bootstrap/en/modules/opac-memberentry.tt | 4 +- .../bootstrap/en/modules/opac-messaging.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 2 +- .../bootstrap/en/modules/opac-password-recovery.tt | 2 +- .../bootstrap/en/modules/opac-patron-consent.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 2 +- .../bootstrap/en/modules/opac-readingrecord.tt | 2 +- .../en/modules/opac-registration-confirmation.tt | 2 +- .../en/modules/opac-registration-email-sent.tt | 2 +- .../en/modules/opac-registration-invalid.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- .../bootstrap/en/modules/opac-results-grouped.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 14 +- .../opac-tmpl/bootstrap/en/modules/opac-review.tt | 2 +- .../bootstrap/en/modules/opac-serial-issues.tt | 2 +- .../bootstrap/en/modules/opac-tags_subject.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/js/global.js | 46 +++++++ 31 files changed, 187 insertions(+), 101 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 17:02:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 15:02:42 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-40-g290e7fe9b9 Message-ID: <E1juzyc-00071k-GM@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 290e7fe9b9c7d41177204699e61d5419c6cab363 (commit) from c561fda1fb166dd2130b02fbb96c47be771d9b7a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 290e7fe9b9c7d41177204699e61d5419c6cab363 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Thu Apr 9 11:23:04 2020 -0400 Bug 25097: Add option to message_queue to allow for only specific sending notices The message_queue.pl currently will send all the messages queued up. It would be nice to have some control over which messages are to be sent. Example: We have libraries who only wanted to send 'hold notices' but not overdue, advance notice, etc during the covid-19 quarantine. And some that were the opposite - turn off hold notices, but send other generated notices. Test Plan: 1) Apply this patch 2) Enqueue some messages with different letter codes 3) Run process_message_queue.pl with the new -c parameter using one of the letter codes enqueued 4) Note that only the messages with the selected code were processed! Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit b48869f1b865ae1f172557274062e932318427db) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/process_message_queue.pl | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 17:10:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 15:10:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-217-g189851fb9b Message-ID: <E1jv067-0007Jz-TT@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 189851fb9bbc831bb2875c2c440877c2562583d0 (commit) from 46d3ec264c4e46cc73ee1713b5c39e6c564e5a1a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 189851fb9bbc831bb2875c2c440877c2562583d0 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 9 10:52:11 2020 +0200 Bug 25964: Prevent data loss when editing items from a MARC record Coming from: Bug 23463: Use new method Koha::Object->set_or_blank We have DB fields that are not mapped with MARC fields, for instance paidfor. They are not handled correctly. In ModItemFromMarc, we get a MARC record in parameter and update the item in DB. But we are loosing the fields that are not in the MARC record Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 13 +++++++++++++ t/db_dependent/Items.t | 10 +++++++--- 2 files changed, 20 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 17:27:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 15:27:36 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-42-g99932ac931 Message-ID: <E1jv0Mi-0007h4-9j@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 99932ac93130058882fe9e8b2800b0057f6144be (commit) via be2c5e50a7c4ec0029cb155d42d1b6f8c739dbc8 (commit) from 290e7fe9b9c7d41177204699e61d5419c6cab363 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 99932ac93130058882fe9e8b2800b0057f6144be Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Date: Wed Jun 17 11:50:26 2020 +0000 Bug 18911: (follow-up) We should save changes with a POST Test plan: Verify if changes to messaging table and language are still saved. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit ef947ff42fb5959d421038ac2a413e9cc6488474) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit be2c5e50a7c4ec0029cb155d42d1b6f8c739dbc8 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Jun 17 12:20:36 2020 +0200 Bug 18911: Add the ability to set the preferred lang for notice at the OPAC Patron should be allowed to modify this setting without asking a staff member. The setting is not configurable and cannot be hidden via a syspref. Test plan: - Turn the pref TranslateNotices on - Install some languages - Edit your messaging settings at the OPAC => Notice the "Preferred language for notices" dropdown list - Select one => Confirm that the value is saved in DB Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0ab27fe6da01095ec3303e35b5736f9ed9bbc07e) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../bootstrap/en/modules/opac-messaging.tt | 31 +++++++++++++++++++++- opac/opac-messaging.pl | 12 +++++++++ 2 files changed, 42 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 17:31:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 15:31:33 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-44-gb66500e424 Message-ID: <E1jv0QX-0007or-Ib@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via b66500e424dd12a37fe418816947c56cba9134b4 (commit) via 6f85f47365a1460d1e68280835d69008424fea45 (commit) from 99932ac93130058882fe9e8b2800b0057f6144be (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b66500e424dd12a37fe418816947c56cba9134b4 Author: Emmi Takkinen <emmi.takkinen at outlook.com> Date: Thu Mar 19 09:12:19 2020 +0200 Bug 4985: Fix Plack scope errors This patch 'ours' several variables to fix Plack scope errors in exceptionHolidays.pl. This also adds '@holidays_list' as parameter to 'edit_holidays'. Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit ee3f5d5a85d93dc36d6bdeab5f092c0098d604e1) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 6f85f47365a1460d1e68280835d69008424fea45 Author: Emmi Takkinen <emmi.takkinen at outlook.com> Date: Fri Feb 7 12:43:54 2020 +0200 Bug 4985: Edit a calendar entry for all branches This patch adds functionality to calendar tool to make edits or deletes to all branches at once. To test: -Apply patch -Add holiday for a library and copy it to all or some libraries -Edit previosly made holiday (edit, delete etc.) and check out "Copy changes to all libraries." checkbox => Changes are made to all libraries sharing changed holiday Sponsored by: Koha-Suomi Oy Signed-off-by: Christofer <christofer.zorn at ajaxlibrary.ca> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit ce2219425d9b97952f5904024fb7575a0809487b) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/tools/holidays.tt | 6 + tools/exceptionHolidays.pl | 165 ++++++++++++--------- 2 files changed, 97 insertions(+), 74 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 17:41:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 15:41:53 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-46-g18faf9b7aa Message-ID: <E1jv0aX-000807-OB@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 18faf9b7aa7c313fd9fa086c5f9609ef7b0c70f5 (commit) via c65e76a7c49720cf112c59a0583a9545b34844c4 (commit) from b66500e424dd12a37fe418816947c56cba9134b4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 18faf9b7aa7c313fd9fa086c5f9609ef7b0c70f5 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Thu Jun 18 09:01:36 2020 -0400 Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 017b67e6c52ab7b79a0187b1ca9fea220117f7ef) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit c65e76a7c49720cf112c59a0583a9545b34844c4 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu Jun 18 16:54:42 2020 -0300 Bug 25805: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 115eeada2b6f959997d21d0e0dd73606f1ca7324) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Item.pm | 4 ++-- t/db_dependent/SIP/Message.t | 37 ++++++++++++++++++++++++++++++++++++- 2 files changed, 38 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 17:53:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 15:53:37 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-48-g6abb06a30b Message-ID: <E1jv0lt-0008Gg-4a@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 6abb06a30b24989681ebdad9e2fdbb941131207a (commit) via c234daac2afe239625a59940c4aa8ef37453762b (commit) from 18faf9b7aa7c313fd9fa086c5f9609ef7b0c70f5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6abb06a30b24989681ebdad9e2fdbb941131207a Author: Lucas Gass <lucas at bywatersolutions.com> Date: Mon Jul 13 15:21:55 2020 +0000 Bug 24986: DBRev 20.05.01.001 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit c234daac2afe239625a59940c4aa8ef37453762b Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jun 4 12:12:23 2020 +0200 Bug 24986: Modify some borrowers DB fields to (TINY|MEDIUM)TEXT Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 16a5197aa9f96ee8a7fb6c63e15a6c7f9342f773) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 60 +++++++++++++++++----------------- installer/data/mysql/updatedatabase.pl | 23 +++++++++++++ 3 files changed, 54 insertions(+), 31 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 18:02:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 16:02:24 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-49-ga0673794eb Message-ID: <E1jv0uO-0000Nc-Qv@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via a0673794ebc4bbac61aaa8d11d31056dee602f6d (commit) from 6abb06a30b24989681ebdad9e2fdbb941131207a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a0673794ebc4bbac61aaa8d11d31056dee602f6d Author: Lucas Gass <lucas at bywatersolutions.com> Date: Mon Jul 13 15:29:31 2020 +0000 Bug 24986: DBIC Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Borrower.pm | 99 +++++++++++------------------------ Koha/Schema/Result/Deletedborrower.pm | 99 +++++++++++------------------------ 2 files changed, 64 insertions(+), 134 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 18:16:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 16:16:14 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-52-g34acff4fa0 Message-ID: <E1jv17m-0000gY-BV@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 34acff4fa093a68ca22cc1820e09bbe0829f348e (commit) via 1ef613a005bb66a7a7d63ceccbb44c1c94d82132 (commit) via b326c76cab302e142ec46d58d9dced0fede4cc61 (commit) from a0673794ebc4bbac61aaa8d11d31056dee602f6d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 34acff4fa093a68ca22cc1820e09bbe0829f348e Author: Lucas Gass <lucas at bywatersolutions.com> Date: Mon Jul 13 15:41:05 2020 +0000 Bug 25232: DBRev 20.05.01.002 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 1ef613a005bb66a7a7d63ceccbb44c1c94d82132 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Thu May 7 09:16:37 2020 -0400 Bug 25232: Add ability to specify multiple notforloan values to skip Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 326c0159a016c25394acde03c379bfea5bb3b820) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit b326c76cab302e142ec46d58d9dced0fede4cc61 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Tue Apr 21 13:52:40 2020 -0400 Bug 25232: Add ability to skip trapping items with a given notforloan value This is a companion/alternative to bug 25184, in that it allows an explicit workflow for placing returned books into temporary storage for a few days for decontamination purposes. The idea here is to create a specific notforloan value for "In Decontamination" or something along along those lines. This notforloan value would never be trappable. At the end of decon, UpdateNotForLoanStatusOnCheckin could be used to remove the notforloan status and allow checkins to be trapped to fill holds. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Give an item a negative notforloan value 4) Place a hold on the item 5) Check the item in 6) Note the item is trapped for hold 7) Set SkipHoldTrapOnNotForLoanValue to the same notforloan value you used in step 3 8) Check the item in again 9) Note Koha did not ask you to trap the item for hold! Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 465e5562fc2f852282f7dcc4683dd0e87b0633eb) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 3 +++ Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 12 ++++++++++++ .../prog/en/modules/admin/preferences/circulation.pref | 6 ++++++ t/db_dependent/Holds.t | 6 +++++- 6 files changed, 28 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 18:25:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 16:25:56 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-54-ga5e4c9b57e Message-ID: <E1jv1HA-0000vU-72@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via a5e4c9b57e80e4a6453b6adbe13b7e24dd06c66c (commit) via f9efb8024b75c847965c25ac96fa7a12c47ab2eb (commit) from 34acff4fa093a68ca22cc1820e09bbe0829f348e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a5e4c9b57e80e4a6453b6adbe13b7e24dd06c66c Author: Julian Maurice <julian.maurice at biblibre.com> Date: Fri Jun 26 10:55:44 2020 +0400 Bug 25858: Use bitwise OR for setting a bit in borrowers.flag Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Thanks-to: Didier Gautheron <didier.gautheron at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 6886cf93eca9b05dc2ccfa1d681d86e9d95385b4) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit f9efb8024b75c847965c25ac96fa7a12c47ab2eb Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jun 24 10:06:57 2020 +0000 Bug 25858: (bug 25858 follow-up) Don't attempt to set flag if already set Signed-off-by: Didier Gautheron <didier.gautheron at biblibre.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit e38634ceb8ae5d30d43055711b97395f580f0310) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 18:29:48 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 16:29:48 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-55-g3a3237da9c Message-ID: <E1jv1Ku-00014Y-O5@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3a3237da9c2f107a9d4e4a9e9383316ce10e6ecc (commit) from a5e4c9b57e80e4a6453b6adbe13b7e24dd06c66c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3a3237da9c2f107a9d4e4a9e9383316ce10e6ecc Author: Slava Shishkin <slavashishkin at gmail.com> Date: Wed May 13 20:20:27 2020 +0300 Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm This warning was thrown: Use of uninitialized value $info{"invalid_username_or_password"} in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm line 387. There is the case when hash key can be undefined in numeric comparison. Fixed by adding additional precheck for $info{"invalid_username_or_password"} being Perl's "true". To test: 1) Go to the first page of the web-installer where it asks to login. 2) Observe the warning in the log file. 3) Apply patch. 4) Repeat step 1. 7) Check that previous warning suppressed. Mentored-by: Andrew Nugged <nugged at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d81438e143273a538c09cd16e7f92a83beed4027) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/InstallAuth.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 18:33:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 16:33:07 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-56-g493eb8ce10 Message-ID: <E1jv1O7-0001BS-2D@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 493eb8ce1009355675e36ef0aa9962f6daf9898f (commit) from 3a3237da9c2f107a9d4e4a9e9383316ce10e6ecc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 493eb8ce1009355675e36ef0aa9962f6daf9898f Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed Jun 24 11:34:32 2020 +0100 Bug 25807: Add Template 3.008 to the exclude list This patch adds version 3.008 of Template to the excludes list in our cpanfile. It also adds support for displaying this version on the about page. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit eb8d23f47d5fd204b48749ac03faca8244e84264) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: about.pl | 3 ++- cpanfile | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 18:49:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 16:49:16 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-57-g13ac8457d5 Message-ID: <E1jv1dk-0001Vd-Tc@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 13ac8457d5ef1da87ecbc729ffb93b9f19fd84e1 (commit) from 493eb8ce1009355675e36ef0aa9962f6daf9898f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 13ac8457d5ef1da87ecbc729ffb93b9f19fd84e1 Author: Owen Leonard <oleonard at myacpl.org> Date: Mon Jun 22 23:57:29 2020 +0000 Bug 25793: OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade This patch modifies the OAI XSLT file, correcting the path to jQuery assets and adds a link to jquery-migrate. To test, apply the patch and make sure the "OAI-PMH" system preference is enabled. 1. Go to: <OPACBaseURL>/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marc21 e.g. localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marc21 2. Click on the 'Sets' and 'Metadata' links. The corresponding panels with set and metatdata information should be shown. Tested against master, works as described. Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 23ed2e110e16f04a34c01ac866b470ec725b7522) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/xslt/OAI.xslt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 18:53:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 16:53:37 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-59-g7467f10ceb Message-ID: <E1jv1hx-0001ec-3r@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7467f10ceb52696f263746d5495532e2b63b8f5b (commit) via 59e1e78c6d59ee6ced202382e2910676a4e32360 (commit) from 13ac8457d5ef1da87ecbc729ffb93b9f19fd84e1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7467f10ceb52696f263746d5495532e2b63b8f5b Author: Nick Clemens <nick at bywatersolutions.com> Date: Thu Jun 25 10:38:16 2020 +0000 Bug 25875: Unit test Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit a804d4be437a5df3641f854a506642afe3501046) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 59e1e78c6d59ee6ced202382e2910676a4e32360 Author: Nick Clemens <nick at bywatersolutions.com> Date: Thu Jun 25 10:38:26 2020 +0000 Bug 25875: Move check for module_bit and code to the JOIN If we limit the JOIN to rows with the correct subpermission we won't duplicate the returned patrons To test: 1 - Give a patron full acquisitions permissions 2 - Also give them several subpermissions on other areas 3 - Go to Acquisitions 4 - Edit a fund 5 - Add a user to the fund 6 - Search for user above 7 - They return multiple times in results 8 - Apply patch 9 - Restart all the things 10 - Repeat search 11 - Patron appears once Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 721876785142fea84f02c7dbe4f325e2a605bd0f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 12 +++++++---- t/db_dependent/Utils/Datatables_Members.t | 35 ++++++++++++++++++++++++++++++- 2 files changed, 42 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 18:58:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 16:58:03 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-60-g25d820f322 Message-ID: <E1jv1mF-0001ml-3e@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 25d820f3226c6116d064591abc67e2463a571f50 (commit) from 7467f10ceb52696f263746d5495532e2b63b8f5b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 25d820f3226c6116d064591abc67e2463a571f50 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Wed May 27 21:35:16 2020 +0000 Bug 22672: Change <i> to <em> and <b> to <strong> in templates, includes, xslt This patch attempts to replace <i> with <em> AND <b> with <strong> in order to more accessible to screen readers. This patch makes no attempt to change Font Awesome icons which typically use <i>. I found templates, includes and XSLT by using 'git grep ‘<b>’ koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘<i>’ koha-tmpl/opac-tmpl/bootstrap/en/ TEST PLAN: There should be no visible difference on the changed pages. The files changed are: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/xslt/OAI.xslt Read the changes and make sure everything looks correct, try to visit as many pages as possible and confirm that everything looks as it should. grep around for cases of <b> or <i> that I could have missed. Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d3036d46ba4b26df040a25f960c3bc3081734c26) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/includes/holds-table.inc | 12 ++++++------ koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt | 2 +- .../bootstrap/en/modules/opac-auth-MARCdetail.tt | 4 ++-- .../en/modules/opac-authoritiessearchresultlist.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt | 2 +- .../bootstrap/en/modules/opac-course-details.tt | 6 +++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt | 4 ++-- .../opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 4 ++-- .../opac-tmpl/bootstrap/en/modules/opac-opensearch.tt | 2 +- .../bootstrap/en/modules/opac-overdrive-search.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 2 +- .../bootstrap/en/modules/opac-results-grouped.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 6 +++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 ++-- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 8 ++++---- .../bootstrap/en/xslt/NORMARCslim2OPACResults.xsl | 4 ++-- .../bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl | 4 ++-- koha-tmpl/opac-tmpl/xslt/OAI.xslt | 16 ++++++++-------- 23 files changed, 49 insertions(+), 49 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 19:08:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 17:08:29 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-61-g9882869f1a Message-ID: <E1jv1wL-000203-7N@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 9882869f1a41f23590d53935d1a08d9f79a4c463 (commit) from 25d820f3226c6116d064591abc67e2463a571f50 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9882869f1a41f23590d53935d1a08d9f79a4c463 Author: Petro Vashchuk <stalkernoid at gmail.com> Date: Wed Jun 17 16:44:42 2020 +0300 Bug 25322: fix for not selected "relationship" defaults to father When a user creates a patron's guarantor on /cgi-bin/koha/members/memberentry.pl but doesn't select the relationship from a dropdown, the relationship defaults to first value, which in default sysprefs is "father". This may or may not be correct as this is not a conscious choice from the user. The solution is to make the "Relationship" field mandatory when there is no empty entry in the system preferences, always starting with an empty option but not allowing the user to save an empty entry. And if there is an empty option in sysprefs, it allows to save empty, as well as makes it default choice. To reproduce with default system preferences: 1) Create a new patron who is assumed to have a guarantor or modify the existing one. 2) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes. 3) Observe that relationship is set as "father". 4) Apply the patch. 5) Repeat steps 1 and 2. 6) Observe that it doesn't allow you to save the form until you pick a relationship type. To reproduce with empty entry added to system preferences: 1) Add an empty entry to borrowerRelationship at /cgi-bin/koha/admin/preferences.pl?tab=patrons in Patron relationships section (example: "|father|mother"). 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes. 4) Observe that relationship is set as "father". 5) Apply the patch. 6) Repeat steps 1, 2 and 3. 7) Observe when you save the empty entry it does set the relationship as empty. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 029f41a667da8f054633432997bc818c1b26a27f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/members/memberentrygen.tt | 34 ++++++++++++++++++---- members/memberentry.pl | 4 +++ 2 files changed, 32 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 19:31:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 17:31:36 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-66-g1c54f85456 Message-ID: <E1jv2Ii-0002St-7K@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 1c54f8545611b43672867ac7a34dd8a0c20c20a4 (commit) via 1b505eee19cfd59f59dcc4b696c591f209931dcc (commit) via 41fb8527b18d1ebaa25934cfd9a01f8b8c4e43be (commit) via 7f89ea6e1843be235783b41f4c521e100edceebd (commit) via b8a1515ad30200a58d4b1d62bf140b86a6f331e1 (commit) from 9882869f1a41f23590d53935d1a08d9f79a4c463 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1c54f8545611b43672867ac7a34dd8a0c20c20a4 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jun 29 13:42:55 2020 +0200 Bug 21395: Remove 'variable $DEBUG masks earlier declaration in same scope' warning % prove t/db_dependent/Serials.t t/db_dependent/Serials.t .. 8/49 "my" variable $DEBUG masks earlier declaration in same scope at /kohadevbox/koha/C4/Barcodes/ValueBuilder.pm line 45. "my" variable $DEBUG masks earlier declaration in same scope at /kohadevbox/koha/C4/Barcodes/ValueBuilder.pm line 87. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 61aa3f794240443f5c2c99adc016f0d80c7251d9) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 1b505eee19cfd59f59dcc4b696c591f209931dcc Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 25 13:48:36 2020 +0100 Bug 21395: (QA follow-up) POD fixes Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit b9e526a12fb338736e149934526e38da782f048f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 41fb8527b18d1ebaa25934cfd9a01f8b8c4e43be Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 25 11:31:49 2020 +0100 Bug 21395: (QA follow-up) Remove some introduced issues This patch removes some new error cases introduced during rebase Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit e968af43777d47c9134ea1875270af9661ef2f5a) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 7f89ea6e1843be235783b41f4c521e100edceebd Author: Julian Maurice <julian.maurice at biblibre.com> Date: Mon Apr 27 10:31:19 2020 +0200 Bug 21395: Fix QA errors Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 1682341b5849c34e59597cda780d4c877d6f3278) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit b8a1515ad30200a58d4b1d62bf140b86a6f331e1 Author: Julian Maurice <julian.maurice at biblibre.com> Date: Fri Sep 21 18:05:42 2018 +0200 Bug 21395: Make perlcritic happy This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit b168f4a2e9a03ed56ce857353d4dde940980caba) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: t/perlcriticrc => .perlcriticrc | 2 + C4/Accounts.pm | 1 - C4/Acquisition.pm | 1 - C4/Auth_with_cas.pm | 18 +-- C4/AuthoritiesMarc.pm | 1 - C4/Barcodes/ValueBuilder.pm | 141 +++++++++++---------- C4/Barcodes/annual.pm | 8 +- C4/Biblio.pm | 1 - C4/ClassSortRoutine.pm | 4 +- C4/ClassSplitRoutine/RegEx.pm | 2 +- C4/Context.pm | 2 - C4/CourseReserves.pm | 2 +- C4/Creators.pm | 2 + C4/Creators/Lib.pm | 2 +- C4/ImportBatch.pm | 12 +- C4/InstallAuth.pm | 58 ++++----- C4/Items.pm | 1 - C4/Labels.pm | 2 + C4/Labels/Label.pm | 5 +- C4/Languages.pm | 4 +- C4/Letters.pm | 1 - C4/Matcher.pm | 2 +- C4/Members/Messaging.pm | 1 - C4/Patroncards.pm | 2 + C4/Patroncards/Patroncard.pm | 8 +- C4/Record.pm | 8 +- C4/Ris.pm | 1 - C4/Search.pm | 5 - C4/Serials.pm | 21 +-- C4/Templates.pm | 2 +- Makefile.PL | 6 +- docs/CAS/CASProxy/examples/koha_webservice.pl | 6 +- docs/CAS/CASProxy/examples/proxy_cas_callback.pl | 6 +- docs/CAS/CASProxy/examples/proxy_cas_data.pl | 8 +- fix-perl-path.PL | 4 +- installer/data/mysql/labels_upgrade.pl | 2 + installer/data/mysql/patroncards_upgrade.pl | 2 + installer/data/mysql/update22to30.pl | 16 +-- installer/data/mysql/updatedatabase.pl | 10 +- installer/externalmodules.pl | 6 +- installer/install.pl | 2 +- misc/admin/koha-preferences | 1 + misc/batchRepairMissingBiblionumbers.pl | 1 - misc/batchdeletebiblios.pl | 2 +- misc/bin/connexion_import_daemon.pl | 1 + misc/check_sysprefs.pl | 6 +- misc/cronjobs/build_browser_and_cloud.pl | 2 +- misc/cronjobs/gather_print_notices.pl | 3 +- misc/cronjobs/holds/cancel_expired_holds.pl | 3 +- misc/cronjobs/longoverdue.pl | 6 +- misc/cronjobs/rss/rss.pl | 6 +- .../thirdparty/TalkingTech_itiva_inbound.pl | 1 + misc/cronjobs/update_totalissues.pl | 2 +- misc/exportauth.pl | 6 +- misc/link_bibs_to_authorities.pl | 2 +- misc/maintenance/cmp_sysprefs.pl | 2 +- .../fix_accountlines_rmdupfines_bug8253.pl | 1 - misc/maintenance/touch_all_biblios.pl | 10 +- misc/maintenance/touch_all_items.pl | 10 +- .../migration_tools/22_to_30/export_Authorities.pl | 7 +- .../22_to_30/export_Authorities_xml.pl | 7 +- .../22_to_30/move_marc_to_biblioitems.pl | 8 +- misc/migration_tools/buildCOUNTRY.pl | 2 +- misc/migration_tools/buildEDITORS.pl | 1 - misc/migration_tools/buildLANG.pl | 2 +- misc/migration_tools/bulkmarcimport.pl | 7 +- misc/migration_tools/remove_unused_authorities.pl | 1 - misc/perlmodule_rm.pl | 2 +- misc/translator/LangInstaller.pm | 2 +- misc/translator/TmplTokenizer.pm | 58 ++++----- misc/translator/VerboseWarnings.pm | 24 ++-- misc/translator/po2json | 14 +- misc/translator/tmpl_process3.pl | 81 ++++++------ misc/translator/xgettext.pl | 30 +++-- opac/opac-MARCdetail.pl | 1 - opac/opac-alert-subscribe.pl | 1 - opac/opac-authorities-home.pl | 1 - opac/opac-authoritiesdetail.pl | 1 - opac/opac-basket.pl | 1 - opac/opac-search.pl | 5 - opac/opac-serial-issues.pl | 2 - opac/opac-showreviews.pl | 1 - patroncards/create-pdf.pl | 10 +- patroncards/image-manage.pl | 2 +- patroncards/print.pl | 12 +- plugins/plugins-upload.pl | 2 +- reports/acquisitions_stats.pl | 1 - reports/bor_issues_top.pl | 26 ++-- reports/borrowers_out.pl | 7 +- reports/catalogue_out.pl | 2 - reports/catalogue_stats.pl | 5 - reports/issues_avg_stats.pl | 5 - reports/issues_stats.pl | 5 +- reports/reserves_stats.pl | 8 +- rewrite-config.PL | 33 +++-- svc/holds | 1 - t/00-testcritic.t | 32 +---- t/Languages.t | 2 +- t/Prices.t | 4 +- t/SuggestionEngine.t | 2 +- t/db_dependent/Accounts.t | 1 - t/db_dependent/Acquisition/OrderFromSubscription.t | 3 +- t/db_dependent/Acquisition/OrderUsers.t | 1 - t/db_dependent/Barcodes.t | 4 +- t/db_dependent/Context.t | 2 - t/db_dependent/Hold.t | 2 +- t/db_dependent/LDAP/test_ldap_add.pl | 2 +- t/db_dependent/Record/Record.t | 32 ++--- t/db_dependent/Search.t | 6 + t/db_dependent/Serials.t | 1 - t/db_dependent/Serials_2.t | 1 - t/db_dependent/XISBN.t | 1 - t/db_dependent/cronjobs/advance_notices_digest.t | 6 +- t/db_dependent/www/auth_values_input_www.t | 1 - t/dummy.t | 1 + tags/review.pl | 6 +- tools/batchMod.pl | 5 +- tools/export.pl | 2 - tools/import_borrowers.pl | 3 - tools/letter.pl | 2 +- tools/modborrowers.pl | 3 +- tools/overduerules.pl | 2 - tools/picture-upload.pl | 14 +- tools/upload-cover-image.pl | 6 +- xt/author/show-template-structure.pl | 6 +- xt/author/translatable-templates.t | 2 +- xt/find-license-problems.t | 5 +- xt/fix-old-fsf-address | 8 +- xt/single_quotes.t | 2 +- 129 files changed, 460 insertions(+), 541 deletions(-) rename t/perlcriticrc => .perlcriticrc (89%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 19:38:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 17:38:49 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-72-g9ec18eedec Message-ID: <E1jv2Ph-0002cV-0q@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 9ec18eedec41ad4e2058fe39e03c2df19a966c54 (commit) via 79b90fff2f1ff5091c5a050d880c36be34a36f2e (commit) via 84711d3d23874dfc8cc41297b4b0d1a0c550846b (commit) via cf93d673a0bcc17e26299f006da1faf00b24fe52 (commit) via b59c5fc63a14013bcb8b43cce093b5d1866db96e (commit) via 1ccee84ddcaac20194042cb3d59163628442030f (commit) from 1c54f8545611b43672867ac7a34dd8a0c20c20a4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9ec18eedec41ad4e2058fe39e03c2df19a966c54 Author: Andrew Nugged <nugged at gmail.com> Date: Wed Jun 17 23:18:01 2020 +0300 Bug 25440: Fixed list of 'show_rule' forming variables in the template In smart-rules.tt we have `SET show_rule = ...` section which filled with 'all used in the loop' variables. Because if historical reasons it seems that there are some missing, few old, and even doubled ones. This list is fixed now by: - variable names 'article_requests' and 'renewalsallowed' repeated so duplicates are removed; - 'hardduedatebefore' and 'hardduedateexact' not present in the whole site code anywhere anymore; IMPORTANT NOTE: these 'hardduedatebefore/hardduedateexact' also exists as remnants in .po-translation files, a lot. - 'note', 'hardduedatecompare', 'renewalperiod', 'rentaldiscount' template variables were missing from this 'show_rule =' checking code so they are added. Order of fields updated to match with above "SET field = ..." pack. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Bug 25440: (QA follow-up) Correction for typo 'engthunit -> lengthunit Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d11e16aec74ad694bd56ce3810954091b0bf1259) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 79b90fff2f1ff5091c5a050d880c36be34a36f2e Author: Andrew Nugged <nugged at gmail.com> Date: Tue May 19 11:20:41 2020 +0300 Bug 25440: Fix for "uninitialized $maxsuspensiondays" in smart-rules.pl This warning emitted: Use of uninitialized value $maxsuspensiondays in string eq at /admin/smart-rules.pl line 257. But that not just undef-warning, there is broken logic, these two lines are mutually contradictory and goes one-by-one: $maxsuspensiondays = undef if $maxsuspensiondays eq q||; $maxsuspensiondays = '' if $maxsuspensiondays eq q||; Fix is simple: to make it '' if it comes undef. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit cb09303e11b11de2b25852a707211a054fb2b8e1) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 84711d3d23874dfc8cc41297b4b0d1a0c550846b Author: Andrew Nugged <nugged at gmail.com> Date: Tue May 19 11:03:13 2020 +0300 Bug 25440: Fix for "uninitialized value in string eq" in smart-rules.pl This warning emitted: Use of uninitialized value in string eq at /admin/smart-rules.pl line 289. It is solved by one line added to exclude comparison with 'on' string when variable is 'undef'. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 5eebfcf68747b4886b23a9d4c8df37ea7d103edb) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit cf93d673a0bcc17e26299f006da1faf00b24fe52 Author: Andrew Nugged <nugged at gmail.com> Date: Sun May 10 18:18:35 2020 +0300 Bug 25440: Fix for "uninitialized value in hash" warning in smart-rules.pl This warning emitted: Use of uninitialized value in hash element at /admin/smart-rules.pl line 569. that happened because we have NULLs in SQL results for 'categorycode' and 'itemtype' which later used as 'any' kind of category/item in the template, so for the template it passed this way: $rules->{ $r->{categorycode} }->{ $r->{itemtype} }->... but undef will stringify as "" to become a hash key ("Hashes are unordered collections of scalar values indexed by their associated string key" https://perldoc.perl.org/perldata.html), that's why "undef warning". To prevent warning here is the simple fix: $rules->{ $r->{categorycode} // '' }->{ $r->{itemtype} // '' }->... Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit b48162f1be1853a89e0ffc898bc0927edef93f95) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit b59c5fc63a14013bcb8b43cce093b5d1866db96e Author: Andrew Nugged <nugged at gmail.com> Date: Sun May 10 13:28:40 2020 +0300 Bug 25440: Fix for "CGI::param called in list context" in smart-rules.pl This warning emitted: CGI::param called in list context from /admin/smart-rules.pl line 262, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at CGI.pm line 412. Explained here: https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-parameter And because all these params are not multi-params, so simple "scalar .." forcing for CGI->param is the fix. Changes are transparent and same values should be assigned as before, just no more warnings. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit eb8a0ffcc1bb4d751daa4221bd37faa815904db8) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 1ccee84ddcaac20194042cb3d59163628442030f Author: Andrew Nugged <nugged at gmail.com> Date: Sun May 10 13:54:29 2020 +0300 Bug 25440: Extra duplicated call to CGI->param method removed In code CGI param 'no_auto_renewal_after_hard_limit' assigned to "$no_auto_renewal_after_hard_limit" var, and then just in the next line again variable "$no_auto_renewal_after_hard_limit" reassigned with call to same "$input->param('no_auto_renewal_after_hard_limit')". Fixed. No logic or results should be changed. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit b9ba7151667bc6481bc97335b94e44487c9701bd) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: admin/smart-rules.pl | 28 ++++++++++------------ .../prog/en/modules/admin/smart-rules.tt | 2 +- 2 files changed, 14 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 13 19:43:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Jul 2020 17:43:18 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-76-gc0136357c5 Message-ID: <E1jv2U2-0002j1-I0@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via c0136357c539ed069504fe02bdda1ba7ab54541a (commit) via b9d54b390d4dfe1e075360b94c2c6f79c5933de8 (commit) via 6e00ffec75908c7e5fa29cb71c3b0fdc9abca9a7 (commit) via d40eaab6d3540061caee6d74ce657f444bbd7310 (commit) from 9ec18eedec41ad4e2058fe39e03c2df19a966c54 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c0136357c539ed069504fe02bdda1ba7ab54541a Author: Julian Maurice <julian.maurice at biblibre.com> Date: Mon Jun 29 17:23:35 2020 +0400 Bug 21395: Fix misc/admin/koha-preferences Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d3f0fc135b0b73b7dcf7fee09ca30a42e2e514a3) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit b9d54b390d4dfe1e075360b94c2c6f79c5933de8 Author: Julian Maurice <julian.maurice at biblibre.com> Date: Mon Jun 29 17:13:10 2020 +0400 Bug 21395: Fix C4/Barcodes/ValueBuilder.pm $DEBUG variable was always set to 0, so it was useless Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 3b06780fb29467fd4276dd25d92fca375a382471) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 6e00ffec75908c7e5fa29cb71c3b0fdc9abca9a7 Author: Julian Maurice <julian.maurice at biblibre.com> Date: Mon Jun 29 17:01:25 2020 +0400 Bug 21395: Ignore .perlcriticrc in t/Makefile.t Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 343a866b6fd6850edde89a79b0c534ee2f494f4b) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit d40eaab6d3540061caee6d74ce657f444bbd7310 Author: Julian Maurice <julian.maurice at biblibre.com> Date: Mon Jun 29 16:57:11 2020 +0400 Bug 21395: Fix creation of PO file Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 133a3ef168af12897ba4c670db25d674fc876864) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Barcodes/ValueBuilder.pm | 135 +++++++++++++++++++-------------------- misc/admin/koha-preferences | 2 +- misc/translator/tmpl_process3.pl | 2 +- t/Makefile.t | 1 + 4 files changed, 67 insertions(+), 73 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 16 06:28:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jul 2020 04:28:07 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-30-g760f1eaad5 Message-ID: <E1jvvV9-0003V1-LK@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 760f1eaad5a426c5bd2436c072a2df401202e8e4 (commit) via dbb2717123362bf620184f3ac548d90918d6c1ce (commit) from 31b55f635a07a55c4d1a413dd3b1d48971bc762b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 760f1eaad5a426c5bd2436c072a2df401202e8e4 Author: Emmi Takkinen <emmi.takkinen at outlook.com> Date: Thu Mar 19 09:12:19 2020 +0200 Bug 4985: Fix Plack scope errors This patch 'ours' several variables to fix Plack scope errors in exceptionHolidays.pl. This also adds '@holidays_list' as parameter to 'edit_holidays'. Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit ee3f5d5a85d93dc36d6bdeab5f092c0098d604e1) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit b66500e424dd12a37fe418816947c56cba9134b4) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit dbb2717123362bf620184f3ac548d90918d6c1ce Author: Emmi Takkinen <emmi.takkinen at outlook.com> Date: Fri Feb 7 12:43:54 2020 +0200 Bug 4985: Edit a calendar entry for all branches This patch adds functionality to calendar tool to make edits or deletes to all branches at once. To test: -Apply patch -Add holiday for a library and copy it to all or some libraries -Edit previosly made holiday (edit, delete etc.) and check out "Copy changes to all libraries." checkbox => Changes are made to all libraries sharing changed holiday Sponsored by: Koha-Suomi Oy Signed-off-by: Christofer <christofer.zorn at ajaxlibrary.ca> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit ce2219425d9b97952f5904024fb7575a0809487b) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 6f85f47365a1460d1e68280835d69008424fea45) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/tools/holidays.tt | 6 + tools/exceptionHolidays.pl | 165 ++++++++++++--------- 2 files changed, 97 insertions(+), 74 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 16 06:35:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jul 2020 04:35:27 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-32-gf22bded524 Message-ID: <E1jvvcF-0003tt-9U@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via f22bded52404114572988e445e1ca0398fa3227d (commit) via 4a3486a7bcc06b05b664a69ba5e977988e7897e6 (commit) from 760f1eaad5a426c5bd2436c072a2df401202e8e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f22bded52404114572988e445e1ca0398fa3227d Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Thu Jun 18 09:01:36 2020 -0400 Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 017b67e6c52ab7b79a0187b1ca9fea220117f7ef) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 18faf9b7aa7c313fd9fa086c5f9609ef7b0c70f5) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 4a3486a7bcc06b05b664a69ba5e977988e7897e6 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu Jun 18 16:54:42 2020 -0300 Bug 25805: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 115eeada2b6f959997d21d0e0dd73606f1ca7324) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit c65e76a7c49720cf112c59a0583a9545b34844c4) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Item.pm | 6 +++--- t/db_dependent/SIP/Message.t | 37 ++++++++++++++++++++++++++++++++++++- 2 files changed, 39 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 16 06:46:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jul 2020 04:46:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-35-g30aea44831 Message-ID: <E1jvvn7-0004Ix-HW@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 30aea44831874050e69cb19911d4310d0304aa81 (commit) via 7efb135dfb3d16c8046877de1a47cd1a835bf5d9 (commit) via 36ded4c66cca20c2464e79fc31cd6c6867bbfc3a (commit) from f22bded52404114572988e445e1ca0398fa3227d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 30aea44831874050e69cb19911d4310d0304aa81 Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Thu Jul 16 16:17:14 2020 +1200 Bug 24986: DBIC Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 7efb135dfb3d16c8046877de1a47cd1a835bf5d9 Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Thu Jul 16 16:14:40 2020 +1200 Bug 24986: DBRev 19.11.07.001 Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 36ded4c66cca20c2464e79fc31cd6c6867bbfc3a Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jun 4 12:12:23 2020 +0200 Bug 24986: Modify some borrowers DB fields to (TINY|MEDIUM)TEXT Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 16a5197aa9f96ee8a7fb6c63e15a6c7f9342f773) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit c234daac2afe239625a59940c4aa8ef37453762b) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Borrower.pm | 99 +++++++++++----------------------- Koha/Schema/Result/Deletedborrower.pm | 99 +++++++++++----------------------- installer/data/mysql/kohastructure.sql | 60 ++++++++++----------- installer/data/mysql/updatedatabase.pl | 24 +++++++++ 5 files changed, 119 insertions(+), 165 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 16 06:53:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jul 2020 04:53:59 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-37-g4f6b3c4a61 Message-ID: <E1jvvuB-0004Uf-UT@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4f6b3c4a6173810bba24b89d82eb223226278b9c (commit) via 6d6132777bc1dfd35e990ac469799ece679e4899 (commit) from 30aea44831874050e69cb19911d4310d0304aa81 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4f6b3c4a6173810bba24b89d82eb223226278b9c Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Thu Jul 16 16:24:38 2020 +1200 [19.11.x] Bug 25858: Use bitwise OR for setting a bit in borrowers.flag Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 6d6132777bc1dfd35e990ac469799ece679e4899 Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Thu Jul 16 16:23:07 2020 +1200 [19.11.x] Bug 25858: Don't attempt to set flag if already set Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 16 06:56:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jul 2020 04:56:29 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-38-g0d9ea88b86 Message-ID: <E1jvvwb-0004Yu-Vf@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 0d9ea88b86ea48142aabdb4eea6efb4b98eae3f1 (commit) from 4f6b3c4a6173810bba24b89d82eb223226278b9c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d9ea88b86ea48142aabdb4eea6efb4b98eae3f1 Author: Slava Shishkin <slavashishkin at gmail.com> Date: Wed May 13 20:20:27 2020 +0300 Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm This warning was thrown: Use of uninitialized value $info{"invalid_username_or_password"} in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm line 387. There is the case when hash key can be undefined in numeric comparison. Fixed by adding additional precheck for $info{"invalid_username_or_password"} being Perl's "true". To test: 1) Go to the first page of the web-installer where it asks to login. 2) Observe the warning in the log file. 3) Apply patch. 4) Repeat step 1. 7) Check that previous warning suppressed. Mentored-by: Andrew Nugged <nugged at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d81438e143273a538c09cd16e7f92a83beed4027) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 3a3237da9c2f107a9d4e4a9e9383316ce10e6ecc) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: C4/InstallAuth.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 16 07:01:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jul 2020 05:01:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-39-g46248a65d6 Message-ID: <E1jvw1Y-0004gf-TB@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 46248a65d6f773a25d4f568e3b6a5508f6648bf6 (commit) from 0d9ea88b86ea48142aabdb4eea6efb4b98eae3f1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 46248a65d6f773a25d4f568e3b6a5508f6648bf6 Author: Owen Leonard <oleonard at myacpl.org> Date: Mon Jun 22 23:57:29 2020 +0000 Bug 25793: OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade This patch modifies the OAI XSLT file, correcting the path to jQuery assets and adds a link to jquery-migrate. To test, apply the patch and make sure the "OAI-PMH" system preference is enabled. 1. Go to: <OPACBaseURL>/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marc21 e.g. localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marc21 2. Click on the 'Sets' and 'Metadata' links. The corresponding panels with set and metatdata information should be shown. Tested against master, works as described. Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 23ed2e110e16f04a34c01ac866b470ec725b7522) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 13ac8457d5ef1da87ecbc729ffb93b9f19fd84e1) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/xslt/OAI.xslt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 16 07:06:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jul 2020 05:06:21 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-41-g512d0bfbd4 Message-ID: <E1jvw69-0004mw-ED@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 512d0bfbd417e9e2d7f2e0e46882979138091e96 (commit) via 0cb156cba54e8433a3ea351a322f93c807a934e5 (commit) from 46248a65d6f773a25d4f568e3b6a5508f6648bf6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 512d0bfbd417e9e2d7f2e0e46882979138091e96 Author: Nick Clemens <nick at bywatersolutions.com> Date: Thu Jun 25 10:38:16 2020 +0000 Bug 25875: Unit test Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit a804d4be437a5df3641f854a506642afe3501046) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 7467f10ceb52696f263746d5495532e2b63b8f5b) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 0cb156cba54e8433a3ea351a322f93c807a934e5 Author: Nick Clemens <nick at bywatersolutions.com> Date: Thu Jun 25 10:38:26 2020 +0000 Bug 25875: Move check for module_bit and code to the JOIN If we limit the JOIN to rows with the correct subpermission we won't duplicate the returned patrons To test: 1 - Give a patron full acquisitions permissions 2 - Also give them several subpermissions on other areas 3 - Go to Acquisitions 4 - Edit a fund 5 - Add a user to the fund 6 - Search for user above 7 - They return multiple times in results 8 - Apply patch 9 - Restart all the things 10 - Repeat search 11 - Patron appears once Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 721876785142fea84f02c7dbe4f325e2a605bd0f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 59e1e78c6d59ee6ced202382e2910676a4e32360) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 12 +++++++---- t/db_dependent/Utils/Datatables_Members.t | 35 ++++++++++++++++++++++++++++++- 2 files changed, 42 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 16 07:11:08 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jul 2020 05:11:08 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-42-geb9650bb1a Message-ID: <E1jvwAm-0004u4-Sk@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via eb9650bb1aa01abb8cf6721f35b077f8421313aa (commit) from 512d0bfbd417e9e2d7f2e0e46882979138091e96 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eb9650bb1aa01abb8cf6721f35b077f8421313aa Author: Lucas Gass <lucas at bywatersolutions.com> Date: Wed May 27 21:35:16 2020 +0000 Bug 22672: Change <i> to <em> and <b> to <strong> in templates, includes, xslt This patch attempts to replace <i> with <em> AND <b> with <strong> in order to more accessible to screen readers. This patch makes no attempt to change Font Awesome icons which typically use <i>. I found templates, includes and XSLT by using 'git grep ‘<b>’ koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘<i>’ koha-tmpl/opac-tmpl/bootstrap/en/ TEST PLAN: There should be no visible difference on the changed pages. The files changed are: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/xslt/OAI.xslt Read the changes and make sure everything looks correct, try to visit as many pages as possible and confirm that everything looks as it should. grep around for cases of <b> or <i> that I could have missed. Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d3036d46ba4b26df040a25f960c3bc3081734c26) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 25d820f3226c6116d064591abc67e2463a571f50) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/includes/holds-table.inc | 12 ++++++------ koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt | 2 +- .../bootstrap/en/modules/opac-auth-MARCdetail.tt | 4 ++-- .../en/modules/opac-authoritiessearchresultlist.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt | 2 +- .../bootstrap/en/modules/opac-course-details.tt | 6 +++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt | 4 ++-- .../opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 4 ++-- .../opac-tmpl/bootstrap/en/modules/opac-opensearch.tt | 2 +- .../bootstrap/en/modules/opac-overdrive-search.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 2 +- .../bootstrap/en/modules/opac-results-grouped.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 5 +++-- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 8 ++++---- .../bootstrap/en/xslt/NORMARCslim2OPACResults.xsl | 4 ++-- .../bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl | 4 ++-- koha-tmpl/opac-tmpl/xslt/OAI.xslt | 16 ++++++++-------- 23 files changed, 49 insertions(+), 48 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 16 16:53:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jul 2020 14:53:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-218-g4b0c2e56e4 Message-ID: <E1jw5Fx-0000JR-L2@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4b0c2e56e43ddacbd3983a8669026b95cd08d660 (commit) from 189851fb9bbc831bb2875c2c440877c2562583d0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4b0c2e56e43ddacbd3983a8669026b95cd08d660 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jul 16 15:16:41 2020 +0100 Bug 25851: DBRev 20.06.00.004 Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/atomicupdate/bug_25851.perl | 7 ------- installer/data/mysql/updatedatabase.pl | 8 ++++++++ 3 files changed, 9 insertions(+), 8 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_25851.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 16 17:08:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Jul 2020 15:08:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-227-g981b601c39 Message-ID: <E1jw5UU-0000dg-0C@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 981b601c39e97e23d309fe342c00a819a9ee8ad6 (commit) via 40ab030060d6cbacb0be9df981fb28a6ade705ea (commit) via 96a871035043c7ffd93c61e756ee1ff89e3da0f0 (commit) via 92970a9abad312a07d9efba46cc57b27469a0509 (commit) via afd88e1d21a5cb5f2198c058144065b64098c124 (commit) via 25127f422821756b030b8f377b3e112b907be5eb (commit) via 95c8d19530e8bef20e02be0b74d7927764bf7ed1 (commit) via 4ed4e468d2ceaf4502b817feb791656d5a159fa5 (commit) via 082da615e649146197fbc9e0a20da672a82d4816 (commit) from 4b0c2e56e43ddacbd3983a8669026b95cd08d660 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 981b601c39e97e23d309fe342c00a819a9ee8ad6 Author: Owen Leonard <oleonard at myacpl.org> Date: Thu Jul 2 12:50:17 2020 +0000 Bug 25909: Recent change to datatables JS in the OPAC causes errors This patch reverts some changes made by Bug 25287 which prematurely introduced the double-underscore i18n function. The i18n features haven't been fully implemented in the OPAC. Some lines are reverts to the previous version, and some are additions, for instance where Bug 25287 introduced new DataTables features and a new string translation is required. In addition to i18n changes, the patch also reverts the default configuration of DataTables in the OPAC so that the "dom" configuration option is set back to "t." This turns off features like pagination buttons, filters, etc. which were previously disabled by default. Enabling these features requires revision to the OPAC CSS in order for them to display well. To test, apply the patch and view a page in the OPAC which includes a DataTable. For instance: checkouts on the "your summary" page, serial issues on the "full subscription history" page. Tables should display correctly and sorting should work correctly. There should be no other DataTables controls visible. To test translatability: To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from the templates e.g. misc/translator/po/fr-FR-opac-bootstrap.po - Locate strings pulled from bootstrap/en/includes/datatables.inc for translation, e.g.: #. SCRIPT #: opac-tmpl/bootstrap/en/includes/datatables.inc:4 msgid "Copy to clipboard" msgstr "" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR Open the translated copy of datatables.inc and confirm that the translated string appears. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> commit 40ab030060d6cbacb0be9df981fb28a6ade705ea Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jul 7 09:27:48 2020 +0100 Bug 25944: Schema fix for illrequests route The illrequests path was missing the `comments` and `status_alias` embedable relations in the path specification. Test plan: 1/ Ensure you have the latest Mojolicious + OpenAPI modules installed. 2/ Navigate to the ill requests page and note that the table is empty. 3/ Note that under the networking tab in your browsers developer tools that the api call fails with a 400 error. 4/ Apply the patch 5/ Refresh the page 6/ The table should now load and the api route should return a proper 200 response. 7/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Magnus Enger <magnus at libriotech.no> Applied the patch to a production server that was having the 400 error on the main ILL page, and the error was gone. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> commit 96a871035043c7ffd93c61e756ee1ff89e3da0f0 Author: Nick Clemens <nick at bywatersolutions.com> Date: Thu May 21 13:41:23 2020 +0000 Bug 25566: Add option to ignore found holds and use it when checking high holds To test: 1 - Find or create a record with 10 items 2 - Set sysprefs: decreaseLoanHighHolds - enable decreaseLoanHighHoldsDuration - 2 decreaseLoanHighHoldsValue - 2 decreaseLoanHighHoldsControl - 'over the number of holdable items'/dynamic 3 - Set circ rules to allow 1 hold per record on the relevant record 4 - Place 3 holds on the record 5 - Check one item in and confirm hold to set to waiting 6 - Issue to the patron with the waiting hold 7 - Get a notice that loan period is decreased 8 - Don't confirm the checkout 9 - Apply patch 10 - Restart all the things 11 - Repeat checkout, no decrease this time! Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> commit 92970a9abad312a07d9efba46cc57b27469a0509 Author: Nick Clemens <nick at bywatersolutions.com> Date: Tue Jul 7 12:05:42 2020 +0000 Bug 25850: (QA follow-up) use dt_from_string Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> commit afd88e1d21a5cb5f2198c058144065b64098c124 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Mon Jun 29 09:54:58 2020 +0100 Bug 25850: (QA follow-up) Match logic in is_holiday Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> commit 25127f422821756b030b8f377b3e112b907be5eb Author: Andreas Jonsson <andreas.jonsson at kreablo.se> Date: Tue Jun 23 15:57:29 2020 +0200 Bug 25850: Adapt day of week in Koha::Calendar::get_push_amt to 0..6 with 0 being Sunday. 1. Go to tools -> calendar and make sure Sundays are holidays by adding a holiday on a Sunday and selecting "Holiday repeated every same day of the week" and "Copy to all libraries" and save. 2. Go to administration -> system preferences and select "Use the calendar to push the due date to the next open matching weekday for weekly loan periods, or the next open day otherwise" for the system preference "useDaysMode" and save the system preferences. 3. Put the below code in a file name test.pl and execute it using the command "sudo koha-shell -c 'perl test.pl' kohadev" use Koha::Calendar; my $calendar = Koha::Calendar->new( branchcode => 'CPL' ); $dt = DateTime->new( year => 2020, month => 06, day => 21 ); print "This is a sunday: " . $dt->day_of_week . "\n"; my $ndt = $calendar->next_open_days($dt, 0); print "This is a monday: " . $ndt->day_of_week . "\n"; 4. Without the patch applied, this script will freeze after printing "This is a sunday ...". Abort using ctrl-c. 5. Apply patch and run the script again. The test script will now complete. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> commit 95c8d19530e8bef20e02be0b74d7927764bf7ed1 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jun 26 16:52:50 2020 +0100 Bug 25850: Regression Test This patch adds a unit test to test for an infinite loop as highlighted by the bug. Test plan 1/ Run the test before applying the fix 2/ The test should fail for 'Sundays' 3/ Apply the subsquent patch 4/ Re-run the test 5/ It should now pass Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> commit 4ed4e468d2ceaf4502b817feb791656d5a159fa5 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jun 26 16:24:00 2020 +0100 Bug 25850: Add tests for weekday holidays Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> commit 082da615e649146197fbc9e0a20da672a82d4816 Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Date: Wed Jul 15 11:08:32 2020 +0000 Bug 25992: Make SIP2 logger subroutines exportable to prevent crash If the subroutines are not exportable we get the following crash: > Undefined subroutine &C4::SIP::SIPServer::set_logger To test: In kohadevbox run for example: $ ps -aux # check that no existing sip server is running, kill the process if exists $ perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml $ koha/misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item 3999900000001 -m item_information After applying this patch the Undefined subroutine error should be gone. Note: when using the sip_cli_emulator.pl the credentials can be anything. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- C4/Reserves.pm | 29 +++--- C4/SIP/Logger.pm | 3 + Koha/Calendar.pm | 9 +- api/v1/swagger/paths/illrequests.json | 4 +- .../opac-tmpl/bootstrap/en/includes/datatables.inc | 8 +- koha-tmpl/opac-tmpl/bootstrap/js/datatables.js | 48 +++++----- t/db_dependent/Calendar.t | 101 ++++++++++++++++++++- t/db_dependent/DecreaseLoanHighHolds.t | 26 +++++- t/db_dependent/Reserves/MultiplePerRecord.t | 7 +- 10 files changed, 190 insertions(+), 47 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 17 04:39:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jul 2020 02:39:21 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-43-g54c6ae736d Message-ID: <E1jwGHR-00061f-4p@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 54c6ae736ddd1843c6bf71563e7b6af33a152ee6 (commit) from eb9650bb1aa01abb8cf6721f35b077f8421313aa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 54c6ae736ddd1843c6bf71563e7b6af33a152ee6 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue May 26 12:28:13 2020 +0200 Bug 25434: Display selections-toolbar on small screens Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 4d9ca6b13d29acc088777e9df414aaa54be4e389) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 014dfd82b6043437a08589e18f2917aaebdfc592) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 17 22:26:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Jul 2020 20:26:59 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-78-g9baea3aceb Message-ID: <E1jwWwd-0000L2-D5@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 9baea3acebe383f80c75e62b0ae5ac61330dcc3c (commit) via 266d7de35a9f271403318eae1c55f46077865a6e (commit) from c0136357c539ed069504fe02bdda1ba7ab54541a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9baea3acebe383f80c75e62b0ae5ac61330dcc3c Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri Jul 17 19:52:49 2020 +0000 Bug 25851: DBRev 20.05.01.003 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 266d7de35a9f271403318eae1c55f46077865a6e Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Jun 24 08:37:18 2020 +0200 Bug 25851: (bug 18928 follow-up) Remove holdallowed rule is value is an empty string On the interface, if "Hold policy" is "Not set", the rule does not exist in the table. We should reflect that during the update DB process. Test plan: 1. Set "Hold policy" to "Not set" 2. Confirm that you can place holds 3. Confirm that the rule does not exist in the DB table 4. Set the value to an empty string (manually) 5. Confirm that you cannot longer place holds 6. Go to the circulation rules page and confirm that the value of "Hold policy" is "Not set" 7. Execute the update DB entry 8. Confirm that you can place holds 9. Confirm that the rule does not exist in the DB table Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c1e1c233ca69fe9f73efb1c939148f8c7afcf11e) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 20 14:34:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Jul 2020 12:34:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-240-g2b56ae1d4a Message-ID: <E1jxV0V-0008Cr-T2@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2b56ae1d4a231a83f52420ec9efc4829226fa86a (commit) via a21a3bba6b23beed7aef9852f7c82efbfc1c3c1e (commit) via 00a12f548b4336f6c6eae8ce30e7c6cfaf7ed05c (commit) via 00f04146e915b2b1a9881439ac34088e6486921f (commit) via 6b9572e0c8fb9f1ad1e60ed5db50e69c60ac1a00 (commit) via 2fbe775070637ebdddcc9ea0b455e80dbb85a83d (commit) via f058e63b5ae573469ea21777b76b822afd8a3442 (commit) via 312dd03223fbce83c77315250af9f1fc9ee0d4a1 (commit) via 7bb31cffae27dc398a7b4a4decf3623ec65478ac (commit) via e441cb35fb13670e65b9437706561c17d1311945 (commit) via f77a377c939080eed36401746b5d722c91ee964b (commit) via 7b84fda33b23347846ae50016f1e4b38b0fd95f4 (commit) via 56220d211d7b5c4e2622787f9ea38ab12c8868f5 (commit) from 981b601c39e97e23d309fe342c00a819a9ee8ad6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2b56ae1d4a231a83f52420ec9efc4829226fa86a Author: Didier Gautheron <didier.gautheron at biblibre.com> Date: Tue Apr 28 07:43:46 2020 +0200 Bug 25293: Don't call escapeHtml on null Test Plan: 1) Create two Checkouts 2) view patron's checkout list cgi-bin/koha/members/moremember.pl?borrowernumber=pp <show checkout> 3) in mysql shell delete a checkout home branch: update items set homebranch = null where itemnumber = xx; 4) view patron's checkout list, again Without this patch the list is empty. Same if biblio title is null (update biblio set title = null where biblionumber = yy;). Javascript error: TypeError: oObj.title is null Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit a21a3bba6b23beed7aef9852f7c82efbfc1c3c1e Author: Slava Shishkin <slavashishkin at gmail.com> Date: Mon Jun 29 22:26:42 2020 +0300 Bug 25896: Add missing closing </td> tag File koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt had one lost closing </td> tag in "daysmode" block. Added. Mentored-by: Andrew Nugged <nugged at gmail.com> Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 00a12f548b4336f6c6eae8ce30e7c6cfaf7ed05c Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Jul 10 14:30:09 2020 +0000 Bug 25974: Remove inline style from table settings administration page This patch removes an inline style attribute from the table settings administration template. A different style is added to the page's <style> block to try to accomplish a similar effect of expressing the hierarchy of the page. To test, apply the patch and go to Administration -> Table settings. The individual tables of settings should be offset from the headings above them. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 00f04146e915b2b1a9881439ac34088e6486921f Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Jul 14 21:30:39 2020 +0000 Bug 25987: Fix alignment of fields in label batch creation form This patch makes minor markup changes to the template for the label batch creation process so that form fields line up correctly. Unrelated change: A hint has been moved out of the label area to below the textarea in order to conform with established patterns. To test, apply the patch and go to Tools > Label creator > New > Label batch. - In the batch creation form the "Enter by itemnumber" and "Enter by barcode" should be aligned correctly with each other. - The "One number per line..." hint should appear below the textarea. - Test that the form fields are still correctly aligned after adding some items to the batch and the "description" field is shown in the form. Works for me! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 6b9572e0c8fb9f1ad1e60ed5db50e69c60ac1a00 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Tue Jan 21 17:53:09 2020 +0000 Bug 24473: Add $raw filter for Syndetics content Syndetics offers enhanced content in the OPAC under the tabs 'Title Notes', 'Excerpt', 'About the author', 'Editions'. They provide this info as HTML therefore we should filter it as $raw so the content shows up without the markup. Signed-off-by: Stina Hallin <stina.hallin at ub.lu.se> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 2fbe775070637ebdddcc9ea0b455e80dbb85a83d Author: Didier Gautheron <didier.gautheron at biblibre.com> Date: Wed Jun 24 16:03:16 2020 +0200 Bug 25862: Prevent TinyMCE to mangle local url links To test: 1 create a report 1 if it doesn't exist 2 open /cgi-bin/koha/tools/koha-news.pl 3 create a news 4 add a HTML link with Insert/Edit link tinyMCE dialog box to /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run%20this%20report "report 1" 5 save 6 on the main page "report 1" link returns a 404 error Apply patch 7 Modify news' URL 8 Test it works in: tools/koha-new.pl admin/branches.pl and admin/preferences.pl Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit f058e63b5ae573469ea21777b76b822afd8a3442 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jul 20 12:57:00 2020 +0200 Bug 24379: DBIC schema changes Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 312dd03223fbce83c77315250af9f1fc9ee0d4a1 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jul 20 12:53:43 2020 +0200 Bug 24379: DBRev 20.06.00.005 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 7bb31cffae27dc398a7b4a4decf3623ec65478ac Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jan 8 20:59:38 2020 +0000 Bug 24379: Make login_attempts not nullable While the column defaults to 0 in Koha::Object->store we set to NULL if NULLABLE When trying to reset a patrons password we check that the account is not administratively locked: login_attempts != -1 This query does not return rows where login_attempts IS NULL. It will return accounts where login_attempts = 0 Let's default to 0 like we intend To test: 1 - Create a new patron 2 - Note their login_attempts is NULL SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1 3 - Enable OpacResetPassword 4 - Attempt to reset password before logging in, you cannot 5 - Apply patch, updatedatabase, restart_all, update schema 6 - Create another patron 7 - Their login attempts should be 0 8 - Attempt to reset password, it works! Bug 24379: Fix the test First we create a patron using TestBuilder to get a hashref of valid info. Then we delete it and create a new patron using Koha::Patron->new Once stored, we should call discard_changes to make the calculated values available in the currenct object. Bug 24379: Don't drop default of 0 for login attempts When moving the column we drop the default, this means that DBs upgraded form earlier versions get the wrong values set To test: 1 - Checkout 16.11.x 2 - Reset all 3 - Checkout master 4 - updatedatabase 5 - SHOW CREATE TABLE borrowers; 6 - Note the column login_attempts defaults to NULL 7 - Apply patch(es) 8 - Repeat 9 - Now it defaults ot 0 (and has NOT NULL if applied all) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e441cb35fb13670e65b9437706561c17d1311945 Author: Fridolin Somers <fridolin.somers at biblibre.com> Date: Wed Jun 24 17:05:30 2020 +0200 Bug 25868: Fix transfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed <form> tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfert 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit f77a377c939080eed36401746b5d722c91ee964b Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jun 24 16:17:19 2020 +0000 Bug 25869: Fix Coce display for lists To test: 1 - Enable Coce for Opac CoceHost: https://coce.bywatersolutions.com CoceProviders: Select all OpacCoce: Enable 2 - Do a search on the Opac, confirm you see some covers 3 - Add some of the items with covers to a public list 4 - View the public list 5 - Note no covers display 6 - Apply patch 7 - Success! Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 7b84fda33b23347846ae50016f1e4b38b0fd95f4 Author: David Cook <dcook at prosentient.com.au> Date: Wed Jul 8 07:10:50 2020 +0000 Bug 25950: Remove <client> in X-Forwarded-For from proxy tests This patch removes the <client> ip address in the X-Forwarded-For header from being tested against koha_trusted_proxies. Without this patch, REMOTE_ADDR will be set to null, if the <client> ip address matches against koha_trusted_proxies. To Test: 1. Run the unit test t/Koha/Middleware/RealIP.t Signed-off-by: Didier Gautheron <didier.gautheron at biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 56220d211d7b5c4e2622787f9ea38ab12c8868f5 Author: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Date: Fri Jun 12 13:51:16 2020 +0000 Bug 25726: make holds to pull ignore holds where found is not null and itemnumber is null To test: 1- place 2 bib-level holds on available items 2- confirm they both show on Holds to Pull 3- edit one hold from the database to set found='T' 4- reload Holds to Pull, confirm it is now empty 5- apply patch 6- Reload Holds to Pull 7- confirm it now shows the hold you did not edit Signed-off-by: donnab <donna at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> [EDIT] Using capitals for SQL reserved words; added a FIXME Tested with: update reserves set found='T', itemnumber=NULL where reserve_id=... This should be a workaround while we fix the underlying problem. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Middleware/RealIP.pm | 3 +- Koha/Schema/Result/Borrower.pm | 8 +- Koha/Schema/Result/Deletedborrower.pm | 8 +- circ/branchtransfers.pl | 44 ++---- circ/pendingreserves.pl | 4 +- installer/data/mysql/kohastructure.sql | 4 +- installer/data/mysql/updatedatabase.pl | 13 +- .../prog/en/includes/wysiwyg-systempreferences.inc | 1 + .../prog/en/modules/admin/branches.tt | 1 + .../prog/en/modules/admin/columns_settings.tt | 6 +- .../prog/en/modules/admin/smart-rules.tt | 1 + .../prog/en/modules/circ/branchtransfers.tt | 28 ++-- .../prog/en/modules/labels/label-edit-batch.tt | 23 ++-- .../prog/en/modules/tools/koha-news.tt | 1 + koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 14 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 10 +- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 4 +- t/Koha/Middleware/RealIP.t | 152 +++++++++++++-------- t/db_dependent/Koha/Patron.t | 21 ++- 20 files changed, 209 insertions(+), 139 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jul 21 12:52:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 21 Jul 2020 10:52:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-341-g56ee42082f Message-ID: <E1jxpsZ-0006Xs-0p@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 56ee42082f0382d2b5e5a8cef081bef886664d7d (commit) via 4f5f5d88b98c2d1f6cc20bc6be6f5b41fb7d3c48 (commit) via 4aa93f04f406b010cd26ea121332133f2599f800 (commit) via 1326fa076b2311ffd9a1df4b995309670bf55cdd (commit) from 01ab775440ee8418e21872c309acee7b1739fad8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 56ee42082f0382d2b5e5a8cef081bef886664d7d Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jul 21 11:18:16 2020 +0100 Bug 8338: (QA follow-up) Fix test for backdated return A test for CalculateFinesOnBackdate was introduced since this bug was written and needed updateing. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 4f5f5d88b98c2d1f6cc20bc6be6f5b41fb7d3c48 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Jul 21 10:08:02 2020 +0200 Bug 23820: Fix Koha/Club/Hold.t kohadev-koha at kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Club/Hold.t t/db_dependent/Koha/Club/Hold.t .. Patron(238) Hold cannot be placed. Reason: libraryNotPickupLocation at /kohadevbox/koha/Koha/Club/Hold.pm line 98. # Looks like you planned 5 tests but ran 4. t/db_dependent/Koha/Club/Hold.t .. 1/1 # Failed test 'add' # at t/db_dependent/Koha/Club/Hold.t line 86. Can't call method "borrowernumber" on an undefined value at t/db_dependent/Koha/Club/Hold.t line 83. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 4aa93f04f406b010cd26ea121332133f2599f800 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Jul 21 09:57:08 2020 +0200 Bug 24151: Use fully qualified names for UpdateStats t/db_dependent/Koha/Account/Line.t .. 8/12 # Looks like you planned 16 tests but ran 3. # Failed test 'void() tests' # at t/db_dependent/Koha/Account/Line.t line 723. Undefined subroutine &Koha::Account::UpdateStats called at /kohadevbox/koha/Koha/Account.pm line 289. It's certainly caused by a circ dep from commit 5ce968e0e571f555261c02a9e1d27447611cdb89 Bug 24151: Copy info to the pseudonymized table when a transaction is done See also bug 17600 for more context. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 1326fa076b2311ffd9a1df4b995309670bf55cdd Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Jul 21 09:47:11 2020 +0200 Bug 22844: Fix yaml_valid.t - don't pick .json files Only .pref are considered yaml files. kohadev-koha at kohadevbox:/kohadevbox/koha$ time prove xt/yaml_valid.t xt/yaml_valid.t .. 1/19 # Failed test 'borrowers.json is YAML' # at xt/yaml_valid.t line 39. # Failed test 'items.json is YAML' # at xt/yaml_valid.t line 39. # Looks like you failed 2 tests of 19. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: Koha/Account.pm | 4 ++-- t/db_dependent/Circulation/Returns.t | 10 +++++++--- t/db_dependent/Koha/Club/Hold.t | 2 +- xt/yaml_valid.t | 12 +++++++++--- 4 files changed, 19 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 05:27:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 03:27:59 +0000 Subject: [koha-commits] main Koha release repository annotated tag v19.11.08 created. v19.11.08 Message-ID: <E1jy5QF-0003JW-7A@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v19.11.08 has been created at cd38d80aede36321302a4800d6eabb3685263c5d (tag) tagging 781c90b3f76619a307ba6ecce39ee5e3b43ab5cb (commit) replaces v19.11.07 tagged by Aleisha Amohia on Wed Jul 22 14:58:24 2020 +1200 - Log ----------------------------------------------------------------- Koha release 19.11.08 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABCgAGBQJfF6tQAAoJEEVLh2SbW7cv6scP/3UCmXMfNCio26PoLuA8B+x9 Vd/md8GdQQOt/CnD58DhGnjF4ktCC8s5CN/hNLVjpGbcOauUNAzPwF5DHR6ZPD5V tRhCFS0b22PZks0YAMTrCg4johqsZ5jcQHTsX/ZB0z7QueghmqnuIAuMFxBBJwy7 Ydpz33stfHnRJqGl2pI0Ut2yu3rZIA9gMRLvjsVu9OPaMulvwnt7oAc+DSx13GmX sSxqLTjPl5CtC7DdbhMzLe/26/WyJdoAcImoBJCgc1GJNfyWOa7XjobKXVXbDxwS JYJlNyK/90VNsE/0RkJKiHp0FNqGlDv3BwAXD/IdsEskHjZz5q/3lrH4hexYbv3w wgEEv99NkcpwiJrTmhWTCXc0lKR8XqrZ8fSwlBePJJdloOaTIUpVlEW/VW2Uk+kR eh9xklVsoPcrrpZPVTAqhFsFyaJ3BFx+GC4Tj/VioZzDsf9+8DWrOeWWeDZRvNAe FEuJuDOLnUsZm/k0p3aRAEWoFVs4LLqv0WFl+34bAqmVba1b/uRer7w2OR9jy/hQ CshRWf+63nQ1Rzx2vDTrU3WvGZ4mGCcR3/cXQIScqMxRvnK5xH2W1ejma6egUPKj 2SwMQJwI+o4FdeVR3RSzZc9V9j3Wd+hZA2286brgMYopiXPPYrdIEDnvGlj1h+4F a0ktCUdpcAwzvN6ZthoM =q9jr -----END PGP SIGNATURE----- Aleisha Amohia (8): Bug 25861: Removing non-existent 'important' field from SQL Bug 24986: DBRev 19.11.07.001 Bug 24986: DBIC [19.11.x] Bug 25858: Don't attempt to set flag if already set [19.11.x] Bug 25858: Use bitwise OR for setting a bit in borrowers.flag Fixing po files for 19.11.08 Increment version for 19.11.08 release Update release notes for 19.11.08 release Andreas Roussos (1): Bug 25756: remove erroneous hyphen David Cook (1): Bug 25509: Remove useless libjs-jquery dependency Emmi Takkinen (3): Bug 25789: Don't allow past date as holds expiration date Bug 4985: Edit a calendar entry for all branches Bug 4985: Fix Plack scope errors Hayley Mapley (1): Bug 25151: Fixing semantic headings in opac-basket.tt Jonathan Druart (4): Bug 25553: Make date columns sortable on the edit items table Bug 25611: Use selected vendor when creating a basket Bug 24986: Modify some borrowers DB fields to (TINY|MEDIUM)TEXT Bug 25434: Display selections-toolbar on small screens Katrin Fischer (2): Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml Bug 11994: (follow-up) Make things work when LibraryName is empty Koha translators (1): Translation updates for Koha 19.11.08 Kyle M Hall (2): Bug 25769: Patron self modification triggers change request for date of birth to null Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name Lucas Gass (3): Bug 25236: Compile CSS Bug 22807: Compile CSS Bug 22672: Change <i> to <em> and <b> to <strong> in templates, includes, xslt Martin Renvoize (9): Bug 25238: Fix semantic heading for opac-details Bug 25236: Fix semantic heading for opac-facets.inc Bug 25236: Fix semantic heading for opac-topissues.inc Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Bug 25154: Add heading where content is introduced in opac-results.tt Bug 25239: Fix semantic heading for opac-reserve.tt Bug 22807: Add 'Skip to content' option Bug 22807: Ensure only one maincontent on searcresults Bug 22807: Ensure .maincontent appears on all pages Nick Clemens (4): Bug 25875: Move check for module_bit and code to the JOIN Bug 25875: Unit test Bug 25864: Unit test adjustment Bug 25864: Lower case fields for searching Owen Leonard (5): Bug 25447: Terminology: Fix button text "Edit biblio" Bug 24352: Correct location and collection labels in OPAC search results Bug 11994: Fix OpenSearch discovery in the OPAC Bug 22807: (follow-up) Update style of skip button Bug 25793: OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade Slava Shishkin (1): Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm Tomás Cohen Arazi (4): Bug 25570: Regression tests Bug 25570: Paginate results by default in objects->search Bug 25570: (follow-up) Fix tests Bug 25805: Regression tests ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jul 21 17:44:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 21 Jul 2020 15:44:53 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-80-gecdefe969e Message-ID: <E1jxuRp-00061J-Dk@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ecdefe969e76c0819e8386f8af539f79528a44b3 (commit) via b2504f1a2fb9b9d44f743ad981794d3365c89951 (commit) from 9baea3acebe383f80c75e62b0ae5ac61330dcc3c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ecdefe969e76c0819e8386f8af539f79528a44b3 Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jun 24 12:20:03 2020 +0000 Bug 25864: Lower case fields for searching To recreate: 1 - Have Koha using ES5 and Elasticsearch as search engine 2 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate 3 - Do a search in authorities using 'Search entire record' (abduction if using sample db) 4 - Note no results 5 - View the page source and find 'search_query' 6 - Note the uppercased fields 7 - curl 'es:9200/koha_kohadev_authorities/data/417?pretty' 8 - Note all fields lower-cased 9 - Apply patch 10 - Repeat search 11 - It works! Signed-off-by: Heather Hernandez <heather_hernandez at nps.gov> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 2ab6018b6e14ae2153093db148f04f71405f4493) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit b2504f1a2fb9b9d44f743ad981794d3365c89951 Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jun 24 12:22:48 2020 +0000 Bug 25864: Unit test adjustment Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 579a3c11edf77d36488f352d88ae373cc4cbfa21) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +- t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jul 21 15:05:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 21 Jul 2020 13:05:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-342-g14932ae7d3 Message-ID: <E1jxrxt-0001MT-Nq@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 14932ae7d3bf864f64bffc9b1b015a07e11c8e2e (commit) from 56ee42082f0382d2b5e5a8cef081bef886664d7d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 14932ae7d3bf864f64bffc9b1b015a07e11c8e2e Author: Mason James <mtj at kohaaloha.com> Date: Thu Jun 18 13:26:20 2020 +1200 Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 to test... 1/ attempt to install koha 20.05 package on deb11, fail :'( 2/ apply patch and build new koha package 3/ attempt to install new koha package on deb11, succeed! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: Makefile.PL | 4 ++-- debian/control | 6 +++--- debian/control.in | 6 +++--- debian/templates/koha-conf-site.xml.in | 24 ++++++++++++------------ rewrite-config.PL | 2 +- 5 files changed, 21 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 05:28:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 03:28:22 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.08 Message-ID: <E1jy5Qc-0003LQ-Jr@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 781c90b3f76619a307ba6ecce39ee5e3b43ab5cb (commit) from 68af6695b028dbdbc2a9ac035bd1097a90c7c3e3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 781c90b3f76619a307ba6ecce39ee5e3b43ab5cb Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Wed Jul 22 14:55:28 2020 +1200 Update release notes for 19.11.08 release Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: misc/release_notes/release_notes_19_11_08.html | 464 +++++++++++++++++++++++++ misc/release_notes/release_notes_19_11_08.md | 376 ++++++++++++++++++++ 2 files changed, 840 insertions(+) create mode 100644 misc/release_notes/release_notes_19_11_08.html create mode 100644 misc/release_notes/release_notes_19_11_08.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 03:22:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 01:22:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-48-g68af6695b0 Message-ID: <E1jy3TD-0008Vs-8J@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 68af6695b028dbdbc2a9ac035bd1097a90c7c3e3 (commit) via 7eef01a41b025a05ca14599dff70cb13d39e767e (commit) via ee24fe92e1aea205baa9f78e33ac9476ece61e9b (commit) from 8a66977e1ebe53fdbcc21abeb578f425c4e7bbd8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 68af6695b028dbdbc2a9ac035bd1097a90c7c3e3 Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Wed Jul 22 12:53:18 2020 +1200 Increment version for 19.11.08 release Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit 7eef01a41b025a05ca14599dff70cb13d39e767e Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Wed Jul 22 12:50:54 2020 +1200 Fixing po files for 19.11.08 Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit ee24fe92e1aea205baa9f78e33ac9476ece61e9b Author: Koha translators <> Date: Tue Jul 21 21:41:57 2020 -0300 Translation updates for Koha 19.11.08 Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + misc/translator/po/am-Ethi-marc-MARC21.po | 23 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 6 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 6 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 609 ++-- misc/translator/po/am-Ethi-pref.po | 106 +- misc/translator/po/am-Ethi-staff-prog.po | 322 +- misc/translator/po/ar-Arab-marc-MARC21.po | 19 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-messages.po | 9 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 609 ++-- misc/translator/po/ar-Arab-pref.po | 114 +- misc/translator/po/ar-Arab-staff-prog.po | 322 +- misc/translator/po/as-IN-marc-MARC21.po | 19 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 600 ++-- misc/translator/po/as-IN-pref.po | 106 +- misc/translator/po/as-IN-staff-prog.po | 318 +- misc/translator/po/az-AZ-marc-MARC21.po | 19 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 605 ++-- misc/translator/po/az-AZ-pref.po | 106 +- misc/translator/po/az-AZ-staff-prog.po | 318 +- misc/translator/po/be-BY-marc-MARC21.po | 19 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 608 ++-- misc/translator/po/be-BY-pref.po | 106 +- misc/translator/po/be-BY-staff-prog.po | 318 +- misc/translator/po/bg-Cyrl-marc-MARC21.po | 23 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 6 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 6 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 609 ++-- misc/translator/po/bg-Cyrl-pref.po | 106 +- misc/translator/po/bg-Cyrl-staff-prog.po | 322 +- misc/translator/po/bn-IN-marc-MARC21.po | 23 +- misc/translator/po/bn-IN-marc-NORMARC.po | 6 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 6 +- misc/translator/po/bn-IN-opac-bootstrap.po | 609 ++-- misc/translator/po/bn-IN-pref.po | 106 +- misc/translator/po/bn-IN-staff-prog.po | 322 +- misc/translator/po/ca-ES-marc-MARC21.po | 19 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 609 ++-- misc/translator/po/ca-ES-pref.po | 106 +- misc/translator/po/ca-ES-staff-prog.po | 1042 +++--- misc/translator/po/cs-CZ-marc-MARC21.po | 23 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 6 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 6 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 613 ++-- misc/translator/po/cs-CZ-pref.po | 112 +- misc/translator/po/cs-CZ-staff-prog.po | 338 +- misc/translator/po/cy-GB-marc-MARC21.po | 696 +++- misc/translator/po/cy-GB-marc-NORMARC.po | 11 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 39 +- misc/translator/po/cy-GB-opac-bootstrap.po | 1738 ++++++--- misc/translator/po/cy-GB-pref.po | 114 +- misc/translator/po/cy-GB-staff-prog.po | 3747 +++++++++++++++----- misc/translator/po/da-DK-marc-MARC21.po | 19 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 607 ++-- misc/translator/po/da-DK-pref.po | 108 +- misc/translator/po/da-DK-staff-prog.po | 320 +- misc/translator/po/de-CH-marc-MARC21.po | 19 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 609 ++-- misc/translator/po/de-CH-pref.po | 110 +- misc/translator/po/de-CH-staff-prog.po | 321 +- misc/translator/po/de-DE-marc-MARC21.po | 19 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 615 ++-- misc/translator/po/de-DE-pref.po | 139 +- misc/translator/po/de-DE-staff-prog.po | 335 +- misc/translator/po/dz-marc-MARC21.po | 19 +- misc/translator/po/dz-marc-NORMARC.po | 2 +- misc/translator/po/dz-marc-UNIMARC.po | 2 +- misc/translator/po/dz-opac-bootstrap.po | 600 ++-- misc/translator/po/dz-pref.po | 106 +- misc/translator/po/dz-staff-prog.po | 318 +- misc/translator/po/el-GR-marc-MARC21.po | 23 +- misc/translator/po/el-GR-marc-NORMARC.po | 6 +- misc/translator/po/el-GR-marc-UNIMARC.po | 6 +- misc/translator/po/el-GR-opac-bootstrap.po | 616 ++-- misc/translator/po/el-GR-pref.po | 110 +- misc/translator/po/el-GR-staff-prog.po | 324 +- misc/translator/po/en-GB-marc-MARC21.po | 19 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 605 ++-- misc/translator/po/en-GB-pref.po | 106 +- misc/translator/po/en-GB-staff-prog.po | 320 +- misc/translator/po/en-NZ-marc-MARC21.po | 19 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 609 ++-- misc/translator/po/en-NZ-pref.po | 110 +- misc/translator/po/en-NZ-staff-prog.po | 320 +- misc/translator/po/eo-marc-MARC21.po | 19 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 619 ++-- misc/translator/po/eo-pref.po | 106 +- misc/translator/po/eo-staff-prog.po | 318 +- misc/translator/po/es-ES-marc-MARC21.po | 29 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 629 ++-- misc/translator/po/es-ES-pref.po | 144 +- misc/translator/po/es-ES-staff-prog.po | 397 ++- misc/translator/po/eu-marc-MARC21.po | 19 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 609 ++-- misc/translator/po/eu-pref.po | 110 +- misc/translator/po/eu-staff-prog.po | 321 +- misc/translator/po/fa-Arab-marc-MARC21.po | 31 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 10 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 607 ++-- misc/translator/po/fa-Arab-pref.po | 119 +- misc/translator/po/fa-Arab-staff-prog.po | 377 +- misc/translator/po/fi-FI-marc-MARC21.po | 19 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 610 ++-- misc/translator/po/fi-FI-pref.po | 110 +- misc/translator/po/fi-FI-staff-prog.po | 321 +- misc/translator/po/fo-FO-marc-MARC21.po | 19 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 600 ++-- misc/translator/po/fo-FO-pref.po | 106 +- misc/translator/po/fo-FO-staff-prog.po | 318 +- misc/translator/po/fr-CA-marc-MARC21.po | 19 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 609 ++-- misc/translator/po/fr-CA-pref.po | 114 +- misc/translator/po/fr-CA-staff-prog.po | 323 +- misc/translator/po/fr-FR-marc-MARC21.po | 19 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 609 ++-- misc/translator/po/fr-FR-pref.po | 114 +- misc/translator/po/fr-FR-staff-prog.po | 359 +- misc/translator/po/ga-marc-MARC21.po | 19 +- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 2 +- misc/translator/po/ga-opac-bootstrap.po | 600 ++-- misc/translator/po/ga-pref.po | 106 +- misc/translator/po/ga-staff-prog.po | 318 +- misc/translator/po/gd-marc-MARC21.po | 19 +- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 2 +- misc/translator/po/gd-opac-bootstrap.po | 600 ++-- misc/translator/po/gd-pref.po | 106 +- misc/translator/po/gd-staff-prog.po | 318 +- misc/translator/po/gl-marc-MARC21.po | 19 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 605 ++-- misc/translator/po/gl-pref.po | 106 +- misc/translator/po/gl-staff-prog.po | 318 +- misc/translator/po/he-Hebr-marc-MARC21.po | 19 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 605 ++-- misc/translator/po/he-Hebr-pref.po | 106 +- misc/translator/po/he-Hebr-staff-prog.po | 318 +- misc/translator/po/hi-marc-MARC21.po | 23 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 614 ++-- misc/translator/po/hi-pref.po | 132 +- misc/translator/po/hi-staff-prog.po | 325 +- misc/translator/po/hr-HR-marc-MARC21.po | 19 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 609 ++-- misc/translator/po/hr-HR-pref.po | 106 +- misc/translator/po/hr-HR-staff-prog.po | 318 +- misc/translator/po/hu-HU-marc-MARC21.po | 1521 ++++---- misc/translator/po/hu-HU-marc-NORMARC.po | 36 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 370 +- misc/translator/po/hu-HU-opac-bootstrap.po | 730 ++-- misc/translator/po/hu-HU-pref.po | 106 +- misc/translator/po/hu-HU-staff-prog.po | 416 +-- misc/translator/po/hy-Armn-marc-MARC21.po | 23 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 6 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 6 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 613 ++-- misc/translator/po/hy-Armn-pref.po | 114 +- misc/translator/po/hy-Armn-staff-prog.po | 326 +- misc/translator/po/hyw-Armn-marc-MARC21.po | 4 - misc/translator/po/hyw-Armn-marc-NORMARC.po | 4 - misc/translator/po/hyw-Armn-marc-UNIMARC.po | 4 - misc/translator/po/hyw-Armn-opac-bootstrap.po | 4 - misc/translator/po/hyw-Armn-staff-prog.po | 4 - misc/translator/po/ia-marc-MARC21.po | 19 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 600 ++-- misc/translator/po/ia-pref.po | 106 +- misc/translator/po/ia-staff-prog.po | 318 +- misc/translator/po/id-ID-marc-MARC21.po | 19 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 607 ++-- misc/translator/po/id-ID-pref.po | 106 +- misc/translator/po/id-ID-staff-prog.po | 318 +- misc/translator/po/iq-CA-marc-MARC21.po | 19 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 600 ++-- misc/translator/po/iq-CA-pref.po | 106 +- misc/translator/po/iq-CA-staff-prog.po | 318 +- misc/translator/po/is-IS-marc-MARC21.po | 19 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 605 ++-- misc/translator/po/is-IS-pref.po | 106 +- misc/translator/po/is-IS-staff-prog.po | 318 +- misc/translator/po/it-IT-marc-MARC21.po | 19 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 609 ++-- misc/translator/po/it-IT-pref.po | 112 +- misc/translator/po/it-IT-staff-prog.po | 321 +- misc/translator/po/iu-CA-marc-MARC21.po | 19 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 600 ++-- misc/translator/po/iu-CA-pref.po | 106 +- misc/translator/po/iu-CA-staff-prog.po | 318 +- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 19 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 609 ++-- misc/translator/po/ja-Jpan-JP-pref.po | 106 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 318 +- misc/translator/po/ka-marc-MARC21.po | 19 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 604 ++-- misc/translator/po/ka-pref.po | 106 +- misc/translator/po/ka-staff-prog.po | 318 +- misc/translator/po/km-KH-marc-MARC21.po | 19 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 604 ++-- misc/translator/po/km-KH-pref.po | 106 +- misc/translator/po/km-KH-staff-prog.po | 318 +- misc/translator/po/kn-Knda-marc-MARC21.po | 23 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 6 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 6 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 609 ++-- misc/translator/po/kn-Knda-pref.po | 106 +- misc/translator/po/kn-Knda-staff-prog.po | 322 +- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 23 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 6 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 6 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 611 ++-- misc/translator/po/ko-Kore-KP-pref.po | 108 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 324 +- misc/translator/po/ku-Arab-marc-MARC21.po | 19 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 607 ++-- misc/translator/po/ku-Arab-pref.po | 106 +- misc/translator/po/ku-Arab-staff-prog.po | 320 +- misc/translator/po/lo-Laoo-marc-MARC21.po | 19 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 605 ++-- misc/translator/po/lo-Laoo-pref.po | 106 +- misc/translator/po/lo-Laoo-staff-prog.po | 318 +- misc/translator/po/lv-marc-MARC21.po | 19 +- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 2 +- misc/translator/po/lv-opac-bootstrap.po | 605 ++-- misc/translator/po/lv-pref.po | 106 +- misc/translator/po/lv-staff-prog.po | 318 +- misc/translator/po/mi-NZ-marc-MARC21.po | 19 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 609 ++-- misc/translator/po/mi-NZ-pref.po | 106 +- misc/translator/po/mi-NZ-staff-prog.po | 318 +- misc/translator/po/ml-marc-MARC21.po | 19 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 600 ++-- misc/translator/po/ml-pref.po | 106 +- misc/translator/po/ml-staff-prog.po | 318 +- misc/translator/po/mon-marc-MARC21.po | 19 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 605 ++-- misc/translator/po/mon-pref.po | 106 +- misc/translator/po/mon-staff-prog.po | 318 +- misc/translator/po/mr-marc-MARC21.po | 23 +- misc/translator/po/mr-marc-NORMARC.po | 6 +- misc/translator/po/mr-marc-UNIMARC.po | 6 +- misc/translator/po/mr-opac-bootstrap.po | 609 ++-- misc/translator/po/mr-pref.po | 106 +- misc/translator/po/mr-staff-prog.po | 322 +- misc/translator/po/ms-MY-marc-MARC21.po | 19 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 607 ++-- misc/translator/po/ms-MY-pref.po | 108 +- misc/translator/po/ms-MY-staff-prog.po | 318 +- misc/translator/po/my-marc-MARC21.po | 19 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 601 ++-- misc/translator/po/my-pref.po | 106 +- misc/translator/po/my-staff-prog.po | 318 +- misc/translator/po/nb-NO-marc-MARC21.po | 19 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 609 ++-- misc/translator/po/nb-NO-pref.po | 112 +- misc/translator/po/nb-NO-staff-prog.po | 321 +- misc/translator/po/ne-NE-marc-MARC21.po | 19 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 605 ++-- misc/translator/po/ne-NE-pref.po | 106 +- misc/translator/po/ne-NE-staff-prog.po | 318 +- misc/translator/po/nl-BE-marc-MARC21.po | 23 +- misc/translator/po/nl-BE-marc-NORMARC.po | 6 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 6 +- misc/translator/po/nl-BE-opac-bootstrap.po | 613 ++-- misc/translator/po/nl-BE-pref.po | 108 +- misc/translator/po/nl-BE-staff-prog.po | 342 +- misc/translator/po/nl-NL-marc-MARC21.po | 41 +- misc/translator/po/nl-NL-marc-NORMARC.po | 10 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 15 +- misc/translator/po/nl-NL-messages-js.po | 24 +- misc/translator/po/nl-NL-opac-bootstrap.po | 663 ++-- misc/translator/po/nl-NL-pref.po | 554 +-- misc/translator/po/nl-NL-staff-prog.po | 4323 ++++++++++++----------- misc/translator/po/nn-NO-marc-MARC21.po | 19 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 605 ++-- misc/translator/po/nn-NO-pref.po | 106 +- misc/translator/po/nn-NO-staff-prog.po | 318 +- misc/translator/po/oc-marc-MARC21.po | 19 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 609 ++-- misc/translator/po/oc-pref.po | 108 +- misc/translator/po/oc-staff-prog.po | 320 +- misc/translator/po/pbr-marc-MARC21.po | 19 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 605 ++-- misc/translator/po/pbr-pref.po | 106 +- misc/translator/po/pbr-staff-prog.po | 318 +- misc/translator/po/pl-PL-marc-MARC21.po | 19 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-messages.po | 8 +- misc/translator/po/pl-PL-opac-bootstrap.po | 609 ++-- misc/translator/po/pl-PL-pref.po | 110 +- misc/translator/po/pl-PL-staff-prog.po | 320 +- misc/translator/po/prs-marc-MARC21.po | 19 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 605 ++-- misc/translator/po/prs-pref.po | 108 +- misc/translator/po/prs-staff-prog.po | 318 +- misc/translator/po/pt-BR-marc-MARC21.po | 19 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 625 ++-- misc/translator/po/pt-BR-pref.po | 170 +- misc/translator/po/pt-BR-staff-prog.po | 403 +-- misc/translator/po/pt-PT-marc-MARC21.po | 23 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 629 ++-- misc/translator/po/pt-PT-pref.po | 126 +- misc/translator/po/pt-PT-staff-prog.po | 361 +- misc/translator/po/ro-RO-marc-MARC21.po | 19 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 605 ++-- misc/translator/po/ro-RO-pref.po | 106 +- misc/translator/po/ro-RO-staff-prog.po | 318 +- misc/translator/po/ru-RU-marc-MARC21.po | 19 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 608 ++-- misc/translator/po/ru-RU-pref.po | 106 +- misc/translator/po/ru-RU-staff-prog.po | 318 +- misc/translator/po/rw-RW-marc-MARC21.po | 19 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 600 ++-- misc/translator/po/rw-RW-pref.po | 106 +- misc/translator/po/rw-RW-staff-prog.po | 318 +- misc/translator/po/sd-PK-marc-MARC21.po | 19 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 605 ++-- misc/translator/po/sd-PK-pref.po | 106 +- misc/translator/po/sd-PK-staff-prog.po | 318 +- misc/translator/po/sk-SK-marc-MARC21.po | 19 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 609 ++-- misc/translator/po/sk-SK-pref.po | 114 +- misc/translator/po/sk-SK-staff-prog.po | 334 +- misc/translator/po/sl-SI-marc-MARC21.po | 19 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 600 ++-- misc/translator/po/sl-SI-pref.po | 108 +- misc/translator/po/sl-SI-staff-prog.po | 318 +- misc/translator/po/sq-AL-marc-MARC21.po | 19 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 609 ++-- misc/translator/po/sq-AL-pref.po | 106 +- misc/translator/po/sq-AL-staff-prog.po | 318 +- misc/translator/po/sr-Cyrl-marc-MARC21.po | 19 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 603 ++-- misc/translator/po/sr-Cyrl-pref.po | 106 +- misc/translator/po/sr-Cyrl-staff-prog.po | 318 +- misc/translator/po/sv-SE-marc-MARC21.po | 19 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 609 ++-- misc/translator/po/sv-SE-pref.po | 110 +- misc/translator/po/sv-SE-staff-prog.po | 322 +- misc/translator/po/sw-KE-marc-MARC21.po | 19 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 600 ++-- misc/translator/po/sw-KE-pref.po | 106 +- misc/translator/po/sw-KE-staff-prog.po | 318 +- misc/translator/po/ta-LK-marc-MARC21.po | 19 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 604 ++-- misc/translator/po/ta-LK-pref.po | 106 +- misc/translator/po/ta-LK-staff-prog.po | 318 +- misc/translator/po/ta-marc-MARC21.po | 19 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 604 ++-- misc/translator/po/ta-pref.po | 106 +- misc/translator/po/ta-staff-prog.po | 318 +- misc/translator/po/te-marc-MARC21.po | 19 +- misc/translator/po/te-marc-NORMARC.po | 2 +- misc/translator/po/te-marc-UNIMARC.po | 2 +- misc/translator/po/te-opac-bootstrap.po | 609 ++-- misc/translator/po/te-pref.po | 120 +- misc/translator/po/te-staff-prog.po | 322 +- misc/translator/po/tet-marc-MARC21.po | 19 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 609 ++-- misc/translator/po/tet-pref.po | 106 +- misc/translator/po/tet-staff-prog.po | 320 +- misc/translator/po/th-TH-marc-MARC21.po | 23 +- misc/translator/po/th-TH-marc-NORMARC.po | 6 +- misc/translator/po/th-TH-marc-UNIMARC.po | 6 +- misc/translator/po/th-TH-opac-bootstrap.po | 609 ++-- misc/translator/po/th-TH-pref.po | 106 +- misc/translator/po/th-TH-staff-prog.po | 322 +- misc/translator/po/tl-PH-marc-MARC21.po | 19 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 605 ++-- misc/translator/po/tl-PH-pref.po | 108 +- misc/translator/po/tl-PH-staff-prog.po | 318 +- misc/translator/po/tr-TR-marc-MARC21.po | 41 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 10 +- misc/translator/po/tr-TR-messages-js.po | 22 +- misc/translator/po/tr-TR-messages.po | 6 +- misc/translator/po/tr-TR-opac-bootstrap.po | 672 ++-- misc/translator/po/tr-TR-pref.po | 144 +- misc/translator/po/tr-TR-staff-prog.po | 530 +-- misc/translator/po/tvl-marc-MARC21.po | 19 +- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 2 +- misc/translator/po/tvl-opac-bootstrap.po | 600 ++-- misc/translator/po/tvl-pref.po | 106 +- misc/translator/po/tvl-staff-prog.po | 318 +- misc/translator/po/uk-UA-marc-MARC21.po | 29 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 8 +- misc/translator/po/uk-UA-opac-bootstrap.po | 710 ++-- misc/translator/po/uk-UA-pref.po | 138 +- misc/translator/po/uk-UA-staff-prog.po | 507 +-- misc/translator/po/ur-Arab-marc-MARC21.po | 19 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 605 ++-- misc/translator/po/ur-Arab-pref.po | 106 +- misc/translator/po/ur-Arab-staff-prog.po | 318 +- misc/translator/po/vi-VN-marc-MARC21.po | 19 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 609 ++-- misc/translator/po/vi-VN-pref.po | 108 +- misc/translator/po/vi-VN-staff-prog.po | 727 ++-- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 19 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 621 ++-- misc/translator/po/zh-Hans-CN-pref.po | 108 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 318 +- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 19 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 614 ++-- misc/translator/po/zh-Hant-TW-pref.po | 114 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 336 +- 534 files changed, 57502 insertions(+), 49123 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 02:33:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 00:33:15 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.07-45-g8a66977e1e Message-ID: <E1jy2h9-0007C1-2b@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8a66977e1ebe53fdbcc21abeb578f425c4e7bbd8 (commit) via ffa92350a098dbde373430eaae1bf3b6fc3f423e (commit) from 54c6ae736ddd1843c6bf71563e7b6af33a152ee6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8a66977e1ebe53fdbcc21abeb578f425c4e7bbd8 Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jun 24 12:20:03 2020 +0000 Bug 25864: Lower case fields for searching To recreate: 1 - Have Koha using ES5 and Elasticsearch as search engine 2 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate 3 - Do a search in authorities using 'Search entire record' (abduction if using sample db) 4 - Note no results 5 - View the page source and find 'search_query' 6 - Note the uppercased fields 7 - curl 'es:9200/koha_kohadev_authorities/data/417?pretty' 8 - Note all fields lower-cased 9 - Apply patch 10 - Repeat search 11 - It works! Signed-off-by: Heather Hernandez <heather_hernandez at nps.gov> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 2ab6018b6e14ae2153093db148f04f71405f4493) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit ecdefe969e76c0819e8386f8af539f79528a44b3) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> commit ffa92350a098dbde373430eaae1bf3b6fc3f423e Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jun 24 12:22:48 2020 +0000 Bug 25864: Unit test adjustment Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 579a3c11edf77d36488f352d88ae373cc4cbfa21) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit b2504f1a2fb9b9d44f743ad981794d3365c89951) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +- t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 11:00:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 09:00:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-350-g005219ea6f Message-ID: <E1jyAbi-0002su-2b@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 005219ea6fc53a52a41169e96024244abb394ee1 (commit) via 015ed932114ff48e944739afa9123d2501d65e14 (commit) via 9b526483c65550c0f36eabad70055bed79a8197c (commit) via b31fdc8f55007217f95980692114a5b0a9a85bc0 (commit) via dc2c19bd515a4ce4057b41b2ae2bb668d345c461 (commit) via 997094cc38a46372777f39f0bfa249b87fe76d58 (commit) via 16413beea6a2f5667a3a68971158ad1d7ea4b48a (commit) via e9927e729066be42a039b7e3f1abb5143820d1cb (commit) from 14932ae7d3bf864f64bffc9b1b015a07e11c8e2e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 005219ea6fc53a52a41169e96024244abb394ee1 Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jul 8 14:24:37 2020 +0000 Bug 25955: Fix getting index_name To test: 1 - Have a site running ES 2 - perl misc/maintenance/compare_es_to_db.pl 3 - Lots of output, all bad 4 - Apply patch 5 - Repeate 6 - Whew, looks correct Signed-off-by: Didier Gautheron <didier.gautheron at biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 015ed932114ff48e944739afa9123d2501d65e14 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Mon Jul 20 09:50:58 2020 -0300 Bug 25845: (QA follow-up) Call it REST API instead of just API Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9b526483c65550c0f36eabad70055bed79a8197c Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Tue Jun 23 11:06:55 2020 -0300 Bug 25845: Add 'api' to the log viewer interface options This patch simply adds the API option to the log viewer. To test: 1. Have BorrowersLog set 2. Update some patron using the API. For example curl --location --request PUT 'http://koha:koha at kohadev-intra.mydnsname.org:8081/api/v1/patrons/1' \ --header 'Content-Type: application/json' \ --data-raw '{ "firstname": "Tomasito", "surname": "None", "address": "Address", "category_id": "ST", "city": "Córdoba", "library_id": "MPL" }' 3. Open the log viewer => FAIL: There's no way to filter on interface, choosing API 4. Apply this patch 5. Reload the log viewer => SUCCESS: There are options to filter by 'API' interface => SUCCESS: Filtering by 'API' works 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit b31fdc8f55007217f95980692114a5b0a9a85bc0 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Wed Jul 1 06:53:18 2020 -0400 Bug 25907: When cancelling a waiting hold on returns.pl, looks for new hold to fill without rescanning barcode Right now, after canceling a hold on the checkin screen, a librarian needs to rescan the item barcode to check and trap the next hold. This is an extra unnecessary step. Test Plan: 1) Place two or more holds on a record 2) Check in the item 3) Confirm the hold 4) Check in the item again 5) Cancel the hold 6) Koha should now display the modal asking to confirm the next hold without the need to rescan the barcode! Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit dc2c19bd515a4ce4057b41b2ae2bb668d345c461 Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Sat May 30 00:46:46 2020 +0000 Bug 25629: Fix capitalization in sample notices This fixes the capitalization in sample notices files to follow coding-guidelines. Only applies to English, translations remain unchanged. Additional fixes: - Overdues slip added the letter code as subject instead of the description - Opac changed to OPAC for self-registration verification emails German (de-DE) file was not changed, as there is a pending translation bug that will take care of these (bug 25129). To test: - Verify changes by running the web installer for the changed files and verify sample notices install without error - Verify subjects and notice descriptions are correct - Run tests in t/db_dependent/Letters* Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 997094cc38a46372777f39f0bfa249b87fe76d58 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jul 17 07:44:45 2020 +0100 Bug 25998: (QA follow-up) Add DBIC level relation Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 16413beea6a2f5667a3a68971158ad1d7ea4b48a Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jul 16 09:40:23 2020 +0100 Bug 25998: Add 'library' relation to Koha::Account::Line Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e9927e729066be42a039b7e3f1abb5143820d1cb Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jul 17 08:01:06 2020 +0100 Bug 25998: Add Unit Tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: Koha/Account/Line.pm | 13 ++++ Koha/Schema/Result/Accountline.pm | 20 ++++++ .../data/mysql/en/mandatory/sample_notices.yml | 80 +++++++++++----------- .../mysql/fr-CA/obligatoire/sample_notices.sql | 4 +- .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 4 +- installer/data/mysql/it-IT/necessari/notices.sql | 2 +- .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 7 +- .../data/mysql/pl-PL/mandatory/sample_notices.sql | 44 ++++++------ .../data/mysql/ru-RU/mandatory/sample_notices.sql | 46 ++++++------- .../data/mysql/uk-UA/mandatory/sample_notices.sql | 2 +- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 1 + .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 3 +- misc/maintenance/compare_es_to_db.pl | 6 +- t/db_dependent/Koha/Account/Line.t | 44 +++++++++++- t/db_dependent/Letters/TemplateToolkit.t | 4 +- 15 files changed, 178 insertions(+), 102 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 19:45:19 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 17:45:19 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-81-gad985def45 Message-ID: <E1jyInv-0000Gt-GG@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ad985def456ec0312d76baa95bd04351940b58fb (commit) from ecdefe969e76c0819e8386f8af539f79528a44b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ad985def456ec0312d76baa95bd04351940b58fb Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jun 15 16:11:49 2020 +0200 Bug 25752: Stay in cwd after koha-shell After bug 25538, after a koha-shell we are not longer in the current directory: root at cec7bffd8100:koha(master)$ pwd /kohadevbox/koha root at cec7bffd8100:koha(master)$ sudo koha-shell kohadev kohadev-koha at cec7bffd8100:~$ pwd /var/lib/koha/kohadev Test plan: Repeat the commands above and confirm that with this version of the script you get /kohadevbox/koha inside the koha-shell Search for possible regressions Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 7555ecaafa3bd8bbf0514f3c2672cb41ff7e0aa7) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-shell | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 20:03:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 18:03:25 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-14-g8d8417a00d Message-ID: <E1jyJ5R-0000s2-DS@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8d8417a00da6f3646a1a60e8c93d5bbece099f00 (commit) from 9b6e78fd249a561cef762193b6cf8cccb12da558 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d8417a00da6f3646a1a60e8c93d5bbece099f00 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Tue Jun 16 08:00:45 2020 -0400 Bug 25769: Patron self modification triggers change request for date of birth to null If PatronSelfModificationBorrowerUnwantedField contains dateofbirth, all patron self modification requests will attempt to set dateofbirth to null instead of ignoring the field. Test Plan: 1) Add dateofbirth to PatronSelfModificationBorrowerUnwantedField 2) Run a patron self modification 3) Note the request sets dateofbirth to null on the staff side 4) Apply this patch 5) Restart all the things! 6) Run another self-modification 7) Note of the staff side that dateofbirth is unaffected Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 73c421a5164a3af4b2b8e1001b49f29213a94e3a) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 41ad2ba4db8d70f5010f530883ded02c0641329d) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit c21ae5e5177ec9180f07fd5639b7e9912aadfdc1) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: opac/opac-memberentry.pl | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 21:12:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 19:12:26 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-82-gd49844d0e1 Message-ID: <E1jyKAE-0002l0-7l@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via d49844d0e1b3ad54c3a7706232437c1a22871fd8 (commit) from ad985def456ec0312d76baa95bd04351940b58fb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d49844d0e1b3ad54c3a7706232437c1a22871fd8 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Thu Jul 2 08:32:51 2020 -0400 Bug 25914: Fix incorrect variable name causing relative's checkouts column to be empty in OPAC In the OPAC, the title column in the relatives checkouts table is always empty. Test Plan: 1) Enable viewing of relative's checkouts in OPAC 2) Check some items out to a patron 3) Log into the OPAC as a relative of that patron that should be able to view them 4) Note the title column is empty in the relative's checkouts tab 5) Apply this patch 6) Reload the page 7) Titles should appear in the title column! Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0b69ff1ed7a775b6fdca8513d1ec5a692e30bbe9) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 21:53:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 19:53:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-17-g40ba02f02d Message-ID: <E1jyKoO-0003mG-KZ@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 40ba02f02d88060cd0f9bf9671855c7189e0a179 (commit) via 9fa242b01911238d852e4f82708758a9906b02ee (commit) via 38f8ab82aef344e5a769098338d345804b0fbbdd (commit) from 8d8417a00da6f3646a1a60e8c93d5bbece099f00 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 40ba02f02d88060cd0f9bf9671855c7189e0a179 Author: Victor Grousset/tuxayo <victor at tuxayo.net> Date: Wed Jul 22 21:23:00 2020 +0200 Bug 24986: DBIC Schema files + fix of bug 23081 backport Bug 23081 backported the DBIC changes instead of regenerating the files. Thus the checksum weren't matching because 19.05 also had other changes to the schema so the same changes result in a different checksum. The small changes were manually undone and the DBIC were regenerated. So this commit contains the changes for both patchsets. Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 9fa242b01911238d852e4f82708758a9906b02ee Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Thu Jul 16 16:14:40 2020 +1200 Bug 24986: DBRev 19.05.12.001 Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 7efb135dfb3d16c8046877de1a47cd1a835bf5d9) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 38f8ab82aef344e5a769098338d345804b0fbbdd Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jun 4 12:12:23 2020 +0200 Bug 24986: Modify some borrowers DB fields to (TINY|MEDIUM)TEXT Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 16a5197aa9f96ee8a7fb6c63e15a6c7f9342f773) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit c234daac2afe239625a59940c4aa8ef37453762b) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 36ded4c66cca20c2464e79fc31cd6c6867bbfc3a) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Borrower.pm | 99 +++++++++++----------------------- Koha/Schema/Result/Deletedborrower.pm | 99 +++++++++++----------------------- Koha/Schema/Result/Deleteditem.pm | 11 ++-- Koha/Schema/Result/Item.pm | 11 ++-- installer/data/mysql/kohastructure.sql | 60 ++++++++++----------- installer/data/mysql/updatedatabase.pl | 24 +++++++++ 7 files changed, 127 insertions(+), 179 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 23:29:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 21:29:06 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-84-g7c89a88df4 Message-ID: <E1jyMIU-000641-WD@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7c89a88df46cb60289df5e7372d89f5d333da0e3 (commit) via b05dac86ec3939867ef5e9ec9c11d3d6a4df5921 (commit) from d49844d0e1b3ad54c3a7706232437c1a22871fd8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7c89a88df46cb60289df5e7372d89f5d333da0e3 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Wed Jul 22 20:59:18 2020 +0000 Increment version for 20.05.02 release Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit b05dac86ec3939867ef5e9ec9c11d3d6a4df5921 Author: Koha translators <> Date: Wed Jul 22 17:41:50 2020 -0300 Translation updates for Koha 20.05.02 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 5 + misc/translator/po/am-Ethi-marc-MARC21.po | 27 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 10 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 10 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 549 +-- misc/translator/po/am-Ethi-pref.po | 16 +- misc/translator/po/am-Ethi-staff-prog.po | 737 ++-- misc/translator/po/ar-Arab-marc-MARC21.po | 23 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 6 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 6 +- misc/translator/po/ar-Arab-messages.po | 38 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 547 +-- misc/translator/po/ar-Arab-pref.po | 16 +- misc/translator/po/ar-Arab-staff-prog.po | 740 ++-- misc/translator/po/as-IN-marc-MARC21.po | 23 +- misc/translator/po/as-IN-marc-NORMARC.po | 6 +- misc/translator/po/as-IN-marc-UNIMARC.po | 6 +- misc/translator/po/as-IN-opac-bootstrap.po | 540 +-- misc/translator/po/as-IN-pref.po | 16 +- misc/translator/po/as-IN-staff-prog.po | 733 ++-- misc/translator/po/az-AZ-marc-MARC21.po | 23 +- misc/translator/po/az-AZ-marc-NORMARC.po | 6 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 6 +- misc/translator/po/az-AZ-opac-bootstrap.po | 545 +-- misc/translator/po/az-AZ-pref.po | 16 +- misc/translator/po/az-AZ-staff-prog.po | 735 ++-- misc/translator/po/be-BY-marc-MARC21.po | 23 +- misc/translator/po/be-BY-marc-NORMARC.po | 6 +- misc/translator/po/be-BY-marc-UNIMARC.po | 6 +- misc/translator/po/be-BY-opac-bootstrap.po | 548 +-- misc/translator/po/be-BY-pref.po | 16 +- misc/translator/po/be-BY-staff-prog.po | 737 ++-- misc/translator/po/bg-Cyrl-marc-MARC21.po | 27 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 10 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 10 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 549 +-- misc/translator/po/bg-Cyrl-pref.po | 16 +- misc/translator/po/bg-Cyrl-staff-prog.po | 737 ++-- misc/translator/po/bn-IN-marc-MARC21.po | 27 +- misc/translator/po/bn-IN-marc-NORMARC.po | 10 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 10 +- misc/translator/po/bn-IN-opac-bootstrap.po | 549 +-- misc/translator/po/bn-IN-pref.po | 16 +- misc/translator/po/bn-IN-staff-prog.po | 739 ++-- misc/translator/po/ca-ES-marc-MARC21.po | 23 +- misc/translator/po/ca-ES-marc-NORMARC.po | 6 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 6 +- misc/translator/po/ca-ES-opac-bootstrap.po | 547 +-- misc/translator/po/ca-ES-pref.po | 16 +- misc/translator/po/ca-ES-staff-prog.po | 740 ++-- misc/translator/po/cs-CZ-marc-MARC21.po | 27 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 10 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 10 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 551 +-- misc/translator/po/cs-CZ-pref.po | 16 +- misc/translator/po/cs-CZ-staff-prog.po | 756 ++-- misc/translator/po/cy-GB-installer-MARC21.po | 147 +- misc/translator/po/cy-GB-installer.po | 198 +- misc/translator/po/cy-GB-marc-MARC21.po | 696 +++- misc/translator/po/cy-GB-marc-NORMARC.po | 11 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 39 +- misc/translator/po/cy-GB-opac-bootstrap.po | 1699 ++++++--- misc/translator/po/cy-GB-pref.po | 22 +- misc/translator/po/cy-GB-staff-prog.po | 4309 ++++++++++++++++------- misc/translator/po/da-DK-marc-MARC21.po | 23 +- misc/translator/po/da-DK-marc-NORMARC.po | 6 +- misc/translator/po/da-DK-marc-UNIMARC.po | 6 +- misc/translator/po/da-DK-opac-bootstrap.po | 547 +-- misc/translator/po/da-DK-pref.po | 16 +- misc/translator/po/da-DK-staff-prog.po | 737 ++-- misc/translator/po/de-CH-marc-MARC21.po | 23 +- misc/translator/po/de-CH-marc-NORMARC.po | 6 +- misc/translator/po/de-CH-marc-UNIMARC.po | 6 +- misc/translator/po/de-CH-opac-bootstrap.po | 547 +-- misc/translator/po/de-CH-pref.po | 16 +- misc/translator/po/de-CH-staff-prog.po | 740 ++-- misc/translator/po/de-DE-installer-MARC21.po | 157 +- misc/translator/po/de-DE-installer.po | 681 ++-- misc/translator/po/de-DE-marc-MARC21.po | 23 +- misc/translator/po/de-DE-marc-NORMARC.po | 6 +- misc/translator/po/de-DE-marc-UNIMARC.po | 6 +- misc/translator/po/de-DE-opac-bootstrap.po | 548 +-- misc/translator/po/de-DE-pref.po | 31 +- misc/translator/po/de-DE-staff-prog.po | 755 ++-- misc/translator/po/dz-marc-MARC21.po | 19 +- misc/translator/po/dz-marc-NORMARC.po | 2 +- misc/translator/po/dz-marc-UNIMARC.po | 2 +- misc/translator/po/dz-opac-bootstrap.po | 536 +-- misc/translator/po/dz-pref.po | 12 + misc/translator/po/dz-staff-prog.po | 729 ++-- misc/translator/po/el-GR-marc-MARC21.po | 27 +- misc/translator/po/el-GR-marc-NORMARC.po | 10 +- misc/translator/po/el-GR-marc-UNIMARC.po | 10 +- misc/translator/po/el-GR-opac-bootstrap.po | 562 +-- misc/translator/po/el-GR-pref.po | 16 +- misc/translator/po/el-GR-staff-prog.po | 777 ++-- misc/translator/po/en-GB-marc-MARC21.po | 23 +- misc/translator/po/en-GB-marc-NORMARC.po | 6 +- misc/translator/po/en-GB-marc-UNIMARC.po | 6 +- misc/translator/po/en-GB-opac-bootstrap.po | 545 +-- misc/translator/po/en-GB-pref.po | 16 +- misc/translator/po/en-GB-staff-prog.po | 740 ++-- misc/translator/po/en-NZ-marc-MARC21.po | 23 +- misc/translator/po/en-NZ-marc-NORMARC.po | 6 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 6 +- misc/translator/po/en-NZ-opac-bootstrap.po | 547 +-- misc/translator/po/en-NZ-pref.po | 16 +- misc/translator/po/en-NZ-staff-prog.po | 738 ++-- misc/translator/po/eo-marc-MARC21.po | 23 +- misc/translator/po/eo-marc-NORMARC.po | 6 +- misc/translator/po/eo-marc-UNIMARC.po | 6 +- misc/translator/po/eo-opac-bootstrap.po | 555 +-- misc/translator/po/eo-pref.po | 16 +- misc/translator/po/eo-staff-prog.po | 735 ++-- misc/translator/po/es-ES-marc-MARC21.po | 35 +- misc/translator/po/es-ES-marc-NORMARC.po | 6 +- misc/translator/po/es-ES-marc-UNIMARC.po | 6 +- misc/translator/po/es-ES-opac-bootstrap.po | 558 +-- misc/translator/po/es-ES-pref.po | 52 +- misc/translator/po/es-ES-staff-prog.po | 861 ++--- misc/translator/po/eu-marc-MARC21.po | 23 +- misc/translator/po/eu-marc-NORMARC.po | 6 +- misc/translator/po/eu-marc-UNIMARC.po | 6 +- misc/translator/po/eu-opac-bootstrap.po | 547 +-- misc/translator/po/eu-pref.po | 16 +- misc/translator/po/eu-staff-prog.po | 740 ++-- misc/translator/po/fa-Arab-installer-MARC21.po | 11 +- misc/translator/po/fa-Arab-marc-MARC21.po | 35 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 6 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 14 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 547 +-- misc/translator/po/fa-Arab-pref.po | 27 +- misc/translator/po/fa-Arab-staff-prog.po | 782 ++-- misc/translator/po/fi-FI-marc-MARC21.po | 23 +- misc/translator/po/fi-FI-marc-NORMARC.po | 6 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 6 +- misc/translator/po/fi-FI-opac-bootstrap.po | 548 +-- misc/translator/po/fi-FI-pref.po | 16 +- misc/translator/po/fi-FI-staff-prog.po | 742 ++-- misc/translator/po/fo-FO-marc-MARC21.po | 23 +- misc/translator/po/fo-FO-marc-NORMARC.po | 6 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 6 +- misc/translator/po/fo-FO-opac-bootstrap.po | 540 +-- misc/translator/po/fo-FO-pref.po | 16 +- misc/translator/po/fo-FO-staff-prog.po | 733 ++-- misc/translator/po/fr-CA-installer-MARC21.po | 168 +- misc/translator/po/fr-CA-installer.po | 282 +- misc/translator/po/fr-CA-marc-MARC21.po | 29 +- misc/translator/po/fr-CA-marc-NORMARC.po | 6 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 6 +- misc/translator/po/fr-CA-opac-bootstrap.po | 550 +-- misc/translator/po/fr-CA-pref.po | 53 +- misc/translator/po/fr-CA-staff-prog.po | 991 +++--- misc/translator/po/fr-FR-installer-MARC21.po | 229 +- misc/translator/po/fr-FR-installer.po | 282 +- misc/translator/po/fr-FR-marc-MARC21.po | 23 +- misc/translator/po/fr-FR-marc-NORMARC.po | 6 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 6 +- misc/translator/po/fr-FR-opac-bootstrap.po | 563 +-- misc/translator/po/fr-FR-pref.po | 16 +- misc/translator/po/fr-FR-staff-prog.po | 769 ++-- misc/translator/po/ga-marc-MARC21.po | 23 +- misc/translator/po/ga-marc-NORMARC.po | 6 +- misc/translator/po/ga-marc-UNIMARC.po | 6 +- misc/translator/po/ga-opac-bootstrap.po | 540 +-- misc/translator/po/ga-pref.po | 16 +- misc/translator/po/ga-staff-prog.po | 733 ++-- misc/translator/po/gd-marc-MARC21.po | 19 +- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 2 +- misc/translator/po/gd-opac-bootstrap.po | 536 +-- misc/translator/po/gd-pref.po | 12 + misc/translator/po/gd-staff-prog.po | 729 ++-- misc/translator/po/gl-marc-MARC21.po | 23 +- misc/translator/po/gl-marc-NORMARC.po | 6 +- misc/translator/po/gl-marc-UNIMARC.po | 6 +- misc/translator/po/gl-opac-bootstrap.po | 545 +-- misc/translator/po/gl-pref.po | 16 +- misc/translator/po/gl-staff-prog.po | 733 ++-- misc/translator/po/he-Hebr-marc-MARC21.po | 23 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 6 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 6 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 545 +-- misc/translator/po/he-Hebr-pref.po | 16 +- misc/translator/po/he-Hebr-staff-prog.po | 733 ++-- misc/translator/po/hi-marc-MARC21.po | 27 +- misc/translator/po/hi-marc-NORMARC.po | 6 +- misc/translator/po/hi-marc-UNIMARC.po | 6 +- misc/translator/po/hi-opac-bootstrap.po | 553 +-- misc/translator/po/hi-pref.po | 33 +- misc/translator/po/hi-staff-prog.po | 789 +++-- misc/translator/po/hr-HR-marc-MARC21.po | 23 +- misc/translator/po/hr-HR-marc-NORMARC.po | 6 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 6 +- misc/translator/po/hr-HR-opac-bootstrap.po | 547 +-- misc/translator/po/hr-HR-pref.po | 16 +- misc/translator/po/hr-HR-staff-prog.po | 733 ++-- misc/translator/po/hu-HU-installer-MARC21.po | 20 +- misc/translator/po/hu-HU-installer.po | 45 +- misc/translator/po/hu-HU-marc-MARC21.po | 1531 ++++---- misc/translator/po/hu-HU-marc-NORMARC.po | 38 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 372 +- misc/translator/po/hu-HU-messages.po | 10 +- misc/translator/po/hu-HU-opac-bootstrap.po | 815 ++--- misc/translator/po/hu-HU-pref.po | 16 +- misc/translator/po/hu-HU-staff-prog.po | 840 ++--- misc/translator/po/hy-Armn-installer-MARC21.po | 3 +- misc/translator/po/hy-Armn-marc-MARC21.po | 40 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 11 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 195 +- misc/translator/po/hy-Armn-messages-js.po | 6 +- misc/translator/po/hy-Armn-messages.po | 12 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 710 ++-- misc/translator/po/hy-Armn-pref.po | 301 +- misc/translator/po/hy-Armn-staff-prog.po | 1506 ++++---- misc/translator/po/hyw-Armn-marc-MARC21.po | 9 +- misc/translator/po/hyw-Armn-marc-NORMARC.po | 9 +- misc/translator/po/hyw-Armn-marc-UNIMARC.po | 9 +- misc/translator/po/hyw-Armn-messages.po | 2 +- misc/translator/po/hyw-Armn-opac-bootstrap.po | 9 +- misc/translator/po/hyw-Armn-pref.po | 4 +- misc/translator/po/hyw-Armn-staff-prog.po | 9 +- misc/translator/po/ia-marc-MARC21.po | 23 +- misc/translator/po/ia-marc-NORMARC.po | 6 +- misc/translator/po/ia-marc-UNIMARC.po | 6 +- misc/translator/po/ia-opac-bootstrap.po | 540 +-- misc/translator/po/ia-pref.po | 16 +- misc/translator/po/ia-staff-prog.po | 733 ++-- misc/translator/po/id-ID-marc-MARC21.po | 23 +- misc/translator/po/id-ID-marc-NORMARC.po | 6 +- misc/translator/po/id-ID-marc-UNIMARC.po | 6 +- misc/translator/po/id-ID-opac-bootstrap.po | 547 +-- misc/translator/po/id-ID-pref.po | 16 +- misc/translator/po/id-ID-staff-prog.po | 733 ++-- misc/translator/po/iq-CA-marc-MARC21.po | 23 +- misc/translator/po/iq-CA-marc-NORMARC.po | 6 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 6 +- misc/translator/po/iq-CA-opac-bootstrap.po | 540 +-- misc/translator/po/iq-CA-pref.po | 16 +- misc/translator/po/iq-CA-staff-prog.po | 733 ++-- misc/translator/po/is-IS-marc-MARC21.po | 23 +- misc/translator/po/is-IS-marc-NORMARC.po | 6 +- misc/translator/po/is-IS-marc-UNIMARC.po | 6 +- misc/translator/po/is-IS-opac-bootstrap.po | 545 +-- misc/translator/po/is-IS-pref.po | 16 +- misc/translator/po/is-IS-staff-prog.po | 733 ++-- misc/translator/po/it-IT-installer-MARC21.po | 104 +- misc/translator/po/it-IT-installer.po | 282 +- misc/translator/po/it-IT-marc-MARC21.po | 221 +- misc/translator/po/it-IT-marc-NORMARC.po | 6 +- misc/translator/po/it-IT-marc-UNIMARC.po | 6 +- misc/translator/po/it-IT-opac-bootstrap.po | 547 +-- misc/translator/po/it-IT-pref.po | 16 +- misc/translator/po/it-IT-staff-prog.po | 1104 +++--- misc/translator/po/iu-CA-marc-MARC21.po | 23 +- misc/translator/po/iu-CA-marc-NORMARC.po | 6 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 6 +- misc/translator/po/iu-CA-opac-bootstrap.po | 540 +-- misc/translator/po/iu-CA-pref.po | 16 +- misc/translator/po/iu-CA-staff-prog.po | 733 ++-- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 23 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 6 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 6 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 549 +-- misc/translator/po/ja-Jpan-JP-pref.po | 16 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 733 ++-- misc/translator/po/ka-marc-MARC21.po | 23 +- misc/translator/po/ka-marc-NORMARC.po | 6 +- misc/translator/po/ka-marc-UNIMARC.po | 6 +- misc/translator/po/ka-opac-bootstrap.po | 544 +-- misc/translator/po/ka-pref.po | 16 +- misc/translator/po/ka-staff-prog.po | 733 ++-- misc/translator/po/km-KH-marc-MARC21.po | 23 +- misc/translator/po/km-KH-marc-NORMARC.po | 6 +- misc/translator/po/km-KH-marc-UNIMARC.po | 6 +- misc/translator/po/km-KH-opac-bootstrap.po | 544 +-- misc/translator/po/km-KH-pref.po | 16 +- misc/translator/po/km-KH-staff-prog.po | 733 ++-- misc/translator/po/kn-Knda-installer-MARC21.po | 130 +- misc/translator/po/kn-Knda-marc-MARC21.po | 27 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 10 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 10 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 549 +-- misc/translator/po/kn-Knda-pref.po | 16 +- misc/translator/po/kn-Knda-staff-prog.po | 737 ++-- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 27 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 10 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 10 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 549 +-- misc/translator/po/ko-Kore-KP-pref.po | 16 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 741 ++-- misc/translator/po/ku-Arab-marc-MARC21.po | 23 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 6 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 6 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 547 +-- misc/translator/po/ku-Arab-pref.po | 16 +- misc/translator/po/ku-Arab-staff-prog.po | 738 ++-- misc/translator/po/lo-Laoo-marc-MARC21.po | 23 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 6 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 6 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 545 +-- misc/translator/po/lo-Laoo-pref.po | 16 +- misc/translator/po/lo-Laoo-staff-prog.po | 733 ++-- misc/translator/po/lv-marc-MARC21.po | 19 +- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 2 +- misc/translator/po/lv-opac-bootstrap.po | 541 +-- misc/translator/po/lv-pref.po | 12 + misc/translator/po/lv-staff-prog.po | 729 ++-- misc/translator/po/mi-NZ-marc-MARC21.po | 23 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 6 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 6 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 547 +-- misc/translator/po/mi-NZ-pref.po | 16 +- misc/translator/po/mi-NZ-staff-prog.po | 733 ++-- misc/translator/po/ml-marc-MARC21.po | 23 +- misc/translator/po/ml-marc-NORMARC.po | 6 +- misc/translator/po/ml-marc-UNIMARC.po | 6 +- misc/translator/po/ml-opac-bootstrap.po | 540 +-- misc/translator/po/ml-pref.po | 16 +- misc/translator/po/ml-staff-prog.po | 733 ++-- misc/translator/po/mon-marc-MARC21.po | 23 +- misc/translator/po/mon-marc-NORMARC.po | 6 +- misc/translator/po/mon-marc-UNIMARC.po | 6 +- misc/translator/po/mon-opac-bootstrap.po | 545 +-- misc/translator/po/mon-pref.po | 16 +- misc/translator/po/mon-staff-prog.po | 736 ++-- misc/translator/po/mr-marc-MARC21.po | 27 +- misc/translator/po/mr-marc-NORMARC.po | 10 +- misc/translator/po/mr-marc-UNIMARC.po | 10 +- misc/translator/po/mr-opac-bootstrap.po | 549 +-- misc/translator/po/mr-pref.po | 16 +- misc/translator/po/mr-staff-prog.po | 737 ++-- misc/translator/po/ms-MY-marc-MARC21.po | 23 +- misc/translator/po/ms-MY-marc-NORMARC.po | 6 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 6 +- misc/translator/po/ms-MY-opac-bootstrap.po | 547 +-- misc/translator/po/ms-MY-pref.po | 16 +- misc/translator/po/ms-MY-staff-prog.po | 733 ++-- misc/translator/po/my-marc-MARC21.po | 23 +- misc/translator/po/my-marc-NORMARC.po | 6 +- misc/translator/po/my-marc-UNIMARC.po | 6 +- misc/translator/po/my-opac-bootstrap.po | 541 +-- misc/translator/po/my-pref.po | 16 +- misc/translator/po/my-staff-prog.po | 733 ++-- misc/translator/po/nb-NO-installer-MARC21.po | 229 +- misc/translator/po/nb-NO-installer.po | 282 +- misc/translator/po/nb-NO-marc-MARC21.po | 19 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 543 +-- misc/translator/po/nb-NO-pref.po | 12 + misc/translator/po/nb-NO-staff-prog.po | 737 ++-- misc/translator/po/ne-NE-marc-MARC21.po | 23 +- misc/translator/po/ne-NE-marc-NORMARC.po | 6 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 6 +- misc/translator/po/ne-NE-opac-bootstrap.po | 545 +-- misc/translator/po/ne-NE-pref.po | 16 +- misc/translator/po/ne-NE-staff-prog.po | 733 ++-- misc/translator/po/nl-BE-marc-MARC21.po | 27 +- misc/translator/po/nl-BE-marc-NORMARC.po | 10 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 10 +- misc/translator/po/nl-BE-messages.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 790 +++-- misc/translator/po/nl-BE-pref.po | 16 +- misc/translator/po/nl-BE-staff-prog.po | 777 ++-- misc/translator/po/nl-NL-installer-MARC21.po | 17 +- misc/translator/po/nl-NL-marc-MARC21.po | 23 +- misc/translator/po/nl-NL-marc-NORMARC.po | 6 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 6 +- misc/translator/po/nl-NL-opac-bootstrap.po | 550 +-- misc/translator/po/nl-NL-pref.po | 30 +- misc/translator/po/nl-NL-staff-prog.po | 783 ++-- misc/translator/po/nn-NO-marc-MARC21.po | 23 +- misc/translator/po/nn-NO-marc-NORMARC.po | 6 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 6 +- misc/translator/po/nn-NO-opac-bootstrap.po | 545 +-- misc/translator/po/nn-NO-pref.po | 16 +- misc/translator/po/nn-NO-staff-prog.po | 735 ++-- misc/translator/po/oc-marc-MARC21.po | 23 +- misc/translator/po/oc-marc-NORMARC.po | 6 +- misc/translator/po/oc-marc-UNIMARC.po | 6 +- misc/translator/po/oc-opac-bootstrap.po | 547 +-- misc/translator/po/oc-pref.po | 16 +- misc/translator/po/oc-staff-prog.po | 737 ++-- misc/translator/po/pbr-marc-MARC21.po | 23 +- misc/translator/po/pbr-marc-NORMARC.po | 6 +- misc/translator/po/pbr-marc-UNIMARC.po | 6 +- misc/translator/po/pbr-opac-bootstrap.po | 545 +-- misc/translator/po/pbr-pref.po | 16 +- misc/translator/po/pbr-staff-prog.po | 733 ++-- misc/translator/po/pl-PL-installer-MARC21.po | 91 +- misc/translator/po/pl-PL-installer.po | 282 +- misc/translator/po/pl-PL-marc-MARC21.po | 213 +- misc/translator/po/pl-PL-marc-NORMARC.po | 6 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 6 +- misc/translator/po/pl-PL-messages.po | 18 +- misc/translator/po/pl-PL-opac-bootstrap.po | 566 +-- misc/translator/po/pl-PL-pref.po | 70 +- misc/translator/po/pl-PL-staff-prog.po | 1099 +++--- misc/translator/po/prs-marc-MARC21.po | 23 +- misc/translator/po/prs-marc-NORMARC.po | 6 +- misc/translator/po/prs-marc-UNIMARC.po | 6 +- misc/translator/po/prs-opac-bootstrap.po | 545 +-- misc/translator/po/prs-pref.po | 16 +- misc/translator/po/prs-staff-prog.po | 733 ++-- misc/translator/po/pt-BR-installer.po | 42 +- misc/translator/po/pt-BR-marc-MARC21.po | 29 +- misc/translator/po/pt-BR-marc-NORMARC.po | 6 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 6 +- misc/translator/po/pt-BR-messages.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 564 +-- misc/translator/po/pt-BR-pref.po | 93 +- misc/translator/po/pt-BR-staff-prog.po | 842 ++--- misc/translator/po/pt-PT-marc-MARC21.po | 23 +- misc/translator/po/pt-PT-marc-NORMARC.po | 6 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 6 +- misc/translator/po/pt-PT-opac-bootstrap.po | 569 +-- misc/translator/po/pt-PT-pref.po | 16 +- misc/translator/po/pt-PT-staff-prog.po | 759 ++-- misc/translator/po/ro-RO-marc-MARC21.po | 23 +- misc/translator/po/ro-RO-marc-NORMARC.po | 6 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 6 +- misc/translator/po/ro-RO-opac-bootstrap.po | 545 +-- misc/translator/po/ro-RO-pref.po | 16 +- misc/translator/po/ro-RO-staff-prog.po | 735 ++-- misc/translator/po/ru-RU-installer-MARC21.po | 229 +- misc/translator/po/ru-RU-installer.po | 282 +- misc/translator/po/ru-RU-marc-MARC21.po | 23 +- misc/translator/po/ru-RU-marc-NORMARC.po | 6 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 6 +- misc/translator/po/ru-RU-opac-bootstrap.po | 548 +-- misc/translator/po/ru-RU-pref.po | 16 +- misc/translator/po/ru-RU-staff-prog.po | 738 ++-- misc/translator/po/rw-RW-marc-MARC21.po | 23 +- misc/translator/po/rw-RW-marc-NORMARC.po | 6 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 6 +- misc/translator/po/rw-RW-opac-bootstrap.po | 540 +-- misc/translator/po/rw-RW-pref.po | 16 +- misc/translator/po/rw-RW-staff-prog.po | 733 ++-- misc/translator/po/sd-PK-marc-MARC21.po | 23 +- misc/translator/po/sd-PK-marc-NORMARC.po | 6 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 6 +- misc/translator/po/sd-PK-opac-bootstrap.po | 545 +-- misc/translator/po/sd-PK-pref.po | 16 +- misc/translator/po/sd-PK-staff-prog.po | 733 ++-- misc/translator/po/sk-SK-marc-MARC21.po | 23 +- misc/translator/po/sk-SK-marc-NORMARC.po | 6 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 6 +- misc/translator/po/sk-SK-messages-js.po | 75 +- misc/translator/po/sk-SK-messages.po | 30 +- misc/translator/po/sk-SK-opac-bootstrap.po | 557 +-- misc/translator/po/sk-SK-pref.po | 16 +- misc/translator/po/sk-SK-staff-prog.po | 740 ++-- misc/translator/po/sl-SI-marc-MARC21.po | 23 +- misc/translator/po/sl-SI-marc-NORMARC.po | 6 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 6 +- misc/translator/po/sl-SI-opac-bootstrap.po | 540 +-- misc/translator/po/sl-SI-pref.po | 16 +- misc/translator/po/sl-SI-staff-prog.po | 733 ++-- misc/translator/po/sq-AL-marc-MARC21.po | 23 +- misc/translator/po/sq-AL-marc-NORMARC.po | 6 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 6 +- misc/translator/po/sq-AL-opac-bootstrap.po | 547 +-- misc/translator/po/sq-AL-pref.po | 16 +- misc/translator/po/sq-AL-staff-prog.po | 733 ++-- misc/translator/po/sr-Cyrl-marc-MARC21.po | 23 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 6 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 6 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 543 +-- misc/translator/po/sr-Cyrl-pref.po | 16 +- misc/translator/po/sr-Cyrl-staff-prog.po | 733 ++-- misc/translator/po/sv-SE-marc-MARC21.po | 23 +- misc/translator/po/sv-SE-marc-NORMARC.po | 6 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 6 +- misc/translator/po/sv-SE-opac-bootstrap.po | 547 +-- misc/translator/po/sv-SE-pref.po | 16 +- misc/translator/po/sv-SE-staff-prog.po | 739 ++-- misc/translator/po/sw-KE-marc-MARC21.po | 23 +- misc/translator/po/sw-KE-marc-NORMARC.po | 6 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 6 +- misc/translator/po/sw-KE-opac-bootstrap.po | 540 +-- misc/translator/po/sw-KE-pref.po | 16 +- misc/translator/po/sw-KE-staff-prog.po | 733 ++-- misc/translator/po/ta-LK-marc-MARC21.po | 23 +- misc/translator/po/ta-LK-marc-NORMARC.po | 6 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 6 +- misc/translator/po/ta-LK-opac-bootstrap.po | 544 +-- misc/translator/po/ta-LK-pref.po | 16 +- misc/translator/po/ta-LK-staff-prog.po | 733 ++-- misc/translator/po/ta-marc-MARC21.po | 23 +- misc/translator/po/ta-marc-NORMARC.po | 6 +- misc/translator/po/ta-marc-UNIMARC.po | 6 +- misc/translator/po/ta-opac-bootstrap.po | 544 +-- misc/translator/po/ta-pref.po | 16 +- misc/translator/po/ta-staff-prog.po | 733 ++-- misc/translator/po/te-installer-MARC21.po | 291 +- misc/translator/po/te-marc-MARC21.po | 19 +- misc/translator/po/te-marc-NORMARC.po | 2 +- misc/translator/po/te-marc-UNIMARC.po | 2 +- misc/translator/po/te-messages.po | 2 +- misc/translator/po/te-opac-bootstrap.po | 543 +-- misc/translator/po/te-pref.po | 12 + misc/translator/po/te-staff-prog.po | 995 +++--- misc/translator/po/tet-marc-MARC21.po | 23 +- misc/translator/po/tet-marc-NORMARC.po | 6 +- misc/translator/po/tet-marc-UNIMARC.po | 6 +- misc/translator/po/tet-opac-bootstrap.po | 547 +-- misc/translator/po/tet-pref.po | 16 +- misc/translator/po/tet-staff-prog.po | 739 ++-- misc/translator/po/th-TH-marc-MARC21.po | 27 +- misc/translator/po/th-TH-marc-NORMARC.po | 10 +- misc/translator/po/th-TH-marc-UNIMARC.po | 10 +- misc/translator/po/th-TH-opac-bootstrap.po | 549 +-- misc/translator/po/th-TH-pref.po | 16 +- misc/translator/po/th-TH-staff-prog.po | 737 ++-- misc/translator/po/tl-PH-marc-MARC21.po | 23 +- misc/translator/po/tl-PH-marc-NORMARC.po | 6 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 6 +- misc/translator/po/tl-PH-opac-bootstrap.po | 545 +-- misc/translator/po/tl-PH-pref.po | 16 +- misc/translator/po/tl-PH-staff-prog.po | 733 ++-- misc/translator/po/tr-TR-installer-MARC21.po | 48 +- misc/translator/po/tr-TR-installer.po | 65 +- misc/translator/po/tr-TR-marc-MARC21.po | 23 +- misc/translator/po/tr-TR-marc-NORMARC.po | 6 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 6 +- misc/translator/po/tr-TR-messages-js.po | 14 +- misc/translator/po/tr-TR-opac-bootstrap.po | 631 ++-- misc/translator/po/tr-TR-pref.po | 22 +- misc/translator/po/tr-TR-staff-prog.po | 922 ++--- misc/translator/po/tvl-marc-MARC21.po | 23 +- misc/translator/po/tvl-marc-NORMARC.po | 6 +- misc/translator/po/tvl-marc-UNIMARC.po | 6 +- misc/translator/po/tvl-opac-bootstrap.po | 540 +-- misc/translator/po/tvl-pref.po | 16 +- misc/translator/po/tvl-staff-prog.po | 733 ++-- misc/translator/po/uk-UA-installer-MARC21.po | 229 +- misc/translator/po/uk-UA-installer.po | 282 +- misc/translator/po/uk-UA-marc-MARC21.po | 33 +- misc/translator/po/uk-UA-marc-NORMARC.po | 6 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 10 +- misc/translator/po/uk-UA-opac-bootstrap.po | 597 ++-- misc/translator/po/uk-UA-pref.po | 56 +- misc/translator/po/uk-UA-staff-prog.po | 968 ++--- misc/translator/po/ur-Arab-marc-MARC21.po | 25 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 6 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 6 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 545 +-- misc/translator/po/ur-Arab-pref.po | 16 +- misc/translator/po/ur-Arab-staff-prog.po | 737 ++-- misc/translator/po/vi-VN-marc-MARC21.po | 23 +- misc/translator/po/vi-VN-marc-NORMARC.po | 6 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 6 +- misc/translator/po/vi-VN-opac-bootstrap.po | 547 +-- misc/translator/po/vi-VN-pref.po | 35 +- misc/translator/po/vi-VN-staff-prog.po | 802 +++-- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 23 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 6 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 6 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 599 ++-- misc/translator/po/zh-Hans-CN-pref.po | 16 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 735 ++-- misc/translator/po/zh-Hant-TW-installer.po | 11 +- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 49 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 6 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 14 +- misc/translator/po/zh-Hant-TW-messages-js.po | 77 +- misc/translator/po/zh-Hant-TW-messages.po | 30 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 821 ++--- misc/translator/po/zh-Hant-TW-pref.po | 426 ++- misc/translator/po/zh-Hant-TW-staff-prog.po | 1155 +++--- 573 files changed, 72824 insertions(+), 62470 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 23:35:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 21:35:06 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.01-85-g7b947f695b Message-ID: <E1jyMOI-0006Fb-Se@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7b947f695bcfd9cb89952bcd1027701ef74bc3dc (commit) from 7c89a88df46cb60289df5e7372d89f5d333da0e3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7b947f695bcfd9cb89952bcd1027701ef74bc3dc Author: Lucas Gass <lucas at bywatersolutions.com> Date: Wed Jul 22 21:05:42 2020 +0000 Update release notes for the 20.05.02 release Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: misc/release_notes/release_notes_20_05_02.html | 518 +++++++++++++++++++++++++ misc/release_notes/release_notes_20_05_02.md | 413 ++++++++++++++++++++ 2 files changed, 931 insertions(+) create mode 100644 misc/release_notes/release_notes_20_05_02.html create mode 100644 misc/release_notes/release_notes_20_05_02.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 22 23:36:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 21:36:30 +0000 Subject: [koha-commits] main Koha release repository annotated tag v20.05.02 created. v20.05.02 Message-ID: <E1jyMPe-0006Im-4b@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v20.05.02 has been created at 2be58e52cccdabfff3e6ff92fc2695d4f613ac72 (tag) tagging 7b947f695bcfd9cb89952bcd1027701ef74bc3dc (commit) replaces v20.05.01 tagged by Lucas Gass on Wed Jul 22 15:07:09 2020 -0600 - Log ----------------------------------------------------------------- Koha release 20.05.02 -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEiuLrhIFCDD7BMEVj+cc4/xIeRdoFAl8Yqn0ACgkQ+cc4/xIe RdoeJggAn53gNFTbIgbop3KmRAVdIzNJRuWkGyvb6BwrvYuAhj7kI1NSccD1s4rN u+xSD+ZcGqN93aoAYMUzkftHrK94jFQbLNn8dIRxcqdF79GbQ6jdrl5PPxb6pA0S ImzZmMdYY+8EHm/YHDidq54wwWa95dDnZdh5X7TK5zi23IwZ/kadMjxV/ET21bQd WMKjfdml5sGUE8B0eZAAZKIxaZWScEsbbAAkuEjNsqeYAtlE8vrMVL4zMSY+YrQp 9ZKYxt1fcfnw9O+jXuBwBEEzH+HWd3fAi+OizJRvpmF8eHTgty7DVMQo9Xr1tZhr AT8tI+hS75UhW+Gn7XEhxrBFDGBhhg== =u8bT -----END PGP SIGNATURE----- Andreas Roussos (1): Bug 25756: remove erroneous hyphen Andrew Nugged (6): Bug 25440: Extra duplicated call to CGI->param method removed Bug 25440: Fix for "CGI::param called in list context" in smart-rules.pl Bug 25440: Fix for "uninitialized value in hash" warning in smart-rules.pl Bug 25440: Fix for "uninitialized value in string eq" in smart-rules.pl Bug 25440: Fix for "uninitialized $maxsuspensiondays" in smart-rules.pl Bug 25440: Fixed list of 'show_rule' forming variables in the template David Cook (1): Bug 25509: Remove useless libjs-jquery dependency David Roberts (1): Bug 12093: Add CSS classes to item statuses in detail view Emmi Takkinen (3): Bug 25789: Don't allow past date as holds expiration date Bug 4985: Edit a calendar entry for all branches Bug 4985: Fix Plack scope errors Hayley Mapley (1): Bug 25151: Fixing semantic headings in opac-basket.tt Jonathan Druart (8): Revert "Bug 25828: Update cpanfile for 20.05 release cycle" Bug 25553: Make date columns sortable on the edit items table Bug 25611: Use selected vendor when creating a basket Bug 18911: Add the ability to set the preferred lang for notice at the OPAC Bug 24986: Modify some borrowers DB fields to (TINY|MEDIUM)TEXT Bug 21395: Remove 'variable $DEBUG masks earlier declaration in same scope' warning Bug 25851: (bug 18928 follow-up) Remove holdallowed rule is value is an empty string Bug 25752: Stay in cwd after koha-shell Julian Maurice (7): Bug 25858: Use bitwise OR for setting a bit in borrowers.flag Bug 21395: Make perlcritic happy Bug 21395: Fix QA errors Bug 21395: Fix creation of PO file Bug 21395: Ignore .perlcriticrc in t/Makefile.t Bug 21395: Fix C4/Barcodes/ValueBuilder.pm Bug 21395: Fix misc/admin/koha-preferences Katrin Fischer (3): Bug 12093: (QA follow-up) Fix typo 'noteforloan' Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml Bug 11994: (follow-up) Make things work when LibraryName is empty Koha translators (1): Translation updates for Koha 20.05.02 Kyle M Hall (6): Bug 25769: Patron self modification triggers change request for date of birth to null Bug 25097: Add option to message_queue to allow for only specific sending notices Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name Bug 25232: Add ability to skip trapping items with a given notforloan value Bug 25232: Add ability to specify multiple notforloan values to skip Bug 25914: Fix incorrect variable name causing relative's checkouts column to be empty in OPAC Lucas Gass (9): Bug 25236: Compile CSS Bug 22807: Compile CSS Bug 24986: DBRev 20.05.01.001 Bug 24986: DBIC Bug 25232: DBRev 20.05.01.002 Bug 22672: Change <i> to <em> and <b> to <strong> in templates, includes, xslt Bug 25851: DBRev 20.05.01.003 Increment version for 20.05.02 release Update release notes for the 20.05.02 release Marcel de Rooy (1): Bug 18911: (follow-up) We should save changes with a POST Martin Renvoize (12): Bug 25239: Fix semantic heading for opac-reserve.tt Bug 25238: Fix semantic heading for opac-details Bug 25236: Fix semantic heading for opac-facets.inc Bug 25236: Fix semantic heading for opac-topissues.inc Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Bug 25154: Add heading where content is introduced in opac-results.tt Bug 22807: Add 'Skip to content' option Bug 22807: Ensure only one maincontent on searcresults Bug 22807: Ensure .maincontent appears on all pages Bug 25807: Add Template 3.008 to the exclude list Bug 21395: (QA follow-up) Remove some introduced issues Bug 21395: (QA follow-up) POD fixes Nick Clemens (7): Bug 25189: Unit tests Bug 25189: Don't create authority if results found Bug 25858: (bug 25858 follow-up) Don't attempt to set flag if already set Bug 25875: Move check for module_bit and code to the JOIN Bug 25875: Unit test Bug 25864: Unit test adjustment Bug 25864: Lower case fields for searching Owen Leonard (11): Bug 25447: Terminology: Fix button text "Edit biblio" Bug 25804: Remove HTML from title tag of bibliographic detail page Bug 24352: Correct location and collection labels in OPAC search results Bug 11994: Fix OpenSearch discovery in the OPAC Bug 25747: Don't display a comma when patron has no firstname Bug 25471: Add DataTables to MARC subfield structure admin page Bug 25402: Put OPAC cart download options into dropdown menu Bug 25402: (QA follow-up) Remove unused downloadBasket function Bug 22807: (follow-up) Add .maincontent class to libraries page Bug 22807: (follow-up) Update style of skip button Bug 25793: OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade Petro Vashchuk (2): Bug 25699: Add edition information to "Holds to pull" report Bug 25322: fix for not selected "relationship" defaults to father Slava Shishkin (1): Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm Tomás Cohen Arazi (4): Bug 25570: Regression tests Bug 25570: Paginate results by default in objects->search Bug 25570: (follow-up) Fix tests Bug 25805: Regression tests ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 23 00:38:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 22:38:47 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-19-g6451838993 Message-ID: <E1jyNNv-0007ng-D7@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 645183899384a9fbb9aabecdb0e0d3d1b34a94bf (commit) via 9d4bc60ea5ff07fd7e1f896964b043d38ff869c2 (commit) from 40ba02f02d88060cd0f9bf9671855c7189e0a179 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 645183899384a9fbb9aabecdb0e0d3d1b34a94bf Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Thu Jul 16 16:24:38 2020 +1200 Bug 25858: Use bitwise OR for setting a bit in borrowers.flag Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 4f6b3c4a6173810bba24b89d82eb223226278b9c) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 9d4bc60ea5ff07fd7e1f896964b043d38ff869c2 Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Thu Jul 16 16:23:07 2020 +1200 Bug 25858: Don't attempt to set flag if already set Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 6d6132777bc1dfd35e990ac469799ece679e4899) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 23 00:55:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Jul 2020 22:55:10 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-20-g5335df5a9b Message-ID: <E1jyNdm-0008VD-4N@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5335df5a9b25f4d93c0a94ceb34e7715ee720a33 (commit) from 645183899384a9fbb9aabecdb0e0d3d1b34a94bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5335df5a9b25f4d93c0a94ceb34e7715ee720a33 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Wed May 27 21:35:16 2020 +0000 Bug 22672: Change <i> to <em> and <b> to <strong> in templates, includes, xslt This patch attempts to replace <i> with <em> AND <b> with <strong> in order to more accessible to screen readers. This patch makes no attempt to change Font Awesome icons which typically use <i>. I found templates, includes and XSLT by using 'git grep ‘<b>’ koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘<i>’ koha-tmpl/opac-tmpl/bootstrap/en/ TEST PLAN: There should be no visible difference on the changed pages. The files changed are: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/xslt/OAI.xslt Read the changes and make sure everything looks correct, try to visit as many pages as possible and confirm that everything looks as it should. grep around for cases of <b> or <i> that I could have missed. Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d3036d46ba4b26df040a25f960c3bc3081734c26) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 25d820f3226c6116d064591abc67e2463a571f50) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit eb9650bb1aa01abb8cf6721f35b077f8421313aa) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/includes/holds-table.inc | 12 ++++++------ koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt | 2 +- .../bootstrap/en/modules/opac-auth-MARCdetail.tt | 4 ++-- .../en/modules/opac-authoritiessearchresultlist.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt | 2 +- .../bootstrap/en/modules/opac-course-details.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt | 4 ++-- .../opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 4 ++-- .../opac-tmpl/bootstrap/en/modules/opac-opensearch.tt | 2 +- .../bootstrap/en/modules/opac-overdrive-search.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 2 +- .../bootstrap/en/modules/opac-results-grouped.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 5 +++-- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 8 ++++---- .../bootstrap/en/xslt/NORMARCslim2OPACResults.xsl | 4 ++-- .../bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl | 4 ++-- koha-tmpl/opac-tmpl/xslt/OAI.xslt | 16 ++++++++-------- 23 files changed, 48 insertions(+), 47 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 23 03:46:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Jul 2020 01:46:22 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-23-gc5fcdbd223 Message-ID: <E1jyQJS-00072v-1k@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via c5fcdbd223473c0832575f6ecb2cb53ce6ea4875 (commit) via 2d5fe7192ee1b10917b6100a07a2cc580d59f7b2 (commit) via b9f20538bd2e6e1e66e2f6cf44e2e6441f05470b (commit) from 5335df5a9b25f4d93c0a94ceb34e7715ee720a33 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c5fcdbd223473c0832575f6ecb2cb53ce6ea4875 Author: Victor Grousset/tuxayo <victor at tuxayo.net> Date: Mon Jun 22 15:10:35 2020 +0200 Increment version for 19.05.13 release Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 2d5fe7192ee1b10917b6100a07a2cc580d59f7b2 Author: Victor Grousset/tuxayo <victor at tuxayo.net> Date: Thu Jul 23 03:06:08 2020 +0200 Fix translations for Koha 19.05.13 Marked as fuzzy the errors found by junitmsgfmt Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit b9f20538bd2e6e1e66e2f6cf44e2e6441f05470b Author: Koha translators <> Date: Wed Jul 22 20:36:18 2020 -0300 Translation updates for Koha 19.05.13 Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 63 +- misc/translator/po/am-Ethi-pref.po | 88 +- misc/translator/po/am-Ethi-staff-prog.po | 64 +- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 65 +- misc/translator/po/ar-Arab-pref.po | 94 +- misc/translator/po/ar-Arab-staff-prog.po | 66 +- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 63 +- misc/translator/po/as-IN-pref.po | 88 +- misc/translator/po/as-IN-staff-prog.po | 64 +- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 63 +- misc/translator/po/az-AZ-pref.po | 88 +- misc/translator/po/az-AZ-staff-prog.po | 64 +- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 63 +- misc/translator/po/be-BY-pref.po | 88 +- misc/translator/po/be-BY-staff-prog.po | 64 +- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 63 +- misc/translator/po/bg-Cyrl-pref.po | 88 +- misc/translator/po/bg-Cyrl-staff-prog.po | 64 +- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 63 +- misc/translator/po/bn-IN-pref.po | 88 +- misc/translator/po/bn-IN-staff-prog.po | 64 +- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 65 +- misc/translator/po/ca-ES-pref.po | 88 +- misc/translator/po/ca-ES-staff-prog.po | 64 +- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 65 +- misc/translator/po/cs-CZ-pref.po | 90 +- misc/translator/po/cs-CZ-staff-prog.po | 80 +- misc/translator/po/cy-GB-marc-MARC21.po | 679 ++++- misc/translator/po/cy-GB-marc-NORMARC.po | 11 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 39 +- misc/translator/po/cy-GB-opac-bootstrap.po | 1181 ++++++-- misc/translator/po/cy-GB-pref.po | 96 +- misc/translator/po/cy-GB-staff-prog.po | 3385 +++++++++++++++++------ misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 63 +- misc/translator/po/da-DK-pref.po | 90 +- misc/translator/po/da-DK-staff-prog.po | 64 +- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 65 +- misc/translator/po/de-CH-pref.po | 90 +- misc/translator/po/de-CH-staff-prog.po | 64 +- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 74 +- misc/translator/po/de-DE-pref.po | 113 +- misc/translator/po/de-DE-staff-prog.po | 78 +- misc/translator/po/dz-marc-MARC21.po | 2 +- misc/translator/po/dz-marc-NORMARC.po | 2 +- misc/translator/po/dz-marc-UNIMARC.po | 2 +- misc/translator/po/dz-opac-bootstrap.po | 63 +- misc/translator/po/dz-pref.po | 88 +- misc/translator/po/dz-staff-prog.po | 64 +- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 65 +- misc/translator/po/el-GR-pref.po | 90 +- misc/translator/po/el-GR-staff-prog.po | 64 +- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 63 +- misc/translator/po/en-GB-pref.po | 88 +- misc/translator/po/en-GB-staff-prog.po | 64 +- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 65 +- misc/translator/po/en-NZ-pref.po | 90 +- misc/translator/po/en-NZ-staff-prog.po | 64 +- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 76 +- misc/translator/po/eo-pref.po | 88 +- misc/translator/po/eo-staff-prog.po | 64 +- misc/translator/po/es-ES-marc-MARC21.po | 2 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 10 +- misc/translator/po/es-ES-opac-bootstrap.po | 88 +- misc/translator/po/es-ES-pref.po | 126 +- misc/translator/po/es-ES-staff-prog.po | 121 +- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 65 +- misc/translator/po/eu-pref.po | 90 +- misc/translator/po/eu-staff-prog.po | 64 +- misc/translator/po/fa-Arab-marc-MARC21.po | 14 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 10 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 71 +- misc/translator/po/fa-Arab-pref.po | 127 +- misc/translator/po/fa-Arab-staff-prog.po | 108 +- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 65 +- misc/translator/po/fi-FI-pref.po | 90 +- misc/translator/po/fi-FI-staff-prog.po | 64 +- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 63 +- misc/translator/po/fo-FO-pref.po | 88 +- misc/translator/po/fo-FO-staff-prog.po | 64 +- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 65 +- misc/translator/po/fr-CA-pref.po | 94 +- misc/translator/po/fr-CA-staff-prog.po | 66 +- misc/translator/po/fr-FR-marc-MARC21.po | 2 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 71 +- misc/translator/po/fr-FR-pref.po | 94 +- misc/translator/po/fr-FR-staff-prog.po | 90 +- misc/translator/po/ga-marc-MARC21.po | 2 +- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 2 +- misc/translator/po/ga-opac-bootstrap.po | 63 +- misc/translator/po/ga-pref.po | 88 +- misc/translator/po/ga-staff-prog.po | 64 +- misc/translator/po/gd-marc-MARC21.po | 2 +- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 2 +- misc/translator/po/gd-opac-bootstrap.po | 63 +- misc/translator/po/gd-pref.po | 88 +- misc/translator/po/gd-staff-prog.po | 64 +- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 63 +- misc/translator/po/gl-pref.po | 88 +- misc/translator/po/gl-staff-prog.po | 64 +- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 63 +- misc/translator/po/he-Hebr-pref.po | 88 +- misc/translator/po/he-Hebr-staff-prog.po | 64 +- misc/translator/po/hi-marc-MARC21.po | 10 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 73 +- misc/translator/po/hi-pref.po | 136 +- misc/translator/po/hi-staff-prog.po | 87 +- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 65 +- misc/translator/po/hr-HR-pref.po | 88 +- misc/translator/po/hr-HR-staff-prog.po | 64 +- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 63 +- misc/translator/po/hu-HU-pref.po | 88 +- misc/translator/po/hu-HU-staff-prog.po | 64 +- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 65 +- misc/translator/po/hy-Armn-pref.po | 94 +- misc/translator/po/hy-Armn-staff-prog.po | 66 +- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 63 +- misc/translator/po/ia-pref.po | 88 +- misc/translator/po/ia-staff-prog.po | 64 +- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 63 +- misc/translator/po/id-ID-pref.po | 88 +- misc/translator/po/id-ID-staff-prog.po | 64 +- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 63 +- misc/translator/po/iq-CA-pref.po | 88 +- misc/translator/po/iq-CA-staff-prog.po | 64 +- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 63 +- misc/translator/po/is-IS-pref.po | 88 +- misc/translator/po/is-IS-staff-prog.po | 64 +- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 100 +- misc/translator/po/it-IT-pref.po | 111 +- misc/translator/po/it-IT-staff-prog.po | 64 +- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 63 +- misc/translator/po/iu-CA-pref.po | 88 +- misc/translator/po/iu-CA-staff-prog.po | 64 +- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 63 +- misc/translator/po/ja-Jpan-JP-pref.po | 88 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 64 +- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 65 +- misc/translator/po/ka-pref.po | 88 +- misc/translator/po/ka-staff-prog.po | 64 +- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 63 +- misc/translator/po/km-KH-pref.po | 88 +- misc/translator/po/km-KH-staff-prog.po | 64 +- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 63 +- misc/translator/po/kn-Knda-pref.po | 88 +- misc/translator/po/kn-Knda-staff-prog.po | 64 +- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 65 +- misc/translator/po/ko-Kore-KP-pref.po | 90 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 64 +- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 63 +- misc/translator/po/ku-Arab-pref.po | 88 +- misc/translator/po/ku-Arab-staff-prog.po | 64 +- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 63 +- misc/translator/po/lo-Laoo-pref.po | 88 +- misc/translator/po/lo-Laoo-staff-prog.po | 64 +- misc/translator/po/lv-marc-MARC21.po | 2 +- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 2 +- misc/translator/po/lv-opac-bootstrap.po | 63 +- misc/translator/po/lv-pref.po | 88 +- misc/translator/po/lv-staff-prog.po | 64 +- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 65 +- misc/translator/po/mi-NZ-pref.po | 88 +- misc/translator/po/mi-NZ-staff-prog.po | 64 +- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 63 +- misc/translator/po/ml-pref.po | 88 +- misc/translator/po/ml-staff-prog.po | 64 +- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 63 +- misc/translator/po/mon-pref.po | 88 +- misc/translator/po/mon-staff-prog.po | 64 +- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 63 +- misc/translator/po/mr-pref.po | 88 +- misc/translator/po/mr-staff-prog.po | 64 +- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 63 +- misc/translator/po/ms-MY-pref.po | 90 +- misc/translator/po/ms-MY-staff-prog.po | 64 +- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 63 +- misc/translator/po/my-pref.po | 88 +- misc/translator/po/my-staff-prog.po | 64 +- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 65 +- misc/translator/po/nb-NO-pref.po | 92 +- misc/translator/po/nb-NO-staff-prog.po | 64 +- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 63 +- misc/translator/po/ne-NE-pref.po | 88 +- misc/translator/po/ne-NE-staff-prog.po | 64 +- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 65 +- misc/translator/po/nl-BE-pref.po | 90 +- misc/translator/po/nl-BE-staff-prog.po | 74 +- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 73 +- misc/translator/po/nl-NL-pref.po | 100 +- misc/translator/po/nl-NL-staff-prog.po | 106 +- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 63 +- misc/translator/po/nn-NO-pref.po | 88 +- misc/translator/po/nn-NO-staff-prog.po | 64 +- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 65 +- misc/translator/po/oc-pref.po | 90 +- misc/translator/po/oc-staff-prog.po | 64 +- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 63 +- misc/translator/po/pbr-pref.po | 88 +- misc/translator/po/pbr-staff-prog.po | 64 +- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-messages.po | 12 +- misc/translator/po/pl-PL-opac-bootstrap.po | 65 +- misc/translator/po/pl-PL-pref.po | 90 +- misc/translator/po/pl-PL-staff-prog.po | 64 +- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 63 +- misc/translator/po/prs-pref.po | 90 +- misc/translator/po/prs-staff-prog.po | 64 +- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 65 +- misc/translator/po/pt-BR-pref.po | 94 +- misc/translator/po/pt-BR-staff-prog.po | 92 +- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 10 +- misc/translator/po/pt-PT-opac-bootstrap.po | 84 +- misc/translator/po/pt-PT-pref.po | 108 +- misc/translator/po/pt-PT-staff-prog.po | 94 +- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 63 +- misc/translator/po/ro-RO-pref.po | 88 +- misc/translator/po/ro-RO-staff-prog.po | 64 +- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 63 +- misc/translator/po/ru-RU-pref.po | 88 +- misc/translator/po/ru-RU-staff-prog.po | 64 +- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 63 +- misc/translator/po/rw-RW-pref.po | 88 +- misc/translator/po/rw-RW-staff-prog.po | 64 +- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 63 +- misc/translator/po/sd-PK-pref.po | 88 +- misc/translator/po/sd-PK-staff-prog.po | 64 +- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 65 +- misc/translator/po/sk-SK-pref.po | 94 +- misc/translator/po/sk-SK-staff-prog.po | 64 +- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 63 +- misc/translator/po/sl-SI-pref.po | 90 +- misc/translator/po/sl-SI-staff-prog.po | 64 +- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 65 +- misc/translator/po/sq-AL-pref.po | 88 +- misc/translator/po/sq-AL-staff-prog.po | 64 +- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 63 +- misc/translator/po/sr-Cyrl-pref.po | 88 +- misc/translator/po/sr-Cyrl-staff-prog.po | 64 +- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 65 +- misc/translator/po/sv-SE-pref.po | 90 +- misc/translator/po/sv-SE-staff-prog.po | 66 +- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 63 +- misc/translator/po/sw-KE-pref.po | 88 +- misc/translator/po/sw-KE-staff-prog.po | 64 +- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 63 +- misc/translator/po/ta-LK-pref.po | 88 +- misc/translator/po/ta-LK-staff-prog.po | 64 +- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 63 +- misc/translator/po/ta-pref.po | 88 +- misc/translator/po/ta-staff-prog.po | 64 +- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 65 +- misc/translator/po/tet-pref.po | 88 +- misc/translator/po/tet-staff-prog.po | 64 +- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 63 +- misc/translator/po/th-TH-pref.po | 88 +- misc/translator/po/th-TH-staff-prog.po | 64 +- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 63 +- misc/translator/po/tl-PH-pref.po | 90 +- misc/translator/po/tl-PH-staff-prog.po | 64 +- misc/translator/po/tr-TR-marc-MARC21.po | 8 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 10 +- misc/translator/po/tr-TR-opac-bootstrap.po | 132 +- misc/translator/po/tr-TR-pref.po | 134 +- misc/translator/po/tr-TR-staff-prog.po | 130 +- misc/translator/po/tvl-marc-MARC21.po | 2 +- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 2 +- misc/translator/po/tvl-opac-bootstrap.po | 63 +- misc/translator/po/tvl-pref.po | 88 +- misc/translator/po/tvl-staff-prog.po | 64 +- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 79 +- misc/translator/po/uk-UA-pref.po | 92 +- misc/translator/po/uk-UA-staff-prog.po | 77 +- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 63 +- misc/translator/po/ur-Arab-pref.po | 88 +- misc/translator/po/ur-Arab-staff-prog.po | 64 +- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 65 +- misc/translator/po/vi-VN-pref.po | 90 +- misc/translator/po/vi-VN-staff-prog.po | 64 +- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 65 +- misc/translator/po/zh-Hans-CN-pref.po | 90 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 64 +- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 71 +- misc/translator/po/zh-Hant-TW-pref.po | 94 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 66 +- 519 files changed, 14402 insertions(+), 10854 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 23 05:14:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Jul 2020 03:14:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.12-24-gcba17a6af7 Message-ID: <E1jyRgU-0000ph-KR@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via cba17a6af741c27f90304e6b1d8ee90246e2f572 (commit) from c5fcdbd223473c0832575f6ecb2cb53ce6ea4875 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cba17a6af741c27f90304e6b1d8ee90246e2f572 Author: Victor Grousset/tuxayo <victor at tuxayo.net> Date: Thu Jul 23 04:41:14 2020 +0200 Update release notes for 19.05.13 release Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: misc/release_notes/release_notes_19_05_13.html | 409 +++++++++++++++++++++++++ misc/release_notes/release_notes_19_05_13.md | 333 ++++++++++++++++++++ 2 files changed, 742 insertions(+) create mode 100644 misc/release_notes/release_notes_19_05_13.html create mode 100644 misc/release_notes/release_notes_19_05_13.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 23 07:56:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Jul 2020 05:56:47 +0000 Subject: [koha-commits] main Koha release repository annotated tag v19.05.13 created. v19.05.13 Message-ID: <E1jyUDn-0004yI-Vm@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v19.05.13 has been created at 15616538d17a8654932d8b5ac2da56d91e99828b (tag) tagging cba17a6af741c27f90304e6b1d8ee90246e2f572 (commit) replaces v19.05.12 tagged by Victor Grousset/tuxayo on Thu Jul 23 04:44:22 2020 +0200 - Log ----------------------------------------------------------------- Koha release 19.05.13 -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRT86JTIbcYFBCjtfABQKyjt9hwuwUCXxj5hgAKCRABQKyjt9hw uxCsAP4jGR2rxmWAA8mNoqjVHL2SPFcQomEGhlJPpXVDOpbGhgEArNxt/hqyPgkA mGRvl/xXEnK6ZuSG0MjfIxBJAlJOfQU= =gDDh -----END PGP SIGNATURE----- Aleisha Amohia (3): Bug 24986: DBRev 19.05.12.001 Bug 25858: Don't attempt to set flag if already set Bug 25858: Use bitwise OR for setting a bit in borrowers.flag Andrew Fuerste-Henry (1): Bug 25675: Reword and reorganize sysprefs related to patron self modification Caroline Cyr La Rose (1): Bug 25394: Cronjob path in the AuthorityMergeLimit syspref description is wrong David Cook (1): Bug 25696: Correct "Test prediction pattern" HTML button David Roberts (1): Bug 22470: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl Jonathan Druart (4): Bug 23276: Do not display tag if pref TagsEnabled is off Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull" Bug 25576: Add link to the manual for the ILL module Bug 24986: Modify some borrowers DB fields to (TINY|MEDIUM)TEXT Katrin Fischer (1): Bug 24353: [19.05] Correct display of privacy_guarantor_checkouts on moremember.pl Koha translators (1): Translation updates for Koha 19.05.13 Kyle M Hall (2): Bug 25537: Page reload at branchtransfers.pl loses destination branch Bug 25769: Patron self modification triggers change request for date of birth to null Lucas Gass (1): Bug 22672: Change <i> to <em> and <b> to <strong> in templates, includes, xslt Petro Vashchuk (1): Bug 25587: fix for "clear" button to reset all selects Tomás Cohen Arazi (3): Bug 24862: Regression tests Bug 24862: Handle annonymous sessions gracefuly Bug 25623: Make sure oauth.t rolls back the db Victor Grousset/tuxayo (4): Bug 24986: DBIC Schema files + fix of bug 23081 backport Fix translations for Koha 19.05.13 Increment version for 19.05.13 release Update release notes for 19.05.13 release ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 23 12:17:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Jul 2020 10:17:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-377-g452015c054 Message-ID: <E1jyYID-0001od-MI@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 452015c054a988ad2016dcad896be516dc318743 (commit) via 0edaab49afec96c793477e9e790b4a9d7b6044fe (commit) via bfb89695aa90bcb6d8c26c0a59ee68f92dd54df9 (commit) via 81e83d250c60b9b571c15d59b1867ebdbd8d6a7f (commit) via 1bc9765d043169dfeb569e25659f553f39dc466b (commit) via f8c5b54acfa94f2c5e04f3376223e883deef9937 (commit) via be1d25ba16014c5fb3c788f8a93c5ecf3f5d9dbf (commit) via f0a0f630bb523cfcda6efa82049608474e09fb15 (commit) via 16053574a5bff66d86ebcc906ccbabe31c45d1c7 (commit) via 8f819ac9b97bd6c9872259f2b614543724fefbbf (commit) via c9eb2be381bf9b6848b14bd374ba004f41198ed0 (commit) via bd9ece8c194ffc960b5709b884620bf24e29068b (commit) via 83d63d2302ee77c68dbae8be80fc6a038fa5ce51 (commit) via cbd86551571260ca6daade57920e0fb3f290dfb4 (commit) via 0fcd0fd2707188368fa5b370b808e875c6ea5814 (commit) via 12e83a64ececa12e691d855e2454a30a9b5e0e04 (commit) via c2d45ac0f4687fc4dcf84e9de663f8d3f3a354be (commit) via db15f4af8dc021c0ac06c3447cb87c5e51952cd2 (commit) via 92d0472d631817395ad71f89f962fa5166f15770 (commit) via 478093072000d01b2b5c20f05044e4bd3bbfeecd (commit) via ae3644a5947ea410fc3e8ac8b64307df7d1cbb18 (commit) via 07a7dbbcf427dfcff9aa386832e9f9cf1c4b4828 (commit) via fa1571cc0a0b2def305a500b5bd344b2ff2fcbea (commit) via dfb70ce9f1edf54d9aad3755f1fb840b5ed4b6d3 (commit) via 83d9a6e60289912736b0181d4e9cee090b4d0ffe (commit) via 3b8b542f9e49ab3f7c45aaa7eda33df1607028ef (commit) via e453f74cfd2358ea795f2f0677946fba75ad7841 (commit) from 005219ea6fc53a52a41169e96024244abb394ee1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 452015c054a988ad2016dcad896be516dc318743 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 10:51:32 2020 +0200 Bug 23797: DBIC schema changes Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 0edaab49afec96c793477e9e790b4a9d7b6044fe Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 10:50:27 2020 +0200 Bug 23797: Apply DB changes to kohastructure.sql Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit bfb89695aa90bcb6d8c26c0a59ee68f92dd54df9 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 10:41:23 2020 +0200 Bug 23797: DBRev 20.06.00.015 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 81e83d250c60b9b571c15d59b1867ebdbd8d6a7f Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 10:40:18 2020 +0200 Bug 23797: DBRev 20.06.00.014 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 1bc9765d043169dfeb569e25659f553f39dc466b Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Jul 7 18:36:32 2020 +0000 Bug 23797: (follow-up) Enable OpacLoginInstructions in header The OpacLoginInstructions information should be available in the login modal which is displayed when the login link in the header menu is clicked. Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit f8c5b54acfa94f2c5e04f3376223e883deef9937 Author: Owen Leonard <oleonard at myacpl.org> Date: Mon Jun 29 13:07:42 2020 +0000 Bug 23797: (follow-up) Increase the size of opac_news.lang This patch adds a database update to increase the size of the opac_news.lang column in order to accommodate longer values. Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit be1d25ba16014c5fb3c788f8a93c5ecf3f5d9dbf Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Mar 24 15:06:30 2020 +0000 Bug 23797: Convert OpacLoginInstructions system preference to news block This patch builds on Bug 22318 to move the OpacLoginInstructions system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacLoginInstructions system preference. Apply the patch and run the database update process. - Go to the OPAC and click the login link. - In the login modal, confirm that the content which was previously in the OpacLoginInstructions system preference displays correctly below the login form. - While not logged in to the OPAC, navigate directly to /cgi-bin/koha/opac-user.pl. The OpacLoginInstructions content should display correctly here as well. - In the staff client, go to Tools -> News and verify that the content from OpacLoginInstructions is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacLoginInstructions_en', 'OpacLoginInstructions_fr-FR', 'OpacLoginInstructions_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacLoginInstructions preference has been removed. - To test the correct selection of language-specific content you must run the translation update/install process for the languages you're updating. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit f0a0f630bb523cfcda6efa82049608474e09fb15 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 10:36:54 2020 +0200 Bug 23796: DBRev 20.06.00.013 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 16053574a5bff66d86ebcc906ccbabe31c45d1c7 Author: Owen Leonard <oleonard at myacpl.org> Date: Wed Dec 11 18:20:46 2019 +0000 Bug 23796: Convert OpacCustomSearch system preference to news block This patch moves the OpacCustomSearch system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacCustomSearch system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacCustomSearch system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacCustomSearch is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacCustomSearch_en', 'OpacCustomSearch_fr-FR', 'OpacCustomSearch_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 8f819ac9b97bd6c9872259f2b614543724fefbbf Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 10:35:13 2020 +0200 Bug 23795: DBRev 20.06.00.012 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit c9eb2be381bf9b6848b14bd374ba004f41198ed0 Author: Owen Leonard <oleonard at myacpl.org> Date: Wed Dec 11 17:03:01 2019 +0000 Bug 23795: Convert opaccredits system preference to news block This patch builds on Bug 22318 to move the opaccredits system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the opaccredits system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opaccredits system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opaccredits is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'opaccredits_en', 'opaccredits_fr-FR', 'opaccredits_cs-CZ' - Go to Administration -> System preferences and confirm that the opaccredits preference has been removed. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit bd9ece8c194ffc960b5709b884620bf24e29068b Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jul 21 16:03:54 2020 +0100 Bug 25765: (QA follow-up) Use method directly in cleanborrowers Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 83d63d2302ee77c68dbae8be80fc6a038fa5ce51 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jul 21 15:58:02 2020 +0100 Bug 25765: (QA follow-up) Save a DB hit Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit cbd86551571260ca6daade57920e0fb3f290dfb4 Author: Fridolin Somers <fridolin.somers at biblibre.com> Date: Tue Jun 16 14:01:39 2020 +0200 Bug 25765: Replace LoginBranchname and LoginBranchcode with use of Branches template plugin The template plugin Branches contains a method GetLoggedInBranchcode that returns current branch code. This patch adds GetLoggedInBranchname to get current branch name. It is used to replace vars LoginBranchname and LoginBranchcode sent to all templates in C4/Auth.pm. In labels and patrons cards modules, I choose to remove a unseless display of current branch in a hint. In acqui/acqui-home.tt, I choose to remove a useless display of current branch and also because table of founds contains a filter on library. Test plan: Check pages source code to see branch code or name is correct. list of the pages: /cgi-bin/koha/acqui/acqui-home.pl /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX /cgi-bin/koha/circ/branchoverdues.pl /cgi-bin/koha/circ/set-library.pl /cgi-bin/koha/circ/offline.pl /cgi-bin/koha/labels/label-edit-batch.pl?op=new /cgi-bin/koha/labels/label-manage.pl /cgi-bin/koha/patroncards/edit-batch.pl /cgi-bin/koha/patroncards/manage.pl OPAC: /cgi-bin/koha/opac-detail.pl?biblionumber=XXX Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 0fcd0fd2707188368fa5b370b808e875c6ea5814 Author: Fridolin Somers <fridolin.somers at biblibre.com> Date: Tue Jun 16 13:59:29 2020 +0200 Bug 25765: Add GetLoggedInBranchname method Add GetLoggedInBranchname method to Branches templates plugin. Also changes GetName method to use Koha::Library instead of direct SQL. Test plan : Run prove t/db_dependent/Template/Plugin/Branches.t Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 12e83a64ececa12e691d855e2454a30a9b5e0e04 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 10:32:09 2020 +0200 Bug 5087: DBRev 20.06.00.011 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit c2d45ac0f4687fc4dcf84e9de663f8d3f3a354be Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 11:15:24 2020 +0200 Bug 5087: Add server-side check If a user to access a CSV profile that is not available at the OPAC we should redirect to 404. It will also handle undefined csv_profiles For instance: kohadev.mydnsname.org:8080/cgi-bin/koha/opac-downloadshelf.pl?shelfnumber=1&format=3 kohadev.mydnsname.org:8080/cgi-bin/koha/opac-downloadcart.pl?bib_list=1/2/&format=3 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit db15f4af8dc021c0ac06c3447cb87c5e51952cd2 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Mon Jul 20 12:02:14 2020 -0300 Bug 5087: (QA follow-up) Fix leakage in opac-downloadshelf.pl Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 92d0472d631817395ad71f89f962fa5166f15770 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Mon Jul 20 11:27:27 2020 -0300 Bug 5087: (QA follow-up) used_for deserves an index This patch introduces an index for the used_for column Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 478093072000d01b2b5c20f05044e4bd3bbfeecd Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Mon Jul 20 11:09:01 2020 -0300 Bug 5087: (QA follow-up) Rename the attribute to fit later API usage This patch renames the introduced attribute for later usage on the API, and changes the logic to use it the other way around. It also adds a KEY for the flag, as it will be used in WHERE statements. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit ae3644a5947ea410fc3e8ac8b64307df7d1cbb18 Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Thu Dec 20 22:52:59 2018 +0000 Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 07a7dbbcf427dfcff9aa386832e9f9cf1c4b4828 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 10:30:31 2020 +0200 Bug 20815: DBRev 20.06.00.010 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit fa1571cc0a0b2def305a500b5bd344b2ff2fcbea Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Wed Jul 22 08:54:26 2020 -0400 Bug 20815: Add unit tests for changes to AddIssue Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit dfb70ce9f1edf54d9aad3755f1fb840b5ed4b6d3 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Jul 21 18:45:37 2020 +0200 Bug 20815: Tests refactoring Some code were duplicated. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 83d9a6e60289912736b0181d4e9cee090b4d0ffe Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Mon Jul 6 20:53:55 2020 +0000 Bug 20815: (QA follow-up) Add message to database update / rephrase pref - Make pref use "checked in" instead of "returned". - Add message to database update Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 3b8b542f9e49ab3f7c45aaa7eda33df1607028ef Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Mon Jul 6 07:03:21 2020 -0400 Bug 20815: Do not use compare float with precision Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e453f74cfd2358ea795f2f0677946fba75ad7841 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Wed Feb 12 12:55:51 2020 -0500 Bug 20815: Add ability to choose if lost fee is refunded based on length of time item has been lost This adds the ability to not refund lost item fees on return if the item has been lost for more than a given number of days. Test Plan: 1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of days 2) Find a lost item that has been lost longer than that NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded 3) Return the item 4) Note no refund on the lost item fee was processed, the fee remains unchanged 5) prove t/db_dependent/Circulation.t Signed-off-by: Deb Stephenson <DStephen at dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 5 - C4/Circulation.pm | 32 +- Koha.pm | 2 +- Koha/Schema/Result/ExportFormat.pm | 16 +- Koha/Schema/Result/OpacNews.pm | 8 +- Koha/Template/Plugin/Branches.pm | 17 +- circ/set-library.pl | 3 +- installer/data/mysql/kohastructure.sql | 7 +- installer/data/mysql/sysprefs.sql | 4 +- installer/data/mysql/updatedatabase.pl | 129 +++++++ koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../intranet-tmpl/prog/en/includes/header.inc | 8 +- .../prog/en/includes/members-toolbar.inc | 2 +- .../prog/en/modules/acqui/acqui-home.tt | 2 +- .../en/modules/admin/preferences/circulation.pref | 5 + .../prog/en/modules/admin/preferences/opac.pref | 18 - .../prog/en/modules/catalogue/detail.tt | 2 +- .../prog/en/modules/circ/branchoverdues.tt | 6 +- .../intranet-tmpl/prog/en/modules/circ/offline.tt | 3 +- .../prog/en/modules/circ/set-library.tt | 2 +- .../prog/en/modules/labels/label-edit-batch.tt | 1 - .../prog/en/modules/labels/label-manage.tt | 1 - .../prog/en/modules/patroncards/edit-batch.tt | 1 - .../prog/en/modules/patroncards/manage.tt | 1 - .../prog/en/modules/tools/cleanborrowers.tt | 2 +- .../prog/en/modules/tools/csv-profiles.tt | 9 + .../prog/en/modules/tools/koha-news.tt | 2 +- .../opac-tmpl/bootstrap/en/includes/bodytag.inc | 5 +- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 14 +- .../bootstrap/en/includes/opac-bottom.inc | 9 +- .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 7 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 5 +- opac/opac-basket.pl | 6 +- opac/opac-downloadcart.pl | 18 +- opac/opac-downloadshelf.pl | 19 +- t/db_dependent/Circulation.t | 383 ++++++++++++++++++++- t/db_dependent/Template/Plugin/Branches.t | 13 +- tools/csv-profiles.pl | 3 + 39 files changed, 680 insertions(+), 94 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 23 12:44:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Jul 2020 10:44:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-378-gd2e191c3ff Message-ID: <E1jyYiS-0002If-SQ@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d2e191c3fff9ef68bf7104b72922ded77e9d5217 (commit) from 452015c054a988ad2016dcad896be516dc318743 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d2e191c3fff9ef68bf7104b72922ded77e9d5217 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 12:14:56 2020 +0200 Bug 24151: (follow-up) Rename the config key with 'bcrypt_settings' Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: debian/templates/koha-conf-site.xml.in | 4 ++-- etc/koha-conf.xml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 23 22:53:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Jul 2020 20:53:24 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.13-2-g3b4064ca8e Message-ID: <E1jyiDU-0006wz-ST@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 3b4064ca8ead9279f5e2ef3e78c5bff7f6aa4466 (commit) via f15a24c62020d893f89f6db2a5e13b759daf1847 (commit) from cba17a6af741c27f90304e6b1d8ee90246e2f572 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3b4064ca8ead9279f5e2ef3e78c5bff7f6aa4466 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri May 22 11:02:39 2020 +0200 Bug 25553: Make date columns sortable on the edit items table When editing items, the table at the top contain several columns that have date values, but they cannot be sorted by dates correctly. Test plan: Have several items with different dates in columns that contain dates, like items.dateaccessioned, items.datelastseen) Sort the column and confirm that with this patch the lines are sorted correctly Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 31800ba46b2ed03cc2e4431c4d3c56fce678a0ec) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit ca74f037d83a7c406f187bdfe77cbed7b2f4aade) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 99a27050d84281643f40bbdb5d0adb4edbf32e15) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit f15a24c62020d893f89f6db2a5e13b759daf1847 Author: Owen Leonard <oleonard at myacpl.org> Date: Mon May 11 19:17:57 2020 +0000 Bug 25447: Terminology: Fix button text "Edit biblio" This patch changes the cataloging main page so that in the menu for reach search result the "Edit biblio" link is now "Edit record." To test, apply the patch and do a search in cataloging. In the list of search results verify that the "Actions" menu contains a link labeled "Edit record." Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 679dcd1574de88cb8b7002c5020e0b4488233943) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit f918bee5f612b3eef54bd81999373ed023e737b4) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit f208817b13636e0b4746b1bfe5d5e5a13de39b88) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: cataloguing/additem.pl | 2 +- .../intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt | 2 +- .../intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 14 ++++++++++++-- 3 files changed, 14 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 00:42:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Jul 2020 22:42:26 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.13-5-g7ed966fc0b Message-ID: <E1jyjv0-0002cX-7w@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 7ed966fc0b4c278b483ba34dc6e0180aee4ba551 (commit) via 8c4b82b604975446aafafb7f2b95f545b7424af8 (commit) via ddbdc549c45399ed4610ae8e47459860b27a69a3 (commit) from 3b4064ca8ead9279f5e2ef3e78c5bff7f6aa4466 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7ed966fc0b4c278b483ba34dc6e0180aee4ba551 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu May 21 18:23:01 2020 -0300 Bug 25570: Paginate results by default in objects->search This patch makes the helper paginate the resultsif no pagination parameters are passed. Page number defaults to 1, and the page size to the RESTdefaultPageSize syspref value. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Pagination is not enforced by default 3. Apply this patch 4. Repeat 2 => SUCCESS: Results are paginated 5. Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 451ae76431d3d580494f917ed397f259cd96a876) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 16530f09687f48cb621c1a1dfc1559fc35979d51) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 55fba122759a85ea5b45a36908d67c310af1ea0c) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 8c4b82b604975446aafafb7f2b95f545b7424af8 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu May 21 18:25:46 2020 -0300 Bug 25570: (follow-up) Fix tests This patch fixes the libraries tests, that expected the old behaviour To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/libraries.t => FAIL: Tests fail 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit b115dfeca649f2f35e0290ead85f2626eabd0829) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 18051cb02a483dc020afc31b82e3897daba8a793) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit afcd1902c03f72ef61846d3a034c7b5086b3c812) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit ddbdc549c45399ed4610ae8e47459860b27a69a3 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu May 21 17:48:21 2020 -0300 Bug 25570: Regression tests This tests verify that the default behaviour is to paginate the results. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: $c->objects->search doesn't paginate results by default Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 2220ce4d50998bef1dcea787d212a287a802b0aa) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit fc8bde417820d2f287df997a44136ea0b504b0f7) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 429d56d3894cffb4febe45616a3073e95191af67) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: Koha/REST/Plugin/Objects.pm | 4 ++++ t/db_dependent/Koha/REST/Plugin/Objects.t | 22 +++++++++++++++++++++- t/db_dependent/api/v1/libraries.t | 13 ++++++++----- 3 files changed, 33 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 00:46:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Jul 2020 22:46:33 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.13-6-g96cb2efdc0 Message-ID: <E1jyjyz-0002or-8E@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 96cb2efdc0a06a60e0b1d9fbb286ef65281a3400 (commit) from 7ed966fc0b4c278b483ba34dc6e0180aee4ba551 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 96cb2efdc0a06a60e0b1d9fbb286ef65281a3400 Author: David Cook <dcook at prosentient.com.au> Date: Fri May 15 14:55:49 2020 +1000 Bug 25509: Remove useless libjs-jquery dependency We don't use the libjs-jquery package, so we should remove the dependency. To Test: 1) Build package (out of scope of test plan) 2) Install package 3) Note that libjs-jquery is marked by apt as no longer required 4) Remove libjs-jquery package from system and note how it doesn't take koha-common with it Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 9e923e57ed18a104c33cc10a4704450ec4c71c28) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 898bd1256af37f5c4ec945e1d99b5146eecc2231) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 46b96996c1643e62f77c62aa12d0f62310498a2e) ----------------------------------------------------------------------- Summary of changes: debian/control.in | 2 -- 1 file changed, 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 01:01:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Jul 2020 23:01:04 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.13-7-ge2061e8f8d Message-ID: <E1jykD2-0003Pd-E3@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via e2061e8f8dadb01775b1c6c8da3c307e1e34dbc5 (commit) from 96cb2efdc0a06a60e0b1d9fbb286ef65281a3400 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e2061e8f8dadb01775b1c6c8da3c307e1e34dbc5 Author: David Cook <dcook at prosentient.com.au> Date: Fri May 15 14:55:49 2020 +1000 Bug 25509: Remove useless libjs-jquery dependency We don't use the libjs-jquery package, so we should remove the dependency. To Test: 1) Build package (out of scope of test plan) 2) Install package 3) Note that libjs-jquery is marked by apt as no longer required 4) Remove libjs-jquery package from system and note how it doesn't take koha-common with it Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 9e923e57ed18a104c33cc10a4704450ec4c71c28) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 898bd1256af37f5c4ec945e1d99b5146eecc2231) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 46b96996c1643e62f77c62aa12d0f62310498a2e) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 02:49:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 00:49:20 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.13-14-g1706486bc5 Message-ID: <E1jylto-0001cA-8x@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1706486bc5d4b8c18895fac48842206ac3572cb4 (commit) via 4b654fd20a3159348e3daa5bbb963e2c6296e4e7 (commit) via fa2d4392d8f5f2ad0b7260531e39824402d79ad5 (commit) via a783ce390e566a3027f47a62d7e9d3581daf05ae (commit) via 0479308267f66e9e402b6bafa9ee85f801df263c (commit) via d330f343e94fd61b6495580f9b9d55730dc95b2e (commit) via ab12d8ed94f5d451efe10428ffaa96d1d5efb14e (commit) from e2061e8f8dadb01775b1c6c8da3c307e1e34dbc5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1706486bc5d4b8c18895fac48842206ac3572cb4 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 12:15:21 2020 +0100 Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 3e18402c240814d7f00a62c3f2359bd9b9d0a098) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 0e711e024e2ac25347a17d6499289d90c6da29de) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 7519f4d065d258653a08cf46a8b142e702ca5af0) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 4b654fd20a3159348e3daa5bbb963e2c6296e4e7 Author: Andreas Roussos <a.roussos at dataly.gr> Date: Mon Jun 15 16:58:38 2020 +0200 Bug 25756: remove erroneous hyphen In the Staff Client, the OPAC "Appearance" preferences table has an extra, empty HTML table row at the end. Test plan: 0) Observe the empty HTML table row at the end of the table that lists OPAC "Appearance" system preferences. 1) Apply this patch. 2) Observe that the empty table row is now gone. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 251197ad73ba2be88ac2154db46748b58a0597f8) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 3fdec870573700d2d0d585b7453f279c25e116a1) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 0425f6702f3b5d1e368e1fd557fd1d1c14993e93) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit fa2d4392d8f5f2ad0b7260531e39824402d79ad5 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Jun 5 11:15:33 2020 +0200 Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor Reported-by: Kelly McElligott <kelly at bywatersolutions.com> Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit cd716269a7b2b1b6165154ea7e85844201402a8d) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit b2514759bcd4b5d3cb5758bf66890f1d84a2c586) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit c260c6c6ffd74151c08f85b5bf53da9095e0a324) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit a783ce390e566a3027f47a62d7e9d3581daf05ae Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Fri May 1 20:11:29 2020 +0000 Bug 11994: (follow-up) Make things work when LibraryName is empty When LibraryName system preference was not set, the installation of the plugin would fail with: Firefox could not download the search plugin from: ... Now if the pref is empty, the description 'Library catalog' will be used instead. To test: - Empty your LibraryName pref - Verify the search plugin can still be installed (see first patch for further instructions) Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 1e0dd6d0783a66514fc92cc0a34ca0882a5ce62f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 42e8c0185cf50b93789f3cfe6d4532565e084aeb) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit da97436614ce8b1ddb9aa2e7f1861d1e82deea84) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 0479308267f66e9e402b6bafa9ee85f801df263c Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Fri May 1 17:20:43 2020 +0000 Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml https://developer.mozilla.org/en-US/docs/Web/OpenSearch Your server should serve OpenSearch plugins using Content-Type: application/opensearchdescription+xml. To test: - Verify the Content-Type the file is delivered with is correct, for example using wget http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?format=opensearchdescription Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f090c1d2cb9253d77c5bac3b8fa03c775af2f0f6) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit e15992e4eb1e194a8ecc3bf8f04b5a74e6e5520a) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit c1ef8a49de0dab37cfb94de9c3e13410989a2de7) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit d330f343e94fd61b6495580f9b9d55730dc95b2e Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Apr 28 14:41:47 2020 +0000 Bug 11994: Fix OpenSearch discovery in the OPAC This patch corrects the markup for the OpenSearchDescription XML document and adds (back) the link in the OPAC header which points to it. This will enable compatible browsers to offer the addition of the OPAC's keyword search as a search engine option. I've found documentation suggesting this feature is available (or at least was at one time) in Chrome and Safari, but in my test it only works in Firefox. To test, apply the patch and make sure the OPACBaseURL preference is set correctly. - Open the OPAC in Firefox (these instructions assume the latest version, currently v.75). - On the right side of the address bar you should see ". . ." Click it to trigger the menu. - You should see an "Add search engine" entry with your OPAC's icon. - Click to add the search engine. - Type a keyword to search in the address bar - A box should pop up below the address bar showing icons at the bottom for performing a search in various search engines. One of these icons should be the icon for your Koha OPAC. - Click the Koha OPAC icon and confirm that it triggers a keyword search in your OPAC. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0ef7b3db4cab73797ba3386b4951c0d86addf871) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 6f9b44c95a02e5f24d4441622949225757db1b95) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 8019711adf319483f4baa4b4bc3b78972d9715ec) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit ab12d8ed94f5d451efe10428ffaa96d1d5efb14e Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Jun 16 19:48:48 2020 +0000 Bug 24352: Correct location and collection labels in OPAC search results This patch modifies the OPAC's MARC21 search results XSLT so that OPAC search result information is correctly labeled based on the OpacItemLocation preference. Previously, search results showed the label "Location(s)" whether the setting was "collection code" or "location." To test, apply the patch and set the OPACXSLTResultsDisplay system preference to 'default.' On the OPAC search results page, each result with items should show information in this format: With the OpacItemLocation preference set to 'call number only,' - "Availability: Items available for loan: {library} [Call number: {call number} ] With the OpacItemLocation preference set to 'collection code,' - "Availability: Items available for loan: {library} Collection(s): {collection description} [{ call number }]" With the OpacItemLocation preference set to 'location,' - "Availability: Items available for loan: {library} Location(s): {shelving location} [{ call number }]" Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 897948cff5812a67144355829cf8915af17465d0) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 0aa981c91319450b4c4c8641845c2098f3f73d0b) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit fa610981b7ef4f3c59527c7d40d84c84167f62a2) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: C4/Output.pm | 5 ++-- acqui/basketheader.pl | 2 +- .../prog/en/modules/admin/preferences/opac.pref | 1 - .../bootstrap/en/includes/doc-head-close.inc | 1 + .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- .../bootstrap/en/modules/opac-opensearch.tt | 33 +++++++++++++--------- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 8 +++--- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 11 +++++++- .../bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl | 4 +-- .../bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 4 +-- opac/opac-search.pl | 2 +- 11 files changed, 44 insertions(+), 29 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 12:23:19 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 10:23:19 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.13-18-geb8533a2b9 Message-ID: <E1jyurH-0001py-9v@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via eb8533a2b9439c935dd94d1f0204af43ac3a1477 (commit) via c6c998667551e499663925eb356d16cd30580797 (commit) via 2fcc6448eb38424b05ebcc64f893a471378d3675 (commit) via 2dda5cd17fdcc0368a96c10b556d203f8d91d97a (commit) from 1706486bc5d4b8c18895fac48842206ac3572cb4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eb8533a2b9439c935dd94d1f0204af43ac3a1477 Author: Victor Grousset/tuxayo <victor at tuxayo.net> Date: Fri Jul 24 11:52:51 2020 +0200 Bug 25236: Compile CSS Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit c6c998667551e499663925eb356d16cd30580797 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 11:54:22 2020 +0100 Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0550e0b7f788b65b50ed4689d677600be3f9c7c2) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit e6cd1ced668bdf25307dc041c95557ec71dfff02) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 9b39c1ec253eb8bf00e31cbed6467f42844e2e31) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 2fcc6448eb38424b05ebcc64f893a471378d3675 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 11:44:53 2020 +0100 Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 62795521eedc02e11bef520c8b980d480b7e02ae) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 0a01f91887ee5ca24c7950cbd59984dbd335404d) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 35e1f053f9fa0d62b004526e7d55a3481b8be7ea) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 2dda5cd17fdcc0368a96c10b556d203f8d91d97a Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 11:37:26 2020 +0100 Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f88d56f689e514b47930d617049358fdf9b68608) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit cc75932f3eca746e8e2c08125306a94952b8a87d) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 3bb05edced373175227d4c2fb704db75519ae78c) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 6 ++++- .../bootstrap/en/includes/opac-facets.inc | 26 +++++++++++----------- .../bootstrap/en/includes/opac-topissues.inc | 2 +- .../en/modules/opac-full-serial-issues.tt | 12 +++++----- 5 files changed, 27 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 14:42:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 12:42:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-391-g1a505632b8 Message-ID: <E1jyx1t-0005zF-4A@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1a505632b8d1300a02512cfe300056f7b3797bfb (commit) via 3b9c0f338bdacb579ef4d68d1e3dc85515419929 (commit) via 4cf04214d381dd9a9eed28a2ee24e0c01eaaf36f (commit) via 9a6b28a914269356e27054811e0d87fc10c12a7d (commit) via 58075331a9e68db0539d59abb4f1a4f215a12120 (commit) via 2b902c7b7512851027c92cf629fd7796d1c8035d (commit) via 4eac2298592ef7d75bd6575cb2e823aeeace8f9d (commit) via e14c1702b446111f98ce6736aa7544df14b03d1d (commit) via 664c0de114be2c47786e570b316f941ade337d1f (commit) via a64368e1fd16d73a87fdda37fc0851743e4ad6db (commit) via 784e4685de0934c939f7047bcea191088169d824 (commit) via fa8c57e55d3f3cc027bc6e9d0fdf8dad81555453 (commit) via 6b6cea9d64f255cce481012a30a0ae3298e160b2 (commit) from d2e191c3fff9ef68bf7104b72922ded77e9d5217 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1a505632b8d1300a02512cfe300056f7b3797bfb Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Fri Jul 17 23:36:24 2020 +0000 Bug 26016: Fix capitalization for "MARC Preview" To test: - Go to any record in the staff catalog - Check the display for the 'MARC Preview' link - Apply patch - It should have changed to 'MARC preview' Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 3b9c0f338bdacb579ef4d68d1e3dc85515419929 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed Jul 22 10:09:29 2020 +0100 Bug 20799: (QA follow-up) Move syspref check This patch moves the syspref check into the controller to save a DB query if the module is not enabled. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> JD - amended patch: removing trailing parenthesis in the IF statement Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 4cf04214d381dd9a9eed28a2ee24e0c01eaaf36f Author: Katrin Fischer <katrin.fischer at bsz-bw.de> Date: Mon Jun 29 17:56:31 2020 +0200 Bug 20799: (follow-up) Add ILLModule system preference check and fix display for no requests When there were no requests the label would still display, using .count fixes this. Also adds a check on the ILLModule system preference to prevent the information from showing when the ILL module is deactivated. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9a6b28a914269356e27054811e0d87fc10c12a7d Author: Magnus Enger <magnus at libriotech.no> Date: Mon Dec 9 17:48:35 2019 +0100 Bug 20799: Add link from biblio to ILL detail view Some ILL systems (e.g. Libris in Sweden) require a link between a biblio and an ILL request. When such a link exists it is nice to display an actual link from the biblio detail view to the ILL request detail view. This patch adds such a link. For users without ILL privileges, the requests should still show, but not be clickable links. To test: - Make sure you have a couple of ILL requests created with the FreeForm backend. (FreeForm does not let you tie a request to a biblio through the UI, but we will add connections directly in the database.) Lets assume these have illrequest_id's a and b. - Make sure you have a record, let's call the biblionumber x. - Apply the patch and make sure there are no changes in the biblio detail view of biblionumber x. - Log into the database and connect the biblio to the first request: UPDATE illrequests SET biblio_id = x where illrequest_id = a; - Check that the biblio detail view now says this: "ILL requests: Request a" - Verify that the "Request a" part is a working link to the detail view of ILL request a. - Do this in the database: UPDATE illrequests SET biblio_id = x where illrequest_id = b; - Check that the biblio detail view now says this: "ILL requests: Request a, Request b" - Verify the links work as expected. - Log in as a staff user and check that the requests are still listed, but not displayed as clickable links. - Sign off Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 58075331a9e68db0539d59abb4f1a4f215a12120 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Jul 24 14:10:52 2020 +0200 Bug 23092: DBRev 20.06.00.016 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 2b902c7b7512851027c92cf629fd7796d1c8035d Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jun 16 13:51:00 2020 +0100 Bug 23092: Add unit tests Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 4eac2298592ef7d75bd6575cb2e823aeeace8f9d Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jan 17 12:04:07 2020 +0000 Bug 23092: Add 'daterequested' to branchtransfers table Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e14c1702b446111f98ce6736aa7544df14b03d1d Author: Josef Moravec <josef.moravec at gmail.com> Date: Mon Sep 30 09:28:40 2019 +0000 Bug 23696: take deleted biblios into account when building oai sets Test plan: 0) do not apply the patch 1) set up OAI and create at least one set 2) run build_oai_sets.pl 3) remember/write down number of records added 4) delete a biblio, the is included in set 5) run buid_oai_sets.pl again 6) the set is 1 record smaller 7) apply the patch 8) run build_oai_sets.pl 9) the number of record should be the same as in 3) Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 664c0de114be2c47786e570b316f941ade337d1f Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Jul 24 14:09:03 2020 +0200 Bug 25031: Compiled CSS Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit a64368e1fd16d73a87fdda37fc0851743e4ad6db Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Jul 24 11:19:24 2020 +0000 Bug 25031: (follow-up) Fix markup error and restore cover class This patch corrects a markup error that appears when no cover image services are enabled. An unclosed <div> caused links on the page to break. This patch also restores a part of the cover-handling script which adds a bordered style to the cover image "tiles" Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 784e4685de0934c939f7047bcea191088169d824 Author: Owen Leonard <oleonard at myacpl.org> Date: Thu Jul 23 19:49:33 2020 +0000 Bug 25031: (QA follow-up) Avoid displaying extra navigation This patch reworks the construction of the navigation links in such a way that they are built during a loop over an updated jQuery object. Previously the stored variable might not reflect that some elements had been removed. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit fa8c57e55d3f3cc027bc6e9d0fdf8dad81555453 Author: Owen Leonard <oleonard at myacpl.org> Date: Wed Jun 17 21:45:00 2020 +0000 Bug 25031: (QA follow-up) Improve handling of one or fewer images This patch addresses a few issues raised during QA: 1. If there are no images, avoid the momentary appearance of an empty borered box. The class controlling the appearance of the box is now added after initialization. 2. If there is only one image, remove the control for switching between covers. 3. Add "preventDefault" to cover naviation click handler. 4. Correct translation function in localcovers.js. This patch modifies SCSS, so rebuilding the staff client CSS is necessary for testing. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 6b6cea9d64f255cce481012a30a0ae3298e160b2 Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Mar 31 21:37:18 2020 +0000 Bug 25031: Improve handling of multiple covers on the biblio detail page in the staff client This patch modifies the template, JS, and CSS for the bibliographic detail page in order to gracefully handle multiple cover images. The changed version loops through any cover images which might be embedded and checks that they are successfully loaded. Only successfully-loaded images are shown. Only the first image is shown, and the others can be "paged through" using generated navigation controls. To test, apply the page and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Enable multiple cover image services. The patch was developed with these services available: - Amazon - Local cover images (including multiple local cover images) - Coce (serving up Amazon, Google, and OpenLibrary images) - Images from the CustomCoverImages preference View a variety of titles and confirm that the cover images are displaying correctly, whether there be 0, 1, 2, or more covers available. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Branchtransfer.pm | 18 +- catalogue/detail.pl | 8 + installer/data/mysql/kohastructure.sql | 1 + installer/data/mysql/updatedatabase.pl | 17 ++ koha-tmpl/intranet-tmpl/js/coce.js | 78 ++++---- .../intranet-tmpl/prog/css/src/staff-global.scss | 37 ++++ koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../intranet-tmpl/prog/en/includes/js_includes.inc | 4 - .../prog/en/modules/catalogue/detail.tt | 201 ++++++++++++++++----- koha-tmpl/intranet-tmpl/prog/js/localcovers.js | 50 ++--- misc/migration_tools/build_oai_sets.pl | 7 +- t/db_dependent/Koha/Item/Transfers.t | 43 ++++- 13 files changed, 339 insertions(+), 129 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 17:31:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 15:31:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-393-g8d56af377c Message-ID: <E1jyzfF-0002O9-4O@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8d56af377c158823497df17b2ef18637bbc11a1c (commit) via 8aa907379eb54d360746c3e15051327a1e6cc1fe (commit) from 1a505632b8d1300a02512cfe300056f7b3797bfb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d56af377c158823497df17b2ef18637bbc11a1c Author: Mason James <mtj at kohaaloha.com> Date: Mon Jun 29 13:40:36 2020 +1200 Bug 25889: Increase performance of debian/list-deps script to test... (on a i7-2600 vm with 8 cores) 1/ run script, note execution time $ time ./debian/update-control real 8m5.000s 2/ copy old file $ cp ./debian/control control.old 3/ apply patch 4/ run updated script, note execution time is smaller $ time ./debian/update-control real 2m14.000s 5/ copy new file $ cp ./debian/control control.new 6/ confirm old and new control files are identical $ diff control.old control.new | wc -l 0 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 8aa907379eb54d360746c3e15051327a1e6cc1fe Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Jul 21 12:36:17 2020 +0200 Bug 26033: Use pic.infini.fr instead of framapic https://framapic.org/ is closing """ Framapic will be closing its doors on Tuesday, January 12, 2021. You will find a similar service on this page. Uploading images is now disabled, but you can still retrieve your images on the My images page. """ https://framablog.org/2019/09/26/lets-de-frama-tify-the-internet/ https://framablog.org/2020/03/03/10-bonnes-raisons-de-fermer-certains-services-framasoft-la-5e-est-un-peu-bizarre/ (French) We can still use another service. However we may think about hosting the service ourself! Test plan: Modify a selenium script to make it fail (for instance modify the path for a find_element call) Run it Confirm that the screenshot has been uploaded correctly and that the link works Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: debian/list-deps | 25 +++++++++++++------------ t/lib/Selenium.pm | 2 +- 2 files changed, 14 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 22:45:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 20:45:18 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-1-g28558bcee7 Message-ID: <E1jz4ZC-0000uf-NF@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 28558bcee7a417595d0c56fbe5fc106e077615c9 (commit) from 7b947f695bcfd9cb89952bcd1027701ef74bc3dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 28558bcee7a417595d0c56fbe5fc106e077615c9 Author: Slava Shishkin <slavashishkin at gmail.com> Date: Thu Jun 18 12:11:29 2020 +0300 Bug 25695: merge of similar code blocks after circulation_rules update In onboarding.pl we have second block with adding just one more rule parameter (maxissueqty) which can be merged to first one after all parameters now stored in circulation_rules table. Also this eliminates the need of adding forgotten "warn $@" after the second eval block. Mentored-by: Andrew Nugged <nugged at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 5c581265abff940350df83a52228085aa0792fe0) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: installer/onboarding.pl | 23 ++--------------------- 1 file changed, 2 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 22:51:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 20:51:23 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-2-g33cb7a9d0b Message-ID: <E1jz4f5-00013Z-AE@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 33cb7a9d0b78fc69b97b687a39170473d662aeee (commit) from 28558bcee7a417595d0c56fbe5fc106e077615c9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 33cb7a9d0b78fc69b97b687a39170473d662aeee Author: Nick Clemens <nick at bywatersolutions.com> Date: Mon Jun 29 11:04:59 2020 +0000 Bug 25890: Update sorting column for checkouts table Test plan: - Check some items out, all from different libraries - Modify the checkout and due dates, like: 2018-10-22 2018-01-23 2018-05-27 - Sort by checkout date, verify it is actually sorting on homebranch - Apply patch - Reload page - Note you can now sort items correctly Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 6250c2dc1556dbf0ef87f2bb36f13534cb2e2368) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 22:55:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 20:55:51 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-4-g5680e79f0d Message-ID: <E1jz4jP-00018v-Lc@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5680e79f0da5795ab0f99a7b145a6b2115fd39e4 (commit) via f7b93ef9c54bd1ce662ff7147f958a6fa73369a2 (commit) from 33cb7a9d0b78fc69b97b687a39170473d662aeee (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5680e79f0da5795ab0f99a7b145a6b2115fd39e4 Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Date: Sun May 24 08:51:27 2020 -0300 Bug 25443: (follow-up) surround strings with <span> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 46d3ec264c4e46cc73ee1713b5c39e6c564e5a1a) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit f7b93ef9c54bd1ce662ff7147f958a6fa73369a2 Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Sun May 24 02:04:03 2020 +0200 Bug 25443: Improve translation of 'Select the record to link%s to' Before this patch the title was set in italic, which caused the translation string to be cut off. Removing the italic formatting in favor of quotes and splitting the string into 2 sentences (dealing with title existing and not existing: Select the host record to link to '[% bibliotitle | html %]' Select the host record to link To test: - Activate EasyAnalyticalRecords system preference - Search for a record in staff - Use Edit > Link to host record - Verify the text is shown as above with the reord's title - The second case is a bit theoretical: - Delete 245$a from the record or empty out biblio.title using SQL - Verify the string still shows but without the 'to...' part. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d53b58cab858f06be7f9762b16b89c8bfbce5625) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 23:02:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 21:02:52 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-5-gfdaa7ce46a Message-ID: <E1jz4qC-0001Hm-4J@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via fdaa7ce46a8071cefd846f563224c84590c504c9 (commit) from 5680e79f0da5795ab0f99a7b145a6b2115fd39e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fdaa7ce46a8071cefd846f563224c84590c504c9 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 9 10:52:11 2020 +0200 Bug 25964: Prevent data loss when editing items from a MARC record Coming from: Bug 23463: Use new method Koha::Object->set_or_blank We have DB fields that are not mapped with MARC fields, for instance paidfor. They are not handled correctly. In ModItemFromMarc, we get a MARC record in parameter and update the item in DB. But we are loosing the fields that are not in the MARC record Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> (cherry picked from commit 189851fb9bbc831bb2875c2c440877c2562583d0) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 13 +++++++++++++ t/db_dependent/Items.t | 10 +++++++--- 2 files changed, 20 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 23:05:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 21:05:53 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-6-ga531a75b62 Message-ID: <E1jz4t7-0001Ld-EF@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via a531a75b628b04ed5638ddaf5add19e84e6779b5 (commit) from fdaa7ce46a8071cefd846f563224c84590c504c9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a531a75b628b04ed5638ddaf5add19e84e6779b5 Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Date: Wed Jul 15 11:08:32 2020 +0000 Bug 25992: Make SIP2 logger subroutines exportable to prevent crash If the subroutines are not exportable we get the following crash: > Undefined subroutine &C4::SIP::SIPServer::set_logger To test: In kohadevbox run for example: $ ps -aux # check that no existing sip server is running, kill the process if exists $ perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml $ koha/misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item 3999900000001 -m item_information After applying this patch the Undefined subroutine error should be gone. Note: when using the sip_cli_emulator.pl the credentials can be anything. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> (cherry picked from commit 082da615e649146197fbc9e0a20da672a82d4816) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/SIP/Logger.pm | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 23:13:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 21:13:25 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-10-gf63c82a30f Message-ID: <E1jz50P-0001Tg-PH@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via f63c82a30f2e9455ce07085f3030d5160658c9f7 (commit) via 4c0d7b14bebcedb802488ee1fb200a2c7513ca91 (commit) via 238b2af84fe8efe8a740758a774f3587717ffb2b (commit) via f5f3269e25169e295fa495dc6b38114edcb767a6 (commit) from a531a75b628b04ed5638ddaf5add19e84e6779b5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f63c82a30f2e9455ce07085f3030d5160658c9f7 Author: Nick Clemens <nick at bywatersolutions.com> Date: Tue Jul 7 12:05:42 2020 +0000 Bug 25850: (QA follow-up) use dt_from_string Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> (cherry picked from commit 92970a9abad312a07d9efba46cc57b27469a0509) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 4c0d7b14bebcedb802488ee1fb200a2c7513ca91 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Mon Jun 29 09:54:58 2020 +0100 Bug 25850: (QA follow-up) Match logic in is_holiday Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> (cherry picked from commit afd88e1d21a5cb5f2198c058144065b64098c124) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 238b2af84fe8efe8a740758a774f3587717ffb2b Author: Andreas Jonsson <andreas.jonsson at kreablo.se> Date: Tue Jun 23 15:57:29 2020 +0200 Bug 25850: Adapt day of week in Koha::Calendar::get_push_amt to 0..6 with 0 being Sunday. 1. Go to tools -> calendar and make sure Sundays are holidays by adding a holiday on a Sunday and selecting "Holiday repeated every same day of the week" and "Copy to all libraries" and save. 2. Go to administration -> system preferences and select "Use the calendar to push the due date to the next open matching weekday for weekly loan periods, or the next open day otherwise" for the system preference "useDaysMode" and save the system preferences. 3. Put the below code in a file name test.pl and execute it using the command "sudo koha-shell -c 'perl test.pl' kohadev" use Koha::Calendar; my $calendar = Koha::Calendar->new( branchcode => 'CPL' ); $dt = DateTime->new( year => 2020, month => 06, day => 21 ); print "This is a sunday: " . $dt->day_of_week . "\n"; my $ndt = $calendar->next_open_days($dt, 0); print "This is a monday: " . $ndt->day_of_week . "\n"; 4. Without the patch applied, this script will freeze after printing "This is a sunday ...". Abort using ctrl-c. 5. Apply patch and run the script again. The test script will now complete. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> (cherry picked from commit 25127f422821756b030b8f377b3e112b907be5eb) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit f5f3269e25169e295fa495dc6b38114edcb767a6 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jun 26 16:52:50 2020 +0100 Bug 25850: Regression Test This patch adds a unit test to test for an infinite loop as highlighted by the bug. Test plan 1/ Run the test before applying the fix 2/ The test should fail for 'Sundays' 3/ Apply the subsquent patch 4/ Re-run the test 5/ It should now pass Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> (cherry picked from commit 95c8d19530e8bef20e02be0b74d7927764bf7ed1) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha/Calendar.pm | 9 ++++- t/db_dependent/Calendar.t | 101 +++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 108 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 23:22:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 21:22:25 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-11-ge6522ea63c Message-ID: <E1jz597-0001hb-IJ@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e6522ea63c6258b162c23731d2d3ff3950808152 (commit) from f63c82a30f2e9455ce07085f3030d5160658c9f7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e6522ea63c6258b162c23731d2d3ff3950808152 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jun 26 16:24:00 2020 +0100 Bug 25850: Add tests for weekday holidays Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> (cherry picked from commit 4ed4e468d2ceaf4502b817feb791656d5a159fa5) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Calendar.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 23:26:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 21:26:34 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-12-gd59536e289 Message-ID: <E1jz5D8-0001nj-2u@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via d59536e289692537289460a9225cc0c0bce80a57 (commit) from e6522ea63c6258b162c23731d2d3ff3950808152 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d59536e289692537289460a9225cc0c0bce80a57 Author: Nick Clemens <nick at bywatersolutions.com> Date: Thu May 21 13:41:23 2020 +0000 Bug 25566: Add option to ignore found holds and use it when checking high holds To test: 1 - Find or create a record with 10 items 2 - Set sysprefs: decreaseLoanHighHolds - enable decreaseLoanHighHoldsDuration - 2 decreaseLoanHighHoldsValue - 2 decreaseLoanHighHoldsControl - 'over the number of holdable items'/dynamic 3 - Set circ rules to allow 1 hold per record on the relevant record 4 - Place 3 holds on the record 5 - Check one item in and confirm hold to set to waiting 6 - Issue to the patron with the waiting hold 7 - Get a notice that loan period is decreased 8 - Don't confirm the checkout 9 - Apply patch 10 - Restart all the things 11 - Repeat checkout, no decrease this time! Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> (cherry picked from commit 96a871035043c7ffd93c61e756ee1ff89e3da0f0) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- C4/Reserves.pm | 29 ++++++++++++++++++----------- t/db_dependent/DecreaseLoanHighHolds.t | 26 ++++++++++++++++++++++---- t/db_dependent/Reserves/MultiplePerRecord.t | 7 +++++-- 4 files changed, 46 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 23:30:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 21:30:18 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-13-g0cd877fb74 Message-ID: <E1jz5Gk-0001u4-Pu@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 0cd877fb743154a76642952f454df1502302338a (commit) from d59536e289692537289460a9225cc0c0bce80a57 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0cd877fb743154a76642952f454df1502302338a Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jul 7 09:27:48 2020 +0100 Bug 25944: Schema fix for illrequests route The illrequests path was missing the `comments` and `status_alias` embedable relations in the path specification. Test plan: 1/ Ensure you have the latest Mojolicious + OpenAPI modules installed. 2/ Navigate to the ill requests page and note that the table is empty. 3/ Note that under the networking tab in your browsers developer tools that the api call fails with a 400 error. 4/ Apply the patch 5/ Refresh the page 6/ The table should now load and the api route should return a proper 200 response. 7/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Magnus Enger <magnus at libriotech.no> Applied the patch to a production server that was having the 400 error on the main ILL page, and the error was gone. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> (cherry picked from commit 40ab030060d6cbacb0be9df981fb28a6ade705ea) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: api/v1/swagger/paths/illrequests.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 23:48:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 21:48:42 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-14-gcb76501776 Message-ID: <E1jz5YY-0002MT-Dk@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via cb76501776b3d03cf7c513b50c6b38630740416e (commit) from 0cd877fb743154a76642952f454df1502302338a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cb76501776b3d03cf7c513b50c6b38630740416e Author: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Date: Fri Jun 12 13:51:16 2020 +0000 Bug 25726: make holds to pull ignore holds where found is not null and itemnumber is null To test: 1- place 2 bib-level holds on available items 2- confirm they both show on Holds to Pull 3- edit one hold from the database to set found='T' 4- reload Holds to Pull, confirm it is now empty 5- apply patch 6- Reload Holds to Pull 7- confirm it now shows the hold you did not edit Signed-off-by: donnab <donna at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> [EDIT] Using capitals for SQL reserved words; added a FIXME Tested with: update reserves set found='T', itemnumber=NULL where reserve_id=... This should be a workaround while we fix the underlying problem. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 56220d211d7b5c4e2622787f9ea38ab12c8868f5) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: circ/pendingreserves.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 23:56:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 21:56:55 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-15-g8c27b372a4 Message-ID: <E1jz5gW-0002b7-06@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 8c27b372a4968d5b0d99e512a781302f09a769bf (commit) from cb76501776b3d03cf7c513b50c6b38630740416e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8c27b372a4968d5b0d99e512a781302f09a769bf Author: David Cook <dcook at prosentient.com.au> Date: Wed Jul 8 07:10:50 2020 +0000 Bug 25950: Remove <client> in X-Forwarded-For from proxy tests This patch removes the <client> ip address in the X-Forwarded-For header from being tested against koha_trusted_proxies. Without this patch, REMOTE_ADDR will be set to null, if the <client> ip address matches against koha_trusted_proxies. To Test: 1. Run the unit test t/Koha/Middleware/RealIP.t Signed-off-by: Didier Gautheron <didier.gautheron at biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 7b84fda33b23347846ae50016f1e4b38b0fd95f4) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha/Middleware/RealIP.pm | 3 +- t/Koha/Middleware/RealIP.t | 152 +++++++++++++++++++++++++++++---------------- 2 files changed, 100 insertions(+), 55 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 24 23:59:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 21:59:38 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-16-gca2e551a4a Message-ID: <E1jz5j8-0002fZ-D1@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ca2e551a4ab5aaf5a9e9fb0b87af4519d8fb5d61 (commit) from 8c27b372a4968d5b0d99e512a781302f09a769bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ca2e551a4ab5aaf5a9e9fb0b87af4519d8fb5d61 Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jun 24 16:17:19 2020 +0000 Bug 25869: Fix Coce display for lists To test: 1 - Enable Coce for Opac CoceHost: https://coce.bywatersolutions.com CoceProviders: Select all OpacCoce: Enable 2 - Do a search on the Opac, confirm you see some covers 3 - Add some of the items with covers to a public list 4 - View the public list 5 - Note no covers display 6 - Apply patch 7 - Success! Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f77a377c939080eed36401746b5d722c91ee964b) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jul 25 00:14:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 22:14:04 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-17-g797af67544 Message-ID: <E1jz5x6-00034u-1D@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 797af6754455b9c029679e8d3c345c8a09ee9b30 (commit) from ca2e551a4ab5aaf5a9e9fb0b87af4519d8fb5d61 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 797af6754455b9c029679e8d3c345c8a09ee9b30 Author: Fridolin Somers <fridolin.somers at biblibre.com> Date: Wed Jun 24 17:05:30 2020 +0200 Bug 25868: Fix transfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed <form> tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfert 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit e441cb35fb13670e65b9437706561c17d1311945) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: circ/branchtransfers.pl | 44 ++++++---------------- .../prog/en/modules/circ/branchtransfers.tt | 28 ++++++++------ 2 files changed, 28 insertions(+), 44 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jul 25 00:28:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 22:28:25 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-19-gac5fbb0f51 Message-ID: <E1jz6Az-0003Ts-NY@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ac5fbb0f510b277a3554c7140dd4ecf7ca1815bd (commit) via 6d675b61ad2dfd8fa6cfd0f58a9ebb8d534bd358 (commit) from 797af6754455b9c029679e8d3c345c8a09ee9b30 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ac5fbb0f510b277a3554c7140dd4ecf7ca1815bd Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri Jul 24 21:55:44 2020 +0000 Bug 24379: DBRev 20.05.02.001 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 6d675b61ad2dfd8fa6cfd0f58a9ebb8d534bd358 Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jan 8 20:59:38 2020 +0000 Bug 24379: Make login_attempts not nullable While the column defaults to 0 in Koha::Object->store we set to NULL if NULLABLE When trying to reset a patrons password we check that the account is not administratively locked: login_attempts != -1 This query does not return rows where login_attempts IS NULL. It will return accounts where login_attempts = 0 Let's default to 0 like we intend To test: 1 - Create a new patron 2 - Note their login_attempts is NULL SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1 3 - Enable OpacResetPassword 4 - Attempt to reset password before logging in, you cannot 5 - Apply patch, updatedatabase, restart_all, update schema 6 - Create another patron 7 - Their login attempts should be 0 8 - Attempt to reset password, it works! Bug 24379: Fix the test First we create a patron using TestBuilder to get a hashref of valid info. Then we delete it and create a new patron using Koha::Patron->new Once stored, we should call discard_changes to make the calculated values available in the currenct object. Bug 24379: Don't drop default of 0 for login attempts When moving the column we drop the default, this means that DBs upgraded form earlier versions get the wrong values set To test: 1 - Checkout 16.11.x 2 - Reset all 3 - Checkout master 4 - updatedatabase 5 - SHOW CREATE TABLE borrowers; 6 - Note the column login_attempts defaults to NULL 7 - Apply patch(es) 8 - Repeat 9 - Now it defaults ot 0 (and has NOT NULL if applied all) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 7bb31cffae27dc398a7b4a4decf3623ec65478ac) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 4 ++-- installer/data/mysql/updatedatabase.pl | 13 +++++++++++-- t/db_dependent/Koha/Patron.t | 21 ++++++++++++++++++++- 4 files changed, 34 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jul 25 00:47:08 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 22:47:08 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-20-g0d54b439a9 Message-ID: <E1jz6T6-0003uW-BT@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 0d54b439a9ee2e404e265c849c5dcf10ca116c23 (commit) from ac5fbb0f510b277a3554c7140dd4ecf7ca1815bd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d54b439a9ee2e404e265c849c5dcf10ca116c23 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri Jul 24 22:13:12 2020 +0000 Bug 24379: DBIC changes Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Borrower.pm | 8 ++++---- Koha/Schema/Result/Deletedborrower.pm | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jul 25 01:21:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 23:21:42 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-21-gc0e665aecc Message-ID: <E1jz70Y-0005wD-Vr@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via c0e665aeccbc028f4289e7b1c144f844c05b5198 (commit) from 0d54b439a9ee2e404e265c849c5dcf10ca116c23 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c0e665aeccbc028f4289e7b1c144f844c05b5198 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jul 20 15:16:29 2020 +0200 Bug 24379: Fix failing tests kohadev-koha at kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Patrons/Import.t t/db_dependent/Koha/Patrons/Import.t .. 2/159 # Failed test 'No warning raised by import_patrons' # at t/db_dependent/Koha/Patrons/Import.t line 171. # found warning: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2. # found warning: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2. # didn't expect to find a warning Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_2> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_2> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_4> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_4> line 2. t/db_dependent/Koha/Patrons/Import.t .. 152/159 # Looks like you failed 1 test of 159. t/db_dependent/Koha/Patrons/Import.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/159 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons/Import.t (Wstat: 256 Tests: 159 Failed: 1) Failed test: 39 Non-zero exit status: 1 Files=1, Tests=159, 3 wallclock secs ( 0.04 usr 0.01 sys + 2.11 cusr 0.24 csys = 2.40 CPU) Result: FAIL Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 545e03c173c789241eb21773a939b4ab7dcc6da4) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha/Patrons/Import.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jul 25 01:30:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 23:30:28 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-22-gace1e3e53e Message-ID: <E1jz792-0006H9-1Q@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ace1e3e53e6332cba767594f6caa0be97ce2e198 (commit) from c0e665aeccbc028f4289e7b1c144f844c05b5198 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ace1e3e53e6332cba767594f6caa0be97ce2e198 Author: Didier Gautheron <didier.gautheron at biblibre.com> Date: Wed Jun 24 16:03:16 2020 +0200 Bug 25862: Prevent TinyMCE to mangle local url links To test: 1 create a report 1 if it doesn't exist 2 open /cgi-bin/koha/tools/koha-news.pl 3 create a news 4 add a HTML link with Insert/Edit link tinyMCE dialog box to /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run%20this%20report "report 1" 5 save 6 on the main page "report 1" link returns a 404 error Apply patch 7 Modify news' URL 8 Test it works in: tools/koha-new.pl admin/branches.pl and admin/preferences.pl Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 2fbe775070637ebdddcc9ea0b455e80dbb85a83d) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt | 1 + 3 files changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jul 25 01:32:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 23:32:52 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-23-gdef7b5d170 Message-ID: <E1jz7BM-0006MB-Qx@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via def7b5d1706fe145c61b18d17fe5251ab92e6dd7 (commit) from ace1e3e53e6332cba767594f6caa0be97ce2e198 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit def7b5d1706fe145c61b18d17fe5251ab92e6dd7 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Tue Jan 21 17:53:09 2020 +0000 Bug 24473: Add $raw filter for Syndetics content Syndetics offers enhanced content in the OPAC under the tabs 'Title Notes', 'Excerpt', 'About the author', 'Editions'. They provide this info as HTML therefore we should filter it as $raw so the content shows up without the markup. Signed-off-by: Stina Hallin <stina.hallin at ub.lu.se> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 6b9572e0c8fb9f1ad1e60ed5db50e69c60ac1a00) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jul 25 01:36:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Jul 2020 23:36:58 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-24-gff49ea79d9 Message-ID: <E1jz7FK-0006Uf-KD@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ff49ea79d9afa4a37fb7e342c2100ba0ef8e26e1 (commit) from def7b5d1706fe145c61b18d17fe5251ab92e6dd7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ff49ea79d9afa4a37fb7e342c2100ba0ef8e26e1 Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Jul 14 21:30:39 2020 +0000 Bug 25987: Fix alignment of fields in label batch creation form This patch makes minor markup changes to the template for the label batch creation process so that form fields line up correctly. Unrelated change: A hint has been moved out of the label area to below the textarea in order to conform with established patterns. To test, apply the patch and go to Tools > Label creator > New > Label batch. - In the batch creation form the "Enter by itemnumber" and "Enter by barcode" should be aligned correctly with each other. - The "One number per line..." hint should appear below the textarea. - Test that the form fields are still correctly aligned after adding some items to the batch and the "description" field is shown in the form. Works for me! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 00f04146e915b2b1a9881439ac34088e6486921f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/labels/label-edit-batch.tt | 23 +++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jul 25 20:19:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 25 Jul 2020 18:19:40 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-25-g6cbd0a6257 Message-ID: <E1jzOlo-0000jG-6f@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 6cbd0a6257dabab98959d2c5a090fca84213eefa (commit) from ff49ea79d9afa4a37fb7e342c2100ba0ef8e26e1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6cbd0a6257dabab98959d2c5a090fca84213eefa Author: Didier Gautheron <didier.gautheron at biblibre.com> Date: Tue Apr 28 07:43:46 2020 +0200 Bug 25293: Don't call escapeHtml on null Test Plan: 1) Create two Checkouts 2) view patron's checkout list cgi-bin/koha/members/moremember.pl?borrowernumber=pp <show checkout> 3) in mysql shell delete a checkout home branch: update items set homebranch = null where itemnumber = xx; 4) view patron's checkout list, again Without this patch the list is empty. Same if biblio title is null (update biblio set title = null where biblionumber = yy;). Javascript error: TypeError: oObj.title is null Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 2b56ae1d4a231a83f52420ec9efc4829226fa86a) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jul 25 20:35:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 25 Jul 2020 18:35:54 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-26-g2fb5292dbf Message-ID: <E1jzP1W-0001Tf-QW@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 2fb5292dbf8244f0e4b2e20503371258d886b81e (commit) from 6cbd0a6257dabab98959d2c5a090fca84213eefa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2fb5292dbf8244f0e4b2e20503371258d886b81e Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Jul 17 13:57:34 2020 +0000 Bug 26005: OPAC cart display fails with error This patch removes the "opac_option" parameter from opac-basket.pl. It was included in Bug 25402 because the bug was dependent on 5087. To test, apply the patch and add some items to the Cart in the OPAC. Click the Cart button to show the cart. The pop-up window should load correctly without errors. Signed-off-by: Frédéric Demians <f.demians at tamil.fr> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 619d7dde80f16cbcae40582b1fa4f5bd9238eac8) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: opac/opac-basket.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jul 25 20:51:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 25 Jul 2020 18:51:37 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-31-ga48123c213 Message-ID: <E1jzPGj-00024e-5m@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via a48123c2131ba9f28f174e0cfc51807e1e42b9ad (commit) via f073ec206c701b0ea4bfab9878b60fa718377373 (commit) via 518332c0826381af3a3dbe35573610f411e80955 (commit) via 754e900fbec98503589770a73ac4164d32b732df (commit) via 54a4aa7d934f9636b9ee19ee9b2ac442658d2dd2 (commit) from 2fb5292dbf8244f0e4b2e20503371258d886b81e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a48123c2131ba9f28f174e0cfc51807e1e42b9ad Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jun 23 15:10:50 2020 +0100 Bug 8338: (QA follow-up) Clean up warning This patch moves the accountline->store call below the FinesLog code such that we return the same 'thing' from _FixOverduesOnReturn as the other clauses of the routine. We also take the oportunity to clean up the warning thrown by an errant call to the routine such that we output the actual itemnumber rather than a HASH reference marker. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit dae82b191abb87b88e6f455179f5776ce04dc2b8) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit f073ec206c701b0ea4bfab9878b60fa718377373 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Mon Jun 22 08:49:15 2020 +0100 Bug 8338: (QA follow-up) Fix perlcritic error Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 312b1c68870aec89eb81b31e7d168421548d2586) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 518332c0826381af3a3dbe35573610f411e80955 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jun 2 17:37:38 2020 +0100 Bug 8338: (follow-up) Fix test This patch moves the previous test introduced with bug 24075 into the same block as the rest of the AddReturn tests and updates it to test for the new 'remove accountline' behaviour as well as the reduce and refund behaviour. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 64bb70d579ffe3a6967103239ba683fd1c0cbd25) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 754e900fbec98503589770a73ac4164d32b732df Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed May 13 14:11:38 2020 +0100 Bug 8338: Remove zero amount overdues on backdated returns where appropriate This patch removes any overdues which would be reversed on a backdated return if CalcFineOnBackdate is enabled and the user has not already attempted to pay off the accruing fine. Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 3f3534a8eeed87869fd6a858866455c10087d7e1) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 54a4aa7d934f9636b9ee19ee9b2ac442658d2dd2 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed May 13 14:11:16 2020 +0100 Bug 8338: Unit Tests Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit a25b95c2e63a1705f406388f4419aa7972abc3b8) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 16 +-- t/db_dependent/Circulation.t | 236 +++++++++++++++++++++++++++++++++---------- 2 files changed, 194 insertions(+), 58 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Jul 26 03:24:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 26 Jul 2020 01:24:12 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.13-19-g2f054779c3 Message-ID: <E1jzVOe-0002vp-2R@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 2f054779c3e4affb01fed988a2c3f1e82cb7200c (commit) from eb8533a2b9439c935dd94d1f0204af43ac3a1477 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2f054779c3e4affb01fed988a2c3f1e82cb7200c Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 13:23:32 2020 +0100 Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 972aeaa0143dcdedc7ae23314a72991d5e4a6490) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 42e3ce7e921e4bd1b54095fd0631bdea2f24d73f) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit feff61b027eea1b1eccb0814dc69ec107ada48ad) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 25 ++++++++++------------ 1 file changed, 11 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Jul 26 17:28:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 26 Jul 2020 15:28:59 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.13-23-ga4938d1310 Message-ID: <E1jziaA-0004jj-Th@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a4938d13107f0d1e8bce91eab12dd23741c624d4 (commit) via 5d8d84bba2f1dfc293b5226b574395f5e0e3f3df (commit) via 181b4ecb3d6d2aa2ab5502b2c4e0a3d0e64488f3 (commit) via 8bd4cf0640780b8e4159c224a9e044fe81e9b83f (commit) from 2f054779c3e4affb01fed988a2c3f1e82cb7200c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a4938d13107f0d1e8bce91eab12dd23741c624d4 Author: Emmi Takkinen <emmi.takkinen at outlook.com> Date: Thu Mar 19 09:12:19 2020 +0200 Bug 4985: Fix Plack scope errors This patch 'ours' several variables to fix Plack scope errors in exceptionHolidays.pl. This also adds '@holidays_list' as parameter to 'edit_holidays'. Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit ee3f5d5a85d93dc36d6bdeab5f092c0098d604e1) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit b66500e424dd12a37fe418816947c56cba9134b4) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 760f1eaad5a426c5bd2436c072a2df401202e8e4) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 5d8d84bba2f1dfc293b5226b574395f5e0e3f3df Author: Emmi Takkinen <emmi.takkinen at outlook.com> Date: Fri Feb 7 12:43:54 2020 +0200 Bug 4985: Edit a calendar entry for all branches This patch adds functionality to calendar tool to make edits or deletes to all branches at once. To test: -Apply patch -Add holiday for a library and copy it to all or some libraries -Edit previosly made holiday (edit, delete etc.) and check out "Copy changes to all libraries." checkbox => Changes are made to all libraries sharing changed holiday Sponsored by: Koha-Suomi Oy Signed-off-by: Christofer <christofer.zorn at ajaxlibrary.ca> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit ce2219425d9b97952f5904024fb7575a0809487b) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 6f85f47365a1460d1e68280835d69008424fea45) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit dbb2717123362bf620184f3ac548d90918d6c1ce) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 181b4ecb3d6d2aa2ab5502b2c4e0a3d0e64488f3 Author: Hayley Mapley <hayleymapley at catalyst.net.nz> Date: Thu Jun 11 11:48:54 2020 +1200 Bug 25151: Fixing semantic headings in opac-basket.tt Test plan: 1) Apply the patch 2) Add items to your cart/folder/basket 3) Open up the basket and check that the main heading is now an h1 4) Check that the page looks fine Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f002bd17105bab2d16aee8db8ed4f6d688192fc3) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 987eb51a3330e69b018633d01ed987d9cf04dfb7) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 9c3412747c9a118345690a69feb4c15a7c757195) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 8bd4cf0640780b8e4159c224a9e044fe81e9b83f Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 13:05:31 2020 +0100 Bug 25239: Fix semantic heading for opac-reserve.tt Prior to this patch, the opac-reserve contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Attempt to place a hold on an item. 3/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 4/ Apply this patch and reload the page 5/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 1a96ede5f114bd90fe1735702ca4bab77dfed9d4) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 5574a5850f2a55a3544b3f9d5c95bf491aae4e03) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 94688f92512cb69812f558b74e283f0ae585dfea) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/tools/holidays.tt | 6 + .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 7 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- tools/exceptionHolidays.pl | 165 ++++++++++++--------- 4 files changed, 102 insertions(+), 78 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Jul 26 18:17:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 26 Jul 2020 16:17:23 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.13-28-g31900b557d Message-ID: <E1jzjL1-0006TF-Jb@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 31900b557d1bca3245f239a2856e2a7694a28ecb (commit) via d43a237884301163daed3e9a199347b42ce30dd5 (commit) via 9a64956e11b3492cfa3f57097fb6942f783805ea (commit) via 4e2a8c53c3d59d5927e2f668680ba565252341c0 (commit) via d363f0246809e1906b3af50f7c6a35abbb1e710c (commit) from a4938d13107f0d1e8bce91eab12dd23741c624d4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 31900b557d1bca3245f239a2856e2a7694a28ecb Author: Nick Clemens <nick at bywatersolutions.com> Date: Thu Jun 25 10:38:26 2020 +0000 Bug 25875: Move check for module_bit and code to the JOIN If we limit the JOIN to rows with the correct subpermission we won't duplicate the returned patrons To test: 1 - Give a patron full acquisitions permissions 2 - Also give them several subpermissions on other areas 3 - Go to Acquisitions 4 - Edit a fund 5 - Add a user to the fund 6 - Search for user above 7 - They return multiple times in results 8 - Apply patch 9 - Restart all the things 10 - Repeat search 11 - Patron appears once Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 721876785142fea84f02c7dbe4f325e2a605bd0f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 59e1e78c6d59ee6ced202382e2910676a4e32360) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 0cb156cba54e8433a3ea351a322f93c807a934e5) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit d43a237884301163daed3e9a199347b42ce30dd5 Author: Nick Clemens <nick at bywatersolutions.com> Date: Thu Jun 25 10:38:16 2020 +0000 Bug 25875: Unit test Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit a804d4be437a5df3641f854a506642afe3501046) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 7467f10ceb52696f263746d5495532e2b63b8f5b) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 512d0bfbd417e9e2d7f2e0e46882979138091e96) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 9a64956e11b3492cfa3f57097fb6942f783805ea Author: Slava Shishkin <slavashishkin at gmail.com> Date: Wed May 13 20:20:27 2020 +0300 Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm This warning was thrown: Use of uninitialized value $info{"invalid_username_or_password"} in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm line 387. There is the case when hash key can be undefined in numeric comparison. Fixed by adding additional precheck for $info{"invalid_username_or_password"} being Perl's "true". To test: 1) Go to the first page of the web-installer where it asks to login. 2) Observe the warning in the log file. 3) Apply patch. 4) Repeat step 1. 7) Check that previous warning suppressed. Mentored-by: Andrew Nugged <nugged at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d81438e143273a538c09cd16e7f92a83beed4027) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 3a3237da9c2f107a9d4e4a9e9383316ce10e6ecc) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 0d9ea88b86ea48142aabdb4eea6efb4b98eae3f1) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit 4e2a8c53c3d59d5927e2f668680ba565252341c0 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Thu Jun 18 09:01:36 2020 -0400 Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 017b67e6c52ab7b79a0187b1ca9fea220117f7ef) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit 18faf9b7aa7c313fd9fa086c5f9609ef7b0c70f5) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit f22bded52404114572988e445e1ca0398fa3227d) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> commit d363f0246809e1906b3af50f7c6a35abbb1e710c Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu Jun 18 16:54:42 2020 -0300 Bug 25805: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 115eeada2b6f959997d21d0e0dd73606f1ca7324) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> (cherry picked from commit c65e76a7c49720cf112c59a0583a9545b34844c4) Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> (cherry picked from commit 4a3486a7bcc06b05b664a69ba5e977988e7897e6) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> ----------------------------------------------------------------------- Summary of changes: C4/InstallAuth.pm | 2 +- C4/SIP/ILS/Item.pm | 6 ++--- C4/Utils/DataTables/Members.pm | 12 ++++++---- t/db_dependent/SIP/Message.t | 37 ++++++++++++++++++++++++++++++- t/db_dependent/Utils/Datatables_Members.t | 35 ++++++++++++++++++++++++++++- 5 files changed, 82 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 10:52:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 08:52:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-394-gb4f3a0f0a6 Message-ID: <E1jzysR-0002DT-Du@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b4f3a0f0a6e813716b7f3995e69998f3abf5cc1d (commit) from 8d56af377c158823497df17b2ef18637bbc11a1c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b4f3a0f0a6e813716b7f3995e69998f3abf5cc1d Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jul 27 10:12:35 2020 +0200 Compiled CSS (OPAC) This RM task has not been done when it was needed. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 17:47:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 15:47:23 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-32-gffa38dae12 Message-ID: <E1k05LX-0005uv-F0@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ffa38dae12c0c9a6b2f24589d1d581b2e3dfb10b (commit) from a48123c2131ba9f28f174e0cfc51807e1e42b9ad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ffa38dae12c0c9a6b2f24589d1d581b2e3dfb10b Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jul 21 11:18:16 2020 +0100 Bug 8338: (QA follow-up) Fix test for backdated return A test for CalculateFinesOnBackdate was introduced since this bug was written and needed updateing. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 56ee42082f0382d2b5e5a8cef081bef886664d7d) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Circulation/Returns.t | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 17:54:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 15:54:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-406-gbc1b76be4a Message-ID: <E1k05SN-000649-5V@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bc1b76be4a35403239fbce6f349ee343435cc8a0 (commit) via 40b6e1b8a1a6e74cb4e9a1c422ffa4faa0bdefc0 (commit) via 0ec7ba72861f21c2ce83d3a98446af7db7a3e321 (commit) via e025cd76437b212746717ad54b5da22e410bbe8f (commit) via 028e9a07db625845482eff1b550a9bbe86ec6fbc (commit) via 330c51c272d38831d1ba27ee39bd5ec2344b767a (commit) via 6fa926be88294bf8e14588dac0134eab506fdecb (commit) via f8e73978a246780296a304164e551f66430a2d8a (commit) via 2a57e3d3db5cf7680a7e199b3c9b26d2e6bb3abc (commit) via b38546f1d150edaf85180d4be2aa68df42674f27 (commit) via 757510c84c4427fb6a68c7d9bc1825c0a26a82cd (commit) via fcd659b2d4cf62df48113567c59392e8dff9696f (commit) from b4f3a0f0a6e813716b7f3995e69998f3abf5cc1d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bc1b76be4a35403239fbce6f349ee343435cc8a0 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Wed Sep 18 10:28:33 2019 -0400 Bug 23086: Search for collection is broken It appears that we are quoting the ccode values deep in the search code. Under ICU chains this breaks searching by limits To recreate 1 - Setup Koha using Zebra and icuchains 2 - Add ccode to AdvancedSearchTypes 3 - In koha-conf.xml set zebra debug level to include request <zebra_loglevels>none,fatal,warn,request,info</zebra_loglevels> 4 - Set some items into different ccodes 5 - On opac perform a search for: ccode:NFIC 6 - It works 7 - tail -n 50 /var/log/koha/kohadev/zebra-output.log 8 - Note search request like: Search biblios OK 26 1 1+0 RPN @attrset Bib-1 @attr 1=8009 NFIC 9 - On opac go to advanced search, select Collection, and limit to smae code a s above 10 - No results 11 - Check the zebra-output.log: Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @attr 1=8009 'NFIC' 12 - Apply patch 13 - Restart all 14 - Repeat search by collection limit 15 - Success! 16 - Check the zebra-output.log: Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @attr 1=8009 NFIC 17 - Add a new ccode value: N)N 18 - Set some items to that ccode 19 - Confirm searching by that ccode works Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 40b6e1b8a1a6e74cb4e9a1c422ffa4faa0bdefc0 Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jul 15 15:33:18 2020 +0000 Bug 23086: Unit test Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 0ec7ba72861f21c2ce83d3a98446af7db7a3e321 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Mon Jul 6 20:38:42 2020 +0000 Bug 25940: Check for reserve_id before Dopop TEST PLAN: 1. Have an item belonging to a different branch and check it in. 2. When the modal pops up hit 'Yes, print slip' or 'Print slip' if AutomaticItemReturn is set to 'don't' 3. The first print dialog should appear with a URL like '/cgi-bin/koha/circ/transfer-slip.pl?transferitem=18&&branchcode=CPL&op=slip' 4. Close that print dialog and you will immediately see another one that says 'No slip template found'. 5. Notice the URL of the second pop-up is: /cgi-bin/koha/circ/hold-transfer-slip.pl?reserve_id= 6. There is no reserve id so the template is not found. 7. Apply patch 8. Repeat 1-6 9. You should no longer have two print dialogs Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e025cd76437b212746717ad54b5da22e410bbe8f Author: Nick Clemens <nick at bywatersolutions.com> Date: Fri Jun 12 10:51:36 2020 +0000 Bug 25724: Do not call ModReserveStatus when completing transfer I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0 Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status. ModReserveStatus also calls CartToShelf regardless of what happens here. To test: 1 - Set UpdateItemLocationOnCheckin to: _ALL_: CART 2 - SetAutomaticItemReturn = Do 3 - Check an item in at a different branch than it's homebranch to create a transfer 4 - Check the item in at it's homebranch 5 - View the item details page 6 - Item is not in CART location 7 - Apply patch 8 - Repeat 9 - Item is in CART location after completion of transfer Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Jason Robb <jrobb at sekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 028e9a07db625845482eff1b550a9bbe86ec6fbc Author: Nick Clemens <nick at bywatersolutions.com> Date: Fri Jun 12 11:11:26 2020 +0000 Bug 25724: Unit tests Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Jason Robb <jrobb at sekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 330c51c272d38831d1ba27ee39bd5ec2344b767a Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Fri Jul 24 07:26:14 2020 -0400 Bug 24279: Disable editing lost status in items editor if item is a return claim Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 6fa926be88294bf8e14588dac0134eab506fdecb Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Tue May 26 07:27:28 2020 -0400 Bug 24279: Disable lost status select if item has a return claim Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit f8e73978a246780296a304164e551f66430a2d8a Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu May 7 12:33:17 2020 +0200 Bug 24279: Display the tip in the title of the option This patch tells select2 to retrieve the title attribute from the original option node. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 2a57e3d3db5cf7680a7e199b3c9b26d2e6bb3abc Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Thu Apr 23 09:04:25 2020 -0400 Bug 24279: (QA follow-up) Show values disabled with tooltips Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit b38546f1d150edaf85180d4be2aa68df42674f27 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Mon Dec 30 08:04:29 2019 -0500 Bug 24279: Claims Returned does not work when set from additem.pl Test Plan: 1) Configure Claimes Returned 2) Apply this patch 3) Go to additem.pl for that item 4) Note the claims returned lost status does not show in the lost status pulldown Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 757510c84c4427fb6a68c7d9bc1825c0a26a82cd Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Mon Dec 30 07:51:23 2019 -0500 Bug 24279: Claims Returned does not work when set from moredetail.pl Test Plan: 1) Configure Claimes Returned 2) Apply this patch 3) Go to moredetail.pl for that item 4) Note the claims returned lost status does not show in the lost status pulldown Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit fcd659b2d4cf62df48113567c59392e8dff9696f Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jul 27 15:15:44 2020 +0200 Bug 25729: Prevent Charges/Fees.t to fail on slow server We must use t::lib::Dates::compare to compare dates Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 -- C4/Search.pm | 3 +-- cataloguing/additem.pl | 26 +++++++++++++++++----- .../intranet-tmpl/prog/en/includes/select2.inc | 3 +++ .../prog/en/modules/catalogue/moredetail.tt | 17 +++++++++----- .../prog/en/modules/cataloguing/additem.tt | 8 +++++-- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 17 +++++++------- t/db_dependent/Circulation/issue.t | 12 +++++++++- t/db_dependent/Koha/Charges/Fees.t | 3 ++- t/db_dependent/Search.t | 8 ++++++- 10 files changed, 70 insertions(+), 29 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 18:19:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 16:19:38 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-36-g090c94f866 Message-ID: <E1k05qk-0006d1-7u@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 090c94f8669000e398c4ede36c1b01ebdef39dd7 (commit) via 39327abe751307c560597da084e5c179ddc179a5 (commit) via bb74ff618c9a1079c7e88ec0e4a569546abee5f4 (commit) via e58362b16a103b6bc215626ec77f908c1b7e55c8 (commit) from ffa38dae12c0c9a6b2f24589d1d581b2e3dfb10b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 090c94f8669000e398c4ede36c1b01ebdef39dd7 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Apr 29 12:19:46 2020 +0200 Bug 23070: Pass no_triggers => 1 to Koha::Objects->update To make sure we will update all the objects in one go (and no trigger the ->set->store from Koha::Object->update) Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 4b299f54aaed64f3ad4ff3a59eae743ed4f17c49) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 39327abe751307c560597da084e5c179ddc179a5 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jan 27 14:55:54 2020 +0100 Bug 23070: Increment all priorities in 1 query Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 6f6f88105db069fb365307f2e2ffaae11c863421) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit bb74ff618c9a1079c7e88ec0e4a569546abee5f4 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jan 27 14:53:23 2020 +0100 Bug 23070: Add tests Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c77f4496b2a9dbc26f59d467032eb74f0d27f328) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit e58362b16a103b6bc215626ec77f908c1b7e55c8 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jun 6 15:14:28 2019 -0500 Bug 23070: Use Koha::Hold in C4::Reserves::RevertWaitingStatus We are using raw SQL statements, we should use Koha::Hold instead. This patch does not seem optimal, we would like to increment priority in only 1 statement and without the need to fetch and loop all holds. == Test plan == - apply patch - place some holds on the same record - check that the priorities look good - mark one hold as waiting by doing a check-in - revert the waiting status - confirm that the priorities are recalculated correctly Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 563a25d952ee571eb1d626f97eef001c5f646b1f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 32 ++++++++++---------------------- t/db_dependent/Reserves.t | 45 ++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 54 insertions(+), 23 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 18:35:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 16:35:36 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-41-g3d627c3823 Message-ID: <E1k066C-000721-5T@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3d627c382319ecd2be731407964c4d98277ea2d0 (commit) via 917273a2f8997f244242dfd5db6029052eb283bb (commit) via fb8bd568512329ef2acb271b25dd74a449f06272 (commit) via 385e11ce1a4f7db322305b550e8b6f11363f1014 (commit) via 4c8a61d49bc0db7f52b76d1d277cb1adfb03fa82 (commit) from 090c94f8669000e398c4ede36c1b01ebdef39dd7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3d627c382319ecd2be731407964c4d98277ea2d0 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Mon Jul 27 16:03:12 2020 +0000 Bug 23148: DBRev 20.05.02.002 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 917273a2f8997f244242dfd5db6029052eb283bb Author: Julian Maurice <julian.maurice at biblibre.com> Date: Fri Jul 3 10:58:50 2020 +0400 Bug 23148: Fix bridge image paths in de-DE installer files Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d4975885b07db43777afb20dc19ef0e4851adc95) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit fb8bd568512329ef2acb271b25dd74a449f06272 Author: Owen Leonard <oleonard at myacpl.org> Date: Mon Jun 29 11:57:52 2020 +0000 Bug 23148: (follow-up) Correct image paths in sample data and tests Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 46372b4bbd6aafae9cb524717f17135cd236bffe) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 385e11ce1a4f7db322305b550e8b6f11363f1014 Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Jun 26 16:37:28 2020 +0000 Bug 23148: (follow-up) Replace gif files in the OPAC with pngs This patch removes the old gif files from the OPAC bridge set and replaces them with png files. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 3d3b207fe8bc2d398289bc81090e8d4e92152278) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 4c8a61d49bc0db7f52b76d1d277cb1adfb03fa82 Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Oct 11 16:14:33 2019 -0400 Bug 23148: Replace Bridge icons with transparent PNG files This patch adds SVG versions of the Bridge item type icon set to misc/interface_customization/itemtypeimg/bridge. It adds some new icons, and updates some existing icons. All GIF versions of the icons are replaced with transparent PNG files. Icon changes: - English text has been removed from all icons - New icon for "Periodical," to differentiate from "Journal" - New icon, "Controller" for video games - New icon for "Laserdisk" to differentiate from "DVD" - New icon for "Kit" to differentiate from "Archive" - New icon, "Reference books." - Updated "badges" on "Juvenile book" and "Reserve book" to try to express the information without English-specific letters. Before applying the patch, update some item types or collection codes with Bridge icons. Apply the patch and run the database update process. - Open the advanced search page in the staff client and confirm that your item type or collection code icons were updated correctly. - Go to Administration -> Item types and edit an item type. - Check the "bridge" tab and confirm that the icon options look correct. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 1625519b9e572e7c2dbe6af8ad813be5ff0a1458) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- .../data/mysql/de-DE/optional/sample_itemtypes.sql | 16 +- .../data/mysql/en/optional/sample_itemtypes.yml | 16 +- .../data/mysql/it-IT/optional/sample_itemtypes.sql | 14 +- .../mysql/nb-NO/2-Valgfritt/sample_itemtypes.sql | 14 +- .../data/mysql/pl-PL/optional/sample_itemtypes.sql | 14 +- .../mysql/ru-RU/optional/library_item_types.sql | 14 +- installer/data/mysql/updatedatabase.pl | 7 + .../prog/img/itemtypeimg/bridge/2d_art.gif | Bin 978 -> 0 bytes .../prog/img/itemtypeimg/bridge/2d_art.png | Bin 0 -> 1652 bytes .../prog/img/itemtypeimg/bridge/3d_art.gif | Bin 988 -> 0 bytes .../prog/img/itemtypeimg/bridge/3d_art.png | Bin 0 -> 1869 bytes .../prog/img/itemtypeimg/bridge/7Day_book.gif | Bin 1833 -> 0 bytes .../prog/img/itemtypeimg/bridge/7Day_book.png | Bin 0 -> 1735 bytes .../prog/img/itemtypeimg/bridge/archive.gif | Bin 986 -> 0 bytes .../prog/img/itemtypeimg/bridge/archive.png | Bin 0 -> 1086 bytes .../prog/img/itemtypeimg/bridge/audio.gif | Bin 1530 -> 0 bytes .../prog/img/itemtypeimg/bridge/audio.png | Bin 0 -> 802 bytes .../prog/img/itemtypeimg/bridge/book.gif | Bin 1051 -> 0 bytes .../prog/img/itemtypeimg/bridge/book.png | Bin 0 -> 1644 bytes .../prog/img/itemtypeimg/bridge/cd_music.gif | Bin 883 -> 0 bytes .../prog/img/itemtypeimg/bridge/cd_music.png | Bin 0 -> 1666 bytes .../prog/img/itemtypeimg/bridge/computer_file.gif | Bin 880 -> 0 bytes .../prog/img/itemtypeimg/bridge/computer_file.png | Bin 0 -> 504 bytes .../prog/img/itemtypeimg/bridge/controller.png | Bin 0 -> 1772 bytes .../prog/img/itemtypeimg/bridge/digital_audio.gif | Bin 1032 -> 0 bytes .../prog/img/itemtypeimg/bridge/digital_audio.png | Bin 0 -> 1778 bytes .../prog/img/itemtypeimg/bridge/dvd.gif | Bin 895 -> 0 bytes .../prog/img/itemtypeimg/bridge/dvd.png | Bin 0 -> 1660 bytes .../prog/img/itemtypeimg/bridge/dvd_play.png | Bin 0 -> 1651 bytes .../prog/img/itemtypeimg/bridge/e_book.gif | Bin 1145 -> 0 bytes .../prog/img/itemtypeimg/bridge/e_book.png | Bin 0 -> 1776 bytes .../prog/img/itemtypeimg/bridge/e_journal.gif | Bin 898 -> 0 bytes .../prog/img/itemtypeimg/bridge/e_journal.png | Bin 0 -> 1684 bytes .../prog/img/itemtypeimg/bridge/e_video.gif | Bin 1891 -> 0 bytes .../prog/img/itemtypeimg/bridge/e_video.png | Bin 0 -> 1320 bytes .../prog/img/itemtypeimg/bridge/journal.gif | Bin 1909 -> 0 bytes .../prog/img/itemtypeimg/bridge/journal.png | Bin 0 -> 1602 bytes .../prog/img/itemtypeimg/bridge/juvenile_book.gif | Bin 1869 -> 0 bytes .../prog/img/itemtypeimg/bridge/juvenile_book.png | Bin 0 -> 1786 bytes .../prog/img/itemtypeimg/bridge/kit.gif | Bin 878 -> 0 bytes .../prog/img/itemtypeimg/bridge/kit.png | Bin 0 -> 1408 bytes .../prog/img/itemtypeimg/bridge/laserdisk.gif | Bin 976 -> 0 bytes .../prog/img/itemtypeimg/bridge/laserdisk.png | Bin 0 -> 1667 bytes .../prog/img/itemtypeimg/bridge/map.gif | Bin 1333 -> 0 bytes .../prog/img/itemtypeimg/bridge/map.png | Bin 0 -> 1640 bytes .../prog/img/itemtypeimg/bridge/noncirc_book.gif | Bin 1887 -> 0 bytes .../prog/img/itemtypeimg/bridge/noncirc_book.png | Bin 0 -> 1865 bytes .../prog/img/itemtypeimg/bridge/noncirc_dvd.gif | Bin 1755 -> 0 bytes .../prog/img/itemtypeimg/bridge/noncirc_dvd.png | Bin 0 -> 1670 bytes .../prog/img/itemtypeimg/bridge/periodical.gif | Bin 977 -> 0 bytes .../prog/img/itemtypeimg/bridge/periodical.png | Bin 0 -> 1541 bytes .../prog/img/itemtypeimg/bridge/realia.gif | Bin 1662 -> 0 bytes .../prog/img/itemtypeimg/bridge/realia.png | Bin 0 -> 1862 bytes .../prog/img/itemtypeimg/bridge/reference.gif | Bin 1870 -> 0 bytes .../prog/img/itemtypeimg/bridge/reference.png | Bin 0 -> 1715 bytes .../img/itemtypeimg/bridge/reference_books.png | Bin 0 -> 1568 bytes .../prog/img/itemtypeimg/bridge/reserve_book.gif | Bin 1810 -> 0 bytes .../prog/img/itemtypeimg/bridge/reserve_book.png | Bin 0 -> 1736 bytes .../prog/img/itemtypeimg/bridge/score.gif | Bin 833 -> 0 bytes .../prog/img/itemtypeimg/bridge/score.png | Bin 0 -> 1239 bytes .../prog/img/itemtypeimg/bridge/software.gif | Bin 1792 -> 0 bytes .../prog/img/itemtypeimg/bridge/software.png | Bin 0 -> 1674 bytes .../prog/img/itemtypeimg/bridge/sound.gif | Bin 1041 -> 0 bytes .../prog/img/itemtypeimg/bridge/sound.png | Bin 0 -> 1747 bytes .../prog/img/itemtypeimg/bridge/tape_music.gif | Bin 1119 -> 0 bytes .../prog/img/itemtypeimg/bridge/tape_music.png | Bin 0 -> 1421 bytes .../prog/img/itemtypeimg/bridge/vhs.gif | Bin 836 -> 0 bytes .../prog/img/itemtypeimg/bridge/vhs.png | Bin 0 -> 843 bytes .../prog/img/itemtypeimg/bridge/vinyl_music.gif | Bin 1340 -> 0 bytes .../prog/img/itemtypeimg/bridge/vinyl_music.png | Bin 0 -> 1742 bytes .../prog/img/itemtypeimg/bridge/web.gif | Bin 1943 -> 0 bytes .../prog/img/itemtypeimg/bridge/web.png | Bin 0 -> 1867 bytes .../bootstrap/itemtypeimg/bridge/2d_art.gif | Bin 978 -> 0 bytes .../bootstrap/itemtypeimg/bridge/2d_art.png | Bin 0 -> 1652 bytes .../bootstrap/itemtypeimg/bridge/3d_art.gif | Bin 988 -> 0 bytes .../bootstrap/itemtypeimg/bridge/3d_art.png | Bin 0 -> 1869 bytes .../bootstrap/itemtypeimg/bridge/7Day_book.gif | Bin 1833 -> 0 bytes .../bootstrap/itemtypeimg/bridge/7Day_book.png | Bin 0 -> 1735 bytes .../bootstrap/itemtypeimg/bridge/archive.gif | Bin 986 -> 0 bytes .../bootstrap/itemtypeimg/bridge/archive.png | Bin 0 -> 1086 bytes .../bootstrap/itemtypeimg/bridge/audio.gif | Bin 1530 -> 0 bytes .../bootstrap/itemtypeimg/bridge/audio.png | Bin 0 -> 802 bytes .../bootstrap/itemtypeimg/bridge/book.gif | Bin 1051 -> 0 bytes .../bootstrap/itemtypeimg/bridge/book.png | Bin 0 -> 1644 bytes .../bootstrap/itemtypeimg/bridge/cd_music.gif | Bin 883 -> 0 bytes .../bootstrap/itemtypeimg/bridge/cd_music.png | Bin 0 -> 1666 bytes .../bootstrap/itemtypeimg/bridge/computer_file.gif | Bin 880 -> 0 bytes .../bootstrap/itemtypeimg/bridge/computer_file.png | Bin 0 -> 504 bytes .../bootstrap/itemtypeimg/bridge/controller.png | Bin 0 -> 1772 bytes .../bootstrap/itemtypeimg/bridge/digital_audio.gif | Bin 1032 -> 0 bytes .../bootstrap/itemtypeimg/bridge/digital_audio.png | Bin 0 -> 1778 bytes .../opac-tmpl/bootstrap/itemtypeimg/bridge/dvd.gif | Bin 895 -> 0 bytes .../opac-tmpl/bootstrap/itemtypeimg/bridge/dvd.png | Bin 0 -> 1660 bytes .../bootstrap/itemtypeimg/bridge/dvd_play.png | Bin 0 -> 1651 bytes .../bootstrap/itemtypeimg/bridge/e_book.gif | Bin 1145 -> 0 bytes .../bootstrap/itemtypeimg/bridge/e_book.png | Bin 0 -> 1776 bytes .../bootstrap/itemtypeimg/bridge/e_journal.gif | Bin 898 -> 0 bytes .../bootstrap/itemtypeimg/bridge/e_journal.png | Bin 0 -> 1684 bytes .../bootstrap/itemtypeimg/bridge/e_video.gif | Bin 1891 -> 0 bytes .../bootstrap/itemtypeimg/bridge/e_video.png | Bin 0 -> 1320 bytes .../bootstrap/itemtypeimg/bridge/journal.gif | Bin 1909 -> 0 bytes .../bootstrap/itemtypeimg/bridge/journal.png | Bin 0 -> 1602 bytes .../bootstrap/itemtypeimg/bridge/juvenile_book.gif | Bin 1869 -> 0 bytes .../bootstrap/itemtypeimg/bridge/juvenile_book.png | Bin 0 -> 1786 bytes .../opac-tmpl/bootstrap/itemtypeimg/bridge/kit.gif | Bin 878 -> 0 bytes .../opac-tmpl/bootstrap/itemtypeimg/bridge/kit.png | Bin 0 -> 1408 bytes .../bootstrap/itemtypeimg/bridge/laserdisk.gif | Bin 976 -> 0 bytes .../bootstrap/itemtypeimg/bridge/laserdisk.png | Bin 0 -> 1667 bytes .../opac-tmpl/bootstrap/itemtypeimg/bridge/map.gif | Bin 1333 -> 0 bytes .../opac-tmpl/bootstrap/itemtypeimg/bridge/map.png | Bin 0 -> 1640 bytes .../bootstrap/itemtypeimg/bridge/noncirc_book.gif | Bin 1887 -> 0 bytes .../bootstrap/itemtypeimg/bridge/noncirc_book.png | Bin 0 -> 1865 bytes .../bootstrap/itemtypeimg/bridge/noncirc_dvd.gif | Bin 1755 -> 0 bytes .../bootstrap/itemtypeimg/bridge/noncirc_dvd.png | Bin 0 -> 1670 bytes .../bootstrap/itemtypeimg/bridge/periodical.gif | Bin 977 -> 0 bytes .../bootstrap/itemtypeimg/bridge/periodical.png | Bin 0 -> 1541 bytes .../bootstrap/itemtypeimg/bridge/realia.gif | Bin 1662 -> 0 bytes .../bootstrap/itemtypeimg/bridge/realia.png | Bin 0 -> 1862 bytes .../bootstrap/itemtypeimg/bridge/reference.gif | Bin 1870 -> 0 bytes .../bootstrap/itemtypeimg/bridge/reference.png | Bin 0 -> 1715 bytes .../itemtypeimg/bridge/reference_books.png | Bin 0 -> 1568 bytes .../bootstrap/itemtypeimg/bridge/reserve_book.gif | Bin 1810 -> 0 bytes .../bootstrap/itemtypeimg/bridge/reserve_book.png | Bin 0 -> 1736 bytes .../bootstrap/itemtypeimg/bridge/score.gif | Bin 833 -> 0 bytes .../bootstrap/itemtypeimg/bridge/score.png | Bin 0 -> 1239 bytes .../bootstrap/itemtypeimg/bridge/software.gif | Bin 1792 -> 0 bytes .../bootstrap/itemtypeimg/bridge/software.png | Bin 0 -> 1674 bytes .../bootstrap/itemtypeimg/bridge/sound.gif | Bin 1041 -> 0 bytes .../bootstrap/itemtypeimg/bridge/sound.png | Bin 0 -> 1747 bytes .../bootstrap/itemtypeimg/bridge/tape_music.gif | Bin 1119 -> 0 bytes .../bootstrap/itemtypeimg/bridge/tape_music.png | Bin 0 -> 1421 bytes .../opac-tmpl/bootstrap/itemtypeimg/bridge/vhs.gif | Bin 836 -> 0 bytes .../opac-tmpl/bootstrap/itemtypeimg/bridge/vhs.png | Bin 0 -> 843 bytes .../bootstrap/itemtypeimg/bridge/vinyl_music.gif | Bin 1340 -> 0 bytes .../bootstrap/itemtypeimg/bridge/vinyl_music.png | Bin 0 -> 1742 bytes .../opac-tmpl/bootstrap/itemtypeimg/bridge/web.gif | Bin 1943 -> 0 bytes .../opac-tmpl/bootstrap/itemtypeimg/bridge/web.png | Bin 0 -> 1867 bytes .../itemtypeimg/bridge/2d_art.svg | 1 + .../itemtypeimg/bridge/3d_art.svg | 1 + .../itemtypeimg/bridge/7Day_book.svg | 1 + .../itemtypeimg/bridge/archive.svg | 1 + .../itemtypeimg/bridge/audio.svg | 1 + .../itemtypeimg/bridge/book.svg | 1 + .../itemtypeimg/bridge/cd_music.svg | 1 + .../itemtypeimg/bridge/computer_file.svg | 1 + .../itemtypeimg/bridge/controller.svg | 187 +++++++++++++ .../itemtypeimg/bridge/digital_audio.svg | 1 + .../itemtypeimg/bridge/dvd.svg | 1 + .../itemtypeimg/bridge/dvd_play.svg | 1 + .../itemtypeimg/bridge/e_book.svg | 1 + .../itemtypeimg/bridge/e_journal.svg | 1 + .../itemtypeimg/bridge/e_video.svg | 1 + .../itemtypeimg/bridge/journal.svg | 216 +++++++++++++++ .../itemtypeimg/bridge/juvenile_book.svg | 1 + .../itemtypeimg/bridge/kit.svg | 1 + .../itemtypeimg/bridge/laserdisk.svg | 1 + .../itemtypeimg/bridge/map.svg | 1 + .../itemtypeimg/bridge/noncirc_book.svg | 1 + .../itemtypeimg/bridge/noncirc_dvd.svg | 1 + .../itemtypeimg/bridge/periodical.svg | 1 + .../itemtypeimg/bridge/realia.svg | 147 +++++++++++ .../itemtypeimg/bridge/reference_book.svg | 292 +++++++++++++++++++++ .../itemtypeimg/bridge/reference_books.svg | 279 ++++++++++++++++++++ .../itemtypeimg/bridge/reserve_book.svg | 278 ++++++++++++++++++++ .../itemtypeimg/bridge/score.svg | 1 + .../itemtypeimg/bridge/software.svg | 1 + .../itemtypeimg/bridge/sound.svg | 1 + .../itemtypeimg/bridge/tape_music.svg | 1 + .../itemtypeimg/bridge/vhs.svg | 1 + .../itemtypeimg/bridge/vinyl_music.svg | 1 + .../itemtypeimg/bridge/web.svg | 1 + t/db_dependent/Search.t | 14 +- t/db_dependent/Suggestions.t | 16 +- 174 files changed, 1494 insertions(+), 60 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/2d_art.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/2d_art.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/3d_art.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/3d_art.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/7Day_book.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/7Day_book.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/archive.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/archive.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/audio.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/audio.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/book.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/book.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/cd_music.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/cd_music.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/computer_file.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/computer_file.png create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/controller.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/digital_audio.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/digital_audio.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/dvd.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/dvd.png create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/dvd_play.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/e_book.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/e_book.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/e_journal.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/e_journal.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/e_video.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/e_video.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/journal.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/journal.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/juvenile_book.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/juvenile_book.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/kit.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/kit.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/laserdisk.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/laserdisk.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/map.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/map.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/noncirc_book.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/noncirc_book.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/noncirc_dvd.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/noncirc_dvd.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/periodical.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/periodical.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/realia.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/realia.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/reference.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/reference.png create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/reference_books.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/reserve_book.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/reserve_book.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/score.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/score.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/software.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/software.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/sound.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/sound.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/tape_music.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/tape_music.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/vhs.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/vhs.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/vinyl_music.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/vinyl_music.png delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/web.gif create mode 100644 koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/bridge/web.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/2d_art.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/2d_art.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/3d_art.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/3d_art.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/7Day_book.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/7Day_book.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/archive.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/archive.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/audio.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/audio.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/book.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/book.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/cd_music.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/cd_music.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/computer_file.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/computer_file.png create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/controller.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/digital_audio.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/digital_audio.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/dvd.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/dvd.png create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/dvd_play.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/e_book.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/e_book.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/e_journal.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/e_journal.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/e_video.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/e_video.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/journal.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/journal.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/juvenile_book.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/juvenile_book.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/kit.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/kit.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/laserdisk.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/laserdisk.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/map.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/map.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/noncirc_book.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/noncirc_book.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/noncirc_dvd.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/noncirc_dvd.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/periodical.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/periodical.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/realia.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/realia.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/reference.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/reference.png create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/reference_books.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/reserve_book.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/reserve_book.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/score.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/score.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/software.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/software.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/sound.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/sound.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/tape_music.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/tape_music.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/vhs.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/vhs.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/vinyl_music.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/vinyl_music.png delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/web.gif create mode 100644 koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/bridge/web.png create mode 100644 misc/interface_customization/itemtypeimg/bridge/2d_art.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/3d_art.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/7Day_book.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/archive.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/audio.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/book.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/cd_music.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/computer_file.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/controller.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/digital_audio.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/dvd.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/dvd_play.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/e_book.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/e_journal.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/e_video.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/journal.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/juvenile_book.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/kit.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/laserdisk.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/map.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/noncirc_book.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/noncirc_dvd.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/periodical.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/realia.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/reference_book.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/reference_books.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/reserve_book.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/score.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/software.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/sound.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/tape_music.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/vhs.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/vinyl_music.svg create mode 100644 misc/interface_customization/itemtypeimg/bridge/web.svg hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 19:13:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 17:13:55 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-45-g0595b52147 Message-ID: <E1k06hH-0008HU-Ma@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 0595b52147273e21bbd41aefb111df3e2777d546 (commit) via 91cef9d977d81b24fdfc56dff35c7b3340a96db0 (commit) via cc7b196a827b78ad90d4359271e3b9fb3fd28395 (commit) via d0d6b45178e9161e54a537322388bfe29a848833 (commit) from 3d627c382319ecd2be731407964c4d98277ea2d0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0595b52147273e21bbd41aefb111df3e2777d546 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Tue Dec 3 15:16:57 2019 -0500 Bug 24165: Add ability to send any item field in a library chosen SIP field Some SIP devices need access to item fields that are not sent as item information in the checkin, checkout and item information responses. It makes sense to allow these fields to be sent in an arbitrary and configurable way, rather than hard code in each special case. Test Plan: 1) Apply this patch 2) Edit your SIP2 config file, add the following within the login stanza: <item_field field="XX" code="<item field 1>" /> <item_field field="XZ" code="<item fied 2>" /> where <item field 1> and <item field 2> are item table columns of your choosing 3) Using the sip cli emulator, run checkout, checkin and item information messages using that item. 4) Note the values you set for the item columns are sent in the corrosponding fields! Signed-off-by: Jill Kleven <jill.kleven at pueblolibrary.org> Fixed merge conflict with number of tests (was 5, changed to 7 which is correct) Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit ee838b171644e362cceae13ceb732d46a9a8e53b) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 91cef9d977d81b24fdfc56dff35c7b3340a96db0 Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Wed Jul 1 11:30:18 2020 +0000 Bug 23820: (QA follow-up) Make label clickable for checkbox By adding an id the checkbox is selected when the label is clicked enhancing usability. Also adds a colon : to the label. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f776354e33a1f2fc24cc0b1fb17132bc3d1c3813) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit cc7b196a827b78ad90d4359271e3b9fb3fd28395 Author: Agustin Moyano <agustinmoyano at theke.io> Date: Fri May 29 13:16:29 2020 -0300 Bug 23820: Add test for new behaviour To test: 1. prove t/db_dependent/api/v1/clubs_holds.t 2. Sign off Sponsored-by: Southeast Kansas Library - SEKLS Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 20395eefda56541e6cac8cd51dd6134b7a61486a) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit d0d6b45178e9161e54a537322388bfe29a848833 Author: Agustin Moyano <agustinmoyano at theke.io> Date: Mon Mar 30 18:56:18 2020 +0000 Bug 23820: Add checkout to default to patron's home branch on club hold This patch adds a checkbox to make holds created by club hold to default to patron's home branch if possible. To test: 1. Apply this patch 2. Create a club, and add two patrons (from now on called patron A and patron B) to it, each one form a different library.. 3. Create a hold for the club, and in the details set pickup location different from any of the patrons. 4. Check "Pickup at patron's home library when possible" checkbox SUCCESS => when submitted, pickup location of holds defaults to patron's home branch 5. Modify patron A's library and set pickup location to no. 6. Repeat steps 3 and 4. SUCCESS => when submitted, patron A's hold now points to pickup location setted on step 3, and patron B's hold still points to his home branch. 7. Sign off Sponsored-by: Southeast Kansas Library - SEKLS Signed-off-by: Jason Robb <jrobb at sekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 8ed09ff7de47e7752d2fcb0a5aff183e07f4e5f3) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Item.pm | 32 +++++++++++ C4/SIP/Sip/MsgType.pm | 5 ++ Koha/Club/Hold.pm | 27 +++++++-- Koha/REST/V1/Clubs/Holds.pm | 4 +- api/v1/swagger/paths/clubs.json | 4 ++ etc/SIPconfig.xml | 1 + .../prog/en/modules/reserve/request.tt | 7 +++ t/db_dependent/SIP/Message.t | 31 +++++++++- t/db_dependent/api/v1/clubs_holds.t | 67 +++++++++++++++++++--- 9 files changed, 162 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 19:17:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 17:17:15 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-46-g867b19c7df Message-ID: <E1k06kV-0008OH-MQ@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 867b19c7df5c8a837e8c9ce631a3e9d95f31060f (commit) from 0595b52147273e21bbd41aefb111df3e2777d546 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 867b19c7df5c8a837e8c9ce631a3e9d95f31060f Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Jul 21 10:08:02 2020 +0200 Bug 23820: Fix Koha/Club/Hold.t kohadev-koha at kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Club/Hold.t t/db_dependent/Koha/Club/Hold.t .. Patron(238) Hold cannot be placed. Reason: libraryNotPickupLocation at /kohadevbox/koha/Koha/Club/Hold.pm line 98. # Looks like you planned 5 tests but ran 4. t/db_dependent/Koha/Club/Hold.t .. 1/1 # Failed test 'add' # at t/db_dependent/Koha/Club/Hold.t line 86. Can't call method "borrowernumber" on an undefined value at t/db_dependent/Koha/Club/Hold.t line 83. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 4f5f5d88b98c2d1f6cc20bc6be6f5b41fb7d3c48) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Club/Hold.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 19:22:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 17:22:36 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-47-ge4d15dff4f Message-ID: <E1k06ph-0008WC-02@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e4d15dff4f0cbc6d67082b8e287ea0f5ecfa3e88 (commit) from 867b19c7df5c8a837e8c9ce631a3e9d95f31060f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e4d15dff4f0cbc6d67082b8e287ea0f5ecfa3e88 Author: Owen Leonard <oleonard at myacpl.org> Date: Wed Apr 1 16:06:33 2020 +0000 Bug 24625: Store showLastPatron information using localStorage This patch removes the use of jquery.cookie to store "last patron" information, using localStorage instead. jquery.cookie.js is obsolete. See Bug 24624. localStorage has been chosen as an alternative in this situation because it does not require transmission between the client and the server. See Bug 12410. Because there is no "session only" option with localStorage, additional handling of the showLastPatron data is added to the login page. That takes care of "stale" last patron information if user didn't log out but the session expired for some reason. To test apply the patch and enable the showLastPatron system preference. 1. Load a patron's account for checkout 2. Navigate away from patron-related pages: Perform a catalog search from the search header form and open the detail page from the search results. Confirm that the correct last patron information still shows. 3. Load another patron's account for checkout - There should now be a "Last patron" link in the breadcrumbs bar which links to the patron in step 1. Hovering your mouse over the link should display a tooltip containing the patron's name and card number. - Click the "X" to clear the last patron information. The last patron link should go away. 4. Log out and log back in. The last patron information should be gone. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit a512ae01fc7e17385e2d2dd42f53f79ae1f55d3a) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 2 + koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 52 ++++++++++++++----------- 2 files changed, 31 insertions(+), 23 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 19:26:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 17:26:15 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-50-g3a9597ea48 Message-ID: <E1k06tD-0000C7-G1@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3a9597ea481a6be3b32011aa0d0e317e4dec77dd (commit) via 482fc13558437013479b31e7a553fd0919ee97c5 (commit) via 7e224455099b0fd33a0c65e8d0647efa2d45419a (commit) from e4d15dff4f0cbc6d67082b8e287ea0f5ecfa3e88 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3a9597ea481a6be3b32011aa0d0e317e4dec77dd Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 10:14:03 2020 +0100 Bug 25155: (follow-up) Increase headings levels by 1 In the previous patch we reduced the headings levels by 2, but this was one level too many as we already have an H1 in the navbar and so all other heading sets should start at level 2 to semantically follow the title heading. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c9a0243f3abf407e1a89d7bfc125911cc153b3cc) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 482fc13558437013479b31e7a553fd0919ee97c5 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 09:32:45 2020 +0100 Bug 25155: Fixing semantic headings login modal The login modal headings were semantically incorrect prior to this patch. Test plan: 1) Click the 'Log in to your account' option to expose the modal 2) Use a headings inspector and note we jump from H1 (Page Title) -> H3 (Modal Title) 3) Apply the patch and reload the page. 4) Click the 'Log in to your account' option to expose the modal 5) The modal should still appear well formed 6) Use a headings inspector and note we jump from H1 (Page Title) -> H2 (Modal Title) -> H3 (Shibboleth title if enabled) Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 513b226873759ba3df6765dce635fe96cf5a51f3) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 7e224455099b0fd33a0c65e8d0647efa2d45419a Author: Hayley Mapley <hayleymapley at catalyst.net.nz> Date: Thu Jun 11 13:13:30 2020 +1200 Bug 25155: Fixing semantic headings in opac-auth.tt Test plan: 1) Follow test plan from comment #1 2) Apply the patch 3) Reload the page, and note that is still displays fine 4) Check that the main heading is now an h1, and that the other headings on the page make sense Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0bc47b5302fba91c1315acee5533ec5917df5761) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/includes/masthead.inc | 6 +++--- .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 22 +++++++++++----------- 2 files changed, 14 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 19:42:02 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 17:42:02 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-51-gbb805283f6 Message-ID: <E1k078U-0000jt-OM@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via bb805283f6094c0ba0988b574bd7ee8b5492f53f (commit) from 3a9597ea481a6be3b32011aa0d0e317e4dec77dd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bb805283f6094c0ba0988b574bd7ee8b5492f53f Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jun 11 12:45:57 2020 +0100 Bug 25237: Fix semantic heading for opac-details Prior to this patch the opac-details view contained semantically incorrect h3 headings for the author information. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that there are semantically incorrect headings H1 (Page title) > H2 (Item title) > H5 (Author) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and note that the semantically incorrect author block has been converted to a span with an 'h3' class for styling 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 6b49a70b94d6b5e0e2e1cde3025ade1278814925) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 19:45:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 17:45:11 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-53-g48ba19be8e Message-ID: <E1k07BX-0000w2-KC@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 48ba19be8e3351f665df8f4ccdde22b63ecab416 (commit) via 21be26f25b7f60c0cadfe247b8efc66cf733551b (commit) from bb805283f6094c0ba0988b574bd7ee8b5492f53f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 48ba19be8e3351f665df8f4ccdde22b63ecab416 Author: Julian Maurice <julian.maurice at biblibre.com> Date: Fri Jul 3 17:36:04 2020 +0400 Bug 25922: Fix typo 'arial-label' -> 'aria-label' Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 73ff914d5d537947b5fdc4cd602e79f41af5179a) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 21be26f25b7f60c0cadfe247b8efc66cf733551b Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jul 3 14:07:25 2020 +0100 Bug 25922: Add aria-label to the allowlist for translation This patch adds aria-label to the allowlist for translations. To test: - Apply patches from here and bug 25244 - kshell - cd misc/translator - perl translate update de-DE - Check for the aria-label in the diff - Verify the strings appear in the po files now - Translate them - perl translate install de-DE - Verify the translated strings appear in the template Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 280f1bdeb3cbec9f57d71e980490e32af61eecfb) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: misc/translator/tmpl_process3.pl | 6 +++--- misc/translator/xgettext.pl | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 19:48:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 17:48:04 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-54-gea51c1a865 Message-ID: <E1k07EK-000117-Bk@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ea51c1a865c20e29ab6c10bc017cbe40a1b314a3 (commit) from 48ba19be8e3351f665df8f4ccdde22b63ecab416 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ea51c1a865c20e29ab6c10bc017cbe40a1b314a3 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Mon Jun 29 15:55:17 2020 +0100 Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Bug 25244: (follow-up) QA corrections Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit d1a7112a9054305ead325daedd6bb106a31b346f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 19:53:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 17:53:40 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-56-g6c0bc74c85 Message-ID: <E1k07Jk-0001E8-Ry@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 6c0bc74c85fdfdf49f17e4f85015e9c0b749fd7e (commit) via 84caea12382e24fcfa6429a7e1a69e4a3043d70d (commit) from ea51c1a865c20e29ab6c10bc017cbe40a1b314a3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c0bc74c85fdfdf49f17e4f85015e9c0b749fd7e Author: Lucas Gass <lucas at bywatersolutions.com> Date: Mon Jul 27 17:23:20 2020 +0000 Bug 25984: Compile CSS Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 84caea12382e24fcfa6429a7e1a69e4a3043d70d Author: Owen Leonard <oleonard at myacpl.org> Date: Mon Jul 13 15:18:23 2020 +0000 Bug 25984: Add minimum height and width to shelf browser covers This patch adds a class to the shelf browser cover image links and a style for these links defining a minimum height and width. This allows the browser's default tab focus outline to be visible. This patch also adds a check for an enabled cover image service before displaying the cover image links. This patch introduces whitespace changes so diff accordingly. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the OPACShelfBrowser system preference. - Enable at least one cover image service (Amazon, Google, Coce, etc). - Locate a title in the OPAC which has items attached. - On the bibliographic detail page, click the "Browse shelf" link in the table of holdings to display the shelf browser. - Use the tab key to move the focus to cover images in the shelf browser. - Confirm that the focus outline moves through each cover link whether or not there is a cover image available. - Diable all cover image services. - Test the shelf browser again and confirm that it's not necessary to tap through an empty row. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit e722dd1725e113acd79dcb9e8eed2cd4da35aa33) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 6 ++ .../bootstrap/en/includes/shelfbrowser.inc | 80 +++++++++++----------- 3 files changed, 48 insertions(+), 40 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 19:55:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 17:55:58 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-57-g14ea1f8880 Message-ID: <E1k07Ly-0001Is-Gn@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 14ea1f8880fcd055efd0bfe425d9cb7bc240f16f (commit) from 6c0bc74c85fdfdf49f17e4f85015e9c0b749fd7e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 14ea1f8880fcd055efd0bfe425d9cb7bc240f16f Author: Owen Leonard <oleonard at myacpl.org> Date: Fri May 8 15:11:19 2020 +0000 Bug 25427: Make authority subfield management interface consistent MARC view This patch makes a couple of minor changes to the authority MARC subfield structure administration interface to make it more consistent with the corresponding MARC subfield interface. To test, apply the patch and go to Administration -> Authority types. - Pick an authority type to edit, for instance PERSO_NAME, and choose 'MARC structure' from the Actions menu. - Pick a tag to edit and select "Subfields" from the Actions menu. - In the table of subfields for that tag, each subfield in the first column should link to the edit interface for that subfield (its tab pre-selected). - The "Edit" button in that table should do the same. Signed-off-by: Heather Hernandez <heather_hernandez at nps.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f1f3117583a41d02f2ad794622f9becd469720f0) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/auth_subfields_structure.tt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 20:00:08 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 18:00:08 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-59-ga7c2683bf5 Message-ID: <E1k07Q0-0001Oy-3d@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via a7c2683bf551b186f17572b6d35b424ea7d84cdc (commit) via 771798f78eeb9dc811d4de6971fc303f83b205cd (commit) from 14ea1f8880fcd055efd0bfe425d9cb7bc240f16f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a7c2683bf551b186f17572b6d35b424ea7d84cdc Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jul 20 16:57:42 2020 +0200 Bug 25511: Add POD for --force Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0c0666c531133a4c743a50ee01a0aada84c2e3cf) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 771798f78eeb9dc811d4de6971fc303f83b205cd Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri May 15 10:51:46 2020 +0100 Bug 25511: Add --force option to update_dbix_class_files.pl This adds a --force option to the aforementioned script allowing those in the know to overwrite the schema when changes above the found are detected. Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 34666e26902facdc3bc7e46a7ecd539f69f813e5) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: misc/devel/update_dbix_class_files.pl | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 20:04:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 18:04:13 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-61-g5d25e77f8c Message-ID: <E1k07Tx-0001VY-K2@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5d25e77f8c4543d6b50f3f867efc4510f4b20667 (commit) via 131e9fd415c5b0d6d8923f234448647b7d0cff4b (commit) from a7c2683bf551b186f17572b6d35b424ea7d84cdc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5d25e77f8c4543d6b50f3f867efc4510f4b20667 Author: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Date: Wed Jul 8 17:24:46 2020 -0400 Bug 25718: Correct typo in additem.tt Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 2440d480ca24bd1d15731fbd32aec0ea3aa71086) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 131e9fd415c5b0d6d8923f234448647b7d0cff4b Author: David Nind <david at davidnind.com> Date: Sat Jun 27 00:38:46 2020 +0000 Bug 25717: Improve automatic renewal error messages Improve wording and grammar for automatic renewal error messages. Test plan: 1. Review the error message changes and make sure they make sense. The new message make sense to me. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 379fd6d838d9909ea5784011486f3d184766a833) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/renew_strings.inc | 8 ++++---- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 27 20:16:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Jul 2020 18:16:03 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-71-gd08b85cb89 Message-ID: <E1k07fP-0001kt-Gu@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via d08b85cb89ffd1333156615408f320d78fed1251 (commit) via 9b51c5eb98e8d1130322fbb71a1aefdbb58119ed (commit) via 221403e3a0ce329342ad5fb2f5b9a6c5b7ecf7a7 (commit) via 882d7a07b9b514801ec7dc335c86360e4a6cdbb6 (commit) via 210c246867a8b451931e7c4c2429d808c740c0d4 (commit) via 8cf7e47b2cd1341435f53db43dfc4bfcd957c558 (commit) via 955a5d77d0793cfbad950ac917beda5a2a9afe84 (commit) via 384df874d8e7e55165bd7e280b8e1c956977ee7b (commit) via 9a60e3934dae4f29cdfa6b6874b0a611db34b2dc (commit) via 30e01203284cc0f76e860644b3032799ccea2f2e (commit) from 5d25e77f8c4543d6b50f3f867efc4510f4b20667 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d08b85cb89ffd1333156615408f320d78fed1251 Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Date: Fri Jul 17 14:26:15 2020 +0000 Bug 25723: (QA follow-up) Remove unused module import The last usage of this module was removed in the commit "Bug 25723: Update cache flushing calls" but the import was not removed along with it. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit e8fe7de5be946735b59fdc5cd8e8c6b166ed2475) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 9b51c5eb98e8d1130322fbb71a1aefdbb58119ed Author: Nick Clemens <nick at bywatersolutions.com> Date: Fri Jul 17 12:34:18 2020 +0000 Bug 25723: (QA follow-up) Handle holiday and exception on same day When a holiday is entered, then exceptions generated on a range, there exists both a holiday and exception in the special holidays table. We should cache the exception over the holiday instead of both Also, !1 in perl returns '' rather than 0, so we should explicitly set the value Add blank line to clear pod error from qa tools Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Re-introduce the blank line mentioned in the commit message, it was accidentally removed by automatic formatting Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 223b603f08267f801860bf5deaaa1884e58eab1e) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 221403e3a0ce329342ad5fb2f5b9a6c5b7ecf7a7 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed Jun 17 14:04:14 2020 +0100 Bug 25723: (QA follow-up) Silent POD warning I didn't introduce the method that is warned about, but adding POD for it seemed reasonable and will silence the QA Script warning. Signed-off-by: Emma Perks <Emma.Perks2 at uhb.nhs.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 5851539424d04eda0da52ef8744925227dd6ce0f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 882d7a07b9b514801ec7dc335c86360e4a6cdbb6 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed Jun 17 13:46:34 2020 +0100 Bug 25723: Remove tests for removed method We removed the exception_holidays (and single_holidays) methods as part of this patchset. As such, we should no longer test them ;) Signed-off-by: Emma Perks <Emma.Perks2 at uhb.nhs.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 25f0d425eaa7c66953d02c5a5717b1b2abcb89a6) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 210c246867a8b451931e7c4c2429d808c740c0d4 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed Jun 17 13:18:24 2020 +0100 Bug 25723: Update cache flushing calls This patch updates the previous single_holidays and exeption_holidays cache flushing calls to match the new cache key structure of the updated routines. Signed-off-by: Emma Perks <Emma.Perks2 at uhb.nhs.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 61141c28b0fcbbb021371bb4c2dd8e818aec0691) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 8cf7e47b2cd1341435f53db43dfc4bfcd957c558 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Wed Jun 17 11:14:30 2020 +0100 Bug 25723: Use the same code for single and exception holidays This patch refactors is_exception_holiday and is_single_holiday to utilise a single _holidays method which combines the logic of the previous single_holidays and exception_holidays methods. As Koha::Calendar is instantiated at a branch level, we also move split the cache into branches too. Signed-off-by: Emma Perks <Emma.Perks2 at uhb.nhs.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit ae0b2befe8c9086df24469cb546c7c5f8d98de95) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 955a5d77d0793cfbad950ac917beda5a2a9afe84 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jun 12 16:30:28 2020 +0100 Bug 25723: Use a hasref for lookup Rather than using an array of dates and iterating them, use a hashref and do a direct lookup Signed-off-by: Emma Perks <Emma.Perks2 at uhb.nhs.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit e1dfe50522a01a7640fcca6e2a015206939579c9) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 384df874d8e7e55165bd7e280b8e1c956977ee7b Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jun 12 16:02:26 2020 +0100 Bug 25723: Drop DateTime::Set from cpanfile Signed-off-by: Emma Perks <Emma.Perks2 at uhb.nhs.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit cd862763c9654ded15c1a7d79fafb2ec73e4f20e) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 9a60e3934dae4f29cdfa6b6874b0a611db34b2dc Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jun 12 15:11:52 2020 +0100 Bug 25723: (follow-up) Fix Unit Test The unit test previously relied on the internals of exception_holidays. Signed-off-by: Emma Perks <Emma.Perks2 at uhb.nhs.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 5b2990d270fdde9fd7f69f6402db9ee171b6473e) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 30e01203284cc0f76e860644b3032799ccea2f2e Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jun 12 11:53:49 2020 +0100 Bug 25723: Drop DateTime::Set dependancy This patch removes our use of DateTime::Set and replaces it with a quick hashref implimentation Signed-off-by: Emma Perks <Emma.Perks2 at uhb.nhs.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0f0553da225052ff5b8b9bca7a386e04472f32da) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Calendar.pm | 29 +++---- Koha/Calendar.pm | 134 ++++++++++--------------------- cpanfile | 1 - t/Calendar.t | 19 +++-- t/db_dependent/Circulation.t | 12 ++- t/db_dependent/Circulation/CalcDateDue.t | 8 +- t/db_dependent/Holidays.t | 47 +---------- tools/newHolidays.pl | 5 -- 8 files changed, 88 insertions(+), 167 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jul 28 17:18:31 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Jul 2020 15:18:31 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-72-ga224b11688 Message-ID: <E1k0RN9-00014E-6b@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via a224b116882341fe4f0db09b456db1e20d8ad2e0 (commit) from d08b85cb89ffd1333156615408f320d78fed1251 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a224b116882341fe4f0db09b456db1e20d8ad2e0 Author: Mason James <mtj at kohaaloha.com> Date: Thu Jun 18 13:26:20 2020 +1200 Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 to test... 1/ attempt to install koha 20.05 package on deb11, fail :'( 2/ apply patch and build new koha package 3/ attempt to install new koha package on deb11, succeed! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 14932ae7d3bf864f64bffc9b1b015a07e11c8e2e) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Makefile.PL | 4 ++-- debian/control | 6 +++--- debian/control.in | 6 +++--- debian/templates/koha-conf-site.xml.in | 24 ++++++++++++------------ rewrite-config.PL | 2 +- 5 files changed, 21 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jul 28 17:26:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Jul 2020 15:26:32 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-75-g3e3eaab724 Message-ID: <E1k0RUu-0001Gq-5D@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3e3eaab724de9d0b0e74c96261f27be7cf311846 (commit) via f870e59a74d9ccfbde4f94c2385617cb78aea93a (commit) via 6be906d1d6948c3585f9656d825ab6a40e484f3d (commit) from a224b116882341fe4f0db09b456db1e20d8ad2e0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3e3eaab724de9d0b0e74c96261f27be7cf311846 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jul 17 07:44:45 2020 +0100 Bug 25998: (QA follow-up) Add DBIC level relation Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 997094cc38a46372777f39f0bfa249b87fe76d58) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit f870e59a74d9ccfbde4f94c2385617cb78aea93a Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Thu Jul 16 09:40:23 2020 +0100 Bug 25998: Add 'library' relation to Koha::Account::Line Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 16413beea6a2f5667a3a68971158ad1d7ea4b48a) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 6be906d1d6948c3585f9656d825ab6a40e484f3d Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Fri Jul 17 08:01:06 2020 +0100 Bug 25998: Add Unit Tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit e9927e729066be42a039b7e3f1abb5143820d1cb) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha/Account/Line.pm | 13 +++++++++++ Koha/Schema/Result/Accountline.pm | 20 +++++++++++++++++ t/db_dependent/Koha/Account/Line.t | 44 +++++++++++++++++++++++++++++++++++++- 3 files changed, 76 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jul 28 17:30:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Jul 2020 15:30:33 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-76-g3b25286a86 Message-ID: <E1k0RYn-0001P0-If@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3b25286a860c6d81627a1173515e65ac1d49984f (commit) from 3e3eaab724de9d0b0e74c96261f27be7cf311846 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3b25286a860c6d81627a1173515e65ac1d49984f Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Sat May 30 00:46:46 2020 +0000 Bug 25629: Fix capitalization in sample notices This fixes the capitalization in sample notices files to follow coding-guidelines. Only applies to English, translations remain unchanged. Additional fixes: - Overdues slip added the letter code as subject instead of the description - Opac changed to OPAC for self-registration verification emails German (de-DE) file was not changed, as there is a pending translation bug that will take care of these (bug 25129). To test: - Verify changes by running the web installer for the changed files and verify sample notices install without error - Verify subjects and notice descriptions are correct - Run tests in t/db_dependent/Letters* Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit dc2c19bd515a4ce4057b41b2ae2bb668d345c461) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../data/mysql/en/mandatory/sample_notices.yml | 80 +++++++++++----------- .../mysql/fr-CA/obligatoire/sample_notices.sql | 4 +- .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 4 +- installer/data/mysql/it-IT/necessari/notices.sql | 2 +- .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 7 +- .../data/mysql/pl-PL/mandatory/sample_notices.sql | 44 ++++++------ .../data/mysql/ru-RU/mandatory/sample_notices.sql | 46 ++++++------- .../data/mysql/uk-UA/mandatory/sample_notices.sql | 2 +- t/db_dependent/Letters/TemplateToolkit.t | 4 +- 9 files changed, 96 insertions(+), 97 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jul 28 17:34:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Jul 2020 15:34:55 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-77-g7802e319fc Message-ID: <E1k0Rd1-0001cH-3G@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7802e319fcf50fba97aecf9b3bcc7e3ab9f5e8fe (commit) from 3b25286a860c6d81627a1173515e65ac1d49984f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7802e319fcf50fba97aecf9b3bcc7e3ab9f5e8fe Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Wed Jul 1 06:53:18 2020 -0400 Bug 25907: When cancelling a waiting hold on returns.pl, looks for new hold to fill without rescanning barcode Right now, after canceling a hold on the checkin screen, a librarian needs to rescan the item barcode to check and trap the next hold. This is an extra unnecessary step. Test Plan: 1) Place two or more holds on a record 2) Check in the item 3) Confirm the hold 4) Check in the item again 5) Cancel the hold 6) Koha should now display the modal asking to confirm the next hold without the need to rescan the barcode! Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit b31fdc8f55007217f95980692114a5b0a9a85bc0) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jul 28 17:49:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Jul 2020 15:49:28 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-79-g5819ace6b5 Message-ID: <E1k0Rr6-0002Jo-Gb@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5819ace6b5419b206b58a7ecb9afc15def521dfa (commit) via 15d043d6a6d553dcb3de50e1bf31154dd7ec90a0 (commit) from 7802e319fcf50fba97aecf9b3bcc7e3ab9f5e8fe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5819ace6b5419b206b58a7ecb9afc15def521dfa Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Mon Jul 20 09:50:58 2020 -0300 Bug 25845: (QA follow-up) Call it REST API instead of just API Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 015ed932114ff48e944739afa9123d2501d65e14) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 15d043d6a6d553dcb3de50e1bf31154dd7ec90a0 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Tue Jun 23 11:06:55 2020 -0300 Bug 25845: Add 'api' to the log viewer interface options This patch simply adds the API option to the log viewer. To test: 1. Have BorrowersLog set 2. Update some patron using the API. For example curl --location --request PUT 'http://koha:koha at kohadev-intra.mydnsname.org:8081/api/v1/patrons/1' \ --header 'Content-Type: application/json' \ --data-raw '{ "firstname": "Tomasito", "surname": "None", "address": "Address", "category_id": "ST", "city": "Córdoba", "library_id": "MPL" }' 3. Open the log viewer => FAIL: There's no way to filter on interface, choosing API 4. Apply this patch 5. Reload the log viewer => SUCCESS: There are options to filter by 'API' interface => SUCCESS: Filtering by 'API' works 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 9b526483c65550c0f36eabad70055bed79a8197c) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jul 28 17:56:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Jul 2020 15:56:52 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-80-gf9bd821cf1 Message-ID: <E1k0RyG-0002jp-AA@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via f9bd821cf10c7ad88ae8d0ca71d9051bf5612eb6 (commit) from 5819ace6b5419b206b58a7ecb9afc15def521dfa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f9bd821cf10c7ad88ae8d0ca71d9051bf5612eb6 Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jul 8 14:24:37 2020 +0000 Bug 25955: Fix getting index_name To test: 1 - Have a site running ES 2 - perl misc/maintenance/compare_es_to_db.pl 3 - Lots of output, all bad 4 - Apply patch 5 - Repeate 6 - Whew, looks correct Signed-off-by: Didier Gautheron <didier.gautheron at biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 005219ea6fc53a52a41169e96024244abb394ee1) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: misc/maintenance/compare_es_to_db.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 30 18:14:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 30 Jul 2020 16:14:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-465-g3ae472ba5d Message-ID: <E1k1BCT-0001Jm-8H@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3ae472ba5d9b7bfe6c6e44320ca020c9cf111b01 (commit) via cc621836b26010986c85bd2cc986ff71b77bb28d (commit) via 5cd1c1e03290ae7be214dd92083e1377eadd3c1f (commit) via c2111c1ce6532b73af3a4847500be8f305db570a (commit) via 773b88e9c20c17ea70aa285d12c8e4e03923d15d (commit) via 9b9e8fd32852acceb10cfc54d4a5a3acc0f6e232 (commit) via 9deaf86754c9d6aa0b4a2cb688b497bd6b03b67f (commit) via 9e0d097a5692af07db020e6f806eeaa97d43ae1e (commit) via 23846781751d7fb808b3fa4b857da72706653575 (commit) via 5bec404420c6dd9251b511d12e2425e5a6039a95 (commit) via 980dd605031e616f1d481852dffe9cc6779eb3e3 (commit) via e68fe2a928bec05b9602fa28dfbc86e04657ce81 (commit) via 0a37a026e3eaa4da57b467d506147849e137781e (commit) via 80077c44f9eeea537f0085e33329fc40eabb5f9d (commit) via 07d00ee029dfddd1aed1b4e45ac04ed92e73f708 (commit) via a351d056c597e3a925500527e2d8ecd49d02c430 (commit) via 89551241dbf3712fa9e582627855f1a859edeeb6 (commit) via 77058c7d6ba4f13c64b5f48a7028692bcfa5b968 (commit) via 2fac4017b78d5da9b20b7e73a9f75ecad7f94a67 (commit) via 33f4bc949e22cca9eb6ee590e044ac708f80966a (commit) via a8b95985847d38296abd1961ca8e05115b563dc7 (commit) via 7e86c994110c8b43e67b1bf152bb44f9e1468df6 (commit) via 3d0da68d5ada37b40099fbc11b63202ccf7a48b2 (commit) via 7c8276bf0e64a2dc90af4aab0d6e78893edc12b1 (commit) via 8ecaedc22db5a25db6ffa98e6a7fc2e7039656c7 (commit) via ab015f04dcd4956ca1ccd610d085e8b0c17ca733 (commit) via 58be086a18e39068fd12dfeef677f982ae735a73 (commit) via 50302c714ed287b06574b8e18f4b33e4df42ee91 (commit) via db74e67bc52b2f3af8efd2243f6ab02fd6568de2 (commit) via 67c54c2c23be60df3efd1c7428ba870c0d5192f8 (commit) via a658db8f7e8d94b463bc6f064753f4ad2aaa48e9 (commit) via 614b64ed170163ac618ea4bec16ea8c92b28c680 (commit) via 536471ec0775d32939d7ef3044df891702827f3a (commit) via 2751defa7ca09cc5040021012dd503464ecf1b32 (commit) via d7392cad470f5809475ccb731e6a229a0bc9504d (commit) via 625ba7a2aa01ef6efbaceb686bcdbcebe98e012f (commit) via 0f54ace6711c9035b267474c2f1ab69570f977b8 (commit) via 9319c8879fdd796d7293beca8f5017a4024bdbd9 (commit) via e5e058e39fa97e5732f514ded46128b666bfba99 (commit) via 04afc1678a4e2b642de4c07402329248c7fc2137 (commit) via d8c137a718cdb344b2910f449e3a8a73e4362263 (commit) via 9932ce33156305d7ebe3c8192bda8f1450f20b2a (commit) via 2ac260ca6c0716c47d7138aeeeabb80a50599f75 (commit) via b78356cafd066cfe37366ca19e2556f69da200be (commit) via 7e9d01d0fa75017698e6558f19105b7446821267 (commit) via 9676f537a448d50770c90d9d5a8b420a1f302444 (commit) via 50ebed51ee160992e22cde55dcd657beb7429f8f (commit) via 5aba38fdaec2958a23f0ccaa57b4c951af1244ce (commit) via 110e0acb5c33f96b9cb61286fc45d480b088f565 (commit) via 4b6d8bb0b6e0fc1e78ffa063740ca605e0efc367 (commit) via 6638e9de8c405e119a3816516a3340e84f5d8793 (commit) via 6b984a0feb29aede7a569dddd6aae35b13eed5cf (commit) via 7fb8f3638859b1e27c2954363b175030fadbee17 (commit) via 41c6940fcdb6522efef68430dcf88683e1831e63 (commit) via d3c8b8fe54b999a6d7f10ab6f6cc49db96edfd53 (commit) via f10acb07e68f10a69e087012e47ae210cd609783 (commit) via 8f7bf2a6b4ab8d4d0be3b522753a8fd17d9fc54f (commit) via 5e45076c00b2f72537ba9c81c4535253f1aaadfb (commit) via 00a3aa21e86719dd702215150a4571219c434ddd (commit) from bc1b76be4a35403239fbce6f349ee343435cc8a0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3ae472ba5d9b7bfe6c6e44320ca020c9cf111b01 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Wed Jul 29 13:03:57 2020 -0400 Bug 26083: Item editor defaults to lost When editing an item via additem.pl, koha defaults to the first available lost status, rather than defaulting to not-lost. Test Plan: 1) Ensure you do not have a value ClaimReturnedLostValue 2) Edit an existing item that is not lost 3) Note the lost value is set even though it is not lost 4) Apply this patch 5) Edit a different item that is not lost 6) Note the lost value is not set! Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit cc621836b26010986c85bd2cc986ff71b77bb28d Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 30 17:40:28 2020 +0200 Bug 26061: Compiled CSS Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 5cd1c1e03290ae7be214dd92083e1377eadd3c1f Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Jul 24 15:59:42 2020 +0000 Bug 26061: Improve style of sidebar datepickers This patch makes a small change to the staff interface CSS so that datepicker form fields in sidebar forms don't force the datepicker icon onto a second line. The change uses the CSS calc() function to specify that form fields with a .hasDatepicker class (dynamically added by jqueryUI) have a width of 100% minus 20 pixels, leaving room for the datepicker icon. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface). - View a page in the staff interface which has a datepicker field in a sidebar form and confirm that the icon stays on the same line as the firm field at varying browser widths. Examples: - Reports -> Saved SQL reports - Circulation -> Overdues - Acquisitions -> Late orders Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit c2111c1ce6532b73af3a4847500be8f305db570a Author: David Cook <dcook at prosentient.com.au> Date: Wed Jul 8 12:36:46 2020 +0000 Bug 25953: Add ID to installed plugins table on plugins-home.pl This patch adds a "installed_plugins" ID to the table of installed plugins. The idea is that it will ease styling and DOM mods through Javascript. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 773b88e9c20c17ea70aa285d12c8e4e03923d15d Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 30 15:21:50 2020 +0000 Bug 26070: DBRev 20.06.00.020 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9b9e8fd32852acceb10cfc54d4a5a3acc0f6e232 Author: Owen Leonard <oleonard at myacpl.org> Date: Mon Jul 27 19:16:07 2020 +0000 Bug 26070: Remove GoogleIndicTransliteration system preference The Google Transliterate API was deprecated on May 26, 2011. This patch removes the feature and associated system preference. To test, apply the patch and run the database update process. - Go to Administration -> System preferences and search for 'GoogleIndicTransliteration.' There should be no results. - Search the Koha codebase for references to 'GoogleIndicTransliteration.' There should be no current references.. Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9deaf86754c9d6aa0b4a2cb688b497bd6b03b67f Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 30 15:21:50 2020 +0000 Bug 22660: DBRev 20.06.00.019 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9e0d097a5692af07db020e6f806eeaa97d43ae1e Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Wed Jul 29 22:51:34 2020 +0000 Bug 22660: (QA follow-up) Fix capitalization in system preference Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 23846781751d7fb808b3fa4b857da72706653575 Author: Owen Leonard <oleonard at myacpl.org> Date: Thu Jul 23 18:20:51 2020 +0000 Bug 22660: (follow-up) Re-word system preference description This patch rewords the system preference description to focus on the generic description of the editor rather than the name of the plugin: tinymce: "a WYSIWYG editor (TinyMCE)" codemirror: "a text editor (CodeMirror)" Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 5bec404420c6dd9251b511d12e2425e5a6039a95 Author: Owen Leonard <oleonard at myacpl.org> Date: Thu Jul 23 17:58:22 2020 +0000 Bug 22660: (follow-up) Improve asset handling, add linting This patch makes some changes to the way assets are included based on the value of the system preferece in order to minimize unnecessary JavaScript includes. The patch also adds HTML syntax-highlighting and linting like we have in the system preferences editor. Removed are two JS files which were not required. To test, apply the patch and set the NewsToolEditor preference to "CodeMirror." - Edit a news item and confirm that the contents of the editor show HTML syntax highlighting. - Test HTML linting by adding some malformed HTML (missing closing tag, for instance). The error should be highlighted. - Set the NewsToolEditor to "TinyMCE" and confirm that WYSIWYG editing still works correctly. https://bugs.koha-community.org/show_bug.cgi?id=22600 Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 980dd605031e616f1d481852dffe9cc6779eb3e3 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri May 8 22:57:40 2020 +0000 Bug 22660: Add system pref to allow switching of editors in News Tool This patch adds a system preference called 'NewsToolEditor' which allows for the choice between TinyMCE and CodeMirror in the News Feature. TEST PLAN: 1. Apply patch and run updatedatabase 2. Go to Tools > News and make a new entry or edit an existing News item. 3. When you initially load you should gte the TinyMCE editor (WYSIWYG) 4. Search for the NewsToolEditor system preference and switch to CodeMirror. 5. Reload your News item and now you should see the CodeMirror editor. 6. Try saving content with both and maki sure it works. 7. Try adding some different HTML tags in CodeMirror mode, saving, and making sure it looks right when you switch back to TinyMCE Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e68fe2a928bec05b9602fa28dfbc86e04657ce81 Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Jul 10 13:19:14 2020 +0000 Bug 25968: Make logs sort by date descending as a default This patch adds DataTables with columns configuration to the log viewer. The table of log entries is now sorted by default by date descending. To test, apply the patch and go to Administration -> Table settings. - Expand the "Tools" section and confirm that there is a section for "logviewer." - Go to Tools -> Log viewer. - Perform a search which will return multiple results. - Confirm that the results are sorted by date descending. - Test that the table controls work correctly: Paging, columns, export. - Return to the Table settings administration page and test that changes to those settings are correctly reflected in the log viewer table. Signed-off-by: barbara <barbara.johnson at bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> JD amended patch: Fix indentation in .yml to match other entries Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 0a37a026e3eaa4da57b467d506147849e137781e Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 30 17:40:18 2020 +0200 Bug 22087: Compiled CSS Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 80077c44f9eeea537f0085e33329fc40eabb5f9d Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jul 27 15:37:21 2020 +0200 Bug 22087: Add missing filters Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 07d00ee029dfddd1aed1b4e45ac04ed92e73f708 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Apr 7 12:40:26 2020 +0200 Bug 22087: Move the email into the list Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit a351d056c597e3a925500527e2d8ecd49d02c430 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Apr 7 12:40:24 2020 +0200 Bug 22087: Remove padding on li's Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 89551241dbf3712fa9e582627855f1a859edeeb6 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Apr 7 12:01:05 2020 +0200 Bug 22087: Prevent variable names colision We should not use PROCESS: http://www.template-toolkit.org/docs/manual/Directives.html " The PROCESS directive is slightly faster than INCLUDE because it avoids the need to localise (i.e. copy) the variable stash before processing the template. " The 'patron' variable is reused by patron-title.inc Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 77058c7d6ba4f13c64b5f48a7028692bcfa5b968 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Apr 6 16:25:34 2020 +0200 Bug 22087: Add a no_line_break parameter to prevent new lines Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 2fac4017b78d5da9b20b7e73a9f75ecad7f94a67 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Apr 6 16:14:04 2020 +0200 Bug 22087: Add space between zipcode and country Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 33f4bc949e22cca9eb6ee590e044ac708f80966a Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Apr 6 16:00:13 2020 +0200 Bug 22087: Use include file to display patrons address in search result In order to display the city and country in the patron search result, we need to use the member-display-address-style include file, to satisfy AddressFormat. Test plan: Modify some patrons and fill the different address info Search for them and notice that the city, zipcode and country are now displayed. Modify the value of AddressFormat and confirm that the display is modified according to its value Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit a8b95985847d38296abd1961ca8e05115b563dc7 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 30 17:40:02 2020 +0200 Bug 26060: Compiled CSS Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 7e86c994110c8b43e67b1bf152bb44f9e1468df6 Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Jul 24 14:07:29 2020 +0000 Bug 26060: Replace staff interface table sort icons with SVG This patch modifies the staff interface CSS to convert table sorting icons from PNG to SVG. These icons are added via background-image data-urls, so only the SCSS file is modified. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface). - Clear your browser cache if necessary - View any DataTable in the staff interface, for instance when checking out to a patron with existing checkouts, the catalog detail page for a title with holdings, the table of saved reports. - Confirm that the sorting icons in the table headers look correct in each state: Sorted ascending, sorted descending, and unsorted. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 3d0da68d5ada37b40099fbc11b63202ccf7a48b2 Author: Didier Gautheron <didier.gautheron at biblibre.com> Date: Sun Jul 12 14:09:15 2020 +0200 Bug 25982: OPAC shelves RSS link output is xml Output rss feed as text/xml Test plan: 1) have books entered 2) log in create a list 3) add books to list 4) display list in OPAC 5) click the RSS link button. -- output is displayed as html text 6) apply patch 7) repeat steps 4&5 -- output is displayed as xml tree Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 7c8276bf0e64a2dc90af4aab0d6e78893edc12b1 Author: Owen Leonard <oleonard at myacpl.org> Date: Thu Jun 18 13:10:35 2020 +0000 Bug 25351: Move cart-related strings out of opac-bottom.inc and into basket.js This patch adds the necessary JavaScript includes to the OPAC to enable translation of strings in JavaScript. It also updates the translation of cart-related strings by removing the strings from opac-bottom.inc and putting them in basket.js where they are used. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from bootstrap/js/basket.js for translation, e.g.: #: koha-tmpl/opac-tmpl/bootstrap/js/basket.js:89 msgid "Your cart is currently empty" msgstr "" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR In the OPAC, switch to the language you're testing. Confirm that your translated string appears. In the above example, by clicking the "Cart" icon in the header when there are no items in the cart. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 8ecaedc22db5a25db6ffa98e6a7fc2e7039656c7 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Jul 28 09:23:35 2020 +0200 Bug 21268: Don't remove 0 allocated funds from fund list If a fund is created with a amount of 0, it will not appear in the fund list (when a new order is created for instance). 0 allocated funds can be used to track donations and other situations where there is not an expected amount for the year. Test plan: 0. Do not apply the patch 1. Create 1 active and 1 inactive budgets 2. Create some funds for each budgets, with amount > 0 and amount == 0 3. Add orders to basket => Note that the funds with amount == 0 are not displayed 4. Apply the patch 5. Add orders to basket (using the different possible ways we have) => Note that the funds with amount == 0 are displayed This change is applied to the different views of the acquisition module. Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit ab015f04dcd4956ca1ccd610d085e8b0c17ca733 Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Sat May 23 01:12:22 2020 +0200 Bug 25499: Fix fund code column when closing a budget When closing a budget the fund code column in the table is always empty. This is due to a TT variable not being correct. To test: - Create a budget and fund - Order anything, leave basket open or not, but don't receive - Duplicate your existing budget - Close the first budget in order to move the pending orders - Verify the fund code is not showing in the table - Apply patch and reload the patch - Verify fund codes are now showing correctly Bonus: Changes the column heading Fund id to Fund ID. Signed-off-by: Abbey Holt <aholt at dubuque.lib.ia.us> Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 58be086a18e39068fd12dfeef677f982ae735a73 Author: Mason James <mtj at kohaaloha.com> Date: Fri Jul 3 23:42:02 2020 +1200 Bug 25920: Add liblocale-codes-perl package to fix ubuntu-stable (focal) to test on ubuntu-20... 1/ install koha-common pkg $ sudo apt install koha-common 2/ confirm liblocale-codes-perl pkg is not installed :( $ apt-cache policy liblocale-codes-perl | grep Installed Installed: (none) 3/ apply patch 4/ build and install new koha-common pkg 5/ confirm liblocale-codes-perl pkg is now installed :) $ apt-cache policy liblocale-codes-perl | grep Installed Installed: 3.62-1 Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 50302c714ed287b06574b8e18f4b33e4df42ee91 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Jul 29 15:11:24 2020 +0200 Bug 26063: Use Koha::Plugins->call for some other hooks Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit db74e67bc52b2f3af8efd2243f6ab02fd6568de2 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Jul 24 16:00:52 2020 -0300 Bug 26063: Use Koha::Plugins->call for circulation hooks This patch gets rid of a helper method used for calling the plugin hooks. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 67c54c2c23be60df3efd1c7428ba870c0d5192f8 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu Jul 23 11:52:57 2020 -0300 Bug 21468: (QA follow-up) Simplify payload This patch simplifies the payload as suggested on bug 25855. It also keeps some specific params that cannot be deduced from the passed checkout object, (e.g. if it is an onsite checkout). Tests are cleared and added for this special exceptions. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit a658db8f7e8d94b463bc6f064753f4ad2aaa48e9 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Wed Jul 15 02:26:20 2020 -0300 Bug 21468: (QA follow-up) Enhance tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 614b64ed170163ac618ea4bec16ea8c92b28c680 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Mon Jul 6 13:46:47 2020 +0100 Bug 21468: Add 'checkin' action for _after_circ_actions Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 536471ec0775d32939d7ef3044df891702827f3a Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Mon Jul 6 13:46:15 2020 +0100 Bug 21468: Unit tests for AddReturn Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 2751defa7ca09cc5040021012dd503464ecf1b32 Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Mon Jul 6 09:44:11 2020 +0100 Bug 21468: Add 'checkout' action for _after_circ_actions This patch adds a call to _after_circ_actions into AddIssue and passes an appropriate payload for plugins to utilise after issuing items. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit d7392cad470f5809475ccb731e6a229a0bc9504d Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Mon Jul 6 11:43:25 2020 +0100 Bug 21468: Unit tests for AddIssue This patch adds a unit test for the addition of a call to the _after_circ_action hook in AddIssue. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 625ba7a2aa01ef6efbaceb686bcdbcebe98e012f Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Jul 24 15:42:17 2020 -0300 Bug 24031: (QA follow-up) Add tests for the AddReserve intervention This patch adds tests for AddReserve Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 0f54ace6711c9035b267474c2f1ab69570f977b8 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Fri Jul 17 11:32:57 2020 -0400 Bug 24031: Add hook to test plugin with unit test Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9319c8879fdd796d7293beca8f5017a4024bdbd9 Author: Julian Maurice <julian.maurice at biblibre.com> Date: Fri May 22 12:29:11 2020 +0200 Bug 24031: Add safety checks in Koha::Plugins::call - Check that the plugin has the method before calling it - Call the method in an eval block to prevent fatal errors Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e5e058e39fa97e5732f514ded46128b666bfba99 Author: Julian Maurice <julian.maurice at biblibre.com> Date: Fri May 22 12:28:17 2020 +0200 Bug 24031: Remove check for syspref UseKohaPlugins UseKohaPlugins has been removed by bug 20415 Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 04afc1678a4e2b642de4c07402329248c7fc2137 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Thu Nov 21 08:08:38 2019 -0500 Bug 24031: Fix warnings Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit d8c137a718cdb344b2910f449e3a8a73e4362263 Author: Julian Maurice <julian.maurice at biblibre.com> Date: Wed Nov 13 11:11:54 2019 +0100 Bug 24031: Add plugin hook after_hold_create It is called after a hold has been placed Test plan: 1. Write a plugin that implements only after_hold_create (see `perldoc Koha::Plugins` for implementation details). Install it and enable it 2. Place a hold and verify that your plugin method has been called with the right parameters Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9932ce33156305d7ebe3c8192bda8f1450f20b2a Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Thu Jul 23 11:00:11 2020 -0300 Bug 25855: (QA follow-up) Simplify payload This patch makes the hook be passed the Koha::Checkout object instead of a hand-crafted list of attributes. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 2ac260ca6c0716c47d7138aeeeabb80a50599f75 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Jul 3 10:26:06 2020 -0300 Bug 25855: (QA follow-up) Generalize hook and simplify tests This patch generalizes the hook so it can be used by other circulation actions. Tests are also simplified by mocking some of the (extensive) plugin hooks. To test: 1. Repeat the test plan on the original patch => SUCCESS: All good 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit b78356cafd066cfe37366ca19e2556f69da200be Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Tue Jun 23 16:23:06 2020 -0300 Bug 25855: Add a post_renewal_action plugin hook This patch adds a new hook to notify plugins about renewal actions. To test it: 1. Apply the unit tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => FAIL: The tests expect some warnings to show, and they don't (i.e. the sample plugin hook is not being called). 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! The hook is being called on renewal! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 7e9d01d0fa75017698e6558f19105b7446821267 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Tue Jun 23 16:18:54 2020 -0300 Bug 25855: Unit tests This patch adds tests fr a new circulation hook for plugins. In this case the post_renewal_action hook, The tests add the hook to the Test plugin, and verify that all the required parameters are passed for the plugin hook to use them. It relies on throwing an exception that is to be caught. Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9676f537a448d50770c90d9d5a8b420a1f302444 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Wed Jul 8 16:54:51 2020 -0300 Bug 25961: Add hooks for plugins to inject variables to OPAC XSLT This patch adds the following plugin hooks: - opac_results_xslt_variables - opac_detail_xslt_variables This hooks will inject variables returned by the plugin in the form of a hashref, into the ones that are passed to the XSLT processing code. To test: 1. Apply the 'DO NOT PUSH' commit 2. Install the Kitchensink plugin 3. Restart all 4. Search biblios in the OPAC => SUCCESS: A text is injected in front of the biblio title 5. Enter the detail page of any of the results => SUCCESS: A text is injected in front of the biblio title 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 50ebed51ee160992e22cde55dcd657beb7429f8f Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 30 15:21:50 2020 +0000 Bug 24157: DBRev 20.06.00.018 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 5aba38fdaec2958a23f0ccaa57b4c951af1244ce Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Jul 24 13:03:31 2020 +0200 Bug 24157: Handle the case where logged in user does not have edit_invoices This patch make possible the reopening and merging of invoices even if the logged in user does not have the edit_invoices permission I don't think it really makes sense but at least it's now possible. Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 110e0acb5c33f96b9cb61286fc45d480b088f565 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Jul 21 11:09:50 2020 +0200 Bug 24157: (follow-up) New permission - delete_invoices Hide the "Delete" invoice link if necessary on /cgi-bin/koha/acqui/invoice.pl?invoiceid=X Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 4b6d8bb0b6e0fc1e78ffa063740ca605e0efc367 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Jul 21 11:03:07 2020 +0200 Bug 24157: New permission - merge_invoices Add a new permission to merge invoices Test plan: - Remove the new permission "merge_invoices" for a given patron, use it to log in into Koha - Create 2 invoices, try to merge them => There is no way to merge it - Add the permission => Now you can merge the invoices Sponsored-by: Galway-Mayo Institute of Technology Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 6638e9de8c405e119a3816516a3340e84f5d8793 Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Mar 6 19:13:35 2020 +0000 Bug 24157: (follow-up) Conditionally show controls to reopen and close invoice This follow-up makes minor changes to the template so that the checkbox for reopening or closing an invoice are not displayed when the user doens't have the correct permissions. To test, apply the patch and try the process of viewing or editing an invoice as a user with these various permissions: - edit_invoices ON - edit_invoices OFF - reopen_closed_invoices ON - reopen_closed_invoices OFF Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 6b984a0feb29aede7a569dddd6aae35b13eed5cf Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Dec 11 16:39:36 2019 +0100 Bug 24157: New permission - delete_baskets Add a new permission to delete acquisition baskets Test plan: - Remove the new permission "delete_basket" for a given patron, use it to log in into Koha - Create basket, try to delete it => There is no way to delete it - Add the permission => Now you can delete the basket Sponsored-by: Galway-Mayo Institute of Technology Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 7fb8f3638859b1e27c2954363b175030fadbee17 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Dec 11 16:37:46 2019 +0100 Bug 24157: New permission - delete_invoices Add a new permission to delete invoices Test plan: - Remove the new permission "delete_invoices" for a given patron, use it to log in into Koha - Create an invoice, try to delete it => There is no way to delete it - Add the permission => Now you can delete the invoice Sponsored-by: Galway-Mayo Institute of Technology Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 41c6940fcdb6522efef68430dcf88683e1831e63 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Dec 13 17:37:36 2019 +0100 Bug 24157: Add new method Acq::Invoice::Adjustement->fund Moving to its own commit in case we want to cherry-pick or move it to its own bug report. Sponsored-by: Galway-Mayo Institute of Technology Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit d3c8b8fe54b999a6d7f10ab6f6cc49db96edfd53 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Dec 10 21:05:40 2019 +0100 Bug 24157: New permission - edit_invoices Add a new permission to edit invoices Test plan: - Remove the new permission "edit_invoices" for a given patron, use it to log in into Koha - Create an invoice, edit it (click "detail") => You can see the detail of the invoice, but cannot edit it. It's a read-only view. - Add the permission => The form is back and you can modify the invoices and save the changes. Also, you are able to create adjustments. Sponsored-by: Galway-Mayo Institute of Technology Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit f10acb07e68f10a69e087012e47ae210cd609783 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Dec 10 20:03:28 2019 +0100 Bug 24157: New permission - reopen_closed_invoices New permission to reopen a closed invoice. Test plan: - Remove the new permission "reopen_closed_invoices" for a given patron, use it to log in into Koha - Create an invoice, close it => You are not able to reopen the invoice - Add the permission => You are able to reopen the invoice Sponsored-by: Galway-Mayo Institute of Technology Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 8f7bf2a6b4ab8d4d0be3b522753a8fd17d9fc54f Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 30 15:21:50 2020 +0000 Bug 25709: DBRev 20.06.00.017 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 5e45076c00b2f72537ba9c81c4535253f1aaadfb Author: Nick Clemens <nick at bywatersolutions.com> Date: Mon Jul 6 17:56:35 2020 +0000 Bug 25709: Rename systempreference to NotesToHide In an effort to use more inclusive language we have added a new coding guideline: https://wiki.koha-community.org/wiki/Coding_Guidelines#TERM3:_Inclusive_Language This patchset renames a syspref to be clearer and follow the guideline To test: 1 - Apply patch and updatedatabase 2 - git grep NotesBlacklist 3 - Note all remaining occurrences are translations, db updates, and release notes 4 - Add a field (e.g. '520' ) to the NotesToHide systempreference 5 - View a record with a 520 field on the opac 6 - Confirm the field does not show in the 'Title notes' tab Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 00a3aa21e86719dd702215150a4571219c434ddd Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jul 27 14:59:59 2020 +0200 Bug 25811: Debug - Paste the source of the page I am really struggling finding the problem here. Posting the source of the page may help. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 33 +-- C4/Circulation.pm | 30 +- C4/Reserves.pm | 3 + Koha.pm | 2 +- Koha/Acquisition/Invoice/Adjustment.pm | 18 +- Koha/Item.pm | 24 +- Koha/Plugins.pm | 53 ++++ acqui/addorderiso2709.pl | 3 - acqui/basket.pl | 9 +- acqui/booksellers.pl | 3 - acqui/duplicate_orders.pl | 4 +- acqui/invoice.pl | 41 ++- acqui/neworderempty.pl | 3 - acqui/orderreceive.pl | 3 - acqui/parcels.pl | 3 - admin/columns_settings.yml | 17 ++ debian/control | 2 + debian/list-deps | 5 +- installer/data/mysql/sysprefs.sql | 4 +- installer/data/mysql/updatedatabase.pl | 51 ++++ installer/data/mysql/userpermissions.sql | 5 + koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss | 6 +- .../intranet-tmpl/prog/css/src/staff-global.scss | 21 ++ koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../prog/en/includes/blocking_errors.inc | 2 + .../en/includes/member-display-address-style.inc | 130 ++++----- .../intranet-tmpl/prog/en/includes/permissions.inc | 25 ++ .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 5 +- .../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 311 +++++++++++++-------- .../prog/en/modules/acqui/invoices.tt | 98 ++++--- .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 4 +- .../prog/en/modules/admin/aqbudgetperiods.tt | 4 +- .../en/modules/admin/preferences/cataloguing.pref | 2 +- .../prog/en/modules/admin/preferences/opac.pref | 7 - .../prog/en/modules/admin/preferences/tools.pref | 8 +- .../prog/en/modules/cataloguing/additem.tt | 2 +- .../en/modules/members/tables/members_results.tt | 10 +- .../prog/en/modules/plugins/plugins-home.tt | 2 +- .../prog/en/modules/tools/koha-news.tt | 70 +++-- .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 12 +- koha-tmpl/intranet-tmpl/prog/js/viewlog.js | 6 + .../bootstrap/en/includes/doc-head-close.inc | 8 + .../bootstrap/en/includes/opac-bottom.inc | 19 +- koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 44 +-- .../bootstrap/js/googleindictransliteration.js | 27 -- opac/opac-detail.pl | 16 ++ opac/opac-main.pl | 5 - opac/opac-search.pl | 18 +- opac/opac-shelves.pl | 3 +- t/Biblio/GetMarcNotes.t | 4 +- .../Koha/Acquisition/Invoice/Adjustments.t | 10 +- t/db_dependent/Koha/Plugins/Circulation_hooks.t | 106 +++++++ ...blio_and_Items_plugin_hooks.t => Holds_hooks.t} | 56 ++-- t/db_dependent/Koha/Plugins/Plugins.t | 30 +- t/lib/Koha/Plugin/Test.pm | 25 ++ t/lib/Selenium.pm | 6 + 56 files changed, 961 insertions(+), 459 deletions(-) delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/js/googleindictransliteration.js create mode 100755 t/db_dependent/Koha/Plugins/Circulation_hooks.t copy t/db_dependent/Koha/Plugins/{Biblio_and_Items_plugin_hooks.t => Holds_hooks.t} (50%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 30 19:45:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 30 Jul 2020 17:45:29 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-86-g3583225507 Message-ID: <E1k1CcT-00042Z-1M@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3583225507c13490278d35616ddead1037da62cf (commit) via ddb722af2675c2a3a3d4f04373c260812c226af7 (commit) via 54e88ebe871bf549c7aa0df9d82687830ce348cd (commit) via bec610d0add6bede97652a2b52a9c2601ee67673 (commit) via 2270d927086be4999fc8e6667258fbe345b89120 (commit) via 712143d26b680b66898995f931248a41470beccb (commit) from f9bd821cf10c7ad88ae8d0ca71d9051bf5612eb6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3583225507c13490278d35616ddead1037da62cf Author: Lucas Gass <lucas at bywatersolutions.com> Date: Thu Jul 30 17:10:14 2020 +0000 Bug 5087: DBRev 20.05.02.003 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit ddb722af2675c2a3a3d4f04373c260812c226af7 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 11:15:24 2020 +0200 Bug 5087: Add server-side check If a user to access a CSV profile that is not available at the OPAC we should redirect to 404. It will also handle undefined csv_profiles For instance: kohadev.mydnsname.org:8080/cgi-bin/koha/opac-downloadshelf.pl?shelfnumber=1&format=3 kohadev.mydnsname.org:8080/cgi-bin/koha/opac-downloadcart.pl?bib_list=1/2/&format=3 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c2d45ac0f4687fc4dcf84e9de663f8d3f3a354be) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 54e88ebe871bf549c7aa0df9d82687830ce348cd Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Mon Jul 20 12:02:14 2020 -0300 Bug 5087: (QA follow-up) Fix leakage in opac-downloadshelf.pl Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit db15f4af8dc021c0ac06c3447cb87c5e51952cd2) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit bec610d0add6bede97652a2b52a9c2601ee67673 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Mon Jul 20 11:27:27 2020 -0300 Bug 5087: (QA follow-up) used_for deserves an index This patch introduces an index for the used_for column Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 92d0472d631817395ad71f89f962fa5166f15770) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 2270d927086be4999fc8e6667258fbe345b89120 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Mon Jul 20 11:09:01 2020 -0300 Bug 5087: (QA follow-up) Rename the attribute to fit later API usage This patch renames the introduced attribute for later usage on the API, and changes the logic to use it the other way around. It also adds a KEY for the flag, as it will be used in WHERE statements. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 478093072000d01b2b5c20f05044e4bd3bbfeecd) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 712143d26b680b66898995f931248a41470beccb Author: Aleisha Amohia <aleishaamohia at hotmail.com> Date: Thu Dec 20 22:52:59 2018 +0000 Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit ae3644a5947ea410fc3e8ac8b64307df7d1cbb18) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/ExportFormat.pm | 16 ++++++++++++++-- installer/data/mysql/kohastructure.sql | 5 ++++- installer/data/mysql/updatedatabase.pl | 20 ++++++++++++++++++++ .../prog/en/modules/tools/csv-profiles.tt | 9 +++++++++ opac/opac-basket.pl | 6 +++++- opac/opac-downloadcart.pl | 18 +++++++++++++++++- opac/opac-downloadshelf.pl | 19 ++++++++++++++++++- tools/csv-profiles.pl | 3 +++ 9 files changed, 91 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 30 20:08:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 30 Jul 2020 18:08:45 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-90-gd6128b6af1 Message-ID: <E1k1Cyz-0004gH-T4@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via d6128b6af130759f0a5838ec58692319c6c3fd9a (commit) via a450d3bb841c1674532e18e9e0e6a2ee49de0cbd (commit) via 1b8f257fbe4690ddc3a5fc8678724ee6efde0019 (commit) via 323ebe649d2baebac60e59269cc390fa5d83a9a5 (commit) from 3583225507c13490278d35616ddead1037da62cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d6128b6af130759f0a5838ec58692319c6c3fd9a Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jul 21 16:03:54 2020 +0100 Bug 25765: (QA follow-up) Use method directly in cleanborrowers Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit bd9ece8c194ffc960b5709b884620bf24e29068b) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit a450d3bb841c1674532e18e9e0e6a2ee49de0cbd Author: Martin Renvoize <martin.renvoize at ptfs-europe.com> Date: Tue Jul 21 15:58:02 2020 +0100 Bug 25765: (QA follow-up) Save a DB hit Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 83d63d2302ee77c68dbae8be80fc6a038fa5ce51) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 1b8f257fbe4690ddc3a5fc8678724ee6efde0019 Author: Fridolin Somers <fridolin.somers at biblibre.com> Date: Tue Jun 16 14:01:39 2020 +0200 Bug 25765: Replace LoginBranchname and LoginBranchcode with use of Branches template plugin The template plugin Branches contains a method GetLoggedInBranchcode that returns current branch code. This patch adds GetLoggedInBranchname to get current branch name. It is used to replace vars LoginBranchname and LoginBranchcode sent to all templates in C4/Auth.pm. In labels and patrons cards modules, I choose to remove a unseless display of current branch in a hint. In acqui/acqui-home.tt, I choose to remove a useless display of current branch and also because table of founds contains a filter on library. Test plan: Check pages source code to see branch code or name is correct. list of the pages: /cgi-bin/koha/acqui/acqui-home.pl /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX /cgi-bin/koha/circ/branchoverdues.pl /cgi-bin/koha/circ/set-library.pl /cgi-bin/koha/circ/offline.pl /cgi-bin/koha/labels/label-edit-batch.pl?op=new /cgi-bin/koha/labels/label-manage.pl /cgi-bin/koha/patroncards/edit-batch.pl /cgi-bin/koha/patroncards/manage.pl OPAC: /cgi-bin/koha/opac-detail.pl?biblionumber=XXX Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit cbd86551571260ca6daade57920e0fb3f290dfb4) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 323ebe649d2baebac60e59269cc390fa5d83a9a5 Author: Fridolin Somers <fridolin.somers at biblibre.com> Date: Tue Jun 16 13:59:29 2020 +0200 Bug 25765: Add GetLoggedInBranchname method Add GetLoggedInBranchname method to Branches templates plugin. Also changes GetName method to use Koha::Library instead of direct SQL. Test plan : Run prove t/db_dependent/Template/Plugin/Branches.t Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0fcd0fd2707188368fa5b370b808e875c6ea5814) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 3 --- Koha/Template/Plugin/Branches.pm | 17 +++++++++-------- circ/set-library.pl | 3 +-- koha-tmpl/intranet-tmpl/prog/en/includes/header.inc | 8 ++++---- .../intranet-tmpl/prog/en/includes/members-toolbar.inc | 2 +- .../intranet-tmpl/prog/en/modules/acqui/acqui-home.tt | 2 +- .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- .../prog/en/modules/circ/branchoverdues.tt | 6 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt | 3 ++- .../intranet-tmpl/prog/en/modules/circ/set-library.tt | 2 +- .../prog/en/modules/labels/label-edit-batch.tt | 1 - .../prog/en/modules/labels/label-manage.tt | 1 - .../prog/en/modules/patroncards/edit-batch.tt | 1 - .../intranet-tmpl/prog/en/modules/patroncards/manage.tt | 1 - .../prog/en/modules/tools/cleanborrowers.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/includes/bodytag.inc | 5 +++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++-- t/db_dependent/Template/Plugin/Branches.t | 13 +++++++------ 18 files changed, 36 insertions(+), 40 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 30 20:39:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 30 Jul 2020 18:39:42 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-92-g6df8440c8f Message-ID: <E1k1DSw-0005vZ-C3@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 6df8440c8f1632c7e11a54b966b8a1fdc16c8c00 (commit) via 7b547576fb1dff6ba53e2c358b15f46bfb82cc05 (commit) from d6128b6af130759f0a5838ec58692319c6c3fd9a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6df8440c8f1632c7e11a54b966b8a1fdc16c8c00 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Thu Jul 30 18:07:33 2020 +0000 Bug 23795: DBRev 20.05.03.004 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 7b547576fb1dff6ba53e2c358b15f46bfb82cc05 Author: Owen Leonard <oleonard at myacpl.org> Date: Wed Dec 11 17:03:01 2019 +0000 Bug 23795: Convert opaccredits system preference to news block This patch builds on Bug 22318 to move the opaccredits system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the opaccredits system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opaccredits system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opaccredits is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'opaccredits_en', 'opaccredits_fr-FR', 'opaccredits_cs-CZ' - Go to Administration -> System preferences and confirm that the opaccredits preference has been removed. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit c9eb2be381bf9b6848b14bd374ba004f41198ed0) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 2 -- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 - installer/data/mysql/updatedatabase.pl | 26 ++++++++++++++++++++++ .../prog/en/modules/admin/preferences/opac.pref | 6 ----- .../prog/en/modules/tools/koha-news.tt | 2 +- .../bootstrap/en/includes/opac-bottom.inc | 9 ++++---- 7 files changed, 33 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 30 20:57:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 30 Jul 2020 18:57:40 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-94-gaf5a3cee41 Message-ID: <E1k1DkK-0006Rz-8Y@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via af5a3cee41525bc266e79afc3a2903e4e17d3cda (commit) via c33123faf3d44d4533fbe2da7802af6ad1d95d13 (commit) from 6df8440c8f1632c7e11a54b966b8a1fdc16c8c00 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit af5a3cee41525bc266e79afc3a2903e4e17d3cda Author: Lucas Gass <lucas at bywatersolutions.com> Date: Thu Jul 30 18:25:20 2020 +0000 Bug 23796: DBRev 20.05.02.005 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit c33123faf3d44d4533fbe2da7802af6ad1d95d13 Author: Owen Leonard <oleonard at myacpl.org> Date: Wed Dec 11 18:20:46 2019 +0000 Bug 23796: Convert OpacCustomSearch system preference to news block This patch moves the OpacCustomSearch system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacCustomSearch system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacCustomSearch system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacCustomSearch is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacCustomSearch_en', 'OpacCustomSearch_fr-FR', 'OpacCustomSearch_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 16053574a5bff66d86ebcc906ccbabe31c45d1c7) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 - installer/data/mysql/updatedatabase.pl | 31 ++++++++++++++++++++++ .../prog/en/modules/admin/preferences/opac.pref | 6 ----- .../prog/en/modules/tools/koha-news.tt | 2 +- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 9 ++++--- 6 files changed, 38 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 11:25:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 09:25:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-470-g09ed4c0dd7 Message-ID: <E1k1RHy-0001dq-Hy@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 09ed4c0dd7277931c1e631c5b1329463fc9751e5 (commit) via 4921ad8ae42c04415347d2d0bce4a5ed7af395a3 (commit) via e330e4ec222f8ac3a04339a020509e30aa0bf3ab (commit) via 0a9d3f17d9e44b5326a42d14420d30243031629d (commit) via d5d221160184120140950112ef8edfb0ea476949 (commit) from 3ae472ba5d9b7bfe6c6e44320ca020c9cf111b01 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 09ed4c0dd7277931c1e631c5b1329463fc9751e5 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 30 10:57:53 2020 +0200 Bug 25887: Keep library filter on the fund list view The problem: When filtering funds by library, the pull down for libraries resets to "empty" when the page is reloaded, although the filter criteria is visible in the URL. Test plan: Create a fund for library A Create a fund for library B Go to the fund list view => All funds are listed Select library A in the library filter, click "Go" => Funds for library A are listed => Library filter has "library A" selected Edit fund for library B => The edit form has "library B" selected Signed-off-by: Holly Cooper <hc at interleaf.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 4921ad8ae42c04415347d2d0bce4a5ed7af395a3 Author: Owen Leonard <oleonard at myacpl.org> Date: Wed Jul 29 20:01:24 2020 +0000 Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid <br clear="both"/> - Move heading inside container so that floats clear correctly - Change <span> tag back to <div> to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list. Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e330e4ec222f8ac3a04339a020509e30aa0bf3ab Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 30 11:59:44 2020 +0200 Bug 25852: Add tests Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 0a9d3f17d9e44b5326a42d14420d30243031629d Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 30 12:00:03 2020 +0200 Bug 25852: Improve C4::Creators::Lib reliability under plack This is certainly a major issue that leads to many side-effects. Under plack, the structure of the default values are not handled correctly. Package variables are used to store stuff like the "layout type". They are complex structures (arrays of hashes) and returned without being copied. When the caller (the controller script) retrieve them then modify the returned structures, it actually modifies the package's variables. One of the issue is: Create a new layout The script retrieve a structure with all "selected" flags are set to 0 It select the first one as default (BAR as selected => 1) The user creates the new layout and will selected BIBBAR (for instance) If you then edit this new layout, the script will retrieve the "label_types" and set "selected" for BIBBAR. However BAR is still selected! The UI receives 2 selected and display the first selected one that has the selected option. Test plan: 1. Create a layout type for Barcode/Biblio 2. Choose fields to print and size of font 3. Save 4. Edit existing Layout => Withtout this patch "Barcode" is the preselected option => With this patch applied, the correct "Barcode/Biblio" option is selected Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit d5d221160184120140950112ef8edfb0ea476949 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Jul 31 09:49:06 2020 +0200 Bug 26108: (bug 25855 follow-up) Call after_circ_action hook only if issue exists AddReturn can be called on an item even if it's not checked out (to trigger holds for instance). The hook should (?) not be called in that situation Test plan: Confirm the above and that the following tests are now passing: t/db_dependent/SIP/Message.t t/db_dependent/Reserves.t t/db_dependent/Circulation/issue.t t/db_dependent/SIP/Transaction.t t/db_dependent/Circulation.t Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 16 +++++++++------- C4/Creators/Lib.pm | 16 ++++++++-------- .../intranet-tmpl/prog/en/modules/admin/aqbudgets.tt | 2 +- .../prog/en/modules/catalogue/moredetail.tt | 10 +++++++--- t/db_dependent/Creators/Lib.t | 7 ++++++- 5 files changed, 31 insertions(+), 20 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 13:26:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 11:26:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-471-g67f6ceecd3 Message-ID: <E1k1TAq-0005XA-5T@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 67f6ceecd314fadd96e3dbc5fc543dd0528b050a (commit) from 09ed4c0dd7277931c1e631c5b1329463fc9751e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 67f6ceecd314fadd96e3dbc5fc543dd0528b050a Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Jul 31 12:55:40 2020 +0200 Bug 25811: (follow-up) Debug - Paste the source of the page Wide character in syswrite at /usr/share/perl5/File/Slurp.pm line 506. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: t/lib/Selenium.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 15:46:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 13:46:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00-476-gcb5acdc670 Message-ID: <E1k1VMU-0001OB-8Q@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cb5acdc6702cef4668921ccf2537797358981fff (commit) via 622ea4627ae50c49f7547ee3a3a8b4bde18e17a3 (commit) via b0eee4d2e1359050cee3dd23a121e75195b0ce11 (commit) via ce441708906fa282e000f523243ded20541970cc (commit) via a51b06001f2f8e42efc48d1898060f1d8d23ae62 (commit) from 67f6ceecd314fadd96e3dbc5fc543dd0528b050a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cb5acdc6702cef4668921ccf2537797358981fff Author: Julian Maurice <julian.maurice at biblibre.com> Date: Thu Jun 25 11:25:41 2020 +0400 Bug 25873: Ignore malformed data for Elasticsearch integer fields If we try to put malformed data into an integer field, Elasticsearch rejects the whole document. Setting 'ignore_malformed' to true allows to ignore malformed data and process the other fields of the document normally https://www.elastic.co/guide/en/elasticsearch/reference/7.8/ignore-malformed.html Test plan: * Without the patch 1. In search engine configuration, change the type of a text field to 'Number' (for instance 'title') 2. misc/search_tools/rebuild_elasticsearch.pl -d -b 3. See that the index is empty (unless you have titles consisting only of digits) * With the patch 1. misc/search_tools/rebuild_elasticsearch.pl -d -b 2. Now records are correctly indexed Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 622ea4627ae50c49f7547ee3a3a8b4bde18e17a3 Author: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Date: Wed Jul 29 15:58:42 2020 +0000 Bug 26084: Clarify language on ConsiderOnSiteCheckoutsAsNormalCheckouts To test: - apply patch - confirm explanation reads as suggested Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit b0eee4d2e1359050cee3dd23a121e75195b0ce11 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Jul 31 11:53:53 2020 +0200 Bug 26111: Add "Serials" (SER) to the reports dictionnary It's missing in the template Test plan: Go go Home › Reports › Guided reports wizard › Dictionary At step 2, notice that with this patch you have "Serials" in the dropdown list (instead of an empty entry) Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit ce441708906fa282e000f523243ded20541970cc Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Jul 31 09:52:10 2020 -0300 Bug 26108: Only call the plugin hook if a return took place This patch makes the hooks be called only if the checkin is effective (i.e. if it is not rejected for some reason. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => FAIL: Tests fail 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit a51b06001f2f8e42efc48d1898060f1d8d23ae62 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Jul 31 09:47:56 2020 -0300 Bug 26108: Regression tests The current implementation makes the assumption that if $issue is defined, then it is the 'return' use case. This is correct, but incomplete: after verifying that there's actually an issue, the return can be rejected for various reasons. This patch introduces a regression test for one of those situations (which I consider enough for testing purposes) . It highlights that the hook shouldn't be called if there hasn't been an actual checkin. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => FAIL: Tests fail because there's an unexpected warining printed by the erroneous plugin call (i.e. there's been no return but the plugin is called anyway). Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 4 ++-- admin/searchengine/elasticsearch/field_config.yaml | 1 + .../prog/en/modules/admin/preferences/circulation.pref | 2 +- .../intranet-tmpl/prog/en/modules/reports/dictionary.tt | 1 + t/db_dependent/Koha/Plugins/Circulation_hooks.t | 12 +++++++++++- 5 files changed, 16 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 22:27:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 20:27:06 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-100-g1667e8b0a3 Message-ID: <E1k1bcQ-0006Jy-UW@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 1667e8b0a3f859b013c4e7e2c28537e9c34627db (commit) via 416b1396d681a08f0c9eee5256e9c4f129e8594e (commit) via a81ddb4372863f65a9d6ea966ffe29925986d3ef (commit) via dbc625102a6ce084cd110eefe7e2b9f2ce38dad3 (commit) via 7216dd64c7ec2669604e23098183ad076938f2a2 (commit) via 4ec1a7b6e26a2890d60820e63c270932e82b3925 (commit) from af5a3cee41525bc266e79afc3a2903e4e17d3cda (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1667e8b0a3f859b013c4e7e2c28537e9c34627db Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Jul 23 10:50:27 2020 +0200 Bug 23797: Apply DB changes to kohastructure.sql Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0edaab49afec96c793477e9e790b4a9d7b6044fe) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 416b1396d681a08f0c9eee5256e9c4f129e8594e Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri Jul 31 19:45:52 2020 +0000 Bug 23797: DBRev 20.05.02.007 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit a81ddb4372863f65a9d6ea966ffe29925986d3ef Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri Jul 31 19:41:40 2020 +0000 Bug 23797: DBRev 20.05.02.006 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit dbc625102a6ce084cd110eefe7e2b9f2ce38dad3 Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Jul 7 18:36:32 2020 +0000 Bug 23797: (follow-up) Enable OpacLoginInstructions in header The OpacLoginInstructions information should be available in the login modal which is displayed when the login link in the header menu is clicked. Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 1bc9765d043169dfeb569e25659f553f39dc466b) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 7216dd64c7ec2669604e23098183ad076938f2a2 Author: Owen Leonard <oleonard at myacpl.org> Date: Mon Jun 29 13:07:42 2020 +0000 Bug 23797: (follow-up) Increase the size of opac_news.lang This patch adds a database update to increase the size of the opac_news.lang column in order to accommodate longer values. Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit f8c5b54acfa94f2c5e04f3376223e883deef9937) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 4ec1a7b6e26a2890d60820e63c270932e82b3925 Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Mar 24 15:06:30 2020 +0000 Bug 23797: Convert OpacLoginInstructions system preference to news block This patch builds on Bug 22318 to move the OpacLoginInstructions system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacLoginInstructions system preference. Apply the patch and run the database update process. - Go to the OPAC and click the login link. - In the login modal, confirm that the content which was previously in the OpacLoginInstructions system preference displays correctly below the login form. - While not logged in to the OPAC, navigate directly to /cgi-bin/koha/opac-user.pl. The OpacLoginInstructions content should display correctly here as well. - In the staff client, go to Tools -> News and verify that the content from OpacLoginInstructions is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacLoginInstructions_en', 'OpacLoginInstructions_fr-FR', 'OpacLoginInstructions_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacLoginInstructions preference has been removed. - To test the correct selection of language-specific content you must run the translation update/install process for the languages you're updating. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit be1d25ba16014c5fb3c788f8a93c5ecf3f5d9dbf) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/sysprefs.sql | 1 - installer/data/mysql/updatedatabase.pl | 38 ++++++++++++++++++++++ .../prog/en/modules/admin/preferences/opac.pref | 6 ---- .../prog/en/modules/tools/koha-news.tt | 2 +- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 5 +-- .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 7 ++-- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 5 +-- 9 files changed, 52 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 22:33:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 20:33:07 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-101-gfcdb0a4426 Message-ID: <E1k1biF-0006hX-EW@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via fcdb0a4426a5ca580af4b37c8f2de7aafb48cf0c (commit) from 1667e8b0a3f859b013c4e7e2c28537e9c34627db (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fcdb0a4426a5ca580af4b37c8f2de7aafb48cf0c Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri Jul 31 20:03:37 2020 +0000 Bug 23797: DBIC Schema Changes Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/OpacNews.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 22:39:00 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 20:39:00 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-102-g7d11c27d94 Message-ID: <E1k1bnw-0006rs-Ia@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7d11c27d9457446d7b9e4ca7fb27376a0f3ea223 (commit) from fcdb0a4426a5ca580af4b37c8f2de7aafb48cf0c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7d11c27d9457446d7b9e4ca7fb27376a0f3ea223 Author: Josef Moravec <josef.moravec at gmail.com> Date: Mon Sep 30 09:28:40 2019 +0000 Bug 23696: take deleted biblios into account when building oai sets Test plan: 0) do not apply the patch 1) set up OAI and create at least one set 2) run build_oai_sets.pl 3) remember/write down number of records added 4) delete a biblio, the is included in set 5) run buid_oai_sets.pl again 6) the set is 1 record smaller 7) apply the patch 8) run build_oai_sets.pl 9) the number of record should be the same as in 3) Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit e14c1702b446111f98ce6736aa7544df14b03d1d) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: misc/migration_tools/build_oai_sets.pl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 22:46:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 20:46:16 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-103-g00adfbce80 Message-ID: <E1k1buy-0007LC-3m@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 00adfbce802ee476c4d5b49edccbcf1cb3a58508 (commit) from 7d11c27d9457446d7b9e4ca7fb27376a0f3ea223 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 00adfbce802ee476c4d5b49edccbcf1cb3a58508 Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Fri Jul 17 23:36:24 2020 +0000 Bug 26016: Fix capitalization for "MARC Preview" To test: - Go to any record in the staff catalog - Check the display for the 'MARC Preview' link - Apply patch - It should have changed to 'MARC preview' Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 1a505632b8d1300a02512cfe300056f7b3797bfb) ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 22:53:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 20:53:47 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-104-ge51c7a73c0 Message-ID: <E1k1c2F-0007WS-NN@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e51c7a73c00b28d2e5091b021ced867fc5942b3b (commit) from 00adfbce802ee476c4d5b49edccbcf1cb3a58508 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e51c7a73c00b28d2e5091b021ced867fc5942b3b Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Jul 21 12:36:17 2020 +0200 Bug 26033: Use pic.infini.fr instead of framapic https://framapic.org/ is closing """ Framapic will be closing its doors on Tuesday, January 12, 2021. You will find a similar service on this page. Uploading images is now disabled, but you can still retrieve your images on the My images page. """ https://framablog.org/2019/09/26/lets-de-frama-tify-the-internet/ https://framablog.org/2020/03/03/10-bonnes-raisons-de-fermer-certains-services-framasoft-la-5e-est-un-peu-bizarre/ (French) We can still use another service. However we may think about hosting the service ourself! Test plan: Modify a selenium script to make it fail (for instance modify the path for a find_element call) Run it Confirm that the screenshot has been uploaded correctly and that the link works Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 8aa907379eb54d360746c3e15051327a1e6cc1fe) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: t/lib/Selenium.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 22:57:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 20:57:28 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-105-gd34e89aa85 Message-ID: <E1k1c5o-0007eE-R9@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via d34e89aa85ac8223445b4bf99829631987637aef (commit) from e51c7a73c00b28d2e5091b021ced867fc5942b3b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d34e89aa85ac8223445b4bf99829631987637aef Author: Mason James <mtj at kohaaloha.com> Date: Mon Jun 29 13:40:36 2020 +1200 Bug 25889: Increase performance of debian/list-deps script to test... (on a i7-2600 vm with 8 cores) 1/ run script, note execution time $ time ./debian/update-control real 8m5.000s 2/ copy old file $ cp ./debian/control control.old 3/ apply patch 4/ run updated script, note execution time is smaller $ time ./debian/update-control real 2m14.000s 5/ copy new file $ cp ./debian/control control.new 6/ confirm old and new control files are identical $ diff control.old control.new | wc -l 0 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 8d56af377c158823497df17b2ef18637bbc11a1c) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: debian/list-deps | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 23:05:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 21:05:11 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-106-gddfec0a706 Message-ID: <E1k1cDH-0007s8-VE@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ddfec0a706c2233ea60bbdb990b5368ceebc982f (commit) from d34e89aa85ac8223445b4bf99829631987637aef (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ddfec0a706c2233ea60bbdb990b5368ceebc982f Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jul 27 15:15:44 2020 +0200 Bug 25729: Prevent Charges/Fees.t to fail on slow server We must use t::lib::Dates::compare to compare dates Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit fcd659b2d4cf62df48113567c59392e8dff9696f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Charges/Fees.t | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 23:19:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 21:19:10 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-108-g51cd56ddb3 Message-ID: <E1k1cQo-0008Ip-BD@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 51cd56ddb37dbb3c92105d948b8a83b98ad6bcfb (commit) via bc1e7669bd2b1abccba7b1975b66adac0de550d2 (commit) from ddfec0a706c2233ea60bbdb990b5368ceebc982f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 51cd56ddb37dbb3c92105d948b8a83b98ad6bcfb Author: Nick Clemens <nick at bywatersolutions.com> Date: Fri Jun 12 10:51:36 2020 +0000 Bug 25724: Do not call ModReserveStatus when completing transfer I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0 Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status. ModReserveStatus also calls CartToShelf regardless of what happens here. To test: 1 - Set UpdateItemLocationOnCheckin to: _ALL_: CART 2 - SetAutomaticItemReturn = Do 3 - Check an item in at a different branch than it's homebranch to create a transfer 4 - Check the item in at it's homebranch 5 - View the item details page 6 - Item is not in CART location 7 - Apply patch 8 - Repeat 9 - Item is in CART location after completion of transfer Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Jason Robb <jrobb at sekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit e025cd76437b212746717ad54b5da22e410bbe8f) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit bc1e7669bd2b1abccba7b1975b66adac0de550d2 Author: Nick Clemens <nick at bywatersolutions.com> Date: Fri Jun 12 11:11:26 2020 +0000 Bug 25724: Unit tests Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Jason Robb <jrobb at sekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 028e9a07db625845482eff1b550a9bbe86ec6fbc) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 -- t/db_dependent/Circulation/issue.t | 12 +++++++++++- 2 files changed, 11 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 23:29:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 21:29:29 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-109-g25f91e5f43 Message-ID: <E1k1can-00008k-2P@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 25f91e5f431f8a8f06ac3710d776c7ed57d3bd20 (commit) from 51cd56ddb37dbb3c92105d948b8a83b98ad6bcfb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 25f91e5f431f8a8f06ac3710d776c7ed57d3bd20 Author: Lucas Gass <lucas at bywatersolutions.com> Date: Mon Jul 6 20:38:42 2020 +0000 Bug 25940: Check for reserve_id before Dopop TEST PLAN: 1. Have an item belonging to a different branch and check it in. 2. When the modal pops up hit 'Yes, print slip' or 'Print slip' if AutomaticItemReturn is set to 'don't' 3. The first print dialog should appear with a URL like '/cgi-bin/koha/circ/transfer-slip.pl?transferitem=18&&branchcode=CPL&op=slip' 4. Close that print dialog and you will immediately see another one that says 'No slip template found'. 5. Notice the URL of the second pop-up is: /cgi-bin/koha/circ/hold-transfer-slip.pl?reserve_id= 6. There is no reserve id so the template is not found. 7. Apply patch 8. Repeat 1-6 9. You should no longer have two print dialogs Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 0ec7ba72861f21c2ce83d3a98446af7db7a3e321) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/circ/returns.tt | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 23:35:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 21:35:03 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-111-g4733a2a421 Message-ID: <E1k1cgB-0000GQ-Ns@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 4733a2a4215c9351a398945ea2546542e4027d43 (commit) via 1a6e51934df7f21f9b64f52606edb84180b5be2d (commit) from 25f91e5f431f8a8f06ac3710d776c7ed57d3bd20 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4733a2a4215c9351a398945ea2546542e4027d43 Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Wed Sep 18 10:28:33 2019 -0400 Bug 23086: Search for collection is broken It appears that we are quoting the ccode values deep in the search code. Under ICU chains this breaks searching by limits To recreate 1 - Setup Koha using Zebra and icuchains 2 - Add ccode to AdvancedSearchTypes 3 - In koha-conf.xml set zebra debug level to include request <zebra_loglevels>none,fatal,warn,request,info</zebra_loglevels> 4 - Set some items into different ccodes 5 - On opac perform a search for: ccode:NFIC 6 - It works 7 - tail -n 50 /var/log/koha/kohadev/zebra-output.log 8 - Note search request like: Search biblios OK 26 1 1+0 RPN @attrset Bib-1 @attr 1=8009 NFIC 9 - On opac go to advanced search, select Collection, and limit to smae code a s above 10 - No results 11 - Check the zebra-output.log: Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @attr 1=8009 'NFIC' 12 - Apply patch 13 - Restart all 14 - Repeat search by collection limit 15 - Success! 16 - Check the zebra-output.log: Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @attr 1=8009 NFIC 17 - Add a new ccode value: N)N 18 - Set some items to that ccode 19 - Confirm searching by that ccode works Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit bc1b76be4a35403239fbce6f349ee343435cc8a0) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit 1a6e51934df7f21f9b64f52606edb84180b5be2d Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Jul 15 15:33:18 2020 +0000 Bug 23086: Unit test Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 40b6e1b8a1a6e74cb4e9a1c422ffa4faa0bdefc0) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 3 +-- t/db_dependent/Search.t | 8 +++++++- 2 files changed, 8 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 23:50:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 21:50:47 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-113-g7d67e541e7 Message-ID: <E1k1cvP-0000qJ-LI@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7d67e541e752a561e04f3682abf9f8471aa4c3fb (commit) via f00ce94d94b079a9e8e326ea3bad99e5567d93f2 (commit) from 4733a2a4215c9351a398945ea2546542e4027d43 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7d67e541e752a561e04f3682abf9f8471aa4c3fb Author: Lucas Gass <lucas at bywatersolutions.com> Date: Fri Jul 31 21:17:49 2020 +0000 Bug 25709: DBRev 20.05.02.008 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> commit f00ce94d94b079a9e8e326ea3bad99e5567d93f2 Author: Nick Clemens <nick at bywatersolutions.com> Date: Mon Jul 6 17:56:35 2020 +0000 Bug 25709: Rename systempreference to NotesToHide In an effort to use more inclusive language we have added a new coding guideline: https://wiki.koha-community.org/wiki/Coding_Guidelines#TERM3:_Inclusive_Language This patchset renames a syspref to be clearer and follow the guideline To test: 1 - Apply patch and updatedatabase 2 - git grep NotesBlacklist 3 - Note all remaining occurrences are translations, db updates, and release notes 4 - Add a field (e.g. '520' ) to the NotesToHide systempreference 5 - View a record with a 520 field on the opac 6 - Confirm the field does not show in the 'Title notes' tab Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 5e45076c00b2f72537ba9c81c4535253f1aaadfb) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 6 +++--- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 6 ++++++ .../prog/en/modules/admin/preferences/cataloguing.pref | 2 +- t/Biblio/GetMarcNotes.t | 4 ++-- 6 files changed, 14 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jul 31 23:59:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jul 2020 21:59:32 +0000 Subject: [koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-114-g55a24f880d Message-ID: <E1k1d3s-0001FP-IR@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 55a24f880d69ed6627e8dc4cbc429d0eb167c96e (commit) from 7d67e541e752a561e04f3682abf9f8471aa4c3fb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 55a24f880d69ed6627e8dc4cbc429d0eb167c96e Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Wed Jul 8 16:54:51 2020 -0300 Bug 25961: Add hooks for plugins to inject variables to OPAC XSLT This patch adds the following plugin hooks: - opac_results_xslt_variables - opac_detail_xslt_variables This hooks will inject variables returned by the plugin in the form of a hashref, into the ones that are passed to the XSLT processing code. To test: 1. Apply the 'DO NOT PUSH' commit 2. Install the Kitchensink plugin 3. Restart all 4. Search biblios in the OPAC => SUCCESS: A text is injected in front of the biblio title 5. Enter the detail page of any of the results => SUCCESS: A text is injected in front of the biblio title 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 9676f537a448d50770c90d9d5a8b420a1f302444) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> ----------------------------------------------------------------------- Summary of changes: opac/opac-detail.pl | 28 ++++++++++++++++++++++++++++ opac/opac-search.pl | 25 +++++++++++++++++++++++++ 2 files changed, 53 insertions(+) hooks/post-receive -- main Koha release repository