[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.13-28-g31900b557d

Sun Jul 26 18:17:23 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  31900b557d1bca3245f239a2856e2a7694a28ecb (commit)
       via  d43a237884301163daed3e9a199347b42ce30dd5 (commit)
       via  9a64956e11b3492cfa3f57097fb6942f783805ea (commit)
       via  4e2a8c53c3d59d5927e2f668680ba565252341c0 (commit)
       via  d363f0246809e1906b3af50f7c6a35abbb1e710c (commit)
      from  a4938d13107f0d1e8bce91eab12dd23741c624d4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 31900b557d1bca3245f239a2856e2a7694a28ecb
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Jun 25 10:38:26 2020 +0000

    Bug 25875: Move check for module_bit and code to the JOIN

    If we limit the JOIN to rows with the correct subpermission we won't
    duplicate the returned patrons

    To test:
     1 - Give a patron full acquisitions permissions
     2 - Also give them several subpermissions on other areas
     3 - Go to Acquisitions
     4 - Edit a fund
     5 - Add a user to the fund
     6 - Search for user above
     7 - They return multiple times in results
     8 - Apply patch
     9 - Restart all the things
    10 - Repeat search
    11 - Patron appears once

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 721876785142fea84f02c7dbe4f325e2a605bd0f)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 59e1e78c6d59ee6ced202382e2910676a4e32360)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit 0cb156cba54e8433a3ea351a322f93c807a934e5)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit d43a237884301163daed3e9a199347b42ce30dd5
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Jun 25 10:38:16 2020 +0000

    Bug 25875: Unit test

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit a804d4be437a5df3641f854a506642afe3501046)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 7467f10ceb52696f263746d5495532e2b63b8f5b)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit 512d0bfbd417e9e2d7f2e0e46882979138091e96)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit 9a64956e11b3492cfa3f57097fb6942f783805ea
Author: Slava Shishkin <slavashishkin at gmail.com>
Date:   Wed May 13 20:20:27 2020 +0300

    Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm

    This warning was thrown:
        Use of uninitialized value $info{"invalid_username_or_password"}
        in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm
        line 387.

    There is the case when hash key can be undefined in numeric comparison.

    Fixed by adding additional precheck for
    $info{"invalid_username_or_password"} being Perl's "true".

    To test:
        1) Go to the first page of the web-installer where it asks to login.
        2) Observe the warning in the log file.
        3) Apply patch.
        4) Repeat step 1.
        7) Check that previous warning suppressed.

    Mentored-by: Andrew Nugged <nugged at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit d81438e143273a538c09cd16e7f92a83beed4027)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 3a3237da9c2f107a9d4e4a9e9383316ce10e6ecc)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit 0d9ea88b86ea48142aabdb4eea6efb4b98eae3f1)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit 4e2a8c53c3d59d5927e2f668680ba565252341c0
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Jun 18 09:01:36 2020 -0400

    Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name

    This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode.
    The subroutine hold_patron_bcode should always return an empty string, not undef.

    Test Plan:
    1) Using the SIP cli emulator, checkin an item that is not checked out
    2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)"
       The hex number will almost certainly be different from this example
    3) Apply this patch
    4) Restart the SIP server
    5) Run the SIP checkin again
    6) Note the DA field is no longer present!

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 017b67e6c52ab7b79a0187b1ca9fea220117f7ef)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 18faf9b7aa7c313fd9fa086c5f9609ef7b0c70f5)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit f22bded52404114572988e445e1ca0398fa3227d)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

commit d363f0246809e1906b3af50f7c6a35abbb1e710c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Jun 18 16:54:42 2020 -0300

    Bug 25805: Regression tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 115eeada2b6f959997d21d0e0dd73606f1ca7324)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit c65e76a7c49720cf112c59a0583a9545b34844c4)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    (cherry picked from commit 4a3486a7bcc06b05b664a69ba5e977988e7897e6)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-----------------------------------------------------------------------

Summary of changes:
 C4/InstallAuth.pm                         |  2 +-
 C4/SIP/ILS/Item.pm                        |  6 ++---
 C4/Utils/DataTables/Members.pm            | 12 ++++++----
 t/db_dependent/SIP/Message.t              | 37 ++++++++++++++++++++++++++++++-
 t/db_dependent/Utils/Datatables_Members.t | 35 ++++++++++++++++++++++++++++-
 5 files changed, 82 insertions(+), 10 deletions(-)

hooks/post-receive
-- 
main Koha release repository