[koha-commits] main Koha release repository branch master updated. v20.05.00-465-g3ae472ba5d
Git repo owner
gitmaster at git.koha-community.org
Thu Jul 30 18:14:33 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 3ae472ba5d9b7bfe6c6e44320ca020c9cf111b01 (commit)
via cc621836b26010986c85bd2cc986ff71b77bb28d (commit)
via 5cd1c1e03290ae7be214dd92083e1377eadd3c1f (commit)
via c2111c1ce6532b73af3a4847500be8f305db570a (commit)
via 773b88e9c20c17ea70aa285d12c8e4e03923d15d (commit)
via 9b9e8fd32852acceb10cfc54d4a5a3acc0f6e232 (commit)
via 9deaf86754c9d6aa0b4a2cb688b497bd6b03b67f (commit)
via 9e0d097a5692af07db020e6f806eeaa97d43ae1e (commit)
via 23846781751d7fb808b3fa4b857da72706653575 (commit)
via 5bec404420c6dd9251b511d12e2425e5a6039a95 (commit)
via 980dd605031e616f1d481852dffe9cc6779eb3e3 (commit)
via e68fe2a928bec05b9602fa28dfbc86e04657ce81 (commit)
via 0a37a026e3eaa4da57b467d506147849e137781e (commit)
via 80077c44f9eeea537f0085e33329fc40eabb5f9d (commit)
via 07d00ee029dfddd1aed1b4e45ac04ed92e73f708 (commit)
via a351d056c597e3a925500527e2d8ecd49d02c430 (commit)
via 89551241dbf3712fa9e582627855f1a859edeeb6 (commit)
via 77058c7d6ba4f13c64b5f48a7028692bcfa5b968 (commit)
via 2fac4017b78d5da9b20b7e73a9f75ecad7f94a67 (commit)
via 33f4bc949e22cca9eb6ee590e044ac708f80966a (commit)
via a8b95985847d38296abd1961ca8e05115b563dc7 (commit)
via 7e86c994110c8b43e67b1bf152bb44f9e1468df6 (commit)
via 3d0da68d5ada37b40099fbc11b63202ccf7a48b2 (commit)
via 7c8276bf0e64a2dc90af4aab0d6e78893edc12b1 (commit)
via 8ecaedc22db5a25db6ffa98e6a7fc2e7039656c7 (commit)
via ab015f04dcd4956ca1ccd610d085e8b0c17ca733 (commit)
via 58be086a18e39068fd12dfeef677f982ae735a73 (commit)
via 50302c714ed287b06574b8e18f4b33e4df42ee91 (commit)
via db74e67bc52b2f3af8efd2243f6ab02fd6568de2 (commit)
via 67c54c2c23be60df3efd1c7428ba870c0d5192f8 (commit)
via a658db8f7e8d94b463bc6f064753f4ad2aaa48e9 (commit)
via 614b64ed170163ac618ea4bec16ea8c92b28c680 (commit)
via 536471ec0775d32939d7ef3044df891702827f3a (commit)
via 2751defa7ca09cc5040021012dd503464ecf1b32 (commit)
via d7392cad470f5809475ccb731e6a229a0bc9504d (commit)
via 625ba7a2aa01ef6efbaceb686bcdbcebe98e012f (commit)
via 0f54ace6711c9035b267474c2f1ab69570f977b8 (commit)
via 9319c8879fdd796d7293beca8f5017a4024bdbd9 (commit)
via e5e058e39fa97e5732f514ded46128b666bfba99 (commit)
via 04afc1678a4e2b642de4c07402329248c7fc2137 (commit)
via d8c137a718cdb344b2910f449e3a8a73e4362263 (commit)
via 9932ce33156305d7ebe3c8192bda8f1450f20b2a (commit)
via 2ac260ca6c0716c47d7138aeeeabb80a50599f75 (commit)
via b78356cafd066cfe37366ca19e2556f69da200be (commit)
via 7e9d01d0fa75017698e6558f19105b7446821267 (commit)
via 9676f537a448d50770c90d9d5a8b420a1f302444 (commit)
via 50ebed51ee160992e22cde55dcd657beb7429f8f (commit)
via 5aba38fdaec2958a23f0ccaa57b4c951af1244ce (commit)
via 110e0acb5c33f96b9cb61286fc45d480b088f565 (commit)
via 4b6d8bb0b6e0fc1e78ffa063740ca605e0efc367 (commit)
via 6638e9de8c405e119a3816516a3340e84f5d8793 (commit)
via 6b984a0feb29aede7a569dddd6aae35b13eed5cf (commit)
via 7fb8f3638859b1e27c2954363b175030fadbee17 (commit)
via 41c6940fcdb6522efef68430dcf88683e1831e63 (commit)
via d3c8b8fe54b999a6d7f10ab6f6cc49db96edfd53 (commit)
via f10acb07e68f10a69e087012e47ae210cd609783 (commit)
via 8f7bf2a6b4ab8d4d0be3b522753a8fd17d9fc54f (commit)
via 5e45076c00b2f72537ba9c81c4535253f1aaadfb (commit)
via 00a3aa21e86719dd702215150a4571219c434ddd (commit)
from bc1b76be4a35403239fbce6f349ee343435cc8a0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3ae472ba5d9b7bfe6c6e44320ca020c9cf111b01
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Jul 29 13:03:57 2020 -0400
Bug 26083: Item editor defaults to lost
When editing an item via additem.pl, koha defaults to the first
available lost status, rather than defaulting to not-lost.
Test Plan:
1) Ensure you do not have a value ClaimReturnedLostValue
2) Edit an existing item that is not lost
3) Note the lost value is set even though it is not lost
4) Apply this patch
5) Edit a different item that is not lost
6) Note the lost value is not set!
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cc621836b26010986c85bd2cc986ff71b77bb28d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jul 30 17:40:28 2020 +0200
Bug 26061: Compiled CSS
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5cd1c1e03290ae7be214dd92083e1377eadd3c1f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jul 24 15:59:42 2020 +0000
Bug 26061: Improve style of sidebar datepickers
This patch makes a small change to the staff interface CSS so that
datepicker form fields in sidebar forms don't force the datepicker icon
onto a second line.
The change uses the CSS calc() function to specify that form fields with
a .hasDatepicker class (dynamically added by jqueryUI) have a width of
100% minus 20 pixels, leaving room for the datepicker icon.
To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface).
- View a page in the staff interface which has a datepicker field in a
sidebar form and confirm that the icon stays on the same line as the
firm field at varying browser widths. Examples:
- Reports -> Saved SQL reports
- Circulation -> Overdues
- Acquisitions -> Late orders
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c2111c1ce6532b73af3a4847500be8f305db570a
Author: David Cook <dcook at prosentient.com.au>
Date: Wed Jul 8 12:36:46 2020 +0000
Bug 25953: Add ID to installed plugins table on plugins-home.pl
This patch adds a "installed_plugins" ID to the table
of installed plugins.
The idea is that it will ease styling and DOM mods through Javascript.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 773b88e9c20c17ea70aa285d12c8e4e03923d15d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jul 30 15:21:50 2020 +0000
Bug 26070: DBRev 20.06.00.020
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9b9e8fd32852acceb10cfc54d4a5a3acc0f6e232
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Jul 27 19:16:07 2020 +0000
Bug 26070: Remove GoogleIndicTransliteration system preference
The Google Transliterate API was deprecated on May 26, 2011. This patch
removes the feature and associated system preference.
To test, apply the patch and run the database update process.
- Go to Administration -> System preferences and search for
'GoogleIndicTransliteration.' There should be no results.
- Search the Koha codebase for references to
'GoogleIndicTransliteration.' There should be no current references..
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9deaf86754c9d6aa0b4a2cb688b497bd6b03b67f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jul 30 15:21:50 2020 +0000
Bug 22660: DBRev 20.06.00.019
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9e0d097a5692af07db020e6f806eeaa97d43ae1e
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Jul 29 22:51:34 2020 +0000
Bug 22660: (QA follow-up) Fix capitalization in system preference
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 23846781751d7fb808b3fa4b857da72706653575
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jul 23 18:20:51 2020 +0000
Bug 22660: (follow-up) Re-word system preference description
This patch rewords the system preference description to focus on the
generic description of the editor rather than the name of the plugin:
tinymce: "a WYSIWYG editor (TinyMCE)"
codemirror: "a text editor (CodeMirror)"
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5bec404420c6dd9251b511d12e2425e5a6039a95
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jul 23 17:58:22 2020 +0000
Bug 22660: (follow-up) Improve asset handling, add linting
This patch makes some changes to the way assets are included based on
the value of the system preferece in order to minimize unnecessary
JavaScript includes.
The patch also adds HTML syntax-highlighting and linting like we have in
the system preferences editor.
Removed are two JS files which were not required.
To test, apply the patch and set the NewsToolEditor preference to
"CodeMirror."
- Edit a news item and confirm that the contents of the
editor show HTML syntax highlighting.
- Test HTML linting by adding some malformed HTML (missing closing tag,
for instance). The error should be highlighted.
- Set the NewsToolEditor to "TinyMCE" and confirm that WYSIWYG editing
still works correctly.
https://bugs.koha-community.org/show_bug.cgi?id=22600
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 980dd605031e616f1d481852dffe9cc6779eb3e3
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Fri May 8 22:57:40 2020 +0000
Bug 22660: Add system pref to allow switching of editors in News Tool
This patch adds a system preference called 'NewsToolEditor' which allows for the choice between TinyMCE and CodeMirror in the News Feature.
TEST PLAN:
1. Apply patch and run updatedatabase
2. Go to Tools > News and make a new entry or edit an existing News item.
3. When you initially load you should gte the TinyMCE editor (WYSIWYG)
4. Search for the NewsToolEditor system preference and switch to CodeMirror.
5. Reload your News item and now you should see the CodeMirror editor.
6. Try saving content with both and maki sure it works.
7. Try adding some different HTML tags in CodeMirror mode, saving, and making sure it looks right when you switch back to TinyMCE
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e68fe2a928bec05b9602fa28dfbc86e04657ce81
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jul 10 13:19:14 2020 +0000
Bug 25968: Make logs sort by date descending as a default
This patch adds DataTables with columns configuration to the log viewer.
The table of log entries is now sorted by default by date descending.
To test, apply the patch and go to Administration -> Table settings.
- Expand the "Tools" section and confirm that there is a section for
"logviewer."
- Go to Tools -> Log viewer.
- Perform a search which will return multiple results.
- Confirm that the results are sorted by date descending.
- Test that the table controls work correctly: Paging, columns, export.
- Return to the Table settings administration page and test that
changes to those settings are correctly reflected in the log viewer
table.
Signed-off-by: barbara <barbara.johnson at bedfordtx.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
JD amended patch: Fix indentation in .yml to match other entries
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0a37a026e3eaa4da57b467d506147849e137781e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jul 30 17:40:18 2020 +0200
Bug 22087: Compiled CSS
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 80077c44f9eeea537f0085e33329fc40eabb5f9d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 27 15:37:21 2020 +0200
Bug 22087: Add missing filters
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 07d00ee029dfddd1aed1b4e45ac04ed92e73f708
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 7 12:40:26 2020 +0200
Bug 22087: Move the email into the list
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a351d056c597e3a925500527e2d8ecd49d02c430
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 7 12:40:24 2020 +0200
Bug 22087: Remove padding on li's
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 89551241dbf3712fa9e582627855f1a859edeeb6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 7 12:01:05 2020 +0200
Bug 22087: Prevent variable names colision
We should not use PROCESS:
http://www.template-toolkit.org/docs/manual/Directives.html
" The PROCESS directive is slightly faster than INCLUDE because it
avoids the need to localise (i.e. copy) the variable stash before
processing the template. "
The 'patron' variable is reused by patron-title.inc
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 77058c7d6ba4f13c64b5f48a7028692bcfa5b968
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 6 16:25:34 2020 +0200
Bug 22087: Add a no_line_break parameter to prevent new lines
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2fac4017b78d5da9b20b7e73a9f75ecad7f94a67
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 6 16:14:04 2020 +0200
Bug 22087: Add space between zipcode and country
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 33f4bc949e22cca9eb6ee590e044ac708f80966a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 6 16:00:13 2020 +0200
Bug 22087: Use include file to display patrons address in search result
In order to display the city and country in the patron search result, we
need to use the member-display-address-style include file, to satisfy
AddressFormat.
Test plan:
Modify some patrons and fill the different address info
Search for them and notice that the city, zipcode and country are now
displayed.
Modify the value of AddressFormat and confirm that the display is
modified according to its value
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a8b95985847d38296abd1961ca8e05115b563dc7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jul 30 17:40:02 2020 +0200
Bug 26060: Compiled CSS
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7e86c994110c8b43e67b1bf152bb44f9e1468df6
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jul 24 14:07:29 2020 +0000
Bug 26060: Replace staff interface table sort icons with SVG
This patch modifies the staff interface CSS to convert table sorting
icons from PNG to SVG. These icons are added via background-image
data-urls, so only the SCSS file is modified.
To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface).
- Clear your browser cache if necessary
- View any DataTable in the staff interface, for instance when checking
out to a patron with existing checkouts, the catalog detail page for
a title with holdings, the table of saved reports.
- Confirm that the sorting icons in the table headers look correct in
each state: Sorted ascending, sorted descending, and unsorted.
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3d0da68d5ada37b40099fbc11b63202ccf7a48b2
Author: Didier Gautheron <didier.gautheron at biblibre.com>
Date: Sun Jul 12 14:09:15 2020 +0200
Bug 25982: OPAC shelves RSS link output is xml
Output rss feed as text/xml
Test plan:
1) have books entered
2) log in create a list
3) add books to list
4) display list in OPAC
5) click the RSS link button.
-- output is displayed as html text
6) apply patch
7) repeat steps 4&5
-- output is displayed as xml tree
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7c8276bf0e64a2dc90af4aab0d6e78893edc12b1
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jun 18 13:10:35 2020 +0000
Bug 25351: Move cart-related strings out of opac-bottom.inc and into basket.js
This patch adds the necessary JavaScript includes to the OPAC to
enable translation of strings in JavaScript. It also updates the
translation of cart-related strings by removing the strings from
opac-bottom.inc and putting them in basket.js where they are used.
To test, apply the patch and test that the correct strings are
translatable. In this example I'm testing fr-FR:
- Update a translation:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for the strings pulled from
JavaScript e.g. misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from bootstrap/js/basket.js for
translation, e.g.:
#: koha-tmpl/opac-tmpl/bootstrap/js/basket.js:89
msgid "Your cart is currently empty"
msgstr ""
- Edit the "msgstr" string however you want (it's just for testing)
- Install the updated translation:
> perl translate install fr-FR
In the OPAC, switch to the language you're testing. Confirm that your
translated string appears. In the above example, by clicking the "Cart"
icon in the header when there are no items in the cart.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8ecaedc22db5a25db6ffa98e6a7fc2e7039656c7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 28 09:23:35 2020 +0200
Bug 21268: Don't remove 0 allocated funds from fund list
If a fund is created with a amount of 0, it will not appear in the fund
list (when a new order is created for instance).
0 allocated funds can be used to track donations and other situations
where there is not an expected amount for the year.
Test plan:
0. Do not apply the patch
1. Create 1 active and 1 inactive budgets
2. Create some funds for each budgets, with amount > 0 and amount == 0
3. Add orders to basket
=> Note that the funds with amount == 0 are not displayed
4. Apply the patch
5. Add orders to basket (using the different possible ways we have)
=> Note that the funds with amount == 0 are displayed
This change is applied to the different views of the acquisition module.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ab015f04dcd4956ca1ccd610d085e8b0c17ca733
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat May 23 01:12:22 2020 +0200
Bug 25499: Fix fund code column when closing a budget
When closing a budget the fund code column in the table is
always empty. This is due to a TT variable not being correct.
To test:
- Create a budget and fund
- Order anything, leave basket open or not, but don't receive
- Duplicate your existing budget
- Close the first budget in order to move the pending orders
- Verify the fund code is not showing in the table
- Apply patch and reload the patch
- Verify fund codes are now showing correctly
Bonus: Changes the column heading Fund id to Fund ID.
Signed-off-by: Abbey Holt <aholt at dubuque.lib.ia.us>
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 58be086a18e39068fd12dfeef677f982ae735a73
Author: Mason James <mtj at kohaaloha.com>
Date: Fri Jul 3 23:42:02 2020 +1200
Bug 25920: Add liblocale-codes-perl package to fix ubuntu-stable (focal)
to test on ubuntu-20...
1/ install koha-common pkg
$ sudo apt install koha-common
2/ confirm liblocale-codes-perl pkg is not installed :(
$ apt-cache policy liblocale-codes-perl | grep Installed
Installed: (none)
3/ apply patch
4/ build and install new koha-common pkg
5/ confirm liblocale-codes-perl pkg is now installed :)
$ apt-cache policy liblocale-codes-perl | grep Installed
Installed: 3.62-1
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 50302c714ed287b06574b8e18f4b33e4df42ee91
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jul 29 15:11:24 2020 +0200
Bug 26063: Use Koha::Plugins->call for some other hooks
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit db74e67bc52b2f3af8efd2243f6ab02fd6568de2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Jul 24 16:00:52 2020 -0300
Bug 26063: Use Koha::Plugins->call for circulation hooks
This patch gets rid of a helper method used for calling the plugin
hooks.
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t
=> SUCCESS: Tests pass!
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 67c54c2c23be60df3efd1c7428ba870c0d5192f8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jul 23 11:52:57 2020 -0300
Bug 21468: (QA follow-up) Simplify payload
This patch simplifies the payload as suggested on bug 25855. It also
keeps some specific params that cannot be deduced from the passed
checkout object, (e.g. if it is an onsite checkout).
Tests are cleared and added for this special exceptions.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a658db8f7e8d94b463bc6f064753f4ad2aaa48e9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jul 15 02:26:20 2020 -0300
Bug 21468: (QA follow-up) Enhance tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 614b64ed170163ac618ea4bec16ea8c92b28c680
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Jul 6 13:46:47 2020 +0100
Bug 21468: Add 'checkin' action for _after_circ_actions
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 536471ec0775d32939d7ef3044df891702827f3a
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Jul 6 13:46:15 2020 +0100
Bug 21468: Unit tests for AddReturn
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2751defa7ca09cc5040021012dd503464ecf1b32
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Jul 6 09:44:11 2020 +0100
Bug 21468: Add 'checkout' action for _after_circ_actions
This patch adds a call to _after_circ_actions into AddIssue and passes
an appropriate payload for plugins to utilise after issuing items.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d7392cad470f5809475ccb731e6a229a0bc9504d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Jul 6 11:43:25 2020 +0100
Bug 21468: Unit tests for AddIssue
This patch adds a unit test for the addition of a call to the
_after_circ_action hook in AddIssue.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 625ba7a2aa01ef6efbaceb686bcdbcebe98e012f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Jul 24 15:42:17 2020 -0300
Bug 24031: (QA follow-up) Add tests for the AddReserve intervention
This patch adds tests for AddReserve
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0f54ace6711c9035b267474c2f1ab69570f977b8
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Jul 17 11:32:57 2020 -0400
Bug 24031: Add hook to test plugin with unit test
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9319c8879fdd796d7293beca8f5017a4024bdbd9
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri May 22 12:29:11 2020 +0200
Bug 24031: Add safety checks in Koha::Plugins::call
- Check that the plugin has the method before calling it
- Call the method in an eval block to prevent fatal errors
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e5e058e39fa97e5732f514ded46128b666bfba99
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri May 22 12:28:17 2020 +0200
Bug 24031: Remove check for syspref UseKohaPlugins
UseKohaPlugins has been removed by bug 20415
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 04afc1678a4e2b642de4c07402329248c7fc2137
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Nov 21 08:08:38 2019 -0500
Bug 24031: Fix warnings
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d8c137a718cdb344b2910f449e3a8a73e4362263
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Nov 13 11:11:54 2019 +0100
Bug 24031: Add plugin hook after_hold_create
It is called after a hold has been placed
Test plan:
1. Write a plugin that implements only after_hold_create (see
`perldoc Koha::Plugins` for implementation details). Install it and
enable it
2. Place a hold and verify that your plugin method has been called with
the right parameters
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9932ce33156305d7ebe3c8192bda8f1450f20b2a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jul 23 11:00:11 2020 -0300
Bug 25855: (QA follow-up) Simplify payload
This patch makes the hook be passed the Koha::Checkout object instead
of a hand-crafted list of attributes.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2ac260ca6c0716c47d7138aeeeabb80a50599f75
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Jul 3 10:26:06 2020 -0300
Bug 25855: (QA follow-up) Generalize hook and simplify tests
This patch generalizes the hook so it can be used by other circulation
actions.
Tests are also simplified by mocking some of the (extensive) plugin
hooks.
To test:
1. Repeat the test plan on the original patch
=> SUCCESS: All good
2. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b78356cafd066cfe37366ca19e2556f69da200be
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jun 23 16:23:06 2020 -0300
Bug 25855: Add a post_renewal_action plugin hook
This patch adds a new hook to notify plugins about renewal actions. To
test it:
1. Apply the unit tests
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t
=> FAIL: The tests expect some warnings to show, and they don't (i.e.
the sample plugin hook is not being called).
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! The hook is being called on renewal!
5. Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7e9d01d0fa75017698e6558f19105b7446821267
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jun 23 16:18:54 2020 -0300
Bug 25855: Unit tests
This patch adds tests fr a new circulation hook for plugins.
In this case the post_renewal_action hook,
The tests add the hook to the Test plugin, and verify that all the
required parameters are passed for the plugin hook to use them.
It relies on throwing an exception that is to be caught.
Sponsored-by: ByWater Solutions
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9676f537a448d50770c90d9d5a8b420a1f302444
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jul 8 16:54:51 2020 -0300
Bug 25961: Add hooks for plugins to inject variables to OPAC XSLT
This patch adds the following plugin hooks:
- opac_results_xslt_variables
- opac_detail_xslt_variables
This hooks will inject variables returned by the plugin in the form of a
hashref, into the ones that are passed to the XSLT processing code.
To test:
1. Apply the 'DO NOT PUSH' commit
2. Install the Kitchensink plugin
3. Restart all
4. Search biblios in the OPAC
=> SUCCESS: A text is injected in front of the biblio title
5. Enter the detail page of any of the results
=> SUCCESS: A text is injected in front of the biblio title
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 50ebed51ee160992e22cde55dcd657beb7429f8f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jul 30 15:21:50 2020 +0000
Bug 24157: DBRev 20.06.00.018
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5aba38fdaec2958a23f0ccaa57b4c951af1244ce
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jul 24 13:03:31 2020 +0200
Bug 24157: Handle the case where logged in user does not have edit_invoices
This patch make possible the reopening and merging of invoices even if
the logged in user does not have the edit_invoices permission
I don't think it really makes sense but at least it's now possible.
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 110e0acb5c33f96b9cb61286fc45d480b088f565
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 21 11:09:50 2020 +0200
Bug 24157: (follow-up) New permission - delete_invoices
Hide the "Delete" invoice link if necessary on
/cgi-bin/koha/acqui/invoice.pl?invoiceid=X
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4b6d8bb0b6e0fc1e78ffa063740ca605e0efc367
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 21 11:03:07 2020 +0200
Bug 24157: New permission - merge_invoices
Add a new permission to merge invoices
Test plan:
- Remove the new permission "merge_invoices" for a given patron,
use it to log in into Koha
- Create 2 invoices, try to merge them
=> There is no way to merge it
- Add the permission
=> Now you can merge the invoices
Sponsored-by: Galway-Mayo Institute of Technology
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6638e9de8c405e119a3816516a3340e84f5d8793
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Mar 6 19:13:35 2020 +0000
Bug 24157: (follow-up) Conditionally show controls to reopen and close invoice
This follow-up makes minor changes to the template so that the checkbox
for reopening or closing an invoice are not displayed when the user
doens't have the correct permissions.
To test, apply the patch and try the process of viewing or editing an
invoice as a user with these various permissions:
- edit_invoices ON
- edit_invoices OFF
- reopen_closed_invoices ON
- reopen_closed_invoices OFF
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6b984a0feb29aede7a569dddd6aae35b13eed5cf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 11 16:39:36 2019 +0100
Bug 24157: New permission - delete_baskets
Add a new permission to delete acquisition baskets
Test plan:
- Remove the new permission "delete_basket" for a given patron,
use it to log in into Koha
- Create basket, try to delete it
=> There is no way to delete it
- Add the permission
=> Now you can delete the basket
Sponsored-by: Galway-Mayo Institute of Technology
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7fb8f3638859b1e27c2954363b175030fadbee17
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 11 16:37:46 2019 +0100
Bug 24157: New permission - delete_invoices
Add a new permission to delete invoices
Test plan:
- Remove the new permission "delete_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, try to delete it
=> There is no way to delete it
- Add the permission
=> Now you can delete the invoice
Sponsored-by: Galway-Mayo Institute of Technology
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 41c6940fcdb6522efef68430dcf88683e1831e63
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Dec 13 17:37:36 2019 +0100
Bug 24157: Add new method Acq::Invoice::Adjustement->fund
Moving to its own commit in case we want to cherry-pick or move it to
its own bug report.
Sponsored-by: Galway-Mayo Institute of Technology
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d3c8b8fe54b999a6d7f10ab6f6cc49db96edfd53
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 10 21:05:40 2019 +0100
Bug 24157: New permission - edit_invoices
Add a new permission to edit invoices
Test plan:
- Remove the new permission "edit_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, edit it (click "detail")
=> You can see the detail of the invoice, but cannot edit it. It's a read-only view.
- Add the permission
=> The form is back and you can modify the invoices and save the changes.
Also, you are able to create adjustments.
Sponsored-by: Galway-Mayo Institute of Technology
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f10acb07e68f10a69e087012e47ae210cd609783
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 10 20:03:28 2019 +0100
Bug 24157: New permission - reopen_closed_invoices
New permission to reopen a closed invoice.
Test plan:
- Remove the new permission "reopen_closed_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, close it
=> You are not able to reopen the invoice
- Add the permission
=> You are able to reopen the invoice
Sponsored-by: Galway-Mayo Institute of Technology
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8f7bf2a6b4ab8d4d0be3b522753a8fd17d9fc54f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jul 30 15:21:50 2020 +0000
Bug 25709: DBRev 20.06.00.017
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5e45076c00b2f72537ba9c81c4535253f1aaadfb
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Jul 6 17:56:35 2020 +0000
Bug 25709: Rename systempreference to NotesToHide
In an effort to use more inclusive language we have added a new coding guideline:
https://wiki.koha-community.org/wiki/Coding_Guidelines#TERM3:_Inclusive_Language
This patchset renames a syspref to be clearer and follow the guideline
To test:
1 - Apply patch and updatedatabase
2 - git grep NotesBlacklist
3 - Note all remaining occurrences are translations, db updates, and release notes
4 - Add a field (e.g. '520' ) to the NotesToHide systempreference
5 - View a record with a 520 field on the opac
6 - Confirm the field does not show in the 'Title notes' tab
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 00a3aa21e86719dd702215150a4571219c434ddd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 27 14:59:59 2020 +0200
Bug 25811: Debug - Paste the source of the page
I am really struggling finding the problem here.
Posting the source of the page may help.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 33 +--
C4/Circulation.pm | 30 +-
C4/Reserves.pm | 3 +
Koha.pm | 2 +-
Koha/Acquisition/Invoice/Adjustment.pm | 18 +-
Koha/Item.pm | 24 +-
Koha/Plugins.pm | 53 ++++
acqui/addorderiso2709.pl | 3 -
acqui/basket.pl | 9 +-
acqui/booksellers.pl | 3 -
acqui/duplicate_orders.pl | 4 +-
acqui/invoice.pl | 41 ++-
acqui/neworderempty.pl | 3 -
acqui/orderreceive.pl | 3 -
acqui/parcels.pl | 3 -
admin/columns_settings.yml | 17 ++
debian/control | 2 +
debian/list-deps | 5 +-
installer/data/mysql/sysprefs.sql | 4 +-
installer/data/mysql/updatedatabase.pl | 51 ++++
installer/data/mysql/userpermissions.sql | 5 +
koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss | 6 +-
.../intranet-tmpl/prog/css/src/staff-global.scss | 21 ++
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../prog/en/includes/blocking_errors.inc | 2 +
.../en/includes/member-display-address-style.inc | 130 ++++-----
.../intranet-tmpl/prog/en/includes/permissions.inc | 25 ++
.../intranet-tmpl/prog/en/modules/acqui/basket.tt | 5 +-
.../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 311 +++++++++++++--------
.../prog/en/modules/acqui/invoices.tt | 98 ++++---
.../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 4 +-
.../prog/en/modules/admin/aqbudgetperiods.tt | 4 +-
.../en/modules/admin/preferences/cataloguing.pref | 2 +-
.../prog/en/modules/admin/preferences/opac.pref | 7 -
.../prog/en/modules/admin/preferences/tools.pref | 8 +-
.../prog/en/modules/cataloguing/additem.tt | 2 +-
.../en/modules/members/tables/members_results.tt | 10 +-
.../prog/en/modules/plugins/plugins-home.tt | 2 +-
.../prog/en/modules/tools/koha-news.tt | 70 +++--
.../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 12 +-
koha-tmpl/intranet-tmpl/prog/js/viewlog.js | 6 +
.../bootstrap/en/includes/doc-head-close.inc | 8 +
.../bootstrap/en/includes/opac-bottom.inc | 19 +-
koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 44 +--
.../bootstrap/js/googleindictransliteration.js | 27 --
opac/opac-detail.pl | 16 ++
opac/opac-main.pl | 5 -
opac/opac-search.pl | 18 +-
opac/opac-shelves.pl | 3 +-
t/Biblio/GetMarcNotes.t | 4 +-
.../Koha/Acquisition/Invoice/Adjustments.t | 10 +-
t/db_dependent/Koha/Plugins/Circulation_hooks.t | 106 +++++++
...blio_and_Items_plugin_hooks.t => Holds_hooks.t} | 56 ++--
t/db_dependent/Koha/Plugins/Plugins.t | 30 +-
t/lib/Koha/Plugin/Test.pm | 25 ++
t/lib/Selenium.pm | 6 +
56 files changed, 961 insertions(+), 459 deletions(-)
delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/js/googleindictransliteration.js
create mode 100755 t/db_dependent/Koha/Plugins/Circulation_hooks.t
copy t/db_dependent/Koha/Plugins/{Biblio_and_Items_plugin_hooks.t => Holds_hooks.t} (50%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list