[koha-commits] main Koha release repository branch master updated. v20.05.00-470-g09ed4c0dd7

Fri Jul 31 11:25:18 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  09ed4c0dd7277931c1e631c5b1329463fc9751e5 (commit)
       via  4921ad8ae42c04415347d2d0bce4a5ed7af395a3 (commit)
       via  e330e4ec222f8ac3a04339a020509e30aa0bf3ab (commit)
       via  0a9d3f17d9e44b5326a42d14420d30243031629d (commit)
       via  d5d221160184120140950112ef8edfb0ea476949 (commit)
      from  3ae472ba5d9b7bfe6c6e44320ca020c9cf111b01 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 09ed4c0dd7277931c1e631c5b1329463fc9751e5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jul 30 10:57:53 2020 +0200

    Bug 25887: Keep library filter on the fund list view

    The problem:
    When filtering funds by library, the pull down for libraries resets to "empty" when the page is reloaded,
    although the filter criteria is visible in the URL.

    Test plan:
    Create a fund for library A
    Create a fund for library B
    Go to the fund list view
    => All funds are listed
    Select library A in the library filter, click "Go"
    => Funds for library A are listed
    => Library filter has "library A" selected
    Edit fund for library B
    => The edit form has "library B" selected

    Signed-off-by: Holly Cooper <hc at interleaf.ie>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4921ad8ae42c04415347d2d0bce4a5ed7af395a3
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Jul 29 20:01:24 2020 +0000

    Bug 26093: Markup error after Bug 24279 creates formatting problem

    This patch makes a few minor changes to the markup of the item detail
    page in order for everything to be valid and styled correctly:

    - Remove unnecessary and invalid <br clear="both"/>
    - Move heading inside container so that floats clear correctly
    - Change <span> tag back to <div> to enable the correct style.

    To test, apply the patch and view the item details page for a title with
    multiple items.

     - Each section starting with "Barcode" should be bordered above by a
       two-pixel gray line
     - The "statuses" section should be styled like the areas above and
       below, not as an ordered list.

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e330e4ec222f8ac3a04339a020509e30aa0bf3ab
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jul 30 11:59:44 2020 +0200

    Bug 25852: Add tests

    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0a9d3f17d9e44b5326a42d14420d30243031629d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jul 30 12:00:03 2020 +0200

    Bug 25852: Improve C4::Creators::Lib reliability under plack

    This is certainly a major issue that leads to many side-effects.
    Under plack, the structure of the default values are not handled
    correctly.
    Package variables are used to store stuff like the "layout type". They
    are complex structures (arrays of hashes) and returned without being
    copied.
    When the caller (the controller script) retrieve them then modify the
    returned structures, it actually modifies the package's variables.

    One of the issue is:
    Create a new layout
    The script retrieve a structure with all "selected" flags are set to 0
    It select the first one as default (BAR as selected => 1)
    The user creates the new layout and will selected BIBBAR (for instance)
    If you then edit this new layout, the script will retrieve the
    "label_types" and set "selected" for BIBBAR. However BAR is still
    selected!
    The UI receives 2 selected and display the first selected one that has
    the selected option.

    Test plan:
    1. Create a layout type for Barcode/Biblio
    2. Choose fields to print and size of font
    3. Save
    4. Edit existing Layout
    => Withtout this patch "Barcode" is the preselected option
    => With this patch applied, the correct "Barcode/Biblio" option is
    selected

    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit d5d221160184120140950112ef8edfb0ea476949
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jul 31 09:49:06 2020 +0200

    Bug 26108: (bug 25855 follow-up) Call after_circ_action hook only if issue exists

    AddReturn can be called on an item even if it's not checked out (to
    trigger holds for instance).
    The hook should (?) not be called in that situation

    Test plan:
    Confirm the above and that the following tests are now passing:
     t/db_dependent/SIP/Message.t
     t/db_dependent/Reserves.t
     t/db_dependent/Circulation/issue.t
     t/db_dependent/SIP/Transaction.t
     t/db_dependent/Circulation.t

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                        | 16 +++++++++-------
 C4/Creators/Lib.pm                                       | 16 ++++++++--------
 .../intranet-tmpl/prog/en/modules/admin/aqbudgets.tt     |  2 +-
 .../prog/en/modules/catalogue/moredetail.tt              | 10 +++++++---
 t/db_dependent/Creators/Lib.t                            |  7 ++++++-
 5 files changed, 31 insertions(+), 20 deletions(-)

hooks/post-receive
-- 
main Koha release repository