[koha-commits] main Koha release repository branch master updated. v20.05.00-476-gcb5acdc670

Fri Jul 31 15:46:14 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  cb5acdc6702cef4668921ccf2537797358981fff (commit)
       via  622ea4627ae50c49f7547ee3a3a8b4bde18e17a3 (commit)
       via  b0eee4d2e1359050cee3dd23a121e75195b0ce11 (commit)
       via  ce441708906fa282e000f523243ded20541970cc (commit)
       via  a51b06001f2f8e42efc48d1898060f1d8d23ae62 (commit)
      from  67f6ceecd314fadd96e3dbc5fc543dd0528b050a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cb5acdc6702cef4668921ccf2537797358981fff
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Thu Jun 25 11:25:41 2020 +0400

    Bug 25873: Ignore malformed data for Elasticsearch integer fields

    If we try to put malformed data into an integer field, Elasticsearch
    rejects the whole document.
    Setting 'ignore_malformed' to true allows to ignore malformed data and
    process the other fields of the document normally

    https://www.elastic.co/guide/en/elasticsearch/reference/7.8/ignore-malformed.html

    Test plan:
    * Without the patch
      1. In search engine configuration, change the type of a text field to
      'Number' (for instance 'title')
      2. misc/search_tools/rebuild_elasticsearch.pl -d -b
      3. See that the index is empty (unless you have titles consisting only
      of digits)
    * With the patch
      1. misc/search_tools/rebuild_elasticsearch.pl -d -b
      2. Now records are correctly indexed

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 622ea4627ae50c49f7547ee3a3a8b4bde18e17a3
Author: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Date:   Wed Jul 29 15:58:42 2020 +0000

    Bug 26084: Clarify language on ConsiderOnSiteCheckoutsAsNormalCheckouts

    To test:
    - apply patch
    - confirm explanation reads as suggested

    Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b0eee4d2e1359050cee3dd23a121e75195b0ce11
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jul 31 11:53:53 2020 +0200

    Bug 26111: Add "Serials" (SER) to the reports dictionnary

    It's missing in the template

    Test plan:
    Go go Home › Reports › Guided reports wizard › Dictionary
    At step 2, notice that with this patch you have "Serials" in the
    dropdown list (instead of an empty entry)

    Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit ce441708906fa282e000f523243ded20541970cc
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jul 31 09:52:10 2020 -0300

    Bug 26108: Only call the plugin hook if a return took place

    This patch makes the hooks be called only if the checkin is effective
    (i.e. if it is not rejected for some reason.

    To test:
    1. Apply the regression tests patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t
    => FAIL: Tests fail
    3. Apply this patch
    4. Repeat 2
    => SUCCESS: Tests pass!
    5. Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a51b06001f2f8e42efc48d1898060f1d8d23ae62
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jul 31 09:47:56 2020 -0300

    Bug 26108: Regression tests

    The current implementation makes the assumption that if $issue is
    defined, then it is the 'return' use case. This is correct, but
    incomplete: after verifying that there's actually an issue, the return
    can be rejected for various reasons.

    This patch introduces a regression test for one of those situations
    (which I consider enough for testing purposes) . It highlights that the
    hook shouldn't be called if there hasn't been an actual checkin.

    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t
    => FAIL: Tests fail because there's an unexpected warining printed by
    the erroneous plugin call (i.e. there's been no return but the plugin is
    called anyway).

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                            |  4 ++--
 admin/searchengine/elasticsearch/field_config.yaml           |  1 +
 .../prog/en/modules/admin/preferences/circulation.pref       |  2 +-
 .../intranet-tmpl/prog/en/modules/reports/dictionary.tt      |  1 +
 t/db_dependent/Koha/Plugins/Circulation_hooks.t              | 12 +++++++++++-
 5 files changed, 16 insertions(+), 4 deletions(-)

hooks/post-receive
-- 
main Koha release repository