[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.02-108-g51cd56ddb3

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 20.05.x has been updated
       via  51cd56ddb37dbb3c92105d948b8a83b98ad6bcfb (commit)
       via  bc1e7669bd2b1abccba7b1975b66adac0de550d2 (commit)
      from  ddfec0a706c2233ea60bbdb990b5368ceebc982f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 51cd56ddb37dbb3c92105d948b8a83b98ad6bcfb
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jun 12 10:51:36 2020 +0000

    Bug 25724: Do not call ModReserveStatus when completing transfer
    
    I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL
    That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due
    to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0
    
    Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status.
    
    ModReserveStatus also calls CartToShelf regardless of what happens here.
    
    To test:
    1 - Set  UpdateItemLocationOnCheckin  to:
        _ALL_: CART
    2 - SetAutomaticItemReturn = Do
    3 - Check an item in at a different branch than it's homebranch to create a transfer
    4 - Check the item in at it's homebranch
    5 - View the item details page
    6 - Item is not in CART location
    7 - Apply patch
    8 - Repeat
    9 - Item is in CART location after completion of transfer
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Jason Robb <jrobb at sekls.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit e025cd76437b212746717ad54b5da22e410bbe8f)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit bc1e7669bd2b1abccba7b1975b66adac0de550d2
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jun 12 11:11:26 2020 +0000

    Bug 25724: Unit tests
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    
    Signed-off-by: Jason Robb <jrobb at sekls.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 028e9a07db625845482eff1b550a9bbe86ec6fbc)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                  |  2 --
 t/db_dependent/Circulation/issue.t | 12 +++++++++++-
 2 files changed, 11 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository