[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.11-17-g1079e73632

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  1079e736329d797470cc4758640f45cdfb68a227 (commit)
      from  bab4bb9adb4db0b20ef94771ef78ecf654497788 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1079e736329d797470cc4758640f45cdfb68a227
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu May 21 12:00:34 2020 +0200

    Bug 25563: (bug 24386 follow-up) Don't disable submit button if form has not been submitted yet
    
    On bug 24386 we prevent double form submission using the our own preventDoubleFormSubmit JS function.
    
    The problem is that we are checking some conditions, and prevent the
    form submission if something is not filled (for instance no checkbox
    checked, or no fund selected).
    
    Technically it means that:
    - click the submit button
    - it submits the form
    - we disable the submit button
    - we prevent the form to be submitted before something is wrong
    At this stage the button is disabled and the form cannot be longer be
    submitted.
    
    This patch replaces the "on submit" event of the form with the "on click" event of the submit button.
    Which means we are going to:
    - click the submit button
    - we prevent the form to be submitted before something is wrong
    => The button will only be disabled if the form is really submitted
    
    Test plan:
    - stage a marc record
    - acquisitions: have a basket
    - click on "Add to basket"
    - "From a staged file"
    - Don't tick the record
    - Save
    - You should see an expected error message
    - Tick the record
    - Save
    - You should see an expected error message
    - Choose a fund
    - Click the "Save" button as many times as you can, to try double submit
    it.
    => The order is saved
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 37370c415ab5e59422aff46be14ccfec0cf8c373)
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    (cherry picked from commit 74b4b64bf94ec60c2b6a01e4dbfad67216ffeeb1)
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt | 2 +-
 koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js               | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository