[koha-commits] main Koha release repository branch master updated. v20.05.00-86-g21cde7bd2f
Git repo owner
gitmaster at git.koha-community.org
Mon Jun 15 12:22:11 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 21cde7bd2f6380129c4a7fb7e4d3aecf4dcb6de0 (commit)
via 85c1537bd7e4002a59c3c3eba6d2180911d8b7c3 (commit)
via 9681b8a1ca4cf4a92642ca262778a28af05b93d1 (commit)
via ee657b6e5aa0dc9a292260b01dc810fe3d5e2f50 (commit)
via 6beda5cf1d1bb76ac692f5443e4b75f727c9c4ba (commit)
via 488a9fc8ed956a6c516e2fa79caf189dce9d63a2 (commit)
via 941989827b12fb54ceefc72dbc26f2727acf2a44 (commit)
via 758b60f711ff97629d5f9cebabd64cec4edb1aca (commit)
via 4a4d3ef0d8a759a485cc5f16e363bfb1f1177ab3 (commit)
via ac973d2d440f90ec2d9f55dd4e2c6c13a45faaec (commit)
via c32d71978c47cc810d5de8c20df89866b2ce417b (commit)
via cfd97049a335d50d633d4c47164d223fcc03cad2 (commit)
via fdca61a7455bb5bdca32a718a43a7e2688bcea46 (commit)
via 814a7ecf47b087a60b35bca6a4d23deeb596a0e8 (commit)
via 953a53d9d6bffbad9303532c113f50864a03a0ae (commit)
via 3e1d0068e8d3a8f94cc5153c3cff9781ed9e142d (commit)
via c2127901da52e0c35124b97ff4626d3ea943e655 (commit)
via 40aaf25409921b1414396bb1aa2146b63d432339 (commit)
via 7eb471fcdb113e158d819932116c546a53ee5845 (commit)
via a17c0475d8fff517eaf3a0da6dfaa65d43bde9f3 (commit)
via 051b0b8d2fb3dc3593147e5ac80bc394dcf48e58 (commit)
via 772205bab5c7d6720ca6d25244c04cdf7649a96f (commit)
via 8ab8df3866352568509ed34f02a5566e750dee21 (commit)
via 50b6e447735ee31a2fbba5b116959cdb6d451c19 (commit)
via 58c389bf279ca6ffdea199ada8d65ce92baaf952 (commit)
via 4f70682c56dddd42f24c62d7634f5cd3b7119702 (commit)
via f898cef4f4b5a9f424f968a58b96898f26f80035 (commit)
via 257e75093258cda2687eddff9e57e0c498457fe2 (commit)
via ada13a39825d666ad75a7510530abe5542803ee6 (commit)
via 3e4b92d84c50bee27b2f331e5fbbc04813e469bb (commit)
via 4116ca4097732977d7b954a881f191174c28d651 (commit)
via 9f1000638f156c27a82ad9d2c2e25714e6f1ec83 (commit)
via 953d0d89d0597b23527c9d57d35885a86f93d6b2 (commit)
via e9f4d3bd76fc9764d58e4cb3ac8fb3eda6a939ca (commit)
via 2d7e08bc0e8c1ab6f21cce06932bb7dd6660cfcd (commit)
via 6fc316d2eef5945b20a14bec81e2daa57696dd81 (commit)
via 14c5512306c2e0c6fc21bbd378cc5bff0169ec68 (commit)
via 7531f66a921089b8b4bae60cf607820b4c483af0 (commit)
via 3ce4024fcb9cc581ab0f5f6acb504d8e4bf904e9 (commit)
via 9e1d4c978d5954c27cd016f636a03942ede6c406 (commit)
via 941b5aaecc0c528a30abf47b433c3805338ff09a (commit)
via 4d9ca6b13d29acc088777e9df414aaa54be4e389 (commit)
via 7de78ab092f7355a15de60e9a2842d9577777581 (commit)
via d21ad9fe11bdbd8c49eb3d64bb24c414bea8a1f7 (commit)
via f98f2edf0a1515ce727e670ecaecd4f9295f34cb (commit)
via 286a739b5cd906a55b2dc97e6ab1ef9ffb00a6f7 (commit)
via 73e5032c4bf52ee72972a6fe8182d3fd5737716c (commit)
via 8e00a96cf17f9c429050ce2ce5e3095fe566121a (commit)
via b16e463173e8125396eaef3159d08df5d0d2cfb6 (commit)
via 2b05647b6361b1a805ae856e81a3e7db0cb3394b (commit)
via 77c945d380975bb18b292e5bb28dd6942dc1288f (commit)
via 35bb41dfc14603d85a6ddb85fec9b4de8d1a4001 (commit)
via d6696944267ca1afd7682193ddf3680a905a773d (commit)
via ca7eb99eef2d1ae0258318310e402069194e999b (commit)
via 6b2d8b6779df37fa6be58f0313f4c128b183e4f6 (commit)
via 682d7896dd8e91fe846221d9605f79ca44d16360 (commit)
via f1a3fad1fc5c3949fbc14df42af49acc88a633ff (commit)
via bbac95d9fbbcc0b586a7bc094f421c35a7d71011 (commit)
from 9ac43fd97b58120560a33e26509d5acc712c97fb (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 21cde7bd2f6380129c4a7fb7e4d3aecf4dcb6de0
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri May 1 16:28:25 2020 +0000
Bug 10910: (follow-up) Move the suggestions note with the other non-blocking notes
To test:
- Add a credit to the patron's account
- Make sure they got a pending suggestion
- Try to delete
- Verify you notes for both as list items
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 85c1537bd7e4002a59c3c3eba6d2180911d8b7c3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun May 5 09:42:45 2019 -0500
Bug 10910: Add a warning when deleting a patron with pending suggestions
Test plan:
From the OPAC, add a suggestion
From the staff interface, try to delete the patron who created the
suggestion
=> You get a warning message
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9681b8a1ca4cf4a92642ca262778a28af05b93d1
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Jun 14 14:02:49 2020 +0200
Bug 12093: (QA follow-up) Fix typo 'noteforloan'
Just changes one character in the noteforloan class to notforloan.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ee657b6e5aa0dc9a292260b01dc810fe3d5e2f50
Author: David Roberts <david at koha-ptfs.co.uk>
Date: Sat May 9 22:14:10 2020 +0000
Bug 12093: Add CSS classes to item statuses in detail view
This patch adds classes where necessary to detail.pl
To test:
1) Apply patch
2) View source of /cgi-bin/koha/catalogue/detail.pl to check that there
are no orphaned statuses without classes.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6beda5cf1d1bb76ac692f5443e4b75f727c9c4ba
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Oct 17 19:56:12 2018 +0000
Bug 21591: Check for record level item type issues too
To test:
1 - sudo koha-mysql kohadev
2 - UPDATE biblioitems SET itemtype = NULL where biblionumber = 1
3 - UPDATE items SET itype = NULL where biblionumber = 1
4 - perl misc/maintenance/search_for_data_inconsistencies.pl
5 - Notice warnings
6 - Apply patch
7 - Undefined itemtype on bibliolevel is now warned
7 - Test also with itype=""
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 488a9fc8ed956a6c516e2fa79caf189dce9d63a2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jun 15 11:45:31 2020 +0200
Bug 24405: Compiled CSS
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 941989827b12fb54ceefc72dbc26f2727acf2a44
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri May 8 13:42:55 2020 +0000
Bug 24405: Make OPAC link underlining consistent
This patch makes a minor modification to the OPAC CSS so that links are
consistently displayed without underlines in their inactive state. This
corrects two cases: Links in the facets sidebar and "Check all/none"
links shown on search results.
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
- In the OPAC, perform a search.
- In the search results facets sidebar, confirm that links are not underlined.
- At the top of the search results table, confirm that the "Select all"
and "Clear all" links are not underlined.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 758b60f711ff97629d5f9cebabd64cec4edb1aca
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Jun 4 01:07:24 2020 +0000
Bug 25070: (QA follow-up) Fix capitalization: Street Number
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4a4d3ef0d8a759a485cc5f16e363bfb1f1177ab3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 6 14:42:40 2020 +0200
Bug 25070: Centralize member-main-address-style
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ac973d2d440f90ec2d9f55dd4e2c6c13a45faaec
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 6 14:25:48 2020 +0200
Bug 25070: Centralize member-display-alt-address-style
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c32d71978c47cc810d5de8c20df89866b2ce417b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 6 14:20:34 2020 +0200
Bug 25070: Centralize member-display-address-style
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cfd97049a335d50d633d4c47164d223fcc03cad2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 6 14:09:06 2020 +0200
Bug 25070: Centralize member-alt-contact-style
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fdca61a7455bb5bdca32a718a43a7e2688bcea46
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 6 13:53:17 2020 +0200
Bug 25070: Centralize member-alt-address-style
There are 5 includes files per value of AddressFormat (us, de, fr).
The code is duplicated for each language, the only thing that changes is the order.
Wwith this patchset we are going to refactore them to avoid further regressions.
The idea is to remove all code that is duplicated and remove the need of
having 5*3 files. We are going to limit them to 5 files, 1 per use.
Note that we could go even further, for instance
member-display-alt-address-style and member-display-address-style are
quite identical.
Test plan (for the whole patchset):
- Create a patron with all the address, contact and alternate info filled
- Edit them and save
- Look at the patron's info (top left) in the patron module, and the
patron detail view.
- Play with the different values of AddressFormat
The order and the info must be displayed identically before and after
this patchset. No change is expected.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 814a7ecf47b087a60b35bca6a4d23deeb596a0e8
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon May 4 12:36:57 2020 +0000
Bug 25363: Merge common.js with staff-global.js
This patch merges the contents of common.js with staff-global.js. Both
are included globally in the staff interface, and there doesn't seem to
be any reason to require that the user downloads two different
JavaScript files.
To test, apply the patch and perform a catalog search in the staff
client.
View the detail page for a title in the search results. On the detail
page you should see navigation controls in the sidebar for browsing
through search results. Confirm they work correctly.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 953a53d9d6bffbad9303532c113f50864a03a0ae
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jun 4 12:33:47 2020 +0000
Bug 25593: Terminology: Fix "There is no order for this biblio." on catalog detail page
This patch changes the phrase "There is no order for this biblio" to
"There is no order for this bibliographic record." on the catalog
detail page.
To test, apply the patch and view the bibliographic detail page for a
record which has no order associated with it. The text in the
"Acquisitions details" tab should be correct.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3e1d0068e8d3a8f94cc5153c3cff9781ed9e142d
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Jun 4 00:09:48 2020 +0000
Bug 25627: Fix class and id in body tag
This will also help if you want to use different colors
for different modules.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c2127901da52e0c35124b97ff4626d3ea943e655
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jun 4 11:51:38 2020 +0000
Bug 25627: Move OPAC problem reports from administration to tools
This patch moves the OPAC problem report management page from the
Administration section to the Tools section.
I think this makes sense because management of reports is an ongoing
task, not a configuration.
To test, apply the patch and enable the OPACReportProblem system
preference.
- Go to Administration. There should be no link to OPAC problem
reports.
- Open an administration page which shows the Administration menu in
the left-hand sidebar, e.g. Libraries. There should be no link to
OPAC problem reports in the menu.
- Go to Tools. There should be a link to OPAC problem reports in the
"Addional tools" section.
- Open the OPAC problem reports page and confirm that it works
correctly.
- The breadcrumbs menu should show "Tools > OPAC problem reports."
- Confirm that the link in the sidebar menu works correctly.
- If necessary, submit an OPAC problem report via the OPAC so that
there is a pending report. Go to the staff interface home page and
check that the "OPAC problem reports pending" link works correctly.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 40aaf25409921b1414396bb1aa2146b63d432339
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Jun 9 20:05:48 2020 +0000
Bug 25687: Switch Y/N in EDI accounts table for Yes and No for better translatability
This patch changes the list of EDI accounts shown in EDI administration
so that columns which previously used "Y" or "N" now show "Yes" or "No."
To test, apply the patch and go to Administration -> EDI accounts.
If necessary, add an EDI account. In the table of information about the
EDI account, the columns with information about quotes, orders,
invoices, responses, and auto-ordering should show "Yes" or "No" based
on the account's settings.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7eb471fcdb113e158d819932116c546a53ee5845
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Tue May 19 13:21:44 2020 -0300
Bug 25346: Supress warning message when install dir exists
To see it enable verbose mode
To test:
1) Install lang with install dir
(cd misc/translator; ./tranlste install de-DE)
check message: "de-DE installer dir /...mysql/de-DE already exists."
2) Apply patch
3) Repeat 1, now message is gone
4) Repeat 1 in verbose mode (./translate install de-DE -v)
check the message now appears at the bottom.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a17c0475d8fff517eaf3a0da6dfaa65d43bde9f3
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Jun 2 11:08:23 2020 +0000
Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports
This patch makes a minor correction to the template to correct the check
on outstanding OPAC problem reports. An error was preventing the check
from working correctly.
To test, apply the patch and enable the OPACReportProblem system
preference.
- On the staff interface home page, check the area showing pending
operations (suggestions, tags, etc.).
- If you have no pending OPAC problem reports there should be no line
for OPAC problem reports.
- If necessary, mark all pending OPAC problem reports closed and
confirm that when there are no outstanding reports the link is
hidden.
- Also test when there are no other outstanding reports in that
section (suggestions, tags, patron modifications), nothing appears
at all, not even the surrounding border.
- If necessary, test that the link appears when you have one or more
OPAC problem reports.
- Go to the OPAC and use the "Report a problem" to submit a test
report.
- Check that the staff interface home page reflects that there is
now a pending report.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 051b0b8d2fb3dc3593147e5ac80bc394dcf48e58
Author: David Roberts <david at koha-ptfs.co.uk>
Date: Sat May 9 16:07:03 2020 +0000
Bug 22470: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl
This patch adds the table name to the SQL update statements.
To test:
1) Apply the patch
2) Run the script. Check that there are no errors, and that the script
behaves as expected.
Signed-off-by: Andreas Roussos <a.roussos at dataly.gr>
Created a test record with values in field 440. Applied the patch, ran the
script with the -c -f flags and observed that the values were moved to field
490. Also, the relevant Koha to MARC mappings were changed accordingly.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 772205bab5c7d6720ca6d25244c04cdf7649a96f
Author: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Date: Wed May 6 16:22:57 2020 -0400
Bug 25394: Cronjob path in the AuthorityMergeLimit syspref description is wrong
Test plan:
1- Apply patch
2- Go to Administration > Global system preferences > Authorities
3- The path to merge_authorities.pl in the AuthorityMergeLimit
description should now read misc/cronjobs/merge_authorities.pl
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8ab8df3866352568509ed34f02a5566e750dee21
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu May 21 13:52:32 2020 -0400
Bug 25537: Page reload at branchtransfers.pl loses destination branch
At branchtransfers.pl, one selects a destination branch and scans in any
number of items to generate transfers to that branch. However, anything
that makes the page reload causes your branch selection to be lost,
reverting you back to whichever branch comes first alphabetically.
This is an invitation to error when one has a stack of books to
send all to the same branch. Could that error handling get moved
into a modal or something that won't reload the page?
Test Plan:
1) Place a hold on an item and set it to waiting
2) Initiate a branch transfer from branchtransfers.pl for any branch but
the first in the pulldown branch selector
3) Choose to cancel the hold and transfer
4) Note the pulldown reverts to the first option
5) Apply this patch
6) Repeat steps 1-3
7) Note the pulldown retains your preveiously selected branch!
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 50b6e447735ee31a2fbba5b116959cdb6d451c19
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri May 22 10:23:55 2020 +0200
Bug 25576: Add link to the manual for the ILL module
Test plan:
Enable ILLModule system preference.
Go to ILL requests
Click Help
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 58c389bf279ca6ffdea199ada8d65ce92baaf952
Author: Petro Vashchuk <stalkernoid at gmail.com>
Date: Fri May 22 18:11:28 2020 +0300
Bug 25587: fix for "clear" button to reset all selects
Button "clear" on cgi-bin/koha/admin/smart-rules.pl did not reset fields
with a dropdown selector except the first one.
This happens because jQuery selector .find("select option:first")
in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
selects only single first element in the whole group, as from jquery
doc:
> The :first pseudo-class is equivalent to :eq( 0 ). It could also be
> written as :lt( 1 ). While this matches only a single element,
> :first-child can match more than one: One for each parent.
> (https://api.jquery.com/first-selector/)
And it works if replaced by: .find("select option:first-child")
To reproduce:
1) Go to /cgi-bin/koha/admin/smart-rules.pl
2) Start editing one of existing rules or filling a new one, change
all selects to have non-first option selected. Fill text input
fields with sample data.
3) Reset all fields with the "clear" button.
4) Observe that only the first dropdown field was reset to the first
option while all others still contain previously given values,
meanwhile all text input fields are cleared as expected.
5) Apply the patch.
6) Repeat steps 1, 2 and 3.
7) Check that all dropdown fields were reset to first option, as
expected.
Mentored-by: Andrew Nugged <nugged at gmail.com>
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4f70682c56dddd42f24c62d7634f5cd3b7119702
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu May 28 12:11:37 2020 +0200
Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull"
On the "Holds to pull" view there are filters that are built on the
value of the cells.
Bug 22536 improved the ergonomic by adding a ul list, but the filters
are now broken, the ul and li tags are retrieved and put in the filter
list.
The idea of this patch is to remove the HTML tags and skip if the value
is then empty.
Test plan:
Place a hold on an item
Go to Home › Circulation › Holds to pull
Open the "libraries" filter
=> Without this patch you see empty entries
=> With this patch the filter contain only the libraries
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f898cef4f4b5a9f424f968a58b96898f26f80035
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri May 29 14:41:25 2020 -0300
Bug 25623: Make sure oauth.t rolls back the db
This patch adds a missing transaction wrapping one of the subtests. This
is probably an oversight when refactoring this file.
To test:
1. Open the patron categories page
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/oauth.t
=> SUCCESS: Tests pass
3. Reload the patron categories page
=> FAIL: There's random data in there
4. Apply this patch and repeat 2
5. Reload the patron categories page
=> SUCCESS: The random data from the previous tests is still there, but
no new random data
=> SUCCESS: Tests still pass
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 257e75093258cda2687eddff9e57e0c498457fe2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jun 15 11:22:52 2020 +0200
Bug 25658: Compiled CSS
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ada13a39825d666ad75a7510530abe5542803ee6
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jun 4 15:22:43 2020 +0000
Bug 25658: Print icon sometimes obscures patron barcode
This patch alters the style of the patron name/cardnumber label on the
checkout screen so that it has a maximum width. This will help avoid the
label being obscured by the print/close buttons displayed when
DisplayClearScreenButton is enabled.
To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
- Enable the DisplayClearScreenButton system preference.
- Check out to a patron. Resize the browser to confirm that at narrower
browser widths the patron name in the checkout form isn't obscured by
the print and clear screen buttons.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3e4b92d84c50bee27b2f331e5fbbc04813e469bb
Author: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Date: Thu Jun 4 16:21:27 2020 +0000
Bug 25675: Reword and reorganize sysprefs related to patron self modification
To Test:
1: apply patch
2: restart all
3: go to System Preferences > OPAC
4: confirm "Self registration" section is now labeled "Self registration and modification"
5: confirm OPACPatronDetails is now in the "Self registration and modification" section
6: confirm PatronSelfRegistration now reads "(Allow / Don't allow) library patrons to register for an account via the OPAC."
7: set OPACPatronDetails to Don't allow
8: set PatronSelfRegistration to Allow
9: log into the opac and verify you're not able to edit your patron details on an existing account
Signed-off-by: DonnaB <donna at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4116ca4097732977d7b954a881f191174c28d651
Author: David Cook <dcook at prosentient.com.au>
Date: Tue Jun 9 15:38:27 2020 +1000
Bug 25696: Correct "Test prediction pattern" HTML button
This patch corrects the closing tag for the "Test prediction pattern"
button from "</a>" to "</button>"
Test plan:
1. Apply the patch
2. Create a serial subscription from a new or existing bib record
3. Choose any frequency, numbering pattern, and subscription start
date you choose (ie fill out all mandatory subscription fields)
4. Click "Test prediction pattern"
5. Note that the prediction pattern appears on the right of the screen
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9f1000638f156c27a82ad9d2c2e25714e6f1ec83
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu May 21 15:46:53 2020 +0200
Bug 20783: Add missing url filters
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 953d0d89d0597b23527c9d57d35885a86f93d6b2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 12 15:13:44 2020 +0200
Bug 20783: Similar changes for OPAC
Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Jessica Zairo <jzairo at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e9f4d3bd76fc9764d58e4cb3ac8fb3eda6a939ca
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 12 12:57:32 2020 +0200
Bug 20783: Remove WWW::YouTube::Download dependency
No longer used.
Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2d7e08bc0e8c1ab6f21cce06932bb7dd6660cfcd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 12 12:54:50 2020 +0200
Bug 20783: Use iframe to embed Youtube videos
WWW::YouTube::Download is broken and not reliable.
Other alternative was to use HTML::Video::Embed but not updated since
years.
The best alternative seems to follow youtube advise and use an iframe
https://developers.google.com/youtube/iframe_api_reference
Test plan:
Put youtube video in 856$u (using different url formats, youtu.be,
youtube.com/embed, etc.)
Enable HTML5MediaEnabled and HTML5MediaYouTube and confirm that the
youtube videos are correctly embeded.
Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6fc316d2eef5945b20a14bec81e2daa57696dd81
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Nov 20 15:40:10 2019 +0100
Bug 23276: Do not display tag if pref TagsEnabled is off
If the pref TagsEnabled is off we should not display the tags at the
OPAC.
There is a message to tell that tags system is disabled, but the tags
are displayed.
We should redirect to 404 like we do in opac-topissues.pl and
opac-suggestions.pl.
Test plan:
- Turn TagsEnabled on
- Add some tags
- Turn TagsEnabled off
- Hit /cgi-bin/koha/opac-tags.pl
=> Without this patch you see a warning messaging saying that the tag
system is disabled, but the tags are displayed
=> With this patch you get a 404 redirect
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 14c5512306c2e0c6fc21bbd378cc5bff0169ec68
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jun 5 16:59:10 2020 +0200
Bug 25266: Remove uneeded var
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7531f66a921089b8b4bae60cf607820b4c483af0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon May 25 09:33:10 2020 +0200
Bug 25266: Fix error when no later order
If no late order we got:
"Argument passed to the 'IN' operator can not be undefined"
It highlights a context error
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3ce4024fcb9cc581ab0f5f6acb504d8e4bf904e9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon May 4 13:17:34 2020 +0200
Bug 25266: Remove C4::Bookseller
This was the only occurrence of GetBooksellersWithLateOrders and it was
the only subroutine of C4::Bookseller
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9e1d4c978d5954c27cd016f636a03942ede6c406
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon May 4 13:13:56 2020 +0200
Bug 25266: Build the vendor list from the order list
This patch is removing the use of GetBooksellersWithLateOrders and use
the late order list to generate the vendors.
Test plan:
Create several vendors, several orders, close the baskets
Also create vendors that do not have orders (or basket not closed)
Go to the late orders page and confirm that the list of vendors is
correctly filled, select one, you can see the "select all" link in the
header of the table
QA: that would be good to test this with production data and compare
execution time.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 941b5aaecc0c528a30abf47b433c3805338ff09a
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Tue May 5 18:04:11 2020 +0000
Bug 25349: Add checkEnter function and apply it to SCO page
This patch adds the checkEnter function to the OPAC global.js and then applies it to the SCO login page.
TO TEST:
1. Go to SCO login and try entering something in the "Login:" input amd "Password:" input.
2. Pressing enter while in either will automatically submit the form.
3. Apply patch.
4. Type something into the Login: field and press enter, the form should NOT submit.
5. Type something into the Password: field and pess enter, this SHOULD submit the form.
6. Change the syspref SelfCheckoutByLogin to 'Cardnumber'
7. Type something into the Please enter your card number: field, the form should submit.
Signed-off-by: Donnab <donna at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4d9ca6b13d29acc088777e9df414aaa54be4e389
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 26 12:28:13 2020 +0200
Bug 25434: Display selections-toolbar on small screens
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7de78ab092f7355a15de60e9a2842d9577777581
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat May 23 01:22:53 2020 +0200
Bug 25507: Fix table in basket group PDF German 2-pages
A variable was doubled up which made the columns in the
table of orders no longer line up (different number of headers
to columns).
To test:
- Create at least one basket with one or more orders
- Close the basket
- Add the basket to a basket group manually or let Koha do it
on closing
- Change the OrderPdfFormat system preference to 'German 2-page'
- Go to the basket group page and print the PDF of the basket
- Verify the table of orders doesn't look right and runs outside
the page
- Apply patch
- Repeat the PDF print - now table should look right
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d21ad9fe11bdbd8c49eb3d64bb24c414bea8a1f7
Author: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Date: Fri May 15 20:20:05 2020 +0000
Bug 25521: Remove cart_to_shelf note from NewItemsDefaultLocation syspref
To test:
1- find the NewItemsDefaultLocation syspref
2- confirm it says "NOTE: This system preference requires the misc/cronjobs/cart_to_shelf.pl cronjob. Ask your system administrator to schedule it."
3- apply patch
4- restart all
5- reload syspref, it doesn't say that anymore!
Signed-off-by: Holly Cooper <hc at interleaf.ie>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f98f2edf0a1515ce727e670ecaecd4f9295f34cb
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat May 30 00:56:04 2020 +0000
Bug 25545: (follow-up) Fix capitalization
Total + Adjustments + Shipment cost ($)
changed to:
Total + adjustments + shipment cost ($)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 286a739b5cd906a55b2dc97e6ab1ef9ffb00a6f7
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed May 27 10:38:03 2020 +0000
Bug 25545: Add adjustments to total tax included
Adjustments are not affected by tax, they are meant as a way to alter invoice
values after receiving (damaged items, refuneds, extra charges, etc)
When adjustments were added the tax included column was missed
To test:
- Add a basket with at least one order
- Close it
- Receive shipment
- Receive the order
- Finish receiving
- Add an adjustment of any amount
- Verify in the invoice details table:
- Total tax exc. is showing including the adjustmnt
- Total tax inc. is missing the adjustment
- Apply patch
- Reload
- Total tax exc. is showing including the adjustmnt
- Total tax inc. is showing including the adjustment
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 73e5032c4bf52ee72972a6fe8182d3fd5737716c
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Wed May 20 17:59:16 2020 +0000
Bug 25555: Invert patron name in holdsqueue.tt
TEST PLAN:
1. Have multiple holds from multiple patrons and run the holds queue cron to populate the holds queue list.
2. Try sorting by patron and see that is sorts based on first name.
3. Apply patch
4. Try sorting again and now it should sort by surname.
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8e00a96cf17f9c429050ce2ce5e3095fe566121a
Author: David Cook <dcook at prosentient.com.au>
Date: Mon May 25 16:25:06 2020 +1000
Bug 25597: Add missing Javascript libraries to sco printslip
This patch adds missing Javascript libraries to the self-checkout
print slip. These missing libraries were preventing the auto print
prompt and close. There was also a font error.
To Test:
0) Apply patch
1) Turn on system preference SelfCheckReceiptPrompt
2) Check out item via /cgi-bin/koha/sco/sco-main.pl
3) Click "Finish"
4) Press F12 on keyboard and choose Console
5) Note no Javascript errors
6) Note that print dialog appears and closes after
a print option is chosen
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b16e463173e8125396eaef3159d08df5d0d2cfb6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 26 10:50:31 2020 +0200
Bug 25599: Fix default value placeholders for UseACQFrameworkForBiblioRecords
The feature was there but a condition disabled it.
Test plan:
- modify the default value for 008@ or another subfield in the ACQ framework using one or more of the placeholders above
- activate UseACQFrameworkForBiblioRecords
- create a basket
- create an order from a new record
- verify the values have been replaced
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2b05647b6361b1a805ae856e81a3e7db0cb3394b
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri Jun 5 16:38:52 2020 +0400
Bug 25642: Fix description of new feature in update_dbix_class_files.pl
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 77c945d380975bb18b292e5bb28dd6942dc1288f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Jun 1 13:31:21 2020 +0100
Bug 25642: Add technical notes
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 35bb41dfc14603d85a6ddb85fec9b4de8d1a4001
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Jun 10 10:58:25 2020 +0000
Bug 25701: Remove sort on removed field
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d6696944267ca1afd7682193ddf3680a905a773d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jun 10 12:03:20 2020 +0200
Bug 25701: (bug 14419 follow-up) Always display facet groups in the same order
It seems that this regression comes from bug 14419, but I have not found
a logic reason behind that.
This patch restores the behaviour we always had: facet groups must be
displayed in a given order: the Zebra index (au, ccode, holdingbranch,
etc.)
Test plan:
Apply this patch, restart all and confirm that the facets are not moving
up and down when you refresh your search result page.
QA note:
I think the following line must be removed
@facets_loop = sort {defined $a->{expand} && defined $b->{expand} && $a->{expand} cmp $b->{expand}} @facets_loop;
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ca7eb99eef2d1ae0258318310e402069194e999b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jun 9 12:40:32 2020 -0300
Bug 24003: (follow-up) Add all userenv parameters
This patch makes the API set more userenv params than just the
borrowernumber. To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/auth_*
=> SUCCESS: All tests pass
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6b2d8b6779df37fa6be58f0313f4c128b183e4f6
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Jun 5 09:47:47 2020 -0300
Bug 24003: (follow-up) Move interface setting to a more readable place
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 682d7896dd8e91fe846221d9605f79ca44d16360
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Jun 5 09:16:16 2020 -0300
Bug 24003: Make the API set userenv on authentication
This patch makes the authentication step stash the user that got
authenticated so code outside the Mojo part of Koha can use it (i.e.
through the use of C4::Context->userenv).
To test:
1. Apply the regression tests
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \
t/db_dependent/api/v1/auth_basic.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f1a3fad1fc5c3949fbc14df42af49acc88a633ff
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Jun 5 09:15:19 2020 -0300
Bug 24003: Regression tests
This patch adds regression tests for the different authentication
mechanisms Koha supports. It highlights the fact that Koha expects
userenv to be set on authentication.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bbac95d9fbbcc0b586a7bc094f421c35a7d71011
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Jun 8 10:23:53 2020 +0100
Bug 25526: Equality matching is case sensative
TEST PLAN:
1. Have a fine on a Patron's account.
2. Choose the "Write off Selected" button
3. Enter an amount less than the amount owed by the patron.
4. Koha will give a yellow box with a note "You must collect a value
greater than or equal to 2.00." The $2.00 is the amount that is
attempted to write off (the amount less than the amount owed).
5. Apply patch
6. Again try to writeoff an amount less than the amount owed.
7. You should be able to write it off.
8. Try paying an amount more than owed, you should still get an
error. You shouldn't be able to write off more than the amount.
9. Follow the above steps via 'Pay selected' as aposed to 'Writeoff
selected'.
10. You should not be able to 'Tender' less than the amount you have
'Paid'.
11. Disable Javascript and run through all the above steps. You should
still be blocked where relevant.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Bookseller.pm | 116 ---
C4/HTML5Media.pm | 29 +-
C4/Search.pm | 4 +-
Koha/Manual.pm | 1 +
Koha/REST/V1/Auth.pm | 38 +-
Koha/pdfformat/layout2pagesde.pm | 2 +-
acqui/lateorders.pl | 42 +-
acqui/neworderempty.pl | 2 +-
cpanfile | 1 -
debian/control | 3 -
debian/control.in | 1 -
.../intranet-tmpl/prog/css/src/staff-global.scss | 3 +
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../intranet-tmpl/prog/en/includes/admin-menu.inc | 3 -
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 7 +-
.../intranet-tmpl/prog/en/includes/js_includes.inc | 1 -
.../en/includes/member-alt-address-style-de.inc | 162 -----
.../en/includes/member-alt-address-style-fr.inc | 162 -----
.../en/includes/member-alt-address-style-us.inc | 160 -----
.../prog/en/includes/member-alt-address-style.inc | 244 +++++++
.../en/includes/member-alt-contact-style-de.inc | 126 ----
.../en/includes/member-alt-contact-style-fr.inc | 126 ----
.../en/includes/member-alt-contact-style-us.inc | 126 ----
.../prog/en/includes/member-alt-contact-style.inc | 198 ++++++
.../includes/member-display-address-style-de.inc | 16 -
.../includes/member-display-address-style-fr.inc | 19 -
.../includes/member-display-address-style-us.inc | 16 -
.../en/includes/member-display-address-style.inc | 74 ++
.../member-display-alt-address-style-de.inc | 16 -
.../member-display-alt-address-style-fr.inc | 21 -
.../member-display-alt-address-style-us.inc | 16 -
.../includes/member-display-alt-address-style.inc | 76 ++
.../en/includes/member-main-address-style-de.inc | 125 ----
.../en/includes/member-main-address-style-fr.inc | 126 ----
.../en/includes/member-main-address-style-us.inc | 125 ----
.../prog/en/includes/member-main-address-style.inc | 190 +++++
.../intranet-tmpl/prog/en/includes/tools-menu.inc | 3 +
.../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 4 +-
.../prog/en/modules/acqui/lateorders.tt | 25 +-
.../prog/en/modules/admin/admin-home.tt | 4 -
.../prog/en/modules/admin/edi_accounts.tt | 20 +-
.../en/modules/admin/preferences/authorities.pref | 2 +-
.../en/modules/admin/preferences/cataloguing.pref | 1 -
.../prog/en/modules/admin/preferences/opac.pref | 16 +-
.../prog/en/modules/admin/smart-rules.tt | 2 +-
.../prog/en/modules/catalogue/detail.tt | 51 +-
.../prog/en/modules/circ/branchtransfers.tt | 1 +
.../prog/en/modules/circ/pendingreserves.tt | 5 +-
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 7 +-
.../prog/en/modules/circ/view_holdsqueue.tt | 2 +-
.../intranet-tmpl/prog/en/modules/intranet-main.tt | 6 +-
.../prog/en/modules/members/deletemem.tt | 8 +-
.../prog/en/modules/members/memberentrygen.tt | 21 +-
.../prog/en/modules/members/moremember-brief.tt | 7 +-
.../prog/en/modules/members/moremember-print.tt | 7 +-
.../prog/en/modules/members/moremember.tt | 14 +-
.../prog/en/modules/serials/subscription-add.tt | 2 +-
.../en/modules/{admin => tools}/problem-reports.tt | 8 +-
.../prog/en/modules/tools/tools-home.tt | 5 +
koha-tmpl/intranet-tmpl/prog/js/commons.js | 73 --
koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 75 ++
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
.../opac-tmpl/bootstrap/css/src/_responsive.scss | 1 -
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 2 -
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 17 +-
.../opac-tmpl/bootstrap/en/modules/opac-tags.tt | 4 +-
.../bootstrap/en/modules/sco/printslip.tt | 4 +-
.../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 +-
koha-tmpl/opac-tmpl/bootstrap/js/global.js | 22 +
members/deletemem.pl | 11 +
members/paycollect.pl | 4 +-
.../maintenance/search_for_data_inconsistencies.pl | 19 +-
misc/migration_tools/switch_marc21_series_info.pl | 12 +-
misc/release_notes/release_notes_20_05_00.html | 101 ++-
misc/release_notes/release_notes_20_05_00.md | 85 ++-
misc/translator/LangInstaller.pm | 2 +-
opac/opac-tags.pl | 38 +-
t/Bookseller.t | 14 -
t/db_dependent/Bookseller.t | 786 ---------------------
.../api/v1/auth_authenticate_api_request.t | 32 +-
t/db_dependent/api/v1/auth_basic.t | 19 +-
t/db_dependent/api/v1/oauth.t | 3 +
{admin => tools}/problem-reports.pl | 2 +-
83 files changed, 1357 insertions(+), 2573 deletions(-)
delete mode 100644 C4/Bookseller.pm
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-de.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-fr.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-us.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style-de.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style-fr.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style-us.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-de.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-fr.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-us.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-display-alt-address-style-de.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-display-alt-address-style-fr.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-display-alt-address-style-us.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-display-alt-address-style.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-fr.inc
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style.inc
rename koha-tmpl/intranet-tmpl/prog/en/modules/{admin => tools}/problem-reports.tt (98%)
delete mode 100644 koha-tmpl/intranet-tmpl/prog/js/commons.js
delete mode 100755 t/Bookseller.t
delete mode 100644 t/db_dependent/Bookseller.t
rename {admin => tools}/problem-reports.pl (97%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list