[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.00-7-g17192eb5a3

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 20.05.x has been updated
       via  17192eb5a38a8549e7e4f43e483c3114cc7f9d2a (commit)
       via  01c09f2656d21eb13248e394ea98822a327f9c6a (commit)
       via  14b151c06eb762e96edce36e0cebd49c02a47b3b (commit)
       via  93c0e6863ab65e951fea5941a0abcc250fc3e2ff (commit)
       via  72b8ca802381aa3b59dd2a1b68c40731a6351138 (commit)
       via  2c710ff9102311b7e3a99dd647e247dc77d5625e (commit)
      from  d2996eea5fd9637c1a2df9ba5a5a0375679aa050 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 17192eb5a38a8549e7e4f43e483c3114cc7f9d2a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jun 9 16:15:04 2020 +0200

    Bug 25638: Make the tests pass - ignoring the actual issue
    
    The API related tests still don't pass with the previous modifications.
    They pass on D10 but fail on U18 and I did not manage to find where the
    problems come from.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit d6c12e2471942f2cd9c4c2d2af891507018009ac)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 01c09f2656d21eb13248e394ea98822a327f9c6a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jun 5 15:55:28 2020 -0300

    Bug 25638: Update TODO
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 9555ca1c73d6a6a7074a9cee721e2d2ff7888c1f)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 14b151c06eb762e96edce36e0cebd49c02a47b3b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jun 5 16:09:46 2020 +0200

    Bug 25638: Fix regression
    
    Now that float/decimal columns are not treated similar to integer ones,
    the default value handling we had set for numeric values is not trapping
    the float/decimal cases as it should.
    
    We love tests!
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit f4f3c8f18b5587ad8629b77b457e9593d781dac6)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 93c0e6863ab65e951fea5941a0abcc250fc3e2ff
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jun 2 14:40:04 2020 +0200

    Bug 25638: Fix float/decimal comparison in API related tests
    
    The previous fix from bug 25513 does not work in all versions we are
    supporting.
    
    Let's hack the float/decimal columns in the same way we did for integer.
    
    prove t/db_dependent/api/v1/acquisitions_vendors.t \
          t/db_dependent/api/v1/patrons_accounts.t \
          t/db_dependent/api/v1/acquisitions_orders.t
    
    Note that there is another error on U20 for acquisitions_orders.t
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 8dfbc46aa4bebffb5e7bd262612ef9d08d24e5d3)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 72b8ca802381aa3b59dd2a1b68c40731a6351138
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jun 2 14:36:43 2020 +0200

    Bug 25638: Revert "Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON"
    
    This reverts commit a79cf4150e8a08e743acc7d7147af91757d7a9b8.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 59ae6ced7fa7ffbcc0a061d884a3bb4cbb233b15)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 2c710ff9102311b7e3a99dd647e247dc77d5625e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jun 5 15:44:39 2020 -0300

    Bug 25638: Add tests for JSON conversion vs DBD::mysql
    
    We have the situation of needing to cast numbers so they are not
    confused in JSON with strings by DBD::mysql returning them with the
    wrong internal flags.
    
    We have also recently removed the cast, and adding it back now.
    This test could help us detect this situation in case we make changes in
    the area, and even on specific libraries versions.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 0569072fc1db2f4af731d5377c654ae7ef76e15a)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Object.pm                              | 42 ++++++++++++++++++++++++++---
 t/db_dependent/Koha/Object.t                | 10 ++++++-
 t/db_dependent/api/v1/acquisitions_orders.t | 35 ++++++++++++------------
 t/lib/TestBuilder.pm                        |  1 +
 4 files changed, 67 insertions(+), 21 deletions(-)


hooks/post-receive
-- 
main Koha release repository