[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.06-45-g4809536e8f

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  4809536e8f561ea708264b80d415b10b4703a9fd (commit)
       via  eb6c53b8ea4d8ec775c7f0bc21fb1c340639ac1b (commit)
      from  e6227af570de4ec3726fcdb8dce3059ec1ef0d6f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4809536e8f561ea708264b80d415b10b4703a9fd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jun 2 11:05:12 2020 +0200

    Bug 17842: Simplify the code
    
    There is no need for all the conditions.
    From Encode::encode POD:
      "If the $string is undef, then undef is returned."
    
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 74c7530e3dacd7a1df9ed72d031bc1a5b7063142)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 6802d1a67e47fae0982c969f414b05f4f6a7cc28)
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit eb6c53b8ea4d8ec775c7f0bc21fb1c340639ac1b
Author: David Cook <dcook at prosentient.com.au>
Date:   Tue May 26 12:30:53 2020 +1000

    Bug 17842: UTF-8 encode ISO2709 MARC download from cart
    
    The cart was outputing ISO2709 MARC records with Latin-1
    encoding. Records containing non-latin1 characters were
    automatically re-encoded as UTF-8 by browsers, which led to
    inconsistent character encodings for downloaded MARC files.
    
    This patch explicitly encodes ISO2709 MARC characters from
    the cart download as UTF-8 encoded bytes, which resolves the problem.
    
    Test Plan:
    0) Don't apply patch
    1) Create bib record with only ASCII characters
    2) Add a ü character to the title
    3) Save bib record
    4) Download bib record from cart (opac and staff client)
    5) Using xxd or some other program, note that the ü is
    represented by a FC byte (latin-1 encoded)
    6) Apply the patch
    7) Download bib record from cart (opac and staff client)
    8) Using xxd or some other program, note that the ü is
    represented by C3 BC bytes (utf-8 encoded)
    9) Success
    
    (Note that you could potentially use Notepad++ or some other
    program to open the downloaded file and just note the encoding
    that it finds. You could also try "chardetect" instead. Lots
    of options for figuring out the encoding.)
    
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 13ec430eccd52413e756c88f90a370787842cbc2)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit a1a1ed902d5dd4af9dbab6eb30f4d07f6eb52732)
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-----------------------------------------------------------------------

Summary of changes:
 basket/downloadcart.pl    | 4 +++-
 opac/opac-downloadcart.pl | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository