[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.06-74-g28fb7b4f83

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  28fb7b4f83b84069954fd6baf7e1e762c67ee75c (commit)
       via  cd950f634113d1cfffd0a6431ad9d121da5b4b0f (commit)
      from  b3189e33692fa5f7be90464dbac673aaa8458401 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 28fb7b4f83b84069954fd6baf7e1e762c67ee75c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon May 4 15:43:18 2020 -0300

    Bug 25327: Do not call authenticate_api_request to render the spec
    
    The original code for Koha::REST::V1::Auth::under called
    authenticate_api_request when requesting the API spec. This didn't make
    sense, and recent changes on what conditions are tested for public
    routes, broke the route.
    
    We could add another condition, but it really doesn't make sense to call
    authenticate_api_request if it should be publicly available in any
    configuration, as discussed on the bug.
    
    This patch adds a trivial check and the requested route, and lets the
    request through in any case in 'under'.
    
    To test:
    1. Point your browser to:
       http://kohadev.myDNSname.org:8080/api/v1/
       http://kohadev.myDNSname.org:8080/api/v1/.html
    => FAIL: In both cases you get an authorization error.
    2. Apply the regression tests patch
    3. Run:
       $ kshell
      k$ prove t/db_dependent/api/v1/auth.t
    => FAIL: The tests reflect the situation, and fail
    4. Apply this patch
    5. Repeat 1 and 3
    => SUCCESS: All good!
    6. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit cd950f634113d1cfffd0a6431ad9d121da5b4b0f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon May 4 15:43:08 2020 -0300

    Bug 25327: Regression tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/REST/V1/Auth.pm         |  3 +++
 t/db_dependent/api/v1/auth.t | 13 ++++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository