[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.06-80-g26ebfc3272

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  26ebfc32721474b89a8e970b5cd6277c94c7c276 (commit)
      from  d680ae35f39c0eb413b45339aadfa9148a58ed55 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 26ebfc32721474b89a8e970b5cd6277c94c7c276
Author: Petro Vashchuk <stalkernoid at gmail.com>
Date:   Fri May 22 18:11:28 2020 +0300

    Bug 25587: fix for "clear" button to reset all selects
    
    Button "clear" on cgi-bin/koha/admin/smart-rules.pl did not reset fields
    with a dropdown selector except the first one.
    
    This happens because jQuery selector .find("select option:first")
    in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
    selects only single first element in the whole group, as from jquery
    doc:
    > The :first pseudo-class is equivalent to :eq( 0 ). It could also be
    > written as :lt( 1 ). While this matches only a single element,
    > :first-child can match more than one: One for each parent.
    > (https://api.jquery.com/first-selector/)
    
    And it works if replaced by: .find("select option:first-child")
    
    To reproduce:
        1) Go to /cgi-bin/koha/admin/smart-rules.pl
        2) Start editing one of existing rules or filling a new one, change
           all selects to have non-first option selected. Fill text input
           fields with sample data.
        3) Reset all fields with the "clear" button.
        4) Observe that only the first dropdown field was reset to the first
           option while all others still contain previously given values,
           meanwhile all text input fields are cleared as expected.
        5) Apply the patch.
        6) Repeat steps 1, 2 and 3.
        7) Check that all dropdown fields were reset to first option, as
           expected.
    
    Mentored-by: Andrew Nugged <nugged at gmail.com>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 58c389bf279ca6ffdea199ada8d65ce92baaf952)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 585b481cf0a9371f7808602a6d8ec9b81fa1a9c4)
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository