[koha-commits] main Koha release repository branch master updated. v20.05.00-95-g3ebfc94a57

Tue Jun 23 10:51:23 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  3ebfc94a5724a0dd63f565f9744800c98d70f9cf (commit)
       via  0de7b6093e86410c022e252b554a5e6305c86480 (commit)
       via  b1af5a62cb74aa7dd000ae41c4be07dd6d3aa330 (commit)
       via  84230fcd798805c38c9ff16312121011cd0dc782 (commit)
      from  7b54b529078756556252530bb72903caa88e94e7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3ebfc94a5724a0dd63f565f9744800c98d70f9cf
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Jun 23 09:25:33 2020 +0200

    Bug 25842: Fix typo streetype in member-main-address-style.inc

    There are several more instances of the incorrect variable "streetype" in member-main-address-style.inc. Must be corrected with DB column name "streettype" in order to be able to set this field as mandatory.

    See also :
    Bug 25839 - Typo patron.streetype in member-main-address-style.inc

    Test plan :
    1) Add "streettype" in system preference "BorrowerMandatoryField"
    2) Create a new patron
    3) Without patch "Street type" field is not mandatory/required, with
       patch it is
    4) Remove "streettype" from system preference "BorrowerMandatoryField"
    5) Create a new patron
    6) Check "Street type" field is not mandatory/required
    7) Select a value and save
    8) Edit again patron
    9) Check value is selected

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0de7b6093e86410c022e252b554a5e6305c86480
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Jun 22 11:58:56 2020 +0200

    Bug 25839: Fix typo patron.streetype in member-main-address-style.inc

    Typo in member-main-address-style.inc : patron.streetype > patron.streettype

    Generates error :
    Template process failed: undef error - The method Koha::Patron->streetype is not covered by tests!

    Test plan : try create a new patron

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b1af5a62cb74aa7dd000ae41c4be07dd6d3aa330
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 17 09:43:40 2020 +0200

    Bug 25774: Handle utf8 chars in REST API queries

    We must utf8 encode the string before json decoding it.

    Test plan:
    Use "❤" and play with the library search (bug 25288) and Postman to
    generate queries using it.

    This patch prevents 500:
    [2020/06/16 14:11:37] [ERROR] GET /api/v1/libraries: unhandled exception (Mojo::Exception)<<Wide character in subroutine entry at /kohadevbox/koha/Koha/REST/Plugin/Objects.pm line 107.>> Koha::REST::Plugin::Exceptions::__ANON__ /kohadevbox/koha/Koha/REST/Plugin/Exceptions.pm (73)

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 84230fcd798805c38c9ff16312121011cd0dc782
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Jun 12 19:46:00 2020 +0000

    Bug 25702: Actions button on Search results from Z39.50 is displayed incorrectly

    This patch modifies, again, the way the actions popup is implemented in
    Z39.50 search results, whether it be in cataloging, authorities, or
    acquisitions. The solution for Bug 25282 changed some markup which was
    being referred to in JavaScript. This patch makes the markup more
    consistent and unifies handling of the menu in one JavaScript file.

    The solution changes the way a menu is generated when the user clicks
    within the row of Z39.50 search results (not on the "Actions" button).
    The script now creates a clone of the actions menu in that row and
    appends it to the <td> the user clicked on.

    To test, apply the patch and clear your browser cache if necessary. Test
    these three areas in the same way:

    1. Cataloging -> New from Z39.50 -> Search
    2. Authorities -> New from Z39.50 -> Search
    3. Acquisitions -> Vendor -> Add to Basket -> From an external source ->
    Search.

    In each case, test the functionality of the "Actions" menu button in the
    last column ("Preview" in Acquisitions search results). The menu
    should be positioned correctly and menu choice works correctly

    Click anywhere else in the search results table. The same actions menu
    should be triggered in that table cell. Confirm that these menu items
    work correctly according to the row which was clicked.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 Koha/REST/Plugin/Objects.pm                        |  7 +--
 .../prog/en/includes/member-main-address-style.inc | 12 ++---
 .../prog/en/modules/acqui/z3950_search.tt          | 20 +-------
 .../en/modules/cataloguing/z3950_auth_search.tt    | 42 +---------------
 .../prog/en/modules/cataloguing/z3950_search.tt    | 41 +--------------
 koha-tmpl/intranet-tmpl/prog/js/z3950_search.js    | 58 ++++++++++++++++++----
 t/db_dependent/Koha/REST/Plugin/Objects.t          | 24 ++++++++-
 7 files changed, 85 insertions(+), 119 deletions(-)

hooks/post-receive
-- 
main Koha release repository