[koha-commits] main Koha release repository branch master updated. v20.05.00-143-gee3f5d5a85
Git repo owner
gitmaster at git.koha-community.org
Wed Jun 24 15:57:18 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via ee3f5d5a85d93dc36d6bdeab5f092c0098d604e1 (commit)
via ce2219425d9b97952f5904024fb7575a0809487b (commit)
via ef947ff42fb5959d421038ac2a413e9cc6488474 (commit)
via 0ab27fe6da01095ec3303e35b5736f9ed9bbc07e (commit)
via b48869f1b865ae1f172557274062e932318427db (commit)
via f102e26da688de83c2ad46e52029d84f305a91da (commit)
via d1a8c3fcfed61061ad8876b97851b92b0ea14fe3 (commit)
via dd0c207f533a4c65b17b59b40c31ac44633e09a8 (commit)
via 032e11c7f4ef5d0eba6b1b49c0c62b8828e9d133 (commit)
via 6b82d1416687434c61fe49b4230c15ad8b795b6e (commit)
via 6f5dc3dc0dd9fa02d6d11e92a6e466e545b8eccc (commit)
via 76ac7ae0a0cbf5141230e58be4a36fcfe28f54c1 (commit)
via 2e94cb26a8267df72f657fb7c1097d08318e8a21 (commit)
via 78cfac8dd5d089960e7d34068415b8c7f0bd7775 (commit)
via c5b173f7dec5d94c29249dfa00e61861d5645998 (commit)
via 6b0887f76e2f561187f6eae78f932987520a9cb6 (commit)
via c36560a1ad731af955c005306c2c2800057cd890 (commit)
via f002bd17105bab2d16aee8db8ed4f6d688192fc3 (commit)
via 972aeaa0143dcdedc7ae23314a72991d5e4a6490 (commit)
via 4ae6ffe59c18557566d74a00d4ac16ca19b85150 (commit)
via 0550e0b7f788b65b50ed4689d677600be3f9c7c2 (commit)
via 62795521eedc02e11bef520c8b980d480b7e02ae (commit)
via f88d56f689e514b47930d617049358fdf9b68608 (commit)
via 3e18402c240814d7f00a62c3f2359bd9b9d0a098 (commit)
via 1a96ede5f114bd90fe1735702ca4bab77dfed9d4 (commit)
via 6d73c08e7351a772a388b1e1c6157b307fcbc1a8 (commit)
via 174ea44dccd8f0a151a82ba5f8c70e3194065539 (commit)
via 7ff774509d8c3fc4747857dcfeee7a2cf7557921 (commit)
via 2e14a0a3fa317191bf0ee735988a83b8f59d4ed5 (commit)
via d2f136713e814d4e33e18d1cdad88f3675a9ec3a (commit)
via c3365a35963742b294a4c8631b22aa34dac228d9 (commit)
via 251197ad73ba2be88ac2154db46748b58a0597f8 (commit)
via cd716269a7b2b1b6165154ea7e85844201402a8d (commit)
via 1e0dd6d0783a66514fc92cc0a34ca0882a5ce62f (commit)
via f090c1d2cb9253d77c5bac3b8fa03c775af2f0f6 (commit)
via 0ef7b3db4cab73797ba3386b4951c0d86addf871 (commit)
via 897948cff5812a67144355829cf8915af17465d0 (commit)
via 980419ed15cd4e5ae8be552218f939f5faea18c4 (commit)
via 258d0b0ecd6450fea09677f0607efdedb33cc16c (commit)
via 9e923e57ed18a104c33cc10a4704450ec4c71c28 (commit)
via b115dfeca649f2f35e0290ead85f2626eabd0829 (commit)
via 451ae76431d3d580494f917ed397f259cd96a876 (commit)
via 2220ce4d50998bef1dcea787d212a287a802b0aa (commit)
via c0f6f3c635170b6183bfa34244ffebad537e1e0b (commit)
via 73c421a5164a3af4b2b8e1001b49f29213a94e3a (commit)
via 31800ba46b2ed03cc2e4431c4d3c56fce678a0ec (commit)
from 477ae01ebd9d6fbe35f299378e352248cb34213d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ee3f5d5a85d93dc36d6bdeab5f092c0098d604e1
Author: Emmi Takkinen <emmi.takkinen at outlook.com>
Date: Thu Mar 19 09:12:19 2020 +0200
Bug 4985: Fix Plack scope errors
This patch 'ours' several variables to fix Plack scope errors
in exceptionHolidays.pl.
This also adds '@holidays_list' as parameter to 'edit_holidays'.
Sponsored-by: Koha-Suomi Oy
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ce2219425d9b97952f5904024fb7575a0809487b
Author: Emmi Takkinen <emmi.takkinen at outlook.com>
Date: Fri Feb 7 12:43:54 2020 +0200
Bug 4985: Edit a calendar entry for all branches
This patch adds functionality to calendar tool to
make edits or deletes to all branches at once.
To test:
-Apply patch
-Add holiday for a library and copy it to all or some
libraries
-Edit previosly made holiday (edit, delete etc.) and
check out "Copy changes to all libraries." checkbox
=> Changes are made to all libraries sharing changed
holiday
Sponsored by: Koha-Suomi Oy
Signed-off-by: Christofer <christofer.zorn at ajaxlibrary.ca>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ef947ff42fb5959d421038ac2a413e9cc6488474
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Jun 17 11:50:26 2020 +0000
Bug 18911: (follow-up) We should save changes with a POST
Test plan:
Verify if changes to messaging table and language are still saved.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0ab27fe6da01095ec3303e35b5736f9ed9bbc07e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jun 17 12:20:36 2020 +0200
Bug 18911: Add the ability to set the preferred lang for notice at the OPAC
Patron should be allowed to modify this setting without asking a staff
member.
The setting is not configurable and cannot be hidden via a syspref.
Test plan:
- Turn the pref TranslateNotices on
- Install some languages
- Edit your messaging settings at the OPAC
=> Notice the "Preferred language for notices" dropdown list
- Select one
=> Confirm that the value is saved in DB
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b48869f1b865ae1f172557274062e932318427db
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Apr 9 11:23:04 2020 -0400
Bug 25097: Add option to message_queue to allow for only specific sending notices
The message_queue.pl currently will send all the messages queued up. It would be nice to have some control over which messages are to be sent.
Example: We have libraries who only wanted to send 'hold notices' but not overdue, advance notice, etc during the covid-19 quarantine. And some that were the opposite - turn off hold notices, but send other generated notices.
Test Plan:
1) Apply this patch
2) Enqueue some messages with different letter codes
3) Run process_message_queue.pl with the new -c parameter using one of the letter codes enqueued
4) Note that only the messages with the selected code were processed!
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f102e26da688de83c2ad46e52029d84f305a91da
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu May 7 11:00:19 2020 -0300
Bug 25288: (follow-up) Use .escapeHtml()
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d1a8c3fcfed61061ad8876b97851b92b0ea14fe3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed May 6 18:50:29 2020 -0300
Bug 25288: (QA follow-up) Escape data and restore empty list behaviour
After the QA round on bug 25279, some things needed to get fixed:
- Data needs to be escaped
- When no library is defined, we should keep the original behaviour and
message.
- aria-hidden="true" for FontAwesome coding guideline enforced
- Added role="button" as well.
This patch does that.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dd0c207f533a4c65b17b59b40c31ac44633e09a8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Apr 27 02:36:13 2020 -0300
Bug 25288: Use the API to list libraries
This patch makes the general libraries datatable use the API for rendering.
To test:
1. Test the datatable behaviour
2. Apply this patch
3. Repeat your tests
=> SUCCESS: Things work! Filtering and sorting specially
Bonus: Use the browser inspector to notice each interaction with thex
datatable triggers an API call with the right query parameters
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 032e11c7f4ef5d0eba6b1b49c0c62b8828e9d133
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Apr 27 02:35:00 2020 -0300
Bug 25288: Add general query parameters to the /libraries route
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6b82d1416687434c61fe49b4230c15ad8b795b6e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 16 16:12:50 2020 +0200
Bug 25287: Make the strings from .js translatable
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6f5dc3dc0dd9fa02d6d11e92a6e466e545b8eccc
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Apr 27 02:28:59 2020 -0300
Bug 25287: Add columns_settings capabilities to API datatables wrapper
This patch adds the code that is used for handling columns settings on
datatables and allows passing the columns_settings information to the
API-centric datatable. To test, you need bug 25288, which uses this features.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Works with bug 24561. Make working bug 25288
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 76ac7ae0a0cbf5141230e58be4a36fcfe28f54c1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jun 24 15:15:36 2020 +0200
Bug 22807: Compiled CSS
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2e94cb26a8267df72f657fb7c1097d08318e8a21
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jun 10 18:30:50 2020 +0000
Bug 22807: (follow-up) Update style of skip button
This patch updates the markup and style of the skip button, adapting
(i.e. stealing) the style of the skip link at https://webaim.org.
To test, apply the patch and rebuild the OPAC CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
Go to any page in the OPAC and hit the tab key. The "Skip to main
content" link should appear. Tabbing away from it should cause the link
to hide. Hitting the ENTER key when the link is highlighted should cause
the page to scroll to the main content.
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 78cfac8dd5d089960e7d34068415b8c7f0bd7775
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jun 10 18:42:06 2020 +0000
Bug 22807: (follow-up) Add .maincontent class to libraries page
This patch adds a missing "maincontent" class to the "all libraries"
view. Previously it was only present on the single library view.
To test, apply the patch and go to the "Libraries" page in the OPAC.
- Hit the "tab" key to highlight the "Skip to main content" link.
- Hit "Enter."
- The page should scroll to the top of the list of libraries.
- Open one of the library detail pages and confirm that the "Skip to
main content" link works on that page too.
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c5b173f7dec5d94c29249dfa00e61861d5645998
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Jun 10 16:56:40 2020 +0100
Bug 22807: Ensure .maincontent appears on all pages
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6b0887f76e2f561187f6eae78f932987520a9cb6
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Jun 10 13:57:42 2020 +0100
Bug 22807: Ensure only one maincontent on searcresults
Prior to this patch, if you entered a search that returned zero results,
you would end up with two 'maincontent' classes on the page
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c36560a1ad731af955c005306c2c2800057cd890
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Jun 9 14:10:53 2020 +0100
Bug 22807: Add 'Skip to content' option
This patch adds a 'Skip to content' link to the header bar which will
only appear upon the first use of 'tab' to navigate after any fresh page
load in the OPAC.
Test plan
1/ Load any page in the OPAC
2/ Hit the `tab` key
3/ Note the new 'Skip to main content' link appears at the top left of
the screen.
4/ Hit `Enter` or Click the button
5/ Note the page scrolls to the area of the page that has the first block
containing a .maincontent class.
6/ Note that the next available focusable element after the first .maincontent
block has been given focus.
7/ Note that the link has been hidden
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f002bd17105bab2d16aee8db8ed4f6d688192fc3
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date: Thu Jun 11 11:48:54 2020 +1200
Bug 25151: Fixing semantic headings in opac-basket.tt
Test plan:
1) Apply the patch
2) Add items to your cart/folder/basket
3) Open up the basket and check that the main heading is now an h1
4) Check that the page looks fine
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 972aeaa0143dcdedc7ae23314a72991d5e4a6490
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jun 11 13:23:32 2020 +0100
Bug 25154: Add heading where content is introduced in opac-results.tt
Prior to this patch, the search results page did not contain a
semantically accurate heading to introduce he main content of the page.
Test plan
1/ Perform a search in the OPAC that yields results
2/ Inspect the page and note that the 'title' stating how many results
are found is not semantically marked up as a heading to introduce the
content.
3/ Apply the patch
4/ Reload the page
5/ Inspect the page and note that the 'title' stating how many results
are found is now properly marked up as a second level heading and
appropriately designated as the start of the 'maincontent' block with an
associated '.maincontent' class.
6/ Perform a search which yields zero results
7/ Note that the 'No results found' title is properly marked up as a
second level heading.
8/ Signoff
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4ae6ffe59c18557566d74a00d4ac16ca19b85150
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jun 24 15:11:01 2020 +0200
Bug 25236: Compiled CSS
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0550e0b7f788b65b50ed4689d677600be3f9c7c2
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jun 11 11:54:22 2020 +0100
Bug 25236: Fix semantic heading for opac-full-serial-issues.tt
Prior to this patch, the opac-full-serial-issues side navigation box contained
semantically incorrect headings.
Test plan
1/ Search for a serial with many linked issues
2/ Navigate to the detailed view of that serial
3/ Click on the 'More details' link after all the listed issues
4/ Inspect the 'Refine your search' elements on the left side of the screen.
Note that the headings are H1 (Koha page title) > H4 (Refine your search)
3/ Apply this patch
4/ Reload the page
5/ Re-inspect the 'Refine your search' elements and note the heading
semantics are now H1 (Title of page) > H2 (Refine your search)
6/ Note the appearance of the box is improved and consistent with elsewhere
7/ Signoff
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 62795521eedc02e11bef520c8b980d480b7e02ae
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jun 11 11:44:53 2020 +0100
Bug 25236: Fix semantic heading for opac-topissues.inc
Prior to this patch, the opac-topissues side navigation box contained
semantically incorrect headings.
Test plan
0/ Enable 'OpacTopIssues'
1/ Navigate to the top issues page via the 'Most popular' link
2/ Inspect the 'Refine your search' elements on the left side of the screen.
Note that the headings are H1 (Koha page title) > H4 (Refine your search)
3/ Apply this patch
4/ Reload the page
5/ Re-inspect the 'Refine your search' elements and note the heading
semantics are now H1 (Title of page) > H2 (Refine your search)
6/ Note the appearance of the box is still reasonable
7/ Signoff
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f88d56f689e514b47930d617049358fdf9b68608
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jun 11 11:37:26 2020 +0100
Bug 25236: Fix semantic heading for opac-facets.inc
Prior to this patch, the opac-facets side navigation box contained
semantically incorrect headings.
Test plan
1/ Perform a search which yields some results in the OPAC
2/ Inspect the 'Refine your search' elements on the left side of the
screen. Note that the headings are H1 (Koha page title) > H4 (Refine
your search) > H5 (Headings within 'Refine your search' box)
3/ Apply this patch and follow
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
4/ Reload the page (Flushing the cache to ensure the CSS change load)
5/ Re-inspect the 'Refine your search' elements and note the heading
semantics are now H1 (Title of page) > H2 (Refine your search) > H3
(Headings within 'Refine your search')
6/ Note the appearance of the box is still reasonable
7/ Signoff
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3e18402c240814d7f00a62c3f2359bd9b9d0a098
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jun 11 12:15:21 2020 +0100
Bug 25238: Fix semantic heading for opac-details
Prior to this patch the opac-details view contained multiple h1 level
headings.
Test plan
1/ Perform a search in the OPAC that will yield results
2/ Navigate to any results detailed view
3/ Inspect the page and note that two H1 level headings are present
(Page title + Item title)
4/ Apply the patch
5/ Reload the page
6/ Inspect the page and ntoe that the 'Item title' is now a level 2
heading
7/ Note the page still appears nicely
8/ Signoff
Bonus points: Check with XSLT views enabled and disabled, MARC21,
UNIMARC and NORMARC variations.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1a96ede5f114bd90fe1735702ca4bab77dfed9d4
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jun 11 13:05:31 2020 +0100
Bug 25239: Fix semantic heading for opac-reserve.tt
Prior to this patch, the opac-reserve contained semantically incorrect headings.
Test plan
1/ Perform a search which yields some results in the OPAC
2/ Attempt to place a hold on an item.
3/ On the resulting screen, note that the headings are:
H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels)
4/ Apply this patch and reload the page
5/ Re-inspect the elements in question note the heading semantics are now:
H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels)
6/ Note the appearance of the box is still reasonable
7/ Signoff
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6d73c08e7351a772a388b1e1c6157b307fcbc1a8
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jun 18 11:31:40 2020 +0000
Bug 25402: (QA follow-up) Remove unused downloadBasket function
This patch removes the now-unused downloadBasket function from
basket.js. The patch should have no effect on the functionality of the
download process.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 174ea44dccd8f0a151a82ba5f8c70e3194065539
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 6 20:30:32 2020 +0000
Bug 25402: Put OPAC cart download options into dropdown menu
This patch modifies the process of downloading a cart so that it doesn't
involve a separate popup window.
To test, apply the patch and add some titles to the cart in the OPAC.
- Open the cart
- The "Download" button should now be a dropdown menu.
- Selecting any of the download options should trigger a download
prompt.
- Test with and without some CSV profiles which have been configured
for use in the OPAC
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7ff774509d8c3fc4747857dcfeee7a2cf7557921
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue May 12 21:27:05 2020 +0000
Bug 25471: Add DataTables to MARC subfield structure admin page
This patch adds DataTables sorting and filtering to the table of
subfields shown on the MARC subfield structure administration page.
To test, apply the patch and go to Administration -> MARC bibliographic
framework.
- From the 'Actions' menu, select 'MARC structure.'
- From the 'Actions' menu, select the 'View subfields' link for a tag
with multiple subfields.
- On the page showing all the subfields for the tag, confirm that the
table is sorted by default by subfield and that sorting works
correctly.
- Confirm that the search form at the top of the table works.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2e14a0a3fa317191bf0ee735988a83b8f59d4ed5
Author: Petro Vashchuk <stalkernoid at gmail.com>
Date: Wed Jun 10 15:36:01 2020 +0300
Bug 25699: Add edition information to "Holds to pull" report
Added a feature that displays edition information of the book
together with title in "Holds to pull" report.
Edition information is fetched from "biblioitem" table
as "editionstatement" and transferred to template.
Those changes don't have performance impact as all tables
including "biblioitem" were already used and joined in this request.
Mentored-by: Andrew Nugged <nugged at gmail.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d2f136713e814d4e33e18d1cdad88f3675a9ec3a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Jun 15 11:14:22 2020 +0000
Bug 25747: Don't display a comma when patron has no firstname
This patch adds a check for the existence of "firstname" to
patron-title.inc so that if the patron has no firstname the "invert
name" setting doesn't cause an unnecessary comma to appear.
To test, apply the patch and locate or create a patron with no first
name.
- When checking out to the patron, examine the page title. It should say
"Checking out to <lastname> (<cardnumber>).
- When checking out to a patron with first and last name it should show
as before, "Checking out to <lastname>, <firstname> (<cardnumber)
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c3365a35963742b294a4c8631b22aa34dac228d9
Author: Emmi Takkinen <emmi.takkinen at outlook.com>
Date: Thu Jun 18 09:36:55 2020 +0300
Bug 25789: Don't allow past date as holds expiration date
When editing existing holds expiration date it's possible to select
past date from datepicker. This patch changes expiration inputs class
as "datepickerto" to make past dates unselectable.
To test:
1. Find item with holds
2. Edit holds expiration date
=> Note that past dates are selectable
3. Apply patch
4. Edit again
=> Past dates are no longer selectable
Sponsored-by: Koha-Suomi Oy
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 251197ad73ba2be88ac2154db46748b58a0597f8
Author: Andreas Roussos <a.roussos at dataly.gr>
Date: Mon Jun 15 16:58:38 2020 +0200
Bug 25756: remove erroneous hyphen
In the Staff Client, the OPAC "Appearance" preferences table has an
extra, empty HTML table row at the end.
Test plan:
0) Observe the empty HTML table row at the end of the table that lists
OPAC "Appearance" system preferences.
1) Apply this patch.
2) Observe that the empty table row is now gone.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cd716269a7b2b1b6165154ea7e85844201402a8d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jun 5 11:15:33 2020 +0200
Bug 25611: Use selected vendor when creating a basket
We did not take into account the vendor selected.
Test plan:
1. Choose Vendor
2. Create Basket
3. Assign a new vendor
Without the patch this new vendor is not changed
With the patch applied the vendor is changed
4. Edit the basket, change the vendor
Reported-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1e0dd6d0783a66514fc92cc0a34ca0882a5ce62f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri May 1 20:11:29 2020 +0000
Bug 11994: (follow-up) Make things work when LibraryName is empty
When LibraryName system preference was not set, the installation
of the plugin would fail with:
Firefox could not download the search plugin from: ...
Now if the pref is empty, the description 'Library catalog'
will be used instead.
To test:
- Empty your LibraryName pref
- Verify the search plugin can still be installed
(see first patch for further instructions)
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f090c1d2cb9253d77c5bac3b8fa03c775af2f0f6
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri May 1 17:20:43 2020 +0000
Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml
https://developer.mozilla.org/en-US/docs/Web/OpenSearch
Your server should serve OpenSearch plugins using
Content-Type: application/opensearchdescription+xml.
To test:
- Verify the Content-Type the file is delivered with
is correct, for example using wget
http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?format=opensearchdescription
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0ef7b3db4cab73797ba3386b4951c0d86addf871
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Apr 28 14:41:47 2020 +0000
Bug 11994: Fix OpenSearch discovery in the OPAC
This patch corrects the markup for the OpenSearchDescription XML
document and adds (back) the link in the OPAC header which points to it.
This will enable compatible browsers to offer the addition of the OPAC's
keyword search as a search engine option.
I've found documentation suggesting this feature is available (or at
least was at one time) in Chrome and Safari, but in my test it only
works in Firefox.
To test, apply the patch and make sure the OPACBaseURL preference is
set correctly.
- Open the OPAC in Firefox (these instructions assume the latest
version, currently v.75).
- On the right side of the address bar you should see ". . ." Click it
to trigger the menu.
- You should see an "Add search engine" entry with your OPAC's icon.
- Click to add the search engine.
- Type a keyword to search in the address bar
- A box should pop up below the address bar showing icons at the bottom
for performing a search in various search engines. One of these icons
should be the icon for your Koha OPAC.
- Click the Koha OPAC icon and confirm that it triggers a keyword
search in your OPAC.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 897948cff5812a67144355829cf8915af17465d0
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Jun 16 19:48:48 2020 +0000
Bug 24352: Correct location and collection labels in OPAC search results
This patch modifies the OPAC's MARC21 search results XSLT so that
OPAC search result information is correctly labeled
based on the OpacItemLocation preference.
Previously, search results showed the label "Location(s)" whether the
setting was "collection code" or "location."
To test, apply the patch and set the OPACXSLTResultsDisplay system
preference to 'default.'
On the OPAC search results page, each result with items should show
information in this format:
With the OpacItemLocation preference set to 'call number only,'
- "Availability: Items available for loan: {library} [Call number:
{call number} ]
With the OpacItemLocation preference set to 'collection code,'
- "Availability: Items available for loan: {library}
Collection(s): {collection description} [{ call number }]"
With the OpacItemLocation preference set to 'location,'
- "Availability: Items available for loan: {library}
Location(s): {shelving location} [{ call number }]"
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 980419ed15cd4e5ae8be552218f939f5faea18c4
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Apr 28 15:34:20 2020 +0000
Bug 25189: Don't create authority if results found
Automatic authority creation assumes that if we don't match we need a new authority.
Using the Default linker, however, we don't match if there exists more than one match.
This leads to repeatedly generating authorities once there is a duplicate in the system
We shoudl instead only create a new authority if there are no results
To test:
1 - Set Linker Module to 'Default'
2 - Enable AutoCreateAuthorities and BiblioAddsAuthorities and CatalogModuleRelink and LinkerRelink
3 - Add two copies of a single authority via Z39
4 - Add a heading for that authority to a bib record
5 - Save the record and note a new authority is generated
6 - Repeat and see another is generated
7 - Apply patch
8 - Restart all the things
9 - Save the record again, no new authority created
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 258d0b0ecd6450fea09677f0607efdedb33cc16c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Apr 28 13:29:52 2020 +0000
Bug 25189: Unit tests
Adds new test for not adding authority if some already exist
Also replaces use of 'SearchAuthorities' as it is Zebra specific
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9e923e57ed18a104c33cc10a4704450ec4c71c28
Author: David Cook <dcook at prosentient.com.au>
Date: Fri May 15 14:55:49 2020 +1000
Bug 25509: Remove useless libjs-jquery dependency
We don't use the libjs-jquery package, so we should remove
the dependency.
To Test:
1) Build package (out of scope of test plan)
2) Install package
3) Note that libjs-jquery is marked by apt as no longer required
4) Remove libjs-jquery package from system and note how it
doesn't take koha-common with it
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b115dfeca649f2f35e0290ead85f2626eabd0829
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu May 21 18:25:46 2020 -0300
Bug 25570: (follow-up) Fix tests
This patch fixes the libraries tests, that expected the old behaviour
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/api/v1/libraries.t
=> FAIL: Tests fail
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests pass!
4. Sign off :-D
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 451ae76431d3d580494f917ed397f259cd96a876
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu May 21 18:23:01 2020 -0300
Bug 25570: Paginate results by default in objects->search
This patch makes the helper paginate the resultsif no pagination
parameters are passed.
Page number defaults to 1, and the page size to the RESTdefaultPageSize
syspref value.
To test:
1. Apply the regression tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t
=> FAIL: Pagination is not enforced by default
3. Apply this patch
4. Repeat 2
=> SUCCESS: Results are paginated
5. Sign off :-D
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2220ce4d50998bef1dcea787d212a287a802b0aa
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu May 21 17:48:21 2020 -0300
Bug 25570: Regression tests
This tests verify that the default behaviour is to paginate the results.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t
=> FAIL: $c->objects->search doesn't paginate results by default
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c0f6f3c635170b6183bfa34244ffebad537e1e0b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jun 18 11:56:38 2020 +0000
Bug 25804: Remove HTML from title tag of bibliographic detail page
This patch removes <span> tags from the bibliographic detail page's
<title> tag.
To test, apply the patch and view the bibliographic detail page for
any title in the staff interface. In the page title shown in the browser
tab you should see no <span> tags.
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 73c421a5164a3af4b2b8e1001b49f29213a94e3a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Jun 16 08:00:45 2020 -0400
Bug 25769: Patron self modification triggers change request for date of birth to null
If PatronSelfModificationBorrowerUnwantedField contains dateofbirth, all
patron self modification requests will attempt to set dateofbirth to
null instead of ignoring the field.
Test Plan:
1) Add dateofbirth to PatronSelfModificationBorrowerUnwantedField
2) Run a patron self modification
3) Note the request sets dateofbirth to null on the staff side
4) Apply this patch
5) Restart all the things!
6) Run another self-modification
7) Note of the staff side that dateofbirth is unaffected
Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 31800ba46b2ed03cc2e4431c4d3c56fce678a0ec
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri May 22 11:02:39 2020 +0200
Bug 25553: Make date columns sortable on the edit items table
When editing items, the table at the top contain several columns that
have date values, but they cannot be sorted by dates correctly.
Test plan:
Have several items with different dates in columns that contain dates,
like items.dateaccessioned, items.datelastseen)
Sort the column and confirm that with this patch the lines are sorted
correctly
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 4 +-
C4/Linker/Default.pm | 4 +-
C4/Output.pm | 5 +-
Koha/REST/Plugin/Objects.pm | 4 +
acqui/basketheader.pl | 2 +-
admin/branches.pl | 6 +-
api/v1/swagger/paths/libraries.json | 9 +
cataloguing/additem.pl | 2 +-
circ/pendingreserves.pl | 52 +-
debian/control.in | 2 -
.../intranet-tmpl/prog/en/includes/holds_table.inc | 2 +-
.../prog/en/includes/patron-title.inc | 2 +-
.../prog/en/modules/admin/branches.tt | 205 +++++--
.../en/modules/admin/marc_subfields_structure.tt | 9 +-
.../prog/en/modules/admin/preferences/opac.pref | 1 -
.../prog/en/modules/catalogue/detail.tt | 4 +-
.../prog/en/modules/cataloguing/additem.tt | 14 +-
.../prog/en/modules/circ/pendingreserves.tt | 1 +
.../prog/en/modules/tools/holidays.tt | 6 +
koha-tmpl/intranet-tmpl/prog/js/datatables.js | 131 ++++-
.../prog/js/marc_subfields_structure.js | 8 +-
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 31 +-
.../bootstrap/en/includes/doc-head-close.inc | 1 +
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 1 +
.../bootstrap/en/includes/opac-facets.inc | 26 +-
.../bootstrap/en/includes/opac-topissues.inc | 2 +-
.../opac-tmpl/bootstrap/en/modules/maintenance.tt | 2 +-
.../bootstrap/en/modules/opac-addbybiblionumber.tt | 2 +-
.../bootstrap/en/modules/opac-alert-subscribe.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 33 +-
.../opac-tmpl/bootstrap/en/modules/opac-blocked.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-browse.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-browser.tt | 2 +-
.../bootstrap/en/modules/opac-course-details.tt | 141 ++---
.../bootstrap/en/modules/opac-course-reserves.tt | 3 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +-
.../bootstrap/en/modules/opac-discharge.tt | 2 +-
.../en/modules/opac-full-serial-issues.tt | 12 +-
.../bootstrap/en/modules/opac-imageviewer.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-library.tt | 29 +-
.../opac-tmpl/bootstrap/en/modules/opac-main.tt | 8 +-
.../modules/opac-memberentry-update-submitted.tt | 2 +-
.../bootstrap/en/modules/opac-memberentry.tt | 4 +-
.../bootstrap/en/modules/opac-messaging.tt | 33 +-
.../bootstrap/en/modules/opac-opensearch.tt | 33 +-
.../opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 2 +-
.../bootstrap/en/modules/opac-password-recovery.tt | 2 +-
.../bootstrap/en/modules/opac-patron-consent.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 2 +-
.../bootstrap/en/modules/opac-readingrecord.tt | 2 +-
.../en/modules/opac-registration-confirmation.tt | 2 +-
.../en/modules/opac-registration-email-sent.tt | 2 +-
.../en/modules/opac-registration-invalid.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 8 +-
.../bootstrap/en/modules/opac-results-grouped.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 39 +-
.../opac-tmpl/bootstrap/en/modules/opac-review.tt | 2 +-
.../bootstrap/en/modules/opac-serial-issues.tt | 2 +-
.../bootstrap/en/modules/opac-tags_subject.tt | 2 +-
.../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 8 +-
.../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 11 +-
.../bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl | 4 +-
.../bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 4 +-
koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 10 -
koha-tmpl/opac-tmpl/bootstrap/js/datatables.js | 588 +++++++++++++++++++--
koha-tmpl/opac-tmpl/bootstrap/js/global.js | 46 ++
misc/cronjobs/process_message_queue.pl | 16 +-
opac/opac-basket.pl | 3 +-
opac/opac-memberentry.pl | 20 +-
opac/opac-messaging.pl | 12 +
opac/opac-search.pl | 2 +-
t/db_dependent/Biblio.t | 36 +-
t/db_dependent/Koha/REST/Plugin/Objects.t | 22 +-
t/db_dependent/api/v1/libraries.t | 13 +-
tools/exceptionHolidays.pl | 165 +++---
76 files changed, 1445 insertions(+), 438 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list