From gitmaster at git.koha-community.org Mon Mar 2 10:41:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 02 Mar 2020 09:41:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-913-g1e7819f742 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1e7819f742cdea8b14342db4da188b48cc0cc4b9 (commit) from c497d4f5a6af3648127ab14ef6e2e970c8258a64 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e7819f742cdea8b14342db4da188b48cc0cc4b9 Author: Marcel de Rooy Date: Mon Mar 2 09:00:57 2020 +0000 Bug 24756: Show the warnings on Jenkins Temporary measure to see which warnings Jenkins got while we cannot reproduce them ourselves on D8, D9 and D10. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/XSLT/Security.t | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 2 11:15:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 02 Mar 2020 10:15:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-933-g104b87c9a0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 104b87c9a093e5a2aa859f9d2d63ed2b8556bcaa (commit) via b4d56d3fd823974e39c064b4f59a17a85a0194bc (commit) via 266bcd554bd298ee4a1f09696af6e20c8fa3f548 (commit) via 8dc15ceffd7c9b3a720210537dff098a7b0c83d8 (commit) via 00d70a9bd839f6153b9b86c50c5e51dbe7d82b40 (commit) via b5b8a7daeb54a4793f5725aa15927781f52fe106 (commit) via 9060ca36c08f6f5ff2b5790ae163cd43758a7fd8 (commit) via ee12fb2247f913195a31d790c164f28952178bf7 (commit) via afd5ee31baeabdee9b01e2b9f5ae379de1ffb8db (commit) via d5a1a82a9bb3aa8c693192d469ee0186aef7c7c4 (commit) via 2fe29c657468f240ec5c781edfaf811261c774cd (commit) via 813da7f2433d182a7616407da42beef7f2c1f881 (commit) via cab8dd8cf116fcc23b487c493d7bac147c82b9fe (commit) via d352145c65d7c8609d8694031902dafdb23a14f2 (commit) via 886dd6b3be3ce94eb28742b2b10cffe7eaf64c8b (commit) via 729200ae57b81966b3ae5e312eef8e75123f85b9 (commit) via c44bfe12087cda33b351b157014e818db2e4613a (commit) via bd88b10c6fbf5b6ee19ff71dc8c9777de26d5eb6 (commit) via 7b63d55ddc0d821b7311fcad714ff46ff750f08a (commit) via 5bbf80989a5b8d6a1222b0e95c242b9457dfb024 (commit) from 1e7819f742cdea8b14342db4da188b48cc0cc4b9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 104b87c9a093e5a2aa859f9d2d63ed2b8556bcaa Author: Martin Renvoize Date: Mon Mar 2 09:45:47 2020 +0000 Bug 22273: DBRev 19.12.00.031 Signed-off-by: Martin Renvoize commit b4d56d3fd823974e39c064b4f59a17a85a0194bc Author: Marcel de Rooy Date: Wed Dec 18 13:49:59 2019 +0000 Bug 22273: Modify Koha::ArticleRequest->store to fill created_on For a new record, store should fill created_on. The database will always update the timestamp updated_on. Since open also calls SUPER::store, we do not need to call it twice. Test plan: [1] Run t/db_dependent/ArticleRequests.t [2] In the interface, add two article requests. Change the status of one to PROCESSING. Check created_on and updated_on in the article_requests table. The changed request should have updated_on > created_on. Signed-off-by: Bernardo Gonzalez Kriegel [1] Tests pass ok 12 - New article request has created_on date set ok 13 - New article request has updated_on date set [2] Work as described. No errors Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 266bcd554bd298ee4a1f09696af6e20c8fa3f548 Author: Marcel de Rooy Date: Wed Dec 18 14:35:50 2019 +0000 Bug 22273: Database revision for table article_requests Column created_on should not be updated. It is filled once by the store method of Koha::ArticleRequest. Column updated_on should be a timestamp, updated by the database. Note: Although higher versions of MySQL and MariaDB support two timestamps (NOT NULL) in one table, I kept on the safe side by allowing NULL on the created_on column. @RM: Don't forget to run DBIx update. Test plan: Run new install or upgrade. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 8dc15ceffd7c9b3a720210537dff098a7b0c83d8 Author: Marcel de Rooy Date: Wed Dec 18 13:39:57 2019 +0000 Bug 22273: Replace typo opan by opac in POD Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 00d70a9bd839f6153b9b86c50c5e51dbe7d82b40 Author: David Cook Date: Mon Jan 13 17:05:17 2020 +1100 Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Patch change Apache access control from 2.2 to 2.4 directives. Test plan: 0. Apply patch 1. Build Koha from source 2. Copy or symlink koha-dev/etc/koha-httpd.conf into your relevant Apache directory. 3. Reload Apache 4. Note a lack of syntax errors regarding the "Order" directive Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit b5b8a7daeb54a4793f5725aa15927781f52fe106 Author: Maryse Simard Date: Wed Aug 21 17:20:16 2019 -0400 Bug 23488: Line wrapping doesn't always respect word order in Patron card creator When wrapping long lines of text, the line is divided by removing each word from the end of the line and putting it in a new one until the line is the right width. When the word to be removed appears multiple time in the line, it is not the last occurrence that is removed. This patch changes the regular expression used to remove the part of the text that is wrapped to a new line, making sure it removes it at the end of the text. Test plan: 1. Go to Tools > Patron card creator 2. Have a card template and a card batch -> If needs be, you can create them by using New > Card template or New > Card batch 3. Create a layout and use one text field containing a long text with at least one word which is repeated a minimum of 2 times (preferably towrdds the end of the text, since it has to be picked as one of the words to appear in the new line). You can use this: one two three one two three one two three one two three one two three one two three one two three one two three ... 4. Go to Manage > Card batches and export a batch 5. Choose the layout set up in 3. 6. Click the Export button and open the resulting pdf file 7. Notice all the repeated word have been grouped -> For this example : all of the ones appear first, followed by all the twos and only then the threes. 8. Apply patch 9. Repeat step 4 through 7 => this time the order of the words has not changed! Signed-off-by: Gabriel DeCarufel Signed-off-by: William Frazilien Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 9060ca36c08f6f5ff2b5790ae163cd43758a7fd8 Author: Owen Leonard Date: Fri Feb 28 16:48:37 2020 +0000 Bug 23753: Add missing humanMsg library to pages using background job JavaScript The JavaScript used to process background uploads calls the humanMsg library under some circumstances. There are several templates which use background-job-progressbar.js which don't include the humanMsg assets. This patch corrects those templates. Note: upload-images.tt has been modified to remove the inclusion of background-job-progressbar.js because it was unused. To test, apply the patch and test the following processes which include background job processing: - Batch item modification -- the background job is triggered when you submit your changes - Batch record modification -- the background job is triggered when you submit your changes - Stage MARC for import -- the background job is triggered when you click the "Sage for import" button after uploading a file - Staged MARC management -- the background job is triggered when you click "Import this batch into the catalog" In each case the process should complete correctly. If you would like to test the error message handling provided by the humanMsg library you can deliberately introduce an error into the JavaScript. After applying the patch you can modify js/background-job-progressbar.js to alter line 63 from: url: f.action, ...to: url: f.action + "foo", Perform the same tests and confirm that you see an error message. Don't forget to undo your changes to background-job-progressbar.js before signing off. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit ee12fb2247f913195a31d790c164f28952178bf7 Author: Owen Leonard Date: Fri Feb 28 15:00:40 2020 +0000 Bug 23536: Remove obsolete category markup from patron entry This patch removes some obsolete markup from the patron entry template (memberentrygen.tt). The old markup was necessary in a long-gone version of Koha where it was possible to add patrons using built-in categories instead of defining your own. To test, apply the patch and test the process of adding or editing patrons. You should see the patron category displayed correctly in the page title, breadcrumbs, and main heading. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit afd5ee31baeabdee9b01e2b9f5ae379de1ffb8db Author: Owen Leonard Date: Fri Feb 28 14:53:53 2020 +0000 Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d5a1a82a9bb3aa8c693192d469ee0186aef7c7c4 Author: Katrin Fischer Date: Mon Feb 24 17:01:19 2020 +0000 Bug 24725: (QA follow-up) Add missing spaces between elements on claims tab There was a missing space between the title and the barcode. Also added a space between title and author. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 2fe29c657468f240ec5c781edfaf811261c774cd Author: Jonathan Druart Date: Tue Feb 25 14:40:06 2020 +0100 Bug 24725: Remove ES template literals in checkouts.js From Julian on bug 24661 comment 6: """ It looks like xgettext does not like ES6 template literals. https://savannah.gnu.org/bugs/?50920 From what I understand, support for template literals was added in gettext 0.20 (still not packaged in debian) but is still buggy in latest released version 0.20.1 and a fix is present in master. """ We should not use backticks ` in .js file, it breaks xgettext. To replicate: kohadev-koha at e1f3025cca60:/kohadevbox/koha/misc/translator$ perl translate update es-ES koha-tmpl/intranet-tmpl/prog/js/checkouts.js:569: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:858: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:904: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:911: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:1095: warning: RegExp literal terminated too early /usr/bin/msgmerge: error while opening "/kohadevbox/koha/misc/translator/po/es-ES-messages-js.po" for reading: No such file or directory (last error 'No such file or directory' is not related to this). Test plan: Make sure nothing is broken on the claims table Confirm that the errors do not longer appear on `perl translate update LANG` Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 813da7f2433d182a7616407da42beef7f2c1f881 Author: Jonathan Druart Date: Tue Feb 25 14:17:27 2020 +0100 Bug 24727: (bug 14697 follow-up) Replace link on title to bib detail page 903 let title = ` At first it seems like a typo: request-rcticle.pl vs request-acticle.pl But actually it does not make sense to link to request-article, we want (I think) to link to the bibliographic record detail page. Test plan: - Have something in the claim table (cf bug 14697) - Click on the title of the bibliographic record Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit cab8dd8cf116fcc23b487c493d7bac147c82b9fe Author: Julian Maurice Date: Wed Feb 26 20:09:52 2020 +0100 Bug 24734: Fix paths in LangInstaller.pm for JS files Use intrahtdocs and opachtdocs in order to get the correct paths for all kind of installations Test plan: 1. With a dev install, run ./translator create/update/install xx-XX and verify that there is no error message 2. With a standard install, run ./translator create/update/install xx-XX and verify that there is no error message Signed-off-by: Bernardo Gonzalez Kriegel Tested for dev/single/standard installs, no errors, just a (normal) warn from po2json. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d352145c65d7c8609d8694031902dafdb23a14f2 Author: Katrin Fischer Date: Sat Feb 29 10:49:46 2020 +0100 Bug 24736: (QA follow-up) Change tooltip wording Suggesting a change of the tooltip wording to read: There are no enrollments for this club yet Signed-off-by: Martin Renvoize commit 886dd6b3be3ce94eb28742b2b10cffe7eaf64c8b Author: Jonathan Druart Date: Wed Feb 26 17:46:49 2020 +0100 Bug 24736: Disable "Enrollments" link if nobody enrolled to the club yet The link is disabled but it's possible to click and access the page anyway. Test plan: - Create a new club template - Create a new club - Click the Actions > Enrollments link => Without this patch you can access the page => With this patch applied you cannot, and a tooltip explains why (feel free to suggest another wording) - Add a new patron to this club (from /cgi-bin/koha/opac-user.pl#opac-user-clubs) - Notice that the action link is not enabled and click takes you to the list of enrollments Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 729200ae57b81966b3ae5e312eef8e75123f85b9 Author: Andrew Fuerste-Henry Date: Thu Feb 27 14:09:02 2020 -0600 Bug 24747: Corrects on-screen instructions in branch transfer limits To test: 1- go to cgi-bin/koha/admin/branch_transfer_limits.pl 2- see wording "Check the boxes for the libraries you accept to checkin items from" 3- apply patch 4- see wording "Check the boxes for the libraries you allow your items to be transferred to" To verify new wording accuractely describes behavior: 1- Set UseBranchTransferLimits set to Enforce using itemtype 2- Confirm circ rules allow holds 3- Confirm hold policy by item type allows holds 4- Confirm all branches are valid pickup locations in branch setup 5- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, disable all transfers so Branch A does not accept books from any other branch 6- Find a patron from Branch A 7- Find a book from Branch B 8- On the intranet, successfully place hold on item for patron for pickup at branch A 9- Cancel hold 10- Log into opac as patron 11- Successfully place hold on item for pickup at Branch A 12- Cancel hold 13- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, ENABLE all transfers so Branch A DOES accept books from any other branch 14- In Branch Transfer Limits, set dropdown to Branch B, select itemtype Book, disable all transfers so Branch B does not accept books from any other branch 15- On the intranet, try to place a hold on item for patron, confirm Branch B is your only pickup option 16- On the OPAC, log in as patron, try to place a hold on item, confirm Branch B is your only pickup option Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit c44bfe12087cda33b351b157014e818db2e4613a Author: Owen Leonard Date: Thu Feb 27 02:06:34 2020 +0000 Bug 24746: Duplicate id in opacheader markup This patch removes '
' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Signed-off-by: Bernardo Gonzalez Kriegel Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; } don't know the intended value but works :) Work as described following test plan, no errors. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit bd88b10c6fbf5b6ee19ff71dc8c9777de26d5eb6 Author: Martin Renvoize Date: Mon Mar 2 09:27:54 2020 +0000 Bug 13327: Compiled CSS Signed-off-by: Martin Renvoize commit 7b63d55ddc0d821b7311fcad714ff46ff750f08a Author: Owen Leonard Date: Wed Feb 19 13:47:11 2020 +0000 Bug 13327: (follow-up) Correct CSS and XSL errors This patch adds back the CSS changes which seem to have been lost in a rebase somewhere. The patch also corrects a bad copy/paste in the XSL file which led to a 404 error. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5bbf80989a5b8d6a1222b0e95c242b9457dfb024 Author: Owen Leonard Date: Mon Aug 12 11:38:57 2019 +0000 Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Patroncards/Patroncard.pm | 2 +- Koha.pm | 2 +- Koha/ArticleRequest.pm | 17 +- Koha/Schema/Result/ArticleRequest.pm | 16 +- etc/koha-httpd.conf | 6 +- installer/data/mysql/kohastructure.sql | 4 +- installer/data/mysql/updatedatabase.pl | 9 + .../intranet-tmpl/prog/en/includes/clubs-table.inc | 4 +- .../en/modules/admin/branch_transfer_limits.tt | 2 +- .../prog/en/modules/members/memberentrygen.tt | 39 +-- .../prog/en/modules/tools/batchMod-edit.tt | 3 +- .../en/modules/tools/batch_record_modification.tt | 2 + .../prog/en/modules/tools/manage-marc-import.tt | 2 + .../prog/en/modules/tools/stage-marc-import.tt | 2 +- .../prog/en/modules/tools/upload-images.tt | 1 - koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 87 ++++--- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 3 +- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 4 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 263 ++++++++------------- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 23 +- misc/translator/LangInstaller.pm | 4 +- t/db_dependent/ArticleRequests.t | 5 +- 23 files changed, 205 insertions(+), 297 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 2 11:32:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 02 Mar 2020 10:32:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-937-g2d49d54ff4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2d49d54ff4660b3ee2ccbfdb8cbbf10e277ebc68 (commit) via 3631678c9566bcbb5776f2e6206cbd052a706c45 (commit) via 2682efccdb84d783be9d2acf41e8435227980bb6 (commit) via 3f8412cc9175bc00e2cb24171042a80178dedde0 (commit) from 104b87c9a093e5a2aa859f9d2d63ed2b8556bcaa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2d49d54ff4660b3ee2ccbfdb8cbbf10e277ebc68 Author: Jonathan Druart Date: Fri Feb 28 17:14:25 2020 +0100 Bug 24757: Add more tests Now we want to make sure we are not missing another situation. Signed-off-by: Martin Renvoize commit 3631678c9566bcbb5776f2e6206cbd052a706c45 Author: Jonathan Druart Date: Fri Feb 28 16:57:56 2020 +0100 Bug 24757: Leap day failing tests - Fix the tests! The same day was returned, for a different subtraction. Signed-off-by: Martin Renvoize commit 2682efccdb84d783be9d2acf41e8435227980bb6 Author: Jonathan Druart Date: Fri Feb 28 16:47:57 2020 +0100 Bug 24757: Leap day failing tests - refactoring Refactore the tests to add more of them after we fixed the failing ones. Signed-off-by: Martin Renvoize commit 3f8412cc9175bc00e2cb24171042a80178dedde0 Author: Jonathan Druart Date: Fri Feb 28 15:59:36 2020 +0100 Bug 24757: Leap day failing tests - It's like we are on 2020-02-28 Those tests were failing on 2020-02-28, next day was a leap day. Let's fake time and recreate the failure Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Patrons.t | 152 ++++++++++++++++++++++++++++++++---------- 1 file changed, 116 insertions(+), 36 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 2 12:09:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 02 Mar 2020 11:09:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-947-g0c6500f467 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0c6500f46776ee0682cc43d3ae3813e5e781cef9 (commit) via a495f29aaf3e181a400e7516280fd78404af327b (commit) via 0bd3b45ba63da574acb74ff709c4677b1a41dbbd (commit) via ae3e69a7dc2743b449561f35325aba77c4a182ed (commit) via a28e1928d3b7efe1503fee2f9cc077954353e5b7 (commit) via f870d027e4dddeab7d1237be0387d762bc7fa840 (commit) via 71279181b2bf864bdee8166181a91adc03d14ad4 (commit) via 6179fcce8cffa33a19e997e9ee6a88ae22ce43d5 (commit) via f64efb1a5c6e83a8d0870ec763746460241b16e2 (commit) via 274dcf9a9001d6a7f0296102577660fdff3b50c1 (commit) from 2d49d54ff4660b3ee2ccbfdb8cbbf10e277ebc68 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0c6500f46776ee0682cc43d3ae3813e5e781cef9 Author: Jonathan Druart Date: Mon Mar 2 11:32:34 2020 +0100 Bug 17016: (follow-up) Clear with 0.00 instead of blank (Use Price) Using Price, to formatted it correctly if needed So far it will not do anything as 'on_editing => 1' we keep 0.00, but it must be improved later (when we will handle that) Signed-off-by: Martin Renvoize commit a495f29aaf3e181a400e7516280fd78404af327b Author: Jonathan Druart Date: Tue Feb 25 11:54:45 2020 +0100 Bug 17016: Clear with 0.00 instead of blank Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0bd3b45ba63da574acb74ff709c4677b1a41dbbd Author: Aleisha Amohia Date: Tue Feb 25 04:19:05 2020 +0000 Bug 17016: (follow-up) Removing unnecessary code Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit ae3e69a7dc2743b449561f35325aba77c4a182ed Author: Aleisha Amohia Date: Tue Aug 2 05:47:28 2016 +0000 Bug 17016: Button to clear all fields in budget planning Currently there is no way to undo the 'auto-fill'. This patch adds a 'clear' option that resets the row. To test: 1) Go to Admin --> Budgets 2) Click a budget 3) Click Planning -> any option 4) Test the Auto-fill button to see what it does 5) Apply patch and refresh page 6) Should now be a Clear button 7) Auto-fill the row then click Clear button. Confirm it clears all fields and sets the fund remaining back to the original amount and styles. 8) Add another fund and confirm that this still works with multiple funds. Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Bouzid Fergani Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit a28e1928d3b7efe1503fee2f9cc077954353e5b7 Author: Jonathan Druart Date: Fri Feb 14 12:36:54 2020 +0100 Bug 21746: Remove NO_LIBRARY_SET NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. One occurrence left in C4::InstallAuth as there is no (real) logged in user yet. Test plan: * Install Koha to make sure NO_LIBRARY_SET is not needed during the install process * Login into Koha * Make sure the your library's name is displayed correctly in the header * Set another library * Confirm that the library's name is updated Signed-off-by: Bernardo Gonzalez Kriegel No problem during install, nor changing library. Fixed (pre-existing) tab in circ/branchtransfers.pl No errors Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit f870d027e4dddeab7d1237be0387d762bc7fa840 Author: Katrin Fischer Date: Sat Feb 29 21:57:09 2020 +0100 Bug 24390: (QA follow-up) Fix capitalization and simplyfy code a bit Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 71279181b2bf864bdee8166181a91adc03d14ad4 Author: Lucas Gass Date: Thu Jan 9 17:07:59 2020 +0000 Bug 24390: Add item total to rotating collections Displays the number of items in a rotating collection. TEST PLAN: 1. Set up some rotating collections and add some items to them. 2. No good way to see how many total items are in a given collection. 3. Apply patch 4. Look at collections again and you should see 'Total Items: X' 5. Make sure it is counting the total number of items correctly. Signed-off-by: Jessica Zairo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 6179fcce8cffa33a19e997e9ee6a88ae22ce43d5 Author: Lucas Gass Date: Wed Feb 19 18:25:48 2020 +0000 Bug 23547: Add column configuration to course reserves table in the OPAC This patch adds opac-course-reserves to the column config tool TEST PLAN: 1. Have some course reserves and go look at opac-course-reserves.pl 2. See all the unconfigurable columns 3. Apply patch 4. Browse to column config > OPAC > course_reserves_table 5. Try hiding each column and make sure the correct column is hidden on opac-course-reserves.pl Signed-off-by: Devinim Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit f64efb1a5c6e83a8d0870ec763746460241b16e2 Author: Marcel de Rooy Date: Mon Feb 24 14:05:23 2020 +0000 Bug 24617: Add number to Descriptions in catalogue detail view Same change as in bug 24530 for OPAC. Only much easier. No trouble from Syndetics. Test plan: Add or remove a few notes from the MARC record (tag 500 etc). Verify the number is correct on the detail page. Signed-off-by: Marcel de Rooy Tested the else part for 'notes' with a [% SET notes = 'test' %] in tt file. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 274dcf9a9001d6a7f0296102577660fdff3b50c1 Author: Nick Clemens Date: Tue Feb 25 18:51:41 2020 +0000 Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort To test: 1 - Enable sysprefs DumpTemplateVarsOpac DumpTemplateVarsIntranet 2 - View some pages on staff client and opac 3 - View the page source 4 - See a large mass of comments including the page vars at the top of the source 5 - Refresh page and note order of vars changes 6 - Apply patch 7 - View page source on some pages and note things are much easier to read 8 - Refresh page and note variable order does not change Signed-off-by: George Williams Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: acqui/basket.pl | 6 ++---- admin/columns_settings.yml | 16 ++++++++++++++++ admin/smart-rules.pl | 2 -- catalogue/detail.pl | 3 +-- circ/branchtransfers.pl | 2 +- circ/circulation.pl | 7 ------- circ/returns.pl | 5 ----- .../prog/en/includes/doc-head-open.inc | 2 +- .../intranet-tmpl/prog/en/includes/header.inc | 18 +++++------------- .../intranet-tmpl/prog/en/modules/admin/aqplan.tt | 22 +++++++++++++++++++--- .../prog/en/modules/catalogue/detail.tt | 2 +- .../en/modules/rotating_collections/addItems.tt | 1 + .../bootstrap/en/includes/doc-head-open.inc | 2 +- .../bootstrap/en/modules/opac-course-reserves.tt | 17 +++++++++++++++-- tools/overduerules.pl | 1 - 15 files changed, 63 insertions(+), 43 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 2 12:20:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 02 Mar 2020 11:20:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-951-g35b47f0119 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 35b47f0119ba124d63542e10e564c2dc61fa1ecc (commit) via 584cf35502364f91f31013ac201ac45d8c4bdaa8 (commit) via 95e4e0a153f22a98e2b676f5efb51eb3056419d6 (commit) via 08900d5653ee0a63ae4867d1a7c7337dac7529d3 (commit) from 0c6500f46776ee0682cc43d3ae3813e5e781cef9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 35b47f0119ba124d63542e10e564c2dc61fa1ecc Author: Katrin Fischer Date: Sun Mar 1 00:33:19 2020 +0100 Bug 15377: (QA follow-up) Fix capitalization and column heading Checked Out -> Checked out Circulation -> Status (matching other pages with this information) Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 584cf35502364f91f31013ac201ac45d8c4bdaa8 Author: Rogan Hamby Date: Tue Jan 14 14:38:36 2020 -0500 Bug 15377: Allow removal of 'checked out' items from course reserves 1) removes the restriction of not allowing a reserve to be removed if it is onloan 2) adds a column to the display that says with the item is checked out or available based on the onloan flag testplan: add an item to course reserves, check the item out, check that the Ciruclation column changes to Checked Out and that you can remove it Signed-off-by: David Nind Signed-off-by: Hannah Olsen Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 95e4e0a153f22a98e2b676f5efb51eb3056419d6 Author: Bernardo Gonzalez Kriegel Date: Fri Feb 14 11:33:44 2020 -0300 Bug 24664: Add missing *-messages-js.po If you try to update some language translation files translate script will complain of missing *-messajes-js.po file. This patch adds those missing files To test: 1) Go to misc translation 2) Update some language, eg- fr-FR Check error /usr/bin/msgmerge: error while opening "/.../misc/translator/po/es-ES-messages-js.po" for reading: No such file or directory 3) Apply this patch 4) Repeat 2), no error message Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 08900d5653ee0a63ae4867d1a7c7337dac7529d3 Author: Owen Leonard Date: Mon Dec 9 18:17:34 2019 +0000 Bug 24193: Add CodeMirror linting of JavaScript, CSS, HTML, and YAML system preferences This patch adds CodeMirror plugins for linting JS, CSS, HTML, and YAML. When invalid data is entered in a linted CodeMirror editor an icon is displayed in the editor's "gutter." Hovering over the icon displays the error message. This patch renames the minified CodeMirror JS file to match convention but the version is unchanged. To test, apply the patch and go to Administration -> System preferences. Test preferences of each type and confirm that each type of CodeMirror editor shows an error indicator if you entry invalid data. Valid data should trigger no error indicator. - HTML: e.g. OpacMainUserBlock, opacheader. Enter invalid HTML, for example "

Hello

World

." Example valid HTML: "

Hello world

" - JavaScript: e.g. OpacUserJS, IntranetUserJS. Example bad JS, "alert("Success!');" Example valid JS: "alert("Success!");" - CSS: e.g. IntranetUserCSS, SCOUserCSS. Example bad CSS, "p { color blue }" Example valid CSS, "p { color: blue; }" - YAML: e.g. OpacHiddenItems. Example bad YAML: "one: two, three: four" Example valid YAML: "one: two three: four" Also test that other CodeMirror instances still work correctly without linting: The advanced MARC editor, SQL reports editing. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../lib/codemirror/codemirror.min.css | 1 + ...{codemirror-compressed.js => codemirror.min.js} | 0 koha-tmpl/intranet-tmpl/lib/codemirror/css-lint.js | 40 + .../intranet-tmpl/lib/codemirror/css-lint.min.js | 1 + .../intranet-tmpl/lib/codemirror/html-lint.js | 59 + .../intranet-tmpl/lib/codemirror/html-lint.min.js | 1 + .../lib/codemirror/javascript-lint.js | 63 + .../lib/codemirror/javascript-lint.min.js | 1 + koha-tmpl/intranet-tmpl/lib/codemirror/lint.css | 73 + koha-tmpl/intranet-tmpl/lib/codemirror/lint.js | 252 + .../intranet-tmpl/lib/codemirror/lint.min.css | 1 + koha-tmpl/intranet-tmpl/lib/codemirror/lint.min.js | 1 + .../intranet-tmpl/lib/codemirror/yaml-lint.js | 41 + .../intranet-tmpl/lib/codemirror/yaml-lint.min.js | 1 + koha-tmpl/intranet-tmpl/lib/linters/csslint.js | 9126 ++++++ koha-tmpl/intranet-tmpl/lib/linters/csslint.min.js | 1 + .../intranet-tmpl/lib/linters/htmlhint.min.js | 8 + koha-tmpl/intranet-tmpl/lib/linters/js-yaml.js | 3946 +++ koha-tmpl/intranet-tmpl/lib/linters/js-yaml.min.js | 1 + koha-tmpl/intranet-tmpl/lib/linters/jshint.js | 29591 +++++++++++++++++++ koha-tmpl/intranet-tmpl/lib/linters/jshint.min.js | 1 + .../prog/en/includes/cateditor-ui.inc | 2 +- .../prog/en/modules/admin/preferences.tt | 15 +- .../prog/en/modules/cataloguing/editor.tt | 2 +- .../en/modules/course_reserves/course-details.tt | 17 +- .../en/modules/reports/guided_reports_start.tt | 4 +- .../intranet-tmpl/prog/js/pages/preferences.js | 34 +- misc/translator/po/am-Ethi-messages-js.po | 17 + misc/translator/po/ar-Arab-messages-js.po | 17 + misc/translator/po/as-IN-messages-js.po | 17 + misc/translator/po/az-AZ-messages-js.po | 17 + misc/translator/po/be-BY-messages-js.po | 19 + misc/translator/po/bg-Cyrl-messages-js.po | 18 + misc/translator/po/bn-IN-messages-js.po | 17 + misc/translator/po/ca-ES-messages-js.po | 17 + misc/translator/po/cs-CZ-messages-js.po | 18 + misc/translator/po/cy-GB-messages-js.po | 17 + misc/translator/po/da-DK-messages-js.po | 18 + misc/translator/po/de-CH-messages-js.po | 18 + misc/translator/po/de-DE-messages-js.po | 18 + misc/translator/po/dz-messages-js.po | 17 + misc/translator/po/el-GR-messages-js.po | 18 + misc/translator/po/en-GB-messages-js.po | 18 + misc/translator/po/en-NZ-messages-js.po | 18 + misc/translator/po/eo-messages-js.po | 18 + misc/translator/po/es-ES-messages-js.po | 18 + misc/translator/po/eu-messages-js.po | 17 + misc/translator/po/fa-Arab-messages-js.po | 17 + misc/translator/po/fi-FI-messages-js.po | 18 + misc/translator/po/fo-FO-messages-js.po | 18 + misc/translator/po/fr-CA-messages-js.po | 18 + misc/translator/po/fr-FR-messages-js.po | 18 + misc/translator/po/ga-messages-js.po | 18 + misc/translator/po/gd-messages-js.po | 17 + misc/translator/po/gl-messages-js.po | 17 + misc/translator/po/he-Hebr-messages-js.po | 18 + misc/translator/po/hi-messages-js.po | 17 + misc/translator/po/hr-HR-messages-js.po | 19 + misc/translator/po/hu-HU-messages-js.po | 18 + misc/translator/po/hy-Armn-messages-js.po | 17 + misc/translator/po/ia-messages-js.po | 17 + misc/translator/po/id-ID-messages-js.po | 17 + misc/translator/po/iq-CA-messages-js.po | 17 + misc/translator/po/is-IS-messages-js.po | 17 + misc/translator/po/it-IT-messages-js.po | 18 + misc/translator/po/iu-CA-messages-js.po | 17 + misc/translator/po/ja-Jpan-JP-messages-js.po | 18 + misc/translator/po/ka-messages-js.po | 17 + misc/translator/po/km-KH-messages-js.po | 17 + misc/translator/po/kn-Knda-messages-js.po | 17 + misc/translator/po/ko-Kore-KP-messages-js.po | 18 + misc/translator/po/ku-Arab-messages-js.po | 17 + misc/translator/po/lo-Laoo-messages-js.po | 17 + misc/translator/po/lv-messages-js.po | 19 + misc/translator/po/mi-NZ-messages-js.po | 17 + misc/translator/po/ml-messages-js.po | 17 + misc/translator/po/mon-messages-js.po | 17 + misc/translator/po/mr-messages-js.po | 17 + misc/translator/po/ms-MY-messages-js.po | 17 + misc/translator/po/my-messages-js.po | 17 + misc/translator/po/nb-NO-messages-js.po | 18 + misc/translator/po/ne-NE-messages-js.po | 17 + misc/translator/po/nl-BE-messages-js.po | 18 + misc/translator/po/nl-NL-messages-js.po | 18 + misc/translator/po/nn-NO-messages-js.po | 18 + misc/translator/po/oc-messages-js.po | 17 + misc/translator/po/pbr-messages-js.po | 17 + misc/translator/po/pl-PL-messages-js.po | 19 + misc/translator/po/prs-messages-js.po | 17 + misc/translator/po/pt-BR-messages-js.po | 18 + misc/translator/po/pt-PT-messages-js.po | 18 + misc/translator/po/ro-RO-messages-js.po | 19 + misc/translator/po/ru-RU-messages-js.po | 19 + misc/translator/po/rw-RW-messages-js.po | 17 + misc/translator/po/sd-PK-messages-js.po | 17 + misc/translator/po/sk-SK-messages-js.po | 18 + misc/translator/po/sl-SI-messages-js.po | 19 + misc/translator/po/sq-AL-messages-js.po | 17 + misc/translator/po/sr-Cyrl-messages-js.po | 19 + misc/translator/po/sv-SE-messages-js.po | 18 + misc/translator/po/sw-KE-messages-js.po | 17 + misc/translator/po/ta-LK-messages-js.po | 17 + misc/translator/po/ta-messages-js.po | 17 + misc/translator/po/tet-messages-js.po | 17 + misc/translator/po/th-TH-messages-js.po | 17 + misc/translator/po/tl-PH-messages-js.po | 17 + misc/translator/po/tr-TR-messages-js.po | 18 + misc/translator/po/tvl-messages-js.po | 17 + misc/translator/po/uk-UA-messages-js.po | 19 + misc/translator/po/ur-Arab-messages-js.po | 17 + misc/translator/po/vi-VN-messages-js.po | 18 + misc/translator/po/zh-Hans-CN-messages-js.po | 17 + misc/translator/po/zh-Hant-TW-messages-js.po | 17 + 113 files changed, 44766 insertions(+), 27 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/codemirror.min.css rename koha-tmpl/intranet-tmpl/lib/codemirror/{codemirror-compressed.js => codemirror.min.js} (100%) create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/css-lint.js create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/css-lint.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/html-lint.js create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/html-lint.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/javascript-lint.js create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/javascript-lint.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/lint.css create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/lint.js create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/lint.min.css create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/lint.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/yaml-lint.js create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/yaml-lint.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/linters/csslint.js create mode 100644 koha-tmpl/intranet-tmpl/lib/linters/csslint.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/linters/htmlhint.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/linters/js-yaml.js create mode 100644 koha-tmpl/intranet-tmpl/lib/linters/js-yaml.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/linters/jshint.js create mode 100644 koha-tmpl/intranet-tmpl/lib/linters/jshint.min.js create mode 100644 misc/translator/po/am-Ethi-messages-js.po create mode 100644 misc/translator/po/ar-Arab-messages-js.po create mode 100644 misc/translator/po/as-IN-messages-js.po create mode 100644 misc/translator/po/az-AZ-messages-js.po create mode 100644 misc/translator/po/be-BY-messages-js.po create mode 100644 misc/translator/po/bg-Cyrl-messages-js.po create mode 100644 misc/translator/po/bn-IN-messages-js.po create mode 100644 misc/translator/po/ca-ES-messages-js.po create mode 100644 misc/translator/po/cs-CZ-messages-js.po create mode 100644 misc/translator/po/cy-GB-messages-js.po create mode 100644 misc/translator/po/da-DK-messages-js.po create mode 100644 misc/translator/po/de-CH-messages-js.po create mode 100644 misc/translator/po/de-DE-messages-js.po create mode 100644 misc/translator/po/dz-messages-js.po create mode 100644 misc/translator/po/el-GR-messages-js.po create mode 100644 misc/translator/po/en-GB-messages-js.po create mode 100644 misc/translator/po/en-NZ-messages-js.po create mode 100644 misc/translator/po/eo-messages-js.po create mode 100644 misc/translator/po/es-ES-messages-js.po create mode 100644 misc/translator/po/eu-messages-js.po create mode 100644 misc/translator/po/fa-Arab-messages-js.po create mode 100644 misc/translator/po/fi-FI-messages-js.po create mode 100644 misc/translator/po/fo-FO-messages-js.po create mode 100644 misc/translator/po/fr-CA-messages-js.po create mode 100644 misc/translator/po/fr-FR-messages-js.po create mode 100644 misc/translator/po/ga-messages-js.po create mode 100644 misc/translator/po/gd-messages-js.po create mode 100644 misc/translator/po/gl-messages-js.po create mode 100644 misc/translator/po/he-Hebr-messages-js.po create mode 100644 misc/translator/po/hi-messages-js.po create mode 100644 misc/translator/po/hr-HR-messages-js.po create mode 100644 misc/translator/po/hu-HU-messages-js.po create mode 100644 misc/translator/po/hy-Armn-messages-js.po create mode 100644 misc/translator/po/ia-messages-js.po create mode 100644 misc/translator/po/id-ID-messages-js.po create mode 100644 misc/translator/po/iq-CA-messages-js.po create mode 100644 misc/translator/po/is-IS-messages-js.po create mode 100644 misc/translator/po/it-IT-messages-js.po create mode 100644 misc/translator/po/iu-CA-messages-js.po create mode 100644 misc/translator/po/ja-Jpan-JP-messages-js.po create mode 100644 misc/translator/po/ka-messages-js.po create mode 100644 misc/translator/po/km-KH-messages-js.po create mode 100644 misc/translator/po/kn-Knda-messages-js.po create mode 100644 misc/translator/po/ko-Kore-KP-messages-js.po create mode 100644 misc/translator/po/ku-Arab-messages-js.po create mode 100644 misc/translator/po/lo-Laoo-messages-js.po create mode 100644 misc/translator/po/lv-messages-js.po create mode 100644 misc/translator/po/mi-NZ-messages-js.po create mode 100644 misc/translator/po/ml-messages-js.po create mode 100644 misc/translator/po/mon-messages-js.po create mode 100644 misc/translator/po/mr-messages-js.po create mode 100644 misc/translator/po/ms-MY-messages-js.po create mode 100644 misc/translator/po/my-messages-js.po create mode 100644 misc/translator/po/nb-NO-messages-js.po create mode 100644 misc/translator/po/ne-NE-messages-js.po create mode 100644 misc/translator/po/nl-BE-messages-js.po create mode 100644 misc/translator/po/nl-NL-messages-js.po create mode 100644 misc/translator/po/nn-NO-messages-js.po create mode 100644 misc/translator/po/oc-messages-js.po create mode 100644 misc/translator/po/pbr-messages-js.po create mode 100644 misc/translator/po/pl-PL-messages-js.po create mode 100644 misc/translator/po/prs-messages-js.po create mode 100644 misc/translator/po/pt-BR-messages-js.po create mode 100644 misc/translator/po/pt-PT-messages-js.po create mode 100644 misc/translator/po/ro-RO-messages-js.po create mode 100644 misc/translator/po/ru-RU-messages-js.po create mode 100644 misc/translator/po/rw-RW-messages-js.po create mode 100644 misc/translator/po/sd-PK-messages-js.po create mode 100644 misc/translator/po/sk-SK-messages-js.po create mode 100644 misc/translator/po/sl-SI-messages-js.po create mode 100644 misc/translator/po/sq-AL-messages-js.po create mode 100644 misc/translator/po/sr-Cyrl-messages-js.po create mode 100644 misc/translator/po/sv-SE-messages-js.po create mode 100644 misc/translator/po/sw-KE-messages-js.po create mode 100644 misc/translator/po/ta-LK-messages-js.po create mode 100644 misc/translator/po/ta-messages-js.po create mode 100644 misc/translator/po/tet-messages-js.po create mode 100644 misc/translator/po/th-TH-messages-js.po create mode 100644 misc/translator/po/tl-PH-messages-js.po create mode 100644 misc/translator/po/tr-TR-messages-js.po create mode 100644 misc/translator/po/tvl-messages-js.po create mode 100644 misc/translator/po/uk-UA-messages-js.po create mode 100644 misc/translator/po/ur-Arab-messages-js.po create mode 100644 misc/translator/po/vi-VN-messages-js.po create mode 100644 misc/translator/po/zh-Hans-CN-messages-js.po create mode 100644 misc/translator/po/zh-Hant-TW-messages-js.po hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 2 12:41:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 02 Mar 2020 11:41:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-954-g9a9e9fb95e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9a9e9fb95e52390451d774835e60903a89647a4d (commit) via 6321c7220ee485783cf31124d21ddcbfcc2a9d0c (commit) via 52e95fff34e1c6da967a4d86fbb99bec748ccb31 (commit) from 35b47f0119ba124d63542e10e564c2dc61fa1ecc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9a9e9fb95e52390451d774835e60903a89647a4d Author: Martin Renvoize Date: Mon Mar 2 11:15:04 2020 +0000 Bug 24735: DBRev 19.12.00.032 Signed-off-by: Martin Renvoize commit 6321c7220ee485783cf31124d21ddcbfcc2a9d0c Author: Jonathan Druart Date: Wed Feb 26 15:59:02 2020 +0100 Bug 24735: Remove more code from tests That was use by QP tests Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 52e95fff34e1c6da967a4d86fbb99bec748ccb31 Author: Jonathan Druart Date: Wed Feb 26 13:28:27 2020 +0100 Bug 24735: Remove QueryParser-related code At the last development meeting we have voted to remove the QueryParser-related code https://wiki.koha-community.org/wiki/Development_IRC_meeting_19_February_2020 Hea tells us that it has not been adopted, and the code/bug tracker that it is not really usable as it. As nobody is willing to work on it, we decided to remove it instead. Test plan: % prove t/db_dependent/Search.t must return green See commits from bug 9239 and confirm that the code is removed in this patch. Also play with the search on the UI and confirm that you do not see obvious regressions Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 34 +- C4/Context.pm | 47 - C4/Matcher.pm | 28 +- C4/Search.pm | 174 +- C4/UsageStats.pm | 1 - Koha.pm | 2 +- Koha/QueryParser/Driver/PQF.pm | 925 -------- Koha/QueryParser/Driver/PQF/Util.pm | 54 - Koha/QueryParser/Driver/PQF/query_plan.pm | 70 - Koha/QueryParser/Driver/PQF/query_plan/facet.pm | 46 - Koha/QueryParser/Driver/PQF/query_plan/filter.pm | 51 - Koha/QueryParser/Driver/PQF/query_plan/modifier.pm | 50 - Koha/QueryParser/Driver/PQF/query_plan/node.pm | 106 - .../QueryParser/Driver/PQF/query_plan/node/atom.pm | 49 - OpenILS/QueryParser.pm | 2242 -------------------- about.pl | 29 - cataloguing/addbooks.pl | 11 +- .../value_builder/marc21_linking_section.pl | 9 +- cataloguing/value_builder/unimarc_field_4XX.pl | 9 +- debian/templates/koha-conf-site.xml.in | 1 - etc/koha-conf.xml | 1 - etc/searchengine/queryparser.yaml | 1647 -------------- installer/data/mysql/sysprefs.sql | 1 - installer/data/mysql/updatedatabase.pl | 10 + koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 23 +- .../en/modules/admin/preferences/cataloguing.pref | 4 +- .../en/modules/admin/preferences/searching.pref | 9 +- labels/label-item-search.pl | 21 +- misc/migration_tools/bulkmarcimport.pl | 18 +- serials/subscription-bib-search.pl | 2 +- t/QueryParser.t | 136 -- t/db_dependent/QueryParser.t | 70 - t/db_dependent/Search.t | 133 +- t/db_dependent/UsageStats.t | 1 - t/db_dependent/default_search_class.pl | 37 - t/db_dependent/zebra_config.pl | 1 - 36 files changed, 46 insertions(+), 6006 deletions(-) delete mode 100644 Koha/QueryParser/Driver/PQF.pm delete mode 100644 Koha/QueryParser/Driver/PQF/Util.pm delete mode 100644 Koha/QueryParser/Driver/PQF/query_plan.pm delete mode 100644 Koha/QueryParser/Driver/PQF/query_plan/facet.pm delete mode 100644 Koha/QueryParser/Driver/PQF/query_plan/filter.pm delete mode 100644 Koha/QueryParser/Driver/PQF/query_plan/modifier.pm delete mode 100644 Koha/QueryParser/Driver/PQF/query_plan/node.pm delete mode 100644 Koha/QueryParser/Driver/PQF/query_plan/node/atom.pm delete mode 100644 OpenILS/QueryParser.pm delete mode 100644 etc/searchengine/queryparser.yaml delete mode 100644 t/QueryParser.t delete mode 100644 t/db_dependent/QueryParser.t delete mode 100755 t/db_dependent/default_search_class.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 3 10:49:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 03 Mar 2020 09:49:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-965-g3c9cc044ce Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3c9cc044ce9c2e8b37b98be5584b0b120940a183 (commit) via 21170c635cbdcb2d0b0ba2c4bb81f35c7cf58dab (commit) via c46dc0fadca08721b7e3e2909c1bbb13a8061ffe (commit) via 10cdbb9fde7529445d00fbe4f225d9aab2b25227 (commit) via 553627f12c388576af34af12b3867ea61ea5f03a (commit) via f1dc82d70bb60de7dcccbb224cac8142054910b8 (commit) via 7809a9fdd8c908e216844e906d58671c69a9e20e (commit) via ef1d49efb5d40ad3d620bc3b8472fb33edf5a475 (commit) via 863f129a58f2ed850b0195fe956b9951f12ae94b (commit) via 755d82015d78d4d0c8d33770e93db9bdd63cd587 (commit) via ab94a12ee46c511b5c09326d37925081996f89aa (commit) from 9a9e9fb95e52390451d774835e60903a89647a4d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3c9cc044ce9c2e8b37b98be5584b0b120940a183 Author: Martin Renvoize Date: Tue Mar 3 09:22:18 2020 +0000 Bug 23975: (QA follow-up) Add another plugin source Signed-off-by: Martin Renvoize commit 21170c635cbdcb2d0b0ba2c4bb81f35c7cf58dab Author: Tomas Cohen Arazi Date: Tue Mar 3 00:08:09 2020 -0300 Bug 23975: (QA follow-up) Add missing TT filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit c46dc0fadca08721b7e3e2909c1bbb13a8061ffe Author: Tomas Cohen Arazi Date: Tue Mar 3 00:04:36 2020 -0300 Bug 23975: (QA follow-up) Search button style and functionality This patch makes the search form button match the other buttons style, and also adds the submit() action on click. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 10cdbb9fde7529445d00fbe4f225d9aab2b25227 Author: Martin Renvoize Date: Mon Mar 2 18:58:13 2020 +0000 Bug 23975: (QA follow-up) Fix styling of install buttons Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 553627f12c388576af34af12b3867ea61ea5f03a Author: Martin Renvoize Date: Thu Feb 13 08:48:17 2020 +0000 Bug 23975: (follow-up) Don't rely on save_to being present The `save_to` shortcut method was introduced to Mojolicious in version 8.02 but we still support 7.21 as our minimum dependancy and as such we cannot yet use it. Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit f1dc82d70bb60de7dcccbb224cac8142054910b8 Author: Martin Renvoize Date: Wed Feb 12 14:43:01 2020 +0000 Bug 23975: Add 'Install' support for github results Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 7809a9fdd8c908e216844e906d58671c69a9e20e Author: Kyle M Hall Date: Tue Nov 5 12:31:04 2019 -0500 Bug 23975: Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit ef1d49efb5d40ad3d620bc3b8472fb33edf5a475 Author: Agustin Moyano Date: Fri Feb 7 23:54:14 2020 -0300 Bug 24615: Make object.search helper also order by embedded columns With this patch REST API request can order results by embedded columns. Full path to the column must be given for it to work. For example: If you are on biblio endpoint and you want to order by holding patron's card number you could > GET /biblio/1?_order_by=item.holds.cardnumber HTTP/1.1 > x-koha-embed: item.holds To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize commit 863f129a58f2ed850b0195fe956b9951f12ae94b Author: Agustin Moyano Date: Thu Jan 30 19:20:42 2020 +0000 Bug 24502: (follow-up) Add all 3 query parameters in api definition This patch adds api definition for body, query or header parameters. To use them include: * "$ref": "../parameters.json#/q_body" for body parameter. * "$ref": "../parameters.json#/q_param" for query parameter. * "$ref": "../parameters.json#/q_header" for header parameter. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 755d82015d78d4d0c8d33770e93db9bdd63cd587 Author: Agustin Moyano Date: Fri Jan 24 23:59:32 2020 -0300 Bug 24502: object.search also filter by prefetched columns This patch adds the possibility to object.search helper, to also filter by prefetched columns. In order to dynamically add filter parameters, they must be coded as json and placed in the body of the request, coded as string in 'q' query parameter or as string in 'x-koha-query' header. The coded json, is in fact dbix syntax. To test: 1. apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t 3. Sign off Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit ab94a12ee46c511b5c09326d37925081996f89aa Author: Jonathan Druart Date: Thu Feb 13 12:03:36 2020 +0100 Bug 17532: Make koha-shell propagate the error code Context: I am trying to make koha-misc4dev stop when something wrong happens. Basically we do not want the process to continue of the DB has not been populated correctly. It will make the errors easier to catch. The issue: Say a script that will return an error (die in perl for an easy example), koha-shell will not return the 255 error code, but 0 instead. The caller cannot know something wrong happened The solution is to propagate the error and make koha-shell return the same error code as the command it executed An example: === t.pl === die('something wrong'); % perl t.pl;echo $? something wrong at t.pl line 1. 255 % sudo koha-shell kohadev -p -c 'perl xxx.pl' ; echo $? something wrong at xxx.pl line 1. 0 Signed-off-by: Tomas Cohen Arazi Tested it with $ sudo debian/scripts/koha-shell kohadev -c 'exit 8' $ echo $? 8 The unpatched version returns 0 (forgets about the error code). Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/REST/Plugin/Objects.pm | 18 +++ Koha/REST/Plugin/Query.pm | 76 +++++++++++- api/v1/swagger/parameters.json | 25 +++- debian/scripts/koha-shell | 2 + debian/templates/koha-conf-site.xml.in | 17 +++ etc/koha-conf.xml | 17 +++ .../prog/en/modules/plugins/plugins-home.tt | 41 +++++++ plugins/plugins-home.pl | 31 +++++ plugins/plugins-upload.pl | 25 ++-- t/Koha/REST/Plugin/Query.t | 61 +++++++++- t/db_dependent/Koha/REST/Plugin/Objects.t | 135 ++++++++++++++++++++- 11 files changed, 436 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 3 12:04:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 03 Mar 2020 11:04:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-967-g292f562605 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 292f56260592a124a28e98103b243696344bd5a0 (commit) via bd9960a2d209bbcf9a23d0a5b1ade4ccb77ec2ca (commit) from 3c9cc044ce9c2e8b37b98be5584b0b120940a183 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 292f56260592a124a28e98103b243696344bd5a0 Author: Marcel de Rooy Date: Mon Mar 2 11:08:18 2020 +0000 Bug 24756: Catch two failed to load-variations in Security.t Test 7 in Security.t failed when 'failed to load HTTP resource' was returned by libxml2 instead of 'failed to load external entity'. We now remove the debugging with Dumper again and adjust the regex to include both variations. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit bd9960a2d209bbcf9a23d0a5b1ade4ccb77ec2ca Author: Martin Renvoize Date: Tue Mar 3 10:30:32 2020 +0000 Bug 24757: (RM follow-up) Restore test count Somehow we lost a '0' on the test count for t/db_dependent/Koha/Patrons.t Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Patrons.t | 2 +- t/db_dependent/Koha/XSLT/Security.t | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 3 16:29:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 03 Mar 2020 15:29:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-982-gab0f1df0c1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ab0f1df0c1ec652f59a3978ec1414129b7251cf3 (commit) via 3252c8d2ddaf30c2bb7270dda5863a022abc3adb (commit) via dd44efbc847b7909cd2dbc9f57dc43e918ce0985 (commit) via d6684f13fc65f0e84c386d47196826de5c65fdda (commit) via a1d89f8b889c0cc5f538c4edc2081a7739d848c7 (commit) via d3015f84e3ec15eb8b21f45e06b7c96183e0ed75 (commit) via 4d2037914c0481ef5fb5908a3cd3b59304b43ad2 (commit) via fcb545b4aed7d46daec23cddde192bbeb2eb380f (commit) via 16b3a163741227c21eaa842d7e2fdce0774f619d (commit) via 39ebdb4ea226d9e78bf1a774495022e85ffb1fd6 (commit) via 8781527637451dbf02b58f5eb441e0fda6496774 (commit) via 747531e8dec58acf37b739a0d8d8b04060a17111 (commit) via 5cf1e85191cda1ba5515011be18ba296d06df896 (commit) via 239ac3303c25ea25b41373ccba66b47968eefcd9 (commit) via e2adf9f28cc59b578fc68549bca3f0f901265ab6 (commit) from 292f56260592a124a28e98103b243696344bd5a0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ab0f1df0c1ec652f59a3978ec1414129b7251cf3 Author: Martin Renvoize Date: Tue Mar 3 15:01:48 2020 +0000 Bug 23355: DBRev 19.12.00.033 Signed-off-by: Martin Renvoize commit 3252c8d2ddaf30c2bb7270dda5863a022abc3adb Author: Martin Renvoize Date: Tue Mar 3 14:09:40 2020 +0000 Bug 23355: (QA follow-up) Add a modal confirm to the cashup action This patch adds a simple modal to confirm the cashup action adding a safely measure to it. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit dd44efbc847b7909cd2dbc9f57dc43e918ce0985 Author: Tomas Cohen Arazi Date: Tue Mar 3 10:50:44 2020 -0300 Bug 23355: Rename staff_id for manager_id This patch makes the parameter naming more consistent and also fixes the tests (there was a missmatch on the parameter naming, and tests count was incorrect). Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit d6684f13fc65f0e84c386d47196826de5c65fdda Author: Tomas Cohen Arazi Date: Tue Mar 3 10:48:22 2020 -0300 Bug 23355: (QA follow-up) Missing koha_object(s)_class definitions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit a1d89f8b889c0cc5f538c4edc2081a7739d848c7 Author: Tomas Cohen Arazi Date: Tue Mar 3 10:03:33 2020 -0300 Bug 23355: (QA follow-up) Add missing TT filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit d3015f84e3ec15eb8b21f45e06b7c96183e0ed75 Author: Tomas Cohen Arazi Date: Tue Mar 3 10:03:01 2020 -0300 Bug 23355: License fixes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 4d2037914c0481ef5fb5908a3cd3b59304b43ad2 Author: Martin Renvoize Date: Fri Sep 13 14:48:49 2019 +0100 Bug 23355: Add cashup permissions Add new 'cashup' sub-permissions to the 'cash_management' permission to allow fine grained control over whome may 'cashup' a cash register. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit fcb545b4aed7d46daec23cddde192bbeb2eb380f Author: Martin Renvoize Date: Thu Jan 23 13:40:33 2020 +0000 Bug 23355: Add register details page This patch adds a new page which can be accessed via the menu to the left of the point of sale page. This new page displays a list of transactions since the last 'cashup' action, a summary of transaction amounts and a button to allow the recording of a new 'cashup action. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 16b3a163741227c21eaa842d7e2fdce0774f619d Author: Martin Renvoize Date: Thu Jan 23 13:39:44 2020 +0000 Bug 23355: Split tests for Line vs Lines This patch simply splits the existing tests for accountlines into two test files, one for the singular object and one for the set. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 39ebdb4ea226d9e78bf1a774495022e85ffb1fd6 Author: Martin Renvoize Date: Fri Sep 13 14:11:37 2019 +0100 Bug 23355: Link cash_register_actions to cash_registers by foreign key Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 8781527637451dbf02b58f5eb441e0fda6496774 Author: Martin Renvoize Date: Thu Aug 22 09:10:51 2019 +0100 Bug 23355: Add accountline deletion test This patch adds a test to ensure database relations do not cascade deletions when a cash register is deleted. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 747531e8dec58acf37b739a0d8d8b04060a17111 Author: Martin Renvoize Date: Thu Jan 23 13:37:46 2020 +0000 Bug 23355: Add CASHUP actions This patch adds methods relating to cashup procedures to the cash register object to ease adding and querying for cashup actions related to the register. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 5cf1e85191cda1ba5515011be18ba296d06df896 Author: Martin Renvoize Date: Thu Jan 23 13:37:33 2020 +0000 Bug 23355: [DO NOT PUSH] DBIC Classes Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 239ac3303c25ea25b41373ccba66b47968eefcd9 Author: Martin Renvoize Date: Tue Jul 23 14:05:18 2019 +0100 Bug 23355: Add cash_register_actions table This patch adds the new cash_register_actions database table to allow for storing of cash register actions which are not already stored as accountlines. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit e2adf9f28cc59b578fc68549bca3f0f901265ab6 Author: Jonathan Druart Date: Tue Mar 3 15:58:40 2020 +0100 Bug 23534: Fix selenium tests The title of the page now contains lot of info (is it what we really want?) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Cash/Register.pm | 123 ++- Koha/{Statistic.pm => Cash/Register/Action.pm} | 31 +- .../Routinglists.pm => Cash/Register/Actions.pm} | 22 +- Koha/Schema/Result/Borrower.pm | 24 +- Koha/Schema/Result/CashRegister.pm | 19 +- ...{ItemsLastBorrower.pm => CashRegisterAction.pm} | 78 +- installer/data/mysql/kohastructure.sql | 16 + installer/data/mysql/updatedatabase.pl | 30 + installer/data/mysql/userpermissions.sql | 1 + .../intranet-tmpl/prog/en/includes/permissions.inc | 5 + .../intranet-tmpl/prog/en/includes/pos-menu.inc | 6 + koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 1 - .../intranet-tmpl/prog/en/modules/pos/register.tt | 199 +++++ pos/{pay.pl => register.pl} | 75 +- t/db_dependent/Koha/Account/{Lines.t => Line.t} | 318 +------- t/db_dependent/Koha/Account/Lines.t | 884 +-------------------- t/db_dependent/Koha/Cash/Register.t | 145 +++- t/db_dependent/selenium/patrons_search.t | 4 +- 19 files changed, 682 insertions(+), 1301 deletions(-) copy Koha/{Statistic.pm => Cash/Register/Action.pm} (64%) copy Koha/{Subscription/Routinglists.pm => Cash/Register/Actions.pm} (71%) copy Koha/Schema/Result/{ItemsLastBorrower.pm => CashRegisterAction.pm} (57%) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt copy pos/{pay.pl => register.pl} (50%) copy t/db_dependent/Koha/Account/{Lines.t => Line.t} (76%) mode change 100755 => 100644 hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 3 18:28:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 03 Mar 2020 17:28:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-984-gf7630d7469 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f7630d746947b82b40098be4cbac266e4a494553 (commit) via bdefa101078c597ed7664937e2c8e1c8c3643836 (commit) from ab0f1df0c1ec652f59a3978ec1414129b7251cf3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f7630d746947b82b40098be4cbac266e4a494553 Author: Martin Renvoize Date: Tue Mar 3 16:19:53 2020 +0000 Bug 23355: (RM follow-up) Remove reintroduced relationship As part of an accidental push of a DO NOT PUSH schema update commit we re-introduced a formerly removed relationship accessor This patch removes that mistake. Tests added to the pre-push hook to prevent future mishaps. Signed-off-by: Martin Renvoize commit bdefa101078c597ed7664937e2c8e1c8c3643836 Author: Martin Renvoize Date: Tue Mar 3 16:09:28 2020 +0000 Bug 23355: (RM follow-up) Add DROP statement for cash_register_actions Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Borrower.pm | 9 ++------- installer/data/mysql/kohastructure.sql | 1 + 2 files changed, 3 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 4 10:19:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 04 Mar 2020 09:19:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-985-g2f98da053b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2f98da053b5b7fd81ea0d7485f6dde6d55c6bd10 (commit) from f7630d746947b82b40098be4cbac266e4a494553 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2f98da053b5b7fd81ea0d7485f6dde6d55c6bd10 Author: Jonathan Druart Date: Wed Mar 4 09:49:06 2020 +0100 Bug 23355: Make "Print receipt" translatable Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 4 10:30:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 04 Mar 2020 09:30:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-986-g027f72da7c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 027f72da7c7bea317e977ed7fba0a06d6840d14a (commit) from 2f98da053b5b7fd81ea0d7485f6dde6d55c6bd10 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 027f72da7c7bea317e977ed7fba0a06d6840d14a Author: Martin Renvoize Date: Wed Mar 4 09:04:15 2020 +0000 Bug 23355: (RM follow-up) Tidy Template At Jonatans request, I have tidied the table markup Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/pos/register.tt | 56 ++++++---------------- 1 file changed, 14 insertions(+), 42 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 4 16:20:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 04 Mar 2020 15:20:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-995-gc0f3c9f29a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c0f3c9f29ad3b5de3efea95da515ab64a4bbd268 (commit) via c5c7f3efa22b755956be4d463a4c172f90ec723d (commit) via 4237fa95121ce0dadf032efd9429c3946f4de56d (commit) via ce2744e0e3f6bf86ca8279f2de3770f343a3bae6 (commit) via 87ff9883937527660541fdaabb3a382e89be3386 (commit) via a2fa0acb7daee624154c98be05ec85b613d64f42 (commit) via 12381ead911a71bac9c38599b0b3670060a8b121 (commit) via 7c6300c6570737415c55696408e34812bf417fdd (commit) via 5b78de6cefd7daf16f8ec0e95cb3e5e155fd8ac7 (commit) from 027f72da7c7bea317e977ed7fba0a06d6840d14a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c0f3c9f29ad3b5de3efea95da515ab64a4bbd268 Author: Martin Renvoize Date: Mon Mar 2 11:59:27 2020 +0000 Bug 24775: Add ID to POS submit payment button This patch simply adds an ID to the submit button to make it easier to overide styling and functionality. Test Plan: 0/ Inspect the element on page and note there is no id 1/ Apply patch 2/ Refresh page 3/ Inspect the element on page and note there is now an id Signed-off-by: Sally Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit c5c7f3efa22b755956be4d463a4c172f90ec723d Author: Martin Renvoize Date: Mon Mar 2 11:32:42 2020 +0000 Bug 24479: Use $Price filters for '0' amounts This patch adds the use of the $Price TT filter to properly format '0' amounts in the POS system. Signed-off-by: Sally Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 4237fa95121ce0dadf032efd9429c3946f4de56d Author: Martin Renvoize Date: Wed Mar 4 14:49:27 2020 +0000 Bug 24081: DBRev 19.12.00.034 Signed-off-by: Martin Renvoize commit ce2744e0e3f6bf86ca8279f2de3770f343a3bae6 Author: Tomas Cohen Arazi Date: Wed Mar 4 09:49:46 2020 -0300 Bug 24081: (QA follow-up) Fix small typo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 87ff9883937527660541fdaabb3a382e89be3386 Author: Martin Renvoize Date: Tue Mar 3 19:22:49 2020 +0000 Bug 24081: Add discount action to boraccount This patch adds the ability to apply discounts to existing patron charges from the boraccount page. Test plan 1/ Carry out some accounting actions that end up with debts on the patron record. (Add a manual invoice for example) 2/ Note a new 'Apply discount' action button on the unpaid debt 3/ Paid debts do not display the action button 4/ Click the button 5/ Enter an amount into the resulting modal and click confirm 6/ Confirm that the outstanding debt has been reduced by the amount you specified. 7/ Confirm that a new 'Discount' line appears on the patrons account 8/ Confirm that in the 'details' view of the debt that the discount line was used against the debt to create the reduction. 9/ Signoff Signed-off-by: Michal Denar Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit a2fa0acb7daee624154c98be05ec85b613d64f42 Author: Martin Renvoize Date: Thu Jan 9 14:14:34 2020 +0000 Bug 24081: Add DISCOUNT to the allowed 'reduce' types This patch adds the DISCOUNT type to the handled types list in the reduce method introduced in bug 23442 Signed-off-by: Michal Denar Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 12381ead911a71bac9c38599b0b3670060a8b121 Author: Martin Renvoize Date: Thu Jan 9 14:13:25 2020 +0000 Bug 24081: Add credit_types, offset_types and permissions This patch adds the credit_type, offset_type and permissions required for the addition of a discounting workflow in the accounts system. Signed-off-by: Michal Denar Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 7c6300c6570737415c55696408e34812bf417fdd Author: Martin Renvoize Date: Mon Mar 2 16:50:17 2020 +0000 Bug 24540: Prevent add button being triggered on enter This patch prevents the add button being triggered by hitting return from inside the collected from patron form input. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 5b78de6cefd7daf16f8ec0e95cb3e5e155fd8ac7 Author: Jonathan Druart Date: Tue Mar 3 09:55:03 2020 +0100 Bug 24741: (bug 21674 follow-up) Fix destructive update DB 19.12.00.017 Previous version of the SQL query did not deal correctly with subgroup. Test plan: checkout the following commit to be just before 017 commit 715da06db557edc4b1baa51cc278fdac362c01c4 Bug 22868: DBRev 19.12.00.016 reset_all # recreate the DB Create a complex tree of library groups, with several groups, subgroups, etc. When you add a new library, refresh the page to add it several time. When ready, git checkout master, restart all the things, execute the updatedatabase script, then go to the library groups page. You should see that the duplicated entries have been removed, but subgroups have not been deleted Signed-off-by: Bernardo Gonzalez Kriegel Tested with duplicated entries on groups and subgroups, going back to the right commit and doing clean install. Patch works, subgroups are preserved. No errors. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Account/Line.pm | 5 +- installer/data/mysql/account_credit_types.sql | 1 + installer/data/mysql/account_offset_types.sql | 1 + installer/data/mysql/updatedatabase.pl | 32 ++++++++++- installer/data/mysql/userpermissions.sql | 1 + .../prog/en/modules/members/boraccount.tt | 62 ++++++++++++++++++++-- koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 17 +++--- members/boraccount.pl | 20 +++++++ 9 files changed, 124 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 4 16:23:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 04 Mar 2020 15:23:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-996-gc16476af44 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c16476af444bc529dbc6500978c63969de4d2b9c (commit) from c0f3c9f29ad3b5de3efea95da515ab64a4bbd268 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c16476af444bc529dbc6500978c63969de4d2b9c Author: Jonathan Druart Date: Wed Mar 4 15:53:12 2020 +0100 Bug 24801: Display all the categories - Selenium fix To make sure we are going to be able to click on the "Delete" button of our newly created category PATRON_CAT, we are displaying them all. Test plan: Create several patron categories that will fill the first page: use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new; for my $i ( 1..20 ) { $builder->build_object({ class => 'Koha::Patron::Categories', value => { description => "cat_$i" } }); } Execute the selenium tests. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/selenium/administration_tasks.t | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 4 17:40:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 04 Mar 2020 16:40:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1002-g95b1b6662d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 95b1b6662deabfe6062e79b7d318f96da448d506 (commit) via 15655f0dbcea2fbada164745fe12037529f9f846 (commit) via 342f45b5dc802af4c4528bbf60b2a4e1611bb52a (commit) via d16710382e21d06bb4a11f616b4f6655a17d2499 (commit) via d4d1ffb91c6019fd7aec570ec9ac4193c21cab26 (commit) via 0359a04bf8086c2f17045c5c60d7b195ed77ec2b (commit) from c16476af444bc529dbc6500978c63969de4d2b9c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 95b1b6662deabfe6062e79b7d318f96da448d506 Author: Martin Renvoize Date: Wed Mar 4 16:05:28 2020 +0000 Bug 24082: DBRev 19.12.00.035 Signed-off-by: Martin Renvoize commit 15655f0dbcea2fbada164745fe12037529f9f846 Author: Tomas Cohen Arazi Date: Tue Mar 3 16:10:17 2020 -0300 Bug 24082: (QA follow-up): Template fixes This patch introduces missing TT filters and also replaces tabs for spaces to fix indentation problems. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 342f45b5dc802af4c4528bbf60b2a4e1611bb52a Author: Martin Renvoize Date: Thu Jan 23 16:05:06 2020 +0000 Bug 24082: Add access to historical transactions Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit d16710382e21d06bb4a11f616b4f6655a17d2499 Author: Martin Renvoize Date: Thu Jan 23 16:03:06 2020 +0000 Bug 24082: Add refund action to relevant lines Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit d4d1ffb91c6019fd7aec570ec9ac4193c21cab26 Author: Martin Renvoize Date: Thu Jan 23 15:52:25 2020 +0000 Bug 24082: Add `anonymous_refund` permission to `cash_management` This patch adds the new `anonymous_refund` permission to the `cash_management` flag and binds it to the visability of the register details page. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 0359a04bf8086c2f17045c5c60d7b195ed77ec2b Author: Jonathan Druart Date: Mon May 6 11:02:03 2019 -0500 Bug 22529: Use new C4::Auth::haspermission from svc/members/search The svc/members/search script can be used to retrieve patrons with a specific permission. This feature is only used once, to link patrons to funds. The code in the script is duplicated from what we have in C4::Auth::haspermission, and it makes sense to clean it. Test plan: Create a fund and add users to this fund. When you search for users you must only have a list of patrons with the acquisition.order_manage permission. Signed-off-by: Bernardo Gonzalez Kriegel Works as described. No errors Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 15 +- installer/data/mysql/userpermissions.sql | 1 + .../intranet-tmpl/prog/en/includes/permissions.inc | 5 + .../intranet-tmpl/prog/en/includes/pos-menu.inc | 2 +- .../intranet-tmpl/prog/en/modules/pos/register.tt | 199 ++++++++++++++++++++- pos/register.pl | 65 ++++++- svc/members/search | 15 +- 8 files changed, 286 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 4 17:45:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 04 Mar 2020 16:45:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1003-g69af9e18cd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 69af9e18cd59afa273f0b36444ea759c11558a1d (commit) from 95b1b6662deabfe6062e79b7d318f96da448d506 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 69af9e18cd59afa273f0b36444ea759c11558a1d Author: Tomas Cohen Arazi Date: Tue Mar 3 11:39:38 2020 -0300 Bug 24790: Add POS to the 'More' dropdown on the staff client This trivial patch adds 'Point of sale' to the dropdown. To test: 1. Notice there is no 'Point of sale' entry in the staff dropdown => FAIL: No dropdown 2. Apply this patch and reload => SUCCESS: Point of sale displays and works 3. Play with enabling/disabling the feature and removing permissions => SUCCESS: The entry in the dropdown respects the configured permissions and settings. 4. Sign off :-D Signed-off-by: George Williams Signed-off-by: Sally Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/header.inc | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 4 23:34:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 04 Mar 2020 22:34:58 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-1-g444a9b435d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 444a9b435d5ac571ff4147382594369f20bee479 (commit) from 4b6a201074135f6c964f408bdef1c4a6a1d7c685 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 444a9b435d5ac571ff4147382594369f20bee479 Author: Nick Date: Wed Oct 2 11:17:13 2019 +0000 Bug 23719: [19.05.x] Allow searching specific fields for matching authorities in ES To test: 1 - Export your authorities via Tools->Export data 2 - Define a record matching rule in Admin->Record matchign rules Use index: LC-card-number field: 010$a 3 - Stage the exported records for import and use the rule created above for matching 4 - The process does not complete 5 - Check intranet error logs - exception on unknown marclist 6 - Apply patch 7 - Repeat 8 - Success! 9 - prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Bug 23719: (follow-up) Add warn when passed invalid search field in marclist Note: I also remove warnings for undefined operation in this patch, is a trivial fix To test: prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 14 ++++--- .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 46 +++++++++++++++++----- 2 files changed, 46 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 5 01:32:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Mar 2020 00:32:22 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-3-g724f090717 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 724f090717eac58750bfd856c925dcc431705832 (commit) via 34083b5ddeac98566b389269fc0e082eb1603414 (commit) via d9485314eb86c8c5a466aba57c54680f053c79c3 (commit) from 76773a995d27d7371856acac3458d96384a29c6f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 724f090717eac58750bfd856c925dcc431705832 Author: Josef Moravec Date: Wed Feb 5 21:13:22 2020 +0000 Bug 13420: (QA follow-up): Fix typo itemdate -> itemdata Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 34083b5ddeac98566b389269fc0e082eb1603414 Author: Jonathan Druart Date: Tue Aug 6 08:56:44 2019 -0500 Bug 13420: Fallback to the previous behavior if published date is not used Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d9485314eb86c8c5a466aba57c54680f053c79c3 Author: Jonathan Druart Date: Sun Apr 28 22:53:55 2019 -0400 Bug 13420: Sort "Serial enumeration" by published date So far the sorting on volume information is incorrect. It sorts by the string displayed in the cell, which may not have any logics. A better solution would be to use Kyle's suggestion, see comments 7, 8, but it will need much more work. This patch suggests to use the publication date to sort this column. Note: In the code there is a switch depending on the existence of items.publisheddate, but I do not think it is valid, this valid should always exist if the item is received (did I miss something?) Test plan: You need to have different existing subscription, using different numbering. On the detail page of the bibliographic record you should be able to sort the serials (tab "Holdings") by "Serial enumeration". The sort will now use the publication dates. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: catalogue/detail.pl | 3 ++- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 10 +++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 5 01:45:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Mar 2020 00:45:03 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-5-gfdc568afa9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via fdc568afa932a03838b71679fbd4d1c50c9ed0cc (commit) via 5fbb0201dc0b60ad3048fc25881bf334db27999f (commit) from 724f090717eac58750bfd856c925dcc431705832 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fdc568afa932a03838b71679fbd4d1c50c9ed0cc Author: Jonathan Druart Date: Thu Nov 14 10:50:24 2019 +0100 Bug 23640: Flushing L1 on every SIP connection This patch flushes the L1 cache on each SIP connection (ie every invocation of process_request). This means each SIP connection will fetch values from the L2 cache (ie memcached) and persist the L1 cache (in Perl memory cache) only until a new SIP connection comes in. Without this patch, the L1 cache persists for the length of the server process, which means the L1 cache will become stale very quickly, which can lead to unexpected behaviour. Test plan: 1. Enable IssueLog 2. Start SIP server 2a. change to Koha git directory 2b. koha-shell kohadev 2c. perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 3. Issue book via SIP perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout 4. Check action_logs for "CIRCULATION ISSUE " line http://localhost:8081/cgi-bin/koha/tools/viewlog.pl 5. Disable IssueLog 6. Check in the book and then check it out again perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkin perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout 7. Check action_logs for "CIRCULATION ISSUE " line http://localhost:8081/cgi-bin/koha/tools/viewlog.pl 8. Note results Without the patch, you'll see a 2nd checkout. With the patch, you won't see the 2nd checkout. (Note: After applying the patch, you have to restart the SIP server.) Signed-off-by: David Cook Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5fbb0201dc0b60ad3048fc25881bf334db27999f Author: Jonathan Druart Date: Mon Jan 13 14:30:35 2020 +0100 Bug 24410: Fix multi holds Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Test plan: Confirm that prior to this patch you are not able to place a hold on several records at once, and that this patch fixes it Signed-off-by: Julian Maurice Signed-off-by: Agustin Moyano Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/SIP/SIPServer.pm | 4 ++++ koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 5 02:46:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Mar 2020 01:46:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-21-geae26a2167 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via eae26a21671e800d7d9ca822fa00561dc10e781d (commit) via 853d0ee468d1f5ba1efb3a9746855486f4d25e6c (commit) via 947db3b6cb77ea6cf68fa9218729068a303aab03 (commit) via 3b3a84d272fd6ee1259273e132739a4caa8bc616 (commit) via d024f3dd860856f0e0a878353af08fa6773743e7 (commit) via a6dc3c436c6cc01b9fd4f4e5fb576b9734d8a204 (commit) from cc43ee0685ff3c895442fdb2c6c13fe076a1ba7d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eae26a21671e800d7d9ca822fa00561dc10e781d Author: Joy Nelson Date: Thu Mar 5 01:19:27 2020 +0000 Bug 20882: DBRev 19.11.03.001 Signed-off-by: Joy Nelson commit 853d0ee468d1f5ba1efb3a9746855486f4d25e6c Author: Marcel de Rooy Date: Mon Feb 10 14:28:51 2020 +0000 Bug 20882: Move items.uri to mediumtext Applies to items and deleteditems. Test plan: Run new install or upgrade. Check field size. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 947db3b6cb77ea6cf68fa9218729068a303aab03 Author: Andreas Jonsson Date: Fri Jan 24 10:13:05 2020 +0000 Bug 24506: Multibranch limit does not work with ElasticSearch Test plan 1. Set up a system with ElasticSearch 2. Set up or make sure ther are at least two branches 3. create a group of branches 4. make sure there are items associated with any library in the group 5. make a search in opac limited by the library group 6. make an advanced search in intra limited by the library group 7. change SearchEngine system preference to Zebra and repeat 5. and 6. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 3b3a84d272fd6ee1259273e132739a4caa8bc616 Author: Marcel de Rooy Date: Mon Feb 10 15:17:38 2020 +0000 Bug 13574: Fix display of repeatable item subfields Applies to OPAC and staff: opac-MARCdetail and catalogue/MARCdetail. Test plan: [1] Pick an item. Pick two fields say URI and copy number, and fill these with a value like A | B. (The pipe char is important.) [2] Verify that the display of the item block on opac-MARCdetail shows both A and B in those columns. (Previously only B was shown.) [3] Verify the same on catalogue MARC detail, items tab. Signed-off-by: Marcel de Rooy Signed-off-by: Holly Cooper Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d024f3dd860856f0e0a878353af08fa6773743e7 Author: Marcel de Rooy Date: Thu Feb 13 09:27:26 2020 +0000 Bug 24649: Fix two other missing
  • tags for cloned subfields Same problem as previous patch in Batch item modification as well as serial-edit.pl. Test plan: [1] Go to Tools/Batch item modification. Test cloning subfield on batchMod-edit. [2] Go to a serial with "Create item when receiving". Receive an issue. Click add item. Test cloning subfield. Signed-off-by: Marcel de Rooy Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit a6dc3c436c6cc01b9fd4f4e5fb576b9734d8a204 Author: Marcel de Rooy Date: Thu Feb 13 08:56:35 2020 +0000 Bug 24649: Fix missing
  • tag on item editor for cloned subfield Instead of the parentNode (which is a div), we need the parent of the div (which is a li). So a simple fix. Test plan: To see the difference, test first without patch applied: Mark item subfield, say URI, as repeatable. Clone that subfield in item editor. Signed-off-by: Marcel de Rooy Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- catalogue/MARCdetail.pl | 20 +++++++++++++++----- catalogue/search.pl | 2 +- installer/data/mysql/kohastructure.sql | 4 ++-- installer/data/mysql/updatedatabase.pl | 9 +++++++++ .../prog/en/modules/cataloguing/additem.tt | 2 +- .../prog/en/modules/serials/serials-edit.tt | 4 ++-- .../prog/en/modules/tools/batchMod-edit.tt | 2 +- opac/opac-MARCdetail.pl | 13 ++++++++++--- opac/opac-search.pl | 2 +- 10 files changed, 43 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 5 03:20:02 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Mar 2020 02:20:02 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-31-g07af2a5645 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 07af2a5645303ad35b45fabc3ed966f2ab55899e (commit) via 5b1c56c7b5b4a23ce1d8cba8ab41276ec07b7add (commit) via 9bf4f492d82196f10bb017dd761ff6fa022a9bb9 (commit) via 91c16e9e7a8e9eccf37024b0efde14819b7093b9 (commit) from a2fe9fa991bc074c4703729b0f459a40a2cc0eb4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 07af2a5645303ad35b45fabc3ed966f2ab55899e Author: David Kuhn Date: Sat Aug 31 16:23:16 2019 -0700 Bug 23527: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Changing the template toolkit filter for rendering the value of BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url fixes the problem. To test (requires a Baker & Taylor username and password): 1. Enter the B&T url into BakerTaylorBookstoreURL. 2. Set BakerTaylorEnabled to "add" and enter your username and password. 3. Look up a title in the OPAC. 4. Locate a title with a cover image. 5. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 6. Display the full record for the title 7. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 8. Apply the patch. 9. Refresh the OPAC display. 10. Click on the cover image. You are now redirected to the specified url. 11. Return to the results list. 12. Click on a cover image. You are now redirected to the specified url. Signed-off-by: Owen Leonard Although I don't have valid Baker & Taylor credentials I was able to use dummy data to verify that the links in the template are correctly encoded with this patch. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5b1c56c7b5b4a23ce1d8cba8ab41276ec07b7add Author: Joy Nelson Date: Thu Mar 5 01:50:40 2020 +0000 Bug 24640: DBRev 19.11.03.002 Signed-off-by: Joy Nelson commit 9bf4f492d82196f10bb017dd761ff6fa022a9bb9 Author: Jonathan Druart Date: Wed Feb 12 12:26:25 2020 +0100 Bug 24640: Allow quotes.timestamp to be NULL It is broken with strict mode enable, timestamp is created without default value. Note that the .sql installer file init the value with NOW(), which is wrong. DBD::mysql::st execute failed: Field 'timestamp' doesn't have a default value [for Statement "INSERT INTO quotes (source, text) VALUES (?, ?);" with ParamValues: 0="poeut", 1="pouet"] at /kohadevbox/koha/tools/quotes/quotes_ajax.pl line 49. Test plan: Create a new quote of the day => Without this patch you will get an error Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 91c16e9e7a8e9eccf37024b0efde14819b7093b9 Author: Nick Clemens Date: Thu Feb 13 15:43:30 2020 +0000 Bug 24654: Remove trailing quote in rda264 XSLT To test: 1 - Find or add a recod with a 264 field 2 - Make sure there is a subfield b 3 - View the record in opac 4 - Right click on publisher link and copy and paste into a text editor 5 - Note the trailing " in the search 6 - Apply patch 7 - Refresh 8 - Link is correctly formed now Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/updatedatabase.pl | 9 +++++++++ koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl | 2 +- 6 files changed, 15 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 5 02:03:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Mar 2020 01:03:12 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-12-g3014538591 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 30145385916935464ccbc52a1a13755464863ef9 (commit) via 905c0bc5e0831148c8334a92863ec9289e2c67b5 (commit) via e9f0e0c6308746cc83e0aa0bbb4309c9f9013c8e (commit) via 5b043c6b4cd71455e0c342d74b9952d8231d069b (commit) via fdb9bbe40ad60ab7da6153c836396c395b6df3a7 (commit) via 1914e1016cd9b0315dc19d1c22cdbc6eec7efe40 (commit) via 0dac0b874779bc7617490199944af1d2b807e656 (commit) from fdc568afa932a03838b71679fbd4d1c50c9ed0cc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 30145385916935464ccbc52a1a13755464863ef9 Author: Owen Leonard Date: Fri Nov 22 19:29:53 2019 +0000 Bug 11281: Printing holds awaiting pickup prints both tabs This patch adds columns configuration to the holds awaiting pickup tables. Doing so helps solve the printing issue by adding a "Print" option to both tables. Using this print function will provide a printable version of only that table. To test you should have multiple holds in your system which are marked "waiting" and some which have been waiting longer than the value specified in the ReservesMaxPickUpDelay system preference. Apply the patch and go to Circulation -> Holds awaiting pickup. - On both the "Holds waiting" and "Holds waiting over..." tabs the DataTable should display correctly and all the controls should work, including the columns settings and the choices in the export menu. - Confirm that the "Print" action creates a printable version of only the table you are viewing. - Go to Administration -> Columns settings -> Circulation. - Change some visibility controls for the tables under the "holds_awaiting_pickup" heading (id=holdso and id=holdst). Confirm that these changes are reflected in the "Holds waiting" interface. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 905c0bc5e0831148c8334a92863ec9289e2c67b5 Author: Jonathan Druart Date: Mon May 6 15:37:38 2019 -0500 Bug 22860: Remove 1 remaining patron after authentication.t is ran Test plan: 0/ Do not apply the patch 1/ select count(*) from borrowers; 2/ Run the tests => Notice that you have 1 more patron 3/ Apply the patch and repeat 1/ and 2/ => Notice that you have the same number of patrons before and after the tests Signed-off-by: Hayley Mapley Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e9f0e0c6308746cc83e0aa0bbb4309c9f9013c8e Author: Jonathan Druart Date: Mon Feb 3 17:31:42 2020 +0100 Bug 24516: Add account_type to the columns settings on boraccount The column was missing from the yml file. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5b043c6b4cd71455e0c342d74b9952d8231d069b Author: Marcel de Rooy Date: Mon Jan 20 12:41:51 2020 +0000 Bug 13305: Remove tabindex from PrepareItemsRecordDisplay Test plan: Check the tab order of the item block on additem.pl (item editor), Acquisition (neworderempty or addiso2709), serials-edit.pl. You could also check services/itemrecorddisplay.pl and pass a biblionumber; this script is used in additem.js for cataloguing and acquisition. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit fdb9bbe40ad60ab7da6153c836396c395b6df3a7 Author: Nick Clemens Date: Fri Feb 7 16:52:52 2020 +0000 Bug 16719: (QA follow-up) Remove tabs Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1914e1016cd9b0315dc19d1c22cdbc6eec7efe40 Author: Oliver Behnke Date: Fri Feb 7 12:35:21 2020 +0000 Bug 16719: (follow-up) Update check on password mapping Change to allow for unmapped default passwords Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 0dac0b874779bc7617490199944af1d2b807e656 Author: Oliver Behnke Date: Fri Feb 7 12:31:31 2020 +0000 Bug 16719: Pass through undef rather than empty string in LDAP mapping Nullable DB fields should be passed null in cases where ldap fields are empty and not replaced with empty strings. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Auth_with_ldap.pm | 6 +-- C4/Items.pm | 10 ++--- admin/columns_settings.yml | 51 ++++++++++++++++++++++ .../prog/en/includes/waiting_holds.inc | 2 +- .../prog/en/modules/circ/waitingreserves.tt | 32 ++++++++++---- t/db_dependent/selenium/authentication.t | 2 + 6 files changed, 86 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 5 02:28:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Mar 2020 01:28:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-15-gcc43ee0685 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via cc43ee0685ff3c895442fdb2c6c13fe076a1ba7d (commit) via d4405602bc7b3edc1ef66a40c22880e644172db6 (commit) via 07aa0a562b35faaa8d04b479c33cec032ece6464 (commit) from 30145385916935464ccbc52a1a13755464863ef9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cc43ee0685ff3c895442fdb2c6c13fe076a1ba7d Author: Jonathan Druart Date: Thu Feb 13 14:24:52 2020 +0100 Bug 24643: Add test to cover the timezone Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d4405602bc7b3edc1ef66a40c22880e644172db6 Author: Andrew Isherwood Date: Wed Feb 12 16:28:58 2020 +0000 Bug 24643: Add unit tests Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 07aa0a562b35faaa8d04b479c33cec032ece6464 Author: Andrew Isherwood Date: Wed Feb 12 16:04:07 2020 +0000 Bug 24643: Support fractional seconds This patch allows dt_from_string to handle RFC3339 strings containing fractional seconds up to one thousandth of a second. Test plan: - Apply patch - prove t/DateUtils.t Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/DateUtils.pm | 2 +- t/DateUtils.t | 14 +++++++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 5 03:09:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Mar 2020 02:09:37 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-27-ga2fe9fa991 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a2fe9fa991bc074c4703729b0f459a40a2cc0eb4 (commit) via fb45f5bb98c07ac544184b8ffa029f1f5702e993 (commit) via c2c7c6e754c0cf44ce0f99798f5115731a61868e (commit) via 329796c7a95ed30a4e0ff4963518bf6f88a0f679 (commit) via c64ac9504fc72ee8e6b95ac26b679dc1701ca2bf (commit) via 0f7d7a8c2faf5777655a9b67c8cea8ffade56071 (commit) from eae26a21671e800d7d9ca822fa00561dc10e781d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a2fe9fa991bc074c4703729b0f459a40a2cc0eb4 Author: Owen Leonard Date: Mon Feb 10 19:04:57 2020 +0000 Bug 24621: Phase out jquery.cookie.js: Basic MARC editor This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply the patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit fb45f5bb98c07ac544184b8ffa029f1f5702e993 Author: Owen Leonard Date: Mon Feb 10 17:58:04 2020 +0000 Bug 24619: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c2c7c6e754c0cf44ce0f99798f5115731a61868e Author: Jonathan Druart Date: Mon Dec 16 17:15:19 2019 +0100 Bug 24389: Better error handle when claiming late orders A successful message says that the email has been sent and the order has been claimed, but nothing happened. Test plan: 0. Do not apply this patch 1. Create a new vendor, does not create a contact 2. Create some orders, close the basket 3. Go to the late orders page and claims some orders => You get a successful message, but the claim has not been done! 4. Apply this patch 5. Claim the orders => You get an error 6. Set a contact for the vendor 7. Claim the orders => Success In the docker container, you may need to: % apt install postfix % postfix start Edit /etc/hosts 127.0.0.1 localhost localhost.localdomain Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 329796c7a95ed30a4e0ff4963518bf6f88a0f679 Author: Katrin Fischer Date: Sat Feb 15 01:15:35 2020 +0000 Bug 18499: (QA follow-up) Add missing colon after label description To match the line above, a colon (:) was added after the description: Callnumber classification scheme: [pull down] Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c64ac9504fc72ee8e6b95ac26b679dc1701ca2bf Author: Nick Clemens Date: Fri Feb 14 17:59:38 2020 +0000 Bug 18499: (follow-up) Add missing filters Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 0f7d7a8c2faf5777655a9b67c8cea8ffade56071 Author: Nick Clemens Date: Thu Feb 6 13:14:30 2020 +0000 Bug 18499: Use items cn_source in cn_browser.pl This does a few things: * We fetch the cn_sort from the DB and use this rather than calculating based on DefaultClassificationSource We were already pulling based on the items source, so this should not change things * Rather than using JS to submit the form, it submits via html * Fix subtitle display and add barcode (it was retrieved in one query but not used) * Add option to apply different classification scheme to the search To test: 1 - Add cn_browser.pl to the 'plugin' field in a framework for 952$o 2 - Edit an item on a record in that framework 3 - Enter an itemcallnumber 4 - Click the two dots to launch the callnumber browser 5 - Note the results 6 - Apply patch 7 - Repeat 8 - Note subtitles and barcodes are displayed in results 9 - Note callnumbers are appropriate 10 - Try changing the class source used 11 - Try this with differing dewey,lcc, and other callnumbers 12 - Ensure results are as expected Signed-off-by: Myka Kennedy Stephens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: acqui/lateorders.pl | 6 ++-- cataloguing/value_builder/cn_browser.pl | 21 ++++++++------ .../prog/en/modules/admin/marctagstructure.tt | 3 +- .../prog/en/modules/cataloguing/addbiblio.tt | 18 ++++++------ .../cataloguing/value_builder/cn_browser.tt | 33 ++++++++++++---------- 5 files changed, 44 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 5 10:20:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Mar 2020 09:20:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1004-g8d8c5f7311 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8d8c5f7311820ff87e29be52d2290c5686454b94 (commit) from 69af9e18cd59afa273f0b36444ea759c11558a1d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d8c5f7311820ff87e29be52d2290c5686454b94 Author: Martin Renvoize Date: Thu Mar 5 08:51:51 2020 +0000 Bug 23354: (RM follow-up) Correction for cash register selection The form element for selectin cash register override at point of sale was misnamed and as such one could not actually override the cash register. This patch corrects the form element name and updates the logic very slighlty to ensure we still fall back to the defualt no the subsequent page load. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: pos/pay.pl | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 5 10:22:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Mar 2020 09:22:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1005-g98c53cd064 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 98c53cd06490ca0ae2cf1c96601ed35365e5b42a (commit) from 8d8c5f7311820ff87e29be52d2290c5686454b94 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 98c53cd06490ca0ae2cf1c96601ed35365e5b42a Author: Martin Renvoize Date: Thu Mar 5 08:51:51 2020 +0000 Bug 23354: (RM follow-up) Correction for cash register selection The form element for selectin cash register override at point of sale was misnamed and as such one could not actually override the cash register. This patch corrects the form element name and updates the logic very slighlty to ensure we still fall back to the defualt no the subsequent page load. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 5 14:32:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Mar 2020 13:32:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1015-g8f7a3bf5ea Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8f7a3bf5eaec24a5de642ba2fe95c0bf7d663af9 (commit) via 2ff054962ed308107b406b454f1c40802ff340e3 (commit) via 764053f2f40c3f2d0d54bc4a726764f296fd3a35 (commit) via 81655e7dbf6d769219260828b6f4781435efca1c (commit) via def667f7fc1b64171bec937861e34c5a94ead0d7 (commit) via 29bca18047f1d08e6408fbf21e5806cbedcae81c (commit) via 1af4010ff7344b12c193c9beb8a33f05125e7bf7 (commit) via c951f8e06a8db91308b85f2610ee9a8c4d89297a (commit) via 2526bc3c9f886cd0b31878bd329097b2229faa8f (commit) via 33f122621adcf94ecdbf28dad9a1017d6f9d5c79 (commit) from 98c53cd06490ca0ae2cf1c96601ed35365e5b42a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8f7a3bf5eaec24a5de642ba2fe95c0bf7d663af9 Author: Kyle M Hall Date: Wed Mar 4 19:02:53 2020 +0000 Bug 24492: Update GPL license Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 2ff054962ed308107b406b454f1c40802ff340e3 Author: Martin Renvoize Date: Thu Jan 9 13:53:09 2020 +0000 Bug 24492: Add branch details page This patch adds a new 'branch details' page to the POS system which displays a summary of the cash register transactions for a branch since each register was last cashed up. It also allows for cashing up individual registers or cashing up all registers at a given branch in one transaction. Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 764053f2f40c3f2d0d54bc4a726764f296fd3a35 Author: Josef Moravec Date: Wed Jan 22 14:24:15 2020 +0000 Bug 22615: Fix perlcritic Signed-off-by: Andrew Isherwood Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 81655e7dbf6d769219260828b6f4781435efca1c Author: Josef Moravec Date: Wed Jan 22 14:21:33 2020 +0000 Bug 22615: Add endpoint for getting one ill backend Signed-off-by: Andrew Isherwood Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit def667f7fc1b64171bec937861e34c5a94ead0d7 Author: Josef Moravec Date: Mon Apr 1 15:08:26 2019 +0000 Bug 22615: Add /ill_backends endpoint Signed-off-by: Andrew Isherwood Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 29bca18047f1d08e6408fbf21e5806cbedcae81c Author: Martin Renvoize Date: Thu Mar 5 13:01:22 2020 +0000 Bug 24369: DBRev 19.12.00.036 Signed-off-by: Martin Renvoize commit 1af4010ff7344b12c193c9beb8a33f05125e7bf7 Author: Tomas Cohen Arazi Date: Thu Jan 9 11:13:47 2020 -0300 Bug 24369: Add CORS support to the API This patch adds CORS support for API requests. It uses the AccessControlAllowOrigin syspref. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth.t => SUCCESS: Tests pass! 3. Set the AccessControlAllowOrigin to any string (for example, *) 4. Use any API testing tool (Postman?) to place a request on the API => SUCCESS: The response headers include Access-Control-Allow-Origin, containing what you set on the syspref 5. Sign off :-D Signed-off-by: Andrew Isherwood Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit c951f8e06a8db91308b85f2610ee9a8c4d89297a Author: Tomas Cohen Arazi Date: Thu Jan 9 10:44:09 2020 -0300 Bug 24369: Add CORS support to output_with_http_headers() This patch adds CORS support to output_with_headers(). It will use the AccessControlAllowOrigin syspref to pick the value and set the Access-Control-Allow-Origin header. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Output.t SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Andrew Isherwood Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 2526bc3c9f886cd0b31878bd329097b2229faa8f Author: Tomas Cohen Arazi Date: Thu Jan 9 10:42:43 2020 -0300 Bug 24369: Add AccessControlAllowOrigin syspref Signed-off-by: Andrew Isherwood Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 33f122621adcf94ecdbf28dad9a1017d6f9d5c79 Author: Julian Maurice Date: Fri Jan 31 11:13:47 2020 +0100 Bug 24552: Be compatible with Search::Elasticsearch 6.00 There is no need to specify the `client` param here because '5_0::Direct' is the default value for Search::Elasticsearch 5.x and it breaks when Search::Elasticsearch 6.x is installed Test plan: 1. Apply the patch 2. Make sure you have Search::Elasticsearch 5.x 3. Reload starman 4. Verify that search works 5. Install Search::Elasticsearch 6.x 6. Reload starman 7. Verify that search works Signed-off-by: Michal Denar Signed-off-by: Ere Maijala Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Output.pm | 2 + Koha.pm | 2 +- Koha/REST/V1.pm | 17 +- Koha/REST/V1/Illbackends.pm | 82 +++++++++ Koha/SearchEngine/Elasticsearch.pm | 1 - api/v1/swagger/definitions.json | 6 + api/v1/swagger/definitions/ill_backend.json | 13 ++ .../{checkouts.json => ill_backends.json} | 2 +- api/v1/swagger/paths.json | 6 + api/v1/swagger/paths/ill_backends.json | 118 +++++++++++++ installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 13 ++ .../intranet-tmpl/prog/en/includes/pos-menu.inc | 1 + .../en/modules/admin/preferences/web_services.pref | 6 + .../intranet-tmpl/prog/en/modules/pos/registers.tt | 184 +++++++++++++++++++++ .../prog/en/modules/tools/tools-home.tt | 8 + pos/registers.pl | 68 ++++++++ t/Output.t | 58 ++++++- t/db_dependent/api/v1/auth.t | 21 ++- 19 files changed, 598 insertions(+), 11 deletions(-) create mode 100644 Koha/REST/V1/Illbackends.pm create mode 100644 api/v1/swagger/definitions/ill_backend.json copy api/v1/swagger/definitions/{checkouts.json => ill_backends.json} (56%) create mode 100644 api/v1/swagger/paths/ill_backends.json create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt create mode 100755 pos/registers.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 6 01:00:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 06 Mar 2020 00:00:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-36-g6805597ea3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 6805597ea3dde2744ca6bd526a1d6f1a4f92d308 (commit) via 9192dead205003ec562e08d9435a6d4c305c528b (commit) via c31d1d54365d0c2fa2ce8337992a7ceab4045b37 (commit) via 701d2f64fca9f4f5eb266bc6557b9991498e2c17 (commit) via 841a0e573d23dbfb42fc07ab87676c5b95b64fab (commit) from 07af2a5645303ad35b45fabc3ed966f2ab55899e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6805597ea3dde2744ca6bd526a1d6f1a4f92d308 Author: Julian Maurice Date: Fri Feb 14 09:46:01 2020 +0100 Bug 24661: Fix inclusion of locale-related javascript files 2 js files (Gettext.js, i18n.js) + 1 generated js file (locale_data.js) were added by bug 21156. Their URL are broken and the files are not loaded. Use Template::Toolkit plugin Asset to include these files, and exclude locale_data.js when language is english, because obviously translations are not needed in this case. Test plan: 1. Just make sure the files mentioned above are loaded correctly when in English and in other languages as well Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 9192dead205003ec562e08d9435a6d4c305c528b Author: Julian Maurice Date: Wed Feb 26 20:09:52 2020 +0100 Bug 24734: Fix paths in LangInstaller.pm for JS files Use intrahtdocs and opachtdocs in order to get the correct paths for all kind of installations Test plan: 1. With a dev install, run ./translator create/update/install xx-XX and verify that there is no error message 2. With a standard install, run ./translator create/update/install xx-XX and verify that there is no error message Signed-off-by: Bernardo Gonzalez Kriegel Tested for dev/single/standard installs, no errors, just a (normal) warn from po2json. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c31d1d54365d0c2fa2ce8337992a7ceab4045b37 Author: Martin Renvoize Date: Fri Feb 14 11:42:54 2020 +0000 Bug 21156: (RM follow-up) Correction to added filters These lines required url filters rather than uri filters, my mistake :( Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 701d2f64fca9f4f5eb266bc6557b9991498e2c17 Author: Martin Renvoize Date: Mon Feb 10 14:13:04 2020 +0000 Bug 21156: (RM follow-up) Add missing filters Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 841a0e573d23dbfb42fc07ab87676c5b95b64fab Author: Julian Maurice Date: Mon Jan 4 21:08:29 2016 +0100 Bug 21156: Add plural translation capabilities to JS files It adds Javascript equivalent of Koha::I18N's exported subroutines, and they are used the same way. String extraction is done only on *.js files and require gettext 0.19 (available in Debian jessie, and also in wheezy-backports) It adds Javascript library Gettext.js for handling translation and a Perl script po2json to transform PO file into JSON. Gettext.js and po2json both come from Locale::Simple. There are several tools named po2json. It's simpler to integrate this one into Koha than to check if the good one is installed on the system. Locale::Simple is not needed. To avoid polluting the global namespace too much, this patch also introduce a global JS object named Koha and add some stuff in Koha.i18n Test plan: 1. Add a translatable string in a JS file. For example, add this: alert(__nx("There is one item", "There are {count} items", 3, {count: 3})); to staff-global.js 2. cd misc/translator && ./translate update fr-FR 3. Open misc/translator/po/fr-FR-messages-js.po, verify that your string is present, and translate it 4. cd misc/translator && ./translate install fr-FR 5. (Optional) Verify that koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js exists and contains your translation 6. Open your browser on the staff main page, change language and verify that the message is translated 7. Repeat 1-6 on OPAC side Signed-off-by: Martin Renvoize Signed-off-by: Bernardo Gonzalez Kriegel Works well, translation is OK and test message is displayed correctly. Current qa-tool error is a false positive. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 2 +- koha-tmpl/intranet-tmpl/js/Gettext.js | 1264 ++++++++++++++++++++ koha-tmpl/intranet-tmpl/js/i18n.js | 51 + .../prog/en/includes/doc-head-close.inc | 10 + koha-tmpl/opac-tmpl/bootstrap/js/Gettext.js | 1264 ++++++++++++++++++++ koha-tmpl/opac-tmpl/bootstrap/js/i18n.js | 51 + misc/translator/LangInstaller.pm | 70 +- misc/translator/po2json | 249 ++++ 8 files changed, 2950 insertions(+), 11 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/js/Gettext.js create mode 100644 koha-tmpl/intranet-tmpl/js/i18n.js create mode 100644 koha-tmpl/opac-tmpl/bootstrap/js/Gettext.js create mode 100644 koha-tmpl/opac-tmpl/bootstrap/js/i18n.js create mode 100755 misc/translator/po2json hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 6 01:17:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 06 Mar 2020 00:17:24 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-40-g96e2517322 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 96e251732266112274b1019b677e7b60a2a2808a (commit) via 06608137cace00dd309105374c7ea27c386ce361 (commit) via f7ec696d7145fa57305922f037b53bdb222fcf13 (commit) via 25778fdc5effa0654866c51ed8862761dd31e9cf (commit) from 6805597ea3dde2744ca6bd526a1d6f1a4f92d308 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 96e251732266112274b1019b677e7b60a2a2808a Author: Jonathan Druart Date: Wed Feb 12 15:24:35 2020 +0100 Bug 24642: Make Cache::Memcached::Fast::Safe required There is something wrong between the logic in Koha::Cache->new and our dependencies. We are having Cache::Memcached required, but Cache::Memcached::Fast::Safe is optional. However, in Koha::Cache->new we are initializing the Memcached cache only if Cache::Memcached::Fast::Safe is installed. We could fix the logic in Koha::Cache, but it seems better to make Cache::Memcached::Fast::Safe mandatory (especially after bug 13193). Note that after bug 13193, you are loosing the Memcached cache, as Cache::Memcached::Fast::Safe will not get installed by default. Signed-off-by: Julian Maurice Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 06608137cace00dd309105374c7ea27c386ce361 Author: Martin Renvoize Date: Fri Feb 7 14:32:13 2020 +0000 Bug 13193: (RM follow-up) Remove Cache::Memcached::Fast from PerlDependencies We replaced this module with Cache::Memcached::Fast::Safe and so do not need to depend upon it any longer. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit f7ec696d7145fa57305922f037b53bdb222fcf13 Author: Mason James Date: Fri Feb 7 15:11:05 2020 +1300 Bug 13193: (follow-up) Update debian/control file The dependancy has now been packaged, this patch adds it to the debian control file for package installs. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 25778fdc5effa0654866c51ed8862761dd31e9cf Author: Joonas Kylmälä Date: Mon Sep 16 10:26:01 2019 +0000 Bug 13193: Make Memcached usage fork safe When a high enough number of forks try to access for example system preferences with Koha::Cache using memcached as backend the results of different cache requests get mixed up. The problem is fixed by using Cache::Memcached::Fast::Safe that is a fork safe version of Cache::Memcached::Fast. Sponsored-by: The National Library of Finland Signed-off-by: David Cook Works as described, and solves an insidious difficult to debug problem in Koha. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 6 +++--- Koha/Cache.pm | 6 +++--- debian/control | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 6 02:19:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 06 Mar 2020 01:19:33 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-41-g30e12584a7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 30e12584a7c6e635abd0e02be1fbbf67f5ae4929 (commit) from 96e251732266112274b1019b677e7b60a2a2808a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 30e12584a7c6e635abd0e02be1fbbf67f5ae4929 Author: Jonathan Druart Date: Mon Feb 17 18:18:48 2020 +0100 Bug 24677: (bug 24002 follow-up) Incorrect DATE value: '00-00-0000' in C4/Serials.pm Oops, wrong copy/paste here! The column order changes was not expected. From bug 24002: commit 3d3336ed6607d80b72502075ebf9567cf48e1709 Bug 24002: Incorrect DATE value: '00-00-0000' in C4/Serials.pm The changes from this patch are like: - year(IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate)) as year, + year(IF(serial.publisheddate IS NULL,serial.publisheddate,serial.planneddate)) as year, This is stilly, if publisheddate is null we do not want to return it. It comes from a wrong copy/paste from the other commits: - ORDER BY IF(publisheddate<>'0000-00-00',publisheddate,planneddate) DESC"; + ORDER BY IF(publisheddate IS NULL,planneddate,publisheddate) DESC"; ="00-00-0000" vs <>"0000-00-00" Test plan: Eyeball the previous patches from bug 24002 and notice that the changes in the commit listed previously are wrong Signed-off-by: Janusz Kaczmarek Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 6 09:55:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 06 Mar 2020 08:55:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1016-g8b003f4b73 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8b003f4b73a4e1ff8c21e2e6ac6f75b3abe3ba04 (commit) from 8f7a3bf5eaec24a5de642ba2fe95c0bf7d663af9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8b003f4b73a4e1ff8c21e2e6ac6f75b3abe3ba04 Author: Martin Renvoize Date: Thu Mar 5 14:16:33 2020 +0000 Bug 24492: (RM follow-up) Redirect to correct page after cashup Cashup of a single register was resulting in a redirect to the register details page. It should return to the branch details page instead. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt | 2 +- pos/registers.pl | 13 ++++++++++++- 2 files changed, 13 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 6 11:35:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 06 Mar 2020 10:35:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1032-ga8964a2dc4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a8964a2dc4dd28844ef5def509427a8b259b4980 (commit) via 7d2a5ef86528679bb5ad8c10cf526c203cddd9c9 (commit) via cc8f2cb50d39bf66a0480b57597a4d081145c3a8 (commit) via 2ba1493e2e8b48a4ca277ed2cea3f31d54c9e45d (commit) via a2449a81be55aa5b3710ca2c6df7884513f89540 (commit) via d26a10c1fedf55a7e85387e6555601e41db0e043 (commit) via 5f853ca1179ab4c69262d65370e0a6f51764dc47 (commit) via 5d30f378b2e55072af680681930bb3cd1a79fb44 (commit) via be31436e858347a3ea1e4d3047368233fea6e0b5 (commit) via 7d23692511c4203736f63aa56d66492d9fdfaeef (commit) via 3aa52a4bf6e1fe7d94504f1eca384d4a4836d4ee (commit) via c2f1106f2e026fe6860e7e4df470540ce3e37405 (commit) via 2eebecfb621d0124b0b8be868c6d2a4fe959a9f7 (commit) via c77e64de1ea64239e64e8479527f2b023adb5189 (commit) via 2cc6c709c1d106800cee6bfe257a88a741d3f319 (commit) via 0fcbec7507a4117a7389d8bcebffed57db3a477c (commit) from 8b003f4b73a4e1ff8c21e2e6ac6f75b3abe3ba04 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a8964a2dc4dd28844ef5def509427a8b259b4980 Author: Martin Renvoize Date: Fri Mar 6 10:08:55 2020 +0000 Bug 23051: DBRev 19.12.00.037 Signed-off-by: Martin Renvoize commit 7d2a5ef86528679bb5ad8c10cf526c203cddd9c9 Author: Andrew Isherwood Date: Thu Mar 5 10:26:38 2020 +0000 Bug 23051: (follow-up) Remove call to GetFines As mentioned by Nick in comment #69 and subsequently discussed on Slack, the call to GetFines in renew_item was unnececcesary. It has now been removed. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit cc8f2cb50d39bf66a0480b57597a4d081145c3a8 Author: Andrew Isherwood Date: Wed Mar 4 15:11:23 2020 +0000 Bug 23051: (follow-up) Fix renew summary display As mentioned in comment #69: >staff client does unless I click 'pay' next to the individual fine Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 2ba1493e2e8b48a4ca277ed2cea3f31d54c9e45d Author: Nick Clemens Date: Wed Mar 4 13:25:48 2020 +0000 Bug 23051: (QA follow-up) Missing curly and tabs and fix test Some rebase issues, accounttype no longer exists, circ rules make CanBookBeRenewed fail, so we mock that too interface must be passed as a hashref Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit a2449a81be55aa5b3710ca2c6df7884513f89540 Author: Andrew Isherwood Date: Wed Oct 9 15:13:54 2019 +0100 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test Rebasing was a nightmare, so I'm squashing the sign off follow-ups to ease the pain with any future rebases Includes: Bug 23051: (follow-up) Refactor renewal code As per Nick's first point in comment #20, the code that tests for renewability and renews items has been refactored into it's own function. Bug 23051: (follow-up) Provide feedback For renewals that fail when a fine is being paid off, this patch causes any errors to be passed back to the template for display. Addresses the second point in Nick's comment #20 Bug 23051: (follow-up) Fix unit tests As raised by Nick in comment #35 Bug 23051: (follow-up) Fix/improve feedback This follow up patch addresses the following parts of Nick's feedback in comment #35: - it would be nice to get feedback on what was successfully renewed as well - In general I think I would prefer to see 'ok' and 'not_ok' returned as a single 'renewal_results' array - There is no listing of errors if I use the 'pay' button on an individual fine Bug 23051: (follow-up) Refactor methods This follow up patch addresses the following parts of Nick's feedback in comment #35: - I don't really like that the functions are internal functions and then exported - I think the pref description should highlight that if 'RenewalPeriodBase' is set to due date, there may be doubled charges Bug 23051: (follow-up) Add SIP summary This follow up patch addresses the following parts of Nick's feedback in comment #35: - Ideally SIP would get feedback in a screen message Bug 23051: (follow-up) Renewing in OPAC This follow up patch addresses the following parts of Nick's feedback in comment #35: - I am also not sure about the code path if a patron paid fines on the opac (via paypal etc.) but renewals are not allowed on the opac. We've introduced the syspref RenewAccruingItemInOpac (default is off) which, when enabled, will cause items attached to fines that are paid off in the OPAC (via payment plugins), to be automatically renewed. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit d26a10c1fedf55a7e85387e6555601e41db0e043 Author: Andrew Isherwood Date: Tue Jun 11 14:17:17 2019 +0100 Bug 23051: Renew items when fines paid off When the RenewAccruingItemWhenPaid syspref is enabled and all the fines on an item that is accruing fines are paid, we automatically renew that item to prevent it from starting to accrue fines again. This patch adds an additional argument to C4::Circulation::AddRenewal which allows us to skip the calculation of fines upon renewal, which we don't want to do if the fines on that item have just been paid. Existing calls to AddRenewal have not been amended because there seems to be a convention of only passing undef when adding arguments that require their positioning to be maintained. Since the new argument is the last one, this is not the case with any existing call. Sponsored-by: Loughborough University Signed-off-by: Lucy Harrison Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 5f853ca1179ab4c69262d65370e0a6f51764dc47 Author: Andrew Isherwood Date: Wed Jun 12 15:18:54 2019 +0100 Bug 23051: Add unit tests This patch adds unit tests for all modules affected by this bug Sponsored-by: Loughborough University Signed-off-by: Lucy Harrison Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 5d30f378b2e55072af680681930bb3cd1a79fb44 Author: Andrew Isherwood Date: Wed Jun 5 14:38:07 2019 +0100 Bug 23051: Add RenewAccruingItemWhenPaid syspref This patch adds the new syspref "RenewAccruingItemWhenPaid" Sponsored-by: Loughborough University Signed-off-by: Lucy Harrison Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit be31436e858347a3ea1e4d3047368233fea6e0b5 Author: Julian Maurice Date: Tue Feb 4 08:01:06 2020 +0100 Bug 24573: Add missing dependencies to cpanfile When using Elasticsearch, Catmandu::Store::ElasticSearch is required for search, and Catmandu::MARC is required for indexation Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 7d23692511c4203736f63aa56d66492d9fdfaeef Author: Jonathan Druart Date: Thu Mar 5 16:27:15 2020 +0100 Bug 24813: Prevent api/v1/holds.t to fail randomly Hold cannot be suspended if found=W: Koha::Hold->suspend_hold 90 if ( $self->is_found ) { # We can't suspend found holds So when TestBuilder generate a hold with found=W the test fail. A question however: Why did not we have the correct exception displayed somewhere? That would be much more helpful to find the problem! Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 3aa52a4bf6e1fe7d94504f1eca384d4a4836d4ee Author: Owen Leonard Date: Tue Feb 25 18:08:59 2020 +0000 Bug 24713: JavaScript error on staff client catalog search results page This patch modifies the output of template toolkit variables so that values in the in-page JavaScript are quoted. This avoids JavaScript errors when the template variable is empty. To test, apply the patch and perform a catalog search in the staff client. Use the browser's developer tool to check for JavaScript errors in the console. There should be none. Test with AmazonCoverImages both on and off. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit c2f1106f2e026fe6860e7e4df470540ce3e37405 Author: Kyle M Hall Date: Wed Mar 4 12:08:29 2020 -0500 Bug 24802: Updating holds can cause suspensions to apply to wrong hold On request.pl, the table of holds shows a suspend_until date picker for each hold, *unless* that hold is waiting or in transit. The script reserve/modrequest.pl assumes that there will be a suspend_until input for each hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of them are waiting or in transit. If you were to then set the suspend until date on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions would apply to the 10 found holds and not the holds they should apply to! Test Plan: 1) Place two holds on a record 2) Check in an item and trap it for the first hold 3) Now that one hold is waiting and the other is not, attempt to set a suspension date using the "Update hold(s)" button 4) Note your hold does not get suspended! 5) Apply this patch 6) Restart all the things! 7) Repeat steps 1-3 8) Your hold should now be suspended! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 2eebecfb621d0124b0b8be868c6d2a4fe959a9f7 Author: Fridolin Somers Date: Thu May 23 07:55:15 2019 +0200 Bug 22969: fix biblionumber on 001 in UNIMARC XSLT In UNIMARC default configuration the 001 is linked to biblio.biblionumber. In some XSLT files, 090$a is used. This is by default biblioitems.biblionumber so it usually works but it may not be the same and var biblionumber is used to create hyperlinks to record detail page. Test plan : 1) Use UNIMARC database 2) Set default in all XSLT system preferences 3) At OPAC, perform a search and click on a result 4) Check displayed page shows the correct biblio record 5) Same at intranet Signed-off-by: Bernardo Gonzalez Kriegel Tested on clean UNIMARC install. Before insert new records: "alter table biblioitems AUTO_INCREMENT = 5" Added two records, with result: +--------------+------------------+ | biblionumber | biblioitemnumber | +--------------+------------------+ | 1 | 5 | | 2 | 6 | +--------------+------------------+ Without patch, OPAC results shows for first record http://opac/cgi-bin/koha/opac-detail.pl?biblionumber=5, Wrong! with patch result is correct Works, no errors Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit c77e64de1ea64239e64e8479527f2b023adb5189 Author: Owen Leonard Date: Wed Mar 4 18:29:24 2020 +0000 Bug 24798: smart-rules.tt has erroneous comments This patch corrects a couple of invalid Template Toolkit comments in the Circulation and Fines rules template. To test, apply the patch and log into the staff client as an administrator. On the Circulation and Fines Rules page "View source" and look for instances of the text "[#% Default branch %#]" There should be none. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy [EDIT] There is a theoretical difference between [% # and [%#. The latter marks the whole directive as a comment and not just until EOL. Signed-off-by: Martin Renvoize commit 2cc6c709c1d106800cee6bfe257a88a741d3f319 Author: Owen Leonard Date: Wed Mar 4 19:47:26 2020 +0000 Bug 24803: Remove JS error when clicking "Log in to your account" This patch removes the "data-toggle" attribute from the login link in order to avoid a JavaScript error. Since we have a custom click handler to trigger the modal we don't need Bootstrap's "automatic" modal handling. Test plan: 1. Apply patch 2. Open F12 dev tools 3. Click "Log in to your account" on OPAC 4. Observe no Javascript errors in console Signed-off-by: David Cook Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0fcbec7507a4117a7389d8bcebffed57db3a477c Author: David Cook Date: Thu Feb 27 00:28:48 2020 +0000 Bug 24719: Remove use of CGI object in C4::Context::set_remote_address() This patch replaces the CGI "http" object method with its equivalent class method, which doesn't require object instantiation and thus skips global initialization and premature handling of the incoming HTTP request. Test plan: 0. Disable Plack if it is enabled 1. Set koha_trusted_proxies in koha-conf.xml to 1.1.1.1 2. Clear Memcached 3. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl 4. Note that form below "Upload progress" never appears and errors show in browser console 5. Apply the patch 6. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl 7. Note that form appears below "Upload progress" Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 8 +- C4/Context.pm | 3 +- C4/SIP/ILS.pm | 8 +- C4/SIP/ILS/Transaction/FeePayment.pm | 20 +++- C4/SIP/Sip/MsgType.pm | 42 ++++++- Koha.pm | 2 +- Koha/Account.pm | 27 ++++- Koha/Account/Line.pm | 92 ++++++++++++++ Koha/REST/V1/Patrons/Account.pm | 2 +- cpanfile | 2 + installer/data/mysql/sysprefs.sql | 2 + installer/data/mysql/updatedatabase.pl | 12 ++ .../intranet-tmpl/prog/en/includes/holds_table.inc | 4 +- .../prog/en/includes/renew_results.inc | 12 ++ .../prog/en/includes/renew_strings.inc | 32 +++++ .../en/modules/admin/preferences/circulation.pref | 14 +++ .../prog/en/modules/admin/smart-rules.tt | 4 +- .../prog/en/modules/catalogue/results.tt | 8 +- .../prog/en/modules/members/boraccount.tt | 1 + .../intranet-tmpl/prog/en/modules/members/pay.tt | 1 + .../prog/en/xslt/UNIMARCslim2intranetDetail.xsl | 2 +- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- .../bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 2 +- .../bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl | 6 +- members/boraccount.pl | 20 ++++ members/pay.pl | 19 +++ members/paycollect.pl | 36 ++++-- reserve/modrequest.pl | 4 +- t/db_dependent/Accounts.t | 16 +-- t/db_dependent/Circulation.t | 11 +- t/db_dependent/Koha/Account.t | 78 +++++++++++- t/db_dependent/Koha/Account/Line.t | 133 ++++++++++++++++++++- t/db_dependent/Koha/Account/Lines.t | 3 + t/db_dependent/api/v1/holds.t | 2 +- 34 files changed, 573 insertions(+), 57 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/renew_results.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/renew_strings.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 6 14:41:31 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 06 Mar 2020 13:41:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1033-g348a04e00f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 348a04e00f57e15dc3f1ef320c673961b47ca936 (commit) from a8964a2dc4dd28844ef5def509427a8b259b4980 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 348a04e00f57e15dc3f1ef320c673961b47ca936 Author: Martin Renvoize Date: Fri Mar 6 13:13:37 2020 +0000 Bug 23051: (RM follow-up) Fix rebase error Looks like at some point during reworking/rebasing the signature for Koha::Account::Line->apply changed and was then reverted but one case of the reversion got lost. The error was highlighted in the patrons_accounts credit api tests. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1/Patrons/Account.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 6 16:28:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 06 Mar 2020 15:28:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1038-gf1c93e88d4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f1c93e88d4d56bcef05929de70fc86115cbdc463 (commit) via 9c2a74a63861543d95c83b2f63a9dc2aeaafd965 (commit) via deb77ffe3d3d76c0863f287f1a6f3697c9fa6949 (commit) via a7de3ebf8b9e834bb00c2fe07464657f2e1d1b9b (commit) via 7da21c6a10f944a21c96d0ce9a9d4494a4ae1560 (commit) from 348a04e00f57e15dc3f1ef320c673961b47ca936 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f1c93e88d4d56bcef05929de70fc86115cbdc463 Author: Jonathan Druart Date: Tue Dec 17 10:45:11 2019 +0100 Bug 24219: Preserve sort order when returning to result list There is a mismatch between sort_cgi, sort and sort_by variables. * sort_cgi I did not find relevant occurrences of sort_cgi in the git log of both search.pl and results.tt. So it seems that it never worked correctly. * sort It is the JS variable use in browser.js * sort_by is the search.pl parameter to set the sort_by option Test plan: 1. Perform a search in the staff client 2. Change the sort order to something different (try Author A-Z) 3. Click on a result to view the record 4. Click on "Results" button on left side to return to result list => Without this patch the result list is sorted by relevancy => With this patch applied the Author A-Z is kept Signed-off-by: Michal Denar Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 9c2a74a63861543d95c83b2f63a9dc2aeaafd965 Author: Jonathan Druart Date: Tue Feb 18 16:13:11 2020 +0100 Bug 23384: Fix use statement order for ArticleRequest::Status Koha::ArticleRequest is used by Koha::ArticleRequests so Koha::ArticleRequest::Status should not be needed in Koha::ArticleRequest. Also Koha::ArticleRequest::Status must be loaded before Koha::ArticleRequest Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit deb77ffe3d3d76c0863f287f1a6f3697c9fa6949 Author: Marcel de Rooy Date: Fri Mar 6 11:13:15 2020 +0000 Bug 24760: (follow-up) Add a neighboring test messsage Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit a7de3ebf8b9e834bb00c2fe07464657f2e1d1b9b Author: Julian Maurice Date: Fri Feb 28 14:22:34 2020 +0100 Bug 24760: Use C4::BackgroundJob->fetch in tests Starting with YAML 1.30 and YAML::Syck 1.32, these modules don't bless loaded objects by default. This is not a problem as C4::BackgroundJob->fetch bless them anyway. So, instead of testing what's in the session, test the result of C4::BackgroundJob->fetch, which is what's used everywhere else Test plan: 1. Install latest version of YAML::Syck (or YAML if YAML::Syck is not installed) 2. prove t/db_dependent/BackgroundJob.t => should FAIL 3. Apply patch 4. prove t/db_dependent/BackgroundJob.t => should PASS 5. Verify that background jobs are still working (for instance, tools/batchMod.pl) Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 7da21c6a10f944a21c96d0ce9a9d4494a4ae1560 Author: David Gustafsson Date: Tue Mar 3 14:32:31 2020 +0100 Bug 24788: Remove autoloaded column accessors in Koha::Object->store Columns are accessed as methods, relying on AUTOLOAD, in Koha::Object->store. This could be a source of strange bugs if a column name clashes with an existing method name. To test: 1) Apply patches for Bug 14957 2) Follow the testing instructions, when saving a new marc rule and error is thrown. 3) Apply patch 4) Try saving a new rule once again, this should now work Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/ArticleRequest.pm | 1 - Koha/ArticleRequests.pm | 2 +- Koha/Object.pm | 14 ++++++++------ Koha/Patron.pm | 1 + koha-tmpl/intranet-tmpl/js/browser.js | 6 +++--- .../intranet-tmpl/prog/en/modules/catalogue/results.tt | 1 + koha-tmpl/intranet-tmpl/prog/js/pages/results.js | 6 +++--- t/db_dependent/BackgroundJob.t | 12 +++++------- 8 files changed, 22 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 6 16:31:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 06 Mar 2020 15:31:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1039-gb952563a3b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b952563a3bdb8581a066bcff51b274d1ce614f5f (commit) from f1c93e88d4d56bcef05929de70fc86115cbdc463 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b952563a3bdb8581a066bcff51b274d1ce614f5f Author: Martin Renvoize Date: Tue Nov 19 14:03:37 2019 +0000 Bug 24066: Add missing POD for has_permission To test: 1) do perldoc Koha/Patron.pm search has_permission Signed-off-by: Bernardo Gonzalez Kriegel Fixed (removed) space before 'my $permission' to make it similar to other entries. No errors Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Patron.pm | 8 ++++++++ 1 file changed, 8 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 12:06:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 11:06:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1041-g0706922221 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0706922221dcdf9fa8ed7fcf86245c5622f33a3c (commit) via 79f2230c5dbb867f56f278883c8d527c9944c236 (commit) from b952563a3bdb8581a066bcff51b274d1ce614f5f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0706922221dcdf9fa8ed7fcf86245c5622f33a3c Author: Martin Renvoize Date: Fri Mar 6 14:47:00 2020 +0000 Bug 24817: Replace sleep calls with date setting in test data Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 79f2230c5dbb867f56f278883c8d527c9944c236 Author: Martin Renvoize Date: Fri Mar 6 08:25:39 2020 +0000 Bug 24817: Add sleep between db create actions We need to allow some time to pass between calls that add cash register lines to accountlines or cash_register_actions. We use database level triggers to maintain the timestamp fields, so cannot use Time::Fake, and the methods we are testing assume that, as human interactions, there will be at least a second between the last 'sale' on a cash register and the 'cashup' of that same cash register. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Cash/Register.pm | 2 +- t/db_dependent/Koha/Cash/Register.t | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 15:38:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 14:38:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1073-g83da3af9da Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 83da3af9dad6591516cf2bd297e7353952596435 (commit) via 5ead9529da75ca5fdd26e7411c5b3ee3487d0e1c (commit) via d9b83c12c601ae43bcf67125e351c098b4fe1efa (commit) via 0f020eabbdb0d1cd358c396959049bc11631ebf2 (commit) via ff39a08302f48dd127cc835686f0eef01897dc47 (commit) via 2c8f894b96dd2e340d3aa8562ba9914ccbfb1d4f (commit) via 95884c204c5bfd8f97bf0580dbf40a3e12d15f8b (commit) via 29411e38ee4c9122d8d9dffab1e13bcecc62f66c (commit) via 08b65033d0617327645bd4ddc902eed851ff0f8e (commit) via e3ed060fb02528032787b56d5637f336be6bac0f (commit) via 89ced6c9a01a5751446af3ab7cb32b64a51a07f8 (commit) via c5ac1d23f2720b975ab8bce0c798f5642d7747c3 (commit) via e49f3ce3ab59b8e28697cdce3d7bc9eb204185d7 (commit) via 77964c9e123a7f7ffb9acc151010ec7ff12e7308 (commit) via 6f90d1f3bd3b73f28c21a510c90a75e69c24b389 (commit) via a57754825f4a2d3d1ade770ef2d40c7e7ef5ffd5 (commit) via 3af76ad5c473c15e6aa8f7da0fbd6a891112da29 (commit) via 1c1693ddccf92573510782fff19ca0fd9c6ada09 (commit) via e848d36412f60e2553301f6d6c9032140744f627 (commit) via 77b0151c9d2f532421ee7c906b94d1c4fa26bd17 (commit) via 8ad61cb07abd8a192abe29580cf368ab3cee9e44 (commit) via e2fceec873300a4df70e332bf25ae32c22dc5253 (commit) via 01efbbf8c6cf6b42c2fbcff5eb704b2d63468d76 (commit) via 23b9c058ce36f559f646121a568b2d5c165aff88 (commit) via dd287a7b7f64b0ce952fcb9b14fbe8cec130ad11 (commit) via c56e8b58d972bb2e77394e1b9b9da885290a2288 (commit) via 31774a2ee8583f49bc204ce75e8a25030fcab0ac (commit) via 33c1ddf86b198677cca49e56b8b566288e01ec1f (commit) via e925eb7a145bd6e206d6770ce7c73dbc32d1decd (commit) via 131183b0bfcb909be44fc64a0e78b30f97135f9b (commit) via fc861f1ed93b44b5d0068f247894a77da0931c75 (commit) via 3edee6db6fa7f5e3c673dfa890e032f90ff234ed (commit) from 0706922221dcdf9fa8ed7fcf86245c5622f33a3c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 83da3af9dad6591516cf2bd297e7353952596435 Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 11:53:04 2020 -0300 Bug 24594: Rewrite marc21_framework_DEFAULT to YAML YAML version of marc21 mandatory marc21_framework_DEFAULT. To test: 1) Do a clean install with mandatory data, dump table marc_tag_structure and marc_subfield_structure, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler-MARC21.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files NOTE: This patch fails with qa tools! Reason is that qa tools use YAML.pm module to check files, but Installer.pm or LangInstaller.pm are using YAML::Syck, using that module gives no error, check for example: perl -e 'use YAML::Syck qw( LoadFile ); $y = LoadFile("marc21_framework_DEFAULT.yml");' No error! perl -e 'use YAML qw( LoadFile ); $y = LoadFile("marc21_framework_DEFAULT.yml");' Error! Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5ead9529da75ca5fdd26e7411c5b3ee3487d0e1c Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 11:55:45 2020 -0300 Bug 24594: Rewrite authorities_normal_marc21 to YAML YAML version of marc21 mandatory authorities_normal_marc21. To test: 1) Do a clean install with mandatory data, dump table auth_types, auth_tag_structure and auth_subfield_structure, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler-MARC21.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files NOTE: This patch fails with qa tools! Reason is that qa tools use YAML.pm module to check files, but Installer.pm or LangInstaller.pm are using YAML::Syck, using that module gives no error, check for example: perl -e 'use YAML::Syck qw( LoadFile ); $y = LoadFile("authorities_normal_marc21.yml");' No error! perl -e 'use YAML qw( LoadFile ); $y = LoadFile("authorities_normal_marc21.yml");' Error! Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit d9b83c12c601ae43bcf67125e351c098b4fe1efa Author: Bernardo Gonzalez Kriegel Date: Wed Mar 4 11:31:29 2020 -0300 Bug 24593: (follow-up) fix sql statements Original inserted values depends on the order of insertion. This patch rewrites the sql statements to make them order independent Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0f020eabbdb0d1cd358c396959049bc11631ebf2 Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 11:12:27 2020 -0300 Bug 24593: Rewrite marc21_simple_bib_frameworks to YAML YAML version of marc21_simple_bib_frameworks To test: 1) Same test plan of first patch NOTE: Same problem as first patch with qa tools Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ff39a08302f48dd127cc835686f0eef01897dc47 Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 11:08:37 2020 -0300 Bug 24593: Rewrite marc21_sample_fastadd_framework to YAML YAML version of marc21_sample_fastadd_framework To test: 1) Same test plan of first patch NOTE: Same problem as first patch with qa tools Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2c8f894b96dd2e340d3aa8562ba9914ccbfb1d4f Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 10:11:16 2020 -0300 Bug 24593: Rewrite marc21_default_matching_rules to YAML YAML version of marc21 optional marc21_default_matching_rules. To test: 1) Do a clean install with optional data, dump table marc_matchers, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler-MARC21.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files NOTE: This patch fails with qa tools! Reason is that qa tools use YAML.pm module to check files, but Installer.pm or LangInstaller.pm are using YAML::Syck, using that module gives no error, check for example: perl -e 'use YAML::Syck qw( LoadFile ); $y = LoadFile("marc21_default_matching_rules.yml");' No error! perl -e 'use YAML qw( LoadFile ); $y = LoadFile("marc21_default_matching_rules.yml");' Error! Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 95884c204c5bfd8f97bf0580dbf40a3e12d15f8b Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 09:53:12 2020 -0300 Bug 24584: Rewrite optional/sample_z3950_servers to YAML YAML version of optional sample_z3950_servers To test: 1) Same test plan of first patch, only check table z3950servers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 29411e38ee4c9122d8d9dffab1e13bcecc62f66c Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 09:51:16 2020 -0300 Bug 24584: Rewrite optional/sample_quotes to YAML YAML version of optional sample_quotes To test: 1) Same test plan of first patch, only check table quotes Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 08b65033d0617327645bd4ddc902eed851ff0f8e Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 09:49:14 2020 -0300 Bug 24584: Rewrite optional/sample_patrons to YAML YAML version of optional sample_patrons To test: 1) Same test plan of first patch, only check table borrowers Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e3ed060fb02528032787b56d5637f336be6bac0f Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 09:46:28 2020 -0300 Bug 24584: Rewrite optional/sample_news to YAML YAML version of optional sample_news To test: 1) Same test plan of first patch, only check table opac_news Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 89ced6c9a01a5751446af3ab7cb32b64a51a07f8 Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 09:44:28 2020 -0300 Bug 24584: Rewrite optional/sample_libraries_holidays to YAML YAML version of optional sample_libraries_holidays To test: 1) Same test plan of first patch, only check table repeatable_holidays Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c5ac1d23f2720b975ab8bce0c798f5642d7747c3 Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 09:42:17 2020 -0300 Bug 24584: Rewrite optional/sample_libraries to YAML YAML version of optional sample_libraries To test: 1) Same test plan of first patch, only check table branches Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e49f3ce3ab59b8e28697cdce3d7bc9eb204185d7 Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 09:39:52 2020 -0300 Bug 24584: Rewrite optional/sample_itemtypes to YAML YAML version of optional sample_itemtypes To test: 1) Same test plan of first patch, only check table itemtypes Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 77964c9e123a7f7ffb9acc151010ec7ff12e7308 Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 09:35:53 2020 -0300 Bug 24584: Rewrite optional/sample_creator_data to YAML YAML version of optional sample_creator_data To test: 1) Same test plan of first patch, only check tables creator_layouts, creator_templates and printers_profile Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6f90d1f3bd3b73f28c21a510c90a75e69c24b389 Author: Bernardo Gonzalez Kriegel Date: Wed Feb 5 09:32:10 2020 -0300 Bug 24584: Rewrite optional/patron_categories to YAML YAML version of optional patron_categories To test: 1) Same test plan of first patch, only check table categories Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit a57754825f4a2d3d1ade770ef2d40c7e7ef5ffd5 Author: Bernardo Gonzalez Kriegel Date: Tue Feb 4 21:27:01 2020 -0300 Bug 24584: Rewrite optional/patron_atributes to YAML YAML version of optional patron_atributes To test: 1) Same test plan of first patch, only check table borrower_attribute_types Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 3af76ad5c473c15e6aa8f7da0fbd6a891112da29 Author: Bernardo Gonzalez Kriegel Date: Tue Feb 4 21:01:27 2020 -0300 Bug 24584: Rewrite optional/parameters to YAML YAML version of optional parameters To test: 1) Same test plan of first patch, only check table currency Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 1c1693ddccf92573510782fff19ca0fd9c6ada09 Author: Bernardo Gonzalez Kriegel Date: Tue Feb 4 21:17:00 2020 -0300 Bug 24584: Rewrite optional/marc21_relatorterms to YAML YAML version of optional marc21_relatorterms To test: 1) Same test plan of first patch, only check table authorised_values Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e848d36412f60e2553301f6d6c9032140744f627 Author: Bernardo Gonzalez Kriegel Date: Tue Feb 4 21:07:44 2020 -0300 Bug 24584: Rewrite optional/marc21_holdings_coded_values to YAML YAML version of optional marc21_holdings_coded_values To test: 1) Same test plan of first patch, only check table authorised_values Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 77b0151c9d2f532421ee7c906b94d1c4fa26bd17 Author: Bernardo Gonzalez Kriegel Date: Tue Feb 4 20:56:30 2020 -0300 Bug 24584: Rewrite optional/csv_profiles to YAML YAML version of optional csv_profiles. To test: 1) Do a clean install with optional data, dump table export_format, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8ad61cb07abd8a192abe29580cf368ab3cee9e44 Author: Bernardo Gonzalez Kriegel Date: Thu Mar 5 10:21:55 2020 -0300 Bug 24583: (follow-up) restore null values to labels This patch adds null values to selected label2/3 in sample numberpatterns Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e2fceec873300a4df70e332bf25ae32c22dc5253 Author: Bernardo Gonzalez Kriegel Date: Tue Feb 4 20:34:54 2020 -0300 Bug 24583: Rewrite mandatory/sample_numberpatterns to YAML YAML version of mandatory sample_numberpatterns To test: 1) Same test plan of first patch, only check table subscription_numberpatterns Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 01efbbf8c6cf6b42c2fbcff5eb704b2d63468d76 Author: Bernardo Gonzalez Kriegel Date: Tue Feb 4 20:07:43 2020 -0300 Bug 24583: Rewrite mandatory/sample_notices to YAML YAML version of mandatory sample_notices To test: 1) Same test plan of first patch, only check table letter Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 23b9c058ce36f559f646121a568b2d5c165aff88 Author: Bernardo Gonzalez Kriegel Date: Tue Feb 4 20:05:31 2020 -0300 Bug 24583: Rewrite mandatory/sample_frequencies to YAML YAML version of mandatory sample_frequencies To test: 1) Same test plan of first patch, only check table subscription_frequencies Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit dd287a7b7f64b0ce952fcb9b14fbe8cec130ad11 Author: Bernardo Gonzalez Kriegel Date: Tue Feb 4 19:58:09 2020 -0300 Bug 24583: Rewrite mandatory/class_sources to YAML YAML version of mandatory class_sources To test: 1) Same test plan of first patch, only check tables class_sort_rules, class_split_rules and class_sources Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c56e8b58d972bb2e77394e1b9b9da885290a2288 Author: Bernardo Gonzalez Kriegel Date: Tue Feb 4 19:45:07 2020 -0300 Bug 24583: Rewrite mandatory/auth_values to YAML YAML version of mandatory auth_values. To test: 1) Do a clean install, dump auth_values, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 31774a2ee8583f49bc204ce75e8a25030fcab0ac Author: Bernardo Gonzalez Kriegel Date: Thu Mar 5 10:23:53 2020 -0300 Bug 24262: (follow-up) admit null values on labels This patch adds handling of null values on translatable labels. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 33c1ddf86b198677cca49e56b8b566288e01ec1f Author: Bernardo Gonzalez Kriegel Date: Fri Dec 20 10:53:11 2019 -0300 Bug 24262: Translate installer data in YAML format This patch adds the ability to: 1) Create new translation files from yaml installer files 2) Create installer directory for a given language It will not create a installer directory if it already exists. New (possible) translation files: xx-YY-installer.po xx-YY-installer-MARC21.po xx-YY-installer-UNIMARC.po Needs Bug 13897 (for yaml files) NOTE: updated version adding ability to process multiline fields, discard small ( < 2) strings, and discard strings with pure html, TT or punctuation. To test: 1) Apply patches from Bug 13897 2) Apply this patch 3) Go to misc/translation 4) Create translation files for a NEW language $ ./translate create xx-YY check new file 'xx-YY-installer.po' 5) Copy ../../installer/data/mysql/en/optional/auth_val.yml into ../../installer/data/mysql/en/marcflavour/marc21/mandatory/ and ../../installer/data/mysql/en/marcflavour/unimarc/mandatory/ remove po/xx-YY*, then repeat creation check new files 'xx-YY-installer.po', 'xx-YY-installer-MARC21.po' and 'xx-YY-installer-UNIMARC.po' remove all new files 6) Create for xx-YY again and try update $ ./translate create xx-YY edit ../../installer/data/mysql/en/optional/auth_val.yml and change one char in one of the translatable values, also edit 'xx-YY-installer.po', translate the same string (in msgstr). Do an update $ ./translate update xx-YY check in 'xx-YY-installer.po' a fuzzy value for the translated value and the preservation of the translation Fix the translation, or add a new one. 7) Create an install dir for xx-YY ./translate install xx-YY Check new dir '../../installer/data/mysql/xx-YY/' Check files on it $ tree ../../installer/data/mysql/xx-YY/ and compare with ../../installer/data/mysql/en/ All installation files must be present 8) Try a new Koha install using this language in the usual way. Check in authorised_values table for the translated string. 9) Try create an install dir for an existing language (eg. es-ES, de-DE or fr-FR ), eg. ./translate install de-DE Install dir is detected and not changed, a note is printed. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e925eb7a145bd6e206d6770ce7c73dbc32d1decd Author: Jonathan Druart Date: Wed Feb 12 11:27:39 2020 +0100 Bug 13897: Surround columns with backticks We have some column's names that need to be surrounded by ` as they are protected keywords ('rows' for instance) Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 131183b0bfcb909be44fc64a0e78b30f97135f9b Author: Bernardo Gonzalez Kriegel Date: Thu Jan 30 11:30:30 2020 -0300 Bug 13897: Process description, multiline values and SQL statements in YAML files This patch adds 3 features: 1) Display description of YAML files at install time for frameworks, and fixes it's encoding. 2) Enable use of multiline values, field required 3) Process SQL statements declared in YAML files With this features we can process files with the following generic YAML strucure: --- description: - "File description" tables: - table_name: translatable: [ title, content ] multiline: [ content ] rows: - title: "Example title" content: - "Content:" - "" - "This is the content." id: 1 value: ~ sql_statements: - "UPDATE table_name SET value ='empty' WHERE value IS NULL" ... * file description is now inside the YAML, can have multiple lines. This attribute is expected in all YAML files. * translatable attribute in table declare fields that can be translated * multiline attribute in table declare fields that can have multiple lines of content, they are joined using '\r\n' before insert into database. This is useful to express fields like 'news' content, and to simplify it's translation. '\r\n' is used for correct display in Windows clients. * sql_statements allows to add multiple SQL sentences, not insertions normally, that are executed in order. This features are not needed for the example file of this patch, but will be used in new bugs. To test: 1) Use the same test plan of first patch. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit fc861f1ed93b44b5d0068f247894a77da0931c75 Author: Jonathan Druart Date: Wed Dec 18 09:27:59 2019 +0100 Bug 13897: Catch the error and warn it Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 3edee6db6fa7f5e3c673dfa890e032f90ff234ed Author: Bernardo Gonzalez Kriegel Date: Thu Nov 28 19:06:35 2019 -0300 Bug 13897: Use YAML files for installer data This patch modifies C4/Installer.pm to add support for loading YAML files into database. As an example of the functionality, optional auth_val.sql file is replaced by auth_val.yml The rationale behind this feature is to enable the translation of the data that is loaded into the database. That will be addressed in another bug. But taking into account that goal, translatable values are declared in the YAML files, to ease identification by translate script. Also file description is moved into the yaml file. To test: 0) Do a clean install with all optional data, then dump authorised_values table, reserve. 1) Apply the patch 2) Do a clean install in English (marc21/unimarc) 3) On optional data check for description of auth_val "Some basic default authorised values for ..." 4) Select all optional data 5) Finish installation 6) Dump again authorised_values table and compare with that of point '0'. No differences should be found. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Installer.pm | 83 +- installer/data/mysql/en/mandatory/auth_values.sql | 6 - installer/data/mysql/en/mandatory/auth_values.txt | 1 - installer/data/mysql/en/mandatory/auth_values.yml | 60 + .../data/mysql/en/mandatory/class_sources.sql | 41 - .../data/mysql/en/mandatory/class_sources.txt | 1 - .../data/mysql/en/mandatory/class_sources.yml | 98 + .../data/mysql/en/mandatory/sample_frequencies.sql | 16 - .../data/mysql/en/mandatory/sample_frequencies.txt | 1 - .../data/mysql/en/mandatory/sample_frequencies.yml | 105 + .../data/mysql/en/mandatory/sample_notices.sql | 384 - .../data/mysql/en/mandatory/sample_notices.txt | 1 - .../data/mysql/en/mandatory/sample_notices.yml | 1148 + .../mysql/en/mandatory/sample_numberpatterns.sql | 25 - .../mysql/en/mandatory/sample_numberpatterns.txt | 1 - .../mysql/en/mandatory/sample_numberpatterns.yml | 119 + .../marc21/mandatory/authorities_normal_marc21.sql | 2389 - .../marc21/mandatory/authorities_normal_marc21.txt | 11 - .../marc21/mandatory/authorities_normal_marc21.yml | 32953 ++++++++ .../marc21/mandatory/marc21_framework_DEFAULT.sql | 4681 -- .../marc21/mandatory/marc21_framework_DEFAULT.txt | 1 - .../marc21/mandatory/marc21_framework_DEFAULT.yml | 78107 +++++++++++++++++++ .../optional/marc21_default_matching_rules.sql | 46 - .../optional/marc21_default_matching_rules.txt | 5 - .../optional/marc21_default_matching_rules.yml | 70 + .../optional/marc21_sample_fastadd_framework.sql | 88 - .../optional/marc21_sample_fastadd_framework.txt | 1 - .../optional/marc21_sample_fastadd_framework.yml | 117 + .../optional/marc21_simple_bib_frameworks.sql | 494 - .../optional/marc21_simple_bib_frameworks.txt | 10 - .../optional/marc21_simple_bib_frameworks.yml | 502 + installer/data/mysql/en/optional/auth_val.sql | 86 - installer/data/mysql/en/optional/auth_val.txt | 1 - installer/data/mysql/en/optional/auth_val.yml | 294 + installer/data/mysql/en/optional/csv_profiles.sql | 2 - installer/data/mysql/en/optional/csv_profiles.txt | 3 - installer/data/mysql/en/optional/csv_profiles.yml | 36 + .../en/optional/marc21_holdings_coded_values.sql | 146 - .../en/optional/marc21_holdings_coded_values.txt | 2 - .../en/optional/marc21_holdings_coded_values.yml | 509 + .../data/mysql/en/optional/marc21_relatorterms.sql | 226 - .../data/mysql/en/optional/marc21_relatorterms.txt | 1 - .../data/mysql/en/optional/marc21_relatorterms.yml | 919 + installer/data/mysql/en/optional/parameters.sql | 5 - installer/data/mysql/en/optional/parameters.txt | 1 - installer/data/mysql/en/optional/parameters.yml | 47 + .../data/mysql/en/optional/patron_atributes.sql | 2 - .../data/mysql/en/optional/patron_atributes.txt | 2 - .../data/mysql/en/optional/patron_atributes.yml | 36 + .../data/mysql/en/optional/patron_categories.sql | 23 - .../data/mysql/en/optional/patron_categories.txt | 21 - .../data/mysql/en/optional/patron_categories.yml | 209 + .../data/mysql/en/optional/sample_creator_data.sql | 34 - .../data/mysql/en/optional/sample_creator_data.txt | 1 - .../data/mysql/en/optional/sample_creator_data.yml | 259 + .../data/mysql/en/optional/sample_itemtypes.sql | 9 - .../data/mysql/en/optional/sample_itemtypes.txt | 1 - .../data/mysql/en/optional/sample_itemtypes.yml | 83 + .../data/mysql/en/optional/sample_libraries.sql | 16 - .../data/mysql/en/optional/sample_libraries.txt | 1 - .../data/mysql/en/optional/sample_libraries.yml | 75 + .../en/optional/sample_libraries_holidays.sql | 4 - .../en/optional/sample_libraries_holidays.txt | 1 - .../en/optional/sample_libraries_holidays.yml | 51 + installer/data/mysql/en/optional/sample_news.sql | 2 - installer/data/mysql/en/optional/sample_news.txt | 1 - installer/data/mysql/en/optional/sample_news.yml | 52 + .../data/mysql/en/optional/sample_patrons.sql | 51 - .../data/mysql/en/optional/sample_patrons.txt | 1 - .../data/mysql/en/optional/sample_patrons.yml | 2427 + installer/data/mysql/en/optional/sample_quotes.sql | 34 - installer/data/mysql/en/optional/sample_quotes.txt | 1 - installer/data/mysql/en/optional/sample_quotes.yml | 154 + .../mysql/en/optional/sample_z3950_servers.sql | 11 - .../mysql/en/optional/sample_z3950_servers.txt | 5 - .../mysql/en/optional/sample_z3950_servers.yml | 82 + misc/translator/LangInstaller.pm | 291 +- 77 files changed, 118859 insertions(+), 8924 deletions(-) delete mode 100644 installer/data/mysql/en/mandatory/auth_values.sql delete mode 100644 installer/data/mysql/en/mandatory/auth_values.txt create mode 100644 installer/data/mysql/en/mandatory/auth_values.yml delete mode 100644 installer/data/mysql/en/mandatory/class_sources.sql delete mode 100644 installer/data/mysql/en/mandatory/class_sources.txt create mode 100644 installer/data/mysql/en/mandatory/class_sources.yml delete mode 100644 installer/data/mysql/en/mandatory/sample_frequencies.sql delete mode 100644 installer/data/mysql/en/mandatory/sample_frequencies.txt create mode 100644 installer/data/mysql/en/mandatory/sample_frequencies.yml delete mode 100644 installer/data/mysql/en/mandatory/sample_notices.sql delete mode 100644 installer/data/mysql/en/mandatory/sample_notices.txt create mode 100644 installer/data/mysql/en/mandatory/sample_notices.yml delete mode 100644 installer/data/mysql/en/mandatory/sample_numberpatterns.sql delete mode 100644 installer/data/mysql/en/mandatory/sample_numberpatterns.txt create mode 100644 installer/data/mysql/en/mandatory/sample_numberpatterns.yml delete mode 100644 installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql delete mode 100644 installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.txt create mode 100644 installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.yml delete mode 100644 installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql delete mode 100644 installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.txt create mode 100644 installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml delete mode 100644 installer/data/mysql/en/marcflavour/marc21/optional/marc21_default_matching_rules.sql delete mode 100644 installer/data/mysql/en/marcflavour/marc21/optional/marc21_default_matching_rules.txt create mode 100644 installer/data/mysql/en/marcflavour/marc21/optional/marc21_default_matching_rules.yml delete mode 100644 installer/data/mysql/en/marcflavour/marc21/optional/marc21_sample_fastadd_framework.sql delete mode 100644 installer/data/mysql/en/marcflavour/marc21/optional/marc21_sample_fastadd_framework.txt create mode 100644 installer/data/mysql/en/marcflavour/marc21/optional/marc21_sample_fastadd_framework.yml delete mode 100644 installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql delete mode 100644 installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.txt create mode 100644 installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.yml delete mode 100644 installer/data/mysql/en/optional/auth_val.sql delete mode 100644 installer/data/mysql/en/optional/auth_val.txt create mode 100644 installer/data/mysql/en/optional/auth_val.yml delete mode 100644 installer/data/mysql/en/optional/csv_profiles.sql delete mode 100644 installer/data/mysql/en/optional/csv_profiles.txt create mode 100644 installer/data/mysql/en/optional/csv_profiles.yml delete mode 100644 installer/data/mysql/en/optional/marc21_holdings_coded_values.sql delete mode 100644 installer/data/mysql/en/optional/marc21_holdings_coded_values.txt create mode 100644 installer/data/mysql/en/optional/marc21_holdings_coded_values.yml delete mode 100644 installer/data/mysql/en/optional/marc21_relatorterms.sql delete mode 100644 installer/data/mysql/en/optional/marc21_relatorterms.txt create mode 100644 installer/data/mysql/en/optional/marc21_relatorterms.yml delete mode 100644 installer/data/mysql/en/optional/parameters.sql delete mode 100644 installer/data/mysql/en/optional/parameters.txt create mode 100644 installer/data/mysql/en/optional/parameters.yml delete mode 100644 installer/data/mysql/en/optional/patron_atributes.sql delete mode 100644 installer/data/mysql/en/optional/patron_atributes.txt create mode 100644 installer/data/mysql/en/optional/patron_atributes.yml delete mode 100644 installer/data/mysql/en/optional/patron_categories.sql delete mode 100644 installer/data/mysql/en/optional/patron_categories.txt create mode 100644 installer/data/mysql/en/optional/patron_categories.yml delete mode 100644 installer/data/mysql/en/optional/sample_creator_data.sql delete mode 100644 installer/data/mysql/en/optional/sample_creator_data.txt create mode 100644 installer/data/mysql/en/optional/sample_creator_data.yml delete mode 100644 installer/data/mysql/en/optional/sample_itemtypes.sql delete mode 100644 installer/data/mysql/en/optional/sample_itemtypes.txt create mode 100644 installer/data/mysql/en/optional/sample_itemtypes.yml delete mode 100644 installer/data/mysql/en/optional/sample_libraries.sql delete mode 100644 installer/data/mysql/en/optional/sample_libraries.txt create mode 100644 installer/data/mysql/en/optional/sample_libraries.yml delete mode 100644 installer/data/mysql/en/optional/sample_libraries_holidays.sql delete mode 100644 installer/data/mysql/en/optional/sample_libraries_holidays.txt create mode 100644 installer/data/mysql/en/optional/sample_libraries_holidays.yml delete mode 100644 installer/data/mysql/en/optional/sample_news.sql delete mode 100644 installer/data/mysql/en/optional/sample_news.txt create mode 100644 installer/data/mysql/en/optional/sample_news.yml delete mode 100644 installer/data/mysql/en/optional/sample_patrons.sql delete mode 100644 installer/data/mysql/en/optional/sample_patrons.txt create mode 100644 installer/data/mysql/en/optional/sample_patrons.yml delete mode 100644 installer/data/mysql/en/optional/sample_quotes.sql delete mode 100644 installer/data/mysql/en/optional/sample_quotes.txt create mode 100644 installer/data/mysql/en/optional/sample_quotes.yml delete mode 100644 installer/data/mysql/en/optional/sample_z3950_servers.sql delete mode 100644 installer/data/mysql/en/optional/sample_z3950_servers.txt create mode 100644 installer/data/mysql/en/optional/sample_z3950_servers.yml hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 16:45:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 15:45:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1076-g7b25bb7644 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7b25bb76444afb06d3459423ca65314e2145c8a9 (commit) via 4c7f72e4ed0f61053d3344d11ab844cd901697fc (commit) via 61a2c4db6adfa18ccd3b403cf7ccb12a0df9efd7 (commit) from 83da3af9dad6591516cf2bd297e7353952596435 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7b25bb76444afb06d3459423ca65314e2145c8a9 Author: Jonathan Druart Date: Mon Mar 9 16:14:58 2020 +0100 Bug 24583: adjust xt/sample_notices.t Signed-off-by: Martin Renvoize commit 4c7f72e4ed0f61053d3344d11ab844cd901697fc Author: Jonathan Druart Date: Mon Mar 9 16:09:50 2020 +0100 Bug 24594: Fix license statements Signed-off-by: Martin Renvoize commit 61a2c4db6adfa18ccd3b403cf7ccb12a0df9efd7 Author: Jonathan Druart Date: Mon Mar 9 15:59:41 2020 +0100 Bug 24545: Cannot return outside of sub We must die instead Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/en/mandatory/auth_values.yml | 21 ++++++++++---------- .../data/mysql/en/mandatory/class_sources.yml | 21 ++++++++++---------- .../data/mysql/en/mandatory/sample_frequencies.yml | 21 ++++++++++---------- .../data/mysql/en/mandatory/sample_notices.yml | 21 ++++++++++---------- .../mysql/en/mandatory/sample_numberpatterns.yml | 21 ++++++++++---------- .../marc21/mandatory/authorities_normal_marc21.yml | 23 +++++++++++----------- .../marc21/mandatory/marc21_framework_DEFAULT.yml | 23 +++++++++++----------- .../optional/marc21_default_matching_rules.yml | 21 ++++++++++---------- .../optional/marc21_sample_fastadd_framework.yml | 21 ++++++++++---------- .../optional/marc21_simple_bib_frameworks.yml | 21 ++++++++++---------- installer/data/mysql/en/optional/auth_val.yml | 21 ++++++++++---------- installer/data/mysql/en/optional/csv_profiles.yml | 21 ++++++++++---------- .../en/optional/marc21_holdings_coded_values.yml | 21 ++++++++++---------- .../data/mysql/en/optional/marc21_relatorterms.yml | 21 ++++++++++---------- installer/data/mysql/en/optional/parameters.yml | 21 ++++++++++---------- .../data/mysql/en/optional/patron_atributes.yml | 21 ++++++++++---------- .../data/mysql/en/optional/patron_categories.yml | 21 ++++++++++---------- .../data/mysql/en/optional/sample_creator_data.yml | 21 ++++++++++---------- .../data/mysql/en/optional/sample_itemtypes.yml | 21 ++++++++++---------- .../data/mysql/en/optional/sample_libraries.yml | 21 ++++++++++---------- .../en/optional/sample_libraries_holidays.yml | 21 ++++++++++---------- installer/data/mysql/en/optional/sample_news.yml | 21 ++++++++++---------- .../data/mysql/en/optional/sample_patrons.yml | 21 ++++++++++---------- installer/data/mysql/en/optional/sample_quotes.yml | 23 +++++++++++----------- .../mysql/en/optional/sample_z3950_servers.yml | 21 ++++++++++---------- xt/find-license-problems.t | 2 +- xt/sample_notices.t | 18 +++++++++++++---- 27 files changed, 273 insertions(+), 278 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 18:44:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 17:44:20 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-2-g649c0b2df7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 649c0b2df7e288488fe016408f90440041ff59fb (commit) from 444a9b435d5ac571ff4147382594369f20bee479 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 649c0b2df7e288488fe016408f90440041ff59fb Author: Jonathan Druart Date: Wed Feb 5 10:36:14 2020 +0100 Bug 24590: Fix Koha/Object.t on MySQL 8 % prove t/db_dependent/Koha/Object.t is failing on MySQL 8 with: kohadev-koha at 9bbf9ac68519:/kohadevbox/koha$ prove t/db_dependent/Koha/Object.t t/db_dependent/Koha/Object.t .. 15/18 # Failed test 'Exception field is correct' # at t/db_dependent/Koha/Object.t line 650. # got: 'api_keys.secret' # expected: 'secret' # Looks like you failed 1 test of 16. t/db_dependent/Koha/Object.t .. 16/18 # Failed test 'store() tests' # at t/db_dependent/Koha/Object.t line 723. MySQL 8 displays the tablename in the error. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d5cd348c27b0c0d18474d11a8b78d1e2468f9a7a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Object.t | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 18:47:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 17:47:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-3-g1252f3986b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1252f3986b47d671a4d069c7ffe01827e820ee72 (commit) from 649c0b2df7e288488fe016408f90440041ff59fb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1252f3986b47d671a4d069c7ffe01827e820ee72 Author: Nick Clemens Date: Fri Jan 17 14:29:42 2020 +0000 Bug 24449: Add too_many_overdue to patron status for SIP To test: 1 - Have sip running and use the cli to get info for a patron example: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su koha -sp koha -l CPL -m patron_status_request --patron koha 2 - Checkout an item to the patron, backdated so it is overdue 3 - Set syspref 'OverduesBlockCirc' to anything but "Don't Block" 4 - Get the patron status via SIP, note circ blocked flag is set, but too_many_overdue is not 5 - Apply patch 6 - Restart all the things 7 - Get the patron status via SIP 8 - Note the too_many_overdue flag is now triggered and there is a message example: READ: 24Y Y 00120200117 142716AEEdna Acosta|AA23529001000463|BLY|CQN|BV0.25|AFGreetings from Koha. -- Patron has overdues -- Patron owes 0.25|AOCPL| Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit cb59d155aede69111bfd9d4d013ae027ebf51ae3) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Patron.pm | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 19:14:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 18:14:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-6-g002f431bd4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 002f431bd4c6c7883ca5c4527dfd97ee6d136db7 (commit) via 44d9ad6491a241f80b31e0647453ad0908ad4cdb (commit) via c094c0dfdd19e9e1d68801a2d718e1ccf3060b5b (commit) from 1252f3986b47d671a4d069c7ffe01827e820ee72 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 002f431bd4c6c7883ca5c4527dfd97ee6d136db7 Author: Josef Moravec Date: Wed Feb 5 21:13:22 2020 +0000 Bug 13420: (QA follow-up): Fix typo itemdate -> itemdata Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 724f090717eac58750bfd856c925dcc431705832) Signed-off-by: Lucas Gass commit 44d9ad6491a241f80b31e0647453ad0908ad4cdb Author: Jonathan Druart Date: Tue Aug 6 08:56:44 2019 -0500 Bug 13420: Fallback to the previous behavior if published date is not used Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 34083b5ddeac98566b389269fc0e082eb1603414) Signed-off-by: Lucas Gass commit c094c0dfdd19e9e1d68801a2d718e1ccf3060b5b Author: Jonathan Druart Date: Sun Apr 28 22:53:55 2019 -0400 Bug 13420: Sort "Serial enumeration" by published date So far the sorting on volume information is incorrect. It sorts by the string displayed in the cell, which may not have any logics. A better solution would be to use Kyle's suggestion, see comments 7, 8, but it will need much more work. This patch suggests to use the publication date to sort this column. Note: In the code there is a switch depending on the existence of items.publisheddate, but I do not think it is valid, this valid should always exist if the item is received (did I miss something?) Test plan: You need to have different existing subscription, using different numbering. On the detail page of the bibliographic record you should be able to sort the serials (tab "Holdings") by "Serial enumeration". The sort will now use the publication dates. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d9485314eb86c8c5a466aba57c54680f053c79c3) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: catalogue/detail.pl | 3 ++- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 10 +++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 19:25:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 18:25:06 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-7-g9ee605ea9f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 9ee605ea9f920cff02f39083d8fa3d6ea59064a4 (commit) from 002f431bd4c6c7883ca5c4527dfd97ee6d136db7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9ee605ea9f920cff02f39083d8fa3d6ea59064a4 Author: Jonathan Druart Date: Thu Nov 14 10:50:24 2019 +0100 Bug 23640: Flushing L1 on every SIP connection This patch flushes the L1 cache on each SIP connection (ie every invocation of process_request). This means each SIP connection will fetch values from the L2 cache (ie memcached) and persist the L1 cache (in Perl memory cache) only until a new SIP connection comes in. Without this patch, the L1 cache persists for the length of the server process, which means the L1 cache will become stale very quickly, which can lead to unexpected behaviour. Test plan: 1. Enable IssueLog 2. Start SIP server 2a. change to Koha git directory 2b. koha-shell kohadev 2c. perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 3. Issue book via SIP perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout 4. Check action_logs for "CIRCULATION ISSUE " line http://localhost:8081/cgi-bin/koha/tools/viewlog.pl 5. Disable IssueLog 6. Check in the book and then check it out again perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkin perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 1 --item 3999900000001 -m checkout 7. Check action_logs for "CIRCULATION ISSUE " line http://localhost:8081/cgi-bin/koha/tools/viewlog.pl 8. Note results Without the patch, you'll see a 2nd checkout. With the patch, you won't see the 2nd checkout. (Note: After applying the patch, you have to restart the SIP server.) Signed-off-by: David Cook Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit fdc568afa932a03838b71679fbd4d1c50c9ed0cc) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/SIP/SIPServer.pm | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 19:32:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 18:32:33 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-10-g8d9747f050 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8d9747f05013d8d56094dc05feadcc96d2a54486 (commit) via 75a4e33f5c9392f4f3a69fcd694e55730ef2786e (commit) via 14d5e841cdfbce63dad0d3e05cd8ae8339f5f9db (commit) from 9ee605ea9f920cff02f39083d8fa3d6ea59064a4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d9747f05013d8d56094dc05feadcc96d2a54486 Author: Nick Clemens Date: Fri Feb 7 16:52:52 2020 +0000 Bug 16719: (QA follow-up) Remove tabs Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit fdb9bbe40ad60ab7da6153c836396c395b6df3a7) Signed-off-by: Lucas Gass commit 75a4e33f5c9392f4f3a69fcd694e55730ef2786e Author: Oliver Behnke Date: Fri Feb 7 12:35:21 2020 +0000 Bug 16719: (follow-up) Update check on password mapping Change to allow for unmapped default passwords Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1914e1016cd9b0315dc19d1c22cdbc6eec7efe40) Signed-off-by: Lucas Gass commit 14d5e841cdfbce63dad0d3e05cd8ae8339f5f9db Author: Oliver Behnke Date: Fri Feb 7 12:31:31 2020 +0000 Bug 16719: Pass through undef rather than empty string in LDAP mapping Nullable DB fields should be passed null in cases where ldap fields are empty and not replaced with empty strings. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 0dac0b874779bc7617490199944af1d2b807e656) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Auth_with_ldap.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 20:39:48 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 19:39:48 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-11-g423b8a999f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 423b8a999f500e06e534b2b5fa87ceb889357791 (commit) from 8d9747f05013d8d56094dc05feadcc96d2a54486 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 423b8a999f500e06e534b2b5fa87ceb889357791 Author: Marcel de Rooy Date: Mon Jan 20 12:41:51 2020 +0000 Bug 13305: Remove tabindex from PrepareItemsRecordDisplay Test plan: Check the tab order of the item block on additem.pl (item editor), Acquisition (neworderempty or addiso2709), serials-edit.pl. You could also check services/itemrecorddisplay.pl and pass a biblionumber; this script is used in additem.js for cataloguing and acquisition. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5b043c6b4cd71455e0c342d74b9952d8231d069b) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 20:43:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 19:43:32 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-12-g98a8a9c041 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 98a8a9c0419ff50f3e20eb4a472320560f07d994 (commit) from 423b8a999f500e06e534b2b5fa87ceb889357791 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 98a8a9c0419ff50f3e20eb4a472320560f07d994 Author: Jonathan Druart Date: Mon Feb 3 17:31:42 2020 +0100 Bug 24516: Add account_type to the columns settings on boraccount The column was missing from the yml file. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit e9f0e0c6308746cc83e0aa0bbb4309c9f9013c8e) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: admin/columns_settings.yml | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 20:49:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 19:49:20 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-13-gcf8354aaa7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via cf8354aaa7cd3da8a8c51f6d84363db30e92f298 (commit) from 98a8a9c0419ff50f3e20eb4a472320560f07d994 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cf8354aaa7cd3da8a8c51f6d84363db30e92f298 Author: Jonathan Druart Date: Mon May 6 15:37:38 2019 -0500 Bug 22860: Remove 1 remaining patron after authentication.t is ran Test plan: 0/ Do not apply the patch 1/ select count(*) from borrowers; 2/ Run the tests => Notice that you have 1 more patron 3/ Apply the patch and repeat 1/ and 2/ => Notice that you have the same number of patrons before and after the tests Signed-off-by: Hayley Mapley Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 905c0bc5e0831148c8334a92863ec9289e2c67b5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/selenium/authentication.t | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 21:30:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 20:30:21 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-14-g5073a05caa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5073a05caafb3598b40384409a02e9885e43c6ab (commit) from cf8354aaa7cd3da8a8c51f6d84363db30e92f298 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5073a05caafb3598b40384409a02e9885e43c6ab Author: Owen Leonard Date: Fri Nov 22 19:29:53 2019 +0000 Bug 11281: Printing holds awaiting pickup prints both tabs This patch adds columns configuration to the holds awaiting pickup tables. Doing so helps solve the printing issue by adding a "Print" option to both tables. Using this print function will provide a printable version of only that table. To test you should have multiple holds in your system which are marked "waiting" and some which have been waiting longer than the value specified in the ReservesMaxPickUpDelay system preference. Apply the patch and go to Circulation -> Holds awaiting pickup. - On both the "Holds waiting" and "Holds waiting over..." tabs the DataTable should display correctly and all the controls should work, including the columns settings and the choices in the export menu. - Confirm that the "Print" action creates a printable version of only the table you are viewing. - Go to Administration -> Columns settings -> Circulation. - Change some visibility controls for the tables under the "holds_awaiting_pickup" heading (id=holdso and id=holdst). Confirm that these changes are reflected in the "Holds waiting" interface. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 30145385916935464ccbc52a1a13755464863ef9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: admin/columns_settings.yml | 80 ++++++++++++++++++++++ .../prog/en/includes/waiting_holds.inc | 2 +- .../prog/en/modules/circ/waitingreserves.tt | 34 ++++++--- 3 files changed, 106 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 21:34:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 20:34:12 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-15-g29fd9216aa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 29fd9216aaec996af88f86f65882f5da81f1b8b3 (commit) from 5073a05caafb3598b40384409a02e9885e43c6ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 29fd9216aaec996af88f86f65882f5da81f1b8b3 Author: Andrew Isherwood Date: Wed Feb 12 16:04:07 2020 +0000 Bug 24643: Support fractional seconds This patch allows dt_from_string to handle RFC3339 strings containing fractional seconds up to one thousandth of a second. Test plan: - Apply patch - prove t/DateUtils.t Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 07aa0a562b35faaa8d04b479c33cec032ece6464) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/DateUtils.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 21:36:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 20:36:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-17-g4539ac1318 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 4539ac13180ba87a913aa5afcb73425401620ee9 (commit) via 05d12aba62c740fcd71ebab339c91fd9a1aee25a (commit) from 29fd9216aaec996af88f86f65882f5da81f1b8b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4539ac13180ba87a913aa5afcb73425401620ee9 Author: Jonathan Druart Date: Thu Feb 13 14:24:52 2020 +0100 Bug 24643: Add test to cover the timezone Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit cc43ee0685ff3c895442fdb2c6c13fe076a1ba7d) Signed-off-by: Lucas Gass commit 05d12aba62c740fcd71ebab339c91fd9a1aee25a Author: Andrew Isherwood Date: Wed Feb 12 16:28:58 2020 +0000 Bug 24643: Add unit tests Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d4405602bc7b3edc1ef66a40c22880e644172db6) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/DateUtils.t | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 21:54:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 20:54:18 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-19-ge91edec0a6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via e91edec0a608a576a97f055ef664bc13b851ce83 (commit) via fdf8ad9d663b42d1c969194ff5bde3f99e0b2ebf (commit) from 4539ac13180ba87a913aa5afcb73425401620ee9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e91edec0a608a576a97f055ef664bc13b851ce83 Author: Marcel de Rooy Date: Thu Feb 13 09:27:26 2020 +0000 Bug 24649: Fix two other missing
  • tags for cloned subfields Same problem as previous patch in Batch item modification as well as serial-edit.pl. Test plan: [1] Go to Tools/Batch item modification. Test cloning subfield on batchMod-edit. [2] Go to a serial with "Create item when receiving". Receive an issue. Click add item. Test cloning subfield. Signed-off-by: Marcel de Rooy Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d024f3dd860856f0e0a878353af08fa6773743e7) Signed-off-by: Lucas Gass commit fdf8ad9d663b42d1c969194ff5bde3f99e0b2ebf Author: Marcel de Rooy Date: Thu Feb 13 08:56:35 2020 +0000 Bug 24649: Fix missing
  • tag on item editor for cloned subfield Instead of the parentNode (which is a div), we need the parent of the div (which is a li). So a simple fix. Test plan: To see the difference, test first without patch applied: Mark item subfield, say URI, as repeatable. Clone that subfield in item editor. Signed-off-by: Marcel de Rooy Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a6dc3c436c6cc01b9fd4f4e5fb576b9734d8a204) ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 21:58:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 20:58:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-20-g92af2c2dc7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 92af2c2dc70ce20dcebba2c2812af6f46675fda2 (commit) from e91edec0a608a576a97f055ef664bc13b851ce83 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 92af2c2dc70ce20dcebba2c2812af6f46675fda2 Author: Marcel de Rooy Date: Mon Feb 10 15:17:38 2020 +0000 Bug 13574: Fix display of repeatable item subfields Applies to OPAC and staff: opac-MARCdetail and catalogue/MARCdetail. Test plan: [1] Pick an item. Pick two fields say URI and copy number, and fill these with a value like A | B. (The pipe char is important.) [2] Verify that the display of the item block on opac-MARCdetail shows both A and B in those columns. (Previously only B was shown.) [3] Verify the same on catalogue MARC detail, items tab. Signed-off-by: Marcel de Rooy Signed-off-by: Holly Cooper Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 3b3a84d272fd6ee1259273e132739a4caa8bc616) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: catalogue/MARCdetail.pl | 20 +++++++++++++++----- opac/opac-MARCdetail.pl | 13 ++++++++++--- 2 files changed, 25 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 22:02:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 21:02:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-21-g23ee004d9c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 23ee004d9c6345d08f0e7e422efba6012372b3fe (commit) from 92af2c2dc70ce20dcebba2c2812af6f46675fda2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 23ee004d9c6345d08f0e7e422efba6012372b3fe Author: Andreas Jonsson Date: Fri Jan 24 10:13:05 2020 +0000 Bug 24506: Multibranch limit does not work with ElasticSearch Test plan 1. Set up a system with ElasticSearch 2. Set up or make sure ther are at least two branches 3. create a group of branches 4. make sure there are items associated with any library in the group 5. make a search in opac limited by the library group 6. make an advanced search in intra limited by the library group 7. change SearchEngine system preference to Zebra and repeat 5. and 6. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 947db3b6cb77ea6cf68fa9218729068a303aab03) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: catalogue/search.pl | 2 +- opac/opac-search.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 22:41:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 21:41:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-23-g7b3c2d287a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 7b3c2d287ace83ac19747e31f858e8b2beccdc2e (commit) via 2691b65213f90dab1811e50938d8e431bfbfd107 (commit) from 23ee004d9c6345d08f0e7e422efba6012372b3fe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7b3c2d287ace83ac19747e31f858e8b2beccdc2e Author: Lucas Gass Date: Mon Mar 9 21:04:00 2020 +0000 Bug 20882: DBRev 19.05.08.001 Signed-off-by: Lucas Gass commit 2691b65213f90dab1811e50938d8e431bfbfd107 Author: Marcel de Rooy Date: Mon Feb 10 14:28:51 2020 +0000 Bug 20882: Move items.uri to mediumtext Applies to items and deleteditems. Test plan: Run new install or upgrade. Check field size. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 853d0ee468d1f5ba1efb3a9746855486f4d25e6c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 4 ++-- installer/data/mysql/updatedatabase.pl | 11 ++++++++++- 3 files changed, 13 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 9 23:34:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Mar 2020 22:34:54 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.14-3-g72a4f68197 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 72a4f68197256436274472680d6ebd61092bdaaf (commit) via f59ea116e5cc4e365e1a54a06410ac7b58b3bb6e (commit) from 89ab97da996acbe7ead156f03a8f72b520301669 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 72a4f68197256436274472680d6ebd61092bdaaf Author: Andrew Isherwood Date: Wed Dec 11 11:10:26 2019 +0000 Bug 23980: Revert "Bug 23229: Only load ILL table JS when needed" This reverts commit f95749a66bb5dad53fa2cf00224fc38f52c1e788. https://bugs.koha-community.org/show_bug.cgi?id=23980 Signed-off-by: Bernardo Gonzalez Kriegel Fixed commit title, no errors Revised test plan: - Do not apply the patch - View koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt - TEST: Verify that it includes a "jsinclude" block near the bottom of the template - Apply the patch - Re-open the template - TEST: Verify that the "jsinclude" block is now gone Signed-off-by: Nick Clemens Signed-off-by: Hayley Mapley commit f59ea116e5cc4e365e1a54a06410ac7b58b3bb6e Author: Andrew Isherwood Date: Wed Dec 11 11:10:17 2019 +0000 Bug 23980: Revert "Bug 23229: (QA follow-up) Fix indentation" This reverts commit d4676ff4532f41abec87ba2d1128e3f219d9c920. https://bugs.koha-community.org/show_bug.cgi?id=23980 Signed-off-by: Bernardo Gonzalez Kriegel Fixed commit title Signed-off-by: Nick Clemens Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 16 ---------------- 1 file changed, 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 10 13:06:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Mar 2020 12:06:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1090-g8b6fb99c45 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8b6fb99c459a51e9da99d26361307b8c6e9600cf (commit) via 65f48c02bc1e2daf9f85a91d08003cc96dcbf98f (commit) via 9a29f56a90ee4960359a1583d0a5b665b2670ca6 (commit) via db0b620c5f7d69f1830321d7f2c5885aa8ffff8f (commit) via b49656fa3196deb0e22e1d3a9a02bd002c196863 (commit) via 3cd9d847f7316302e545e38d2579eaeac4f88dc8 (commit) via 00d375b26543ab4a55acf695705f886fa1de6cce (commit) via 39924b6769aa18de54a02196f8bb79bbc964f96a (commit) via 3896eaa2bb64a667b920100d7516225cee242ad1 (commit) via 934790769fa195f41d2ce45023d2746e2e62a71e (commit) via ae885b99f0f3fd1ec7cd6a38e200582b4db3c6d8 (commit) via ccbfb6338ef4ae944365190f48344c4b20b33832 (commit) via 47895a1a23ce888e6f4035a144a7ed76787b55c8 (commit) via 04b473261ac1517062668b8268234beb191cd14a (commit) from 7b25bb76444afb06d3459423ca65314e2145c8a9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8b6fb99c459a51e9da99d26361307b8c6e9600cf Author: Martin Renvoize Date: Tue Mar 10 11:39:44 2020 +0000 Bug 23112: Compiled CSS Signed-off-by: Martin Renvoize commit 65f48c02bc1e2daf9f85a91d08003cc96dcbf98f Author: Martin Renvoize Date: Tue Mar 10 11:38:48 2020 +0000 Bug 23112: DBRev 19.12.00.038 Signed-off-by: Martin Renvoize commit 9a29f56a90ee4960359a1583d0a5b665b2670ca6 Author: Nick Clemens Date: Fri Mar 6 11:35:05 2020 +0000 Bug 23112: (QA follow-up) Clean up tests, catch warnings Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit db0b620c5f7d69f1830321d7f2c5885aa8ffff8f Author: Andrew Isherwood Date: Fri Mar 6 09:33:16 2020 +0000 Bug 23112: (follow-up) Unit test fixes As requested by Nick, fixes unit tests and added a test for the new Koha::Illrequest::biblio method Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit b49656fa3196deb0e22e1d3a9a02bd002c196863 Author: Andrew Isherwood Date: Thu Mar 5 09:27:32 2020 +0000 Bug 23112: (follow-up) Conditionally prevent checkout As mentioned by Nick in comment #69, the checkout button displays even for requests without a biblio attached (such as chapters). This patch fixes that. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 3cd9d847f7316302e545e38d2579eaeac4f88dc8 Author: Nick Clemens Date: Wed Mar 4 11:52:11 2020 +0000 Bug 23112: (QA follow-up) Fix database update, add filters, remove tabs Looks like the atomicupdate and sysprefs.sql changes were lost at some point. Don't forget to run QA tools on your patches before submitting Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 00d375b26543ab4a55acf695705f886fa1de6cce Author: Andrew Isherwood Date: Tue Jan 7 10:16:58 2020 +0000 Bug 23112: (follow-up) Fix test as per feedback As per comment #48 Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 39924b6769aa18de54a02196f8bb79bbc964f96a Author: Andrew Isherwood Date: Mon Jan 6 12:04:53 2020 +0000 Bug 23112: (follow-up) Address QA feedback As per comment #46 Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 3896eaa2bb64a667b920100d7516225cee242ad1 Author: Andrew Isherwood Date: Thu Oct 10 15:41:58 2019 +0100 Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues In response to the problem Magnus was experiencing in comment #28 & #29 we now call GetAuthorisedValues by it's full path Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 934790769fa195f41d2ce45023d2746e2e62a71e Author: Andrew Isherwood Date: Tue Jul 30 14:54:53 2019 +0100 Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method Sponsored-by: Loughborough University Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit ae885b99f0f3fd1ec7cd6a38e200582b4db3c6d8 Author: Andrew Isherwood Date: Mon Jul 29 09:10:04 2019 +0100 Bug 23112: Update request status on return This patch updates a request's status to RET upon return Sponsored-by: Loughborough University Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit ccbfb6338ef4ae944365190f48344c4b20b33832 Author: Andrew Isherwood Date: Mon Jul 29 09:08:41 2019 +0100 Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. Sponsored-by: Loughborough University Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 47895a1a23ce888e6f4035a144a7ed76787b55c8 Author: Andrew Isherwood Date: Thu Jul 25 13:46:12 2019 +0100 Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added This development has been carried out according to the originally stated requirements of the customer that sponsored it, detailed here: https://wiki.koha-community.org/wiki/ILL_Circulation_RFC Test plan: 1. Ensure the FreeForm ILL backend is available 2. Enable the "CirculateILL" syspref 3. Ensure you have a statistical patron category defined (patron category type "Statistical") 4. Ensure you have at least one patron in your statistical patron category 5. Create a new FreeForm request (make a note of the library you select when creating it) 6. Mark the new request as confirmed by clicking the "Confirm request" button on the "Manage ILL request" page 7. TEST: Observe that a "Check out" button is now displayed in the request toolbar 8. Click the "Check out" button in the "Manage ILL request" page 9. In the "Issue requested item to..." screen: a. Do not select a statistical patron at this time b. You can at this point choose an item type, this will determine the type of the item that will be created for this request c. TEST: Observe that the default selected "Library" matches that that was defined when creating the request d. Do not select a due date at this time 10. Click "Submit" 11. TEST: Observe that the "Item checked out" screen displays, issued to the requesting patron with a due date corresponding to appropriate circ rules 12. Click "Return to request" 13. TEST: Observe that the request's status is now "Checked out" 14. Click the "Bibliographic record ID" link 15. TEST: Observe that the bibliographic record now has one item attached to it which is checked out 16. TEST: Observe that the item barcode is "ILL-" + the ILL request ID 17. Return to step 5., however, this time select a statistical patron and test that the item use is recorded and the item is not issued 18. Return to step 5., however, this time manually select a due date and test that the item's due date is set correctly on check out 19. Check in the item 20. TEST: Observe that the request's status is updated to "Returned to library" 21. Now implement a restriction on the patron (perhaps a fine) which would prevent them from checking out an item 22. Return to step 5. follow the instructions to step 10. 23. TEST: Observe that a banner is displayed at the top of the screen informing you that there was a problem checking the item out, containing a link to the patron's account page 24. Resolve the problem with the patron's account 25. Return to step 8. 26. TEST: Observe that the item is now successfully checked out 27. Disable the "CirculateILL" syspref 28. Return to step 5. at step 7. Observe that the "Check out" button is NOT displayed Sponsored-by: Loughborough University Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 04b473261ac1517062668b8268234beb191cd14a Author: Andrew Isherwood Date: Fri Jul 26 10:42:32 2019 +0100 Bug 23112: Add CirculateILL syspref Sponsored-by: Loughborough University Signed-off-by: Chris Walton Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 10 + Koha.pm | 2 +- Koha/Illrequest.pm | 253 ++++++++++++++++++++- Koha/Illrequest/Logger.pm | 2 +- ill/ill-requests.pl | 8 + installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 7 + .../intranet-tmpl/prog/css/src/staff-global.scss | 4 + koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../en/modules/admin/preferences/circulation.pref | 7 + .../prog/en/modules/ill/ill-requests.tt | 185 +++++++++++++++ t/db_dependent/Illrequests.t | 195 ++++++++++++++-- 12 files changed, 657 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 10 16:46:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Mar 2020 15:46:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1109-g03013acc2e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 03013acc2ed908a41415c3def0c72e888d4e5d00 (commit) via 6fc8d02995b7c5c085c913bde6af3fcd24536107 (commit) via 32421f8de6e09453d78ec4ae511b7ffb888bff2f (commit) via f0c031670e864858f0e4627e1a9151f954628bcc (commit) via aad473ff26ffb3e5bef6f3330c828a29690d8a2b (commit) via ef2fee688536a0db979ada68fa19d6c26972458d (commit) via 6f39131b85fa7039c1d6f43e71e73073aae459fd (commit) via 7e0749d4f0e8d35ece1499c5775f5277a5ae9e83 (commit) via faf1e7cd914d1a6c88f5c7bef54780d43b6c453d (commit) via 8b17e1ae2ccde6f03037a311f5c398c46c21022f (commit) via 8a7afe0ead1ff04196663199568ce4d100e4008f (commit) via b0a783a8a8428ad657b8b58a341474718c021203 (commit) via 07b0c5bc0e06001137419e99b14c3f75c5b3d26d (commit) via 9f362876f4fceffda51a09678828e4078c6454d0 (commit) via 708f297918c5d6642131641cb1030f3040653e29 (commit) via db473f8777235244929ec80133515130c55a1559 (commit) via c7b7f83ae31c23f1bf7e0e1761d06c733d2817f9 (commit) via 9b86077aaea9b12ba750a04f7054fd4c1ab180aa (commit) via f9efa7a99c3ea1a803b00e53ccb0b8e3020b0edb (commit) from 8b6fb99c459a51e9da99d26361307b8c6e9600cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 03013acc2ed908a41415c3def0c72e888d4e5d00 Author: Fridolin Somers Date: Mon Mar 2 18:03:54 2020 +0300 Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt In return page return.tt, when there is an hold message, patron is said as restricted even if restriction end date is in the past. Test plan : 1) For a patron Jon Doe create a manual restriction with end date in the past 2) Create an hold for this patron on an item 3) Check in this item => You don't see message "Patron is RESTRICTED" 4) For a patron Kevin Doe create a manual restriction with end date in the future 5) Create an hold for this patron on an item 6) Check in this item => You see message "Patron is RESTRICTED" 7) Repeate 1-6 with system preference HoldsAutoFill enabled 8) Repeate 1-6 with a waiting hold Signed-off-by: Nazlı Çetin Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6fc8d02995b7c5c085c913bde6af3fcd24536107 Author: Emmi Date: Fri Jul 5 11:46:15 2019 +0300 Bug 23268: Make "Suspend all holds" calendar select a date from tomorrow This patch removes "circulation" and moremember" templates functions for Datepicker plugin. They now use options common for all inputs with "datepicker" class and get "minDate" option from class "futuredate" assigned function in "calender.inc". To test: - Apply patch - Add holds for patron - Use "Suspend all holds" calendar =>Calendar greys out dates past from today Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 32421f8de6e09453d78ec4ae511b7ffb888bff2f Author: Jonathan Druart Date: Tue Mar 10 12:19:54 2020 +0100 Bug 18127: Add missing html filters Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit f0c031670e864858f0e4627e1a9151f954628bcc Author: Aleisha Amohia Date: Wed Feb 5 04:33:50 2020 +0000 Bug 18127: Add batch modified records to an existing list To test: 1) Start by having no (zero) lists 2) Go to Tools -> Batch record modification 3) Go through the batch record modification process, confirm everything works as normal and there is a link to do a new batch record modification at the end 4) In another tab, go to Lists and create a new list 5) Go back to the first tab and start a new batch modification process 6) At the end of the process, there should be a new option to add modified records to an existing list 7) Select a list from the dropdown and confirm you are able to save your modified records to the list as expected 8) Start a new batch modification process, this time for authorities records 9) At the end confirm there is no option to add modified records to a list, because authorities cannot be added to lists Sponsored-by: Catalyst IT Signed-off-by: Jessica Zairo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit aad473ff26ffb3e5bef6f3330c828a29690d8a2b Author: Martin Renvoize Date: Tue Mar 10 15:19:34 2020 +0000 Bug 17374: DBRev 19.12.040 Signed-off-by: Martin Renvoize commit ef2fee688536a0db979ada68fa19d6c26972458d Author: Katrin Fischer Date: Thu Jan 30 08:31:28 2020 +0100 Bug 17374: (QA follow-up) Make search labels match with patron record Makes some small changes to the patronfields.inc to make sure the search labels match with the labels in the patron record. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6f39131b85fa7039c1d6f43e71e73073aae459fd Author: Nick Date: Wed Oct 30 14:07:02 2019 +0000 Bug 17374: (follow-up) Unit tests Signed-off-by: Maxime Dufresne Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 7e0749d4f0e8d35ece1499c5775f5277a5ae9e83 Author: Nick Clemens Date: Tue Apr 24 19:03:26 2018 +0000 Bug 17374: (follow-up) Remove spaces from include file Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit faf1e7cd914d1a6c88f5c7bef54780d43b6c453d Author: Nick Clemens Date: Thu Oct 27 14:21:02 2016 +0000 Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Kelly Signed-off-by: Maxime Dufresne Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8b17e1ae2ccde6f03037a311f5c398c46c21022f Author: Martin Renvoize Date: Tue Mar 10 15:09:07 2020 +0000 Bug 17845: DBRev 19.12.00.039 Signed-off-by: Martin Renvoize commit 8a7afe0ead1ff04196663199568ce4d100e4008f Author: Jonathan Druart Date: Tue Mar 10 11:12:12 2020 +0100 Bug 17845: Schema changes Signed-off-by: Martin Renvoize commit b0a783a8a8428ad657b8b58a341474718c021203 Author: Jonathan Druart Date: Tue Mar 10 10:56:08 2020 +0100 Bug 17845: Remove the column if it exists Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 07b0c5bc0e06001137419e99b14c3f75c5b3d26d Author: Jonathan Druart Date: Tue Mar 10 10:39:49 2020 +0100 Bug 17845: Adjust few other occurrences Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 9f362876f4fceffda51a09678828e4078c6454d0 Author: Martin Renvoize Date: Mon Mar 9 16:51:28 2020 +0000 Bug 17845: Remove some missed references to branchprinter Remove a few last references to branchprinter, mostly from tests. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 708f297918c5d6642131641cb1030f3040653e29 Author: Martin Renvoize Date: Mon Mar 9 16:44:57 2020 +0000 Bug 17845: (QA follow-up) Remove hidden print input As highlighted by Jonathan, the hidden 'print' form field is no longer read and thus no longer required in the template. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit db473f8777235244929ec80133515130c55a1559 Author: Martin Renvoize Date: Mon Mar 9 16:42:34 2020 +0000 Bug 17845: (QA follow-up) Remove commented line A commented line still refered to the removed page from the admin-menu.inc Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c7b7f83ae31c23f1bf7e0e1761d06c733d2817f9 Author: Martin Renvoize Date: Mon Mar 9 16:41:27 2020 +0000 Bug 17845: Update atomic update for new format Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 9b86077aaea9b12ba750a04f7054fd4c1ab180aa Author: Katrin Fischer Date: Sun Sep 16 23:25:37 2018 +0200 Bug 17845: Remove unused code related to printers There is some quite old and unused code in Koha related to printer configuration and network printing. These code hasn't been functional in a long time and should be removed. This patch: - Removes printcirculationslips system preference - Removes table printers - Removes branchprinter column from branches Check that: - Go to administration - Open any age there, but change the last bit to: printers.pl - Apply patch, run the database update - Verify the hidden page no longer exists - Verify that logging in and out still works correctly - Verify that checkout and returns work correctly - Switch to another branch using the "Set library" option Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit f9efa7a99c3ea1a803b00e53ccb0b8e3020b0edb Author: Colin Campbell Date: Wed Oct 30 12:34:45 2019 +0000 Bug 23926: Limit GIR segment to 5 pieces of info Strictly if a GIR segment contains more than 5 pieces of information the it should be encoded in repeated segments each of 5 elements or less each sharing the same copy sequence number Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 37 ++--- C4/Context.pm | 5 +- C4/InstallAuth.pm | 3 +- C4/Koha.pm | 40 ----- C4/Print.pm | 103 ------------ C4/Utils/DataTables/Members.pm | 15 +- Koha.pm | 2 +- Koha/Edifact/Order.pm | 72 ++++++--- Koha/Library.pm | 1 - Koha/Schema/Result/Branch.pm | 12 +- Koha/Script.pm | 4 +- admin/printers.pl | 137 ---------------- circ/circulation.pl | 19 +-- circ/returns.pl | 10 +- circ/selectbranchprinter.pl | 45 ------ installer/data/mysql/kohastructure.sql | 14 -- .../data/mysql/ru-RU/optional/example_branches.sql | 18 +-- installer/data/mysql/sysprefs.sql | 3 +- installer/data/mysql/updatedatabase.pl | 22 +++ .../intranet-tmpl/prog/en/includes/admin-menu.inc | 1 - .../intranet-tmpl/prog/en/includes/calendar.inc | 4 + .../prog/en/includes/patron-search.inc | 64 ++------ .../prog/en/includes/patronfields.inc | 75 +++++++++ .../en/modules/admin/preferences/circulation.pref | 1 - .../prog/en/modules/admin/preferences/patrons.pref | 2 +- .../prog/en/modules/admin/printers.tt | 173 --------------------- .../prog/en/modules/circ/circulation.tt | 10 +- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 6 +- .../prog/en/modules/circ/selectbranchprinter.tt | 15 -- .../prog/en/modules/members/member.tt | 63 ++------ .../prog/en/modules/members/moremember.tt | 10 +- .../en/modules/tools/batch_record_modification.tt | 38 ++++- misc/commit_file.pl | 2 +- t/Ediorder.t | 58 ++++++- t/Koha/Script.t | 1 - t/Koha/Script_cron.t | 1 - t/Print.t | 15 -- t/Token.t | 7 +- t/db_dependent/Circulation/GetHardDueDate.t | 2 - t/db_dependent/Circulation/OfflineOperation.t | 1 - t/db_dependent/RotatingCollections.t | 1 - t/db_dependent/Utils/Datatables_Members.t | 22 ++- t/db_dependent/selenium/patrons_search.t | 22 ++- t/lib/Mocks.pm | 4 +- tools/batch_record_modification.pl | 4 +- 45 files changed, 368 insertions(+), 796 deletions(-) delete mode 100644 C4/Print.pm delete mode 100755 admin/printers.pl create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/printers.tt delete mode 100755 t/Print.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 10 20:15:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Mar 2020 19:15:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1111-g52db77b93e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 52db77b93ead47914e049f1e32e102e6b0dab40b (commit) via 6653a24148d8d061f2dce868ca19db48c6bf5a34 (commit) from 03013acc2ed908a41415c3def0c72e888d4e5d00 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 52db77b93ead47914e049f1e32e102e6b0dab40b Author: Martin Renvoize Date: Tue Mar 10 18:48:49 2020 +0000 Bug 17845: (RM follow-up) Remove Printer DBIC Class Signed-off-by: Martin Renvoize commit 6653a24148d8d061f2dce868ca19db48c6bf5a34 Author: Martin Renvoize Date: Tue Mar 10 18:41:48 2020 +0000 Bug 17845: (RM follow-up) Restore a removed test Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Printer.pm | 74 ------------------------------------------- t/Token.t | 1 + 2 files changed, 1 insertion(+), 74 deletions(-) delete mode 100644 Koha/Schema/Result/Printer.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 10 23:42:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Mar 2020 22:42:47 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-26-gc60a49a81d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via c60a49a81d8595b2570f221284c81a8710a0e512 (commit) via 0fb8056d3fa294b78078646e3e0320e3583505fe (commit) via cad404ba2948413a258abbfd085cc33b7f107ef0 (commit) from 7b3c2d287ace83ac19747e31f858e8b2beccdc2e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c60a49a81d8595b2570f221284c81a8710a0e512 Author: Katrin Fischer Date: Sat Feb 15 01:15:35 2020 +0000 Bug 18499: (QA follow-up) Add missing colon after label description To match the line above, a colon (:) was added after the description: Callnumber classification scheme: [pull down] Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 329796c7a95ed30a4e0ff4963518bf6f88a0f679) Signed-off-by: Lucas Gass commit 0fb8056d3fa294b78078646e3e0320e3583505fe Author: Nick Clemens Date: Fri Feb 14 17:59:38 2020 +0000 Bug 18499: (follow-up) Add missing filters Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c64ac9504fc72ee8e6b95ac26b679dc1701ca2bf) Signed-off-by: Lucas Gass commit cad404ba2948413a258abbfd085cc33b7f107ef0 Author: Nick Clemens Date: Thu Feb 6 13:14:30 2020 +0000 Bug 18499: Use items cn_source in cn_browser.pl This does a few things: * We fetch the cn_sort from the DB and use this rather than calculating based on DefaultClassificationSource We were already pulling based on the items source, so this should not change things * Rather than using JS to submit the form, it submits via html * Fix subtitle display and add barcode (it was retrieved in one query but not used) * Add option to apply different classification scheme to the search To test: 1 - Add cn_browser.pl to the 'plugin' field in a framework for 952$o 2 - Edit an item on a record in that framework 3 - Enter an itemcallnumber 4 - Click the two dots to launch the callnumber browser 5 - Note the results 6 - Apply patch 7 - Repeat 8 - Note subtitles and barcodes are displayed in results 9 - Note callnumbers are appropriate 10 - Try changing the class source used 11 - Try this with differing dewey,lcc, and other callnumbers 12 - Ensure results are as expected Signed-off-by: Myka Kennedy Stephens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 0f7d7a8c2faf5777655a9b67c8cea8ffade56071) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: cataloguing/value_builder/cn_browser.pl | 21 ++++++++------ .../cataloguing/value_builder/cn_browser.tt | 33 ++++++++++++---------- 2 files changed, 31 insertions(+), 23 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 10 23:47:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Mar 2020 22:47:20 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-27-g5bccfa152a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5bccfa152ab90183e84b7e5b03536b05efc71abd (commit) from c60a49a81d8595b2570f221284c81a8710a0e512 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5bccfa152ab90183e84b7e5b03536b05efc71abd Author: Jonathan Druart Date: Mon Dec 16 17:15:19 2019 +0100 Bug 24389: Better error handle when claiming late orders A successful message says that the email has been sent and the order has been claimed, but nothing happened. Test plan: 0. Do not apply this patch 1. Create a new vendor, does not create a contact 2. Create some orders, close the basket 3. Go to the late orders page and claims some orders => You get a successful message, but the claim has not been done! 4. Apply this patch 5. Claim the orders => You get an error 6. Set a contact for the vendor 7. Claim the orders => Success In the docker container, you may need to: % apt install postfix % postfix start Edit /etc/hosts 127.0.0.1 localhost localhost.localdomain Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c2c7c6e754c0cf44ce0f99798f5115731a61868e) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: acqui/lateorders.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 10 23:51:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Mar 2020 22:51:07 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-28-gd83a915b6d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via d83a915b6d98c469f477fa34f29bf2fa35d9ca58 (commit) from 5bccfa152ab90183e84b7e5b03536b05efc71abd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d83a915b6d98c469f477fa34f29bf2fa35d9ca58 Author: Owen Leonard Date: Mon Feb 10 17:58:04 2020 +0000 Bug 24619: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit fb45f5bb98c07ac544184b8ffa029f1f5702e993) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 10 23:55:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Mar 2020 22:55:24 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-29-ge89516e5eb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via e89516e5eb74094047a489ed98b8af3185293116 (commit) from d83a915b6d98c469f477fa34f29bf2fa35d9ca58 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e89516e5eb74094047a489ed98b8af3185293116 Author: Owen Leonard Date: Mon Feb 10 19:04:57 2020 +0000 Bug 24621: Phase out jquery.cookie.js: Basic MARC editor This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply the patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a2fe9fa991bc074c4703729b0f459a40a2cc0eb4) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/cataloguing/addbiblio.tt | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 11 00:00:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Mar 2020 23:00:18 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-30-g49080b42a1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 49080b42a1b1c584ec974f4abb310044b4f3906e (commit) from e89516e5eb74094047a489ed98b8af3185293116 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 49080b42a1b1c584ec974f4abb310044b4f3906e Author: Nick Clemens Date: Thu Feb 13 15:43:30 2020 +0000 Bug 24654: Remove trailing quote in rda264 XSLT To test: 1 - Find or add a recod with a 264 field 2 - Make sure there is a subfield b 3 - View the record in opac 4 - Right click on publisher link and copy and paste into a text editor 5 - Note the trailing " in the search 6 - Apply patch 7 - Refresh 8 - Link is correctly formed now Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 91c16e9e7a8e9eccf37024b0efde14819b7093b9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 11 00:08:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Mar 2020 23:08:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-32-g8839904934 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 88399049343fd8dd39d80e2ad784883aca02a89e (commit) via 12ac783d98c470513e039269b0f986b1b0988d08 (commit) from 49080b42a1b1c584ec974f4abb310044b4f3906e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 88399049343fd8dd39d80e2ad784883aca02a89e Author: Lucas Gass Date: Tue Mar 10 22:40:07 2020 +0000 Bug 24260: DBRev 19.05.08.002 Signed-off-by: Lucas Gass commit 12ac783d98c470513e039269b0f986b1b0988d08 Author: Jonathan Druart Date: Wed Feb 12 12:26:25 2020 +0100 Bug 24640: Allow quotes.timestamp to be NULL It is broken with strict mode enable, timestamp is created without default value. Note that the .sql installer file init the value with NOW(), which is wrong. DBD::mysql::st execute failed: Field 'timestamp' doesn't have a default value [for Statement "INSERT INTO quotes (source, text) VALUES (?, ?);" with ParamValues: 0="poeut", 1="pouet"] at /kohadevbox/koha/tools/quotes/quotes_ajax.pl line 49. Test plan: Create a new quote of the day => Without this patch you will get an error Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 9bf4f492d82196f10bb017dd761ff6fa022a9bb9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/updatedatabase.pl | 8 ++++++++ 3 files changed, 10 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 11 00:13:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Mar 2020 23:13:30 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-33-g205dac98dc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 205dac98dc0258884c2171b9c1e972b0b7938ff6 (commit) from 88399049343fd8dd39d80e2ad784883aca02a89e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 205dac98dc0258884c2171b9c1e972b0b7938ff6 Author: David Kuhn Date: Sat Aug 31 16:23:16 2019 -0700 Bug 23527: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Changing the template toolkit filter for rendering the value of BakerTaylorBookstoreURL in opac-detail.tt and opac-results.tt from uri to url fixes the problem. To test (requires a Baker & Taylor username and password): 1. Enter the B&T url into BakerTaylorBookstoreURL. 2. Set BakerTaylorEnabled to "add" and enter your username and password. 3. Look up a title in the OPAC. 4. Locate a title with a cover image. 5. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 6. Display the full record for the title 7. Click on the cover image. You are not redirected to the url stored in BakerTaylorBookstoreURL. 8. Apply the patch. 9. Refresh the OPAC display. 10. Click on the cover image. You are now redirected to the specified url. 11. Return to the results list. 12. Click on a cover image. You are now redirected to the specified url. Signed-off-by: Owen Leonard Although I don't have valid Baker & Taylor credentials I was able to use dummy data to verify that the links in the template are correctly encoded with this patch. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 07af2a5645303ad35b45fabc3ed966f2ab55899e) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 11 15:15:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 11 Mar 2020 14:15:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1117-g0c9b39a66d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0c9b39a66dff00d2d76effc42824c2051484f9c5 (commit) via d28bf2de71edb2d895840619d0b70aadff43290a (commit) via 87f3e2d5e09ce4f0aeb20bb805732e1c050b9629 (commit) via 818ce7ac998b50b1e0d094082b75de1fd1c4f0de (commit) via 218012812d2c95f7e5013a4bb0a2684a4eec7378 (commit) via 2c3b0f4d57c73b1775780d48703cbb5af82e58d3 (commit) from 52db77b93ead47914e049f1e32e102e6b0dab40b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0c9b39a66dff00d2d76effc42824c2051484f9c5 Author: Julian Maurice Date: Fri Feb 14 10:44:39 2020 +0100 Bug 24662: Remove global variables MSG_* from datatables.inc Now that bug 21156 is pushed, we don't need to have global variables in .inc or .tt files for translation in .js file. We can simply declare our translatable strings where they are used. This patch removes all global variables used in DataTables configuration Test plan: 1. cd misc/translator && ./translate update fr-FR 2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po 3. cd misc/translator && ./translate install fr-FR 4. Go to the staff interface, in english, and check that DataTables tables are still working. You should check at least the following pages: - catalogue/detail.pl - circ/circulation.pl - tools/quotes.pl - tools/letter.pl 5. Switch to french and check again DataTables tables, and verify that strings are translated This patch depends on bug 24661 Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Martin Renvoize commit d28bf2de71edb2d895840619d0b70aadff43290a Author: Martin Renvoize Date: Thu Mar 5 14:32:23 2020 +0000 Bug 24812: (bug 24081 follow-up) Add permission description Bug 24081 added a discount permission to the accounts system but during subsequent rebases, the description of that new permission got lot. This patch restores the description. Test plan 0/ Check that a checkbox without a description appears in the 'Manage patrons patrons fines and fees' section of the 'Set permissions' page. 1/ Apply the patch 2/ Reload the page and note that the checkbox now preceeds a suitable description. 3/ Signoff. Bonus points: Check the permission works as described and hides the 'Discount' action button for staff who do not have the permission enabled. Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 87f3e2d5e09ce4f0aeb20bb805732e1c050b9629 Author: Andrew Isherwood Date: Mon Feb 3 11:14:50 2020 +0000 Bug 24565: Add patron profile to ILL list pages We need the API call to get ILL requests on the patron profile page, this commit allows this. Test plan: - Do not apply the patch. - Go to the "Ill requests history" page for a patron who has made ILL requests - TEST: Observe that no requests are displayed - Apply the patch - Refresh the page - TEST: Observe that requests are displayed - Go to the main "ILL requests" page - TEST: Observe that requests are displayed Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize commit 818ce7ac998b50b1e0d094082b75de1fd1c4f0de Author: Martin Renvoize Date: Wed Mar 11 11:27:38 2020 +0000 Bug 24839: (QA follow-up) Remove unused variables Whilst QAing I spotted a couple of unused variables in the test.. no harm in removing them ;) Signed-off-by: Martin Renvoize commit 218012812d2c95f7e5013a4bb0a2684a4eec7378 Author: Nick Clemens Date: Tue Mar 10 09:37:56 2020 -0400 Bug 24839: Return hold info to transfer script and set borrowernumber To test: 1 - Place a hold on an item 2 - Go to Circulation->Transfers 3 - Attempt to transfer item to a branch it is not expected at 4 - No warning 5 - Apply patches 6 - Repeate 7 - You get a notice that there is a hold and must deal with the hold (or ignore) Signed-off-by: David Nind Signed-off-by: Martin Renvoize commit 2c3b0f4d57c73b1775780d48703cbb5af82e58d3 Author: Nick Clemens Date: Tue Mar 10 09:59:16 2020 -0400 Bug 24839: Unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 3 +- circ/branchtransfers.pl | 1 + .../intranet-tmpl/prog/en/includes/datatables.inc | 24 ----------- .../intranet-tmpl/prog/en/includes/permissions.inc | 5 +++ .../prog/en/modules/circ/circulation.tt | 1 - .../intranet-tmpl/prog/en/modules/tools/quotes.tt | 18 +-------- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 5 ++- koha-tmpl/intranet-tmpl/prog/js/datatables.js | 46 +++++++++++----------- koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 12 +++++- koha-tmpl/intranet-tmpl/prog/js/letter.js | 4 +- koha-tmpl/intranet-tmpl/prog/js/table_filters.js | 4 +- t/db_dependent/Circulation/transferbook.t | 32 ++++++++++----- 12 files changed, 70 insertions(+), 85 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 13 01:10:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Mar 2020 00:10:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-45-gb09ca43dec Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b09ca43dec81209d08abf45d75e9e5dea9f4b907 (commit) via 414a1fbb7ddeec3af27ebdd76b765838b301e958 (commit) via 78cba3f3397d51355bb40f81c69a1b2404e85d5f (commit) via 2d60c61cf778940597eea24e330f6ddbdaa9fddf (commit) from 30e12584a7c6e635abd0e02be1fbbf67f5ae4929 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b09ca43dec81209d08abf45d75e9e5dea9f4b907 Author: Katrin Fischer Date: Mon Feb 24 17:01:19 2020 +0000 Bug 24725: (QA follow-up) Add missing spaces between elements on claims tab There was a missing space between the title and the barcode. Also added a space between title and author. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 414a1fbb7ddeec3af27ebdd76b765838b301e958 Author: Jonathan Druart Date: Tue Feb 25 14:40:06 2020 +0100 Bug 24725: Remove ES template literals in checkouts.js From Julian on bug 24661 comment 6: """ It looks like xgettext does not like ES6 template literals. https://savannah.gnu.org/bugs/?50920 From what I understand, support for template literals was added in gettext 0.20 (still not packaged in debian) but is still buggy in latest released version 0.20.1 and a fix is present in master. """ We should not use backticks ` in .js file, it breaks xgettext. To replicate: kohadev-koha at e1f3025cca60:/kohadevbox/koha/misc/translator$ perl translate update es-ES koha-tmpl/intranet-tmpl/prog/js/checkouts.js:569: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:858: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:904: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:911: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:1095: warning: RegExp literal terminated too early /usr/bin/msgmerge: error while opening "/kohadevbox/koha/misc/translator/po/es-ES-messages-js.po" for reading: No such file or directory (last error 'No such file or directory' is not related to this). Test plan: Make sure nothing is broken on the claims table Confirm that the errors do not longer appear on `perl translate update LANG` Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 78cba3f3397d51355bb40f81c69a1b2404e85d5f Author: Jonathan Druart Date: Tue Feb 25 14:17:27 2020 +0100 Bug 24727: (bug 14697 follow-up) Replace link on title to bib detail page 903 let title = ` At first it seems like a typo: request-rcticle.pl vs request-acticle.pl But actually it does not make sense to link to request-article, we want (I think) to link to the bibliographic record detail page. Test plan: - Have something in the claim table (cf bug 14697) - Click on the title of the bibliographic record Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 2d60c61cf778940597eea24e330f6ddbdaa9fddf Author: Bernardo Gonzalez Kriegel Date: Fri Feb 14 11:33:44 2020 -0300 Bug 24664: Add missing *-messages-js.po If you try to update some language translation files translate script will complain of missing *-messajes-js.po file. This patch adds those missing files To test: 1) Go to misc translation 2) Update some language, eg- fr-FR Check error /usr/bin/msgmerge: error while opening "/.../misc/translator/po/es-ES-messages-js.po" for reading: No such file or directory 3) Apply this patch 4) Repeat 2), no error message Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 87 +++++++++++++--------------- misc/translator/po/am-Ethi-messages-js.po | 17 ++++++ misc/translator/po/ar-Arab-messages-js.po | 17 ++++++ misc/translator/po/as-IN-messages-js.po | 17 ++++++ misc/translator/po/az-AZ-messages-js.po | 17 ++++++ misc/translator/po/be-BY-messages-js.po | 19 ++++++ misc/translator/po/bg-Cyrl-messages-js.po | 18 ++++++ misc/translator/po/bn-IN-messages-js.po | 17 ++++++ misc/translator/po/ca-ES-messages-js.po | 17 ++++++ misc/translator/po/cs-CZ-messages-js.po | 18 ++++++ misc/translator/po/cy-GB-messages-js.po | 17 ++++++ misc/translator/po/da-DK-messages-js.po | 18 ++++++ misc/translator/po/de-CH-messages-js.po | 18 ++++++ misc/translator/po/de-DE-messages-js.po | 18 ++++++ misc/translator/po/dz-messages-js.po | 17 ++++++ misc/translator/po/el-GR-messages-js.po | 18 ++++++ misc/translator/po/en-GB-messages-js.po | 18 ++++++ misc/translator/po/en-NZ-messages-js.po | 18 ++++++ misc/translator/po/eo-messages-js.po | 18 ++++++ misc/translator/po/es-ES-messages-js.po | 18 ++++++ misc/translator/po/eu-messages-js.po | 17 ++++++ misc/translator/po/fa-Arab-messages-js.po | 17 ++++++ misc/translator/po/fi-FI-messages-js.po | 18 ++++++ misc/translator/po/fo-FO-messages-js.po | 18 ++++++ misc/translator/po/fr-CA-messages-js.po | 18 ++++++ misc/translator/po/fr-FR-messages-js.po | 18 ++++++ misc/translator/po/ga-messages-js.po | 18 ++++++ misc/translator/po/gd-messages-js.po | 17 ++++++ misc/translator/po/gl-messages-js.po | 17 ++++++ misc/translator/po/he-Hebr-messages-js.po | 18 ++++++ misc/translator/po/hi-messages-js.po | 17 ++++++ misc/translator/po/hr-HR-messages-js.po | 19 ++++++ misc/translator/po/hu-HU-messages-js.po | 18 ++++++ misc/translator/po/hy-Armn-messages-js.po | 17 ++++++ misc/translator/po/ia-messages-js.po | 17 ++++++ misc/translator/po/id-ID-messages-js.po | 17 ++++++ misc/translator/po/iq-CA-messages-js.po | 17 ++++++ misc/translator/po/is-IS-messages-js.po | 17 ++++++ misc/translator/po/it-IT-messages-js.po | 18 ++++++ misc/translator/po/iu-CA-messages-js.po | 17 ++++++ misc/translator/po/ja-Jpan-JP-messages-js.po | 18 ++++++ misc/translator/po/ka-messages-js.po | 17 ++++++ misc/translator/po/km-KH-messages-js.po | 17 ++++++ misc/translator/po/kn-Knda-messages-js.po | 17 ++++++ misc/translator/po/ko-Kore-KP-messages-js.po | 18 ++++++ misc/translator/po/ku-Arab-messages-js.po | 17 ++++++ misc/translator/po/lo-Laoo-messages-js.po | 17 ++++++ misc/translator/po/lv-messages-js.po | 19 ++++++ misc/translator/po/mi-NZ-messages-js.po | 17 ++++++ misc/translator/po/ml-messages-js.po | 17 ++++++ misc/translator/po/mon-messages-js.po | 17 ++++++ misc/translator/po/mr-messages-js.po | 17 ++++++ misc/translator/po/ms-MY-messages-js.po | 17 ++++++ misc/translator/po/my-messages-js.po | 17 ++++++ misc/translator/po/nb-NO-messages-js.po | 18 ++++++ misc/translator/po/ne-NE-messages-js.po | 17 ++++++ misc/translator/po/nl-BE-messages-js.po | 18 ++++++ misc/translator/po/nl-NL-messages-js.po | 18 ++++++ misc/translator/po/nn-NO-messages-js.po | 18 ++++++ misc/translator/po/oc-messages-js.po | 17 ++++++ misc/translator/po/pbr-messages-js.po | 17 ++++++ misc/translator/po/pl-PL-messages-js.po | 19 ++++++ misc/translator/po/prs-messages-js.po | 17 ++++++ misc/translator/po/pt-BR-messages-js.po | 18 ++++++ misc/translator/po/pt-PT-messages-js.po | 18 ++++++ misc/translator/po/ro-RO-messages-js.po | 19 ++++++ misc/translator/po/ru-RU-messages-js.po | 19 ++++++ misc/translator/po/rw-RW-messages-js.po | 17 ++++++ misc/translator/po/sd-PK-messages-js.po | 17 ++++++ misc/translator/po/sk-SK-messages-js.po | 18 ++++++ misc/translator/po/sl-SI-messages-js.po | 19 ++++++ misc/translator/po/sq-AL-messages-js.po | 17 ++++++ misc/translator/po/sr-Cyrl-messages-js.po | 19 ++++++ misc/translator/po/sv-SE-messages-js.po | 18 ++++++ misc/translator/po/sw-KE-messages-js.po | 17 ++++++ misc/translator/po/ta-LK-messages-js.po | 17 ++++++ misc/translator/po/ta-messages-js.po | 17 ++++++ misc/translator/po/tet-messages-js.po | 17 ++++++ misc/translator/po/th-TH-messages-js.po | 17 ++++++ misc/translator/po/tl-PH-messages-js.po | 17 ++++++ misc/translator/po/tr-TR-messages-js.po | 18 ++++++ misc/translator/po/tvl-messages-js.po | 17 ++++++ misc/translator/po/uk-UA-messages-js.po | 19 ++++++ misc/translator/po/ur-Arab-messages-js.po | 17 ++++++ misc/translator/po/vi-VN-messages-js.po | 18 ++++++ misc/translator/po/zh-Hans-CN-messages-js.po | 17 ++++++ misc/translator/po/zh-Hant-TW-messages-js.po | 17 ++++++ 87 files changed, 1551 insertions(+), 46 deletions(-) create mode 100644 misc/translator/po/am-Ethi-messages-js.po create mode 100644 misc/translator/po/ar-Arab-messages-js.po create mode 100644 misc/translator/po/as-IN-messages-js.po create mode 100644 misc/translator/po/az-AZ-messages-js.po create mode 100644 misc/translator/po/be-BY-messages-js.po create mode 100644 misc/translator/po/bg-Cyrl-messages-js.po create mode 100644 misc/translator/po/bn-IN-messages-js.po create mode 100644 misc/translator/po/ca-ES-messages-js.po create mode 100644 misc/translator/po/cs-CZ-messages-js.po create mode 100644 misc/translator/po/cy-GB-messages-js.po create mode 100644 misc/translator/po/da-DK-messages-js.po create mode 100644 misc/translator/po/de-CH-messages-js.po create mode 100644 misc/translator/po/de-DE-messages-js.po create mode 100644 misc/translator/po/dz-messages-js.po create mode 100644 misc/translator/po/el-GR-messages-js.po create mode 100644 misc/translator/po/en-GB-messages-js.po create mode 100644 misc/translator/po/en-NZ-messages-js.po create mode 100644 misc/translator/po/eo-messages-js.po create mode 100644 misc/translator/po/es-ES-messages-js.po create mode 100644 misc/translator/po/eu-messages-js.po create mode 100644 misc/translator/po/fa-Arab-messages-js.po create mode 100644 misc/translator/po/fi-FI-messages-js.po create mode 100644 misc/translator/po/fo-FO-messages-js.po create mode 100644 misc/translator/po/fr-CA-messages-js.po create mode 100644 misc/translator/po/fr-FR-messages-js.po create mode 100644 misc/translator/po/ga-messages-js.po create mode 100644 misc/translator/po/gd-messages-js.po create mode 100644 misc/translator/po/gl-messages-js.po create mode 100644 misc/translator/po/he-Hebr-messages-js.po create mode 100644 misc/translator/po/hi-messages-js.po create mode 100644 misc/translator/po/hr-HR-messages-js.po create mode 100644 misc/translator/po/hu-HU-messages-js.po create mode 100644 misc/translator/po/hy-Armn-messages-js.po create mode 100644 misc/translator/po/ia-messages-js.po create mode 100644 misc/translator/po/id-ID-messages-js.po create mode 100644 misc/translator/po/iq-CA-messages-js.po create mode 100644 misc/translator/po/is-IS-messages-js.po create mode 100644 misc/translator/po/it-IT-messages-js.po create mode 100644 misc/translator/po/iu-CA-messages-js.po create mode 100644 misc/translator/po/ja-Jpan-JP-messages-js.po create mode 100644 misc/translator/po/ka-messages-js.po create mode 100644 misc/translator/po/km-KH-messages-js.po create mode 100644 misc/translator/po/kn-Knda-messages-js.po create mode 100644 misc/translator/po/ko-Kore-KP-messages-js.po create mode 100644 misc/translator/po/ku-Arab-messages-js.po create mode 100644 misc/translator/po/lo-Laoo-messages-js.po create mode 100644 misc/translator/po/lv-messages-js.po create mode 100644 misc/translator/po/mi-NZ-messages-js.po create mode 100644 misc/translator/po/ml-messages-js.po create mode 100644 misc/translator/po/mon-messages-js.po create mode 100644 misc/translator/po/mr-messages-js.po create mode 100644 misc/translator/po/ms-MY-messages-js.po create mode 100644 misc/translator/po/my-messages-js.po create mode 100644 misc/translator/po/nb-NO-messages-js.po create mode 100644 misc/translator/po/ne-NE-messages-js.po create mode 100644 misc/translator/po/nl-BE-messages-js.po create mode 100644 misc/translator/po/nl-NL-messages-js.po create mode 100644 misc/translator/po/nn-NO-messages-js.po create mode 100644 misc/translator/po/oc-messages-js.po create mode 100644 misc/translator/po/pbr-messages-js.po create mode 100644 misc/translator/po/pl-PL-messages-js.po create mode 100644 misc/translator/po/prs-messages-js.po create mode 100644 misc/translator/po/pt-BR-messages-js.po create mode 100644 misc/translator/po/pt-PT-messages-js.po create mode 100644 misc/translator/po/ro-RO-messages-js.po create mode 100644 misc/translator/po/ru-RU-messages-js.po create mode 100644 misc/translator/po/rw-RW-messages-js.po create mode 100644 misc/translator/po/sd-PK-messages-js.po create mode 100644 misc/translator/po/sk-SK-messages-js.po create mode 100644 misc/translator/po/sl-SI-messages-js.po create mode 100644 misc/translator/po/sq-AL-messages-js.po create mode 100644 misc/translator/po/sr-Cyrl-messages-js.po create mode 100644 misc/translator/po/sv-SE-messages-js.po create mode 100644 misc/translator/po/sw-KE-messages-js.po create mode 100644 misc/translator/po/ta-LK-messages-js.po create mode 100644 misc/translator/po/ta-messages-js.po create mode 100644 misc/translator/po/tet-messages-js.po create mode 100644 misc/translator/po/th-TH-messages-js.po create mode 100644 misc/translator/po/tl-PH-messages-js.po create mode 100644 misc/translator/po/tr-TR-messages-js.po create mode 100644 misc/translator/po/tvl-messages-js.po create mode 100644 misc/translator/po/uk-UA-messages-js.po create mode 100644 misc/translator/po/ur-Arab-messages-js.po create mode 100644 misc/translator/po/vi-VN-messages-js.po create mode 100644 misc/translator/po/zh-Hans-CN-messages-js.po create mode 100644 misc/translator/po/zh-Hant-TW-messages-js.po hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 13 01:28:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Mar 2020 00:28:30 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-50-g710a372200 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 710a37220017025c039d64a06a307130bfdcae67 (commit) via fe86bf2b6c7a0afb8be0a0030f8013dd9f5d7f85 (commit) via 7535b5072329cc38ef7f0cef2616d51b289efb0b (commit) via aa8cdebe0c6b9b0dfb0819648e217553e675d2f5 (commit) via ed641c85571df0461b4f0cbf5a6ba2b3363a0b5d (commit) from b09ca43dec81209d08abf45d75e9e5dea9f4b907 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 710a37220017025c039d64a06a307130bfdcae67 Author: Jonathan Druart Date: Tue Nov 26 09:27:21 2019 +0100 Bug 24110: Do not html filter TT vars when dumped DumpTemplateVarsIntranet and DumpTemplateVarsOpac are devs tools to display the variables sent to the template. They should not be filtered otherwise it's getting complicate to read. For instance: $VAR1 = { var => val } Test plan: Turn DumpTemplateVarsIntranet on Go to the main page Show the source of the page Confirm that the variable are displayed as it and not filtered Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit fe86bf2b6c7a0afb8be0a0030f8013dd9f5d7f85 Author: Nick Clemens Date: Fri Jan 24 17:33:48 2020 +0000 Bug 24514: Add option to exclude title from patron-title.inc Without this patch sorting by patron name on the 'holds awaiting pickup' report sorted by title, surname, firstname. With this patch the list will sort by surname, firstname, ignoring the title. To test: - generate and capture a hold for a patron named "Mr. A A" - generate and capture a hold for a patron named "A A" - generste and capture a hold for patron named "Mr. B B" - generste and capture a hold for patron named "B B" - go to holds awaiting pickup - sort by patron name ascending - holds sort Mr. A, Mr. B, A, B - sort by patron name descending - holds sort B, A, Mr. B, Mr. A - APPLY PATCH - Reload holds awaiting pickup - Confirm holds sort on Surname Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 7535b5072329cc38ef7f0cef2616d51b289efb0b Author: Aleisha Amohia Date: Sun Feb 9 21:55:01 2020 +0000 Bug 18933: Allow OPAC messaging SMS number to be set to empty To test: 1) Ensure EnhancedMessagingPreferences is enabled and EnhancedMessagingPreferencesOPAC is set to Show. Set SMSSendDriver to Email 2) Log in to OPAC, go to your messaging tab 3) Set an SMS number if you havent already 4) Try to remove it (set to empty) 5) Notice that it says the number has been updated, but it has not been set to empty 6) Apply patch and refresh page 7) Attempt to set the number to empty 8) Confirm this is successful Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit aa8cdebe0c6b9b0dfb0819648e217553e675d2f5 Author: Jonathan Druart Date: Mon Dec 16 18:50:16 2019 +0100 Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ed641c85571df0461b4f0cbf5a6ba2b3363a0b5d Author: Jonathan Druart Date: Wed Feb 12 15:49:17 2020 +0100 Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled If the showLastPatron syspref is disabled, we should not store the 3 cookies we use for this feature. Test plan: 0/ Do not apply this patch 1/ Turn off showLastPatron 2/ Search for a patron, click on a result 3/ Open the cookie list of your browser => You see 3 cookies named lastborrowercard, lastborrowername, lastborrowernumber 4/ Remove them 5/ Apply the patch 6/ Reload the patron detail page => The 3 cookies are not created 7/ Turn the pref on 8/ Reload the patron detail page => The 3 cookies are created 9/ Eat one of them. QA note: it's a bit dirty, we should do that JS side, but staff-global.js is too widely used to make the change easy. Any other suggestions welcomed. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 8 +++++--- koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-open.inc | 3 ++- koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc | 1 + koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt | 4 +--- koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-open.inc | 3 ++- opac/opac-messaging.pl | 11 ++++------- 7 files changed, 16 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 13 01:41:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Mar 2020 00:41:34 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-59-g72cbcf7c4b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 72cbcf7c4b2d921721b520fd8e67d0c7d8c7f8e0 (commit) via 98bd5eaa9e967d490cd413129fbc11c2257e3b18 (commit) via c9ce2ed2f052cbe5691ab5757f945cb9f236f787 (commit) via 859604ed975bb0a09b38fbe1ae4f73631435945e (commit) via d54a0d81c51396d9a0f94a264fb33688894caebe (commit) via 091133983b116e2b5a330223404187482e5d5e79 (commit) via 25389561d124c759dac1b9565bb15cee48310566 (commit) via 492db0609ce93ac91573abc0cea48bc18d2f438a (commit) via d2a33f2eebbe2f41c84b272ad856fbcf8a68adfc (commit) from 710a37220017025c039d64a06a307130bfdcae67 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 72cbcf7c4b2d921721b520fd8e67d0c7d8c7f8e0 Author: Jonathan Druart Date: Sat Feb 16 11:46:08 2019 -0300 Bug 22245: Allow copy/move from and to control fields The JS conditions were wrong, we want to allow copy and move between control fields. Test plan: Create a new MARC modification template action using control fields. Confirm that you are allowed to copy/move a control field to another one Signed-off-by: Hayley Mapley Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 98bd5eaa9e967d490cd413129fbc11c2257e3b18 Author: Martin Renvoize Date: Tue Feb 18 18:32:02 2020 +0000 Bug 24666: (QA follow-up) Add missing filters Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c9ce2ed2f052cbe5691ab5757f945cb9f236f787 Author: Jonathan Druart Date: Mon Feb 17 14:39:50 2020 +0100 Bug 24666: Display not registered guarantors on the patron detail page There was no way to see the not registered guarantors apart of editing the patron. Test plan: - Create a patron with category type "Child" - Define a "guarantor surname" and/or "guarantor firstname" in the "Contact" block (the patron is not registered) - See the patron's detail page and notice that the info appear - Edit and add a registered guarantor - See the patron's detail page and notice that the 2 guarantors info appear Note that the relationship has been added. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 859604ed975bb0a09b38fbe1ae4f73631435945e Author: Katrin Fischer Date: Sun Nov 24 13:01:20 2019 +0100 Bug 5016: Fix some translation issues with English PDF order templates Changes made: - Instead of n° print no. - Market Identification => Market identification - GST => Tax To test: - Create at least 2 baskets with one or more orders - Create a basket group with those baskets - Print the PDF using - the 2 page layout - the 3 page layout - Verify that the changes made appear and everything looks correct Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d54a0d81c51396d9a0f94a264fb33688894caebe Author: Katrin Fischer Date: Sun Jan 12 03:55:41 2020 +0000 Bug 17221: (follow-up) Orphan comma in shelf browser This further improves the display if no location or no collection has been set. Example output: Browsing Centerville shelves, Collection: Non-fiction Also changes 'Collection code' to 'collection' and takes care of additional spaces before the comma. To test: - Make sure your OpacShelfBrowser pref is set to "Show" - Search for a record with items and callnumbers in your OPAC - "Browse shelf" - Navigate back and forth, verify the information showing on top of the list is correctly formatted - Try different combinations for the following prefs: - ShelfBrowserUsesCcode - ShelfBrowserUsesHomeBranch - ShelfBrowserUsesLocation - Verify the display is always nicely formatted Note: fixing capitalization here is tricky, as it also depends on what was displayed before. If you have no homebranch, you would want "Shelving...", if you have one we'd like "shelving...". Left as I found it for now. Signed-off-by: Katrin Fischer Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 091133983b116e2b5a330223404187482e5d5e79 Author: phette23 Date: Sun Jan 12 11:32:53 2020 +0100 Bug 17221: Remove orphan commas in shelf browser This patch adds more conditions to the shelf browser template such that the displayed text reads as a proper list no matter what combination of system preferences are utilized Sponsored-by: California College of the Arts Signed-off-by: Katrin Fischer Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 25389561d124c759dac1b9565bb15cee48310566 Author: Kyle M Hall Date: Tue Dec 3 11:03:18 2019 -0500 Bug 21944: Improve efficiency of code Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 492db0609ce93ac91573abc0cea48bc18d2f438a Author: Christopher Brannon Date: Tue Dec 4 16:38:34 2018 +0000 Bug 21944: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d2a33f2eebbe2f41c84b272ad856fbcf8a68adfc Author: Christopher Brannon Date: Thu Dec 13 00:08:54 2018 +0000 Bug 21944: Test for Circulation.pm Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 8 ++++++- C4/Reserves.pm | 26 ++++++++------------- Koha/pdfformat/layout2pages.pm | 2 +- Koha/pdfformat/layout3pages.pm | 4 ++-- .../prog/en/modules/members/moremember.tt | 9 ++++--- .../prog/js/marc_modification_templates.js | 4 ++-- koha-tmpl/intranet-tmpl/prog/pdf/layout2pages.odt | Bin 12728 -> 11630 bytes koha-tmpl/intranet-tmpl/prog/pdf/layout2pages.pdf | Bin 25887 -> 25264 bytes koha-tmpl/intranet-tmpl/prog/pdf/layout3pages.odt | Bin 13023 -> 11913 bytes koha-tmpl/intranet-tmpl/prog/pdf/layout3pages.pdf | Bin 27293 -> 26626 bytes .../bootstrap/en/includes/shelfbrowser.inc | 8 ++++--- t/db_dependent/Circulation.t | 14 ++++++++++- 12 files changed, 46 insertions(+), 29 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 13 01:59:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Mar 2020 00:59:28 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-68-g48f4383bda Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 48f4383bda8c9236ea130280cfb5e5cbf766a7e5 (commit) via 916dd8d7234f4613a06627cd43fe189e285624c2 (commit) via aab0258799f372731ec991dacb60a9f4d161126b (commit) via 4dd2445fd667294b9cf430f7a6986ea3ceb1cc05 (commit) via 8288f02c3722093d6d8dd6f00953efe3c542f360 (commit) via 3c45a6ac63b93fcaa67b2c2d529cbc95bd2a44da (commit) via 088a610682f1a1be3fd05b64c5080faa0ff7cfd7 (commit) via d78feb1d2fed87f2f38b4d4b57a3c0e5cff63b9d (commit) via d833b9f957b5b537dd831ad4d9296b6163db2ba9 (commit) from 72cbcf7c4b2d921721b520fd8e67d0c7d8c7f8e0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 48f4383bda8c9236ea130280cfb5e5cbf766a7e5 Author: Joy Nelson Date: Fri Mar 13 00:29:45 2020 +0000 Bug 21633: DBRev 19.11.03.003 Signed-off-by: Joy Nelson commit 916dd8d7234f4613a06627cd43fe189e285624c2 Author: Nick Clemens Date: Thu Jan 23 12:06:21 2020 +0000 Bug 21633: (follow-up) Cleanup other values for finesMode Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit aab0258799f372731ec991dacb60a9f4d161126b Author: Nick Clemens Date: Fri Jan 3 14:56:53 2020 +0000 Bug 21633: Remove finesMode 'test' Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 4dd2445fd667294b9cf430f7a6986ea3ceb1cc05 Author: Nick Clemens Date: Fri Jan 31 14:18:24 2020 +0000 Bug 24094: Strip trailing spaces and punctuation from authority headings Both when searching for and creating new authorities we need to remove punctuation that exists in the bibliographic record but does not belong in the authority record. For example, a series with a volume contains a semicolon in the bib record, however, this should not be passed to the authority as the volume is not included in the authority record. To test: 1 - Set AutoCreateAuthorities to 'generate' 2 - Set BiblioAddsAuthorities to 'true' 3 - Set CatalogModuleRelink to 'Do' 4 - Find or create a record with: a 100 field with a subfield e preceded by a comma: 100 $aBoring, M. Eugene M ,$e author an 830 field with a volume preceded by a semicolon: 650$aLord of the rings ;$v 3. 5 - Save the records and check the links 6 - Note punctuation is passed through 7 - Save again, auth records are created again 8 - Apply patch 9 - Save again, new auth records are created again 10 - Check the records, punctuation has been removed 11 - Save again, no more records created. Signed-off-by: Myka Kennedy Stephens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8288f02c3722093d6d8dd6f00953efe3c542f360 Author: Nick Clemens Date: Fri Jan 31 14:18:14 2020 +0000 Bug 24094: Unit tests Signed-off-by: Myka Kennedy Stephens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 3c45a6ac63b93fcaa67b2c2d529cbc95bd2a44da Author: Jonathan Druart Date: Thu Feb 13 17:01:06 2020 +0100 Bug 24494: Make the regex more exact Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 088a610682f1a1be3fd05b64c5080faa0ff7cfd7 Author: Victor Grousset/tuxayo Date: Thu Jan 23 15:55:18 2020 +0100 Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules == Test plan == - work with SCSS (just recompile it if you never did) - https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS - now you have a node_modules directory - prove -r t/00-valid-xml.t - it should fail on files in node_modules - apply this patch - prove -r t/00-valid-xml.t - it should work - sabotage a legitimate XML file, like etc/SIPconfig.xml - prove -r t/00-valid-xml.t - it should fail, good the test is still useful - undo the sabotage Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d78feb1d2fed87f2f38b4d4b57a3c0e5cff63b9d Author: Jonathan Druart Date: Fri Feb 14 11:44:44 2020 +0100 Bug 19791: Keep user in circ when viewing patron's logs When a librarian is viewing the log for a given patron (tab "modification log" from the circulation module), the "object" and "modules" parameter can be modified. It does not make sense, we should stay in the circulation module and avoid those fields to be modified. Test plan: - Modify several patrons (in order to have several modification logs) - Go to the modification log tab of one of them - Notice that the "Object" input is not a "Borrowernumber" labelled input and that you cannot modify it. Also notice that the "modules" is hidden. - Go to the log viewer tool and notice that the view is still the same as before this patch. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d833b9f957b5b537dd831ad4d9296b6163db2ba9 Author: Jonathan Druart Date: Mon Nov 18 11:29:46 2019 +0100 Bug 24051: Remove "search( %condition ) is deprecated" warning from batchMod.pl Test plan: Go to Home › Tools › Batch item modification Insert barcodes and continue => Without this patch you will get warning in the log => With this patch applied you warning does no longer appear Confirm that the number of holds is correct Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 24 ++++++----- C4/Heading/MARC21.pm | 2 +- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 14 +++++++ .../en/modules/admin/preferences/circulation.pref | 1 - .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 47 +++++++++++++--------- misc/cronjobs/fines.pl | 2 +- misc/cronjobs/staticfines.pl | 1 - t/00-valid-xml.t | 1 + t/db_dependent/Biblio.t | 24 ++++++++++- t/db_dependent/Heading_MARC21.t | 8 +++- tools/batchMod.pl | 2 +- 13 files changed, 93 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 13 02:11:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Mar 2020 01:11:59 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-69-g82a84bfbde Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 82a84bfbde7e46a67b02d7fbb8a70ade3972fc41 (commit) from 48f4383bda8c9236ea130280cfb5e5cbf766a7e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 82a84bfbde7e46a67b02d7fbb8a70ade3972fc41 Author: Nick Clemens Date: Tue Jan 14 13:00:03 2020 +0000 Bug 24269: Adjust C4::Heading to generate headings from auth tags To test: 1 - Be using Elasticsearch 2 - Check that field 150 is mapped to 'Match-heading' or add it (the subfields don't matter) 3 - Add a topic term authority record like "150 $aCats$vFiction" 4 - Add a 650 with $aCats and $vFiction and $e depicted to a bibliographic record 5 - Run the linker for the bib perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v 6 - Confirm the record is not correctly linked to the record 7 - Apply patch 8 - Reindex authorities for ES perl misc/search_tools/rebuild_elasticsearch.pl -v -d -a 9 - Run the linker and confirm record is correctly linked perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 4 +- C4/Heading.pm | 34 +++++++------- C4/Heading/MARC21.pm | 69 ++++++++++++++++++++++++---- C4/Heading/UNIMARC.pm | 8 ++-- C4/Linker/Default.pm | 2 +- Koha/SearchEngine/Elasticsearch.pm | 16 ++++++- t/Koha/SearchEngine/Elasticsearch.t | 92 ++++++++++++++++++++++++++++++++++++- t/db_dependent/Heading.t | 33 +++++++------ t/db_dependent/Heading_MARC21.t | 4 +- t/db_dependent/Linker_Default.t | 6 +-- t/db_dependent/Linker_FirstMatch.t | 2 +- 11 files changed, 214 insertions(+), 56 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 13 02:36:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Mar 2020 01:36:46 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-74-gcec049bf80 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via cec049bf80c05e6c32d29d935f6cd1421247aaac (commit) via 2bcb1f0398214ad2dd3ef65019ecd98309341536 (commit) via 5e32b20c6a79e50af488bf6459eb67152dca207a (commit) via 382372edbb9082616d53231d2c18ce82f081e0f7 (commit) via 44f733ee63cd5bcb18d21e7811907fe4de027e46 (commit) from 82a84bfbde7e46a67b02d7fbb8a70ade3972fc41 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cec049bf80c05e6c32d29d935f6cd1421247aaac Author: Joy Nelson Date: Fri Mar 13 01:10:09 2020 +0000 Bug 24532: DBRev 19.11.03.004 Signed-off-by: Joy Nelson commit 2bcb1f0398214ad2dd3ef65019ecd98309341536 Author: Martin Renvoize Date: Thu Jan 30 14:39:22 2020 +0000 Bug 24532: Fix misidentified credit_types from bug 23049 Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5e32b20c6a79e50af488bf6459eb67152dca207a Author: Martin Renvoize Date: Thu Jan 30 13:19:37 2020 +0000 Bug 24532: Fix original DB update for bug 23049 Pathalogical cases of Payments and Writeoffs being converted to debits are identified during the DB update for bug 23049, but we are not correctly limiting to those types accountlines when subsequently populating the debit_type field. Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 382372edbb9082616d53231d2c18ce82f081e0f7 Author: David Cook Date: Wed Feb 19 02:07:30 2020 +0000 Bug 24538: Handle Net::Netmask parser errors This patch switches from the new() to new2() constructor, which will return an undef value when it fails to parse a value. This patch warns on parser failures, but otherwise silently drops the invalid value, and returns objects for any valid input it can parse. This way one mistake won't disable the whole feature. To test: 1. Run the unit test t/Koha/Middlware/RealIP.t Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 44f733ee63cd5bcb18d21e7811907fe4de027e46 Author: David Cook Date: Wed Feb 19 02:05:07 2020 +0000 Bug 24538: Add unit tests for Koha::Middleware::RealIP This patch adds some unit tests for Koha::Middleware::RealIP Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Middleware/RealIP.pm | 11 +++- installer/data/mysql/updatedatabase.pl | 46 ++++++++++++++++- t/Koha/Middlware/RealIP.t | 94 ++++++++++++++++++++++++++++++++++ 4 files changed, 150 insertions(+), 3 deletions(-) create mode 100644 t/Koha/Middlware/RealIP.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 13 02:47:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Mar 2020 01:47:18 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.03-79-gaf0441d613 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via af0441d6139d6bf7bc1f5fc70f2ff869cac34b37 (commit) via b8b8ca7b2cdfa7ef55b552d4fcc7fee4bf04bf53 (commit) via 9ce7bc002599fcd27208029fbeef75933ff28dfe (commit) via addc372890f60960622dff14e37b78a2f101750d (commit) via e1f92e91dfdd1d3aeed4b4642969b3246dc92832 (commit) from cec049bf80c05e6c32d29d935f6cd1421247aaac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit af0441d6139d6bf7bc1f5fc70f2ff869cac34b37 Author: Martin Renvoize Date: Fri Jan 24 12:23:39 2020 +0000 Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b8b8ca7b2cdfa7ef55b552d4fcc7fee4bf04bf53 Author: Martin Renvoize Date: Wed Nov 20 16:01:56 2019 +0000 Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 9ce7bc002599fcd27208029fbeef75933ff28dfe Author: David Cook Date: Tue Feb 18 00:59:05 2020 +0000 Bug 24676: Remove

    typo in opac-auth.tt This patch removes some trivial invalid HTML from opac-auth.tt Test plan: 1. Apply patch 2. As an unauthenticated user, try to place a hold on a search result e.g. http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29 3. View source or use an inspector to see there is no

    block between and
    Signed-off-by: Sally Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit addc372890f60960622dff14e37b78a2f101750d Author: Jonathan Druart Date: Fri Feb 21 14:35:30 2020 +0100 Bug 17896: Remove duplicated use statements and remove uneeded '&' Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e1f92e91dfdd1d3aeed4b4642969b3246dc92832 Author: Nick Clemens Date: Fri Feb 21 12:56:53 2020 +0000 Bug 17896: load BakerTaylor module with use We are incinsistent here, Amazon and Syndetics module are always loaeded in some places BakerTaylor is conditional everywhere, and causes issues under plack For simplicity sake I think we should just load this (small) module where it might be needed To test: 1 - Disable Baker and Taylor images 2 - Restart plack 3 - Visit opac-readingrecord, opac-detail, opac-search, opac-shelves, opac-user Log in to opac Virew your reading history Make/view a list Search the catalog Look at an individual title 4 - Enable BakerTaylorEnabled If you don't have Baker and Taylor credentials, simply fudge them with bad data and enable 5 - Repeat steps above, in the word of Joubu "Kaboom" 6 - Apply patch 7 - Repeat 1-4 8 - You shoudl be able to load all the pages after enabling the pref Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/members/paycollect.tt | 31 +++++++++++++++++----- .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 1 - members/paycollect.pl | 8 +++++- opac/opac-detail.pl | 8 +----- opac/opac-readingrecord.pl | 8 +----- opac/opac-search.pl | 8 +----- opac/opac-shelves.pl | 1 + opac/opac-user.pl | 8 +----- 8 files changed, 36 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 16 01:34:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 16 Mar 2020 00:34:32 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.14-4-ga230878b6f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via a230878b6f3d3afa5d7f33c9d816bd6272c5b1a1 (commit) from 72a4f68197256436274472680d6ebd61092bdaaf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a230878b6f3d3afa5d7f33c9d816bd6272c5b1a1 Author: Owen Leonard Date: Wed Nov 20 20:04:10 2019 +0000 Bug 21296: suspend hold ignores system preference on intranet This patch modifies the DataTable configuration for the table of holds which displays under the "Holds" tab on the patron's checkout and details pages. A variable is now defined in the JavaScript with the value of the "SuspendHoldsIntranet" system preference. This variable is passed to the DataTable configuration to determine whether the column is visible or not. One of the changes made in this patch moves a