[koha-commits] main Koha release repository branch master updated. v19.11.00-1038-gf1c93e88d4

Fri Mar 6 16:28:42 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f1c93e88d4d56bcef05929de70fc86115cbdc463 (commit)
       via  9c2a74a63861543d95c83b2f63a9dc2aeaafd965 (commit)
       via  deb77ffe3d3d76c0863f287f1a6f3697c9fa6949 (commit)
       via  a7de3ebf8b9e834bb00c2fe07464657f2e1d1b9b (commit)
       via  7da21c6a10f944a21c96d0ce9a9d4494a4ae1560 (commit)
      from  348a04e00f57e15dc3f1ef320c673961b47ca936 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f1c93e88d4d56bcef05929de70fc86115cbdc463
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Dec 17 10:45:11 2019 +0100

    Bug 24219: Preserve sort order when returning to result list

    There is a mismatch between sort_cgi, sort and sort_by variables.

     * sort_cgi
    I did not find relevant occurrences of sort_cgi in the git log of both
    search.pl and results.tt. So it seems that it never worked correctly.
     * sort
    It is the JS variable use in browser.js
     * sort_by is the search.pl parameter to set the sort_by option

    Test plan:
    1. Perform a search in the staff client
    2. Change the sort order to something different (try Author A-Z)
    3. Click on a result to view the record
    4. Click on "Results" button on left side to return to result list
    => Without this patch the result list is sorted by relevancy
    => With this patch applied the Author A-Z is kept

    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9c2a74a63861543d95c83b2f63a9dc2aeaafd965
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Feb 18 16:13:11 2020 +0100

    Bug 23384: Fix use statement order for ArticleRequest::Status

    Koha::ArticleRequest is used by Koha::ArticleRequests so
    Koha::ArticleRequest::Status should not be needed in
    Koha::ArticleRequest.
    Also Koha::ArticleRequest::Status must be loaded before
    Koha::ArticleRequest

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit deb77ffe3d3d76c0863f287f1a6f3697c9fa6949
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Mar 6 11:13:15 2020 +0000

    Bug 24760: (follow-up) Add a neighboring test messsage

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a7de3ebf8b9e834bb00c2fe07464657f2e1d1b9b
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Feb 28 14:22:34 2020 +0100

    Bug 24760: Use C4::BackgroundJob->fetch in tests

    Starting with YAML 1.30 and YAML::Syck 1.32, these modules don't bless
    loaded objects by default. This is not a problem as
    C4::BackgroundJob->fetch bless them anyway.

    So, instead of testing what's in the session, test the result of
    C4::BackgroundJob->fetch, which is what's used everywhere else

    Test plan:
    1. Install latest version of YAML::Syck (or YAML if YAML::Syck is not
    installed)
    2. prove t/db_dependent/BackgroundJob.t => should FAIL
    3. Apply patch
    4. prove t/db_dependent/BackgroundJob.t => should PASS
    5. Verify that background jobs are still working (for instance,
    tools/batchMod.pl)

    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7da21c6a10f944a21c96d0ce9a9d4494a4ae1560
Author: David Gustafsson <david.gustafsson at ub.gu.se>
Date:   Tue Mar 3 14:32:31 2020 +0100

    Bug 24788: Remove autoloaded column accessors in Koha::Object->store

    Columns are accessed as methods, relying on AUTOLOAD, in
    Koha::Object->store. This could be a source of strange bugs
    if a column name clashes with an existing method name.

    To test:

    1) Apply patches for Bug 14957
    2) Follow the testing instructions, when saving a new marc rule and
    error is thrown.
    3) Apply patch
    4) Try saving a new rule once again, this should now work

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/ArticleRequest.pm                                     |  1 -
 Koha/ArticleRequests.pm                                    |  2 +-
 Koha/Object.pm                                             | 14 ++++++++------
 Koha/Patron.pm                                             |  1 +
 koha-tmpl/intranet-tmpl/js/browser.js                      |  6 +++---
 .../intranet-tmpl/prog/en/modules/catalogue/results.tt     |  1 +
 koha-tmpl/intranet-tmpl/prog/js/pages/results.js           |  6 +++---
 t/db_dependent/BackgroundJob.t                             | 12 +++++-------
 8 files changed, 22 insertions(+), 21 deletions(-)

hooks/post-receive
-- 
main Koha release repository