[koha-commits] main Koha release repository branch master updated. v19.11.00-1090-g8b6fb99c45

Tue Mar 10 13:06:11 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  8b6fb99c459a51e9da99d26361307b8c6e9600cf (commit)
       via  65f48c02bc1e2daf9f85a91d08003cc96dcbf98f (commit)
       via  9a29f56a90ee4960359a1583d0a5b665b2670ca6 (commit)
       via  db0b620c5f7d69f1830321d7f2c5885aa8ffff8f (commit)
       via  b49656fa3196deb0e22e1d3a9a02bd002c196863 (commit)
       via  3cd9d847f7316302e545e38d2579eaeac4f88dc8 (commit)
       via  00d375b26543ab4a55acf695705f886fa1de6cce (commit)
       via  39924b6769aa18de54a02196f8bb79bbc964f96a (commit)
       via  3896eaa2bb64a667b920100d7516225cee242ad1 (commit)
       via  934790769fa195f41d2ce45023d2746e2e62a71e (commit)
       via  ae885b99f0f3fd1ec7cd6a38e200582b4db3c6d8 (commit)
       via  ccbfb6338ef4ae944365190f48344c4b20b33832 (commit)
       via  47895a1a23ce888e6f4035a144a7ed76787b55c8 (commit)
       via  04b473261ac1517062668b8268234beb191cd14a (commit)
      from  7b25bb76444afb06d3459423ca65314e2145c8a9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8b6fb99c459a51e9da99d26361307b8c6e9600cf
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Mar 10 11:39:44 2020 +0000

    Bug 23112: Compiled CSS

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 65f48c02bc1e2daf9f85a91d08003cc96dcbf98f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Mar 10 11:38:48 2020 +0000

    Bug 23112: DBRev 19.12.00.038

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9a29f56a90ee4960359a1583d0a5b665b2670ca6
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Mar 6 11:35:05 2020 +0000

    Bug 23112: (QA follow-up) Clean up tests, catch warnings

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit db0b620c5f7d69f1830321d7f2c5885aa8ffff8f
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Fri Mar 6 09:33:16 2020 +0000

    Bug 23112: (follow-up) Unit test fixes

    As requested by Nick, fixes unit tests and added a test for the new
    Koha::Illrequest::biblio method

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b49656fa3196deb0e22e1d3a9a02bd002c196863
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Thu Mar 5 09:27:32 2020 +0000

    Bug 23112: (follow-up) Conditionally prevent checkout

    As mentioned by Nick in comment #69, the checkout button displays even
    for requests without a biblio attached (such as chapters). This patch
    fixes that.

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3cd9d847f7316302e545e38d2579eaeac4f88dc8
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Mar 4 11:52:11 2020 +0000

    Bug 23112: (QA follow-up) Fix database update, add filters, remove tabs

    Looks like the atomicupdate and sysprefs.sql changes were lost at some point.

    Don't forget to run QA tools on your patches before submitting

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 00d375b26543ab4a55acf695705f886fa1de6cce
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Tue Jan 7 10:16:58 2020 +0000

    Bug 23112: (follow-up) Fix test as per feedback

    As per comment #48

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 39924b6769aa18de54a02196f8bb79bbc964f96a
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Mon Jan 6 12:04:53 2020 +0000

    Bug 23112: (follow-up) Address QA feedback

    As per comment #46

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3896eaa2bb64a667b920100d7516225cee242ad1
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Thu Oct 10 15:41:58 2019 +0100

    Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues

    In response to the problem Magnus was experiencing in comment #28 & #29
    we now call GetAuthorisedValues by it's full path

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 934790769fa195f41d2ce45023d2746e2e62a71e
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Tue Jul 30 14:54:53 2019 +0100

    Bug 23112: Add unit tests

    This patch adds unit test for the new Koha::Illrequest::check_out method

    Sponsored-by: Loughborough University
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ae885b99f0f3fd1ec7cd6a38e200582b4db3c6d8
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Mon Jul 29 09:10:04 2019 +0100

    Bug 23112: Update request status on return

    This patch updates a request's status to RET upon return

    Sponsored-by: Loughborough University
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ccbfb6338ef4ae944365190f48344c4b20b33832
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Mon Jul 29 09:08:41 2019 +0100

    Bug 23112: Add permission checks

    We only want the ILL circulation functionality to be available if the
    appropriate syspref and perm are available, this patch adds those
    checks.

    Sponsored-by: Loughborough University
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 47895a1a23ce888e6f4035a144a7ed76787b55c8
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Thu Jul 25 13:46:12 2019 +0100

    Bug 23112: Add circulation to ILL requests

    This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical  user. A due date can be specified, but if not circ rules are used.

    Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added

    This development has been carried out according to the originally stated requirements of the customer that sponsored it, detailed here: https://wiki.koha-community.org/wiki/ILL_Circulation_RFC

    Test plan:

    1. Ensure the FreeForm ILL backend is available
    2. Enable the "CirculateILL" syspref
    3. Ensure you have a statistical patron category defined (patron category type "Statistical")
    4. Ensure you have at least one patron in your statistical patron category
    5. Create a new FreeForm request (make a note of the library you select when creating it)
    6. Mark the new request as confirmed by clicking the "Confirm request" button on the "Manage ILL request" page
    7. TEST: Observe that a "Check out" button is now displayed in the request toolbar
    8. Click the "Check out" button in the "Manage ILL request" page
    9. In the "Issue requested item to..." screen:
      a. Do not select a statistical patron at this time
      b. You can at this point choose an item type, this will determine the type of the item that will be created for this request
      c. TEST: Observe that the default selected "Library" matches that that was defined when creating the request
      d. Do not select a due date at this time
    10. Click "Submit"
    11. TEST: Observe that the "Item checked out" screen displays, issued to the requesting patron with a due date corresponding to appropriate circ rules
    12. Click "Return to request"
    13. TEST: Observe that the request's status is now "Checked out"
    14. Click the "Bibliographic record ID" link
    15. TEST: Observe that the bibliographic record now has one item attached to it which is checked out
    16. TEST: Observe that the item barcode is "ILL-" + the ILL request ID
    17. Return to step 5., however, this time select a statistical patron and test that the item use is recorded and the item is not issued
    18. Return to step 5., however, this time manually select a due date and test that the item's due date is set correctly on check out
    19. Check in the item
    20. TEST: Observe that the request's status is updated to "Returned to library"
    21. Now implement a restriction on the patron (perhaps a fine) which would prevent them from checking out an item
    22. Return to step 5. follow the instructions to step 10.
    23. TEST: Observe that a banner is displayed at the top of the screen informing you that there was a problem checking the item out, containing a link to the patron's account page
    24. Resolve the problem with the patron's account
    25. Return to step 8.
    26. TEST: Observe that the item is now successfully checked out
    27. Disable the "CirculateILL" syspref
    28. Return to step 5. at step 7. Observe that the "Check out" button is NOT displayed

    Sponsored-by: Loughborough University
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 04b473261ac1517062668b8268234beb191cd14a
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Fri Jul 26 10:42:32 2019 +0100

    Bug 23112: Add CirculateILL syspref

    Sponsored-by: Loughborough University
    Signed-off-by: Chris Walton <C.J.Walton at lboro.ac.uk>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |  10 +
 Koha.pm                                            |   2 +-
 Koha/Illrequest.pm                                 | 253 ++++++++++++++++++++-
 Koha/Illrequest/Logger.pm                          |   2 +-
 ill/ill-requests.pl                                |   8 +
 installer/data/mysql/sysprefs.sql                  |   1 +
 installer/data/mysql/updatedatabase.pl             |   7 +
 .../intranet-tmpl/prog/css/src/staff-global.scss   |   4 +
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |   2 +-
 .../en/modules/admin/preferences/circulation.pref  |   7 +
 .../prog/en/modules/ill/ill-requests.tt            | 185 +++++++++++++++
 t/db_dependent/Illrequests.t                       | 195 ++++++++++++++--
 12 files changed, 657 insertions(+), 19 deletions(-)

hooks/post-receive
-- 
main Koha release repository