[koha-commits] main Koha release repository branch master updated. v19.11.00-1141-g4c186a3e25
Git repo owner
gitmaster at git.koha-community.org
Mon Mar 16 16:22:10 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 4c186a3e25efb174d54b5ca6e5d6599979bcd568 (commit)
via a0c872992f41977f3d3590eac08822cad51e42dc (commit)
via e0483bd6e244fe81a858ad3e22cbd92fe2a83672 (commit)
via f4f841fd8ce5e21c1c84dba21dace6081451fa8b (commit)
via 8f9aedaf1d0d6a381293265b0c8a691a12fc1258 (commit)
via 1d26fb3a9dcaa2c40abd95f3d454973865194cc8 (commit)
via de07356028d5b98af3a7cd7cbae02a7ad6402a43 (commit)
via 0547ad34dfe01ca7d7660df59e29bc30fdf3cf1d (commit)
from 6c3a2b474806d1499780966bdb35c0ddabc609d0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 4c186a3e25efb174d54b5ca6e5d6599979bcd568
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Mar 2 17:35:53 2020 +0300
Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a0c872992f41977f3d3590eac08822cad51e42dc
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Mar 2 17:27:10 2020 +0300
Bug 24776: Remove Borrowers.IsDebarred call
Borrowers Template Toolkit plugin contains method IsDebarred that can be directly called from Koha::Patron object.
Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron".
Test plan :
1) Enable system preference SpecifyReturnDate
2) For a patron without restriction create a checkout
3) Create a manual restriction to debarre patron
4) Go to return page and click on "Checkin settings"
5) Specify a date in the past, barcode and click "Check in"
6) You see message "Jon Doe is restricted. Please verify this patron should still be restricted."
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e0483bd6e244fe81a858ad3e22cbd92fe2a83672
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Mar 2 17:18:34 2020 +0300
Bug 24776: Remove Borrowers.HasOverdues call
Borrowers Template Toolkit plugin contains method HasOverdues that can be directly called from Koha::Patron object.
Test plan :
1) Go to circulation page of a patron with overdues
2) Click on print button
3) You see "Print overdues"
4) Go to circulation page of a patron without overdues
5) Click on print button
6) You don't see "Print overdues"
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f4f841fd8ce5e21c1c84dba21dace6081451fa8b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 16 13:01:04 2020 +0100
Bug 24827: Add a test
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8f9aedaf1d0d6a381293265b0c8a691a12fc1258
Author: Andreas Roussos <a.roussos at dataly.gr>
Date: Sun Mar 15 08:43:25 2020 +0100
Bug 24827: Specify UTF-8 as encoding in new_from_xml()
The MARC preview of staged records fails when a staged record contains
items with UTF-8 characters (see attached screenshots). That's because
in EmbedItemsInImportBiblio() the call to MARC::Record->new_from_xml()
does not explicitly specify 'UTF-8' as the optional encoding to use.
This patch fixes that.
Test plan (in a MARC21 instance):
0) Stage for import the test record attached to this bug report (make
sure that 'Check for embedded item record data?' is set to 'Yes'),
then go to Home > Tools > Manage staged MARC records and click on
the filename you've just staged.
1) In the 'Citation' column, click on the hyperlink to launch the MARC
preview -- notice how it fails to produce any output apart from the
modal heading.
2) Apply the patch, and restart Plack if necessary.
3) Re-launch the MARC preview: this time the output should include the
whole record, including the embedded item data in field 952.
4) Run the unit tests to ensure nothing was broken inadvertently:
$ prove t
$ prove xt
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 1d26fb3a9dcaa2c40abd95f3d454973865194cc8
Author: Andreas Roussos <a.roussos at dataly.gr>
Date: Sun Mar 15 08:34:52 2020 +0100
Bug 24827: Standardise on 'UTF-8' as the encoding name
This patch standardises the encoding name used in direct calls
to new_from_xml() to 'UTF-8' instead of 'utf8' or 'utf-8'.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit de07356028d5b98af3a7cd7cbae02a7ad6402a43
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Mar 13 12:03:03 2020 -0300
Bug 24862: Handle annonymous sessions gracefuly
This patch introduces code to detect (cookie) annonymous sessions and
act as expected.
Right now, as check_cookie_auth is not passed the required permissions
(because there aren't always required permissions, and the code to check
permissions is shared with other authentication mechanisms) it returns
'ok' and the session id. This use case was overlooked when this was
coded, and yeilds unexpected error codes (500) when the user logs out
and the annonymous session cookie is used to hit the API. The end result
doesn't pose any security issue (i.e. the resource access is rejected)
but the returned error code is not correct and should be fixed.
This patch verifies for an anonymous session (and avoids querying the
corresponding patron) and then verifies if there is an authorization
config on the route and if the patron object is defined.
To test:
1. Apply the tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail, 500 instead of the expected 401
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Repeat the original 'steps to reproduce' from the bug report using
the browser
=> SUCCESS: Problem solved!
6. Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0547ad34dfe01ca7d7660df59e29bc30fdf3cf1d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Mar 13 11:44:03 2020 -0300
Bug 24862: Regression tests
This patch introduces tests for the expected behaviour on API routes
that expect a logged in user, but the request is made with an anonymous
session cookie.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail because the situation is not handled correctly in
the code
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 2 +-
C4/ImportBatch.pm | 2 +-
Koha/Biblio/Metadata.pm | 2 +-
Koha/BiblioUtils/Iterator.pm | 2 +-
Koha/REST/V1/Auth.pm | 16 ++++--
Koha/Template/Plugin/Borrowers.pm | 60 ----------------------
.../prog/en/includes/members-toolbar.inc | 3 +-
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 7 ++-
misc/batchRebuildBiblioTables.pl | 2 +-
misc/migration_tools/build_oai_sets.pl | 2 +-
opac/opac-readingrecord.pl | 2 +-
svc/bib | 2 +-
svc/import_bib | 2 +-
svc/new_bib | 2 +-
t/db_dependent/ImportBatch.t | 7 ++-
.../Koha/Z3950Responder/GenericSession.t | 8 +--
t/db_dependent/Koha/Z3950Responder/ZebraSession.t | 4 +-
.../api/v1/auth_authenticate_api_request.t | 21 +++++++-
18 files changed, 58 insertions(+), 88 deletions(-)
delete mode 100644 Koha/Template/Plugin/Borrowers.pm
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list