[koha-commits] main Koha release repository branch master updated. v19.11.00-1291-ge6d255b5e5
Git repo owner
gitmaster at git.koha-community.org
Mon Mar 23 10:52:45 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e6d255b5e50b141caec6aad60f5dd440ba4af02f (commit)
via 6c9cc168bae98d70153b1b589d13a7c684cd059f (commit)
via a881984413d8a09f59b064c9484f0d59533a923f (commit)
via 8170645f84be2b1f4c8e527258e58117ae2e0593 (commit)
via 34cca6a775abed84c2978b9ebd38bac56ae6a82a (commit)
via 62852241430b9444acd600498fc51912f36a90e7 (commit)
via a494bb1b49d0ec91b0f4a7edb44f7db6a435205f (commit)
via 974caa4304358423c08b9e2ea784ea83af2d09c1 (commit)
via de9ce93cf284aa32f8c5c527387949ebc79cc4ea (commit)
via 57eb6e42265a830aabb01f5de0bcab49bd090356 (commit)
via 794e8f992eee39641ec83beb83c140c6f7df4814 (commit)
via f70a738bca1782e7a90ef217473c2d50e335e3e4 (commit)
via cc6f25fec44273ed1407c910544af04c4700817e (commit)
via 18555f244ad0bbb0526e58cb26993161d9fd07e0 (commit)
via f76a75a3d3b8e6c99d5dcd687580778364571c14 (commit)
via 22f8584eadd2ace33f296f9cee1409ed6608e12b (commit)
via befc3f19f7d28dd3e92f719274d7e277e1a15fff (commit)
via fce29fb77d61ff7c006874b22ae7a00adb80cf34 (commit)
via bef6c36156a3e732c294d096169eb58682912e6b (commit)
via eeaf0b19e08e96293be1bf663015e7138d80e69c (commit)
via 4bce8c68fec3d940a053b647cfd629cf56c134c1 (commit)
via 2088b6857e9dd0d41acb53582897703586b7116d (commit)
via 2677da8f17fdf5a7f505770a2dc9935e55a3e73c (commit)
via a3687711b075f64e1e5f1fe31c6adad664679e42 (commit)
via b844b19dfc9dacea4e6b27357844f731c6a389e3 (commit)
via fc09b0d491b17447c9e3bdfe67c3f7b870405b9a (commit)
via 6ae8919e9230b2327bbc690bfbce89c1c4c67ad5 (commit)
via 516e76d1b53001a1be2f765e71d02b63ac9d85fb (commit)
via 7ec06a1ae8466b5027535fb3d40ab9618bfd3a65 (commit)
via 7d35052a14df66e9c5fe5d70378d36a6b1edb94d (commit)
via df520d2d6288bfbc9acac59c90a28ebe343a5390 (commit)
via bbb504c86f5ca0a474365d4839177412f415c4ee (commit)
via 0c8d8e867b18b61f39381d2061cd2124fe1c5ed3 (commit)
via 488a6f98a6b7a1527ed801f4eef21013f8a2bbf9 (commit)
via 02134d7604a6fc08b88046fde87b6c909de04353 (commit)
via 2075a22ed3c71196002dd8da28a061f791baf393 (commit)
via 9b33b8babdfe288ef1f436bdfc4a1ea5cc5629da (commit)
via 150b835ab3b57c05b043c0b8d317f9dcb75b6d58 (commit)
via 826eda128e98f39e989a7da3af92e7f8b500eb75 (commit)
from fcaed6ef24084da54d9d91c09072ff04d0070ef2 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e6d255b5e50b141caec6aad60f5dd440ba4af02f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 20 15:15:17 2020 +0100
Bug 23463: Fix items.cn_sort vs cn_sort
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6c9cc168bae98d70153b1b589d13a7c684cd059f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 16 14:56:08 2020 +0100
Bug 23463: (follow-up 2) Fix timestamp default value
Removing previous change, again.
But this time in Object.pm
It fixes t/db_dependent/Koha/Object.t and t/db_dependent/Koha/Item.t is
still passing.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a881984413d8a09f59b064c9484f0d59533a923f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 16 14:51:06 2020 +0100
Bug 23463: Use new method Koha::Object->set_or_blank
This patch fixes an issue when editing items.
* The issue
Cannot blank a subfield when editing an item.
If you have an item with itemcallnumber=42, then edit it, blank it and
save. The itemcallnumber is still 42
* Why? (line numbers from https://gitlab.com/joubu/Koha/-/tree/bug_23463)
additem (and other item's edition forms) receives a list of tags,
subfields and values, generates a MARC::Record::XML then calls
ModItemFromMarc:
717 my $itemtosave=MARC::Record::new_from_xml($xml, 'UTF-8');
727 my $newitem = ModItemFromMarc($itemtosave, $biblionumber,
$itemnumber);
And ModItemFromMarc:
282 my $item = TransformMarcToKoha( $localitemmarc,
$frameworkcode, 'items' );
283 $item->{cn_source} = delete $item->{'items.cn_source'}; #
Because of C4::Biblio::_disambiguate
284 $item_object->set($item);
ModItemFromMarc never knows that the field has been blank.
Prior to bug 23463 we had a map of default values, and ModItemFromMarc
was doing:
426 my $item = TransformMarcToKoha( $localitemmarc,
$frameworkcode, 'items' );
427 my $default_values = _build_default_values_for_mod_marc();
428 foreach my $item_field ( keys %$default_values ) {
429 $item->{$item_field} = $default_values->{$item_field}
430 unless exists $item->{$item_field};
431 }
I do not want to reinsert that list of default values.
Here I wrote a generic method in Koha::Object to set the value passed in parameter,
or "blank" if not passed.
It's nulled if can be set to null in DB, or the default value is retrieved from
the schema info.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8170645f84be2b1f4c8e527258e58117ae2e0593
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 16 13:49:01 2020 +0100
Bug 23463: Replace new occurrence of AddItem
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 34cca6a775abed84c2978b9ebd38bac56ae6a82a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 6 10:40:29 2020 +0100
Bug 23463: Fix XSLT.t
From commit bf49eecdd87e2b29760226281ab1afc0a185c7f0
Bug 23463: Replace AddItem calls with Koha::Item->store
in build_sample_item:
- my $itype = delete $args->{itype}
- || $self->build_object( { class => 'Koha::ItemTypes' } )->itemtype;
+ # If itype is not passed it will be picked from the biblio (see Koha::Item->store)
So before we generated a new itemtype if not passed, now we pick the one from biblioitem->itemtype.
For this specific test we need to make sure they are different.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 62852241430b9444acd600498fc51912f36a90e7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 6 15:06:07 2020 +0100
Bug 23463: Fix cn_source for new item
get_dirty_columns only work for existing items.
This fixes t/db_dependent/ShelfBrowser.t
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a494bb1b49d0ec91b0f4a7edb44f7db6a435205f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 6 14:34:36 2020 +0100
Bug 23463: Fix IsItemIssued.t
It seems that some of those tests could be removed as safe_delete is
widely tested in Koha/Item.t
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 974caa4304358423c08b9e2ea784ea83af2d09c1
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Feb 6 10:24:04 2020 -0300
Bug 23463: Fix tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit de9ce93cf284aa32f8c5c527387949ebc79cc4ea
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 30 16:15:14 2020 +0100
Bug 23463: Fix safe_return return value in deletion tools
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 57eb6e42265a830aabb01f5de0bcab49bd090356
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 28 12:54:37 2020 +0100
Bug 23463: (follow-up) Fix timestamp default value
For discussion, this patch revert the changes made previously.
This line exists in Koha::Item->store as it is the translation of:
if (exists $item->{'timestamp'}) {
delete $item->{'timestamp'};
}
that was coming from _do_column_fixes_for_mod (called from ModItem)
To preserve existing behavior I would be in favor of keeping it like that to
avoid regression, and deal with it separately if we want to improve/remove it.
So basically here we are setting it to undef in Koha::Item->store to make it
handle correctly by the parent Koha::Object->store. I agree that's kind of weird
and must be improved.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 794e8f992eee39641ec83beb83c140c6f7df4814
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 27 17:20:26 2020 +0100
Bug 23463: Move DelItem.t and Items_DelItemCheck.t tests to a Koha/Item.t subtest
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f70a738bca1782e7a90ef217473c2d50e335e3e4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 27 16:54:20 2020 +0100
Bug 23463: Fix timestamp default value
This sounds wrong as we should let the DBMS do that, but it was failing.
Here we are doing the same as Koha::Patron->store for dateenrolled
To recreate the failure, prove t/db_dependent/Koha/Item.t without this
patch:
DBD::mysql::st execute failed: Column 'timestamp' cannot be null [for
Statement "UPDATE `items` SET `more_subfields_xml` = ?, `timestamp` = ?
WHERE ( `itemnumber` = ? )" with ParamValues: 0='<?xml version="1.0"
encoding="UTF-8"?>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cc6f25fec44273ed1407c910544af04c4700817e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 10 12:58:09 2019 +0100
Bug 23463: (follow-up) Remove DelItemCheck and ItemSafeToDelete
Wrong replacement in additem.pl
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 18555f244ad0bbb0526e58cb26993161d9fd07e0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 2 14:32:09 2019 +0100
Bug 23463: cn_sort needs to be updated if cn_source changed
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f76a75a3d3b8e6c99d5dcd687580778364571c14
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 2 12:02:28 2019 +0100
Bug 23463: Replace recently added occurrences
Few occurrences have been added since this patchset has been originaly
written
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 22f8584eadd2ace33f296f9cee1409ed6608e12b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 12 18:27:30 2019 -0500
Bug 23463: build cn_sort only if needed
No need to calculate cn_sort if not dirty when we store
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit befc3f19f7d28dd3e92f719274d7e277e1a15fff
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 12 17:51:24 2019 -0500
Bug 23463: Fix items.cn_source vs cn_source
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fce29fb77d61ff7c006874b22ae7a00adb80cf34
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 7 21:13:18 2019 -0500
Bug 23463: update permanent_location if location has been updated
This change to Koha::Item->store seems correct here, but tests from /db_dependent/Items.t is failing now.
Adjusting them to make them pass.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit bef6c36156a3e732c294d096169eb58682912e6b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 7 20:47:20 2019 -0500
Bug 23463: Fix AutomaticItemModificationByAge.t
We do not want to log if nothing changed
How could we do that better?
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit eeaf0b19e08e96293be1bf663015e7138d80e69c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 7 20:28:06 2019 -0500
Bug 23463: Getting less item-level_itypes warnings (?)
So, we get less warnings. I do not really understand why...
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 4bce8c68fec3d940a053b647cfd629cf56c134c1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 7 11:09:57 2019 -0500
Bug 23463: Fix failing tests
And adding a FIXME about discard_changes
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2088b6857e9dd0d41acb53582897703586b7116d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 7 11:00:49 2019 -0500
Bug 23463: Fix CancelReceipt.t
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2677da8f17fdf5a7f505770a2dc9935e55a3e73c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 7 10:44:24 2019 -0500
Bug 23463: Remove no longer needed subs related to default values
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a3687711b075f64e1e5f1fe31c6adad664679e42
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 6 11:58:01 2019 -0500
Bug 23463: Remove DelItemCheck and ItemSafeToDelete
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b844b19dfc9dacea4e6b27357844f731c6a389e3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 6 11:29:27 2019 -0500
Bug 23463: Remove DelItem
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fc09b0d491b17447c9e3bdfe67c3f7b870405b9a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 6 11:14:25 2019 -0500
Bug 23463: Remove ModItem
There should not be any calls left
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6ae8919e9230b2327bbc690bfbce89c1c4c67ad5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 6 11:14:07 2019 -0500
Bug 23463: Remove _mod_item_dates
We did not do anything useful here.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 516e76d1b53001a1be2f765e71d02b63ac9d85fb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 6 11:12:31 2019 -0500
Bug 23463: _do_column_fixes_for_mod dealt with integer location and timestamp moved
That's done in Koha::Item->store, and Koha::Object->store for integers.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7ec06a1ae8466b5027535fb3d40ab9618bfd3a65
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 6 11:11:38 2019 -0500
Bug 23463: _set_derived_columns_for_mod was only used for cn_sort
Same as _set_defaults_for_add
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7d35052a14df66e9c5fe5d70378d36a6b1edb94d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 6 10:17:28 2019 -0500
Bug 23463: Move plugin hook
From C4::Items to Koha::Item
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit df520d2d6288bfbc9acac59c90a28ebe343a5390
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 18 15:06:03 2019 -0300
Bug 23463: remove trivial UpdateHoldingbranch sub
We do not need this subroutine, moving it where it is used.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit bbb504c86f5ca0a474365d4839177412f415c4ee
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 18 14:56:19 2019 -0300
Bug 23463: Replace ModItem with Koha::Item->store
Starting to replace the ModItem calls with Koha::Item->store
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0c8d8e867b18b61f39381d2061cd2124fe1c5ed3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 18 14:41:37 2019 -0300
Bug 23463: AddItem removing
We are done with AddItem, only need to log and index.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 488a6f98a6b7a1527ed801f4eef21013f8a2bbf9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 18 14:20:51 2019 -0300
Bug 23463: Replace _set_derived_columns_for_add
Remove the unique call to _set_derived_columns_for_add
Even if design to deal with other values it only dealts with cn_sort
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 02134d7604a6fc08b88046fde87b6c909de04353
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 18 14:15:37 2019 -0300
Bug 23463: Remove _set_defaults_for_add
_set_defaults_for_add is no longer needed as it is handled by dbic and koha::object->store
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2075a22ed3c71196002dd8da28a061f791baf393
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Mar 17 23:12:46 2019 -0300
Bug 23463: Replace AddItem calls with Koha::Item->store
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9b33b8babdfe288ef1f436bdfc4a1ea5cc5629da
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Mar 17 23:12:22 2019 -0300
Bug 23463: fix for testbuilder - set default value items.damaged=0
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 150b835ab3b57c05b043c0b8d317f9dcb75b6d58
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Mar 17 21:10:00 2019 -0300
Bug 23463: Remove uneeded SearchItemsByField subroutine
It is no longer used.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 826eda128e98f39e989a7da3af92e7f8b500eb75
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Mar 17 21:09:29 2019 -0300
Bug 23463: Replace SearchItemsByField by SearchItems
The subroutine SearchItemsByField is only called once and can be
replaced easily with SearchItems
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 4 +-
C4/Circulation.pm | 77 +-
C4/CourseReserves.pm | 19 +-
C4/ImportBatch.pm | 5 +-
C4/Items.pm | 916 +--------------------
Koha/Checkout.pm | 2 +-
Koha/EDI.pm | 19 +-
Koha/Illrequest.pm | 7 +-
Koha/Item.pm | 242 ++++++
Koha/Object.pm | 41 +
acqui/addorderiso2709.pl | 35 +-
acqui/check_uniqueness.pl | 2 +-
acqui/finishreceive.pl | 19 +-
catalogue/updateitem.pl | 16 +-
cataloguing/additem.pl | 28 +-
circ/pendingreserves.pl | 7 +-
misc/cronjobs/delete_items.pl | 10 +-
misc/cronjobs/delete_records_via_leader.pl | 2 +-
misc/cronjobs/longoverdue.pl | 3 +-
misc/maintenance/touch_all_items.pl | 4 +-
misc/migration_tools/fix_onloan.pl | 23 +-
offline_circ/process_koc.pl | 2 +-
serials/serials-edit.pl | 7 +-
svc/checkin | 1 -
t/db_dependent/Acquisition.t | 2 +-
t/db_dependent/Acquisition/CancelReceipt.t | 8 +-
t/db_dependent/Acquisition/TransferOrder.t | 10 +-
t/db_dependent/Circulation.t | 39 +-
t/db_dependent/Circulation/Branch.t | 25 +-
t/db_dependent/Circulation/CheckIfIssuedToPatron.t | 4 +-
t/db_dependent/Circulation/CheckValidBarcode.t | 6 +-
.../Circulation/GetPendingOnSiteCheckouts.t | 8 +-
t/db_dependent/Circulation/GetTopIssues.t | 10 +-
t/db_dependent/Circulation/IsItemIssued.t | 8 +-
.../Circulation/IssuingRules/maxsuspensiondays.t | 6 +-
t/db_dependent/Circulation/Returns.t | 12 +-
t/db_dependent/Circulation/issue.t | 39 +-
t/db_dependent/Circulation/transfers.t | 20 +-
t/db_dependent/CourseReserves.t | 12 +-
t/db_dependent/Holds.t | 133 ++-
t/db_dependent/Holds/LocalHoldsPriority.t | 9 +-
t/db_dependent/Holds/RevertWaitingStatus.t | 9 +-
t/db_dependent/Items.t | 339 +++-----
.../Items/AutomaticItemModificationByAge.t | 18 +-
t/db_dependent/Items/DelItem.t | 43 -
t/db_dependent/Items_DelItemCheck.t | 170 ----
t/db_dependent/Koha/BiblioUtils/Iterator.t | 2 +-
t/db_dependent/Koha/Biblios.t | 20 +-
t/db_dependent/Koha/Item.t | 110 ++-
t/db_dependent/Koha/Items.t | 25 +-
t/db_dependent/Koha/Object.t | 36 +-
.../Koha/Plugins/Biblio_and_Items_plugin_hooks.t | 4 +-
t/db_dependent/Labels/t_Label.t | 14 +-
t/db_dependent/Members/GetAllIssues.t | 13 +-
t/db_dependent/Members/IssueSlip.t | 8 +-
t/db_dependent/Patron/Borrower_Discharge.t | 15 +-
t/db_dependent/Reserves.t | 123 ++-
t/db_dependent/RotatingCollections.t | 33 +-
t/db_dependent/ShelfBrowser.t | 12 +-
t/db_dependent/Template/Plugin/Branches.t | 1 -
t/db_dependent/XSLT.t | 5 +-
t/lib/TestBuilder.pm | 14 +-
tools/batchMod.pl | 10 +-
tools/batch_delete_records.pl | 10 +-
tools/inventory.pl | 12 +-
65 files changed, 1079 insertions(+), 1809 deletions(-)
delete mode 100644 t/db_dependent/Items/DelItem.t
delete mode 100644 t/db_dependent/Items_DelItemCheck.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list