[koha-commits] main Koha release repository branch master updated. v19.11.00-1296-g757ca57bfd

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  757ca57bfdbd4346b90293429e658d239b8d0102 (commit)
      from  243a5395de9be3e3971ae8171a8b2b3aa79e74bb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 757ca57bfdbd4346b90293429e658d239b8d0102
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Mar 23 13:09:07 2020 +0100

    Bug 23463: Fix selenium tests (highlight a bug in date management)
    
    There is something wrong, and a regression has been caught by those
    tests:
    If an invalid date is passed from the add item form, the app now
    crashes.
    Before:
     * if the date was completely invalid, the field was blanked
    silently
     * DateTime::Format::MySQL was used to convert dates, and it's not
     strict at all. For instance, what happened in the selenium tests for
     dateaccessionned: %Y-%m-%d was prefilled by the framework plugin, then
     the biblionumber was added, we ended with something like (eg for today)
     2020-03-234242 (with biblionumber=4242). DateTime::Format::MySQL
     converts that to 2020-03-23
    
    We must deal with invalid dates, but I do not think it is good to add it
    back to Koha::Item->store, we will prefer to raise the error to the end
    user, saying that something went wrong (and more specifically the
    dates).
    
    The (ugly) trick was in C4::Items::_mod_item_dates
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 t/db_dependent/selenium/basic_workflow.t | 11 +++++++++++
 1 file changed, 11 insertions(+)


hooks/post-receive
-- 
main Koha release repository