[koha-commits] main Koha release repository branch master updated. v19.11.00-1341-ga373a6a272
Git repo owner
gitmaster at git.koha-community.org
Tue Mar 24 10:57:49 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via a373a6a27257d8d4d140f7f1c5f1c8d5c334d4a2 (commit)
via c8718bd4af3e5b1329878cee6ff27a7a5a27091b (commit)
via 7d66e67bd1e8e4f3b47b3a75e01a286191205637 (commit)
via 9dd63147cfc61a25422c8fb9e166134ce04b4b99 (commit)
via 7a2f1247e1bee329719eb733f199fc302e30d4d8 (commit)
via 117b55c702e326201a572f1fb3d79e6f579af47d (commit)
via 8188655897152764f01ba3d883626396893d4f01 (commit)
via e9e3bb6aa19ad915904e31d51af875b1bf27aa85 (commit)
via 71354abe5a216e077cfb55206afbb7e0f0cc5c26 (commit)
via f85d85f380b2b8edd6fccc3fc2440f2a44b92454 (commit)
via 7f815b258fca9cf2a76c83ebee1ec569fa7dd2ab (commit)
via 3702194574cc2bdc291a05ca2d17b63e191ee6b3 (commit)
via b6891f1d1b2a00db25067df9212b4b5677255572 (commit)
via 60c31d70bbdefc0d67baa514aa481076de55d278 (commit)
via 3302ad146194738c247b2ccfa7b8e3cb98478f7d (commit)
from acf7ec2d872b3ac55259cf114b32bfc4c9163037 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a373a6a27257d8d4d140f7f1c5f1c8d5c334d4a2
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Sun Mar 15 11:39:42 2020 -0300
Bug 24872: Set languages prefererences after install
This patch set 'languages' and 'opaclanguages' system
preferences with the language used during install.
To test:
1. Apply the patch
2. Do a clean install in a language other than english
3. Verify that 'languages' and 'opaclanguages' system
preferences show the language code used during install,
besides english.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c8718bd4af3e5b1329878cee6ff27a7a5a27091b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Feb 17 14:58:02 2020 +0100
Bug 24672: (bug 24430 follow-up) Do not get active orders on deleted biblio record
On bug 24430 we replaced the call to CountBiblioInOrders with
Koha::Biblio->active_orders
In case the bibliographic record is deleted, the count must be set to 0.
This prevent the app to crash with:
Can't call method "active_orders" on an undefined value at
/home/vagrant/kohaclone/acqui/parcel.pl line 244
Test plan:
Create 2+ orders
Receive one, delete it, delete the bibliographic record
Receive the order one
=> Without this patch, on the parcel page you should get the error
=> With this patch applied you must be allowed to finish the receive
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7d66e67bd1e8e4f3b47b3a75e01a286191205637
Author: Mason James <mtj at kohaaloha.com>
Date: Thu Mar 19 20:41:00 2020 +1300
Bug 24874: Printing is broken on opac-results.pl page
to test:
- search for something in opac
- print page using file -> print
- observe printing is broken (pic1)
- apply patch
- search for something in opac
- print page using file -> print
- observe printing is fixed (pic2)
it seems this issue was introduced by bug 5287
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9dd63147cfc61a25422c8fb9e166134ce04b4b99
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Mar 22 12:10:43 2020 +0100
Bug 24876: Fix capitalization on patron search for holds
When placing a hold in the staff interface, the heading on the
search box reads: Search Patrons or clubs
The patch changes it to be Search patrons... instead.
Also changes club id to club ID.
To test:
- Place a hold in the staff interface
- Verify the capitalization error
- Switch tabs to Clubs, see: club id
- Apply patch
- Verify it's all good now
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7a2f1247e1bee329719eb733f199fc302e30d4d8
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Mar 24 08:09:14 2020 +0000
Bug 24854: DBRev 19.12.00.050
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 117b55c702e326201a572f1fb3d79e6f579af47d
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Mar 13 17:16:28 2020 +0000
Bug 24854: Remove IDreamBooks integration
The IDreamBooks service has not seen updates in a long time, so
we should remove the service from Koha as it's no longer operational.
To test:
- Apply patch and run the database update
- Verify that the IDreamBooks related system preferences are gone
- Verify that opac detail pages and result lists still work
as expected
- Run t/db_dependent/UsageStats.t
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8188655897152764f01ba3d883626396893d4f01
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Mar 20 16:05:46 2020 -0300
Bug 24918: Fix attribute mappings in Koha::Acquisition::Basket
When bug 18731 was written, the official vote on the RFC hadn't been
held yet. Once it got voted, the mappings were adapted and all the
dependent work fixed as well. But three attribute names were overlooked
and they become evident on developing 20212 which required them.
This patch fixes this really tiny mistake.
To test:
1. Just verify the voted attribute names.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e9e3bb6aa19ad915904e31d51af875b1bf27aa85
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Mar 20 15:53:35 2020 -0300
Bug 24464: (QA follow-up) Make the method reflect the lack of FK
This patch makes it super obvious to understand by reading the code that
there's originally no foreign key.
To test:
1. Run the tests and notice they pass
2. Spot the # FIXME
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 71354abe5a216e077cfb55206afbb7e0f0cc5c26
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jan 20 16:00:05 2020 -0300
Bug 24464: Add K::A::Basket->creator
This patch adds a ->creator method to Koha::Acquisition::Basket to
retrieve the related Koha::Patron object.
Note: this should be re-done once 22658 is pushed, but at the time
being, there's not patch submitted, and it is not a trivial task because
of the column type missmatch. That said, the implementation of ->creator
in this class is simple enough to just rewrite it once 22658 is
submitted, and the tests will reflect the expected/unchanged behavior.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f85d85f380b2b8edd6fccc3fc2440f2a44b92454
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jan 20 15:59:59 2020 -0300
Bug 24464: Unit tests
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7f815b258fca9cf2a76c83ebee1ec569fa7dd2ab
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jan 20 11:56:36 2020 -0300
Bug 24463: Add a basket_group relationship for baskets
This patch aims to bring consistency between the accessor name and the
underlying relationship to ease things when using it from the API.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass! No behavior change!
3. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3702194574cc2bdc291a05ca2d17b63e191ee6b3
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Mar 10 15:11:07 2020 +0000
Bug 21708: Sort MARC fields in TransformHtmlToMarc
Instead of pushing 999 in the front :)
Test plan:
Do not yet apply this patch.
Edit a record. Save. And open MARC view/view plain on opac-detail.
Verify that the biblionumber field (MARC21 999) follows leader.
Apply this patch. Restart Plack.
Edit a record. Save. And open MARC view/view plain on opac-detail.
Verify that the biblionumber field is in right position.
Run t/db_dependent/Biblio/TransformHtmlToMarc.t. Should pass now.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b6891f1d1b2a00db25067df9212b4b5677255572
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Mar 11 13:22:31 2020 +0000
Bug 21708: Add a few tests in TransformHtmlToMarc.t
Test plan:
Run t/db_dependent/Biblio/TransformHtmlToMarc.t without the module change
patch. Verify that the test fails on the order of fields.
Go to test plan of the second patch.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 60c31d70bbdefc0d67baa514aa481076de55d278
Author: Liz Rea <wizzyrea at gmail.com>
Date: Fri Jan 3 21:18:27 2020 +0000
Bug 24324: Resolve error with delete_records_via_leader.pl
To test:
Have a record with the 000 position 5 set to "deleted" (record status)
Use koha-shell to run the job with the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -i -v
* items and the record should be deleted
Mark another record with the 000 position 5 set to deleted (record status)
Use koha-shell to run the job without the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -v
* if the record had items, it will not be deleted
* if the record did not have items, it will be deleted.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3302ad146194738c247b2ccfa7b8e3cb98478f7d
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Thu Mar 19 09:38:52 2020 +0100
Bug 24902: Join different mc- limits with AND (elasticsearch)
In the advanced search form, you can enable several limits using syspref
AdvancedSearchTypes (namely itemtypes, shelving locations, collections)
When used, the resulting query parts end up being joined with OR, even
if the field is different. That means that if you pick "Book" under
itemtypes tab, and "Fiction" under collection tab, it will search
"itype:BOOK OR ccode:FIC". It should be AND.
For instance, if you select:
Itemtypes:
✓ Book
✓ DVD
Location:
✓ Child
✓ Adult
it should search:
itype:(Book OR DVD) AND location:(Child OR Adult)
Test plan:
0. Do not apply the patch yet
1. Enable elasticsearch
2. Set syspref AdvancedSearchTypes = 'itemtypes|loc|ccode'
3. Create a new itemtype and a new authorised value for categories LOC
and CCODE
4. Create a biblio with the new itemtype, another biblio with the new
location, another biblio with the new collection, and again another
biblio with the new itemtype, location and collection
5. Verify that you can find these new biblio records using only the
"advanced search types" in the advanced search form
6. In the advanced search form, pick all 3 limits (itemtype, location,
collection) and verify that it returns the 4 records.
7. Apply the patch
8. Repeat step 6, it should now return only the biblio that satisfies
all criteria
9. Verify that if you select more than one
{itemtype|location|collection} it still returns results that
satisfies any selected criteria
10. prove t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 1 +
C4/Installer.pm | 26 +++++++++
C4/UsageStats.pm | 3 --
Koha.pm | 2 +-
Koha/Acquisition/Basket.pm | 27 ++++++++--
Koha/Schema/Result/Aqbasket.pm | 12 +++++
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 26 +++++----
acqui/parcel.pl | 2 +-
installer/data/mysql/sysprefs.sql | 3 --
installer/data/mysql/updatedatabase.pl | 7 +++
installer/install.pl | 5 ++
.../admin/preferences/enhanced_content.pref | 19 -------
.../prog/en/modules/reserve/request.tt | 4 +-
koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss | 7 ++-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 61 ----------------------
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 44 ----------------
misc/cronjobs/delete_records_via_leader.pl | 6 +--
opac/opac-detail.pl | 3 --
opac/opac-search.pl | 3 --
t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t | 31 ++++++++++-
t/db_dependent/Biblio/TransformHtmlToMarc.t | 46 ++++++++++++++--
t/db_dependent/Koha/Acquisition/Basket.t | 32 +++++++++++-
t/db_dependent/UsageStats.t | 3 --
23 files changed, 206 insertions(+), 167 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list