[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.08-60-g7f8656d0b5

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  7f8656d0b523f56cbfcb837568da7a1fd7537df2 (commit)
      from  3836fe5754f6852239cdb53bfd50ea268e7465e0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7f8656d0b523f56cbfcb837568da7a1fd7537df2
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon Feb 17 06:50:49 2020 +0000

    Bug 24673: Add CSRF token support to opac-messaging.pl
    
    This patch adds CSRF token support to opac-messaging.pl,
    which allows users to manually update their messaging preferences,
    but prevents bad actors from tricking people into updating their
    preferences from cross-site requests.
    
    Test plan:
    0. Set SMSSendDriver global system preference to "Test" if unset
    1. Log into the OPAC
    2. Navigate to a URL in your browser like the following:
    http://localhost:8080/cgi-bin/koha/opac-messaging.pl?modify=yes
    &1=email&digest=1&2-DAYS=5&2=email&digest=2&4=email&SMSnumber=0444444444
    3. Observe that the preference and SMS number update
    
    4. Apply the patch
    
    5. Navigate to a URL in your browser like the following:
    http://localhost:8080/cgi-bin/koha/opac-messaging.pl?modify=yes
    &1=email&digest=1&2-DAYS=5&2=email&digest=2&4=email&SMSnumber=0444444444
    6. Observe that you get an error message of "Wrong CSRF token" instead
    of the previous behaviour
    7. Navigate to a URL in your browser like the following:
    http://localhost:8080/cgi-bin/koha/opac-messaging.pl
    8. Update "Advance notice" to 3 and update "SMS number" to 61111111111
    9. Observe that the "Advance notice" and "SMS number" fields update
    correctly
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 35cdeadbdfbf75731688f71778756aab73ffb824)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt |  1 +
 opac/opac-messaging.pl                                     | 13 +++++++++++++
 2 files changed, 14 insertions(+)


hooks/post-receive
-- 
main Koha release repository