[koha-commits] main Koha release repository branch master updated. v19.11.00-1475-ga29e0d4802

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a29e0d480251055040438cb53238424d5a75af26 (commit)
       via  0d84a36d24259a9dfc9dd24af708c79b2f759f4a (commit)
       via  b372daa298f984715745268d721d67b4fb2fbd3a (commit)
       via  066ff4e7875bbbb16734853d139a721829004142 (commit)
      from  e87908078fe7866f6a31815d41e4c9409de57719 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a29e0d480251055040438cb53238424d5a75af26
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Feb 11 17:21:38 2020 +0100

    Bug 24614: Use Koha::Reports from save_report and update_sql
    
    In order to get the default value defined at DBMS level, we use
    Koha::Reports (to inherit from Koha::Object->store) from the 2 add/edit
    methods of C4::Reports::Guided.
    A second step would be to remove completely those CRUD subroutines and
    use directly Koha::Reports instead.
    
    Test plan:
    1. Add and edit some reports
    2. Disable memcached, create a report, edit it
    => Should not crash
    3. Make sure the tests make sense and that they pass after the second
    patch.
    
    The error was:
    DBD::mysql::db do failed: Column 'cache_expiry' cannot be null [for
    Statement "UPDATE saved_sql SET savedsql = ?, last_modified = now(),
    report_name = ?, report_group = ?, report_subgroup = ?, notes = ?,
    cache_expiry = ?, public = ? WHERE id = ? "] at
    /kohadevbox/koha/C4/Reports/Guided.pm line 633.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0d84a36d24259a9dfc9dd24af708c79b2f759f4a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Feb 11 17:21:15 2020 +0100

    Bug 24614: Add tests
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b372daa298f984715745268d721d67b4fb2fbd3a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Mar 9 09:33:54 2020 -0400

    Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims
    
    ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero.
    
    Test Plan:
    1) Make 3 return claims for a patron
    2) Set ClaimReturnedWarningThreshold to 4
    3) Note the claims warning displays for the patron on circulation.pl
    4) Apply this patch
    5) Reload circulation.pl, the warning should go away
    6) Set ClaimReturnedWarningThreshold to 2
    7) Reload the page, the warning should reappear
    
    Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 066ff4e7875bbbb16734853d139a721829004142
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Mar 23 20:10:15 2020 +0000

    Bug 24959: Fix id/label pairs in saved reports table
    
    This patch adds a unique id attribute to each checkbox in the table of
    saved reports. Also updated is the corresponding <label>'s "for"
    attribute so that clicking the report id will toggle the checkbox.
    
    To reproduce, go to Reports -> Use saved and click a number in the ID
    column. Nothing happens.
    
    After applying the patch clicking the number should check or uncheck the
    corresponding checkbox.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Works Ok, no errors.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reports/Guided.pm                               | 43 ++++++++++++++++------
 .../prog/en/modules/circ/circulation.tt            |  2 +-
 .../en/modules/reports/guided_reports_start.tt     |  4 +-
 t/db_dependent/Reports/Guided.t                    |  6 ++-
 4 files changed, 39 insertions(+), 16 deletions(-)


hooks/post-receive
-- 
main Koha release repository