[koha-commits] main Koha release repository branch master updated. v19.11.00-1555-g624a24b820

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  624a24b8203624d94cbe0efdb37106065cf6cd92 (commit)
      from  ff19fd48060aee94eb98ae5e0ae883c86f81475a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 624a24b8203624d94cbe0efdb37106065cf6cd92
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Mar 27 17:09:27 2020 +0100

    Bug 24614: Fix Reports/Guided.t
    
    DBD::mysql::st execute failed: Column 'public' cannot be null [for Statement "UPDATE `saved_sql` SET `last_modified` = ?, `notes` = ?, `public` = ?, `report_group` = ?, `report_name` = ?, `report_subgroup` = ?,
    `savedsql` = ? WHERE ( `id` = ? )" with ParamValues: 0='2020-03-27T16:03:04', 1=undef, 2=undef, 3=undef, 4='Just another report', 5=undef, 6=undef, 7=25] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
        # Looks like you planned 17 tests but ran 6.
    
    update_sql expect all the paramters to be set, otherwise it will be
    nulled.
    
    The best way to fix it is at test level. There is only 1 occurrence in
    controller/module, and it sends all the parameters. That is the correct
    way to do and will make things easier when we will removed them to use
    Koha::Reports directly
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 t/db_dependent/Reports/Guided.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository