[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-6-g9b0ba1c096

Tue Mar 31 00:26:00 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  9b0ba1c096ed72bd867792a11de59a825355e6dc (commit)
       via  c242f8667794cc4217155c783dfe8065d77ac788 (commit)
       via  d7f922eb63c420375f42ab419d9db154650fbd4d (commit)
       via  60a0c1c51cc4667eefa62232d7a45a823168a378 (commit)
       via  91da9841d78d26db205c6493c27c174c20e7b7c2 (commit)
       via  a137b170c0f4bac8fdd69dd4e9fe6e46c60edd59 (commit)
      from  c8e099cb5755e2139cd2af2a84b8e252d051d962 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9b0ba1c096ed72bd867792a11de59a825355e6dc
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Nov 29 09:45:48 2019 +0000

    Bug 24114: (QA follow-up) Fix counts for lock, anonymize and delete

    Since these operations impact on the resultset, the counts should be
    saved before.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit c242f8667794cc4217155c783dfe8065d77ac788
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Nov 29 09:17:19 2019 +0000

    Bug 24114: (follow-up) Resolve warning on non-numeric subtraction

    Argument "" isn't numeric in subtraction (-) at /usr/share/koha/Koha/Patrons.pm line 290.

    Coming from an empty or undefined FailedLoginAttempts.

    Test plan:
    Verify that Koha/Patrons.t still passes.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit d7f922eb63c420375f42ab419d9db154650fbd4d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Nov 26 11:11:35 2019 +0100

    Bug 24114: Remove warn statements from Koha::Patrons

    The warn must be done in the cronjob.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Followed this test plan (with two follow-ups applied):
    [1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef
    [2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job:
        Locked 0 patrons
        Anonymized 1 patrons
        Deleted 0 patrons
    [3] Pick borrower, set expiry to NOW-3. Run cleanup job:
        Locked 0 patrons
        Anonymized 0 patrons
        Deleted 1 patrons

    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 60a0c1c51cc4667eefa62232d7a45a823168a378
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Feb 21 10:31:54 2020 +0100

    Bug 24682: Make UsageStatsGeolocation readonly (and redirect to the config page)

    To prevent invalid values in this pref (and so on the server), we should
    make this input readonly on the syspref page.
    The sysprefs related to Hea should be edited from the dedicated page, so
    also adding a note about that.

    Test plan:
    Search syspref with "UsageStats"
    Notice the note about the admin page
    Notice the UsageStatsGeolocation input is now readonly (and resized, to
    display the whole value when filled)

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 91da9841d78d26db205c6493c27c174c20e7b7c2
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Jan 28 16:09:20 2020 +0100

    Bug 24527: misc/cronjobs/update_totalissues.pl problem with multiple items

    misc/cronjobs/update_totalissues.pl when issuing statistics table, no-incremental,  has a problem for biblio with multiple items.
    The first SQL query gets the biblios linked to items with issues in statistics :

    SELECT
      biblio.biblionumber, COUNT(statistics.itemnumber)
    FROM
      biblio
    LEFT JOIN
      items
    ON
      (biblio.biblionumber=items.biblionumber)
    LEFT JOIN
      statistics
    ON
      (items.itemnumber=statistics.itemnumber)
    WHERE
      statistics.type = 'issue'
    $limit
    GROUP BY
      biblio.biblionumber

    The second SQL query is :
    SELECT
      biblio.biblionumber, 0
    FROM
      biblio
    LEFT JOIN
      items
    ON
      (biblio.biblionumber=items.biblionumber)
    LEFT JOIN
      statistics
    ON
      (items.itemnumber=statistics.itemnumber)
    WHERE
      statistics.itemnumber IS NULL
    GROUP BY
      biblio.biblionumber

    The problem is that this second query will set to 0 where ANY item has no entry in statistics table.
    So when running it sets 0 to the biblio that had a value from first
    query.

    I think the best fix is to use "WHERE statistics.type = 'issue'" inside que JOIN :
    LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber AND statistics.type = 'issue')

    Test plan :
    1) Begin with an empty database
    2) Create a biblio 1 with no items
    3) Create a biblio 2 with 3 items
    4) Create a biblio 3 with 2 items
    5) Checkout and checkin all items of biblio 2
    6) Checkout and checkin the firt item of biblio 3
    7) run misc/cronjobs/update_totalissues.pl --use-stats -v
    8) Check biblio 1 has biblioitems.totalissues = 0
    9) Check biblio 2 has biblioitems.totalissues = 3
    10) Without patch the biblio 3 has biblioitems.totalissues = 0
    11) With patch the biblio 3 has biblioitems.totalissues = 1
    12) Check misc/cronjobs/update_totalissues.pl --incremental is OK

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit a137b170c0f4bac8fdd69dd4e9fe6e46c60edd59
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Feb 21 21:11:37 2020 +0000

    Bug 24711: Don't add logout input to login form

    To test:
    1 - Set OpacPublic syspref to 'Disable'
    2 - Log in to OPAC
    3 - Log out
    4 - Try to log in again
    5 - No error, but you get the login form again
    6 - Apply patch
    7 - Repeat
    8 - This time you can log in again

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Patrons.pm                                    | 19 +++++-------------
 .../prog/en/modules/admin/preferences.tt           |  6 +++++-
 .../prog/en/modules/admin/preferences/admin.pref   |  2 ++
 .../opac-tmpl/bootstrap/en/modules/opac-auth.tt    |  1 +
 misc/cronjobs/cleanup_database.pl                  | 23 ++++++++++++++++++----
 misc/cronjobs/update_totalissues.pl                | 18 ++++++-----------
 t/db_dependent/Koha/Patrons.t                      | 11 ++++++++++-
 7 files changed, 48 insertions(+), 32 deletions(-)

hooks/post-receive
-- 
main Koha release repository