From gitmaster at git.koha-community.org Fri May 1 09:35:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 May 2020 07:35:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1967-gb13df9d3d0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b13df9d3d061f3405d9587cf3d6951f8d8fe12b8 (commit) via c95add2e17be7b48c3218a264b60c8372fe1d9a2 (commit) from 049aee253699102d44fde8cc814a830c146c0b7b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b13df9d3d061f3405d9587cf3d6951f8d8fe12b8 Author: Jonathan Druart Date: Thu Apr 30 14:15:28 2020 +0200 Bug 25303: Add a test for ->reset Signed-off-by: Martin Renvoize commit c95add2e17be7b48c3218a264b60c8372fe1d9a2 Author: Jonathan Druart Date: Thu Apr 30 13:24:30 2020 +0200 Bug 25303: Call ->reset before iterate on the set In case we already started to iterate. This fixes a failing tests in t/db_dependent/Koha/Biblios.t Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Objects.pm | 1 + t/db_dependent/Koha/Objects.t | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 1 09:47:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 May 2020 07:47:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1975-g30906c8b4f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 30906c8b4f5cabf7d2533cbbde1f3368c5e2915c (commit) via 4689777ba9d50c45345f455a9f9a5d9b489a0fdf (commit) via 15595a5f35a204ec26501a9a0fcec2d5a21f0e24 (commit) via e3382d89cd3616f171863e328abd0f83bbcebce8 (commit) via 6ccad9a14a2f72fde26295350aa3353ddcbc6ddd (commit) via 03ea4bd0cc058bd3ca1c2e339371f45afc6c0244 (commit) via 5b2c79f1ea8313f6e0328d3efa2ea190b184c1d1 (commit) via 2d80fb494c0cb7f142ed1f0e0d29b96ca3dc8640 (commit) from b13df9d3d061f3405d9587cf3d6951f8d8fe12b8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 30906c8b4f5cabf7d2533cbbde1f3368c5e2915c Author: Martin Renvoize Date: Fri May 1 08:19:27 2020 +0100 Bug 23794: DBRev 19.12.082 Signed-off-by: Martin Renvoize commit 4689777ba9d50c45345f455a9f9a5d9b489a0fdf Author: Owen Leonard Date: Wed Dec 11 16:24:50 2019 +0000 Bug 23794: Convert OpacMainUserBlock system preference to news block This patch builds on Bug 22318 to move the OpacMainUserBlock system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacMainUserBlock system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacMainUserBlock system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacMainUserBlock is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'opacmainuserblock_en', 'opacmainuserblock_fr-FR', 'opacmainuserblock_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacMainUserBlock preference has been removed. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 15595a5f35a204ec26501a9a0fcec2d5a21f0e24 Author: Tomas Cohen Arazi Date: Mon Apr 27 18:55:59 2020 -0300 Bug 25297: Consistent return value in K::A::Order->current_item_level_holds This patch makes the return values for 'current_item_level_holds' consistent: they will always be a Koha::Holds iterator. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => FAIL: It doesn't work as expected, cannot call ->count on undef, etc 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e3382d89cd3616f171863e328abd0f83bbcebce8 Author: Tomas Cohen Arazi Date: Mon Apr 27 18:55:32 2020 -0300 Bug 25297: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6ccad9a14a2f72fde26295350aa3353ddcbc6ddd Author: Agustin Moyano Date: Tue Mar 31 17:56:22 2020 -0300 Bug 24980: (follow-up) return '' when date is null Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 03ea4bd0cc058bd3ca1c2e339371f45afc6c0244 Author: Martin Renvoize Date: Wed Mar 25 20:41:45 2020 +0000 Bug 24980: Only add timezone if passed a date-time This patch prevents a timezone from being assigned to the js moment if the input string is only at the full-date and not date-time resolution To test: 1. Do not apply this patch 2. Set your system time zone to CET 3. Apply previous patch (It's just for test) 4. In your browser go to koha main page, open a console and type $date('2020-03-25', {tz: 'UTC'}) CHECK => you sould get '03/24/2020' (notice day is 24 instead of 25) 5. Apply this patch and reload the browser 6. repeat step 4 SUCCESS => now you get '03/25/2020' (day is correct) 7. Sing off Signed-off-by: Martin Renvoize Signed-off-by: Agustin Moyano Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5b2c79f1ea8313f6e0328d3efa2ea190b184c1d1 Author: Josef Moravec Date: Thu Apr 30 11:29:56 2020 +0000 Bug 24043: (QA follow-up) Fix another TypeError when retrieving status name Test plan: 1) Apply first patch, and have the same requests as in previous patch test plan 2) Load ill requests list 2a) You can see another TypeError in console 2b) You can notice, the Placed on and Updated on columns have prepended another columns with unformatted dates and without header label 3) Apply this patch 4) Reload page (be sure it is not loaded from cache - Ctrl+F5) 5) Errors from 2a and 2b are gone Signed-off-by: Josef Moravec Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize commit 2d80fb494c0cb7f142ed1f0e0d29b96ca3dc8640 Author: Andrew Isherwood Date: Mon Jan 13 10:18:19 2020 +0000 Bug 24043: Fix retrieval of of status name This patch modifies the way in which a request's status name is retrieved. I think the previous way it was done (which can never have worked properly) must have come from a time when we weren't embedding the request's backend capabilities in each request. So now we can just use the current row. Test plan: 1. *Before applying the patch*: 2. Ensure you have at least two requests, from two different backends. One of the backends you are using must have a possible status that doesn't exist in the other. For example, the BLDSS backend has a status of STAT, that doesn't not exist in any other backends. 3. Ensure that the request who's backend has the unique status is *not* the first request in the returned list. 4. Load the "View ILL requests" page 5. Observe that the page JS fails with a "Cannot read property 'name' of undefined" error 6. Apply the patch 7. Reload the page (maybe doing a hard reload to ensure the JS is not cached) 8. TEST: Observe that the error no longer occurs and the requests all have their statuses displayed correctly. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 1 - Koha.pm | 2 +- Koha/Acquisition/Order.pm | 13 +++++----- installer/data/mysql/sysprefs.sql | 1 - installer/data/mysql/updatedatabase.pl | 30 ++++++++++++++++++++++ .../prog/en/includes/js-date-format.inc | 4 ++- .../prog/en/modules/admin/preferences/opac.pref | 6 ----- .../prog/en/modules/tools/koha-news.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 13 +++------- .../bootstrap/en/includes/js-date-format.inc | 12 +++++++-- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 9 +++++-- t/db_dependent/Koha/Acquisition/Order.t | 15 ++++++++--- 12 files changed, 72 insertions(+), 36 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 1 17:13:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 May 2020 15:13:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1980-g04813346c8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 04813346c84157902d5926e3128ec147138cfa49 (commit) via 27bc382535dea91f1c5adb353858b2df9ef3f2a3 (commit) via 99882e35e1efc5257b084e4d66acd53c7f16856c (commit) via f195cb45a82d43549647d0efc904fe2107149d2a (commit) via 7761db8052329411d6d67ab282f9f8c136feb567 (commit) from 30906c8b4f5cabf7d2533cbbde1f3368c5e2915c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 04813346c84157902d5926e3128ec147138cfa49 Author: Kyle M Hall Date: Wed Apr 29 10:40:21 2020 -0400 Bug 24772: Don't revert course item fields when deleting a course item unless it is enabled Deactivating a from Course Reserves reverts Item's Shelving Location correctly, then deleting the same course reverts the Course Reserve Items to old shelving location values. Test Plan: 1) Add items to a Course - make sure they all have shelving locations prior to being added to the course. 2) When adding items change their shelving location to something else. See that Shelving Location has changed; permanent location in parentheses 3) Deactivated course See that Shelving Location has changed back to its original location 4) Deleted course See that Shelving Location has changed back to what was picked during adding it to the Course. 5) Apply this patch, restart all the things! 6) Repeat steps 1-4, note the shelvig location is not lost! Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Hannah Olsen Signed-off-by: Martin Renvoize commit 27bc382535dea91f1c5adb353858b2df9ef3f2a3 Author: Martin Renvoize Date: Mon Apr 20 12:09:27 2020 +0100 Bug 25127: Use Koha::Number::Price->round for comparison Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 99882e35e1efc5257b084e4d66acd53c7f16856c Author: Martin Renvoize Date: Mon Apr 20 09:34:19 2020 +0100 Bug 25127: Correction to tests Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit f195cb45a82d43549647d0efc904fe2107149d2a Author: Nick Clemens Date: Mon Apr 13 12:47:03 2020 +0000 Bug 25127: Unit tests Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 7761db8052329411d6d67ab282f9f8c136feb567 Author: Katrin Fischer Date: Sat Apr 11 12:02:03 2020 +0000 Bug 25119: Fix account type and description for individual writeoffs/payments When paying or writing off a single line from the list of pending charges, the account type displayed the code instead of the description. And when bug 23483 fixed the display of the description, 2 variables where missed. This change is only visible when looking at the page source: With the patch applied, the value will be filled with the description. To test: - Create one or more manual invoices of different types - Try to pay/write off using the buttons within the table - Verify the account type shows as code, not description - Apply patch - Repeat - Bonus points: Check the source code for the hidden input with description. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/CourseReserves.pm | 5 +- C4/Overdues.pm | 2 +- .../prog/en/modules/members/paycollect.tt | 11 +-- t/db_dependent/Overdues.t | 79 +++++++++++++++++++++- 4 files changed, 88 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 1 17:32:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 May 2020 15:32:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1981-gd9013a1333 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d9013a1333ec911f7f88eef6b362f7f4df604839 (commit) from 04813346c84157902d5926e3128ec147138cfa49 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d9013a1333ec911f7f88eef6b362f7f4df604839 Author: Martin Renvoize Date: Fri May 1 16:04:21 2020 +0100 Bug 24772: Don't revert course item fields when deleting a course item unless it is enabled Deactivating a from Course Reserves reverts Item's Shelving Location correctly, then deleting the same course reverts the Course Reserve Items to old shelving location values. Test Plan: 1) Add items to a Course - make sure they all have shelving locations prior to being added to the course. 2) When adding items change their shelving location to something else. See that Shelving Location has changed; permanent location in parentheses 3) Deactivated course See that Shelving Location has changed back to its original location 4) Deleted course See that Shelving Location has changed back to what was picked during adding it to the Course. 5) Apply this patch, restart all the things! 6) Repeat steps 1-4, note the shelvig location is not lost! NOTE: Empty commit simply to restore the updated test plan and QA signoff Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Hannah Olsen Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 1 20:14:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 May 2020 18:14:30 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-35-ge370007f0e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via e370007f0e04945a82a1fa1af42bfc84ab8855b4 (commit) via 5b10df8bf77c8e7148caf042221d2ecd946742fa (commit) via cf649efd7251243bc824bab542285ba17adafacb (commit) via ef8f3870b41032e1ae388baaeb8f13565a08dfaf (commit) via e6c829d887b8b6aeda98a7ba57dc9ac04b79a7a3 (commit) from d1cb5f562e47be367bf17a8a689a378c88da954e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e370007f0e04945a82a1fa1af42bfc84ab8855b4 Author: Jonathan Druart Date: Wed Apr 8 11:28:31 2020 +0200 Bug 25046: Add test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5b10df8bf77c8e7148caf042221d2ecd946742fa Author: Andreas Roussos Date: Thu Apr 2 19:14:57 2020 +0200 Bug 25046: Include borrowers.othernames in SELECT statement In C4/Utils/DataTables/Members.pm, the SELECT statement that fetches patron data from the database does not include borrowers.othernames in the field list. As a consequence, when the output is in the form of a DataTable, the Template Toolkit files that refer to .othernames (such as the patron-title.inc include) won't display the information from the 'Other name' input field if that field has been filled in. This patch fixes that. Test plan: 0) Have a few patrons with some data in the 'Other name' field. 1) Perform a generic search in Home > Patrons to ensure you will get a DataTable with results. 2) Observe that the 'Name' column does not include 'Other name' info. 3) Apply the patch, and restart Plack if necessary. 4) Repeat your search: this time you should see the information from the 'Other name' field, it will be next to the patron's First name and within parentheses. Sponsored-by: Eugenides Foundation Library Signed-off-by: Devinim Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit cf649efd7251243bc824bab542285ba17adafacb Author: Jonathan Druart Date: Wed Mar 11 16:21:06 2020 +0100 Bug 24826: Remove warnings from Sendmail Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ef8f3870b41032e1ae388baaeb8f13565a08dfaf Author: David Roberts Date: Fri Apr 3 15:23:01 2020 +0000 Bug 24940: Serials statistics wizard: order vendor list alphabetically This patch changes the dropdown from being sorted by aqbookseller.id to aqbookseller.name To test: 1) Add at least 2 vendors: - First: ZZZZ - Second: AAAA 2) Add subscriptions for each of the vendors 3) Check the pull down in the serials statistics wizard and verify it lists them as ZZZZ, AAAA 4) Apply the patch 5) Re-check the pull down in the wizard and check that the vendors are now listed AAAA,ZZZZ Signed-off-by: Devinim Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e6c829d887b8b6aeda98a7ba57dc9ac04b79a7a3 Author: Tomas Cohen Arazi Date: Mon Mar 30 09:39:13 2020 -0300 Bug 25019: Make the ViewPolicy filter initialization standard This patch makes the ViewPolicy filter use the 'params' accessor instead of relying of ->{options} which has no accessor. This will allow interacting with the filter object be similar through all the filters in the chain. To test, we just need to verify no behaviour change takes place: 1. Run: $ kshell k$ prove t/db_dependent/Filter_MARC_ViewPolicy.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 1 + Koha/Email.pm | 4 ++-- Koha/Filter/MARC/ViewPolicy.pm | 16 ++++------------ reports/serials_stats.pl | 3 ++- t/db_dependent/Utils/Datatables_Members.t | 12 +++++++++++- 5 files changed, 20 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 1 23:44:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 May 2020 21:44:44 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-3-g12bf0c91d1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 12bf0c91d1ff15dc2c33cb25c16edbdb5121d740 (commit) from 4c44691ed9c80b2887e1c08ecc2c46f8adfa3411 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 12bf0c91d1ff15dc2c33cb25c16edbdb5121d740 Author: Nick Clemens Date: Thu Apr 23 10:36:20 2020 +0000 Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown There is an issue in that historic values will still be truncated, but recent values are not. I feel the cash register report should reflect recent transactions over historic, and the historic are a data cleanup issue To test: 1 - Add a MANUAL_INV value with more than 5 characters 'INCREDIBLE_HULK' 2 - Add a manual invoice to a patron's acccount using this value 3 - Note the full code displays in patrons account 4 - Browse to Reports->Cash register 5 - Search for today's date, the value you createed, and all libraries 6 - No results returned 7 - Apply patch 8 - Repeat 5 9 - The transaction shows Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 4 10:10:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 04 May 2020 08:10:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2010-gc6edd2d7f3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c6edd2d7f375f624a922bd59c1b275a9bdba6f97 (commit) via d2c01b24586e3828c87c2bb383d864cebf32a7c4 (commit) via b3e30677315ee304a74ae31c6851030e22b31b27 (commit) via 580e6fabff5ec0f564e200a6b2fe42955661b5b7 (commit) via 39138e860ce8e3eb54d2788ba32728baf03122c0 (commit) via e2ace8dfe33c04048a3ef52a5a735cc9aedd54d1 (commit) via 7c325fd6319057e8d8746bf829419f99d0ac9dba (commit) via 8adf22c72511c9252cc90cc4d295f868abc1e718 (commit) via 240b52170be0551830d0d1c77967f271d5ae553e (commit) via c34eb3c95032b9ae54c04a55a5935bdc9691804c (commit) via b76fb4a6c5b6eec9d9ed7a6656bca28e013b6ca9 (commit) via 3db5242ff9d92789ec346d6c278eb54c3bdd7d7d (commit) via e94c5ea20b60401c99cab1ee9c5d0a9b321b9acb (commit) via 1ed4cc6540e48da584763ed24d5571608d14cf61 (commit) via 537ba245eed721d645387b840d6dbffaf98d57df (commit) via 8b6be7cced077e587c00a43080efc548b48fefac (commit) via 3d953d7988df792ca83a13872a39f49480c7e39f (commit) via 219f000069377f8a6b2790e42870083236b66bd0 (commit) via dc0cb0378cdd8260123bc3d0bbc58fd388b5e650 (commit) via 46040fcf862f0c7b6f8bdf9f2b1ecd9f15adf54e (commit) via 78ce445ae49404c7e7344999945abfc576ad8cac (commit) via 02499a45caf241cc55674e89da56e727026391e6 (commit) via 83d78e764e0821037de235b67d269220d7d29f69 (commit) via 77fde261c3e6d199d78c12c631326cd23bea4e6c (commit) via 0ebb62755e56fb4e057ad35db6408e04d237559f (commit) via 0f3e7691a491d71b4804a527ce4d3a0bd3ed44a5 (commit) via b9cfa36d475e0f897398228a1cfe8b0a71b4d227 (commit) via 8e4d0fe9df385be1509d6e636665f55a098af2b2 (commit) via 68425749246ef48f198f30f2d3416ae2ae7360e6 (commit) from d9013a1333ec911f7f88eef6b362f7f4df604839 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c6edd2d7f375f624a922bd59c1b275a9bdba6f97 Author: Jonathan Druart Date: Wed Apr 29 14:57:57 2020 +0200 Bug 25309: Limit size of streetnumber field to 10 It's its size in DB (varchar(10)) Test plan: Create or editing a patron and confirm that you fill in more than 10 characters in the streetnumber field Save => The patron has been correctly created/updated Signed-off-by: David Roberts Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d2c01b24586e3828c87c2bb383d864cebf32a7c4 Author: Katrin Fischer Date: Fri May 1 22:04:15 2020 +0000 Bug 25311: (QA follow-up) Add misssing filter Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit b3e30677315ee304a74ae31c6851030e22b31b27 Author: Jonathan Druart Date: Wed Apr 29 14:48:38 2020 +0200 Bug 25311: Better error handling when updating a patron Same as the precedent patch for patron's modification Test plan is identical but with an existing patron Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 580e6fabff5ec0f564e200a6b2fe42955661b5b7 Author: Jonathan Druart Date: Wed Apr 29 14:38:41 2020 +0200 Bug 25311: Better error handling when creating a patron This is still not ideal but brings a bit of enhancement. One possible problem is that the patron creation will fail if the streetnumber field is too long (borrowers.streetnumber is varchar(10). Test plan: 0. Don't apply this patch 1. Create a new patron with a streetnumber longer than 10 characters 2. Save => The patron has not been created and the app explodes The error is about extended_attributes and not meaningful Can't call method "extended_attributes" on an undefined value at /kohadevbox/koha/members/memberentry.pl line 560 3. Apply the patch 4. Repeat 1. and 2 => You get a warning on the interface and you still see the creation form 5. Check the logs => The error is meaningful "Data too long for column 'streetnumber'" Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 39138e860ce8e3eb54d2788ba32728baf03122c0 Author: Martin Renvoize Date: Mon May 4 08:35:59 2020 +0100 Bug 17268: DBRev 19.12.00.084 Signed-off-by: Martin Renvoize commit e2ace8dfe33c04048a3ef52a5a735cc9aedd54d1 Author: Martin Renvoize Date: Mon May 4 08:33:02 2020 +0100 Bug 17268: Schema Update Signed-off-by: Martin Renvoize commit 7c325fd6319057e8d8746bf829419f99d0ac9dba Author: Katrin Fischer Date: Fri May 1 21:35:38 2020 +0000 Bug 17268: (follow-up) Don't show the macro ID in front of description I believe it's nicer to allow users to organize the macros as they want using the descrpitions they prefer. Submitting as a suggestion. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 8adf22c72511c9252cc90cc4d295f868abc1e718 Author: Katrin Fischer Date: Fri May 1 23:33:00 2020 +0200 Bug 17268: (QA follow-up) Make "Convert old browser macros" translatable The code was missing the necessary markup to make the string translatable. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 240b52170be0551830d0d1c77967f271d5ae553e Author: Nick Clemens Date: Wed Apr 22 21:13:34 2020 +0000 Bug 17268: Update patchs per RFC https://wiki.koha-community.org/wiki/Advanced_editor_macros_endpoint_RFC Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit c34eb3c95032b9ae54c04a55a5935bdc9691804c Author: Nick Clemens Date: Fri Mar 27 10:38:04 2020 +0000 Bug 17268: (follow-up) Fix translatability This patch moves the error messages to translatable strings Also includes capitalization fixes and POD adjustment Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit b76fb4a6c5b6eec9d9ed7a6656bca28e013b6ca9 Author: Nick Clemens Date: Wed Mar 11 09:39:25 2020 -0400 Bug 17268: Set boolean for shared column in schema Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 3db5242ff9d92789ec346d6c278eb54c3bdd7d7d Author: Nick Clemens Date: Thu Jan 2 15:02:04 2020 +0000 Bug 17268: Schema update Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit e94c5ea20b60401c99cab1ee9c5d0a9b321b9acb Author: Nick Clemens Date: Wed Mar 11 09:31:39 2020 -0400 Bug 17268: (follow-up) Fix licenses Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 1ed4cc6540e48da584763ed24d5571608d14cf61 Author: Nick Clemens Date: Tue Mar 3 13:14:03 2020 +0000 Bug 17268: Use API to store/retrieve values To test: 1 - Enable AdvancedCatalogingEditor 2 - Add some macros (they don't need to be valid, just have content) 3 - Apply patches 4 - updatedatabase 5 - Set user to have 'create_shared_macros' and 'delete_shared_macros' 6 - Load the advanced editor (Cataloging->Advanced editor) 7 - Click on 'Macros' 8 - Previous macros should not show, but you should have a 'Convert' button 9 - Convert old macros and confirm they show 10 - Edit the macros, changing content and the public checkbox, confirm 'Saved' shows in the top right of editor when updating 11 - Have at least on valid macro and run it, e.g.: new 100=Testing this out 12 - Run the macro, confirm it runs 13 - Try a macro with gibberish, confirm there is an error when running 14 - Ensure you have a few macros marked public 15 - In a private browser window sign in as a patron with neither shared macro permission 16 - Confirm the public macros load, but cannot be edited 17 - Grant create_shared_macros permission to this patron 18 - Reload editor, they should now be able to edit shared macros 19 - Confirm they cannot delete shared macros 20 - Grant delete_shared_macros permission 21 - Reload editor 22 - Confirm they can now delete shared macros Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 537ba245eed721d645387b840d6dbffaf98d57df Author: Nick Clemens Date: Wed Dec 4 11:39:41 2019 +0000 Bug 17268: Advanced cataloging editor macros - add endpoint Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 8b6be7cced077e587c00a43080efc548b48fefac Author: Nick Date: Wed Oct 2 13:28:39 2019 +0000 Bug 17268: Add macros table and permissions Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 3d953d7988df792ca83a13872a39f49480c7e39f Author: Bernardo Gonzalez Kriegel Date: Tue Apr 28 19:37:52 2020 -0300 Bug 24808: enable translation on results.js String sorrounded by "__()" To test: 1) create translation files for a language (cd misc/translator; ./translate create xx-YY) 2) Check string egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 2 files, opac-bootstrap and staf-prog 3) Apply patch 4) Create files again (cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY) 5) Check again egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 3 files, new in messages-js Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 219f000069377f8a6b2790e42870083236b66bd0 Author: Martin Renvoize Date: Mon May 4 07:46:00 2020 +0100 Bug 17355: DBRev 19.12.00.083 Signed-off-by: Martin Renvoize commit dc0cb0378cdd8260123bc3d0bbc58fd388b5e650 Author: Katrin Fischer Date: Fri May 1 17:47:07 2020 +0200 Bug 17355: (QA follow-up) Add description to updatedatabase entry Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 46040fcf862f0c7b6f8bdf9f2b1ecd9f15adf54e Author: Jonathan Druart Date: Tue Apr 28 11:53:57 2020 +0200 Bug 17355: Add the ability to remove authorised value categories This new patch set is adding a new DB field is_system to distinguish internal categories. The list of internal categories is in the patch "DB changes - set is_system for categories" and can be discussed/extended. Test plan: 0. - Apply patch - updatedabase 1. - Create a new AV category - Create an authorised value - List the AVs for this category - Remove all the AVs for this category => You see 2 buttons "Add a new authorised value" and "Delete category 'XXX'" - Click the delete button => You get a popup - Accept => The category is deleted 2. - List the AV for Asort1 (internal category) /cgi-bin/koha/admin/authorised_values.pl?searchfield=Asort1 - Delete the AVs for this category (if there is any) => You do not see the "Delete category" button 3. - Create a new AV category 'foo' - Create an authorised value - Hit /admin/authorised_values.pl?op=delete_category&categor_name=foo => You get an error message (expected because the category cannot be deleted if it has AV linked) => message text: => An error occurred when deleting this authorized value category. Check the logs. 4. - Hit /admin/authorised_values.pl?op=delete_category&categor_name=Asort1 => You get an error message (expected because the category Asort1 cannot be deleted, it's an internal category. => message text: => An error occurred when deleting this authorized value category. Check the logs. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 78ce445ae49404c7e7344999945abfc576ad8cac Author: Jonathan Druart Date: Tue Apr 28 11:32:23 2020 +0200 Bug 17355: DB changes - set is_system for categories Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 02499a45caf241cc55674e89da56e727026391e6 Author: Jonathan Druart Date: Tue Apr 28 11:23:02 2020 +0200 Bug 17355: Override delete methods Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 83d78e764e0821037de235b67d269220d7d29f69 Author: Jonathan Druart Date: Tue Apr 28 11:05:46 2020 +0200 Bug 17355: DBIC changes - boolean flag Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 77fde261c3e6d199d78c12c631326cd23bea4e6c Author: Jonathan Druart Date: Tue Apr 28 11:03:25 2020 +0200 Bug 17355: DBIC changes Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0ebb62755e56fb4e057ad35db6408e04d237559f Author: Jonathan Druart Date: Tue Apr 28 11:01:19 2020 +0200 Bug 17355: DB changes This patch adds a new authorised_value_category.is_system boolean/tinyint(1) DB field. Name 'is_system' is coming from existing tables account_credit_types and account_debit_types and should not be discussed here (if you disagree fill a new bug report and deal with naming issue separately) Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0f3e7691a491d71b4804a527ce4d3a0bd3ed44a5 Author: Martin Renvoize Date: Mon May 4 07:40:21 2020 +0100 Bug 23433: (RM follow-up) One last consistency improvement Signed-off-by: Martin Renvoize commit b9cfa36d475e0f897398228a1cfe8b0a71b4d227 Author: Owen Leonard Date: Fri Mar 6 15:06:02 2020 +0000 Bug 23433: Make consistent use of patron-title.inc in hold confirmation dialogs Use of patron-title.inc on the checkin page is inconsistent, resulting in patron names being displayed differently under different circumstances. This patch makes it more consistent. To test, apply the patch and check in items with the following statuses: - On hold for a patron at your library - On hold for a patron not at your library - On hold and already marked 'Waiting' - On hold while HoldsAutoFill preference is enabled - An item which has been marked with a LOST status in the 'ClaimReturnedLostValue' system preference. - An item which was checked out to a manually-restricted patron and checked in with a back-dated checkin date. See test plan on Bug 24776. Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 8e4d0fe9df385be1509d6e636665f55a098af2b2 Author: Martin Renvoize Date: Wed Dec 11 11:53:51 2019 +0000 Bug 15751: Add ModDateLastSeen to ProcessOfflineReturn Test plan: 1) Before the patch when one checks in something using the KOCT the last seen date is not updated. 2) After the patch when one checks in something using the KOCT the last seen date is updated. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 68425749246ef48f198f30f2d3416ae2ae7360e6 Author: Martin Renvoize Date: Fri May 1 17:27:52 2020 +0100 Bug 23794: (RM follow-up) Make DB update consistent Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 + Koha.pm | 2 +- Koha/{Desk.pm => AdvancedEditorMacro.pm} | 23 +- Koha/{Desks.pm => AdvancedEditorMacros.pm} | 15 +- Koha/AuthorisedValueCategories.pm | 20 + Koha/AuthorisedValueCategory.pm | 15 + Koha/REST/V1/AdvancedEditorMacro.pm | 395 ++++++++++++++++ .../{Discharge.pm => AdvancedEditorMacro.pm} | 72 +-- Koha/Schema/Result/AuthorisedValueCategory.pm | 16 +- Koha/Schema/Result/Borrower.pm | 19 +- admin/authorised_values.pl | 16 +- api/v1/swagger/definitions.json | 3 + .../swagger/definitions/advancededitormacro.json | 26 + api/v1/swagger/parameters.json | 3 + api/v1/swagger/parameters/advancededitormacro.json | 9 + api/v1/swagger/paths.json | 12 + api/v1/swagger/paths/advancededitormacros.json | 521 +++++++++++++++++++++ api/v1/swagger/x-primitives.json | 5 + installer/data/mysql/kohastructure.sql | 16 + installer/data/mysql/mandatory/auth_val_cat.sql | 86 ++-- installer/data/mysql/updatedatabase.pl | 62 ++- installer/data/mysql/userpermissions.sql | 2 + .../prog/en/includes/cateditor-ui.inc | 264 +++++++++-- .../en/includes/member-main-address-style-de.inc | 2 +- .../en/includes/member-main-address-style-fr.inc | 2 +- .../en/includes/member-main-address-style-us.inc | 2 +- .../intranet-tmpl/prog/en/includes/permissions.inc | 10 + .../prog/en/modules/admin/authorised_values.tt | 29 +- .../prog/en/modules/cataloguing/editor.tt | 6 + .../intranet-tmpl/prog/en/modules/circ/returns.tt | 23 +- .../prog/en/modules/members/memberentrygen.tt | 11 + koha-tmpl/intranet-tmpl/prog/js/pages/results.js | 4 +- members/memberentry.pl | 130 ++--- t/db_dependent/AuthorisedValues.t | 27 +- t/db_dependent/api/v1/advanced_editor_macros.t | 474 +++++++++++++++++++ 35 files changed, 2091 insertions(+), 233 deletions(-) copy Koha/{Desk.pm => AdvancedEditorMacro.pm} (67%) copy Koha/{Desks.pm => AdvancedEditorMacros.pm} (78%) create mode 100644 Koha/REST/V1/AdvancedEditorMacro.pm copy Koha/Schema/Result/{Discharge.pm => AdvancedEditorMacro.pm} (50%) create mode 100644 api/v1/swagger/definitions/advancededitormacro.json create mode 100644 api/v1/swagger/parameters/advancededitormacro.json create mode 100644 api/v1/swagger/paths/advancededitormacros.json create mode 100644 t/db_dependent/api/v1/advanced_editor_macros.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 4 10:22:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 04 May 2020 08:22:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2025-ge64d3c8d67 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e64d3c8d675040aa8213c1b4d6ee93267b741986 (commit) via 9776d591ece45b36365f69315e2c958f264bc76f (commit) via 1f00c2a9a911b180d20638bafa26463d5e7a6619 (commit) via 0650c9abdf1605030e86596c1000a91aaac8c5f5 (commit) via 0e34f36d47fb2a5e7834b5f6b73e453d487d67b7 (commit) via 3f752ce2b85bf600cca2e59b1bcd69a5854016aa (commit) via 0610dbd6fce4ffcc1dff0c69424d70703afa722e (commit) via a8d5b11629f74174c7e6169bfdc5ac969d9ed990 (commit) via 83c65d975f8712c9d50ecf65033cdc1012698986 (commit) via ebded0c3326e87aacba57c082d3ddf8fe37b510f (commit) via 263a889be4f3ec002b779abe0917da664e9b6ade (commit) via 569f3915d7212f580b7a5bf6c7767c6374c279dd (commit) via 4317229ae9096453ece8464d09375488ff322e21 (commit) via 3e4409155339139366d7cb586ee775a89d7f4c0b (commit) via 1667a5af935115a812bc95db26d31521ccb5ee44 (commit) from c6edd2d7f375f624a922bd59c1b275a9bdba6f97 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e64d3c8d675040aa8213c1b4d6ee93267b741986 Author: Alex Buckley Date: Fri Oct 20 23:22:13 2017 +0000 Bug 18308: Increase minPasswordLength default to 8 To test: - Run the web installer for any language - Verify that minPasswordLength is set to 8 now Sponsored-By: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 9776d591ece45b36365f69315e2c958f264bc76f Author: Owen Leonard Date: Fri May 1 12:43:40 2020 +0000 Bug 25340: Pass biblio object to OPAC comments template This patch modifies the OPAC comments system so that the biblio object is passed to the template. This allows the biblio-title include to properly access the title and subtitle information. Unrelated change: Remove some custom CSS from the page which was obsolete. To test, apply the patch and make sure the "reviewson" preference is enabled. - Log in to the OPAC and open a bibliographic record's detail page. - Under the "Comments" tab, click the "Post your comments" link to trigger the pop-up window. - In the pop-up window, verify that the item's title is correct in the page title and the heading. Author should display correctly, if present. - Test submitting a comment and editing a comment. Everything should work correctly. Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 1f00c2a9a911b180d20638bafa26463d5e7a6619 Author: Bernardo Gonzalez Kriegel Date: Sun May 3 19:19:21 2020 -0300 Bug 24636: (follow-up) - move 'by' into include file To ease correct translation. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0650c9abdf1605030e86596c1000a91aaac8c5f5 Author: Bernardo Gonzalez Kriegel Date: Tue Apr 28 21:21:09 2020 -0300 Bug 24636: translate planning sections This patch adds a new inc file to process and translate plannig sections To test: 1) Apply patch 2) Create new language files (cd misc/translator; ./translate create xx-YY) 3) Verify new file is taken into account in translation files egrep -n budget_planning misc/translator/xx-YY*.po check new strings in staff-prog file 4) Go to Administration > Budgets > Founds > Planning select different options, check page title and 'Planning for...' phrase 5) Translate strings, install new language, enable it, verify the text change with options like point 4) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0e34f36d47fb2a5e7834b5f6b73e453d487d67b7 Author: Andrew Fuerste-Henry Date: Thu Apr 30 19:35:51 2020 +0000 Bug 25335: group by authorised_value in addbiblio.pl To Test: 1- Edit your default framework, connect any subfield outside of the 952 to an authorised value (for example, connect the 942$n to the Yes_No auth value) 2 - Find a record in that framework 3 - Edit the record and find your subfield 4 - The subfield shows a dropdown with no contents 5 - check plack log, see "DBD::mysql::st execute failed: 'koha_kohadev.authorised_values.authorised_value' isn't in GROUP BY " 6 - apply patch, restart all 7 - reload edit record page, see your auth value dropdown has contents Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 3f752ce2b85bf600cca2e59b1bcd69a5854016aa Author: Nick Clemens Date: Tue Apr 21 12:06:09 2020 +0000 Bug 25133: (follow-up) Remove Names as they do no affect display In testing I couldn't make any changes to the names have an effect and everythign worked as expected without these lines Signed-off-by: Nick Clemens Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0610dbd6fce4ffcc1dff0c69424d70703afa722e Author: Jonathan Druart Date: Mon Apr 20 10:59:55 2020 +0200 Bug 25133: Handle 12hr format for dt_from_string Signed-off-by: Nick Clemens Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit a8d5b11629f74174c7e6169bfdc5ac969d9ed990 Author: Jonathan Druart Date: Fri Apr 17 12:11:25 2020 +0200 Bug 25133: Fix time part of due date for 12hr With Timeformat system preference set to 12 hours format: Prior to 19.05.08, when due date was specified at checkout, the time in the box would show in 24hr format (e.g. 15:59) while the due date in the patron's checkouts would show in 12hr format (e.g. 3:59 PM). After 19.05.08, the format in the specify a due date box shows in 24hr format and the due date in 12hr format (in patron checkouts) as before. But when checking out multiple items using the specify due date option for the session, the time changes from PM to AM. To test: - Check out an item with specified due date 15:50 PM - Check out a second item in same transaction - Verify date changed to AM - Apply patch - Repeat - Verify this time the date is kept as set Signed-off-by: Nick Clemens Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 83c65d975f8712c9d50ecf65033cdc1012698986 Author: Jonathan Druart Date: Wed Apr 29 11:53:45 2020 +0200 Bug 25305: Translation process - Open all files specifying the utf8 encoding To test: 1) Create translation files for a new language ( cd misc/translator; ./translate create xx-YY) A new language means one that isn't already in Koha, xx-YY=>something you invent. 2) Verify double encoding egrep "Aix-Marseille|Jean Prunier|periodika|Bokm" misc/translator/po/xx-YY-* check strange strings 3) Apply the patch 4) Create po files again ( cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY) 5) Verify no more double encoding egrep "Aix-Marseille|Jean Prunier|periodika|Bokm" misc/translator/po/xx-YY-* check normal string Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Didier Gautheron Signed-off-by: Martin Renvoize commit ebded0c3326e87aacba57c082d3ddf8fe37b510f Author: Owen Leonard Date: Mon Apr 27 13:20:23 2020 +0000 Bug 22515: Improve logic determining how to show OPAC suggestions This patch makes changes to the OPAC suggestions view so that the logic around logged in users and the OPACViewOthersSuggestions preference is more specific. To reproduce the bug you should have pending purchase susggestions in your system from more than one patron. 1. Set the OPACViewOthersSuggestions preference to "Show." 2. Log in to the OPAC as a user who has not submitted any suggestions. 3. Follow the link to the purchase suggestions page from the menu under the search bar. 4. The page will say that there are no purchase suggestions. 5. Add "?suggested_by_anyone=1" to the end of the page URL. 6. You should see suggestions from other users. To test, apply the patch and repeat steps 2-3 above. The suggestions page should show other patrons' suggestions. Test with different combinations of factors: - Logged in user, OPACViewOthersSuggestions off - No logged in user, OPACViewOthersSuggestions on - No logged in user, OPACViewOthersSuggestions off Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 263a889be4f3ec002b779abe0917da664e9b6ade Author: Nick Clemens Date: Wed Apr 22 12:11:53 2020 +0000 Bug 25247: Only convert data ot objects when displaying on screen To test: 1 - Modify a patron 2 - Circulate some items to the patron 3 - Click 'Modification log' 4 - Verify you see your actions 5 - Under 'Output' select 'To a file' 6 - Save the output to a file 7 - View the file 8 - Not you have references ot objects in stead of patron/item data 9 - Apply patch 10 - Repeat 11 - Note viewing on screen has not changed 12 - Note exporting to file inlcudes borrower/item numbers and not references 13 - Sign off Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 569f3915d7212f580b7a5bf6c7767c6374c279dd Author: Owen Leonard Date: Wed Apr 29 17:57:44 2020 +0000 Bug 21565: (follow-up) Make confirmation buttons more detailed This patch updates the confirmation buttons to be more specific about what each one does. My concern was that it wasn't clear that "No" meant "No receipt" and not "Cancel logging out." The patch also updates the modal confirmation code so that the modal body is removed if no message is passed for it. To test, apply the patch and repeat the previous test plan. When you click "Finish" you should have the options "Print receipt and end session" and "End session." Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 4317229ae9096453ece8464d09375488ff322e21 Author: Lucas Gass Date: Fri Apr 24 18:39:02 2020 +0000 Bug 21565: Add modal to SCO confirm This patch uses the confirmModal framework to add a modal confirm to SCO Finish. TO TEST: 1. Enable SCO and go to /cgi-bin/koha/sco/sco-main.pl. Make sure SelfCheckReceiptPrompt is set to 'show' 2. Login and click 'Finish' to see the old print alert box. 3. Apply patch and repeat steps 1 and 2. 4. Make sure the modal works for confirming and denying a receipt. Checkout some items and make sure everything still functions the same. 5. Make sure when printing a receipt that the print dialog automatally shows 6. Set SelfCheckReceiptPrompt to 'Don't show' and confirm behavior is acceptable. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize commit 3e4409155339139366d7cb586ee775a89d7f4c0b Author: Kyle M Hall Date: Fri Apr 10 06:58:43 2020 -0400 Bug 25107: Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType At some point some calls to maybe_add got an extra $server var in their parameter lists. This doubled parameter does nothing and should be removed. Test Plan: No change in behavior should be noted Signed-off-by: Frédéric Demians Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 1667a5af935115a812bc95db26d31521ccb5ee44 Author: David Roberts Date: Mon Apr 6 23:42:19 2020 +0000 Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a This patch makes the subfield i display before subfield a in the 246 and 730 fields To test: 1) Create a bibliographic record with data in several subfields in tags 246 and 730. 2) See that subfield i displays at the end of the field in the 246 field, and probably not at all in the 730 field. Check in both the OPAC and staff client 3) Apply the patch. 4) Check your bib record again in both clients. Subfield i should now display before subfield a. Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/SIP/Sip/MsgType.pm | 30 +++++++++++----------- C4/TTParser.pm | 3 ++- Koha/DateUtils.pm | 9 +++++++ cataloguing/addbiblio.pl | 2 +- circ/circulation.pl | 2 +- installer/data/mysql/sysprefs.sql | 2 +- .../prog/en/includes/budget_planning.inc | 7 +++++ .../intranet-tmpl/prog/en/includes/calendar.inc | 4 +++ .../intranet-tmpl/prog/en/modules/admin/aqplan.tt | 5 ++-- .../prog/en/modules/circ/circulation.tt | 2 +- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 15 ++++++++--- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 6 ++--- .../opac-tmpl/bootstrap/en/modules/opac-review.tt | 11 +++----- .../bootstrap/en/modules/opac-suggestions.tt | 18 ++++++++++--- .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 17 +++++++----- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 15 ++++++++--- koha-tmpl/opac-tmpl/bootstrap/js/global.js | 6 ++++- misc/translator/xgettext.pl | 6 ++--- opac/opac-review.pl | 3 +-- t/DateUtils.t | 13 +++++++++- tools/viewlog.pl | 4 +-- 21 files changed, 123 insertions(+), 57 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/budget_planning.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 4 11:12:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 04 May 2020 09:12:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2052-g67f695001a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 67f695001a17556fc3b1796181fff9a1493cae94 (commit) via d6ab91721366264d40fd092f6a2e1e7f74dfb8b5 (commit) via a18e944400efd354f2b755459f45e249f8a24468 (commit) via e294eb1dd7965347fcbcb4aecb81d3eb4140232c (commit) via 1cf3f11bbda3ed0bc71dbee2853da2fbd0778e0b (commit) via 6b34eab8570e1899e9a3395ddee2850f53fd1e15 (commit) via 6a8f3ba98feb6bfbc349d20e696e0ecaec2b3452 (commit) via b2de93144a3091e282c3a49e7c6957b91309ae17 (commit) via 33745001d1faf1c60a520297f7fad95a2e519604 (commit) via d2c2e7740fb5fc52e44c6363a217ce6c0f6bda47 (commit) via b58c1c692b2bf335caac68968aaedd767b7977e2 (commit) via 2556e39a34750e6f3cb7061c6d9eeb32dd0f7f53 (commit) via 878ab699fca320ba30b8f53a4015696a09c4e61d (commit) via 0963451d65016d6c6c6a4ce4974ef6da18fc011c (commit) via aca15e62532cdc05568c35e9014bc7e233d3a79f (commit) via 1dc361e824dbd60cb8aaade702c9873ea8942e44 (commit) via 140079c807b68d48cc5abcd92a3b3cd55fd5e8cf (commit) via 39d904e21d8adce183dc068a26172d8924dc10fa (commit) via 6c4375adb5f1bc9a1e3a70c49af43a3c02e0b8b1 (commit) via a867743f94402b475fcc3d62897ec6a23b2bec22 (commit) via a15932117cae6341a91cd0f21bdd05fb2a4c0922 (commit) via d94be594a2cc55bfac8962473b3e12faa0d294cd (commit) via 4bad65addf1c19cc736af7c23bfee474ff53068b (commit) via 5a861749d911585d64f671c64ec86f8fd07c6748 (commit) via 20c3d85b5e4d99e5a9aece8a081e29ca3723c3fe (commit) via e36e73506e7497ef6debf2ad32534ed8a223e994 (commit) via 308d67950ea1b2560a2f71b1f69750b45b83834f (commit) from e64d3c8d675040aa8213c1b4d6ee93267b741986 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 67f695001a17556fc3b1796181fff9a1493cae94 Author: Owen Leonard Date: Fri May 1 18:29:33 2020 +0000 Bug 25350: Load Emoji picker assets more efficiently This patch moves the Emoji picker JS assets out of opac-bottom.inc and into opac-detail.tt. This prevents the assets from being loaded on every page of the OPAC when they're only used on opac-detail. The patch also combines and minifies the 4 JavaScript files used by the feature. opac-detail.tt now loads only the one file. To test, apply the patch and make sure the TagsEnabled and TagsInputOnDetail preferences are enabled. - Log in to the OPAC and view the detail page for a bibliographic record. - Click the "Add tag(s)" link - Verify that the emoji-picker works for adding emojis Signed-off-by: David Roberts Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d6ab91721366264d40fd092f6a2e1e7f74dfb8b5 Author: Martin Renvoize Date: Mon May 4 09:26:39 2020 +0100 Bug 24161: Schema Fixes Signed-off-by: Martin Renvoize commit a18e944400efd354f2b755459f45e249f8a24468 Author: Martin Renvoize Date: Mon May 4 09:23:19 2020 +0100 Bug 24161: DBRev 19.12.00.085 Signed-off-by: Martin Renvoize commit e294eb1dd7965347fcbcb4aecb81d3eb4140232c Author: Jonathan Druart Date: Sat May 2 15:28:23 2020 +0200 Bug 24161: (follow-up) DB changes Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 1cf3f11bbda3ed0bc71dbee2853da2fbd0778e0b Author: Jonathan Druart Date: Sat May 2 15:26:42 2020 +0200 Bug 24161: Fix license statements Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 6b34eab8570e1899e9a3395ddee2850f53fd1e15 Author: Jonathan Druart Date: Thu Apr 23 13:41:04 2020 +0200 Bug 24161: Display claimed dates vertically Signed-off-by: Angela O'Connor Desmond Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 6a8f3ba98feb6bfbc349d20e696e0ecaec2b3452 Author: Jonathan Druart Date: Wed Apr 1 14:30:54 2020 +0200 Bug 24161: DBIC manual changes No idea what's happening with the current_timestamp, but previous change was wrong. Signed-off-by: Angela O'Connor Desmond Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit b2de93144a3091e282c3a49e7c6957b91309ae17 Author: Jonathan Druart Date: Wed Jan 8 23:47:02 2020 +0100 Bug 24161: Add tests Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 33745001d1faf1c60a520297f7fad95a2e519604 Author: Jonathan Druart Date: Wed Jan 8 21:45:09 2020 +0100 Bug 24161: Remove GetLateOrders Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d2c2e7740fb5fc52e44c6363a217ce6c0f6bda47 Author: Jonathan Druart Date: Mon Dec 16 18:35:08 2019 +0100 Bug 24161: Keep tracks of late orders claims So far we only record the number of claims and the date of the last claim, in the aqorders table. To keep track of the different claim dates, this patchset is going to make the following DB changes: * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on) * Remove the two columns from the aqorders table: claims_count and claimed_date This will allow to display the different claim dates where needed: on the late orders page, and the basket page. To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders has been moved to Koha::Acquisition::Orders->filter_by_late That way we are going to add consistency, robustness, and cover the feature with new tests. Test plan: 0/ Create a bunch of new orders. Make sure they are from different vendor (with different delivery time). 1/ Go to the late orders page and claim some orders 2/ Reclaim some of those orders 3/ Confirm that you can see the different claim dates for a given orders (the history of the late orders claims is kept and displayed) 4/ Bonus point: Regression tests: a. Modify the closedate of the basket in the database. That will allow you to make sure the patch set did not introduce regressions. It would be good to test the different filters on the late orders page: * delay * Estimated delivery date from/to * Vendor b. Confirm that the subtotal and the total values from the late orders page is correct. c. Test the update database entry: do not apply these patches, claims some orders against master. Apply the patch, execute the update DB entry then confirm that the number of claims is correct (note that the dates will not as it is not possible to guess them). QA note: the branchcode parameter has been removed from filter_by_late. At first glance it seems that it was not used. Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit b58c1c692b2bf335caac68968aaedd767b7977e2 Author: Jonathan Druart Date: Mon Dec 16 17:34:12 2019 +0100 Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 2556e39a34750e6f3cb7061c6d9eeb32dd0f7f53 Author: Jonathan Druart Date: Mon Dec 16 17:30:55 2019 +0100 Bug 24161: DBIC changes Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 878ab699fca320ba30b8f53a4015696a09c4e61d Author: Jonathan Druart Date: Mon Dec 16 17:20:31 2019 +0100 Bug 24161: DB changes Sponsored-by: Cork Institute of Technology Signed-off-by: Angela O'Connor Desmond Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0963451d65016d6c6c6a4ce4974ef6da18fc011c Author: Katrin Fischer Date: Sat May 2 04:29:11 2020 +0200 Bug 24995: (QA follow-up) Terminology: Use checkin and checkout ... instead of issue and return. Signed-off-by: Katrin Fischer commit aca15e62532cdc05568c35e9014bc7e233d3a79f Author: Lucas Gass Date: Thu Mar 26 21:17:42 2020 +0000 Bug 24995: Add issuedate to table_account_fines and finest TO TEST: 1. Have a patron with some fines on an item. Try accruing fines. 2. Go to the accounting tab and look at both the Tranaction tab and Make a payment Tab 3. No Issue Date 4. Apply patch 5. Check those tabs again and see the issue date displays. 6. Go to column configuration and try to hide the issuedate, make sure it hides properly. Try this for both tables. Also make sure other columns hide properly. 7. Sign off! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 1dc361e824dbd60cb8aaade702c9873ea8942e44 Author: Didier Gautheron Date: Thu Feb 27 10:51:19 2020 +0100 Bug 24740: Use biblio title rather than biblio number in OPAC search result cover images tooltips In OPAC biblionum doesn't mean much to patrons, use biblio title field if not empty. Test plan: OPAC search 1) Apply the patch 2) For each cover images providers available to tester in: /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=Cover OPACLocalCoverImages, AdlibrisEnabled, OPACAmazonCoverImages, GoogleJackets, Coce provider. 3) Enable the provider. 4) Search a Library Catalog for a book with a cover image. 6) test mouse over cover image display biblio title. OPAC Shelves 1) Enable OPAC virtualshelves preference 2) Create a list. 3) For each covers providers available. 4) Search the List 5) test mouse over cover image display biblio title. Signed-off-by: Stina Hallin Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 140079c807b68d48cc5abcd92a3b3cd55fd5e8cf Author: Katrin Fischer Date: Sat May 2 03:31:30 2020 +0200 Bug 15668: (QA follow-up) Add date accessioned to column configuration The date accessioned column in the items table was not configurable in the columns settings. To test: - Make sure the Date accessioned is shown in the column list on both tables - Make sure that configuring it via Adminitration > Configure columns works as intended Signed-off-by: Martin Renvoize commit 39d904e21d8adce183dc068a26172d8924dc10fa Author: Katrin Fischer Date: Sat May 2 03:22:44 2020 +0200 Bug 15668: (QA follow-up) Fix capitalization Course Reserves Signed-off-by: Martin Renvoize commit 6c4375adb5f1bc9a1e3a70c49af43a3c02e0b8b1 Author: Lucas Gass Date: Mon Mar 16 17:48:26 2020 +0000 Bug 15668: (follow up) add selector to th follow up add a selector to the to ensure we count the table in questions. Should not affect other pages but is needed on detail.tt where there are two tables to configure Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit a867743f94402b475fcc3d62897ec6a23b2bec22 Author: Lucas Gass Date: Thu Mar 12 14:50:57 2020 +0000 Bug 15668: Add column configuration to the items table in staff detail pages To test: 1 - Apply patches 2 - View biblio details in staff client 3 - Should be able to toggle columns 4 - Go to admin columns settings 5 - Change some settings, verify they work 6 - Enable SeparateHoldings 7 - Go to a record that has holdings from 2 different branches 8 - Change some settings, verify they work. 9 - Check the Other Holdings Tabs, change some settings make sure they work. 10. - Test all the dataTable functions like the search box, columns, export. make sure they on both tabs Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit a15932117cae6341a91cd0f21bdd05fb2a4c0922 Author: Lucas Gass Date: Fri May 1 17:01:11 2020 +0000 Bug 25341: Remove whitespace from barcode in add_items.pl TEST PLAN: 1. Go to course reserves and trying adding a course with a barcode that has some leading/trailing whitespace. 2. It doesnt work 3. Apply patch and restart_all 4. Try again with leading/trailing whitespace, it should work. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d94be594a2cc55bfac8962473b3e12faa0d294cd Author: Owen Leonard Date: Fri May 1 13:23:12 2020 +0000 Bug 24522: Show alert when trying to add nothing to a list in staff This patch modifies the JavaScript which handles the process of adding items to a list in the staff client. Error-handling is added in the case when a set of biblionumbers hasn't been passed to the vShelf function. To test, apply the patch and perform a catalog search in the staff client. On the search results page, select any list from the "Add to list" menu at the top of the search results table without checking any checkboxes. You should get an alert, "No item was selected." Also test that adding to a list works correctly after selecting one or more titles. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 4bad65addf1c19cc736af7c23bfee474ff53068b Author: Martin Renvoize Date: Mon May 4 09:44:09 2020 +0100 Bug 13388: Compiled CSS Signed-off-by: Martin Renvoize commit 5a861749d911585d64f671c64ec86f8fd07c6748 Author: Katrin Fischer Date: Fri May 1 15:07:07 2020 +0000 Bug 13388: (QA follow-up) Add id to nav item and use singleBranchMode This uses the existing singleBranchMode variable to display either Library or Libraries depending on the number of existing libraries in the installation. It also adds an id to the navigation item for customization purposes. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 20c3d85b5e4d99e5a9aece8a081e29ca3723c3fe Author: Martin Renvoize Date: Fri May 1 15:12:14 2020 +0100 Bug 13388: (follow-up) Inlcude OpacNav I believe this page should include the optional OpacNav and OpacNavBottom blocks Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit e36e73506e7497ef6debf2ad32534ed8a223e994 Author: Owen Leonard Date: Fri May 1 12:06:03 2020 +0000 Bug 13388: (follow-up) Remove display of email address Since the email address configured for a library may not be the email address libraries want to use as a contact email address the email should not be displayed by default. This patch removes display of the email address. Libraries may choose to add the information to the opac_info column, so there is already a built-in alternative. To test, apply the patch and view the detail page for a library in your system which has an email address configured. The email address should not display on the page. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 308d67950ea1b2560a2f71b1f69750b45b83834f Author: Owen Leonard Date: Tue Apr 28 19:23:55 2020 +0000 Bug 13388: Add library pages to the OPAC This patch adds a script and a template for showing library information pages in the OPAC. A "libraries" page lists all the libraries in the system, linking to individual pages for each library showing more information.. If there is only one library in the system the page shows all of that library's information. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to /cgi-bin/koha/opac-library.pl in the OPAC. - Verify that all the correct information is displayed for the libraries in your system. - Verify that page title and breadcrumbs look correct. - Click to view details for a library. - The details page should show the full contents of branches.opac_info - A menu should show links to other libraries' detail pages. EDIT: This revised patch adds a "Libraries" link to the links under the search bar; Corrects encoding in the breadcrumb link; Makes the page title more specific when viewing an individual library. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 132 +-------------- Koha.pm | 2 +- Koha/Acquisition/Basket.pm | 51 ++++++ Koha/Acquisition/Order.pm | 57 +++++++ Koha/{ActionLog.pm => Acquisition/Order/Claim.pm} | 12 +- .../Methods.pm => Acquisition/Order/Claims.pm} | 12 +- Koha/Acquisition/Orders.pm | 99 +++++++++++ Koha/Schema/Result/Aqorder.pm | 35 ++-- .../Result/{AqordersItem.pm => AqordersClaim.pm} | 33 ++-- acqui/basket.pl | 1 + acqui/lateorders-export.pl | 6 +- acqui/lateorders.pl | 38 ++--- admin/columns_settings.yml | 109 +++++++++++- course_reserves/add_items.pl | 2 + installer/data/mysql/kohastructure.sql | 14 +- installer/data/mysql/updatedatabase.pl | 35 ++++ .../prog/en/includes/columns_settings.inc | 2 +- .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 6 + .../prog/en/modules/acqui/csv/lateorders.tt | 4 +- .../prog/en/modules/acqui/lateorders.tt | 71 ++++---- .../prog/en/modules/acqui/showorder.tt | 4 +- .../prog/en/modules/catalogue/detail.tt | 56 ++++--- .../prog/en/modules/members/boraccount.tt | 8 +- .../intranet-tmpl/prog/en/modules/members/pay.tt | 14 +- koha-tmpl/intranet-tmpl/prog/js/basket.js | 2 + koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 22 +++ .../opac-tmpl/bootstrap/en/includes/masthead.inc | 7 + .../bootstrap/en/includes/opac-bottom.inc | 12 -- .../bootstrap/en/includes/shelfbrowser.inc | 12 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 23 ++- .../opac-tmpl/bootstrap/en/modules/opac-library.tt | 155 +++++++++++++++++ .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 19 ++- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 18 +- .../lib/emoji-picker/js/emoji-picker-all.min.js | 1 + opac/{opac-routing-lists.pl => opac-library.pl} | 30 ++-- t/db_dependent/Acquisition.t | 23 ++- t/db_dependent/Koha/Acquisition/Basket.t | 102 +++++++++++- t/db_dependent/Koha/Acquisition/Order.t | 183 ++++++++++++++++++++- 39 files changed, 1075 insertions(+), 339 deletions(-) copy Koha/{ActionLog.pm => Acquisition/Order/Claim.pm} (83%) copy Koha/{Plugins/Methods.pm => Acquisition/Order/Claims.pm} (80%) copy Koha/Schema/Result/{AqordersItem.pm => AqordersClaim.pm} (63%) create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-library.tt create mode 100644 koha-tmpl/opac-tmpl/lib/emoji-picker/js/emoji-picker-all.min.js copy opac/{opac-routing-lists.pl => opac-library.pl} (64%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 4 14:17:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 04 May 2020 12:17:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2054-g164b8127e7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 164b8127e719628aa9013dd2b30fb6511fbc4bf9 (commit) via 910acdbcfab3c11a583dd5cb92802fe57355f1ff (commit) from 67f695001a17556fc3b1796181fff9a1493cae94 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 164b8127e719628aa9013dd2b30fb6511fbc4bf9 Author: Jonathan Druart Date: Mon May 4 13:32:33 2020 +0200 Bug 24161: (follow-up) DBIC changes Define koha_object[s]_class methods Signed-off-by: Martin Renvoize commit 910acdbcfab3c11a583dd5cb92802fe57355f1ff Author: Jonathan Druart Date: Mon May 4 13:29:31 2020 +0200 Bug 24161: (follow-up) Fix typo in POD # Failed test 'POD test for Koha/Acquisition/Orders.pm' # at /usr/share/perl5/Test/Pod.pm line 187. # Koha/Acquisition/Orders.pm (43): Non-ASCII character seen before =encoding in 'uivalent'. Assuming UTF-8 xt/author/podcorrectness.t .. 622/829 # Looks like you failed 1 test of 829. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Acquisition/Orders.pm | 2 +- Koha/Schema/Result/AqordersClaim.pm | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 4 15:13:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 04 May 2020 13:13:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2055-ga6985d167e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a6985d167e11eaafee985b51cb0188a693405af5 (commit) from 164b8127e719628aa9013dd2b30fb6511fbc4bf9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a6985d167e11eaafee985b51cb0188a693405af5 Author: Nick Clemens Date: Mon May 4 11:33:11 2020 +0000 Bug 25133: (follow-up) Move changes to timepicker.inc Witht the changes in calendar.inc there can be a js error where the timepicker is not included. Moving the changes to timepicker.inc should resolve this Note: in previous patches the amnames/pmnames were removed. It is possible they had no effect because they were declared in two files, so I have left them in timepicker.inc Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc | 4 ---- koha-tmpl/intranet-tmpl/prog/en/includes/timepicker.inc | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 4 23:24:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 04 May 2020 21:24:23 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-41-g0c64138dd1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 0c64138dd1787dd35c06cad1512dd1a2de470bfb (commit) via cac73b47ef221b32a6254fd25f22c86bcdd20c20 (commit) via ef9f3adbddbffdf0f734e68e11a0c0424d6ec975 (commit) via 85e4d6585bd7a9c41730b0073bc3045311e5660e (commit) via 0693b3758507dae5460cdd6f1fd9affa5f635933 (commit) via 56c629d969b0de56f1202799d7ab11705fc39d90 (commit) from e370007f0e04945a82a1fa1af42bfc84ab8855b4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0c64138dd1787dd35c06cad1512dd1a2de470bfb Author: Kyle M Hall Date: Wed Apr 8 10:52:23 2020 -0400 Bug 22778: Add unit test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit cac73b47ef221b32a6254fd25f22c86bcdd20c20 Author: Kyle M Hall Date: Thu Apr 25 15:50:35 2019 -0400 Bug 22778: Suggestions with no "suggester" can cause errors If one tries to modify a suggestion that has no suggester you will get the following error: Can't call method "lang" on an undefined value at /usr/share/koha/lib/C4/Suggestions.pm line 506 Koha assumes that every suggestion has a borrowernumber in suggestedby Test Plan: 1) Create a suggestion with an unpopulated suggestedby 2) Attempt to modify that suggestion 3) Note the error 4) Apply this patch 5) Restart all teh things 6) Attempt to modify that suggestion 7) No error! Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ef9f3adbddbffdf0f734e68e11a0c0424d6ec975 Author: Theodoros Theodoropoulos Date: Wed Apr 8 08:21:12 2020 +0100 Bug 23514: Split Call Numbers for all layout types This patch ensures call numbers are properly split for layout types other than 'BAR'. Test plan: 1. Go to Label Creator and choose/create a Label Layout with "Choose layout type: Biblio" 2. make sure you have at least "itemcallnumber" in Bibliographic data to print/Data fields 3. check "Split call numbers" box and save the layout (ie testlayout) 4. create a label batch, using items that have a call number (ie DC611.B848 H84 1997). LCC is used here, but you may try with Dewey as well. 5. export selected batch using any template and the layout you created in previous step to a PDF 6. Call numbers are splitted (as expected) in the resulting PDF file 7. edit the layout you created in the previous step (ie testlayout) and change the "Choose layout type:" to either Biblio/Barcode (BIBBAR) or Barcode/Biblio (BARBIB) 8. export the same batch using the same template and layout as before 9. Call numbers are NOT splitted at all After patch is applied, call numbers splitting functions are applied even in Biblio/Barcode (BIBBAR) or Barcode/Biblio (BARBIB) layout types. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 85e4d6585bd7a9c41730b0073bc3045311e5660e Author: Jonathan Druart Date: Wed Apr 8 11:45:51 2020 +0200 Bug 25081: Fix wrong comment Not directly related to previous patch, coming from 23435. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0693b3758507dae5460cdd6f1fd9affa5f635933 Author: Janusz Kaczmarek Date: Tue Apr 7 22:23:20 2020 +0200 Bug 25081: Fix creation of new item for a received issue The Bug 23435 introduced the idea of multiple copies added while receiving a new issue. Unfortunately, under some circumstances, it causes no items being added at all. It occurs stochastically, only under some conditions. But it is quite likely to happen while receiving a supplemental issue. The reason fot hist is that, in serials-edit.pl, line ca 292 and infra, @num_copies is treated in the same way as @tags, while it should be treated similarly to @bibnums. It will be obvious after examining the content of parameters tag, subfield, field_value, ..., number_of_copies. In other words, for every edited issue number_of_copies is a scalar. Nota bene: a) beter to initialize $countdistinct with zero; b) note that in master, now, before applying the patch, $itemhash{$item}->{'num_copies'} is treated once as a scalar and in the next line--as an array: $itemhash{$item}->{'num_copies'} //= 1; for (my $copy = 0; $copy < $itemhash{$item}->{'num_copies'}[$index];){ TEST PLAN ========= 1. Have a subscription with the option "Create an item record when receiving this serial" active and try to receive a supplemental issue. Control that a new item under the biblio record (usually) will not be created. 2. Apply the patch. 3. Repeat p. 1 -- a new item should be created. Signed-off-by: Aleisha Amohia Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 56c629d969b0de56f1202799d7ab11705fc39d90 Author: Kyle M Hall Date: Fri Mar 27 12:01:05 2020 -0400 Bug 22937: Add hint to groups editor Signed-off-by: Lisette Scheer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Labels/Label.pm | 2 +- C4/Suggestions.pm | 3 +- .../prog/en/modules/admin/library_groups.tt | 2 ++ serials/serials-edit.pl | 8 ++--- t/db_dependent/Suggestions.t | 35 +++++++++++++++++++++- 5 files changed, 43 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 5 00:05:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 04 May 2020 22:05:06 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-52-g0b7d3b4331 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 0b7d3b4331c69238ae04fdb895baeae9ce0742cf (commit) via 71eb787fbd34294ff6df995fa74d930dec4f4057 (commit) via 82bee9fe6a28e70393d382b03db884d1eb142ddf (commit) via 9845c93cc7d1b072ec2c79d7f16a21f00935f3ef (commit) via 93d95ac1b3feaf5482b6a1a25c9d4198837e675c (commit) via 48d42a68794c3bf85c087adf2185d979929a13bc (commit) via 68588e017595de632b0bd4dd03f8e05c43fa240e (commit) via b216f20dd684c80663567b17f9005e79e113abb2 (commit) via 61b348118ada5a1520a2ad44ae7697a30be9f885 (commit) via c6c6c57400a9941a027ce8f919c652567ed37710 (commit) via de56296d36ef8102f1d90e90e1617bd87c9879d8 (commit) from 0c64138dd1787dd35c06cad1512dd1a2de470bfb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0b7d3b4331c69238ae04fdb895baeae9ce0742cf Author: Lucas Gass Date: Thu Mar 26 22:46:26 2020 +0000 Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature TEST PLAN: 1. Make a new news item and use the TinyMCE editor, click on the <> icon to go to the Source code editor 2. Add some HTML like and save it. 3. Go back in and notice that TinyMCE has changed it to:

TEST

4. It should not auto clean up and also it should not autowrap with

tag. 5. Apply patch patch, and repeat step 2. Save again. 6. It should not have automatiicly changed any HTML or added any

wrapper. Signed-off-by: David Cook Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 71eb787fbd34294ff6df995fa74d930dec4f4057 Author: Marcel de Rooy Date: Thu Mar 19 14:39:14 2020 +0100 Bug 24903: Add tests for _handle_seqno Trivial tests. Test plan: Run t/Serials/ModSerialStatus.t Signed-off-by: Marcel de Rooy Signed-off-by: Laurence Rault Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 82bee9fe6a28e70393d382b03db884d1eb142ddf Author: Marcel de Rooy Date: Thu Mar 19 14:20:38 2020 +0100 Bug 24903: Special characters like parentheses in numbering pattern cause duplication in recievedlist Test plan: Use serial with a numbering pattern with parentheses like "2018 (No. 1)". Mark serial issue as arrived, check receivedlist on summary. Edit issue again, check if not duplicated on receivedlist. Mark issue as missing or not available, check missinglist. Mark missing issue as not missing, check list again. Signed-off-by: Marcel de Rooy Signed-off-by: Laurence Rault Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 9845c93cc7d1b072ec2c79d7f16a21f00935f3ef Author: Jonathan Druart Date: Tue Apr 7 13:25:09 2020 +0200 Bug 25038: Fix tabs on the OPAC reading history view OPAC reading history table has three tabs for different checkout types: All, Checkouts, On-site checkouts. However, all of your checkouts are visible every tab regardless of checkout type. Test plan: 1. Enable OnSiteCheckouts system preference 2. Perform two checkouts: one normal checkout, one on-site checkout 3. Go to OPAC /cgi-bin/koha/opac-readingrecord.pl 4. Observe your checkouts all are visible in first tab 5. Select second tab and notice that the table is now filtered 6. Same with third tab Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Lari Taskula Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 93d95ac1b3feaf5482b6a1a25c9d4198837e675c Author: Kyle M Hall Date: Fri Apr 10 06:43:51 2020 -0400 Bug 24966: Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 48d42a68794c3bf85c087adf2185d979929a13bc Author: Marcel de Rooy Date: Fri Apr 10 09:50:13 2020 +0000 Bug 24966: (QA follow-up) Fix return value of hold_patron_bcode It is used in list context, but we need a scalar value. Can be fixed by adding scalar's, or returning empty string as here. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 68588e017595de632b0bd4dd03f8e05c43fa240e Author: Martin Renvoize Date: Fri Apr 3 11:16:39 2020 +0100 Bug 25040: monkeypatch Schema::Loader for recent MariaDB Recent versions of MariaDB changed the output of 'DESCRIBE' for timestamp columns with defaults from `CURRENT_TIMESTAMP` to `current_timestamp()`. As such the code inside DBIx::Class::Schema::Loader which catches such cases and outputs `\"current_timestamp"` as a sensible cross platform default is missed and this leads of inconsistent class files and bugs with out default lookup code in Koha::Objects. This patch serves as a backport of the code I have submitted upstream such that out developers can continue to use update_dbix_class_files.pl to build their schema classes from the database and regardless of their db server version get a consistently correct output. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b216f20dd684c80663567b17f9005e79e113abb2 Author: Nick Clemens Date: Fri Apr 3 12:14:27 2020 +0000 Bug 25050: Adjust marc_records_to_documents to search entire mapping array There was an assumption in the ES code that match-heading mappings will appear in a specified portion of the mappings array. Certain mappings setups will not meet this assumption. We need to move our searching up one level The key seems to be having a mapping for a complete field, say 150, in both the match-heading and another field as well as having mappings for ungrouped fields like 150a 150ab etc. The unit test coverage should be sufficient for testing Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 61b348118ada5a1520a2ad44ae7697a30be9f885 Author: Nick Clemens Date: Fri Apr 3 12:12:49 2020 +0000 Bug 25050: Unit tests This patch simplay alters the data we use for the tests, doing so causes them to fail To test: 1 - Apply only this patch 2 - prove -v t/Koha/SearchEngine/Elasticsearch.t 3 - It fails! 4 - Apply next patch 5 - It passes! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c6c6c57400a9941a027ce8f919c652567ed37710 Author: Aleisha Amohia Date: Mon Mar 16 22:09:51 2020 +0000 Bug 24266: (alternate patch) Only use defined borrowernumbers in reconcile_balances.pl cron I believe the error is triggered when borrowernumbers are left empty in the accountlines table. Not sure why this would happen, but it appears to be what causes the problem. Do not apply the first patch if testing this patch. To test: 1) sudo koha-mysql INSTANCENAME 2) Create a test borrower, add any payment etc to create an accountline, then delete this borrower 3) ensure the AccountAutoReconcile syspref is disabled 4) Go to another borrower's accounting tab 5) Create a manual credit or debit. Confirm this shows in the 'Make a payment' tab as an amount that COULD be applied, but isn't automatically applied 6) in your terminal, run the reconcile_balances.pl script 7) Confirm the error does not show in the logs and the balance for the borrower is correctly reconciled. Sponsored-by: Horowhenua District Council Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit de56296d36ef8102f1d90e90e1617bd87c9879d8 Author: Kyle M Hall Date: Thu Apr 9 08:24:44 2020 -0400 Bug 25095: Remove warn left in FeePayment.pm It appears that a debugging statement was accidentally left in FeePayment.pm by bug 5605. Signed-off-by: Devinim Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Item.pm | 4 +- C4/SIP/ILS/Transaction/FeePayment.pm | 2 - C4/Serials.pm | 29 ++++++++--- Koha/Schema/Loader/mysql.pm | 59 ++++++++++++++++++++++ Koha/SearchEngine/Elasticsearch.pm | 2 +- .../prog/en/modules/tools/koha-news.tt | 4 ++ .../bootstrap/en/modules/opac-readingrecord.tt | 10 ++-- misc/cronjobs/reconcile_balances.pl | 3 +- misc/devel/update_dbix_class_files.pl | 8 ++- t/Koha/SearchEngine/Elasticsearch.t | 41 ++++++++++++--- t/Serials/ModSerialStatus.t | 38 ++++++++++++++ t/db_dependent/SIP/Message.t | 32 +++++++++++- 12 files changed, 205 insertions(+), 27 deletions(-) create mode 100644 Koha/Schema/Loader/mysql.pm create mode 100755 t/Serials/ModSerialStatus.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 5 12:19:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 05 May 2020 10:19:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2057-gcd141a7445 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cd141a74458f739ce74e627376b97ea72df0c0c6 (commit) via 0575bc22d14b7a14ba38df51432114f53230bd2f (commit) from a6985d167e11eaafee985b51cb0188a693405af5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cd141a74458f739ce74e627376b97ea72df0c0c6 Author: Jonathan Druart Date: Tue May 5 10:26:55 2020 +0200 Bug 18308: fix failing tests # Failed test 'check_password hook tests' # at t/db_dependent/Koha/Plugins/Patron.t line 83. [The password was rejected by a plugin]# Looks like your test exited with 255 just after 5. Signed-off-by: Martin Renvoize commit 0575bc22d14b7a14ba38df51432114f53230bd2f Author: Martin Renvoize Date: Tue May 5 10:49:07 2020 +0100 Bug 18308: (RM follow-up) Fix failing tests Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Patrons/Import.t | 6 +++--- t/db_dependent/Koha/Plugins/Patron.t | 3 ++- t/lib/Koha/Plugin/Test.pm | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 5 12:32:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 05 May 2020 10:32:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2078-g48d887c236 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 48d887c2363b7611036cf336b3abf83aea3381fe (commit) via 6ec2d13b9da8ca42a2553ca4e6b781d807678240 (commit) via 05b39b50e0d2a2776b38c2ef17dc78ffb8cfc573 (commit) via 031e53958a400d491a502a1c32bf89d3bcfeb0dd (commit) via 0a8775cfabd674207112f0c205dc1bd2578040e1 (commit) via 2cbe7bc17a80760d4ed849d95b1de02ce8f1a402 (commit) via 09ccb2e96844ddfcbbe4d3007a71ed614fe371d3 (commit) via 9569c5e31f9df0bac0c8989f7dafd0b0d8088e4e (commit) via f298b30fe3a7cb8f64cecb6d20e2cb157defd537 (commit) via f06bd7be16596a4fb189f60137c86d727e279336 (commit) via fee4fe4f88a23a4fa109b4ccc829e03773cef43b (commit) via 2b72cd6b12f01d574462512f68a8f8035ad0c6bb (commit) via 7a722e5970b6a3a7f268086a6d7fee30466fb7d7 (commit) via 13773753448f3cad6922e868ffca49dd4991474d (commit) via 05b21df1db4726e3f94252bbb032a984607a3991 (commit) via 21d0d69b4fc126c8c2242c57950b8cf1d45bf482 (commit) via 8457804bcf6b6b51703a2fa1143d0dfd539e4e4b (commit) via fe2ac51b2732befe9e4f9b8d2c85d6d94de525a3 (commit) via 633befb5f0e23306586aedf3219fefab5fa719f0 (commit) via 6235d0cfa16e5278a32ba6a4814f67ee4ad575b1 (commit) via 085cc7c4d21fdf30e79d3b15844fc8f872f5114b (commit) from cd141a74458f739ce74e627376b97ea72df0c0c6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 48d887c2363b7611036cf336b3abf83aea3381fe Author: Tomas Cohen Arazi Date: Mon May 4 11:25:35 2020 -0300 Bug 24769: Regression tests When regressions are found, we introduce regression tests :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 6ec2d13b9da8ca42a2553ca4e6b781d807678240 Author: Jonathan Druart Date: Fri Apr 24 11:31:33 2020 +0200 Bug 24769: (bug 14711 follow-up 2) Fix typo in parameter name for AddReserve This patch fixes 2 other occurrences. The first one is in POD of AddReserve, the other one fixes SIP code Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 05b39b50e0d2a2776b38c2ef17dc78ffb8cfc573 Author: Jonathan Druart Date: Fri Apr 24 11:25:43 2020 +0200 Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve The parameter is branchcode, not branch. Test plan: Place a hold on a biblio using ILSDI Check that the branchcode is correctly filled with the patron's library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 031e53958a400d491a502a1c32bf89d3bcfeb0dd Author: Katrin Fischer Date: Mon Apr 13 04:42:37 2020 +0200 Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql The description on STATUS was incomplete, missing 2 status and the SUGGEST_STATUS category. To test: - Later this will show up in schema.koha-community.org, but for now it can only be verified reading the patch. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0a8775cfabd674207112f0c205dc1bd2578040e1 Author: Bernardo Gonzalez Kriegel Date: Thu Apr 23 08:36:38 2020 -0300 Bug 7947: (follow-up) fix 490 subfield visibility (IT) Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2cbe7bc17a80760d4ed849d95b1de02ce8f1a402 Author: Bernardo Gonzalez Kriegel Date: Thu Apr 23 08:36:09 2020 -0300 Bug 7947: (follow-up) fix 490 subfield visibility (DE) Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 09ccb2e96844ddfcbbe4d3007a71ed614fe371d3 Author: Bernardo Gonzalez Kriegel Date: Thu Apr 23 08:35:35 2020 -0300 Bug 7947: (follow-up) fix 490 subfield visibility (EN) Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 9569c5e31f9df0bac0c8989f7dafd0b0d8088e4e Author: Katrin Fischer Date: Sat Mar 28 11:23:54 2020 +0100 Bug 7947: Update MARC21 440/490 mapping and visibility in uk-UA installer 440 has been obsoleted in the standard for a long time. 490 is now used for series information. Changes made here only apply for new installations: - Hide 440 subfields by default - Make 490 avx visible by default - Add mapping biblioitems.seriestitle to 490a - Add mapping biblioitems.volume to 490v To test: - Run the web installer for this language and verify changes in all frameworks Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit f298b30fe3a7cb8f64cecb6d20e2cb157defd537 Author: Katrin Fischer Date: Sat Mar 28 11:25:40 2020 +0100 Bug 7947: Update MARC21 440/490 mapping and visibility in ru-RU installer 440 has been obsoleted in the standard for a long time. 490 is now used for series information. Changes made here only apply for new installations: - Hide 440 subfields by default - Make 490 avx visible by default - Add mapping biblioitems.seriestitle to 490a - Add mapping biblioitems.volume to 490v To test: - Run the web installer for this language and verify changes in all frameworks Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit f06bd7be16596a4fb189f60137c86d727e279336 Author: Katrin Fischer Date: Sat Mar 28 11:26:57 2020 +0100 Bug 7947: Update MARC21 440/490 mapping and visibility in nb-NO installer 440 has been obsoleted in the standard for a long time. 490 is now used for series information. Changes made here only apply for new installations: - Hide 440 subfields by default - Make 490 3avx visible by default - Add mapping biblioitems.seriestitle to 490a - Add mapping biblioitems.volume to 490v To test: - Run the web installer for this language and verify changes in all frameworks Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit fee4fe4f88a23a4fa109b4ccc829e03773cef43b Author: Katrin Fischer Date: Sat Mar 28 11:29:11 2020 +0100 Bug 7947: Update MARC21 440/490 mapping and visibility in pl-PL installer 440 has been obsoleted in the standard for a long time. 490 is now used for series information. Changes made here only apply for new installations: - Hide 440 subfields by default - Make 490 3avx visible by default - Add mapping biblioitems.seriestitle to 490a - Add mapping biblioitems.volume to 490v To test: - Run the web installer for this language and verify changes in all frameworks Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2b72cd6b12f01d574462512f68a8f8035ad0c6bb Author: Katrin Fischer Date: Sat Mar 28 11:30:44 2020 +0100 Bug 7947: Update MARC21 440/490 mapping and visibility in it-IT installer 440 has been obsoleted in the standard for a long time. 490 is now used for series information. Changes made here only apply for new installations: - Hide 440 subfields by default - Make 490 3avx visible by default - Add mapping biblioitems.seriestitle to 490a - Add mapping biblioitems.volume to 490v To test: - Run the web installer for this language and verify changes in all frameworks Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 7a722e5970b6a3a7f268086a6d7fee30466fb7d7 Author: Katrin Fischer Date: Sat Mar 28 11:28:37 2020 +0100 Bug 7947: Update MARC21 440/490 mapping and visibility in fr-FR installer 440 has been obsoleted in the standard for a long time. 490 is now used for series information. Changes made here only apply for new installations: - Hide 440 subfields by default - Make 490 3avx visible by default - Add mapping biblioitems.seriestitle to 490a - Add mapping biblioitems.volume to 490v To test: - Run the web installer for this language and verify changes in all frameworks Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 13773753448f3cad6922e868ffca49dd4991474d Author: Katrin Fischer Date: Sat Mar 28 11:18:37 2020 +0100 Bug 7947: Update MARC21 440/490 mapping and visibility in de-DE installer 440 has been obsoleted in the standard for a long time. 490 is now used for series information. Changes made here only apply for new installations: - Hide 440 subfields by default - Make 490 3avx visible by default - Add mapping biblioitems.seriestitle to 490a - Add mapping biblioitems.volume to 490v To test: - Run the web installer for this language and verify changes in all frameworks Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 05b21df1db4726e3f94252bbb032a984607a3991 Author: Katrin Fischer Date: Sat Mar 28 11:28:06 2020 +0100 Bug 7947: Update MARC21 440/490 mapping and visibility in en installer 440 has been obsoleted in the standard for a long time. 490 is now used for series information. Changes made here only apply for new installations: - Hide 440 subfields by default - Make 490 3avx visible by default - Add mapping biblioitems.seriestitle to 490a - Add mapping biblioitems.volume to 490v To test: - Run the web installer for this language and verify changes in all frameworks Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 21d0d69b4fc126c8c2242c57950b8cf1d45bf482 Author: Katrin Fischer Date: Sun Apr 19 13:39:08 2020 +0200 Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files It looks like RewriteLog will no longer work with Apache 2.4 and later. RewriteLog Those familiar with earlier versions of mod_rewrite will no doubt be looking for the RewriteLog and RewriteLogLevel directives. This functionality has been completely replaced by the new per-module logging configuration mentioned above. http://httpd.apache.org/docs/current/mod/mod_rewrite.html All lines removed were commented out, so there should be no change in behaviour or side effects. To test. - Verify every mention of RewriteLog has been removed from Koha - Verify patch by reading it Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8457804bcf6b6b51703a2fa1143d0dfd539e4e4b Author: Martin Renvoize Date: Tue May 5 10:57:07 2020 +0100 Bug 23185: (RM follow-up) Minor POD wording update Signed-off-by: Martin Renvoize commit fe2ac51b2732befe9e4f9b8d2c85d6d94de525a3 Author: Tomas Cohen Arazi Date: Mon May 4 09:54:30 2020 -0300 Bug 23185: (QA follow-up) Add POD for Koha::Objects->update Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 633befb5f0e23306586aedf3219fefab5fa719f0 Author: Martin Renvoize Date: Fri May 1 14:12:09 2020 +0100 Bug 23185: (QA follow-up) Semantics, split fields and options This patch improves the semantics of the update routine to more clearly separate the 'fields' we're modifying from the 'options' we wish to apply to the modification. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 6235d0cfa16e5278a32ba6a4814f67ee4ad575b1 Author: Jonathan Druart Date: Tue Apr 28 17:14:41 2020 +0200 Bug 23185: Make Koha::Objects->update loop on the object set if needed Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 085cc7c4d21fdf30e79d3b15844fc8f872f5114b Author: Jonathan Druart Date: Tue Apr 28 17:14:35 2020 +0200 Bug 23185: Add tests Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/ILSDI/Services.pm | 4 +- C4/Reserves.pm | 2 +- C4/SIP/ILS/Transaction/Hold.pm | 2 +- Koha/Exceptions/Object.pm | 4 + Koha/Object.pm | 3 +- Koha/Objects.pm | 43 +++- debian/templates/apache-site-https.conf.in | 2 - debian/templates/apache-site.conf.in | 2 - etc/koha-httpd.conf | 8 - .../marc21/mandatory/marc21_framework_DEFAULT.sql | 20 +- .../optional/marc21_simple_bib_frameworks.sql | 3 - .../marc21/mandatory/marc21_framework_DEFAULT.yml | 24 +- .../optional/marc21_simple_bib_frameworks.yml | 3 - .../Obligatoire/marc21_framework_DEFAULT.sql | 19 +- .../Optionnel/marc21_simple_bib_frameworks.sql | 153 ++++++------ .../marc21/mandatory/marc21_framework_DEFAULT.sql | 20 +- .../optional/marc21_simple_bib_frameworks.sql | 3 - installer/data/mysql/kohastructure.sql | 2 +- .../marc21/mandatory/marc21_framework_DEFAULT.sql | 19 +- .../optional/marc21_simple_bib_frameworks.sql | 152 +++++------ .../marcflavour/normarc/Obligatorisk/normarc.sql | 2 +- .../marc21/mandatory/marc21_framework_DEFAULT.sql | 20 +- .../optional/marc21_simple_bib_frameworks.sql | 152 +++++------ .../marc21_bibliographic_DEFAULT_general.sql | 16 +- .../optional/marc21_bibliographic_AR_general.sql | 16 +- .../optional/marc21_bibliographic_BKS_general.sql | 20 +- .../optional/marc21_bibliographic_CF_general.sql | 16 +- .../optional/marc21_bibliographic_IR_general.sql | 16 +- .../optional/marc21_bibliographic_KT_general.sql | 16 +- .../optional/marc21_bibliographic_SER_general.sql | 20 +- .../optional/marc21_bibliographic_SR_general.sql | 16 +- .../optional/marc21_bibliographic_VR_general.sql | 16 +- .../marc21_bibliographic_DEFAULT_general.sql | 16 +- .../marc21_bibliographic_DEFAULT_local.sql | 2 +- .../optional/marc21_bibliographic_AR_general.sql | 26 +- .../optional/marc21_bibliographic_AR_local.sql | 2 +- .../optional/marc21_bibliographic_BKS_general.sql | 26 +- .../optional/marc21_bibliographic_BKS_local.sql | 2 +- .../optional/marc21_bibliographic_CF_general.sql | 26 +- .../optional/marc21_bibliographic_CF_local.sql | 2 +- .../optional/marc21_bibliographic_IR_general.sql | 26 +- .../optional/marc21_bibliographic_IR_local.sql | 2 +- .../optional/marc21_bibliographic_KT_general.sql | 26 +- .../optional/marc21_bibliographic_KT_local.sql | 2 +- .../optional/marc21_bibliographic_SER_general.sql | 26 +- .../optional/marc21_bibliographic_SER_local.sql | 2 +- .../optional/marc21_bibliographic_SR_general.sql | 26 +- .../optional/marc21_bibliographic_SR_local.sql | 2 +- .../optional/marc21_bibliographic_VR_general.sql | 26 +- .../optional/marc21_bibliographic_VR_local.sql | 2 +- t/db_dependent/ILSDI_Services.t | 6 +- t/db_dependent/Koha/Objects.t | 277 ++++++++++++++++++++- t/db_dependent/SIP/Transaction.t | 6 +- 53 files changed, 838 insertions(+), 507 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 5 12:42:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 05 May 2020 10:42:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2088-gcdf786b0aa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cdf786b0aa0dc1d9fed489335fcfb0bf2cf9ea43 (commit) via 5eb07b28eb8db9b2e3a72b13b740a0a003eb1d84 (commit) via 563d316bba4deda338aff3e0f20ee46622083b9c (commit) via dccf4518d46e94970b1b39082d8ec1e326de35ff (commit) via a02f0b077752d0a686afae5aa7428c3fab1c4cd2 (commit) via 2042cb65310072a5c00205fe1d632deac00e639e (commit) via 6a5cdfa37fbd5c66fdd8a33f91c843278fb2a0c8 (commit) via af4d8a5751ed024bdf0de023394b028175744475 (commit) via 3cf6d99948e81a5037bd956a1823e7485a65bd91 (commit) via 3ebfa1a74a1f2265f6af8121dc5c9d36cb95ea68 (commit) from 48d887c2363b7611036cf336b3abf83aea3381fe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cdf786b0aa0dc1d9fed489335fcfb0bf2cf9ea43 Author: Martin Renvoize Date: Tue May 5 11:14:49 2020 +0100 Bug 24163: DBRev 19.12.00.086 Signed-off-by: Martin Renvoize commit 5eb07b28eb8db9b2e3a72b13b740a0a003eb1d84 Author: Jonathan Druart Date: Sat May 2 16:02:27 2020 +0200 Bug 24162: Add quantity column to the columns settings config Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 563d316bba4deda338aff3e0f20ee46622083b9c Author: Jonathan Druart Date: Sat May 2 16:00:27 2020 +0200 Bug 24162: Add missing filter Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit dccf4518d46e94970b1b39082d8ec1e326de35ff Author: Jonathan Druart Date: Thu Jan 9 17:28:09 2020 +0100 Bug 24162: Add quantity column to the late orders page This patch add a new column "quantity" to the late orders page Test plan: 1. Create some orders, close the basket 2. Go to the "Late orders" page => You should see a new column "quantity" that contains the number of items of the order Sponsored-by: Cork Institute of Technology Signed-off-by: Devinim Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit a02f0b077752d0a686afae5aa7428c3fab1c4cd2 Author: Jonathan Druart Date: Sat May 2 15:57:16 2020 +0200 Bug 24163: UTF-8 encode the output Specify the UTF-8 charset in the header and Encode the output to avoid encoding issues Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 2042cb65310072a5c00205fe1d632deac00e639e Author: Jonathan Druart Date: Sat May 2 15:46:13 2020 +0200 Bug 24163: Add the new CSV profile to other installer files export_format is not populated for other languages apparently... Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 6a5cdfa37fbd5c66fdd8a33f91c843278fb2a0c8 Author: Jonathan Druart Date: Sat May 2 15:42:18 2020 +0200 Bug 24163: (QA follow-up) Fix wordings Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit af4d8a5751ed024bdf0de023394b028175744475 Author: Jonathan Druart Date: Wed Dec 18 17:32:46 2019 +0100 Bug 24163: Add the csv into the DB - as an example Sponsored-by: Institute of Technology Tralee Signed-off-by: David Nind Signed-off-by: Angela O'Connor Desmond Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 3cf6d99948e81a5037bd956a1823e7485a65bd91 Author: Jonathan Druart Date: Wed Dec 18 17:24:17 2019 +0100 Bug 24163: Allow to define CSV profile for late orders export This new enhancement adds the ability to create a CSV profile for the late orders export. Prior to this, the CSV profile was hardcoded in a template and not editable (unless you modify the .tt file of course). The main difficulty of the request was to make the multiple claims dates accessible from the CSV profile. So far we only accept columns from the database. However we would like to use the Koha::Acquisition::Order object to make things easier (it had a ->claims method to access the different claims). To acchieve this, we are going to accept the TT syntax for that CSV profile. It means that only CSV profiles created for 'late_orders' will have the capability to use the TT syntax (can be extended later of course if needed). The alternative was to use specific placeholders, like %claims_count%, %claimed_date%, but it sounded more powerful and flexible to allow the TT syntax instead. Note that the former export (template based) still exists and is the default option. Test plan: 0. Apply the patches and execute the update database entry 1. Create some orders, close the basket 2. Claim some of the orders 3. Note the new button at the bottom of the table that have several entries. => The first entry will generate a CSV file using the previous method => The second entry will generate it using the new CSV profile, note that the number of claims as well as the different claims date are displayed. 4. Bonus point: Edit the CSV profile (Home › Tools › CSV export profiles) that is named "Late orders (csv profile)", or create a new one, and modify it. Export the late orders using this CSV profile and confirm that the generated CSV file is the one you expect. Sponsored-by: Institute of Technology Tralee Signed-off-by: David Nind Signed-off-by: Angela O'Connor Desmond Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 3ebfa1a74a1f2265f6af8121dc5c9d36cb95ea68 Author: Katrin Fischer Date: Sat Apr 11 14:09:27 2020 +0000 Bug 15727: Add MARC21 385 - Audience to detail pages This add 385$m$a to the staff and intranet detail pages. To test: - Catalog different variations of 385 and verify the display in the OPAC and staff client is ok Examples can be found in the LOC MARC21 documentation: http://www.loc.gov/marc/bibliographic/bd385.html Signed-off-by: Stina Hallin Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- acqui/lateorders-export.pl | 93 ++++++++++++++-------- acqui/lateorders.pl | 2 + admin/columns_settings.yml | 2 + .../data/mysql/de-DE/optional/csv_profiles.sql | 12 ++- installer/data/mysql/en/optional/csv_profiles.yml | 23 +++++- .../data/mysql/fr-CA/facultatif/csv_profiles.sql | 12 ++- .../data/mysql/it-IT/necessari/csv_profiles.sql | 12 ++- installer/data/mysql/updatedatabase.pl | 19 +++++ .../prog/en/modules/acqui/lateorders.tt | 27 +++++-- .../prog/en/modules/tools/csv-profiles.tt | 8 +- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 27 +++++++ .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 28 ++++++- 13 files changed, 216 insertions(+), 51 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 5 16:26:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 05 May 2020 14:26:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2090-g4071924f7f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4071924f7f9438c344e878a86d29792f83c06704 (commit) via 8d97c44b8e733235e6fc70c461c4c9ff943f1368 (commit) from cdf786b0aa0dc1d9fed489335fcfb0bf2cf9ea43 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4071924f7f9438c344e878a86d29792f83c06704 Author: Martin Renvoize Date: Tue May 5 14:58:40 2020 +0100 Bug 18308: (RM follow-up) Clarify intent of tests Signed-off-by: Martin Renvoize commit 8d97c44b8e733235e6fc70c461c4c9ff943f1368 Author: Jonathan Druart Date: Tue May 5 10:44:52 2020 +0200 Bug 17355: Fix failing tests This patch makes the tests pass without deleting mandatory AV cats Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/AuthorisedValues.t | 22 +++++++++++----------- t/db_dependent/Koha/Plugins/Patron.t | 18 +++++++++++++----- t/lib/Koha/Plugin/Test.pm | 2 +- 3 files changed, 25 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 5 23:35:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 05 May 2020 21:35:27 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-60-g0ac67146b9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 0ac67146b97123c2d408c0c72547d92e13368313 (commit) via 5576bf647dda24a4f7da56bf86656fe58f05b80d (commit) via cfd8e38fd8c01d0ab1dfd9e1b828b283b1dac64d (commit) via 121ea7e96cdaf0e620858ec04ab80213a09a3d44 (commit) via 317d2c1de7c7ef234517b99e65df3cab361fc1bb (commit) via b4f47c9a06af45a1524c210f073c07523ff94ce9 (commit) via b2b36b6f447890ec2972cd2b397a23c53fd183f3 (commit) via 008b09ce057e117766a95c03f551cab82e90c424 (commit) from 0b7d3b4331c69238ae04fdb895baeae9ce0742cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0ac67146b97123c2d408c0c72547d92e13368313 Author: Jonathan Druart Date: Tue Mar 31 16:39:12 2020 +0200 Bug 25027: Use localStorage instead of sessionStorage for results browser Staff side, when a search a done and a result clicked, a browser appears on the left, to navigate between the different results. We use sessionStorage to know the list of biblionumber from the result. As sessionStorage is only for the current tab, we do some ugly things, to catch the click events, then open the new tab, attach it to the current window, and put the focus back on the result list. We really should not do that, and let the user decide what they want to do with their clicks! To do so, let use the correct storage, localStorage, and have the results shared between the windows. We may need to clear that at some point, isn't it? Test plan: Launch a search, click result (left or middle), confirm you see the browser and that the window/tab opened like any other websites (depending on your web browser settings). Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5576bf647dda24a4f7da56bf86656fe58f05b80d Author: David Roberts Date: Mon Apr 13 01:22:07 2020 +0000 Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it This patch changes the wording of the comment To test: 1) Check the wording of Line 67 of Koha/AuthUtils.pm 2) Apply the patch 3) Check that the wording has changed from "Encrypt it" to "Hash it" Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit cfd8e38fd8c01d0ab1dfd9e1b828b283b1dac64d Author: Liz Rea Date: Thu Apr 9 15:50:04 2020 +0000 Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. Signed-off-by: Jonathan Druart Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 121ea7e96cdaf0e620858ec04ab80213a09a3d44 Author: Jonathan Druart Date: Wed Apr 8 11:57:06 2020 +0200 Bug 24993: Make sure we are not going to loop indefinitely Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 317d2c1de7c7ef234517b99e65df3cab361fc1bb Author: Jonathan Druart Date: Thu Apr 2 12:36:16 2020 +0200 Bug 24993: Make sure SIP server is stopped before restarting it Sometimes doing koha-sip --restart instance happens too fast and the SIP server is not started. To test: - have SIP enabled and running for your instance - issue a restart, make sure it restarts sudo koha-sip --restart inst Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b4f47c9a06af45a1524c210f073c07523ff94ce9 Author: Tomas Cohen Arazi Date: Mon Mar 30 10:06:43 2020 -0300 Bug 25008: Overload Koha::RecordProcessor->options to update filters This patch overloads the 'options' accessor generated by Class:Accessor. It does so the passed options are used to refresh the loaded filters. Tests are added for this overloaded method as well. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/RecordProcessor.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b2b36b6f447890ec2972cd2b397a23c53fd183f3 Author: Tomas Cohen Arazi Date: Mon Mar 30 10:20:11 2020 -0300 Bug 25008: Tests for ->options Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 008b09ce057e117766a95c03f551cab82e90c424 Author: Tomas Cohen Arazi Date: Fri Mar 27 17:53:32 2020 -0300 Bug 25008: Regression tests This patch highlights a behaviour of Koha::RecordProcessor that is unexpected: if you change the original options using ->options, the loaded filters don't pick the change. That's because the filter objects are loaded on ->new, and they are never updated. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/RecordProcessor.t => FAIL: Test prove ->options doesn't update the filters! Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/AuthUtils.pm | 2 +- Koha/RecordProcessor.pm | 23 +++++++++++++++ debian/scripts/koha-sip | 10 +++++++ koha-tmpl/intranet-tmpl/js/browser.js | 22 +++----------- t/RecordProcessor.t | 54 +++++++++++++++++++++++++++++++++++ 5 files changed, 92 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 6 00:33:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 05 May 2020 22:33:49 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-66-g8523817dcc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8523817dcc4d2219138b1c8600f289cbe9a009ee (commit) via ace1f665dfdcb7dd2fe1e864191556432e9c5ef6 (commit) via ee25606e8a85fb8a95284b6ad678dd18e97dfd02 (commit) via 36a84f4264e5c03b900eb850c93cc4eb0befd9e7 (commit) via 2b8f6f62af9c262bec4a4ce88ddae3d706727fb1 (commit) via d3e3a3757dc3e9d97e3204767409e1d39d637255 (commit) from 0ac67146b97123c2d408c0c72547d92e13368313 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8523817dcc4d2219138b1c8600f289cbe9a009ee Author: Fridolin Somers Date: Wed Mar 11 17:39:18 2020 +0300 Bug 21865: allow test arg alone Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ace1f665dfdcb7dd2fe1e864191556432e9c5ef6 Author: Fridolin Somers Date: Mon Nov 19 15:45:49 2018 +0100 Bug 21865: add confirm to remove_unused_authorities.pl script Like in most scripts in misc, add confirm argument to ensure script is not run without knowing what it does. Test plan: 1) Run misc/migration_tools/remove_unused_authorities.pl -h 2) You see help line for confirm 3) Run misc/migration_tools/remove_unused_authorities.pl 4) You see help and script does nothing 5) Run misc/migration_tools/remove_unused_authorities.pl -c 6) Script runs like wanted Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ee25606e8a85fb8a95284b6ad678dd18e97dfd02 Author: Fridolin Somers Date: Mon Nov 19 15:19:46 2018 +0100 Bug 21865: ES compatiblity of remove_unused_authorities.pl The script misc/migration_tools/remove_unused_authorities.pl directly checks if Zebra search is OK. This patch changes so that this test is only if Zebra is the search engine. It also adds a test on the search off any authority number indexed (index 'an'). With Zebra its : an,alwaysmatches='' With ES its : an:* This test ensure that biblios records are indexed and that not all autorities will be deleted. Test plan: 1) On a catalog create a new authority 2) Use Zebra in systempreference SearchEngine 3) Stop Zebra server 4) Run misc/migration_tools/remove_unused_authorities.pl -c 5) The script does nothing and says : Zebra server seems not to be available. This script needs Zebra runs. 6) Restart Zebra server 7) Delete biblio index base 8) Run misc/migration_tools/remove_unused_authorities.pl -c 9) The script does nothing and says : Searching authority number in biblio records seems not to be available : an,alwaysmatches='' 10) Use ElasticSearch in systempreference SearchEngine 11) Delete biblio index base 12) Run misc/migration_tools/remove_unused_authorities.pl -c 13) The script does nothing and says : Searching authority number in biblio records seems not to be available : an:* Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 36a84f4264e5c03b900eb850c93cc4eb0befd9e7 Author: Fridolin Somers Date: Mon Nov 19 14:46:05 2018 +0100 Bug 21865: improve remove_unused_authorities.pl script remove_unused_authorities.pl script can be improved. This patch changes changes verbosity so than test mode can be used to know the autorities that are used and those that can be deleted. It also writes a line in output if limited authority type(s). This patch also removes the unused vars $thresholdmin and $thresholdmax. It also changes the query to use SQL with parameters for authority types. Test plan : 1) On a catalog create a new authority 2) Be sure catalog is well indexed 3) Run misc/migration_tools/remove_unused_authorities.pl -t 4) You will see the line : *** Testing only, authorities will not be deleted. *** 5) You will see lines of : authid=x type=y : used X time(s) 6) You will see the line for the authority created in 1) : authid=x type=y : can be deleted 7) You will see at the end : x authorities parsed y can be deleted because unused z unchanged because used 8) Run misc/migration_tools/remove_unused_authorities.pl 9) You don't see the line : *** Testing only, authorities will not be deleted. *** 10) You will see lines of : authid=x type=y : used X time(s) 11) You will see the line for the authority created in 1) : authid=x type=y : deleted 12) You will see at the end : x authorities parsed y deleted because unused z unchanged because used 13) Run misc/migration_tools/remove_unused_authorities.pl --auth NP --auth CO 14) You see the line : Restricted to authority type(s) : NP,CO. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 2b8f6f62af9c262bec4a4ce88ddae3d706727fb1 Author: David Roberts Date: Sat Apr 4 23:13:00 2020 +0000 Bug 25053: Clarify the description of syspref PatronSelfRegistrationExpireTemporaryAccountsDelay This patch changes the wording of this system preference. To test: 1) Check the current wording of this system preference. 2) Install the patch. 3) Check that the wording of this system preference has changed to "Delete patrons still in the category indicated by PatronSelfRegistrationDefaultCategory X days after account creation." Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d3e3a3757dc3e9d97e3204767409e1d39d637255 Author: Kyle M Hall Date: Thu Jan 30 10:29:05 2020 -0500 Bug 24547: Add more action logs for holds It seems like ModReserveFill and ModReserveAffect should both produce action logs for holds. Test Plan: 1) Apply this patch 2) Place a hold 3) Check in the item to trap the hold 4) Check out the item to fill the hold 5) Check the action logs for that reserve id 6) Note the new logs! Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 6 ++ .../prog/en/modules/admin/preferences/opac.pref | 4 +- misc/migration_tools/remove_unused_authorities.pl | 87 ++++++++++++++-------- 3 files changed, 65 insertions(+), 32 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 6 01:14:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 05 May 2020 23:14:50 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-70-g05c4248721 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 05c4248721cfcbb9967b42e2bacf1a82eb845f1a (commit) via 8c09c5ee80d59aae134454375f260c47a6af2f16 (commit) via 58990eda36c29d09903c2135e76529c6a3accfcc (commit) via 66ad3c6e4bac3a39e9038735b8b429098d9d7e29 (commit) from 8523817dcc4d2219138b1c8600f289cbe9a009ee (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 05c4248721cfcbb9967b42e2bacf1a82eb845f1a Author: Owen Leonard Date: Sat Mar 28 17:42:50 2020 +0000 Bug 25007: (follow-up) Fix the way image check alters layout A question in the bug report asks: Why is is necessary to change the Bootstrap class to col-xs-12? The JavaScript which checks for the existence of an Amazon cover image is designed to remove the Amazon cover's container if there is none. Changing the class of cover image column is gone. However, the check is incorrect because it doesn't account for Local Covers. There might be both a 1 x 1 pixel Amazon image and a local cover image, so the layout shouldn't be changed unless there are no images present. To test, apply the patch and view the bibliographic details page of various titles including: - Amazon cover present, no local cover - No Amazon cover, local cover image present - Both Amazon and local cover image Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8c09c5ee80d59aae134454375f260c47a6af2f16 Author: Lucas Gass Date: Fri Mar 27 20:40:30 2020 +0000 Bug 25007: Check for normaalized ISBN when building Amazon link TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -Apply patch and reload page -The image should be back in its normal spot Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 58990eda36c29d09903c2135e76529c6a3accfcc Author: Katrin Fischer Date: Mon Apr 13 04:32:56 2020 +0200 Bug 22468: Standardize on labelling ccode table columns as Collections We now display the descriptions everywhere, so we should drop the 'code' from labels. This changes text in a lot of playes in Koha, including: - The relatives checkouts table when displayed for the guarantor - The new order and order receive forms in acquisitoins (item creation) - The description of CCODE in the authorised values table - The column description on results in item search - The branch tranfers page - Course reserves: add reserve items (one and in batch) - Patron account > statistics tab Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 66ad3c6e4bac3a39e9038735b8b429098d9d7e29 Author: Katrin Fischer Date: Sat Apr 11 13:40:39 2020 +0000 Bug 25120: Make accounting the default tab when opening the pref editor The default/active tab when opening the sys pref editor used to be 'Acquisitions' as the first tab, but should now be the new first 'Accounting' To test: - Go to Administration > System preferences - Verify the Aquisition tab is second and preselected - Apply patch - Repeat - Verify now Accounting is selected Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: admin/preferences.pl | 2 +- .../intranet-tmpl/prog/en/includes/relatives-issues-table.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/admin/authorised_values.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 9 +++++---- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 6 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 4 ++-- .../prog/en/modules/course_reserves/add_items-step2.tt | 2 +- .../prog/en/modules/course_reserves/batch_add_items.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt | 2 +- 11 files changed, 19 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 6 01:35:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 05 May 2020 23:35:45 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-73-g8ed0d57c95 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8ed0d57c95f36cfb960a998dc5b2fda6cfa44ef4 (commit) via 5c44fa7d50665b70a54d76936da7adfbb78874d4 (commit) via d82e657a660257825241e5314539f32cd61138da (commit) from 05c4248721cfcbb9967b42e2bacf1a82eb845f1a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ed0d57c95f36cfb960a998dc5b2fda6cfa44ef4 Author: Kyle M Hall Date: Tue Jan 30 11:10:07 2018 -0500 Bug 20101: Cronjob automatic_item_modification_by_age.pl does not log run in action logs C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. Test Plan: 1) Apply this patch 2) Enable CronjobLog 3) Run automatic_item_modification_by_age.pl succesfully 4) Note the run is noted in the action logs Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5c44fa7d50665b70a54d76936da7adfbb78874d4 Author: Joy Nelson Date: Tue May 5 23:04:53 2020 +0000 Bug 25086: DBRev 19.11.05.003 Signed-off-by: Joy Nelson commit d82e657a660257825241e5314539f32cd61138da Author: Agustin Moyano Date: Wed Apr 8 16:53:43 2020 -0300 Bug 25086: Set changed_fields column as nullable This patch changed_fields column as nullable. To test: 1. Do not apply any patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and updatedatabase 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/updatedatabase.pl | 7 +++++++ misc/cronjobs/automatic_item_modification_by_age.pl | 3 +++ 4 files changed, 12 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 7 17:32:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 May 2020 15:32:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2091-g185d88bac6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 185d88bac6745f7b76799600f6fd0a16cf09ac93 (commit) from 4071924f7f9438c344e878a86d29792f83c06704 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 185d88bac6745f7b76799600f6fd0a16cf09ac93 Author: Jonathan Druart Date: Thu May 7 17:05:32 2020 +0200 Bug 20443: (follow-up) Remove C4::Members::AttributeTypes ----------------------------------------------------------------------- Summary of changes: members/memberentry.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 7 19:58:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 May 2020 17:58:37 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-78-gb090cad820 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b090cad82064d2f02440ff53a2b17856f5aeb746 (commit) via fef648e9027162b6cae91a6f75ca612ef9e3cfc2 (commit) via b7e9de9a436d59c811f459758094b9bb1ab86a59 (commit) via 017d03b7414dd794046a883745e4e696ba4c8076 (commit) via 88526da244ce7ce3ec69bd5c167e016f021b3f08 (commit) from 8ed0d57c95f36cfb960a998dc5b2fda6cfa44ef4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b090cad82064d2f02440ff53a2b17856f5aeb746 Author: Jonathan Druart Date: Wed Mar 11 12:56:41 2020 +0100 Bug 24800: Add tests Signed-off-by: Clemens Elmlinger Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Joy Nelson commit fef648e9027162b6cae91a6f75ca612ef9e3cfc2 Author: Jonathan Druart Date: Wed Mar 11 13:01:52 2020 +0100 Bug 24800: Handle inexistent return date on self checking See bug 24800 comment 0 for a description of the problem. We do not want the SIP server to crash if it receives a checkin request with a return date that is not given. The option this patch chose is to parse it only if provided. Signed-off-by: Clemens Elmlinger Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Joy Nelson commit b7e9de9a436d59c811f459758094b9bb1ab86a59 Author: Jonathan Druart Date: Mon Apr 6 12:44:13 2020 +0200 Bug 25069: Fix AddressFormat="fr" behavior Something went wrong during a rebase of bug 13618 commit dcd1f5d48c758aee17b6c6f069c6146b42efe117 Bug 13618: Add html filters to all the variables Several changes related to AddressFormat are wrong: - [% IF Koha.Preference( 'AddressFormat' ) %] - [% INCLUDE "member-main-address-style-${ Koha.Preference( 'AddressFormat' ) }.inc" %] - [% ELSE %] - [% INCLUDE 'member-main-address-style-us.inc' %] - [% END %] + [% SWITCH Koha.Preference( 'AddressFormat' ) %] + [% CASE 'de' %] + [% INCLUDE 'member-main-address-style-de.inc' %] + [% CASE # us %] + [% INCLUDE 'member-main-address-style-us.inc' %] + [% END %] Test plan: Create a patron with all the address fields filled Play with the 3 option values of AddressFormat, and confirm that the address is displayed correctly on the patron's view, and in the patron module (top left) Signed-off-by: Joy Nelson commit 017d03b7414dd794046a883745e4e696ba4c8076 Author: Nick Clemens Date: Thu Mar 26 11:05:32 2020 +0000 Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string We should use Koha::DateUtils instead of Date::Time directly This patch simplay replaces calls to now() with a call to dt_from_string() which does effectively the same thing. Probably reading the code and verifying changes is sufficient but... To test: 1 - confirm the files all compile 2 - confirm all tests pass 3 - confirm Koha still works Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Bug 24840: Catch some further cases of DateTime->now This patch corrects a few additional cases where DateTime->now is called directly instead of via Koha::DateUtils. Signed-off-by: Jonathan Druart Signed-off-by: Joy Nelson commit 88526da244ce7ce3ec69bd5c167e016f021b3f08 Author: Nick Clemens Date: Mon Feb 10 18:18:45 2020 +0000 Bug 24620: [19.11.x] Close existing transfer when hold set to waiting (squashed) Signed-off-by: Jonathan Druart Bug 24620: Close existing transfers when setting item to waiting This patch adds a clause in ModReserveAffect to check if there are existing transfers and close them when setting a hold to waiting To test: 1 - Set AutomaticItemReturn to Do 2 - Checkin an item from Library B at Library A 3 - Confirm item is in transfer (check the details page) 4 - Place a item level hold for pickup at library A 5 - Checkin the item at Library A 6 - Confirm the hold 7 - View the details page 8 - Note the item is in transit and waiting 9 - Apply patch 10 - Delete hold and repeat 11 - Confirm that transfer is closed when hold marked waiting Signed-off-by: Sally Signed-off-by: Stina Hallin Signed-off-by: Jonathan Druart Bug 24620: Fix test, remove replaced code, use dt_from_string Signed-off-by: Jonathan Druart Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 20 ++++---- C4/Letters.pm | 2 +- C4/MarcModificationTemplates.pm | 3 +- C4/Reserves.pm | 13 ++++- C4/SIP/ILS/Transaction/Checkin.pm | 27 ++++++----- Koha/Calendar.pm | 2 +- Koha/Checkout.pm | 3 +- Koha/Checkouts.pm | 3 +- Koha/EDI.pm | 5 +- Koha/Edifact/Order.pm | 3 +- Koha/Edifact/Transport.pm | 3 +- Koha/Illrequest.pm | 3 +- Koha/Patron/Password/Recovery.pm | 3 +- Koha/Sitemapper/Writer.pm | 4 +- Koha/StockRotationItem.pm | 12 ++--- circ/overdue.pl | 2 +- circ/returns.pl | 6 +-- .../fix_unclosed_nonaccruing_fines_bug17135.pl | 2 +- installer/data/mysql/updatedatabase.pl | 2 +- .../intranet-tmpl/prog/en/includes/circ-menu.inc | 9 ++-- .../prog/en/modules/members/memberentrygen.tt | 21 ++++---- members/summary-print.pl | 3 +- misc/cronjobs/fines.pl | 2 +- misc/cronjobs/overdue_notices.pl | 4 +- misc/cronjobs/update_totalissues.pl | 3 +- opac/opac-ics.pl | 2 +- t/Circulation/AgeRestrictionMarkers.t | 5 +- t/db_dependent/Circulation.t | 38 ++++++++++++++- t/db_dependent/DecreaseLoanHighHolds.t | 5 +- t/db_dependent/Letters/TemplateToolkit.t | 2 +- t/db_dependent/OAI/Server.t | 2 +- t/db_dependent/Passwordrecovery.t | 11 +++-- t/db_dependent/SIP/Transaction.t | 56 +++++++++++++++++++++- t/db_dependent/Sitemapper.t | 3 +- 34 files changed, 198 insertions(+), 86 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 7 23:37:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 May 2020 21:37:05 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-81-g55b5a0e112 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 55b5a0e1121ae72d635e89f110b1063e9fb2877b (commit) via fe9fc8428101c13021f7e1386962b9d18095cffb (commit) via 7c6d01442e867b916c5286e83283fa6760c26477 (commit) from b090cad82064d2f02440ff53a2b17856f5aeb746 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 55b5a0e1121ae72d635e89f110b1063e9fb2877b Author: Owen Leonard Date: Sun Mar 29 00:19:39 2020 +0000 Bug 25016: Coce should not return a 1-pixel Amazon cover image This patch adds an onload function to the JavaScript which loads images from Coce. In the case where the image is 1 x 1 pixel the image should be removed. To test you should have Coce enabled and Amazon.com included in the list of sources. - Apply the patch and view the bibliographic details page under a variety of conditions: - A title which has a matching Amazon image: - The image should load as expected. - A title which doesn't have a matching Amazon image - The image should not be found in the source at all after the page has loaded. - Test with local cover images enabled Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit fe9fc8428101c13021f7e1386962b9d18095cffb Author: Joy Nelson Date: Thu May 7 21:07:30 2020 +0000 Bug 25176: Compiled CSS Signed-off-by: Joy Nelson commit 7c6d01442e867b916c5286e83283fa6760c26477 Author: Owen Leonard Date: Fri Apr 17 11:40:36 2020 +0000 Bug 25176: Fix style of checkout form This patch makes a small CSS change in order to fix a display problem with the checkout form where the form's width doesn't match that of the "last checked out" message. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check an item out to a patron. Confirm that the green-bordered "Checked out" message under the checkout form matches the width of the form. Signed-off-by: David Roberts Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/js/coce.js | 8 +++++++- koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 1 + koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 7 23:56:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 May 2020 21:56:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2093-gb422e017ec Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b422e017eca6ad74f0f66d5fea181b01e48d661e (commit) via fdea245e991aca4ca3ddad9d1a15d511e427fc0a (commit) from 185d88bac6745f7b76799600f6fd0a16cf09ac93 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b422e017eca6ad74f0f66d5fea181b01e48d661e Author: Tomas Cohen Arazi Date: Thu May 7 18:20:57 2020 -0300 Bug 23185: Realistic POD for Koha::Objects->search Signed-off-by: Tomas Cohen Arazi commit fdea245e991aca4ca3ddad9d1a15d511e427fc0a Author: Tomas Cohen Arazi Date: Thu May 7 18:05:29 2020 -0300 Bug 23185: ->update can only be called on instantiated classes Since our use ok Koha::Objects, there's been an implicit instantiation happening in ->search that has somehow hidden the fact that classes need instantiation... This change in ->delete and ->update made it clear because of the failures/hangs on the tests. This patch instantiates Koha::Patron::Categories before attempting to call ->update. The original patches for this bug are correct and the only issue here is that we need to document better than for some methods, instantiation is not implicit and is required first. This is awkward and I would prefer to force everyone to call ->new first. But I understand it would be inconvenient. To test: 1. Run: $ kshell k$ prove t/db_dependent/Template/Plugin/Categories.t => FAIL: Notice it hangs, Ctrl+c to abort 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests dong hang, and in fact pass 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: Koha/Objects.pm | 19 ++++++++++++++++--- t/db_dependent/Template/Plugin/Categories.t | 2 +- 2 files changed, 17 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 8 00:19:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 May 2020 22:19:32 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-89-gac16246829 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via ac162468290f24cdc105f8848740a52c805dd481 (commit) via 8cbe6a740ceb9d1529da6cc9ae8ff681d8f924fd (commit) via 8395bc9421042c9cb3e0eeab06ac03a3f2eddee9 (commit) via b095050dcf30b3848e0424d14d3a18c1167b2b23 (commit) via 09b527d717be485b1e4de39a0877ac6d0050a40a (commit) via 1b9fd03f17cc1d99ea0960173be87ae33d76df40 (commit) via a934499b8cc192781f263b0ba2b3edd5374e64cf (commit) via 6d02cbad0b8f64293ceae4a3cc2640a149a2756a (commit) from 55b5a0e1121ae72d635e89f110b1063e9fb2877b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ac162468290f24cdc105f8848740a52c805dd481 Author: Katrin Fischer Date: Sun Apr 12 22:06:05 2020 +0000 Bug 14369: Only show 'Create labels' link on staged records import when status is imported The label creator won't be able to add a batch for items, if they are not imported into the database (missing itemnumber). This patch hides the link, when the status is not imported, to avoid the error situation. To test: - Export a record with items from your Koha installation - Delete items and record from Koha - Stage the record with the items - the "Create labels" link should be showing - Try to create the labels - note error - Apply patch - Retry - the link should no longer show - Import the records - the link should show now - Create labels again - a new batch should have been created - Verify the link on the batch # leads to the batch in the labels module Bonus: Moves the message from the .pl file to the template to make it translatable. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8cbe6a740ceb9d1529da6cc9ae8ff681d8f924fd Author: Martin Renvoize Date: Tue Apr 21 12:14:13 2020 +0100 Bug 20484: (RM follow-up) Highlight ES disablement Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8395bc9421042c9cb3e0eeab06ac03a3f2eddee9 Author: Nick Clemens Date: Tue Apr 21 10:54:56 2020 +0000 Bug 20484: Implement blocking_errors for ES config page Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b095050dcf30b3848e0424d14d3a18c1167b2b23 Author: Nick Clemens Date: Wed Apr 8 10:11:38 2020 +0000 Bug 20484: Allow configuration of ES before switching to ES To test: 1 - Set SearchEngine syspref to Zebra 2 - Be a user with permission to manage search engine configuration (manage_search_engine_config) 3 - Confirm you do not see 'Search engine configuration' on Admin main page 4 - Apply patch 5 - Confirm you see it with '(Elasticsearch)' appended 6 - Be a user without above permission 7 - Confirm you cannot see the 'Search engine configuration' 8 - Confirm you cannot access directly: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 09b527d717be485b1e4de39a0877ac6d0050a40a Author: Katrin Fischer Date: Mon Apr 13 21:45:22 2020 +0000 Bug 13557: Add hint for on-site checkouts to list of current checkouts in OPAC In the list of checkouts it's currently not possible for the patront or tell the difference between normal checkouts (item is at home with them) and on-site checouts (items remained at the library). This patch adds a hint to the list of checkouts to allow differentiating these kinds of checkouts. To test: - In your patron account, have multiple checkouts, some on-site, some others, overdue items, etc. - Go to: OPAC > your summary > Checked out - Verify that there is no hint for the on-site checkouts - Apply patch - Check again, there should now be a note The note also has a class, so would be easy to be hidden or formatted differently: class="onsite_checkout". Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1b9fd03f17cc1d99ea0960173be87ae33d76df40 Author: Katrin Fischer Date: Tue Apr 14 13:14:37 2020 +0000 Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs When paging through the patron account in staff, using the tabs on the right, you notice that some pages are missing the patron toolbar on top and that the headings, where they exist, vary in size. This patch adds the patron toolbar to 3 more tabs and changes headings to h1 to be consistent with older tabs. It has also been suggested on another tab that this is preferrable for screen readers. Note: Modification log was left out for now, as this is also used in tools. To test: - Activate ILL (ILLModule pref) - Activate discharges (UseDischarge pref) - Go to any patron account, tab through the tabs... - Verify that discharge, purchase suggestions and ill requests are missing the toolbar - Apply patch - Verify that the toolbar now appears on these pages and works correctly - Also veriy that the headings are now consistently h1 on all pages Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit a934499b8cc192781f263b0ba2b3edd5374e64cf Author: Katrin Fischer Date: Tue Apr 14 16:57:38 2020 +0000 Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account When using sort1/sort2 with authorised values to create a pull down list, there will be no empty entry unless one is manually added to the authorised values list. This is not a good default behaviour, as it can easily cause errors on patron creation. Without the empty entry, the first alphabetic value is pre-selected and will be saved if not explicitly changed. It also doesn't allow to mark sort1/sort2 as mandatory, as the value is always 'set', the required message won't be triggered. This adds an empty parameter to av-build-dropbox.inc to allow selectively adding this empty entry without causing side-effects in other places this include is used. To test: - Create authorised values for either Bsort1 or Bsort2 authorised value category - Create a new patron: - you should see a pull down list on one and an input field for the other - for the pull down list, there will be no empty entry and the first alphabetic value will be preselected - Make your sort1 and sort2 mandatory using BorrowerMandatoryField - Verify there is still on empty entry - Apply patch - Repeat tests and verify that the behaviour is as expected - There should now be an empty entry - When the field is marked mandatory and empty is left, the required warning will be shown. Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 6d02cbad0b8f64293ceae4a3cc2640a149a2756a Author: Katrin Fischer Date: Mon Apr 13 03:46:25 2020 +0200 Bug 10561: Rephrase DisplayOPACiconsXSLT and DisplayIconsXSLT slightly As the pref removes the whole 'line' of information, this tries to makes the behaviour a little clearer by adding a 'and descriptions' to the pref text. It now reads: [Show|Don't show] the format, audience, and material type icons and descriptions in XSLT MARC21 results and detail pages in ... To test: - Check both preference descriptions in the staff client - Verify the text reads correctly and this helps things Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: admin/searchengine/elasticsearch/mappings.pl | 13 +++++++++++-- koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc | 6 +++--- .../intranet-tmpl/prog/en/includes/av-build-dropbox.inc | 6 ++++-- .../intranet-tmpl/prog/en/includes/blocking_errors.inc | 2 ++ .../intranet-tmpl/prog/en/modules/admin/admin-home.tt | 6 +++--- .../prog/en/modules/admin/preferences/opac.pref | 2 +- .../prog/en/modules/admin/preferences/staff_client.pref | 2 +- .../modules/admin/searchengine/elasticsearch/mappings.tt | 10 +++++++--- .../intranet-tmpl/prog/en/modules/members/discharge.tt | 6 ++++-- .../intranet-tmpl/prog/en/modules/members/housebound.tt | 2 +- .../prog/en/modules/members/ill-requests.tt | 5 ++++- .../prog/en/modules/members/memberentrygen.tt | 4 ++-- .../prog/en/modules/members/purchase-suggestions.tt | 3 ++- .../intranet-tmpl/prog/en/modules/members/statistics.tt | 2 +- .../prog/en/modules/tools/manage-marc-import.tt | 16 +++++++++++++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 1 + tools/manage-marc-import.pl | 4 ++-- 17 files changed, 62 insertions(+), 28 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 8 00:34:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 May 2020 22:34:13 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-94-g5810b72af9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5810b72af96a032fcf3d41b39eb0ad582117d2c1 (commit) via 7d69c0f10c7cb6c8b11baf55f05256684cdb0966 (commit) via 65783bd649ee9f794c8d4778d4e1ea3771a07db5 (commit) via 3759380bf5414ab181ed467dff6f84406a9d7ca0 (commit) via ed6978e0971d3825f98b3840678c4a10bc7f269e (commit) from ac162468290f24cdc105f8848740a52c805dd481 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5810b72af96a032fcf3d41b39eb0ad582117d2c1 Author: Phil Ringnalda Date: Sun Apr 19 02:37:49 2020 +0000 Bug 20501: Don't cut strings when unhighlighting in intranet search results When you click Unhighlight on the search results of a search in the staff client when the search terms contain the same word twice, like "ma ma", the highlighted words disappear, and don't reappear if you click Highlight. This patch makes the same change to the intranet copy of jquery.highlight-3.js that bug 5844 made to the OPAC copy. Test plan: 1) Without this patch, search in the intranet for ma ma and verify you have at least two matching records. 2) Notice that the Ma in Material type: Book is highlighted. 3) Click Unhighlight, and notice that it has become terial type: Book 4) Apply this patch, repeat the search with a shift+reload to reload the .js 5) Click Unhighlight, and verify that Material type: Book remains Material Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 7d69c0f10c7cb6c8b11baf55f05256684cdb0966 Author: Nick Clemens Date: Mon Apr 20 18:41:37 2020 +0000 Bug 25223: Make join of aqbasket and aqorders explicit This is simply a SQL change that makes things a bit easier to read and also prevents too much data being returned in a large system To test: 1 - Have some orders in your system in the ordered status 2 - Click the 'Ordered' amount for your budget from Acquisitions home 3 - Note the view of orders, possibly screen shot 4 - Apply patch 5 - Restart all the things 6 - Reload the ordered page 7 - Confirm nothing has changed Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 65783bd649ee9f794c8d4778d4e1ea3771a07db5 Author: Martin Renvoize Date: Mon Apr 20 08:37:10 2020 +0100 Bug 25123: (QA follow-up) Re-used variable name Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 3759380bf5414ab181ed467dff6f84406a9d7ca0 Author: Nick Clemens Date: Mon Apr 13 11:38:28 2020 +0000 Bug 25123: Count the current fine when reducing for maxFine If maxFine is set, we total the patrons outstanding fines when making an adjustment, however, we neglect to count the amount of a currently updating fine when doing so. To test: 1 - Set maxFine to 5 2 - Create an overdue amount of 4.99 for a patron 3 - Set an itemtype to have a fine of $.10 per day 4 - Checkout an item of that type to a patron and backdate the due date so it is overdue 5 - Run fines.pl with -v 6 - Note the fine is reduced from $.10 (or a multiple) to .01 7 - Run it again, a second cent is added 8 - Repeat and note it keeps happening until the amount of the fine is reached, exceeding the maxFine setting 9 - Apply patch 10 - Note the fine is now reduced to 0 and nothing is added to account Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ed6978e0971d3825f98b3840678c4a10bc7f269e Author: Nick Clemens Date: Mon Apr 13 11:38:23 2020 +0000 Bug 25123: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Overdues.pm | 1 - acqui/ordered.pl | 4 +-- .../lib/jquery/plugins/jquery.highlight-3.js | 8 ++---- t/db_dependent/Overdues.t | 32 +++++++++++++++++++++- 4 files changed, 35 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 8 00:39:35 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 May 2020 22:39:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2094-g74586912c0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 74586912c081d0440f49228a2cb08fdc84ddb2a2 (commit) from b422e017eca6ad74f0f66d5fea181b01e48d661e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 74586912c081d0440f49228a2cb08fdc84ddb2a2 Author: Tomas Cohen Arazi Date: Thu May 7 19:10:29 2020 -0300 Bug 17355: (QA follow-up) Fix used package name Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: Koha/AuthorisedValueCategories.pm | 2 +- Koha/AuthorisedValueCategory.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 8 16:10:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 14:10:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2099-gfcc6836925 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fcc6836925e6903cf5c1e27a63551820bd5b9569 (commit) via 6f6bde3c24e5f9dbe6c3ee8b2bb8569d741c8480 (commit) via 7c87ac8c3ba78434c29181ad9f2add7c99b51741 (commit) via 02fc6ca6d1b740cf7e0015f190efd5cb7c56883c (commit) via b5ff3696b5aebb4865f9b988075cc850068a91cf (commit) from 74586912c081d0440f49228a2cb08fdc84ddb2a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fcc6836925e6903cf5c1e27a63551820bd5b9569 Author: Jonathan Druart Date: Fri May 8 15:17:31 2020 +0200 Bug 25423: Force call to update and empty with an instanciated object Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 6f6bde3c24e5f9dbe6c3ee8b2bb8569d741c8480 Author: Jonathan Druart Date: Fri May 8 15:17:07 2020 +0200 Bug 25423: (follow-up) Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 7c87ac8c3ba78434c29181ad9f2add7c99b51741 Author: Tomas Cohen Arazi Date: Fri May 8 08:47:25 2020 -0300 Bug 25423: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 02fc6ca6d1b740cf7e0015f190efd5cb7c56883c Author: Tomas Cohen Arazi Date: Fri May 8 08:39:10 2020 -0300 Bug 25423: Add Koha::Exceptions::Object::NotInstantiated Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit b5ff3696b5aebb4865f9b988075cc850068a91cf Author: Tomas Cohen Arazi Date: Thu May 7 21:00:39 2020 -0300 Bug 23185: (follow-up) K:C:Register->make_default should use no_triggers Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: Koha/Cash/Register.pm | 2 +- Koha/Exceptions/Object.pm | 8 ++++++++ Koha/Objects.pm | 13 ++++++++++--- t/Koha/Exceptions.t | 24 +++++++++++++++++++++++- t/db_dependent/Koha/Objects.t | 19 +++++++++++++++---- 5 files changed, 57 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 8 21:16:35 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 19:16:35 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-96-ge5456e8291 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via e5456e82916482fa225dce4e01caf6b0058c50be (commit) via 8266b4fc2dabc426de3101c1f8a3e0377ce757e9 (commit) from 5810b72af96a032fcf3d41b39eb0ad582117d2c1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e5456e82916482fa225dce4e01caf6b0058c50be Author: Martin Renvoize Date: Fri Apr 17 16:05:43 2020 +0100 Bug 24768: (RM follow-up) Add missing koha_object_class's Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8266b4fc2dabc426de3101c1f8a3e0377ce757e9 Author: Katrin Fischer Date: Sat Apr 11 10:36:36 2020 +0000 Bug 24768: Add 'Return claims' to column configuration for checkouts tables The checkouts tables on the checkouts and details tabs in the staff patron account support column confiugration, but the new column "Return claims" was missing. This patch adds the column to the column configuration. To test: - Make sure to test with a patron having return claims and without - Verify cou can toggle the visibility of the return claims column from top of the tables in the checkouts and details tabs - Go to administrastion > column configuration - Change the settings for the issues tables in the Patrons and Circulation sections - Verify the changes have been applied to the tables as configured Signed-off-by: David Roberts Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/CourseInstructor.pm | 7 ++++++- Koha/Schema/Result/CourseItem.pm | 8 +++++++- Koha/Schema/Result/CourseReserve.pm | 7 ++++++- admin/columns_settings.yml | 5 +++++ 4 files changed, 24 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 8 22:08:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 20:08:33 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-97-g8641888fa3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8641888fa3c2dd460a1cf62855dc65bc1448682c (commit) from e5456e82916482fa225dce4e01caf6b0058c50be (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8641888fa3c2dd460a1cf62855dc65bc1448682c Author: Jonathan Druart Date: Mon Apr 20 11:13:40 2020 +0200 Bug 25186: Fix accordion sections height in columns configuration page The height for each section was the height of the highest section. Now the height is set to the length of the section. Test plan: Go to Administration > Column configuration Open the sections and confirm that the height fits its content. QA: note that I guess "autoHeight: false" was meant to achieve that, but it does not exist in the API of the plugin. Signed-off-by: Owen Leonard Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 8 22:14:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 20:14:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2100-gfc9ef3a279 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fc9ef3a2799f4654b114c319c1955113f7f716c6 (commit) from fcc6836925e6903cf5c1e27a63551820bd5b9569 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fc9ef3a2799f4654b114c319c1955113f7f716c6 Author: Tomas Cohen Arazi Date: Fri May 8 16:45:49 2020 -0300 Bug 25423: (follow-up) Fix wrong test This is confusing: why does it pass on all OSs but Debian 8? Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: t/Koha/Exceptions.t | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 8 23:01:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 21:01:37 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-99-g0d5d14935a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 0d5d14935aa6749ff02ac885e3b3697a3a08f29f (commit) via ab5c115d088665b41d3ae03b57fb801f1a63aca3 (commit) from 8641888fa3c2dd460a1cf62855dc65bc1448682c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d5d14935aa6749ff02ac885e3b3697a3a08f29f Author: Bernardo Gonzalez Kriegel Date: Wed Dec 4 21:51:16 2019 -0300 Bug 25257: Preserve prolog on translated XML files This patch fix the missing xml prolog in translated files, XML or TT. Is fixed teaching C4::TTParse not to ignore constructs, then teaching xgettext.pl to ignore those strings. Net result is that they are copied in the translated file. To test: 1) Update & install your preferred language, (cd misc/translator/; perl translate update xx-YY; perl translate install xx-YY ) 2) Compare the first lines (head -2) of: koha-tmpl/opac-tmpl/bootstrap/en/xslt/compact.xsl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/intranet-tmpl/prog/en/xslt/plainMARC.xsl and koha-tmpl/opac-tmpl/bootstrap/xx-YY/xslt/compact.xsl koha-tmpl/opac-tmpl/bootstrap/xx-YY/modules/opac-opensearch.tt koha-tmpl/intranet-tmpl/prog/xx-YY/xslt/plainMARC.xsl Check the missing prolog 3) Install this patch, repeat 1 and 2, now the prolog is present on translated files. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ab5c115d088665b41d3ae03b57fb801f1a63aca3 Author: Andrew Fuerste-Henry Date: Tue Apr 21 17:41:29 2020 +0000 Bug 25224: Show large print format in search results XSLT To test: 1: find a bib with 008 type Book (Leader position 6 = 'a' and leader position 7 = 'm' -- use bib number 1 in master data) 2: set 008 position 23 to 'd' for large print 3: check your book record in opac and intranet search results, note that your change is not reflected in the "format" note in line with material type 4: find a bib with 008 type Continuing Resource (Leader position 6 = 'a' and leader position 7 = 's' -- use bib number 44 in master data) 5: set 008 position 23 to 'd' for large print 6: check your continuing resource record in opac and intranet search results, note that your change is not reflected in the "format" note in line with material type 7: apply patch, restart_all 8: reload search results from steps 3 and 6, confirm they now say "format: large print" Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/TTParser.pm | 10 ++++++++++ .../intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl | 3 +++ .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 3 +++ misc/translator/xgettext.pl | 1 + 4 files changed, 17 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 8 23:04:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 21:04:04 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-100-gbfa97dc73c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via bfa97dc73ca24f41dcabef058e7e50c42f29e0ef (commit) from 0d5d14935aa6749ff02ac885e3b3697a3a08f29f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bfa97dc73ca24f41dcabef058e7e50c42f29e0ef Author: Owen Leonard Date: Tue Apr 14 11:52:17 2020 +0000 Bug 25118: Return claims has some translation issues This patch adds the right function calls to checkouts.js so that English strings can be picked up by the translator. The resolution message has been reformatted so that it can be clear without including "on" and "by" in the middle of the string. To test you should have a patron with at least one return claim. Open the checkout page for that patron and open the "Claims" tab. Test the process of editing, deleting, and resolving claims. TESTING TRANSLATABILITY - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the staff client: misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from checkouts.js for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:920 msgid "Double click to edit" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR Switch to the udpated translation and test the functionality under the "Claims" tab again to confirm that your translated strings appear. Note that "untranslatable string" failures reported by the QA script are false positives. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 8 23:22:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 21:22:50 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-107-g9018cefc25 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 9018cefc25d330355778f56159459a9f4abcf30a (commit) via 303ade2dce48f6dacd8ed576fdc49ce51eb5341d (commit) via bedf692a3c348612f7e97dd2d0e428cab257185d (commit) via 66c0ab283a364f34ca470938b847366d3117153a (commit) via a656ccf5376287c9a572e2db4771dae12a4c1afa (commit) via 77a59b5b3ab8a8870ca9bf9842d1ad30104a05d3 (commit) via 2c9e0ac020c99fbcecfe53e6f5588ce2ece4a1fa (commit) from bfa97dc73ca24f41dcabef058e7e50c42f29e0ef (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9018cefc25d330355778f56159459a9f4abcf30a Author: Lucas Gass Date: Tue Apr 21 21:33:03 2020 +0000 Bug 25233: Staff XSLT material type label "Book" should be "Text" This patch makes the staff client XSLT stylesheets consistent with the ones for the OPAC, it also makes consitent the use of 'Text' when the leader6 = 't' TO TEST: 1. Have a record with leader06 = 'a' and leader07 = 'c' 'd' or 'm'. 2. Check the staff client results and details page. See that the material type label says "Book" 3. Check the OPAC client results and details page. See that the materila type label says "Text" 4. Apply patch. 5. See that both staff client and OPAC results/details all now say "Text" 6. Set the leader6 = 't' and make sure that is says 'Text' on both the staff client and OPAC Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 303ade2dce48f6dacd8ed576fdc49ce51eb5341d Author: Joy Nelson Date: Fri May 8 20:52:03 2020 +0000 Bug 25276: Compiled CSS commit bedf692a3c348612f7e97dd2d0e428cab257185d Author: Owen Leonard Date: Fri Apr 24 14:24:07 2020 +0000 Bug 25276: Correct hover style of list share button in the OPAC This patch adds missing "btn" classes to the OPAC share button so that its style is consistent with similar controls. The patch also makes some general changes to the OPAC CSS to make sure link color and hover color are applied with enough specificity. This corrects the hover color of the share button but should not change any other existing style. To test you should have the OpacAllowSharingPrivateLists preference enabled. - Rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log in to the OPAC as a user with one or more private lists. - Go to Lists -> Your lists. - In the list of lists there should be a "Share" link for each list. Hovering your mouse pointer over the link should change the style in the same way the "Edit" link does. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 66c0ab283a364f34ca470938b847366d3117153a Author: Owen Leonard Date: Mon Apr 20 11:38:41 2020 +0000 Bug 25211: Add missing share icon to OPAC lists page This patch adds a Font Awesome icon to the "Share" links on the list of lists in the OPAC. To test, apply the patch and log in to the OPAC as a user who has one or more private lists. - Go to Lists -> Your lists - In the table of your lists, each list should have a "Share" link with an icon. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit a656ccf5376287c9a572e2db4771dae12a4c1afa Author: Lucas Gass Date: Tue Apr 21 20:11:17 2020 +0000 Bug 24957: OpenLibrarySearch shouldnt display if nothing is returned TO TEST: 1. Turn on OpenLibrarySearch 2. Do an OPAC search that returns results that have results with Open Library results and some that do not. 3. Notice results that return nothing simpliy say "Open Library:" with nothing afterwards. 4. Some results return a png from OpenLibrary or "Not found" 5. Apply patch and look at records again. 6. The results that return nothing for OpenLibrary API should now to hidden. Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 77a59b5b3ab8a8870ca9bf9842d1ad30104a05d3 Author: Katrin Fischer Date: Sun Apr 12 03:19:03 2020 +0000 Bug 21927: Acq - Add blank values in pull downs of mandatory item subfields This is the same fix as on bug 14662, which fixed the behaviour in cataloguing, but for the item form in acquisitions. The code assumes that if a subfield is marked as mandatory, there should be no empty entry in the pull downs. This assumption is not correct, as it leads to the first entry of the pull down being preselected if there is no default set. As the field can never be 'unset', there will never be a 'required' warning. Furthermore, it might be counterproductive to use mandatory fields, as it might be easily forgotten to change the preselected value and those mistakes will be hard to find. Correct behaviour would be to preselect the empty value when there is no default. This means on saving the item an error message is triggered and the cataloger is forced to set the value. To test: - This is best tested with an ACQ framework, but default can be used when no ACQ framework was created. - In your MARC bibliographic framework: - In 952 make itemtype, classification source and some other pull downs like location or collection mandatory and set them to visibel if needed - Create a new basket with 'items created while ordering' - Add a new order, an existing record with 942$c set will work best - Add items for your order line - Verify that the first value of each pull down is preselected, there is no way to trigger the 'required' error - Apply patch - Add a new order line - Verify that classification source is preselected according to the DefaultClassificationSource system preference (try unsetting it later) - Verify all mandatory fields can be set to empty - Verify that you can't save before correctly setting them - Change your frameworks and set a default for itemtype (Ex: BK) and another mandatory and non-mandatory field of your choice - Add a new order line and item and verify the defaults are selected Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2c9e0ac020c99fbcecfe53e6f5588ce2ece4a1fa Author: Owen Leonard Date: Fri Apr 24 11:49:21 2020 +0000 Bug 25274: Don't initialize DataTable if table isn't present This patch modifies the OPAC basket JavaScript so that a check is added for the existence of the "itemst" table. This avoids an error if the "More details" view is selected and hte "itemst" table isn't present. To reproduce the error, add some items to the OPAC cart and open the cart window. Open the JavaScript console in your browser and click the "More details" link. You'll see an error. To test, apply the patch and perform the same test as above. The error should not be present. Test that table sorting in the "brief" view words correctly. Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 8 ++--- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 4 +-- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 4 +-- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss | 1 + koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 26 ++++++++------ .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 41 +++++++++++----------- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js | 2 ++ 9 files changed, 49 insertions(+), 41 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 8 23:59:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 21:59:58 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-114-g8d21d40537 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8d21d40537d5e3872b319796c72640faf079ee57 (commit) via 0e3ad130eaed7db3fd7d547a52420d3a3f70bc42 (commit) via 31dd98d6d418c0f74436a1241dd664f55e5f3d9d (commit) via 1aefaf9bca2022c806e07ba1cbd170336e85807a (commit) via c760d0830054ccf609ea8b78eb8869338d8e288e (commit) via 02896efdf347adbfa0cb262c9b7d46e11dbe4866 (commit) via 85339f38a096c63a9794cab424b4b4d4ce94e291 (commit) from 9018cefc25d330355778f56159459a9f4abcf30a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d21d40537d5e3872b319796c72640faf079ee57 Author: Joy Nelson Date: Fri May 8 21:26:45 2020 +0000 DBIC update Signed-off-by: Joy Nelson commit 0e3ad130eaed7db3fd7d547a52420d3a3f70bc42 Author: Joy Nelson Date: Fri May 8 21:22:48 2020 +0000 Bug 23081: DBRev 19.11.05.004 Signed-off-by: Joy Nelson commit 31dd98d6d418c0f74436a1241dd664f55e5f3d9d Author: Jonathan Druart Date: Mon Apr 27 11:55:15 2020 +0200 Bug 23081: Adjust tests Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1aefaf9bca2022c806e07ba1cbd170336e85807a Author: Jonathan Druart Date: Mon Apr 27 11:51:35 2020 +0200 Bug 23081: Revert "Bug 24443: Consider NULL as 0 for issues in items search" This reverts commit 80f1374f262544a750b5d81a7d9605c8708c53b1. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c760d0830054ccf609ea8b78eb8869338d8e288e Author: Andrew Fuerste-Henry Date: Sun Apr 26 23:53:26 2020 +0000 Bug 23081: atomicupdate for change to existing installs Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 02896efdf347adbfa0cb262c9b7d46e11dbe4866 Author: Andrew Fuerste-Henry Date: Sun Apr 26 23:51:25 2020 +0000 Bug 23081: set default to 0 for items.issues and deleteditems.issues To test: - save and run this sql query in reports: select sum(if(issues is null,1,0)),sum(if(issues=0,1,0)) from items - you should see a lot of nulls and no zeros - apply patch - updatedatabase - re-run your query and see that your nulls have changed to zeros - create a new item - rerun your query and see your new item is counted in the zeros, not the nulls Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 85339f38a096c63a9794cab424b4b4d4ce94e291 Author: Joseph Sikowitz Date: Sat Apr 18 16:06:05 2020 -0400 Bug 24750: Instructor Search Results Adds regex to the split() of the passed parameters to improve searching. Test plan 1. Go to Course Reserves module. 2. Press New course button. 3. Make active the instructor search box. 4. Start typing the last name of a patron that exists in your database. 5. At the end of the last name type ", " and try to add a first name. 6. The search should fail. 7. Apply the patch. 8. Follow steps 1-5 again. 9. You should now be able to search using the following methods 9a. surname, firstname 9b. firstname surname Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 3 --- Koha.pm | 2 +- Koha/Schema/Result/ArticleRequest.pm | 16 ++++++++-------- Koha/Schema/Result/BorrowerModification.pm | 8 ++++---- Koha/Schema/Result/Deleteditem.pm | 8 ++++++-- Koha/Schema/Result/Item.pm | 8 ++++++-- circ/ysearch.pl | 2 +- .../bug_23081-change-default-of-issues-field.perl | 15 +++++++++++++++ installer/data/mysql/kohastructure.sql | 4 ++-- installer/data/mysql/updatedatabase.pl | 11 +++++++++++ t/db_dependent/Items.t | 4 ++-- 11 files changed, 56 insertions(+), 25 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_23081-change-default-of-issues-field.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 9 00:12:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 22:12:58 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-115-g8917804a42 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8917804a423032ebcd2c0fc6c0dd8958d005b0ad (commit) from 8d21d40537d5e3872b319796c72640faf079ee57 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8917804a423032ebcd2c0fc6c0dd8958d005b0ad Author: Joy Nelson Date: Fri May 8 21:45:33 2020 +0000 Bug 23081: followup remove atomicupdate file Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: .../bug_23081-change-default-of-issues-field.perl | 15 --------------- 1 file changed, 15 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_23081-change-default-of-issues-field.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 9 00:14:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 22:14:53 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-118-ga8e67c9530 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a8e67c953009894828a7d2bffd416a2b9e98af95 (commit) via dbcdb741bd43d7cb40b72acd51856bc170964c02 (commit) via 9c8a182c024600cae9c9664304cdb1120d8d8139 (commit) from 8917804a423032ebcd2c0fc6c0dd8958d005b0ad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a8e67c953009894828a7d2bffd416a2b9e98af95 Author: Jonathan Druart Date: Mon Jan 27 11:03:46 2020 +0100 Bug 24339: Do not assume there are exactly 3 SIP* AVs Update DB entry 19.06.00.017: We created SIP* AV from accountlines if '^Pay[[:digit:]]{2}$', so I think we should assume that more than SIP00, SIP01, SIP02 can exist. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joy Nelson commit dbcdb741bd43d7cb40b72acd51856bc170964c02 Author: Martin Renvoize Date: Wed Jan 8 12:48:55 2020 +0000 Bug 24339: Remove SIP payment types from staff pay screens Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joy Nelson commit 9c8a182c024600cae9c9664304cdb1120d8d8139 Author: Martin Renvoize Date: Fri Jan 3 21:50:51 2020 +0000 Bug 24339: Add SIP2 payment types for installation Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/en/mandatory/auth_values.sql | 3 +++ .../intranet-tmpl/prog/en/modules/members/paycollect.tt | 16 ++++++++++++---- 2 files changed, 15 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 9 00:22:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 22:22:54 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-120-g9d4aec3a2b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 9d4aec3a2ba772d37f12e793216feb428bc14c62 (commit) via 9cd83a9c4ea6d5499e516270e2b5e70477bb13f8 (commit) from a8e67c953009894828a7d2bffd416a2b9e98af95 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9d4aec3a2ba772d37f12e793216feb428bc14c62 Author: Phil Ringnalda Date: Tue Apr 21 21:34:33 2020 -0700 Bug 25235: Rename the button instead of alerting when replacing an existing record Test plan: Pre-patch 1 - Go to the main Authorities page, search for any authority, click the Actions menubutton and choose Edit 2 - Note the button saying Z39.50 search 3 - Note the modal alert forcing you to click it 4 - Cancel and cancel again, and in the New authority menubutton choose Default 5 - Click the button saying Z39.50 search again, note that it warns you about replacing your totally blank record Apply this patch 6 - Edit an existing authority, note the button says "Replace record via Z39.50/SRU search" 2 - Click the button, verify it still opens the search window with the main entry of the record filled in without an alert 3 - Create a new authority, note the button says "Z39.50/SRU search" 4 - Click the button, verify it still opens the search window but without an alert Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 9cd83a9c4ea6d5499e516270e2b5e70477bb13f8 Author: Katrin Fischer Date: Tue Apr 14 10:45:01 2020 +0000 Bug 17232: Make sure all fields are copies when creating a new framework from another Some digging revealed that when you create a new framework and use an old framework as the base, some information would not be copied to the new framework as they were missing from the SQL command used here. - Tag: Important - Subfield: - Important - Default value - Max length - Is a URL - Link To test: - Pick one of the existing frameworks and change the fields listed above. Take note of what you changed. - Create a new framework - Go to "Marc structure" of the new framework - You are offered the option to copy an existing framework - Use your prepared framework - Verify the fields weren't copied - your config was lost - Apply patch - Create another new framework - Repeat the duplication and tests - Verify that now all fields have been copied correctly Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: admin/marctagstructure.pl | 12 ++++++------ .../prog/en/modules/authorities/authorities.tt | 18 ++++++++++-------- 2 files changed, 16 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 9 00:37:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 22:37:44 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-127-g071ba2e49b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 071ba2e49bfd8eac30bd97f297d0b6ad62265d8c (commit) via 76ea2eb9b400072162ce51bb7269001bc57459b6 (commit) via 6879393681f89739970d0cb6bd30cbac3926bd19 (commit) via fc836d6e3afa89c8bf4c1b54dd58f5736924a4db (commit) via 8f8d8effa61c966e9c85902d6dc600c769060488 (commit) via e939e0e0dc4ec189fae8e863d5296eb60b36fc36 (commit) via d04c97b2d78bbb3366a584fea87b372fd16c199d (commit) from 9d4aec3a2ba772d37f12e793216feb428bc14c62 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 071ba2e49bfd8eac30bd97f297d0b6ad62265d8c Author: Didier Gautheron Date: Mon Apr 27 14:42:49 2020 +0200 Bug 25291: Escape barcode in ReturnClaims table display Test Plan: 1) Set ClaimReturnedLostValue 2) Create a checkout 3) Claim a return 4) Change the barcode to something with html inside, will do Without this patch cgi-bin/koha/members/moremember.pl claim tab barcode link is broken. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 76ea2eb9b400072162ce51bb7269001bc57459b6 Author: Nick Clemens Date: Mon Apr 27 11:37:13 2020 +0000 Bug 25229: (follow-up) Move QueryBuilder test to Elasticsearch dir Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 6879393681f89739970d0cb6bd30cbac3926bd19 Author: Nick Clemens Date: Tue Apr 21 13:47:59 2020 +0000 Bug 25229: Return authid of record rather than 001 Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit fc836d6e3afa89c8bf4c1b54dd58f5736924a4db Author: Nick Clemens Date: Mon Apr 27 11:28:51 2020 +0000 Bug 25229: Unit test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8f8d8effa61c966e9c85902d6dc600c769060488 Author: Kyle M Hall Date: Mon Apr 27 07:07:12 2020 -0400 Bug 25227: Display correct message if item is withdrawn and withdrawn returns are allowed Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e939e0e0dc4ec189fae8e863d5296eb60b36fc36 Author: Kyle M Hall Date: Tue Apr 21 07:11:08 2020 -0400 Bug 25227: Display correct message if item is lost and lost returns are allowed Even if a library allows returns of lost items, the SIP server returns the error message "Item lost, return not allowed" if the checkin was not ok for any reason other than it being withdrawn ( and withdrawn items not being returnable ). The most clear example of this is that when a lost item is not checked out to a patron and is returned. SIP returns that message even though lost items *can* be returned. The actual problem being that the item was not checked out. Test Plan: 1) Ensure you can return lost items 2) Mark an item as lost 3) Check it in via SIP 4) Note the message you get back is "Item lost, return not allowed" 5) Apply this patch 6) Restart your SIP server 7) Repeat steps 2 and 3 8) Note you no longer get the incorrect message! Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d04c97b2d78bbb3366a584fea87b372fd16c199d Author: Kyle M Hall Date: Mon Apr 27 08:04:07 2020 -0400 Bug 25227: Add unit tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS.pm | 4 +- Koha/SearchEngine/Elasticsearch/Search.pm | 10 ++- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 8 ++- .../QueryBuilder.t | 0 t/Koha/SearchEngine/Elasticsearch/Search.t | 65 ++++++++++++++++++ t/db_dependent/SIP/Transaction.t | 78 +++++++++++++++++++++- 6 files changed, 155 insertions(+), 10 deletions(-) rename t/Koha/SearchEngine/{ElasticSearch => Elasticsearch}/QueryBuilder.t (100%) create mode 100644 t/Koha/SearchEngine/Elasticsearch/Search.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 15:28:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 13:28:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2128-g04ce87c4c0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 04ce87c4c0f8e73b1213aca8e9c3591967c6e94e (commit) from 2b2c605ea7ed0cc907264d82067172fa401c6d75 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 04ce87c4c0f8e73b1213aca8e9c3591967c6e94e Author: Jonathan Druart Date: Wed Apr 8 15:44:55 2020 +0200 Bug 16547: Remove more multi_holds inconsistencies There was a bug, on the biblio's hold list view, if the pickup library was changed, the next screen was "place a hold for no title" http://pro.kohadev.org/cgi-bin/koha/reserve/request.pl?multi_hold=1&biblionumbers= Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 5 ++--- reserve/modrequest.pl | 12 +++++------- reserve/placerequest.pl | 2 +- 3 files changed, 8 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 12:38:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 10:38:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2126-g575878f0fb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 575878f0fbfbd4f222cd8a9d5f9b4704ca1ad19d (commit) from 0e0f09ba94e17c89e0bd54162c47b8032c71e18a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 575878f0fbfbd4f222cd8a9d5f9b4704ca1ad19d Author: Martin Renvoize Date: Mon May 11 11:10:41 2020 +0100 Bug 25184: (RM follow-up) Syntax error correction Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 11:29:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 09:29:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2125-g0e0f09ba94 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0e0f09ba94e17c89e0bd54162c47b8032c71e18a (commit) via 0d4b8cf126bcb5c6539ffb61930642a0fe6e7481 (commit) via d6ca541b5553331da83e5ae4c16b425c1a085ffd (commit) via d7168b02bd9373f40882f8b181e1f43cd8b6d39e (commit) via 20d493090ac86a41b2add16625ae8aa88c450f44 (commit) via 5a1f42e793498987d92d18a58a91b54d82e3bcb9 (commit) via e97ca8ab15114adaba7212760b90e5c98072d4ff (commit) via a0c2012ce9b07b1c74ac80093e082514d2d981d6 (commit) via af495b93c72f275c58ae2bc7cd9a2280648449d7 (commit) via c256a30998763c7962a26c72a7c34de284e04f35 (commit) via e8414baf5b69a239b7c2df43b88c027be84794a4 (commit) via 2363179198c54cc73c5d314b2367a87b367bcef5 (commit) via 040abebb7dce94bd04fcb5bc0af3eebffbb741e5 (commit) via ef55bc44fdd909be94dc7c9ab9918fb8a4edb744 (commit) via bea36d9f09622883e102908c7ca5ca3c04446eeb (commit) via 9f00c5912e7b1c602847e73187ce0e39082a1130 (commit) via 4318d84433062be07fc61764a13f046cb31fcfde (commit) via 0c0bb0dacf3cb1717feaf2737b4b1d708d8186ef (commit) via cc4b6b34c0541f4c56bf85755bc80fca6ea17e36 (commit) via 8cfe35b0440f7b9331b51f24224d80783b03a4da (commit) via 72f013937c7f616554a25f57ef61c9b7f69037be (commit) via f08e7ff8b583ffc547e4ac1faeee7101811fc6df (commit) from f806adf0ea9b39076d41b2b7a74fff9b5f505790 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0e0f09ba94e17c89e0bd54162c47b8032c71e18a Author: David Roberts Date: Mon May 4 19:43:32 2020 +0000 Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) The patch adds the suggestion management reason to the display when viewing a suggestion. To test: 1) Edit a suggestion and assign a reason for accepting it. 2) View the suggestion (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=XX&op=show, replacing XX with your suggestion ID) 3) Under suggestion management, the reason you've just assigned does not display. 4) Apply the patch 5) Check the display again - the Reason should now be visible directly under the status. Signed-off-by: Abbey Holt Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0d4b8cf126bcb5c6539ffb61930642a0fe6e7481 Author: Owen Leonard Date: Fri May 8 16:41:03 2020 +0000 Bug 24963: (follow-up) Fix another instance This patch corrects the second instance of "auto renewal" in the description of the AllowPatronToControlAutorenewal system preference. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize commit d6ca541b5553331da83e5ae4c16b425c1a085ffd Author: Owen Leonard Date: Thu May 7 15:16:35 2020 +0000 Bug 24963: Terminology: Use "auto-renewal" instead of alternatives This patch updates terminology in the templates so that "auto-renewal" is used instead of "auto renewal" or "autorenewal." To test, apply the patch and set the 'AllowPatronToControlAutorenewal' preference to "allow patrons." - Log in to the OPAC and view the "your account" page. - At the top of the "Checked out" tab you should see controls for turning auto-renewals on and off. The labels should be correct. - Turn off auto-renewals for this patron. - In the staff interface, view the detail page for the patron you updated in the previous step. - In right-hand column of information about the patron you should see "Auto-renewal: Patron has opted out." - Add "&print=brief" to the page URL. Check that auto-renewal information displays correctly on this brief view as well. - Go to Administration -> System preferences. - Under the "Circulation" tab, check that the description of the OPACFineNoRenewalsBlockAutoRenew preference refers to "auto-renewal." - Under the "Patrons" tab, check the description of the AllowPatronToControlAutorenewal refers to "auto-renewal." Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d7168b02bd9373f40882f8b181e1f43cd8b6d39e Author: Tomas Cohen Arazi Date: Mon May 4 15:43:18 2020 -0300 Bug 25327: Do not call authenticate_api_request to render the spec The original code for Koha::REST::V1::Auth::under called authenticate_api_request when requesting the API spec. This didn't make sense, and recent changes on what conditions are tested for public routes, broke the route. We could add another condition, but it really doesn't make sense to call authenticate_api_request if it should be publicly available in any configuration, as discussed on the bug. This patch adds a trivial check and the requested route, and lets the request through in any case in 'under'. To test: 1. Point your browser to: http://kohadev.myDNSname.org:8080/api/v1/ http://kohadev.myDNSname.org:8080/api/v1/.html => FAIL: In both cases you get an authorization error. 2. Apply the regression tests patch 3. Run: $ kshell k$ prove t/db_dependent/api/v1/auth.t => FAIL: The tests reflect the situation, and fail 4. Apply this patch 5. Repeat 1 and 3 => SUCCESS: All good! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 20d493090ac86a41b2add16625ae8aa88c450f44 Author: Tomas Cohen Arazi Date: Mon May 4 15:43:08 2020 -0300 Bug 25327: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5a1f42e793498987d92d18a58a91b54d82e3bcb9 Author: Grace McKenzie Date: Wed Jan 18 22:55:48 2017 +0000 Bug 17853: Don't remove () from 780 link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Felix Hemme Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: David Nind Bug 17853: Don't remove () from 785 link text and restore link value of 780 The only thing we change for 780 and 785 is, that if the display text contains (), they are no longer removed. To test: - Catalogue a record with 785$a some text (including) parenthesis e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Katrin Fischer Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit e97ca8ab15114adaba7212760b90e5c98072d4ff Author: Jonathan Druart Date: Fri Apr 17 12:24:24 2020 +0200 Bug 25157: Silent patron deletion cmd line script Without -v the script will no longer display messages unless the error is major. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit a0c2012ce9b07b1c74ac80093e082514d2d981d6 Author: Marcel de Rooy Date: Fri May 8 09:39:46 2020 +0000 Bug 8132: (QA follow-up) Missing filter Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit af495b93c72f275c58ae2bc7cd9a2280648449d7 Author: Jonathan Druart Date: Tue Dec 3 10:58:57 2019 +0100 Bug 8132: Adding message when deleting from the UI Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit c256a30998763c7962a26c72a7c34de284e04f35 Author: Jonathan Druart Date: Tue Dec 3 10:13:38 2019 +0100 Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit e8414baf5b69a239b7c2df43b88c027be84794a4 Author: Jonathan Druart Date: Mon Dec 2 16:32:13 2019 +0100 Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Apply the patches Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold from B2 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 2363179198c54cc73c5d314b2367a87b367bcef5 Author: Jonathan Druart Date: Mon Dec 2 16:15:59 2019 +0100 Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 040abebb7dce94bd04fcb5bc0af3eebffbb741e5 Author: Bernardo Gonzalez Kriegel Date: Thu May 7 08:16:57 2020 -0300 Bug 25410: Sync liblibrarian and libopac descriptions During translations some subfields show different descriptions for intranet/opac Just a little string change To test: 1) Check if changes make sense and there are no errors 2) Check if a clean install loads default marc21 frameworks without problem. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit ef55bc44fdd909be94dc7c9ab9918fb8a4edb744 Author: Katrin Fischer Date: Mon Apr 13 02:20:30 2020 +0200 Bug 24098: Standardize Fines/Fees & Charges This patch suggests to adopt the terminology used in the OPAC to only use charges and leave off the Fines or Fees. To test: - Add a charge to your account - Check the note on the details and checkouts tabs - Check the tab name on the details tab - Activate batch checkouts via systempreferences for your patron category: - BatchCheckouts - BatchCheckoutsValidCategories - Add a guarantee to your patron and allow to see fines (requires: AllowStaffToSetFinesVisibilityForGuarantor) - Add a manual fine for the guaranee above NoIssuesChargeGuarantee - Go to the batch checkout tab of your patron and verify note there Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit bea36d9f09622883e102908c7ca5ca3c04446eeb Author: Owen Leonard Date: Thu May 7 14:57:25 2020 +0000 Bug 25343: Use of item in review/comment feature is misleading This patch updates the terminology associated with leaving a comment in the OPAC. the word "item" is replaced with the more specific "title." To test, apply the patch and make sure the reviewson system preference is enabled. - Log in to the OPAC and view a bibliographic record which has no comments. - Under the "comments" tab, verify that the text in the tab says "There are no comments on this title. Post your comments on this title." Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 9f00c5912e7b1c602847e73187ce0e39082a1130 Author: George Veranis Date: Wed Apr 22 11:43:53 2020 +0200 Bug 19312: Fix typo in template This patch fixes a simple typo Test plan: 1) Go to Administration -> MARC bibliographic framework 2) Select a framework and add plugin unimarc_field_121a.pl to 121 field 3) Open cataloguing screen 4) Go to 121 field and check if for subfield a shows two times the value 2-dimensional 5) Apply the patch 6) Go to 121 field again and check if it shows 2 different values Mentored-by: Andreas Roussos Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 4318d84433062be07fc61764a13f046cb31fcfde Author: David Roberts Date: Thu May 7 18:07:21 2020 +0000 Bug 25388: There is no link for the "online help" This patch removes a non-existent link to the online help from the marc subfield editor. To test: 1) Go to Admin > MARC Bibliographic framework > Edit MARC structure > Edit subfield (for example /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=000&frameworkcode=AR) 2) Check that the Max Length value in the Advanced constraints area contains text saying "See online help" 3) Apply patch 4) Check that the reference to the online help has disappeared. Remove tabs from start of line Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0c0bb0dacf3cb1717feaf2737b4b1d708d8186ef Author: Nicolas Legrand Date: Thu Apr 9 16:50:55 2020 +0200 Bug 25099: Sending a LANG variable to plug-in template To make internationalised plug-ins, it may be useful to get the lang from C4::Languages::getlanguage. This patch adds C4::Languages::getlanguage result to a LANG variable which is sent to the template plugin. In your plugin, you can add a i18n directory containing lang[-DIALECT].inc files with a TOKENS hash like this: [% TOKENS = { PLUGIN_NAME = "Mannequin" PRESENTATION = "Voici un example d'outil." CLICK_ME = "Cliquez moi !" } %] The plugin template can then include such a lang[-DIALECT].inc with a hash containing all the plugin strings: [% TRY %] [% PROCESS "$PLUGIN_DIR/i18n/${LANG}.inc" %] [% CATCH %] [% PROCESS "$PLUGIN_DIR/i18n/default.inc" %] [% END %] The strings are then printed in the template with something like: [% TOKENS.PRESENTATION %] Test plan: 1. apply patch 2. install, enable and run BULAC Mannequin plugin 3. it should print stuff in english by default 4. install french French (fr-FR) 5. change you Koha lang to French 6. run again the plugin 7. ho là là! French! Thanks to Tomàs Cohen and his pay via paypal plug-in from which most ideas in this patch are taken. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize commit cc4b6b34c0541f4c56bf85755bc80fca6ea17e36 Author: Katrin Fischer Date: Tue May 5 11:43:39 2020 +0000 Bug 25082: Don't remove characters from string At the moment, show-lang-041 will either get a code or an AV description to deal with. If it's a description, we don't want to remove spaces and other chars from it. To test: - Repeat tests from first patch with an AV in LANG category that consists of multiple words, has a - and other possible punctuation. - The description should show correctly in OPAC and staff. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8cfe35b0440f7b9331b51f24224d80783b03a4da Author: Katrin Fischer Date: Sun Apr 12 16:30:05 2020 +0000 Bug 25082: Make 041 descriptions display, if authorised value list is used When 041$a or another subfield is linked to an authorised value list, Koha will replace the codes with the descriptions from the authorised value in the MARCXML before passing it to the XSLT. The XSLT was made to translate codes into descriptions - as there is no code now, this fails and 'unknown language' is shown. The patch changes the handling so that when the XSLT is handled something that doesn't match a known code, it displays the subfield without processing. To test: - Create some records with 041. Examples: http://www.loc.gov/marc/bibliographic/bd041.html - Verify this displays nicely in staff and OPAC - Apply patch - Verify display is unchanged - Remove the patch - Change one of your MARC frameworks (use another framework than for your first test records) and link the 041 subfields to the LANG authorised value list - Go to administration and create some entries for LANG with language codes and descriptions - Catalog a 041 using the normal editor (not advanced) - You can now use a pull down to select the values you want - Verify the display is now 'Unknown language' for this record - Apply patch - Verify all records display the language descriptions now, using an authorised value or not - Run misc/maintenance/generate_MARC21Languages.pl Verify the output at the end reads like: Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 72f013937c7f616554a25f57ef61c9b7f69037be Author: Frédéric Demians Date: Tue May 5 19:21:15 2020 +0200 Bug 25325: ElasticSearch mapping export lacks staff_client/opac fields Run test: prove t/db_dependent/Koha/SearchEngine/Elasticsearch/ExportConfig.t Or: Run export_elasticsearch_mappings.pl script. See that opac/staff_client fields are exorted. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit f08e7ff8b583ffc547e4ac1faeee7101811fc6df Author: Frédéric Demians Date: Tue May 5 19:19:26 2020 +0200 Bug 25325: Test ES lack of staff_client/opac fields Run this test to see that export_elasticsearch_mappings.pl doesn't export staff_client/opac fields. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Item.pm | 10 + Koha/Plugins/Base.pm | 2 +- Koha/REST/V1/Auth.pm | 3 + Koha/SearchEngine/Elasticsearch.pm | 2 + .../marc21/mandatory/authorities_normal_marc21.yml | 18 +- .../marc21/mandatory/marc21_framework_DEFAULT.yml | 46 ++--- .../prog/en/includes/blocked-fines.inc | 4 +- .../en/modules/admin/marc_subfields_structure.tt | 2 +- .../en/modules/admin/preferences/circulation.pref | 2 +- .../prog/en/modules/admin/preferences/patrons.pref | 2 +- .../prog/en/modules/cataloguing/additem.tt | 1 + .../value_builder/unimarc_field_121a.tt | 4 +- .../prog/en/modules/circ/circulation.tt | 2 +- .../en/modules/circ/circulation_batch_checkouts.tt | 2 +- .../prog/en/modules/members/moremember-brief.tt | 2 +- .../prog/en/modules/members/moremember.tt | 4 +- .../prog/en/modules/suggestion/suggestion.tt | 6 + .../prog/en/modules/tools/batchMod-del.tt | 41 +++- .../prog/en/modules/tools/batchMod-edit.tt | 2 - .../intranet-tmpl/prog/en/xslt/MARC21Languages.xsl | 3 +- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 8 +- .../intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl | 4 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 +- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +- .../bootstrap/en/xslt/MARC21Languages.xsl | 3 +- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 8 +- .../bootstrap/en/xslt/MARC21slimUtils.xsl | 4 +- misc/cronjobs/delete_patrons.pl | 9 +- misc/maintenance/generate_MARC21Languages.pl | 3 +- t/db_dependent/Koha/Item.t | 10 +- .../Koha/SearchEngine/Elasticsearch/ExportConfig.t | 9 +- t/db_dependent/api/v1/auth.t | 13 +- tools/batchMod.pl | 229 ++++++++++++--------- 33 files changed, 291 insertions(+), 175 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 9 01:26:39 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 23:26:39 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-145-g47414f97c1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 47414f97c1358da9cd79e1e884ab1f9d74516014 (commit) via 86d7b100d7ac474186f44e8b96f8a1c594ab3a18 (commit) via 2bd6572578618f27ae602d1dded21382dd76df3a (commit) via f2aaef739ef5127cc737692bde84b6cbc93671ca (commit) from 243e94598e5f3d84b7b53b67c5bc38a1eecee5e0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 47414f97c1358da9cd79e1e884ab1f9d74516014 Author: Martin Renvoize Date: Wed Dec 11 11:53:51 2019 +0000 Bug 15751: Add ModDateLastSeen to ProcessOfflineReturn Test plan: 1) Before the patch when one checks in something using the KOCT the last seen date is not updated. 2) After the patch when one checks in something using the KOCT the last seen date is updated. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 86d7b100d7ac474186f44e8b96f8a1c594ab3a18 Author: Martin Renvoize Date: Mon Apr 20 12:09:27 2020 +0100 Bug 25127: Use Koha::Number::Price->round for comparison Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 2bd6572578618f27ae602d1dded21382dd76df3a Author: Martin Renvoize Date: Mon Apr 20 09:34:19 2020 +0100 Bug 25127: Correction to tests Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit f2aaef739ef5127cc737692bde84b6cbc93671ca Author: Nick Clemens Date: Mon Apr 13 12:47:03 2020 +0000 Bug 25127: Unit tests Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 ++ C4/Overdues.pm | 2 +- t/db_dependent/Overdues.t | 79 +++++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 79 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 13:18:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 11:18:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2127-g2b2c605ea7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2b2c605ea7ed0cc907264d82067172fa401c6d75 (commit) from 575878f0fbfbd4f222cd8a9d5f9b4704ca1ad19d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2b2c605ea7ed0cc907264d82067172fa401c6d75 Author: Jonathan Druart Date: Mon May 11 12:43:06 2020 +0200 Bug 8132: Fix failing tests * Add missing html filter (xt/find-missing-filters.t) * Fix AddReserve call Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt | 2 +- t/db_dependent/Koha/Item.t | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 10:51:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 08:51:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2103-gf806adf0ea Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f806adf0ea9b39076d41b2b7a74fff9b5f505790 (commit) via 82e866fcb549d25a6269d7a25138ae047c95bdb4 (commit) via cc938e6be18ae4e81207bfdbd6a0a438529c60cc (commit) from fc9ef3a2799f4654b114c319c1955113f7f716c6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f806adf0ea9b39076d41b2b7a74fff9b5f505790 Author: Martin Renvoize Date: Mon May 11 08:57:47 2020 +0100 Bug 25184: DBRev 19.12.00.087 Signed-off-by: Martin Renvoize commit 82e866fcb549d25a6269d7a25138ae047c95bdb4 Author: Kyle M Hall Date: Tue Apr 21 12:52:38 2020 -0400 Bug 25184: Add syspref It's entirely possible that some libraries are relying on the current before for part of their workflow. Do to this possibility, it seems like a good idea to control this behavior via a system preference. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Set TrapHoldsOnOrder to "don't trap" 4) Set an item's notforloan value to -1 5) Place a hold on that item 6) Check in the item 7) Note the item is not trapped for hold 9) Set TrapHoldsOnOrder to "trap" 10) Check in the item 11) Koha should now ask if you'd like to trap the item for the hold! Signed-off-by: Martin Renvoize commit cc938e6be18ae4e81207bfdbd6a0a438529c60cc Author: Kyle M Hall Date: Fri Apr 17 14:06:32 2020 -0400 Bug 25184: Items with a negative notforloan status should not be captured for holds Negative notforloan statuses should allow holds to be placed but not captured. Due to coronavirus, we have libraries setting all returned materials to a negative notforloan value of Quarantine for several days. They're using UpdateNotForLoanStatusOnCheckin to set that status automatically. However, those items are still capturing for holds, even though those items cannot be checked out until the notforloan status is removed. In cases like an On Order item where we do want the hold to fill at checkin, UpdateNotForLoanStatusOnCheckin should be used to clear that notforloan status so the hold can fill. In master, if I set an item to a not for loan but holdable status ( < 0 ) I can place the hold, capture the hold and set it to waiting, but *not* check it out to the patron! This does not make sense. I should not be able to trap an item for checkout unless it can be checked out. Test Plan: 1) Set an item's notforloan value to -1 2) Place a hold on that item 3) Check in the item 4) Trap the item for that hold 5) Attempt to check the item out to the patron, you will be unable to because it is notforloan 6) Apply this patch 7) Restart all the things! 8) Repeat steps 1-3 9) The screen should no longer ask if the item should be trapped to fill the hold! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Catherine Ingram Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 5 ++++- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 10 ++++++++++ .../en/modules/admin/preferences/circulation.pref | 6 ++++++ t/db_dependent/Holds.t | 23 +++++++++++++++++++++- 6 files changed, 44 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 9 00:59:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 22:59:26 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-133-gb5add0dd05 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b5add0dd0556f9468708595860c2833d34eeb433 (commit) via 5a0a350ed7d9e1fa5e93500b2eb92ae33589de4a (commit) via ac3a39bd48be70e8ceadcd42fe0a1086a554d1fc (commit) via 32f43c1bdf10d5bce2472e2bfc42055065a25aec (commit) via 5a8067ff09f9679ff836695f3a01619b3c9b763f (commit) via 1be0d7500cac91457d8f69b437706630d5339a2d (commit) from 071ba2e49bfd8eac30bd97f297d0b6ad62265d8c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5add0dd0556f9468708595860c2833d34eeb433 Author: Jonathan Druart Date: Fri Feb 21 16:07:23 2020 +0100 Bug 22828: Add tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5a0a350ed7d9e1fa5e93500b2eb92ae33589de4a Author: Nick Clemens Date: Thu May 2 11:27:27 2019 +0000 Bug 22828: Elasticsearch - display errors encountered during indexing on the command line To test: 1 - Use the Koha sample data, or insert a blank 245$b into a record (easiest way is using advanced cataloging editor 2 - Reindex elasticsearch 3 - Check the ES count on the about page 4 - Check the count in the DB (SELECT count(*) FROM biblio) 5 - They don't match! 6 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 7 - No errors indicated 8 - Apply patch 9 - perl misc/search_tools/rebuild_elastic_search.pl -v 10 - You should be notified of an error 11 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 12 - You should be notified of the specific biblio with an error and a (somewhat) readable reason 13 - perl misc/search_tools/rebuild_elastic_search.pl 14 - No output Signed-off-by: Ere Maijala Signed-off-by: Séverine QUEUNE Signed-off-by: Bouzid Fergani Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ac3a39bd48be70e8ceadcd42fe0a1086a554d1fc Author: Nick Clemens Date: Tue Apr 21 17:30:00 2020 +0000 Bug 25231: Rename button instead of alert/confirm when replacing record This test plan applies to the basic editor only To test: 1 - Edit an existing record 2 - Click 'Z3950 Search' 3 - Note the confirmation box 4 - Add a new record 5 - Click 'Z3950 Search' 6 - Note no popup 7 - Apply patch 8 - Edit existing record 9 - Note button now says 'Replace record via Z3950 search' 10 - Add a new blank record 11 - Note the button says 'Z3950 search' 12 - Confirm editing/saving/replacing works as in the past Signed-off-by: Phil Ringnalda Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 32f43c1bdf10d5bce2472e2bfc42055065a25aec Author: Lucas Gass Date: Wed Apr 15 21:42:36 2020 +0000 Bug 25072: Fix details.tt print CSS TO TEST: -Search for something in the catalog and go to the details page. -Try to print either for the Print button in Koha or File->Print... -Notice the large amount of whitespace on the left -Apply patch -Reload detaials page and attempt to print again. -No whitespace on left side Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5a8067ff09f9679ff836695f3a01619b3c9b763f Author: David Cook Date: Tue Apr 28 11:40:23 2020 +1000 Bug 25299: Show soon to expire patron date This patch fixes the call to show the patron expiry date on the Details page when the patron is soon to expire. Test plan: 0. Do not apply patch yet 1. Create a patron 2. Set patron's date expiry to 3 days from today 3. Go to Details tab 4. Note message "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5. Apply patch 4. Note message pattern "Expiration: Patron's card will expire soon. Patron's card expires on XX/XX/XXXX Renew or Edit details" Signed-off-by: Frédéric Demians Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1be0d7500cac91457d8f69b437706630d5339a2d Author: David Cook Date: Tue Apr 28 12:00:15 2020 +1000 Bug 25300: Fix typo in "Edit details" for expiring/expired patron This patch removes a typo in the argument to the "op" parameter for the "Edit details" link when editing an expiring/expired patron on the Details page. Test plan: 0. Do not apply patch yet 1. Create patron 2. Set expiry date to 3 days from now 3. Go to Details tab in patron record 4. Click "Edit details" in "Library use" section 5. Note the form is blank and has no patron data in it 6. Apply the patch 7. Reload the Details page in patron record 8. Click "Edit details" in "Library use" section 9. Note the form now contains your patron data and will work for editing the details Signed-off-by: Frédéric Demians Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/Indexer.pm | 6 ++--- koha-tmpl/intranet-tmpl/prog/css/print.css | 5 ++++ .../prog/en/modules/cataloguing/addbiblio.tt | 15 +++++------ .../prog/en/modules/members/moremember.tt | 6 ++--- misc/search_tools/rebuild_elasticsearch.pl | 30 ++++++++++++++++++++-- .../Koha/SearchEngine/Elasticsearch/Indexer.t | 7 +++-- 6 files changed, 50 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 9 01:15:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 08 May 2020 23:15:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-141-g243e94598e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 243e94598e5f3d84b7b53b67c5bc38a1eecee5e0 (commit) via 40f4e9437cb012f93de7ac3b66bcb649617f13f5 (commit) via c85ae52c22592587e5bae7f7c5974400a9f07b0d (commit) via 7f99b5a1a0b7ac587dac91ef1c5447c824eadc13 (commit) via cd7ab5328b5752839398353867eaea517de051bb (commit) via 59021355f91a28105166d10efe30c2aab837e9aa (commit) via de542d406e0ab4f2c22bd66a12ec13dc8d61acca (commit) via 7aa114f11e4d194d3db5dcf765974a56a3d5c84b (commit) from b5add0dd0556f9468708595860c2833d34eeb433 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 243e94598e5f3d84b7b53b67c5bc38a1eecee5e0 Author: Josef Moravec Date: Thu Apr 30 11:29:56 2020 +0000 Bug 24043: (QA follow-up) Fix another TypeError when retrieving status name Test plan: 1) Apply first patch, and have the same requests as in previous patch test plan 2) Load ill requests list 2a) You can see another TypeError in console 2b) You can notice, the Placed on and Updated on columns have prepended another columns with unformatted dates and without header label 3) Apply this patch 4) Reload page (be sure it is not loaded from cache - Ctrl+F5) 5) Errors from 2a and 2b are gone Signed-off-by: Josef Moravec Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 40f4e9437cb012f93de7ac3b66bcb649617f13f5 Author: Andrew Isherwood Date: Mon Jan 13 10:18:19 2020 +0000 Bug 24043: Fix retrieval of of status name This patch modifies the way in which a request's status name is retrieved. I think the previous way it was done (which can never have worked properly) must have come from a time when we weren't embedding the request's backend capabilities in each request. So now we can just use the current row. Test plan: 1. *Before applying the patch*: 2. Ensure you have at least two requests, from two different backends. One of the backends you are using must have a possible status that doesn't exist in the other. For example, the BLDSS backend has a status of STAT, that doesn't not exist in any other backends. 3. Ensure that the request who's backend has the unique status is *not* the first request in the returned list. 4. Load the "View ILL requests" page 5. Observe that the page JS fails with a "Cannot read property 'name' of undefined" error 6. Apply the patch 7. Reload the page (maybe doing a hard reload to ensure the JS is not cached) 8. TEST: Observe that the error no longer occurs and the requests all have their statuses displayed correctly. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c85ae52c22592587e5bae7f7c5974400a9f07b0d Author: Tomas Cohen Arazi Date: Thu Mar 19 12:04:39 2020 -0300 Bug 24908: Add text-formatted MARC support in /biblios/{biblio_id} This patch makes the route support requesting (through the Accept header) the MARC record to be output as formatted text as in $record->as_formatted. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Try the route with your favourite API testing tool (Postman?) => SUCCESS: Accept: text/plain returns the expected results => SUCCESS: Wrong Accept header returns a list of valid formats, and includes 'text/plain'. 6. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 7f99b5a1a0b7ac587dac91ef1c5447c824eadc13 Author: Tomas Cohen Arazi Date: Thu Mar 19 12:04:27 2020 -0300 Bug 24908: Unit tests Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit cd7ab5328b5752839398353867eaea517de051bb Author: Jonathan Druart Date: Wed Apr 15 16:38:16 2020 +0200 Bug 23137: Move cache flushing to the method Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 59021355f91a28105166d10efe30c2aab837e9aa Author: Nick Clemens Date: Tue Apr 14 10:14:00 2020 +0000 Bug 23137: Add documentation Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit de542d406e0ab4f2c22bd66a12ec13dc8d61acca Author: Nick Clemens Date: Thu Mar 19 16:37:24 2020 +0000 Bug 23137: Add reset and delete to koha-elasticsearch Same as previous test, but use the script to run the reindex reset_all to update the scripts or use misc4dev/cp_debian_files.pl sudo koha-elasticsearch --rebuild -r -v Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 7aa114f11e4d194d3db5dcf765974a56a3d5c84b Author: Nick Clemens Date: Thu Mar 19 16:30:29 2020 +0000 Bug 23137: Add reset option to rebuild_elasticsearch.pl Setup: 1 - Be using Elasticsearch 2 - Reload mappings from the db Admin->Search configuration Reset Mappings 3 - Reindex ES and confirm searching is working To test: 1 - Apply patch 2 - Alter your mappings file for elastic (just change a description for a field) 3 - perl misc/search_tools/rebuild_elasticsearch.pl -r -v Verbose not necessary, but good for letting you know things are progressing 4 - Confirm the mapping change shows in the interface 5 - Confirm reindex worked and searching is working Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1/Biblios.pm | 8 +++++++- Koha/SearchEngine/Elasticsearch.pm | 7 +++++++ admin/searchengine/elasticsearch/mappings.pl | 13 +++++-------- api/v1/swagger/paths/biblios.json | 3 ++- debian/docs/koha-elasticsearch.xml | 15 +++++++++++++++ debian/scripts/koha-elasticsearch | 16 ++++++++++++++++ koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 13 +++---------- misc/search_tools/rebuild_elasticsearch.pl | 21 ++++++++++++++++++++- .../Koha/SearchEngine/Elasticsearch/Reset.t | 11 ++++++++++- t/db_dependent/api/v1/biblios.t | 10 ++++++++-- 10 files changed, 93 insertions(+), 24 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 15:46:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 13:46:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2129-ga57cc4645d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a57cc4645d38b80ec9a8846afcea2d27f22605b4 (commit) from 04ce87c4c0f8e73b1213aca8e9c3591967c6e94e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a57cc4645d38b80ec9a8846afcea2d27f22605b4 Author: Jonathan Druart Date: Mon May 11 15:13:18 2020 +0200 Bug 25248: (bug 23463 follow-up) Adjust second occurrence Same as the precedent patch for a single item deletion (vs delete all items) Item is returned if deletion successful, not 1 Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: cataloguing/additem.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 19:18:09 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 17:18:09 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-151-g93f37f3a03 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 93f37f3a03fc1205b3c3cb54e650081dc3dd79ea (commit) via 18f3661179e6a556fc1c39a8841edb99e4e97cd9 (commit) via e4e31117e7dcdc769f6c94553165202c49c7e0ae (commit) via b325831210dacbb0857f843670eb26b0c5268e6d (commit) via 6e53814c58be68bf7392395896c7a66a40d12bd1 (commit) via 8dea59bba0c620da41a47698e2142e61f1dba3f9 (commit) from 47414f97c1358da9cd79e1e884ab1f9d74516014 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 93f37f3a03fc1205b3c3cb54e650081dc3dd79ea Author: Owen Leonard Date: Mon Apr 27 13:20:23 2020 +0000 Bug 22515: Improve logic determining how to show OPAC suggestions This patch makes changes to the OPAC suggestions view so that the logic around logged in users and the OPACViewOthersSuggestions preference is more specific. To reproduce the bug you should have pending purchase susggestions in your system from more than one patron. 1. Set the OPACViewOthersSuggestions preference to "Show." 2. Log in to the OPAC as a user who has not submitted any suggestions. 3. Follow the link to the purchase suggestions page from the menu under the search bar. 4. The page will say that there are no purchase suggestions. 5. Add "?suggested_by_anyone=1" to the end of the page URL. 6. You should see suggestions from other users. To test, apply the patch and repeat steps 2-3 above. The suggestions page should show other patrons' suggestions. Test with different combinations of factors: - Logged in user, OPACViewOthersSuggestions off - No logged in user, OPACViewOthersSuggestions on - No logged in user, OPACViewOthersSuggestions off Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 18f3661179e6a556fc1c39a8841edb99e4e97cd9 Author: Nick Clemens Date: Wed Apr 22 12:11:53 2020 +0000 Bug 25247: Only convert data ot objects when displaying on screen To test: 1 - Modify a patron 2 - Circulate some items to the patron 3 - Click 'Modification log' 4 - Verify you see your actions 5 - Under 'Output' select 'To a file' 6 - Save the output to a file 7 - View the file 8 - Not you have references ot objects in stead of patron/item data 9 - Apply patch 10 - Repeat 11 - Note viewing on screen has not changed 12 - Note exporting to file inlcudes borrower/item numbers and not references 13 - Sign off Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit e4e31117e7dcdc769f6c94553165202c49c7e0ae Author: Owen Leonard Date: Wed Apr 29 17:57:44 2020 +0000 Bug 21565: (follow-up) Make confirmation buttons more detailed This patch updates the confirmation buttons to be more specific about what each one does. My concern was that it wasn't clear that "No" meant "No receipt" and not "Cancel logging out." The patch also updates the modal confirmation code so that the modal body is removed if no message is passed for it. To test, apply the patch and repeat the previous test plan. When you click "Finish" you should have the options "Print receipt and end session" and "End session." Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit b325831210dacbb0857f843670eb26b0c5268e6d Author: Lucas Gass Date: Fri Apr 24 18:39:02 2020 +0000 Bug 21565: Add modal to SCO confirm This patch uses the confirmModal framework to add a modal confirm to SCO Finish. TO TEST: 1. Enable SCO and go to /cgi-bin/koha/sco/sco-main.pl. Make sure SelfCheckReceiptPrompt is set to 'show' 2. Login and click 'Finish' to see the old print alert box. 3. Apply patch and repeat steps 1 and 2. 4. Make sure the modal works for confirming and denying a receipt. Checkout some items and make sure everything still functions the same. 5. Make sure when printing a receipt that the print dialog automatally shows 6. Set SelfCheckReceiptPrompt to 'Don't show' and confirm behavior is acceptable. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize commit 6e53814c58be68bf7392395896c7a66a40d12bd1 Author: Kyle M Hall Date: Fri Apr 10 06:58:43 2020 -0400 Bug 25107: Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType At some point some calls to maybe_add got an extra $server var in their parameter lists. This doubled parameter does nothing and should be removed. Test Plan: No change in behavior should be noted Signed-off-by: Frédéric Demians Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 8dea59bba0c620da41a47698e2142e61f1dba3f9 Author: David Roberts Date: Mon Apr 6 23:42:19 2020 +0000 Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a This patch makes the subfield i display before subfield a in the 246 and 730 fields To test: 1) Create a bibliographic record with data in several subfields in tags 246 and 730. 2) See that subfield i displays at the end of the field in the 246 field, and probably not at all in the 730 field. Check in both the OPAC and staff client 3) Apply the patch. 4) Check your bib record again in both clients. Subfield i should now display before subfield a. Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/SIP/Sip/MsgType.pm | 30 +++++++++++----------- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 15 ++++++++--- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 6 ++--- .../bootstrap/en/modules/opac-suggestions.tt | 18 ++++++++++--- .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 17 +++++++----- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 15 ++++++++--- koha-tmpl/opac-tmpl/bootstrap/js/global.js | 8 ++++-- tools/viewlog.pl | 4 +-- 8 files changed, 75 insertions(+), 38 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 21:46:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 19:46:44 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-5-g3c4e03fbcd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 3c4e03fbcdcdc0c7e61b488526b8915b60b2f80c (commit) via 9ecf51eb43d49e4029d08821a2c360529cbaa65d (commit) from 12bf0c91d1ff15dc2c33cb25c16edbdb5121d740 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3c4e03fbcdcdc0c7e61b488526b8915b60b2f80c Author: Martin Renvoize Date: Fri Apr 3 14:10:07 2020 +0100 Bug 9422: (RM follow-up) Rebase Correction Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d611dd49aedfbe3c69c8d5042d3b0b59a6ffaf5f) Signed-off-by: Lucas Gass commit 9ecf51eb43d49e4029d08821a2c360529cbaa65d Author: Katrin Fischer Date: Sun Feb 10 12:09:08 2019 +0100 Bug 9422: Don't allow access to 'Upload patron images' when patronimages syspref is off In addition to checking the patron image upload permission, this adds a check for the patronimages system preference to the tools home page and sidebar. To test: - Check that the patron image upload tool only displays when - system preference patronimages is set to 'Allow' and user is either - superlibrarian or - has bath_upload_patron_images permission - Save URL of patron image uploader page - Turn off patronimages - Verify you get redirected to the home page of Koha when trying to access the page Note: this redirect is already used by the stock rotation feature. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 4ed4b51e4bbbcc0e968c1685a6f4eaeefc6d7e37) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt | 4 ++-- tools/picture-upload.pl | 6 ++++++ 3 files changed, 10 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 21:55:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 19:55:25 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-156-gfa24607515 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via fa246075155d6a64cab51f78ccba2ad4ce8108a8 (commit) via 65959ccdfbf0b2351f1709fefa5c6c8bf020e696 (commit) via c5f24c2042df50a8b3ef186c9b652565817a2668 (commit) via 5a2506a849b3848045482987e166da09e2d72d43 (commit) via cb62a145f5acf596713f1358cac3ed822bf04f97 (commit) from 93f37f3a03fc1205b3c3cb54e650081dc3dd79ea (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fa246075155d6a64cab51f78ccba2ad4ce8108a8 Author: Jonathan Druart Date: Wed Apr 8 08:47:49 2020 +0200 Bug 24801: (follow-up) Display all the libraries - Selenium fix We have it failing now for the delete link.. 14:26:50 selenium_1 | 05:26:50.451 WARN - Exception: Unable to locate element: {"method":"xpath","selector":"//*[@id=\"delete_library_UT_BC\"]"} Signed-off-by: Joy Nelson commit 65959ccdfbf0b2351f1709fefa5c6c8bf020e696 Author: Jonathan Druart Date: Thu Mar 26 09:59:32 2020 +0100 Bug 24801: Display all the libraries - Selenium fix Same as for categories. 22:41:28 koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:104 in Selenium::Remote::Driver::catch {...} 22:41:28 koha_1 | /usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:353 in Try::Tiny::try 22:41:28 koha_1 | (eval 1337):1 in Selenium::Remote::Driver::__ANON__ 22:41:28 koha_1 | (eval 1339):2 in Selenium::Remote::Driver::__ANON__ 22:41:28 koha_1 | /usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:1330 in Selenium::Remote::Driver::_execute_command 22:41:28 koha_1 | /usr/local/share/perl/5.20.2/Selenium/Remote/Driver.pm:1330 in (eval) 22:41:28 koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:174 in Selenium::Remote::Driver::find_element 22:41:28 koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:166 in t::lib::Selenium::click_when_visible 22:41:28 koha_1 | t/db_dependent/selenium/administration_tasks.t:128 in t::lib::Selenium::click 22:41:28 koha_1 | 22:41:28 selenium_1 | 14:41:28.273 INFO - Executing: [take screenshot]) 22:41:28 selenium_1 | 14:41:28.873 INFO - Done: [take screenshot] 22:41:31 koha_1 | 22:41:31 koha_1 | SCREENSHOT: https://framapic.org/0nvX5dhLHpU1/tAEnENSeLRXB 22:41:31 koha_1 | An element could not be located on the page using the given search parameters: //div[@class="main container-fluid"]//a[contains(@href, "/admin/branches.pl?op=add_form&branchcode=UT_BC")],xpath at /kohadevbox/koha/t/lib/Selenium.pm line 174. The screenshot was obvious, the UT_BC was not on the first page. There was a total of 33 libraries at this point, which is not expected, maybe data not deleted from previous selenium tests. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c5f24c2042df50a8b3ef186c9b652565817a2668 Author: Jonathan Druart Date: Wed Mar 4 15:53:12 2020 +0100 Bug 24801: Display all the categories - Selenium fix To make sure we are going to be able to click on the "Delete" button of our newly created category PATRON_CAT, we are displaying them all. Test plan: Create several patron categories that will fill the first page: use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new; for my $i ( 1..20 ) { $builder->build_object({ class => 'Koha::Patron::Categories', value => { description => "cat_$i" } }); } Execute the selenium tests. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5a2506a849b3848045482987e166da09e2d72d43 Author: Jonathan Druart Date: Mon May 11 16:04:27 2020 +0200 Bug 23081: [19.11.x] Set items.issues to 0 if not provided (AddItem) In master it has been replaced by Koha::Object->store and we deal with the default value. Signed-off-by: Joy Nelson commit cb62a145f5acf596713f1358cac3ed822bf04f97 Author: Nick Clemens Date: Wed Jun 19 17:59:14 2019 +0000 Bug 20816: [19.11.x] Add ability to define custom templated fields in SIP patron responses To test: 1 - You will need to enable SIP on your testing instance cp etc/SIPconfig.xml /etc/koha/sites/kohadev/ sudo koha-start-sip add a user listed in the SIPconfig to your system and give them permissions (superlibrarian works) on koha-testing-docker you should be able to start sip with user koha/koha without any adjustments 2 - If you copied the above file you should be set to get custom field DE with dateexpiry Otherwise edit the sip login for the user to have a custom section like: 3 - send a status test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l kohalibrary --patron 23529001000463 -m patron_status_request 4 - send an information test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l kohalibrary --patron 23529001000463 -m patron_information 5 - confirm you receive the DE field with a dateexpiry 6 - Add your own custom fields and confirm it works with several 7 - prove -v t/db_dependent/SIP/Patron.t 8 - prove -v t/db_dependent/SIP/ Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Bug 20816: Make SIP tests pass under ES Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 2 +- C4/SIP/ILS/Patron.pm | 47 ++++++++++++++++++++++---- C4/SIP/Sip.pm | 1 - C4/SIP/Sip/MsgType.pm | 17 ++++++++-- etc/SIPconfig.xml | 1 + t/db_dependent/SIP/Message.t | 17 ++++++---- t/db_dependent/SIP/Patron.t | 46 ++++++++++++++++++++++++- t/db_dependent/SIP/Transaction.t | 21 +++++------- t/db_dependent/selenium/administration_tasks.t | 9 +++++ 9 files changed, 128 insertions(+), 33 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 21:56:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 19:56:17 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-6-g8c81690d44 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8c81690d449ae0c68c71e65cb770f77a2eb60444 (commit) from 3c4e03fbcdcdc0c7e61b488526b8915b60b2f80c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8c81690d449ae0c68c71e65cb770f77a2eb60444 Author: Katrin Fischer Date: Sat Mar 28 01:05:14 2020 +0100 Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options There are some ocurrences of "Call Number" in the sort option lists in staff and OPAC. The patch changes them to "Call number". To test: - Check the sort option list in staff and OPAC for the typo - Apply patch - Verify it's now all corrected Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b85e53dccb76e2a462255b01c6e37f2f040b7ff2) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/resort_form.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/includes/resort_form.inc | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 21:58:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 19:58:52 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-7-g4dd3e83b6e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 4dd3e83b6e556f2ea1e8cb0d4e928b68b48e0d28 (commit) from 8c81690d449ae0c68c71e65cb770f77a2eb60444 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4dd3e83b6e556f2ea1e8cb0d4e928b68b48e0d28 Author: Katrin Fischer Date: Sat Mar 28 00:54:21 2020 +0100 Bug 25013: Fix capitalization: Edit Items on batch item edit Fixes a tiny string issue: Edit Items --> Edit items To test: - Go to tools / batch item edit - Enter a barcode - Check the heading above the edit item form - Apply patch - Verify the heading is now properly capitalized Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b3ecfd686d5190c937415558497024819992e8d5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 22:03:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 20:03:07 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-8-g13f62df3f5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 13f62df3f555387ca1a7c6886c30362744c1b79f (commit) from 4dd3e83b6e556f2ea1e8cb0d4e928b68b48e0d28 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 13f62df3f555387ca1a7c6886c30362744c1b79f Author: Katrin Fischer Date: Sat Mar 28 00:46:55 2020 +0100 Bug 25012: Fix class on OPAC view link in staff detail page Probably a copy & paste error: the OPAC view link on the staff detail page currently has the class succeeding_entry_note. This patch changes it to opac_view to allow for independent styling of the link. Note: The link will only be visible when OPACBaseURL is set. To test: - Use the element inspector or check the source code for the class used on the OPAC view link on the staff detail page - Apply patch - Repeat and verify that the class has changed to opac_view Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit f11299f9c04e6223507f0b4914b3191b60d5845e) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 22:12:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 20:12:06 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-9-g05399b5fdd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 05399b5fdd8988a4d16960aa5f9e3e082e249025 (commit) from 13f62df3f555387ca1a7c6886c30362744c1b79f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 05399b5fdd8988a4d16960aa5f9e3e082e249025 Author: Katrin Fischer Date: Thu Mar 26 22:30:52 2020 +0000 Bug 17938: Fix display of label for repeated MARC 583 - Action note fields When there are mulitple 583 on a record, the label "Action note" will be repeated for each. This fixes it, so that the label only appears once and multiple fields are separated by | following the existing pattern. Also makes sure there is a space between $z and other subfields. Note: Ind. 1 = private - These won't display in the OPAC Ind. 1 = 0 or empty - These will display in the OPAC Staff will display all 583 independent from indicator. To test: - Add one or more records with none, one and muliple 583, at least one including $z For examples see: http://www.loc.gov/marc/bibliographic/bd583.html - Verify display problems - Apply patch - Verify display is improved - one label and $z is followed by a space Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d35bcd9bb8890b8ad2121e21e5e4f44adf571b3e) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 37 +++++++++++----------- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 29 ++++++++--------- 2 files changed, 32 insertions(+), 34 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 22:15:31 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 20:15:31 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-10-gbfd709df69 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via bfd709df691fc5f774683282dc6f78ab8318fb46 (commit) from 05399b5fdd8988a4d16960aa5f9e3e082e249025 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bfd709df691fc5f774683282dc6f78ab8318fb46 Author: Owen Leonard Date: Tue Mar 31 14:20:23 2020 +0000 Bug 25022: Display problem in authority editor with repeatable field This patch corrects an error in the structure of the authority editor template so that repeating subfields do not generate invalid markup. The correction was found by comparing with addbiblio.tt. If you are viewing the diff, please note that some minor whitespace changes have been made. To reproduce, clone and and populate any repeatable subfield, save, and open the authority for editing again. The clones subfield will be formatting incorrectly, showing bullet points on each line. To test, apply the patch and reload the authority editor showing the record with the cloned subfield. It should display correctly. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 276e271ef4ec7c6d5196a3214663996b4cd289db) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/authorities/authorities.tt | 25 ++++++++++------------ 1 file changed, 11 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 23:02:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 21:02:18 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-167-ga2beeb8da9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a2beeb8da9dbfb85e3314f56f642599419dff5e1 (commit) via d14e25b57ed68637517da323d28108d5ea5b247b (commit) via 9be2c20c461382ebb6ebed0482b16f3d066c2ea0 (commit) via 8b2864b6c0c54ebcf86cd51129703ee8d482fbd3 (commit) via f46d88125d48fa21893f77f14584320dc3548a64 (commit) via b4c06e171730e1ed5d9b317670f25f01744cf742 (commit) via e49ecdedd87d8796da77adeaa9e864c43ca90763 (commit) via f5c7e3fd76f3d08b7b7ed2090f4d822bd3f2e3de (commit) via 7202498771468b9263474e1255039e3845da64c0 (commit) via 1adb28bc23b11e4c11b97f0524b829e840c70a74 (commit) via 1973003eaafd4cc7f7040cc66f946751eb2bacc3 (commit) from fa246075155d6a64cab51f78ccba2ad4ce8108a8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a2beeb8da9dbfb85e3314f56f642599419dff5e1 Author: Didier Gautheron Date: Thu Feb 27 10:51:19 2020 +0100 Bug 24740: Use biblio title rather than biblio number in OPAC search result cover images tooltips In OPAC biblionum doesn't mean much to patrons, use biblio title field if not empty. Test plan: OPAC search 1) Apply the patch 2) For each cover images providers available to tester in: /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=Cover OPACLocalCoverImages, AdlibrisEnabled, OPACAmazonCoverImages, GoogleJackets, Coce provider. 3) Enable the provider. 4) Search a Library Catalog for a book with a cover image. 6) test mouse over cover image display biblio title. OPAC Shelves 1) Enable OPAC virtualshelves preference 2) Create a list. 3) For each covers providers available. 4) Search the List 5) test mouse over cover image display biblio title. Signed-off-by: Stina Hallin Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d14e25b57ed68637517da323d28108d5ea5b247b Author: Lucas Gass Date: Fri May 1 17:01:11 2020 +0000 Bug 25341: Remove whitespace from barcode in add_items.pl TEST PLAN: 1. Go to course reserves and trying adding a course with a barcode that has some leading/trailing whitespace. 2. It doesnt work 3. Apply patch and restart_all 4. Try again with leading/trailing whitespace, it should work. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 9be2c20c461382ebb6ebed0482b16f3d066c2ea0 Author: Owen Leonard Date: Fri May 1 13:23:12 2020 +0000 Bug 24522: Show alert when trying to add nothing to a list in staff This patch modifies the JavaScript which handles the process of adding items to a list in the staff client. Error-handling is added in the case when a set of biblionumbers hasn't been passed to the vShelf function. To test, apply the patch and perform a catalog search in the staff client. On the search results page, select any list from the "Add to list" menu at the top of the search results table without checking any checkboxes. You should get an alert, "No item was selected." Also test that adding to a list works correctly after selecting one or more titles. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8b2864b6c0c54ebcf86cd51129703ee8d482fbd3 Author: Owen Leonard Date: Fri May 1 12:43:40 2020 +0000 Bug 25340: Pass biblio object to OPAC comments template This patch modifies the OPAC comments system so that the biblio object is passed to the template. This allows the biblio-title include to properly access the title and subtitle information. Unrelated change: Remove some custom CSS from the page which was obsolete. To test, apply the patch and make sure the "reviewson" preference is enabled. - Log in to the OPAC and open a bibliographic record's detail page. - Under the "Comments" tab, click the "Post your comments" link to trigger the pop-up window. - In the pop-up window, verify that the item's title is correct in the page title and the heading. Author should display correctly, if present. - Test submitting a comment and editing a comment. Everything should work correctly. Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit f46d88125d48fa21893f77f14584320dc3548a64 Author: Bernardo Gonzalez Kriegel Date: Sun May 3 19:19:21 2020 -0300 Bug 24636: (follow-up) - move 'by' into include file To ease correct translation. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b4c06e171730e1ed5d9b317670f25f01744cf742 Author: Bernardo Gonzalez Kriegel Date: Tue Apr 28 21:21:09 2020 -0300 Bug 24636: translate planning sections This patch adds a new inc file to process and translate plannig sections To test: 1) Apply patch 2) Create new language files (cd misc/translator; ./translate create xx-YY) 3) Verify new file is taken into account in translation files egrep -n budget_planning misc/translator/xx-YY*.po check new strings in staff-prog file 4) Go to Administration > Budgets > Founds > Planning select different options, check page title and 'Planning for...' phrase 5) Translate strings, install new language, enable it, verify the text change with options like point 4) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e49ecdedd87d8796da77adeaa9e864c43ca90763 Author: Andrew Fuerste-Henry Date: Thu Apr 30 19:35:51 2020 +0000 Bug 25335: group by authorised_value in addbiblio.pl To Test: 1- Edit your default framework, connect any subfield outside of the 952 to an authorised value (for example, connect the 942$n to the Yes_No auth value) 2 - Find a record in that framework 3 - Edit the record and find your subfield 4 - The subfield shows a dropdown with no contents 5 - check plack log, see "DBD::mysql::st execute failed: 'koha_kohadev.authorised_values.authorised_value' isn't in GROUP BY " 6 - apply patch, restart all 7 - reload edit record page, see your auth value dropdown has contents Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit f5c7e3fd76f3d08b7b7ed2090f4d822bd3f2e3de Author: Nick Clemens Date: Mon May 4 11:33:11 2020 +0000 Bug 25133: (follow-up) Move changes to timepicker.inc Witht the changes in calendar.inc there can be a js error where the timepicker is not included. Moving the changes to timepicker.inc should resolve this Note: in previous patches the amnames/pmnames were removed. It is possible they had no effect because they were declared in two files, so I have left them in timepicker.inc Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 7202498771468b9263474e1255039e3845da64c0 Author: Nick Clemens Date: Tue Apr 21 12:06:09 2020 +0000 Bug 25133: (follow-up) Remove Names as they do no affect display In testing I couldn't make any changes to the names have an effect and everythign worked as expected without these lines Signed-off-by: Nick Clemens Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1adb28bc23b11e4c11b97f0524b829e840c70a74 Author: Jonathan Druart Date: Mon Apr 20 10:59:55 2020 +0200 Bug 25133: Handle 12hr format for dt_from_string Signed-off-by: Nick Clemens Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1973003eaafd4cc7f7040cc66f946751eb2bacc3 Author: Jonathan Druart Date: Fri Apr 17 12:11:25 2020 +0200 Bug 25133: Fix time part of due date for 12hr With Timeformat system preference set to 12 hours format: Prior to 19.05.08, when due date was specified at checkout, the time in the box would show in 24hr format (e.g. 15:59) while the due date in the patron's checkouts would show in 12hr format (e.g. 3:59 PM). After 19.05.08, the format in the specify a due date box shows in 24hr format and the due date in 12hr format (in patron checkouts) as before. But when checking out multiple items using the specify due date option for the session, the time changes from PM to AM. To test: - Check out an item with specified due date 15:50 PM - Check out a second item in same transaction - Verify date changed to AM - Apply patch - Repeat - Verify this time the date is kept as set Signed-off-by: Nick Clemens Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/DateUtils.pm | 9 +++++++++ cataloguing/addbiblio.pl | 2 +- circ/circulation.pl | 2 +- course_reserves/add_items.pl | 2 ++ .../prog/en/includes/budget_planning.inc | 7 +++++++ .../intranet-tmpl/prog/en/includes/timepicker.inc | 1 + .../intranet-tmpl/prog/en/modules/admin/aqplan.tt | 5 +++-- .../intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/basket.js | 2 ++ .../opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 12 +++++++++--- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 14 ++++++++++---- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 19 ++++++++++++------- .../opac-tmpl/bootstrap/en/modules/opac-review.tt | 11 ++++------- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 18 ++++++++++++------ opac/opac-review.pl | 3 +-- t/DateUtils.t | 13 ++++++++++++- 16 files changed, 87 insertions(+), 35 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/budget_planning.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 23:30:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 21:30:20 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-15-g47d1ee2666 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 47d1ee26667c4003d8ae1a2b1ad9d2e38064a6e5 (commit) via dbd9d8a6b6a17400aa14323cd350131e2ae7b229 (commit) via 188bab98c8547021e2425df8e7575a25de9f9592 (commit) via 6cb9931864bcd17d216ec5de39ea11ac7c2a096e (commit) via da20e30b9ce059667ac208b5b2cb80a321cf3cc9 (commit) from bfd709df691fc5f774683282dc6f78ab8318fb46 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 47d1ee26667c4003d8ae1a2b1ad9d2e38064a6e5 Author: Jonathan Druart Date: Mon Apr 6 11:44:18 2020 +0200 Bug 24964: [19.11.x] Do not fetch all patrons for owner/users of funds admin/add_user_search.pl sets 'patrons_with_acq_perm_only', to only retrieve patrons with acq (order_manage) permissions. The original bug was hidden in the existing code, but the behavior was terrible. To prevent patrons matching the permissions contrainst to be hidden, we fetched ALL the patrons from the DB, then filtered them depending on their permissions. This might have awful performance on DB with lot of patrons. So basically with this patch we are adding the pagination back to the "owner/users for funds" feature, as the permission filtering is now done at DB level. Signed-off-by: Joy Nelson (cherry picked from commit 300dbea81219245614d95599c7cd98c51a005242) Signed-off-by: Lucas Gass commit dbd9d8a6b6a17400aa14323cd350131e2ae7b229 Author: Kyle M Hall Date: Thu Mar 26 08:53:59 2020 -0400 Bug 24964: [19.11.x] Fix perl critic warning Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson (cherry picked from commit 96956fee2440f20a112bc1413253d6043ada704f) Signed-off-by: Lucas Gass commit 188bab98c8547021e2425df8e7575a25de9f9592 Author: Jonathan Druart Date: Wed Mar 25 13:50:45 2020 +0100 Bug 24964: [19.11.x] Prevent random failures sorting by borrowernumber Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson (cherry picked from commit 6c962a7d5af5117fc7f858b2a78ddb818b679397) Signed-off-by: Lucas Gass commit 6cb9931864bcd17d216ec5de39ea11ac7c2a096e Author: Jonathan Druart Date: Wed Mar 25 11:21:15 2020 +0100 Bug 24964: [19.11.x] Do not filter patrons after they have been fetched The svc/members/search script is called in different places. In some places (Set owner for a fund, add users to a fund, or set a manager to a suggestion), we need patrons to be filtered depending on the permissions they have. For instance you can only set a fund's owner with a patron that has acquisition.order_manage. Currently we have fetching X (default 20) patrons, then filter them depending on their permission. Says you have 3 patrons that have the correct permissions but are not in the 20 first patrons, if you do not define a search term, the search result will be empty. This is not ideal and we should filter when requesting the DB. Test plan: - Have more than 20 patrons, remove them their permissions - Create 3 more: 1 superlibrarian 1 with the full acq permission 1 with acquisition.order_manage - Create a fund and set a owner - Search for patrons, without specifying a search term (to get them all) => Without this patch the new patrons you created are not displayed => With this patch they are! Same test plan apply to set a manager to a suggestion (freshly pushed, see bug 23590), with suggestions and suggestions.suggestions_manage Note: The code has been written that way to rely on C4::Auth::haspermission, but the SQL query is quite trivial and the gain is important. Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson (cherry picked from commit 62b6e283a2c72d5e8c7f7f9a048df44fba2de8c3) Signed-off-by: Lucas Gass commit da20e30b9ce059667ac208b5b2cb80a321cf3cc9 Author: Jonathan Druart Date: Wed Mar 25 11:20:20 2020 +0100 Bug 24964: [19.11.x] Add tests Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson (cherry picked from commit b3d97ce0294bebd89c65830b1851cea5d936f0c4) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 43 +++++++++++--- .../prog/en/modules/common/patron_search.tt | 8 +-- svc/members/search | 30 ++-------- t/db_dependent/Utils/Datatables_Members.t | 68 ++++++++++++++++++++-- 4 files changed, 106 insertions(+), 43 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 23:34:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 21:34:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-16-g0ba79c681b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0ba79c681b0f29b6603191e37ffa71e20b0f7527 (commit) from 47d1ee26667c4003d8ae1a2b1ad9d2e38064a6e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0ba79c681b0f29b6603191e37ffa71e20b0f7527 Author: Nick Clemens Date: Mon Mar 30 15:16:36 2020 +0000 Bug 23601: Prevent default for auxclick The issue appears to be that the default action is not prevented for middle click because it registers an 'auxclick' event as opposed to a 'click' event To test: 1 - Perform a search in staff client 2 - Shift-click and hold on a result 3 - Note a new tab opens 4 - Release the click, no change 5 - Middle click and hold on a result 6 - New tab opens 7 - Release, a second new tab opens 8 - Apply patch 9 - Reload page 10 - Middle click and hold 11 - New tab opens 12 - Release 13 - No new tab Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 9f89eabcd5befe34d4b3ad75fb8b128f4de131f3) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/js/browser.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 23:39:19 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 21:39:19 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-18-g938c788b91 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 938c788b911255724e39b71df6503a4f65b9b1d3 (commit) via d9a4c2a343a7af234bb867cac73fb1389ce3b070 (commit) from 0ba79c681b0f29b6603191e37ffa71e20b0f7527 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 938c788b911255724e39b71df6503a4f65b9b1d3 Author: Jonathan Druart Date: Wed Apr 1 10:58:28 2020 +0200 Bug 25024: Do not escape $ Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a51e18d746526897abcc6e7b9e16b0937d332ad6) Signed-off-by: Lucas Gass commit d9a4c2a343a7af234bb867cac73fb1389ce3b070 Author: Nick Clemens Date: Tue Mar 31 13:55:21 2020 +0000 Bug 25024: Make grep match full string To test: 1 - Create or have a branch with code CPL 2 - Create two new branches 'ACPL' and 'CPLA' 3 - In branch transfer limits disallow some itype or collection from another branch (FPL) to ACPL and CPLA 4 - Set UseBranchTransferLimits to 'Enforce' 5 - Find a biblio with one item belonging to FPL 6 - On opac, attempt to place a hold 7 - Note that ACPL and CPLA don't show in dropdown, OK 8 - Note that CPL is disabled, NOT OK 9 - Apply patch 10 - Place hold 11 - CPL is now enabled Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Joel Sasse Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 155b47d2fee0440cc743a09d5c6a2152abb97d16) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 23:47:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 21:47:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-19-ga43184de5e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a43184de5e1a048476297541d3adacc14faf4160 (commit) from 938c788b911255724e39b71df6503a4f65b9b1d3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a43184de5e1a048476297541d3adacc14faf4160 Author: Julian Maurice Date: Thu Feb 6 16:15:43 2020 +0100 Bug 24604: Add 'Pay' button under Transactions tab in patron accounting It does the same thing as the 'Pay' button under 'Make a payment' tab. It is nothing more than a shortcut. Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 4ed413a76a32c52db71aae5efc2d3edf1949cc2c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 23:50:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 21:50:49 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-172-ga0ee80a303 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a0ee80a3038dc275b99ae781530f483c2fb425ad (commit) via e98dc9494a1bf0307084c5d11bdfb25d49d0b131 (commit) via 8a8130c0524efd4c211155cecce78392a76804f6 (commit) via 09e8d7885ccadbc8dba50ddf0b841c98f92df56d (commit) via d816e371ecba064f6e9418439a40d160f01aa924 (commit) from a2beeb8da9dbfb85e3314f56f642599419dff5e1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a0ee80a3038dc275b99ae781530f483c2fb425ad Author: Katrin Fischer Date: Sat Apr 11 14:09:27 2020 +0000 Bug 15727: Add MARC21 385 - Audience to detail pages This add 385$m$a to the staff and intranet detail pages. To test: - Catalog different variations of 385 and verify the display in the OPAC and staff client is ok Examples can be found in the LOC MARC21 documentation: http://www.loc.gov/marc/bibliographic/bd385.html Signed-off-by: Stina Hallin Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e98dc9494a1bf0307084c5d11bdfb25d49d0b131 Author: Katrin Fischer Date: Mon Apr 13 04:42:37 2020 +0200 Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql The description on STATUS was incomplete, missing 2 status and the SUGGEST_STATUS category. To test: - Later this will show up in schema.koha-community.org, but for now it can only be verified reading the patch. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8a8130c0524efd4c211155cecce78392a76804f6 Author: Katrin Fischer Date: Sun Apr 19 13:39:08 2020 +0200 Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files It looks like RewriteLog will no longer work with Apache 2.4 and later. RewriteLog Those familiar with earlier versions of mod_rewrite will no doubt be looking for the RewriteLog and RewriteLogLevel directives. This functionality has been completely replaced by the new per-module logging configuration mentioned above. http://httpd.apache.org/docs/current/mod/mod_rewrite.html All lines removed were commented out, so there should be no change in behaviour or side effects. To test. - Verify every mention of RewriteLog has been removed from Koha - Verify patch by reading it Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 09e8d7885ccadbc8dba50ddf0b841c98f92df56d Author: Katrin Fischer Date: Sat May 2 04:29:11 2020 +0200 Bug 24995: (QA follow-up) Terminology: Use checkin and checkout ... instead of issue and return. Signed-off-by: Katrin Fischer Signed-off-by: Joy Nelson commit d816e371ecba064f6e9418439a40d160f01aa924 Author: Lucas Gass Date: Thu Mar 26 21:17:42 2020 +0000 Bug 24995: Add issuedate to table_account_fines and finest TO TEST: 1. Have a patron with some fines on an item. Try accruing fines. 2. Go to the accounting tab and look at both the Tranaction tab and Make a payment Tab 3. No Issue Date 4. Apply patch 5. Check those tabs again and see the issue date displays. 6. Go to column configuration and try to hide the issuedate, make sure it hides properly. Try this for both tables. Also make sure other columns hide properly. 7. Sign off! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: admin/columns_settings.yml | 4 ++++ debian/templates/apache-site-https.conf.in | 2 -- debian/templates/apache-site.conf.in | 2 -- etc/koha-httpd.conf | 8 ------- installer/data/mysql/kohastructure.sql | 2 +- .../prog/en/modules/members/boraccount.tt | 8 ++++--- .../intranet-tmpl/prog/en/modules/members/pay.tt | 14 +++++++---- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 27 +++++++++++++++++++++ .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 28 +++++++++++++++++++++- 9 files changed, 74 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 11 23:56:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 21:56:17 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-21-g0f293662c3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0f293662c37f76408ac2c4b952c6160dbdb9f014 (commit) via 70447d05deb6cd688d76aaf0f865ea8a8642ff15 (commit) from a43184de5e1a048476297541d3adacc14faf4160 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0f293662c37f76408ac2c4b952c6160dbdb9f014 Author: Lucas Gass Date: Mon May 11 21:27:29 2020 +0000 Bug 20754: DBRev 19.05.11.001 Signed-off-by: Lucas Gass commit 70447d05deb6cd688d76aaf0f865ea8a8642ff15 Author: Marcel de Rooy Date: Fri May 4 10:42:38 2018 +0200 Bug 20754: DB revision to remove double accepted shares [Originally submitted for bug 11943, parked at 20754.] [Attempt to revive it now.] Although it is no problem to have them, we could do a cleanup. This patch just removes duplicate rows from the table. Note: I considered adding a unique index like: ALTER TABLE virtualshelfshares ADD UNIQUE INDEX (shelfnumber, borrowernumber, invitekey); But the possible NULL values in borrowernumber and/or invitekey require additional code changes. So I left it alone. Test plan: [1] Create two records with same borrowernumber and shelfnumber in the shares table, if not present already. [2] Run updatedatabase.pl Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ba3bed7afe84b9e5278bed0aa12d71bfc82b4c9d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 00:02:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 22:02:59 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-22-g4484b7d4d9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 4484b7d4d96e980a445c687398a363817f4f907c (commit) from 0f293662c37f76408ac2c4b952c6160dbdb9f014 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4484b7d4d96e980a445c687398a363817f4f907c Author: Tomas Cohen Arazi Date: Mon Mar 30 09:39:13 2020 -0300 Bug 25019: Make the ViewPolicy filter initialization standard This patch makes the ViewPolicy filter use the 'params' accessor instead of relying of ->{options} which has no accessor. This will allow interacting with the filter object be similar through all the filters in the chain. To test, we just need to verify no behaviour change takes place: 1. Run: $ kshell k$ prove t/db_dependent/Filter_MARC_ViewPolicy.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit e6c829d887b8b6aeda98a7ba57dc9ac04b79a7a3) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Filter/MARC/ViewPolicy.pm | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 00:12:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 22:12:26 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-23-g4d98f19541 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 4d98f19541bef0e075c5c3d6b2709baa40d1aa60 (commit) from 4484b7d4d96e980a445c687398a363817f4f907c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4d98f19541bef0e075c5c3d6b2709baa40d1aa60 Author: David Roberts Date: Fri Apr 3 15:23:01 2020 +0000 Bug 24940: Serials statistics wizard: order vendor list alphabetically This patch changes the dropdown from being sorted by aqbookseller.id to aqbookseller.name To test: 1) Add at least 2 vendors: - First: ZZZZ - Second: AAAA 2) Add subscriptions for each of the vendors 3) Check the pull down in the serials statistics wizard and verify it lists them as ZZZZ, AAAA 4) Apply the patch 5) Re-check the pull down in the wizard and check that the vendors are now listed AAAA,ZZZZ Signed-off-by: Devinim Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ef8f3870b41032e1ae388baaeb8f13565a08dfaf) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: reports/serials_stats.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 00:15:48 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 22:15:48 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-24-g6ae8f92f35 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 6ae8f92f35f844c057254d7bac7254aee157e960 (commit) from 4d98f19541bef0e075c5c3d6b2709baa40d1aa60 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6ae8f92f35f844c057254d7bac7254aee157e960 Author: Jonathan Druart Date: Wed Mar 11 16:21:06 2020 +0100 Bug 24826: Remove warnings from Sendmail Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit cf649efd7251243bc824bab542285ba17adafacb) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Email.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 00:25:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 22:25:06 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-176-g75e7861df4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 75e7861df4834d7172b55552d1b7a03d3ab3b537 (commit) via 8048acf2255034bac433c654e66597e8da24ee99 (commit) via bb3893720d55100380bf431cf6aea8a044a9bd04 (commit) via aa9a4fc3f64787e536faabd4b49be76d1e8144f1 (commit) from a0ee80a3038dc275b99ae781530f483c2fb425ad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 75e7861df4834d7172b55552d1b7a03d3ab3b537 Author: Joy Nelson Date: Mon May 11 21:56:04 2020 +0000 Bug 25184: (follow-up) fix number of tests Signed-off-by: Joy Nelson commit 8048acf2255034bac433c654e66597e8da24ee99 Author: Joy Nelson Date: Mon May 11 21:52:39 2020 +0000 Bug 25184: DBRev 19.11.05.005 Signed-off-by: Joy Nelson commit bb3893720d55100380bf431cf6aea8a044a9bd04 Author: Kyle M Hall Date: Tue Apr 21 12:52:38 2020 -0400 Bug 25184: Add syspref It's entirely possible that some libraries are relying on the current before for part of their workflow. Do to this possibility, it seems like a good idea to control this behavior via a system preference. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Set TrapHoldsOnOrder to "don't trap" 4) Set an item's notforloan value to -1 5) Place a hold on that item 6) Check in the item 7) Note the item is not trapped for hold 9) Set TrapHoldsOnOrder to "trap" 10) Check in the item 11) Koha should now ask if you'd like to trap the item for the hold! Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit aa9a4fc3f64787e536faabd4b49be76d1e8144f1 Author: Kyle M Hall Date: Fri Apr 17 14:06:32 2020 -0400 Bug 25184: Items with a negative notforloan status should not be captured for holds Negative notforloan statuses should allow holds to be placed but not captured. Due to coronavirus, we have libraries setting all returned materials to a negative notforloan value of Quarantine for several days. They're using UpdateNotForLoanStatusOnCheckin to set that status automatically. However, those items are still capturing for holds, even though those items cannot be checked out until the notforloan status is removed. In cases like an On Order item where we do want the hold to fill at checkin, UpdateNotForLoanStatusOnCheckin should be used to clear that notforloan status so the hold can fill. In master, if I set an item to a not for loan but holdable status ( < 0 ) I can place the hold, capture the hold and set it to waiting, but *not* check it out to the patron! This does not make sense. I should not be able to trap an item for checkout unless it can be checked out. Test Plan: 1) Set an item's notforloan value to -1 2) Place a hold on that item 3) Check in the item 4) Trap the item for that hold 5) Attempt to check the item out to the patron, you will be unable to because it is notforloan 6) Apply this patch 7) Restart all the things! 8) Repeat steps 1-3 9) The screen should no longer ask if the item should be trapped to fill the hold! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Catherine Ingram Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 5 ++++- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 10 ++++++++++ .../en/modules/admin/preferences/circulation.pref | 6 ++++++ t/db_dependent/Holds.t | 23 +++++++++++++++++++++- 6 files changed, 44 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 00:32:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 22:32:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-26-g8c2788855a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8c2788855a4489d9ad0ff28f81ad48c9d19da9cf (commit) via fd531c242b7a74725a0bf21cf541a012470789ac (commit) from 6ae8f92f35f844c057254d7bac7254aee157e960 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8c2788855a4489d9ad0ff28f81ad48c9d19da9cf Author: Jonathan Druart Date: Wed Apr 8 11:28:31 2020 +0200 Bug 25046: Add test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit e370007f0e04945a82a1fa1af42bfc84ab8855b4) Signed-off-by: Lucas Gass commit fd531c242b7a74725a0bf21cf541a012470789ac Author: Andreas Roussos Date: Thu Apr 2 19:14:57 2020 +0200 Bug 25046: Include borrowers.othernames in SELECT statement In C4/Utils/DataTables/Members.pm, the SELECT statement that fetches patron data from the database does not include borrowers.othernames in the field list. As a consequence, when the output is in the form of a DataTable, the Template Toolkit files that refer to .othernames (such as the patron-title.inc include) won't display the information from the 'Other name' input field if that field has been filled in. This patch fixes that. Test plan: 0) Have a few patrons with some data in the 'Other name' field. 1) Perform a generic search in Home > Patrons to ensure you will get a DataTable with results. 2) Observe that the 'Name' column does not include 'Other name' info. 3) Apply the patch, and restart Plack if necessary. 4) Repeat your search: this time you should see the information from the 'Other name' field, it will be next to the patron's First name and within parentheses. Sponsored-by: Eugenides Foundation Library Signed-off-by: Devinim Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5b10df8bf77c8e7148caf042221d2ecd946742fa) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 1 + t/db_dependent/Utils/Datatables_Members.t | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 00:33:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 22:33:37 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-27-g0cc2ba3827 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0cc2ba382747b6fe20f4599895384041d9092c38 (commit) from 8c2788855a4489d9ad0ff28f81ad48c9d19da9cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0cc2ba382747b6fe20f4599895384041d9092c38 Author: Kyle M Hall Date: Fri Mar 27 12:01:05 2020 -0400 Bug 22937: Add hint to groups editor Signed-off-by: Lisette Scheer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit 56c629d969b0de56f1202799d7ab11705fc39d90) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 00:35:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 22:35:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-182-g629d9dc21e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 629d9dc21e0df630c71eb53a219b01be72d3cf3d (commit) via 96202ca7bb533ddf6bcb1c8486b8ae5a9591f1a1 (commit) via b48282ba825870f11c10edc7aee44f4b0db52435 (commit) via 34c07a58f8cdbe9a4c36b93b7c680837499f3018 (commit) via e5372db43e8094fc491b861db7defb8e36e6b7db (commit) via a53d63e0f7720321715e75be1147d8ea4df9a3aa (commit) from 75e7861df4834d7172b55552d1b7a03d3ab3b537 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 629d9dc21e0df630c71eb53a219b01be72d3cf3d Author: Owen Leonard Date: Thu May 7 14:57:25 2020 +0000 Bug 25343: Use of item in review/comment feature is misleading This patch updates the terminology associated with leaving a comment in the OPAC. the word "item" is replaced with the more specific "title." To test, apply the patch and make sure the reviewson system preference is enabled. - Log in to the OPAC and view a bibliographic record which has no comments. - Under the "comments" tab, verify that the text in the tab says "There are no comments on this title. Post your comments on this title." Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 96202ca7bb533ddf6bcb1c8486b8ae5a9591f1a1 Author: George Veranis Date: Wed Apr 22 11:43:53 2020 +0200 Bug 19312: Fix typo in template This patch fixes a simple typo Test plan: 1) Go to Administration -> MARC bibliographic framework 2) Select a framework and add plugin unimarc_field_121a.pl to 121 field 3) Open cataloguing screen 4) Go to 121 field and check if for subfield a shows two times the value 2-dimensional 5) Apply the patch 6) Go to 121 field again and check if it shows 2 different values Mentored-by: Andreas Roussos Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b48282ba825870f11c10edc7aee44f4b0db52435 Author: David Roberts Date: Thu May 7 18:07:21 2020 +0000 Bug 25388: There is no link for the "online help" This patch removes a non-existent link to the online help from the marc subfield editor. To test: 1) Go to Admin > MARC Bibliographic framework > Edit MARC structure > Edit subfield (for example /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=000&frameworkcode=AR) 2) Check that the Max Length value in the Advanced constraints area contains text saying "See online help" 3) Apply patch 4) Check that the reference to the online help has disappeared. Remove tabs from start of line Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 34c07a58f8cdbe9a4c36b93b7c680837499f3018 Author: Nicolas Legrand Date: Thu Apr 9 16:50:55 2020 +0200 Bug 25099: Sending a LANG variable to plug-in template To make internationalised plug-ins, it may be useful to get the lang from C4::Languages::getlanguage. This patch adds C4::Languages::getlanguage result to a LANG variable which is sent to the template plugin. In your plugin, you can add a i18n directory containing lang[-DIALECT].inc files with a TOKENS hash like this: [% TOKENS = { PLUGIN_NAME = "Mannequin" PRESENTATION = "Voici un example d'outil." CLICK_ME = "Cliquez moi !" } %] The plugin template can then include such a lang[-DIALECT].inc with a hash containing all the plugin strings: [% TRY %] [% PROCESS "$PLUGIN_DIR/i18n/${LANG}.inc" %] [% CATCH %] [% PROCESS "$PLUGIN_DIR/i18n/default.inc" %] [% END %] The strings are then printed in the template with something like: [% TOKENS.PRESENTATION %] Test plan: 1. apply patch 2. install, enable and run BULAC Mannequin plugin 3. it should print stuff in english by default 4. install french French (fr-FR) 5. change you Koha lang to French 6. run again the plugin 7. ho là là! French! Thanks to Tomàs Cohen and his pay via paypal plug-in from which most ideas in this patch are taken. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e5372db43e8094fc491b861db7defb8e36e6b7db Author: Katrin Fischer Date: Tue May 5 11:43:39 2020 +0000 Bug 25082: Don't remove characters from string At the moment, show-lang-041 will either get a code or an AV description to deal with. If it's a description, we don't want to remove spaces and other chars from it. To test: - Repeat tests from first patch with an AV in LANG category that consists of multiple words, has a - and other possible punctuation. - The description should show correctly in OPAC and staff. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit a53d63e0f7720321715e75be1147d8ea4df9a3aa Author: Katrin Fischer Date: Sun Apr 12 16:30:05 2020 +0000 Bug 25082: Make 041 descriptions display, if authorised value list is used When 041$a or another subfield is linked to an authorised value list, Koha will replace the codes with the descriptions from the authorised value in the MARCXML before passing it to the XSLT. The XSLT was made to translate codes into descriptions - as there is no code now, this fails and 'unknown language' is shown. The patch changes the handling so that when the XSLT is handled something that doesn't match a known code, it displays the subfield without processing. To test: - Create some records with 041. Examples: http://www.loc.gov/marc/bibliographic/bd041.html - Verify this displays nicely in staff and OPAC - Apply patch - Verify display is unchanged - Remove the patch - Change one of your MARC frameworks (use another framework than for your first test records) and link the 041 subfields to the LANG authorised value list - Go to administration and create some entries for LANG with language codes and descriptions - Catalog a 041 using the normal editor (not advanced) - You can now use a pull down to select the values you want - Verify the display is now 'Unknown language' for this record - Apply patch - Verify all records display the language descriptions now, using an authorised value or not - Run misc/maintenance/generate_MARC21Languages.pl Verify the output at the end reads like: Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/Plugins/Base.pm | 2 +- .../intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt | 2 +- .../prog/en/modules/cataloguing/value_builder/unimarc_field_121a.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21Languages.xsl | 3 ++- koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21Languages.xsl | 3 ++- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl | 4 ++-- misc/maintenance/generate_MARC21Languages.pl | 3 ++- 9 files changed, 16 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 00:56:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 22:56:33 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-28-g0bbaf0d1e6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0bbaf0d1e67d343beba5b043408c488db30db8bd (commit) from 0cc2ba382747b6fe20f4599895384041d9092c38 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0bbaf0d1e67d343beba5b043408c488db30db8bd Author: Theodoros Theodoropoulos Date: Wed Apr 8 08:21:12 2020 +0100 Bug 23514: Split Call Numbers for all layout types This patch ensures call numbers are properly split for layout types other than 'BAR'. Test plan: 1. Go to Label Creator and choose/create a Label Layout with "Choose layout type: Biblio" 2. make sure you have at least "itemcallnumber" in Bibliographic data to print/Data fields 3. check "Split call numbers" box and save the layout (ie testlayout) 4. create a label batch, using items that have a call number (ie DC611.B848 H84 1997). LCC is used here, but you may try with Dewey as well. 5. export selected batch using any template and the layout you created in previous step to a PDF 6. Call numbers are splitted (as expected) in the resulting PDF file 7. edit the layout you created in the previous step (ie testlayout) and change the "Choose layout type:" to either Biblio/Barcode (BIBBAR) or Barcode/Biblio (BARBIB) 8. export the same batch using the same template and layout as before 9. Call numbers are NOT splitted at all After patch is applied, call numbers splitting functions are applied even in Biblio/Barcode (BIBBAR) or Barcode/Biblio (BARBIB) layout types. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit ef9f3adbddbffdf0f734e68e11a0c0424d6ec975) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Labels/Label.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 01:08:02 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 11 May 2020 23:08:02 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-185-g854c71df79 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 854c71df7914b1539e9c3af8b65096d607ea5595 (commit) via 7560c4581331a6a09f023df38cf04e4e8b4d5b2c (commit) via 4bc3fe1c72602c6e3886725836558af8f7b370f2 (commit) from 629d9dc21e0df630c71eb53a219b01be72d3cf3d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 854c71df7914b1539e9c3af8b65096d607ea5595 Author: David Roberts Date: Mon May 4 19:43:32 2020 +0000 Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) The patch adds the suggestion management reason to the display when viewing a suggestion. To test: 1) Edit a suggestion and assign a reason for accepting it. 2) View the suggestion (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=XX&op=show, replacing XX with your suggestion ID) 3) Under suggestion management, the reason you've just assigned does not display. 4) Apply the patch 5) Check the display again - the Reason should now be visible directly under the status. Signed-off-by: Abbey Holt Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 7560c4581331a6a09f023df38cf04e4e8b4d5b2c Author: Grace McKenzie Date: Wed Jan 18 22:55:48 2017 +0000 Bug 17853: Don't remove () from 780 link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Felix Hemme Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: David Nind Bug 17853: Don't remove () from 785 link text and restore link value of 780 The only thing we change for 780 and 785 is, that if the display text contains (), they are no longer removed. To test: - Catalogue a record with 785$a some text (including) parenthesis e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Katrin Fischer Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 4bc3fe1c72602c6e3886725836558af8f7b370f2 Author: Jonathan Druart Date: Fri Apr 17 12:24:24 2020 +0200 Bug 25157: Silent patron deletion cmd line script Without -v the script will no longer display messages unless the error is major. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 6 ++++++ .../intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 8 ++++---- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 8 ++++---- misc/cronjobs/delete_patrons.pl | 9 +++++---- 4 files changed, 19 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 12:50:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 May 2020 10:50:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2155-g7dc2aa28b7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7dc2aa28b711fa1e488173e78bba2dd92e9c8237 (commit) via 18acb9a0d542d5b93cc85d25dd10cfb22e38bc3c (commit) via 643309499aeaafc7da33abf6c2c52b13ab9321bd (commit) via 6c95f7154856b03b53d620642417ca8179c12377 (commit) via f248063ee557af6d19afc17f4801213287e76b95 (commit) via 98c98df95500e7c899385926be466c5c88308fd3 (commit) via 5d26407e4d1b5a8d5b42c67c8649b55a2ecab9d4 (commit) via 12dfbe7f037dae1c4825de53932a10c29e7b3852 (commit) via 3f9fc43a71c92d5394955efce9e2108c83894f79 (commit) via cf0a6f48202d3a2c5170db2afb658c47bacce03f (commit) via d5fa69df93e5efda3d7ab87dbf90e822b006876c (commit) via eba7a32df59093b02a5f707b06f636a85be465f7 (commit) via 278df89bb5f86c8f7369405a8aa5d4a32b739643 (commit) via 891307f29be27113475b1605a558799ab9874c01 (commit) via 6b85d1b073bf2f29c9c604a627f15aff7aad12ab (commit) via 312efadd315fb8b0c1d2a952aab672f77f60672a (commit) via 6aeeae3e707d449403ad08914acfdb6b7a1e831f (commit) via 6f1e9fe75080b9a02c49730cbdb341cf09ca9826 (commit) via 1eae01fa14602c32f0e2de925b60b5f3a2b83db1 (commit) via 2a804074030ef02f58ba708db26192ff44fc61cd (commit) via 0b7590775792e9c5a05416104a35de3c9a6b20b5 (commit) via 851f433b77e6e62bd285e4e4671b11710271bab5 (commit) via 3aecd0afb0d543b6047d19154bb9f55c0f7c7bce (commit) via c9a032a8fc5ff312beae9ebfa84e642b9c3056e1 (commit) via 5b0e0f03c17dec4b7ee3f54798ff0c024e873806 (commit) via c79108e495951efca4824d458b3736deb4c79de9 (commit) from a57cc4645d38b80ec9a8846afcea2d27f22605b4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7dc2aa28b711fa1e488173e78bba2dd92e9c8237 Author: Martin Renvoize Date: Tue May 12 11:20:33 2020 +0100 Bug 24185: Add mentorship Mentored-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 18acb9a0d542d5b93cc85d25dd10cfb22e38bc3c Author: Martin Renvoize Date: Tue May 12 11:18:43 2020 +0100 Bug 24027: Add Mentorship lines Mentored-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 643309499aeaafc7da33abf6c2c52b13ab9321bd Author: Slava Shishkin Date: Sun May 10 18:15:09 2020 +0300 Bug 25409: Add missing "Required" text and "required" classes Highlight text with red by adding “required” class to the label and added red “Required” text next to select field in "onboardingstep5.tt" template. To test: 1) Start new installation. During onboarding tool phase you will be requested to create a new circulation rule. 2) Observe that "Units" label has no "required" class and that there’s no “Required” text next to a select field. 3) Apply patch. 4) Repeat step 2 (you can reload circulation rule creation page). 5) Observe the error is gone. Mentored-by: Peter Vashchuk Mentored-by: Andrew Nugged Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 6c95f7154856b03b53d620642417ca8179c12377 Author: Slava Shishkin Date: Thu May 7 14:24:31 2020 +0300 Bug 25409: Add missing "required" class to template Added "required" class to "itemtype" label in "onboardingstep5.tt" template. To test: 1) Start new instalation. During onboarding tool phase you will be requested to create a new circulation rule. 2) Observe that "itemtype" label has no "required" class. 3) Apply patch. 4) Repeat step 2 (you can reload circulation rule creation page). 5) Observe the error is gone. Mentored-by: Peter Vashchuk Mentored-by: Andrew Nugged Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit f248063ee557af6d19afc17f4801213287e76b95 Author: Martin Renvoize Date: Tue May 12 11:13:49 2020 +0100 Bug 25184: (RM follow-up) Make DB update idempotent Signed-off-by: Martin Renvoize commit 98c98df95500e7c899385926be466c5c88308fd3 Author: Nick Clemens Date: Mon May 11 17:08:35 2020 +0000 Bug 25418: (QA follow-up) Raise size of input box In twelve hour format the length of the string is 20 characters we need the box to fit all of them Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 5d26407e4d1b5a8d5b42c67c8649b55a2ecab9d4 Author: Jonathan Druart Date: Thu May 7 17:18:35 2020 +0200 Bug 25418: (bug 25133 follow-up) Display due date with hours And not as due date, it's not a display-only info, but an input. This patch is a follow-up of Bug 25133: Fix time part of due date for 12hr == Test plan == 1. create checkouts with the following params and results 2. tomorrow 11:59 PM timeformat syspref: 12h - item is due without a specific time, only date (after-checkout green box) 3. backdate 11:59 PM timeformat syspref: 12h - note the yellow confirm box has only the date - item is due at 12:00 PM (after-checkout green box) 4. tomorrow 11:23 AM timeformat syspref: 12h - item is due at 11:23 AM (after-checkout green box) 5. backdate 11:23 AM timeformat syspref: 12h - note the yellow confirm box has the date and time - item is due 11:23 AM (after-checkout green box) 6. tomorrow 23:59 timeformat syspref: 24h - item is due without a specific time, only date (after-checkout green box) 7. backdate 23:59 timeformat syspref: 24h - note the yellow confirm box has only the date - item is due at 00:00 (after-checkout green box) 8. tomorrow 11:23 timeformat syspref: 24h - item is due at 11:23 (after-checkout green box) 9. backdate 11:23 timeformat syspref: 24h - note the yellow confirm box has the date and time - item is due 11:23 (after-checkout green box) 10. apply patch 11. create checkouts with the following params and results 12. tomorrow 11:59 PM timeformat syspref: 12h - item is due without a specific time, only date (after-checkout green box) 13. backdate 11:59 PM timeformat syspref: 12h - note the yellow confirm box has the date and time - CHANGE COMPARED TO BEFORE THE PATCH - item is due without a specific time, only date (after-checkout green box) - CHANGE COMPARED TO BEFORE THE PATCH 14. tomorrow 11:23 AM timeformat syspref: 12h - item is due 11:23 AM (after-checkout green box) 15. backdate 11:23 AM timeformat syspref: 12h - note the yellow confirm box has the date and time - item is due 11:23 AM (after-checkout green box) 16. tomorrow 23:59 timeformat syspref: 24h - item is due without a specific time, only date (after-checkout green box) 17. backdate 23:59 timeformat syspref: 24h - note the yellow confirm box has the date and time - CHANGE COMPARED TO BEFORE THE PATCH - item is due without a specific time, only date (after-checkout green box) - CHANGE COMPARED TO BEFORE THE PATCH 18. tomorrow 11:23 timeformat syspref: 24h - item is due at 11:23 (after-checkout green box) 19. backdate 11:23 timeformat syspref: 24h - note the yellow confirm box has the date and time - item is due 11:23 (after-checkout green box) Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 12dfbe7f037dae1c4825de53932a10c29e7b3852 Author: Martin Renvoize Date: Tue May 12 11:11:38 2020 +0100 Bug 24378: DBRev 19.12.00.088 Signed-off-by: Martin Renvoize commit 3f9fc43a71c92d5394955efce9e2108c83894f79 Author: Jonathan Druart Date: Mon May 11 15:44:32 2020 +0200 Bug 24378: (QA follow-up) fix minor issues Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit cf0a6f48202d3a2c5170db2afb658c47bacce03f Author: Katrin Fischer Date: Sun May 10 17:06:17 2020 +0000 Bug 24378: (follow-up) Format due date as due date Changes the due date formatting as was already done for the new sample files on bug 23787. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit d5fa69df93e5efda3d7ab87dbf90e822b006876c Author: Katrin Fischer Date: Sat Apr 11 17:52:30 2020 +0000 Bug 24378: Database update to rewrite notice if left unchanged The database update makes the same changes as done by Andrew on the old database entry. We check for full sentences left unchanged to minimize issues with changes made by the library. Test plan of first patch applies. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit eba7a32df59093b02a5f707b06f636a85be465f7 Author: Andrew Fuerste-Henry Date: Wed Mar 11 00:15:58 2020 +0000 Bug 24378: Change wording of auto_renewals notice in updatedatabase On the template of AUTO-RENEWALS the wording is grammatically incorrect: [% IF checkout.auto_renew_error == 'too_many' %] You have reach the maximum of checkouts possible. This should say [% IF checkout.auto_renew_error == 'too_many' %] You have reached the maximum of checkouts possible. Test plan: - Make sure you have the AUTO_RENEWALS notice with the problematic spelling - install patch - update database - confirm changes to notice name and wording Signed-off-by: Katrin Fischer Kept Andrew's change on the original updatedatabase entry, but removed the database update to be done a little differently in a follow-up patch. Amended test plan. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 278df89bb5f86c8f7369405a8aa5d4a32b739643 Author: Marcel de Rooy Date: Fri May 8 06:46:59 2020 +0000 Bug 22437: (follow-up) Move deletion of merge requests to DelAuthority Lines can be moved. Deletion can be done too if skip_merge is not set. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 891307f29be27113475b1605a558799ab9874c01 Author: Marcel de Rooy Date: Fri Apr 3 08:55:45 2020 +0000 Bug 22437: Delete older merge requests at new merge time If you merge A to B, we should remove older AA merges (regular merge to itself) in the queue before deleting A. Test plan: [1] Set merge limit in prefs to say X. [2] Find three authorities A, B, C with linkcount >X, >X, Signed-off-by: Phil Ringnalda Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6b85d1b073bf2f29c9c604a627f15aff7aad12ab Author: Marcel de Rooy Date: Mon Apr 6 13:44:46 2020 +0000 Bug 22437: Add test case to Merge.t Test proves now that a 'destructive merge' is removed by DelAuthority. Test plan: Run t/db_dependent/Authority/Merge.t. Should fail when you do not apply the other two patches and pass with them. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 312efadd315fb8b0c1d2a952aab672f77f60672a Author: Jonathan Druart Date: Mon May 11 14:51:58 2020 +0200 Bug 25421: Update POD Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6aeeae3e707d449403ad08914acfdb6b7a1e831f Author: Tomas Cohen Arazi Date: Fri May 8 10:04:30 2020 -0300 Bug 25421: Remove use of Koha::Libraries->pickup_locations The current implementation uses Koha::Libraries->pickup_locations which is problematic and due to be removed by bug 24368. This patch makes the trivial change of just searching for libraries that are marked with pickup_location => 1. Calls to Koha::Item->pickup_locations and Koha::Biblio->pickup_locations are as well adapted to the new arrayref return value. To test: 1. Pick a record with only one item 2. Place a biblio-level hold on it 3. Edit the items: remove the item 4. Go to the Holds tab => FAIL: It explodes 5. Apply this patch and restart: $ sudo koha-plack --restart kohadev 6. Go back and go to the holds tab again => SUCCESS: No failure! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Didier Gautheron Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6f1e9fe75080b9a02c49730cbdb341cf09ca9826 Author: Tomas Cohen Arazi Date: Fri May 8 11:40:15 2020 -0300 Bug 25421: Make ->pickup_locations only return an arrayref This patch makes Koha::Item->pickup_locations and Koha::Biblio->pickup_locations always return an arrayref. Test are adjusted to reflect this: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! 2. Apply this patch and repeat 1 => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Didier Gautheron Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 1eae01fa14602c32f0e2de925b60b5f3a2b83db1 Author: Nick Clemens Date: Thu May 7 13:08:14 2020 +0000 Bug 25342: Unit test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2a804074030ef02f58ba708db26192ff44fc61cd Author: Nick Clemens Date: Fri May 1 14:48:55 2020 +0000 Bug 25342: Force ES id as string To test: 1 - Be using ES 2 - Find a unique record by searchign for title or seomthing 3 - Edit the record 4 - Repeat search and confirm you are returned to the details page 5 - Go to Tools->MARC modification templates 6 - Add a template and define an action 7 - Go to Tools->Batch record modification 8 - Select Enter a list of record numbers 9 - Enter the biblionumber of the record you searched for 10 - Use the marc modification template you setup 11 - Complete the modification 12 - Repeat your search 13 - note you get two results, both pointing to same biblionumber 14 - Check the ES index, note that you have two entries, one with the biblionumber, and the other with #.0, e.g.: curl -XGET 'es:9200/koha_kohadev_biblios/data/14.0?pretty' curl -XGET 'es:9200/koha_kohadev_biblios/data/14?pretty' 15 - Apply patch 16 - Delete and rebuild ES index perl misc/search_tools/rebuild_elasticsearch.pl -d -b 17 - Repeat 2-12 18 - No duplication this time Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0b7590775792e9c5a05416104a35de3c9a6b20b5 Author: Katrin Fischer Date: Tue May 5 11:56:07 2020 +0000 Bug 23787: (follow-up) Format due date as due date Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 851f433b77e6e62bd285e4e4671b11710271bab5 Author: Andrew Fuerste-Henry Date: Wed Mar 11 00:43:20 2020 +0000 Bug 23787: Add AUTO_RENEWALS to sample_notices Removed "\" from "It\'s too late..." -- apparently that doesn't need to get escaped in YAML To test: - create a new English (en) install - confirm presence of auto renewal notice Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 3aecd0afb0d543b6047d19154bb9f55c0f7c7bce Author: Katrin Fischer Date: Mon Apr 13 15:04:37 2020 +0200 Bug 23787: Add sample AUTO_RENEWALS notice to translatd installers This adds the default auto renewal notice to the translated installers. Translating will be handled by maintainers of the installers, but this way we don't end up with installations having a different set of notices than others. To test: - Verify the sample_notices.sql files load correctly or - Run the web installer for each of those languages and verify sample_notices loads correctly. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c9a032a8fc5ff312beae9ebfa84e642b9c3056e1 Author: Jonathan Druart Date: Mon May 11 11:10:20 2020 +0200 Bug 25301: Removed URI parameter "categorycode" from the toolbar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5b0e0f03c17dec4b7ee3f54798ff0c024e873806 Author: Petro Vashchuk Date: Thu May 7 12:22:24 2020 +0300 Bug 25301: removed URI parameter "categorycode" from "circulation.tt" "Edit details" links in patron's circulation check-out page was sending empty query parameter "categorycode" because there is no defined template parameter in "circulation.pl" This patch removes the URI parameter from "circulation.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron's circulation check-out page. 3) Inspect "Edit details" link. 4) Observe empty parameter "categorycode=" in that link. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the link anymore. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c79108e495951efca4824d458b3736deb4c79de9 Author: Petro Vashchuk Date: Wed May 6 16:09:01 2020 +0300 Bug 25301: removed useless URI parameter "categorycode" from template Both "Edit details" links were sending empty query parameter "categorycode" as there is no such template parameter in "moremember.pl" defined at all, because template code block looks copy-pasted from "circulation.tt". This patch removes the parameter from "moremember.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron details page of that patron. 3) Inspect both "Edit details" links: one in the notification about expiration and other one in the "Expiration date:" field. 4) Observe empty parameter "categorycode=" in those links. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the links anymore. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 7 ++- Koha.pm | 2 +- Koha/Biblio.pm | 11 +++-- Koha/Item.pm | 8 ++-- Koha/SearchEngine/Elasticsearch/Indexer.pm | 3 +- Koha/Template/Plugin/Branches.pm | 24 ++++++---- authorities/merge.pl | 4 +- .../data/mysql/de-DE/mandatory/sample_notices.sql | 21 +++++++++ .../data/mysql/en/mandatory/sample_notices.yml | 29 ++++++++++++ .../mysql/fr-CA/obligatoire/sample_notices.sql | 21 +++++++++ .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 21 +++++++++ installer/data/mysql/it-IT/necessari/notices.sql | 21 +++++++++ .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 21 +++++++++ .../data/mysql/pl-PL/mandatory/sample_notices.sql | 21 +++++++++ .../data/mysql/ru-RU/mandatory/sample_notices.sql | 21 +++++++++ .../data/mysql/uk-UA/mandatory/sample_notices.sql | 21 +++++++++ installer/data/mysql/updatedatabase.pl | 53 ++++++++++++++++++---- .../prog/en/includes/members-toolbar.inc | 4 +- .../prog/en/modules/circ/circulation.tt | 10 ++-- .../prog/en/modules/members/moremember.tt | 8 ++-- .../prog/en/modules/onboarding/onboardingstep5.tt | 5 +- t/db_dependent/Authority/Merge.t | 15 +++++- t/db_dependent/Koha/Biblio.t | 2 +- t/db_dependent/Koha/Item.t | 2 +- .../Koha/SearchEngine/Elasticsearch/Indexer.t | 28 +++++++++++- 25 files changed, 334 insertions(+), 49 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 13:16:08 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 May 2020 11:16:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2186-g61718c5c57 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 61718c5c57ff4d17992624126dc2edbadb394d74 (commit) via 8cb408cf15663dfc68762d0d1bb8f746b9bfa00d (commit) via b47e18637d58faa20e40e991845e10fac53305f0 (commit) via 46c9d97cfd8d3010386a483bfc147b75d1d58707 (commit) via 2c43e95e0cd108d0a4722f4c96215c278e762fc1 (commit) via ec5ffbd059f5d9534ebd586fbb4278854c3bb285 (commit) via 4bc14ef0523a942e6723c8e68372d9ffe45621f2 (commit) via 315f544cdc4b17912a12e41b90615d54babba705 (commit) via ff15008d20430079fe8bbad51df1709f6663cc7a (commit) via 10c642cb008a7aba563002f800afb96d03c91efc (commit) via 2bb243bb6283b6deab82b8d7744ceb288e32e9a2 (commit) via 660edd0524477641c074fd7b083ba977d26fe6f5 (commit) via 74ff965734dc069ffa18b0158ef07fcef664d118 (commit) via d9bfbefaaf72f7827279204f5867cdcfcb0ab16d (commit) via 419d158c7f4c3034c332e4ab6e8d4e3b14f19c5b (commit) via 6dac19f1e27db98b0f03f940576f1bf6bb69cf74 (commit) via 0ef02cea4a2a2b247127a6b02352f84f9e9b3ea9 (commit) via 8771232293cf6e9a1aed77b5e8f9dbaceb8590a2 (commit) via daaabc21302421653e17dce33e280a0d5e8b8d3a (commit) via e3aa4ddf6106b4e0ed3f4b441681c3a911c36d1a (commit) via 15c0e11a2ce1abbe6d244f7e23b18f4d91e410d7 (commit) via fc11887a64277552caf2aaba7886e542a2c7b474 (commit) via 64de96c612d844304129b9e3c1d1c57652c9b5dd (commit) via 71e3d02ffb5f415e5a03f2b114f107a0ca3a7a3a (commit) via cb623f0f4cf6f7fa09559c44cb18fdf0d9ba14d3 (commit) via 4364b1666e85eb4d2e38184a7dcd1bd64826c8ff (commit) via a07c5c153aaecc5cc8b0d1de5c53f184da5971b9 (commit) via 23e860683f5390cb72fa7e39e7da560512531191 (commit) via e0ab580538dc8cad53597d56cc873b1af0470603 (commit) via 4b37a4e8d3f93404f796a4edbfacb8b7a737c0ae (commit) via 3f546c031ab4557fb6bf98342cc3b8dfe870e11d (commit) from 7dc2aa28b711fa1e488173e78bba2dd92e9c8237 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 61718c5c57ff4d17992624126dc2edbadb394d74 Author: Jonathan Druart Date: Mon May 11 12:10:24 2020 +0200 Bug 15253: Remove specific logging output * We should not call Log::Log4perl directly * Not sure it is correct as I get from (comment 77): % koha-sip --restart [2020/04/23 11:23:27] [ERROR] [undef]@[undef]: Argument "0.33_01" isn't numeric in numeric lt (<) at /usr/share/perl5/Net/Server/Log/Sys/Syslog.pm line 42. C4::SIP::Trapper::PRINT /kohadevbox/koha/C4/SIP/Trapper.pm (24) Why "ERROR" when it's a warning? The [undef]@[undef] seems wrong here. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8cb408cf15663dfc68762d0d1bb8f746b9bfa00d Author: Kyle M Hall Date: Wed Apr 29 06:42:29 2020 -0400 Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit b47e18637d58faa20e40e991845e10fac53305f0 Author: Kyle M Hall Date: Wed Apr 29 06:27:10 2020 -0400 Bug 15253: Convert all tabs into 4 spaces in affected files Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 46c9d97cfd8d3010386a483bfc147b75d1d58707 Author: Kyle M Hall Date: Thu Apr 23 09:25:33 2020 -0400 Bug 15253: Log trapped errors as log level 'warn' instead of 'error' Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2c43e95e0cd108d0a4722f4c96215c278e762fc1 Author: Kyle M Hall Date: Wed Apr 1 08:14:48 2020 -0400 Bug 15253: Add log4perl conf updates for Debian packages * Add log4perl conf updates for Debian packages * Rename sip2.log to sip.log Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ec5ffbd059f5d9534ebd586fbb4278854c3bb285 Author: Kyle M Hall Date: Wed Apr 22 13:24:55 2020 -0400 Bug 15253: Rename syslog() to siplog() Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 4bc14ef0523a942e6723c8e68372d9ffe45621f2 Author: Kyle M Hall Date: Mon Apr 22 11:02:42 2019 -0400 Bug 15253: Move subs to a new module, allow unit tests to function Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 315f544cdc4b17912a12e41b90615d54babba705 Author: Kyle M Hall Date: Tue May 1 11:47:12 2018 +0000 Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Signed-off-by: Liz Rea Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ff15008d20430079fe8bbad51df1709f6663cc7a Author: Martin Renvoize Date: Wed May 6 08:50:54 2020 +0100 Bug 13547: (QA follow-up) Add basic tests Signed-off-by: Martin Renvoize commit 10c642cb008a7aba563002f800afb96d03c91efc Author: Martin Renvoize Date: Wed May 6 08:26:39 2020 +0100 Bug 13547: (follow-up) Improve POD for template plugin Signed-off-by: Martin Renvoize commit 2bb243bb6283b6deab82b8d7744ceb288e32e9a2 Author: Nazlı Çetin Date: Fri Mar 27 17:13:02 2020 +0000 Bug 13547: (follow-up) Item field 'Materials specified' would be useful to see in OPAC Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 660edd0524477641c074fd7b083ba977d26fe6f5 Author: Nazlı Çetin Date: Thu Mar 5 15:02:37 2020 +0000 Bug 13547: Add item field 3 (Materials specified) to the OPAC holdings table Test plan: 1- View a record with Materials specified (field 3) data in the opac 2- Apply patch 3- Log in to staff client 4- Home->Administration->Column Settings->OPAC->holdingst 5- Set item_materials visibility 6- Refresh OPAC page 7- Confirm that the materials specified column has been added after the Call number column. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 74ff965734dc069ffa18b0158ef07fcef664d118 Author: Nick Clemens Date: Thu May 7 12:06:10 2020 +0000 Bug 24823: (QA follow-up) Fix deletion and POD Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit d9bfbefaaf72f7827279204f5867cdcfcb0ab16d Author: David Gustafsson Date: Thu Mar 12 11:52:18 2020 +0100 Bug 24823: Remove unused parameters Remove unused Elasticsearch parameters 'key_prefix' and 'request_timeout'. Refactor so that get_elasticsearch_params only returns parameters used by Search::Elasticsearch, add class accessor for index_name. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 419d158c7f4c3034c332e4ab6e8d4e3b14f19c5b Author: David Gustafsson Date: Mon Mar 9 11:48:13 2020 +0100 Bug 24823: Fix spelling error and remove last of Catmandu Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 6dac19f1e27db98b0f03f940576f1bf6bb69cf74 Author: David Gustafsson Date: Thu Mar 5 18:05:10 2020 +0100 Bug 24823: Drop Catmandu dependency Replace remaining Catmandu dependant code with the Search::Elasticsearch equivalent. To test: 1) Apply patch 2) Run tests in t/Koha/SearchEngine/Elasticsearch.t, t/Koha/SearchEngine/ElasticSearch/* and t/db_dependent/Koha/SearchEngine/* 3) All tests should pass Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 0ef02cea4a2a2b247127a6b02352f84f9e9b3ea9 Author: Julian Maurice Date: Fri May 24 08:51:58 2019 +0200 Bug 22970: Allow to change homebranch in batch add course reserves Test plan: 1. Create a course (disabled) 2. Add multiple reserves to this course using 'batch add' and set a homebranch different from the items homebranch 3. Enable the course 4. Verify that the items homebranch have changed 5. Disable the course 6. Verify that the items homebranch were reset to their initial value Depends on bug 22630 Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8771232293cf6e9a1aed77b5e8f9dbaceb8590a2 Author: Tomas Cohen Arazi Date: Thu May 7 10:10:18 2020 -0300 Bug 25279: (QA follow-up) Use .escapeHtml Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit daaabc21302421653e17dce33e280a0d5e8b8d3a Author: Jonathan Druart Date: Wed May 6 16:09:32 2020 +0200 Bug 25279: Replace encodeURI with encodeURIComponent Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e3aa4ddf6106b4e0ed3f4b441681c3a911c36d1a Author: Tomas Cohen Arazi Date: Wed May 6 10:34:09 2020 -0300 Bug 25279: URI-escape city_id in links This patch escapes city_id uses in URLs, and also removes redundant dom entry as this is inherited from the global datatables configuration anyway. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 15c0e11a2ce1abbe6d244f7e23b18f4d91e410d7 Author: Jonathan Druart Date: Wed May 6 14:59:47 2020 +0200 Bug 25279: Use another var name for the filter It prevents: * The screen to display "no city, create one" if we are searching for a string that does not return any results. * The list to display only the city we have just created Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit fc11887a64277552caf2aaba7886e542a2c7b474 Author: Tomas Cohen Arazi Date: Tue May 5 20:28:10 2020 -0300 Bug 25279: HTML escape cells This patch makes HTML entities be escaped. It is done in a simple way. We need to explore ways to do it at datatables.js level but it deserves its own bug. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 64de96c612d844304129b9e3c1d1c57652c9b5dd Author: Tomas Cohen Arazi Date: Tue May 5 18:55:49 2020 -0300 Bug 25279: (QA follow-up) Original behaviour This patch does the following things: - Uses a call to Koha::Cities->search(*)->count to display the same message we displayed before when no city was found/defined (datatable not rendered at all). - Restores the main search box functionality, the passed param is used to query on the city name with wildcards on both sides, for (a) counting results and for (b) apending to the API call with the same behaviour. The only missing bit from QA is HTML/URI escaping values from cells, but this is going to happen at DT level most sure. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 71e3d02ffb5f415e5a03f2b114f107a0ca3a7a3a Author: Tomas Cohen Arazi Date: Fri May 1 02:26:27 2020 -0300 Bug 25279: (QA follow-up) Make button texts translatable Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit cb623f0f4cf6f7fa09559c44cb18fdf0d9ba14d3 Author: Kyle M Hall Date: Mon Apr 27 15:35:18 2020 -0400 Bug 25279: Fix edit and delete links Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 4364b1666e85eb4d2e38184a7dcd1bd64826c8ff Author: Tomas Cohen Arazi Date: Fri Apr 24 11:50:04 2020 -0300 Bug 25279: Use the API to list cities This patch makes the general cities datatable use the API for rendering. To test: 1. Test the datatable behaviour 2. Apply this patch 3. Repeat your tests => SUCCESS: Things work! Filtering and sorting specially Bonus: Use the browser inspector to notice each interaction with the datatable triggers an API call with the right query parameters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit a07c5c153aaecc5cc8b0d1de5c53f184da5971b9 Author: Tomas Cohen Arazi Date: Fri Apr 24 11:48:58 2020 -0300 Bug 25279: Add general query parameters to the /cities route Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 23e860683f5390cb72fa7e39e7da560512531191 Author: Tomas Cohen Arazi Date: Tue May 5 18:26:48 2020 -0300 Bug 24561: (follow-up) Use full_numbers for pagingType We are trying to keep the current datatables behaviour so this is a trivial yet sensible change. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e0ab580538dc8cad53597d56cc873b1af0470603 Author: Agustin Moyano Date: Thu Apr 30 11:20:05 2020 -0300 Bug 24561: (follow-up) Set default matching criteria to 'contains' and add configuration option This patch adds option.criteria as an option. Possible values are 'contains', 'starts_with', 'ends_with' and 'exact'. 'contains' is the default value. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 4b37a4e8d3f93404f796a4edbfacb8b7a737c0ae Author: Agustin Moyano Date: Wed Feb 19 11:33:14 2020 -0300 Bug 24561: Add a Datatables api wrapper that implements filter and order embedded columns This patch adds the ability to filter and order by embedded columns. To use it you must in JS: $('datatable_selector').api({datatables_options}) where datatables_options are all datatables options plus: 1. embed: [list of embeddable tables] This option adds x-koha-embed header to request. 2. header_filter: true|false This option if true sets x-koha-query header with stringyfied json of filters Oderable and searchable columns must define data option as string, otherwise filter and order won't be possible. If you must custom the output, use the render function. For example: * Don't > $('.table_selector').api({ > columns: [ > { > data: function(row, type, val, meta) { > return ''+row.holds.patron.firstname+''; > }, > orderable: true, > searchable: true > } > ] > }); * Do > $('.table_selector').api({ > columns: [ > { > data: 'holds.patron.firstname', > render: function(row, type, val, meta) { > return ''+row.holds.patron.firstname+''; > }, > orderable: true, > searchable: true > } > ] > }); To test you must implement and test bug 20936, where it will be used. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 3f546c031ab4557fb6bf98342cc3b8dfe870e11d Author: David Roberts Date: Mon May 4 16:00:26 2020 +0000 Bug 25188: Make circulation notes more prominent on the patron details tab This patch adds a more prominent circulation note to the moremember.pl details screen. To test: 1) Add a circulation note to a patron record. 2) Note that it displays prominently on the checkout tab, but only under the Library Use block on the details tab. 3) Apply the patch. 4) Check that the note is now displayed prominently at the top of the details (moremember.pl) screen. Signed-off-by: Katrin Fischer Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS.pm | 30 ++-- C4/SIP/ILS/Item.pm | 8 +- C4/SIP/ILS/Patron.pm | 10 +- C4/SIP/ILS/Transaction/Checkout.pm | 52 +++---- C4/SIP/ILS/Transaction/RenewAll.pm | 4 +- C4/SIP/Logger.pm | 67 +++++++++ C4/SIP/README | 8 +- C4/SIP/SIPServer.pm | 163 ++++++++++++--------- C4/SIP/Sip.pm | 40 +++-- C4/SIP/Sip/Configuration.pm | 4 +- C4/SIP/Sip/MsgType.pm | 69 +++++---- C4/SIP/Trapper.pm | 38 +++++ Koha/SearchEngine/Elasticsearch.pm | 79 +++++----- Koha/SearchEngine/Elasticsearch/Browse.pm | 18 +-- Koha/SearchEngine/Elasticsearch/Indexer.pm | 49 +++---- Koha/SearchEngine/Elasticsearch/Search.pm | 35 ++--- Koha/Template/Plugin/ColumnsSettings.pm | 69 ++++++++- admin/cities.pl | 12 +- admin/columns_settings.yml | 3 + api/v1/swagger/paths/cities.json | 157 +++++++++++++------- course_reserves/batch_add_items.pl | 4 + cpanfile | 2 - debian/koha-common.postinst | 16 ++ debian/templates/log4perl-site.conf.in | 8 + etc/log4perl.conf | 8 + .../prog/en/includes/cities-admin-search.inc | 2 +- .../intranet-tmpl/prog/en/modules/admin/cities.tt | 93 ++++++++---- .../en/modules/course_reserves/batch_add_items.tt | 11 ++ .../prog/en/modules/members/moremember.tt | 11 ++ koha-tmpl/intranet-tmpl/prog/js/datatables.js | 94 ++++++++++++ koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 7 + .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 5 + koha-tmpl/opac-tmpl/bootstrap/js/datatables.js | 94 ++++++++++++ opac/opac-detail.pl | 3 +- t/00-load.t | 5 +- t/Koha/SearchEngine/Elasticsearch.t | 6 +- t/db_dependent/Koha/Authorities.t | 6 - .../Koha/SearchEngine/Elasticsearch/Indexer.t | 10 +- .../Koha/SearchEngine/Elasticsearch/Search.t | 14 +- t/db_dependent/Koha/SearchEngine/Search.t | 5 - .../Koha/Template/Plugin/ColumnsSettings.t | 25 ++++ 41 files changed, 936 insertions(+), 408 deletions(-) create mode 100644 C4/SIP/Logger.pm create mode 100644 C4/SIP/Trapper.pm create mode 100644 t/db_dependent/Koha/Template/Plugin/ColumnsSettings.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 12 15:14:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 May 2020 13:14:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2191-g5bff65dd7a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5bff65dd7a76f69d3cfb91c5e4806b3618edf3b3 (commit) via 7b84e00f7e2f8c8b05c798ee08a1fee203903c27 (commit) via 49d2756f7be4815e7e93874710241506d6a3f9fc (commit) via 53349e8000d7073220fedb48bcd910abec7a592b (commit) via 2c9a322486e003e9f36d48fa72a5dd27b6ebcad9 (commit) from 61718c5c57ff4d17992624126dc2edbadb394d74 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5bff65dd7a76f69d3cfb91c5e4806b3618edf3b3 Author: Martin Renvoize Date: Tue May 12 09:24:28 2020 +0100 Bug 25417: (QA follow-up) Add integration test for AddReturn Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 7b84e00f7e2f8c8b05c798ee08a1fee203903c27 Author: Martin Renvoize Date: Mon May 11 21:14:24 2020 +0100 Bug 25417: (QA follow-up) Restore 'fixing' of fines Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 49d2756f7be4815e7e93874710241506d6a3f9fc Author: Martin Renvoize Date: Mon May 11 21:13:47 2020 +0100 Bug 25417: (QA follow-up) Clarify _FixOverduesOnReturn test Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 53349e8000d7073220fedb48bcd910abec7a592b Author: Jonathan Druart Date: Fri May 8 12:28:46 2020 +0200 Bug 25417: Prevent negative debit amount on backdating returns Koha::Account->add_credit is expecting a positive amount. Signed-off-by: Kyle M Hall Signed-off-by: Didier Gautheron Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 2c9a322486e003e9f36d48fa72a5dd27b6ebcad9 Author: Kyle M Hall Date: Thu May 7 14:21:59 2020 -0400 Bug 25417: Add unit test Signed-off-by: David Nind Signed-off-by: Didier Gautheron Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 4 +-- t/db_dependent/Circulation.t | 66 ++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 65 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 13 10:36:09 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 08:36:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2192-g33a44e4383 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 33a44e438376a567966e80100c1ef4a3c06b215d (commit) from 5bff65dd7a76f69d3cfb91c5e4806b3618edf3b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 33a44e438376a567966e80100c1ef4a3c06b215d Author: Jonathan Druart Date: Wed May 13 09:57:40 2020 +0200 Bug 24161: Fix failing test (when running slow) We "mocked" the claim date to make sure we were not going to hit this problem, but it's not done on the correct claim, it should be done on the last one (so second). from Koha::Acq::Order->claimed_date 294 my $last_claim = $self->claims->last; 295 return unless $last_claim; 296 return $last_claim->claimed_on; Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Acquisition/Order.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 13 11:58:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 09:58:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2194-gb2786e56b9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b2786e56b91d825d06b6e3e6eb5930a72b94ee92 (commit) via 0b42afc9a377cf13109a24b57eb777f3d3d08cdf (commit) from 33a44e438376a567966e80100c1ef4a3c06b215d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b2786e56b91d825d06b6e3e6eb5930a72b94ee92 Author: Tomas Cohen Arazi Date: Fri May 8 16:04:17 2020 -0300 Bug 24368: Comprehensive tests for Koha::Template::Plugin::Branches::pickup_locations Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0b42afc9a377cf13109a24b57eb777f3d3d08cdf Author: Tomas Cohen Arazi Date: Fri May 8 16:01:58 2020 -0300 Bug 24368: Remove Koha::Libraries->pickup_locations This patch removes the unused method, and cleans the tests. To test: 1. Verify Koha::Libraries->pickup_locations is not used in the code: $ git grep 'Koha::Libraries\->pickup_locations' => SUCCESS: no uses 2. Apply this patch 3. Run: $ kshell k$ prove t/db_dependent/Koha/Libraries.t => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Libraries.pm | 72 +------ t/db_dependent/Koha/Libraries.t | 335 +----------------------------- t/db_dependent/Template/Plugin/Branches.t | 94 ++++++--- 3 files changed, 70 insertions(+), 431 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 13 12:04:00 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 10:04:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2199-g4429b42036 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4429b42036061d6cf5662f12e390c521eef65771 (commit) via c5f34fe3ada46e29c9b1ac99b10186fab6d9670f (commit) via bd6ccad5d9b78719241d06a96a7ac0b77cabcef1 (commit) via 483e40d2236bbb584022846bd1c85d62f149f096 (commit) via ed564837a64a45bfd1551ab54417daf0a3b9c559 (commit) from b2786e56b91d825d06b6e3e6eb5930a72b94ee92 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4429b42036061d6cf5662f12e390c521eef65771 Author: Martin Renvoize Date: Wed May 13 10:34:10 2020 +0100 Bug 25389: DBRev 19.12.00.089 Signed-off-by: Martin Renvoize commit c5f34fe3ada46e29c9b1ac99b10186fab6d9670f Author: Martin Renvoize Date: Mon May 11 11:39:00 2020 +0100 Bug 25389: Catch errant cases of LOST_RETURNED For upgrades taking place after the fix for the update in bug 24592 was pushed, we need to catch any last remaining error cases and correct them. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit bd6ccad5d9b78719241d06a96a7ac0b77cabcef1 Author: Martin Renvoize Date: Mon May 11 11:33:32 2020 +0100 Bug 25389: Catch LOST_RETURNED in DB update 19.12.00.021 An errant update from bug 22563 could lead to cases of LOST_RETURNED as aposed to LOST_RETURN as an account_credit_type. This patch adds code to deal with those cases to the update for bug 24592 Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 483e40d2236bbb584022846bd1c85d62f149f096 Author: Martin Renvoize Date: Mon May 11 11:30:35 2020 +0100 Bug 25389: Correct stray cases of LOST_RETURNED The original DB update for bug 22563 incorrectly mapped CR to LOST_RETURNED as aposed to LOST_RETURN. This patch catches such cases and updates them in the update for bug 23805 Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ed564837a64a45bfd1551ab54417daf0a3b9c559 Author: Martin Renvoize Date: Mon May 11 11:27:16 2020 +0100 Bug 25389: Correct original DB update for bug 22563 Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 38 +++++++++++++++++++++++++++++++++- 2 files changed, 38 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 13 17:34:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 15:34:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2201-g233974a251 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 233974a2514ed7891d889624a86312e29e8f43e5 (commit) via 8b2859011326b8c5ee9d2a67890b8e753b1fbc37 (commit) from 4429b42036061d6cf5662f12e390c521eef65771 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 233974a2514ed7891d889624a86312e29e8f43e5 Author: Jonathan Druart Date: Wed May 13 16:10:34 2020 +0200 Bug 24161: (follow-up) Fix failing test (when running slow) The previous assumption was wrong, we just need to return the last one. The tests mean to have 2 different values in the claimed_on dates. Signed-off-by: Martin Renvoize commit 8b2859011326b8c5ee9d2a67890b8e753b1fbc37 Author: Jonathan Druart Date: Wed May 13 16:02:35 2020 +0200 Bug 23794: (follow-up) Remove extra carriage return Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- t/db_dependent/Koha/Acquisition/Order.t | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 13 18:21:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 16:21:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2202-g7e720e7e82 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7e720e7e820408e7e2b7b03f65cbdd1435a2d031 (commit) from 233974a2514ed7891d889624a86312e29e8f43e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7e720e7e820408e7e2b7b03f65cbdd1435a2d031 Author: Martin Renvoize Date: Wed May 13 16:52:47 2020 +0100 Bug 23794: (RM follow-up) Remove warnings from updatedatabase Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 13 18:43:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 16:43:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-193-g2cb01116ee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 2cb01116ee3ed6ce6296cb0ad5e794fd68e58f8a (commit) via 08aa52c8315c7bec6df9800101c61591892d07dd (commit) via c748b95d57ef625e77742785f8ced5369b326787 (commit) via 5518f9183054a49c672c94c6d98081da41571668 (commit) via 1bae59611da3ed166176fc67f5e68980afbb87d0 (commit) via b56c9376f1f6abda4147c183bada7c999c592985 (commit) via a833492869b8e53d2e2b24f1c7aead6fb62765fa (commit) via 27476256dfa391693b4d7473b40b95fe73cf8291 (commit) from 854c71df7914b1539e9c3af8b65096d607ea5595 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2cb01116ee3ed6ce6296cb0ad5e794fd68e58f8a Author: Marcel de Rooy Date: Fri May 8 06:46:59 2020 +0000 Bug 22437: (follow-up) Move deletion of merge requests to DelAuthority Lines can be moved. Deletion can be done too if skip_merge is not set. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 08aa52c8315c7bec6df9800101c61591892d07dd Author: Marcel de Rooy Date: Fri Apr 3 08:55:45 2020 +0000 Bug 22437: Delete older merge requests at new merge time If you merge A to B, we should remove older AA merges (regular merge to itself) in the queue before deleting A. Test plan: [1] Set merge limit in prefs to say X. [2] Find three authorities A, B, C with linkcount >X, >X, Signed-off-by: Phil Ringnalda Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c748b95d57ef625e77742785f8ced5369b326787 Author: Marcel de Rooy Date: Mon Apr 6 13:44:46 2020 +0000 Bug 22437: Add test case to Merge.t Test proves now that a 'destructive merge' is removed by DelAuthority. Test plan: Run t/db_dependent/Authority/Merge.t. Should fail when you do not apply the other two patches and pass with them. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5518f9183054a49c672c94c6d98081da41571668 Author: Nick Clemens Date: Thu May 7 13:08:14 2020 +0000 Bug 25342: Unit test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1bae59611da3ed166176fc67f5e68980afbb87d0 Author: Nick Clemens Date: Fri May 1 14:48:55 2020 +0000 Bug 25342: Force ES id as string To test: 1 - Be using ES 2 - Find a unique record by searchign for title or seomthing 3 - Edit the record 4 - Repeat search and confirm you are returned to the details page 5 - Go to Tools->MARC modification templates 6 - Add a template and define an action 7 - Go to Tools->Batch record modification 8 - Select Enter a list of record numbers 9 - Enter the biblionumber of the record you searched for 10 - Use the marc modification template you setup 11 - Complete the modification 12 - Repeat your search 13 - note you get two results, both pointing to same biblionumber 14 - Check the ES index, note that you have two entries, one with the biblionumber, and the other with #.0, e.g.: curl -XGET 'es:9200/koha_kohadev_biblios/data/14.0?pretty' curl -XGET 'es:9200/koha_kohadev_biblios/data/14?pretty' 15 - Apply patch 16 - Delete and rebuild ES index perl misc/search_tools/rebuild_elasticsearch.pl -d -b 17 - Repeat 2-12 18 - No duplication this time Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b56c9376f1f6abda4147c183bada7c999c592985 Author: Jonathan Druart Date: Mon May 11 11:10:20 2020 +0200 Bug 25301: Removed URI parameter "categorycode" from the toolbar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit a833492869b8e53d2e2b24f1c7aead6fb62765fa Author: Petro Vashchuk Date: Thu May 7 12:22:24 2020 +0300 Bug 25301: removed URI parameter "categorycode" from "circulation.tt" "Edit details" links in patron's circulation check-out page was sending empty query parameter "categorycode" because there is no defined template parameter in "circulation.pl" This patch removes the URI parameter from "circulation.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron's circulation check-out page. 3) Inspect "Edit details" link. 4) Observe empty parameter "categorycode=" in that link. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the link anymore. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 27476256dfa391693b4d7473b40b95fe73cf8291 Author: Petro Vashchuk Date: Wed May 6 16:09:01 2020 +0300 Bug 25301: removed useless URI parameter "categorycode" from template Both "Edit details" links were sending empty query parameter "categorycode" as there is no such template parameter in "moremember.pl" defined at all, because template code block looks copy-pasted from "circulation.tt". This patch removes the parameter from "moremember.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron details page of that patron. 3) Inspect both "Edit details" links: one in the notification about expiration and other one in the "Expiration date:" field. 4) Observe empty parameter "categorycode=" in those links. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the links anymore. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 7 +++++- Koha/SearchEngine/Elasticsearch/Indexer.pm | 3 +-- authorities/merge.pl | 4 ++-- .../prog/en/includes/members-toolbar.inc | 4 ++-- .../prog/en/modules/circ/circulation.tt | 4 ++-- .../prog/en/modules/members/moremember.tt | 8 +++---- t/db_dependent/Authority/Merge.t | 15 +++++++++++- .../Koha/SearchEngine/Elasticsearch/Indexer.t | 28 +++++++++++++++++++++- 8 files changed, 58 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 13 21:23:09 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 19:23:09 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-197-g1e2cb846ec Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 1e2cb846ecab70a6bdad0d960e4609c954f6583e (commit) via ebab63161f1d9b89a25b6e4f4f485f4cc4903dea (commit) via 8ac1f30c9192cecbe32f8eda3dae8e5ed8d24bb3 (commit) via 57bf9fc48d1e996f11a2a25e76232d7048b92b5b (commit) from 2cb01116ee3ed6ce6296cb0ad5e794fd68e58f8a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e2cb846ecab70a6bdad0d960e4609c954f6583e Author: Joy Nelson Date: Wed May 13 18:54:56 2020 +0000 Bug 25478: DBRev 19.11.05.006 Signed-off-by: Joy Nelson commit ebab63161f1d9b89a25b6e4f4f485f4cc4903dea Author: Martin Renvoize Date: Wed May 13 10:57:55 2020 +0100 Bug 25478: (25389 backport) Catch errant cases of LOST_RETURNED For upgrades taking place after the fix for the update in bug 24592 was pushed, we need to catch any last remaining error cases and correct them. (cherry picked from commit c5f34fe3ada46e29c9b1ac99b10186fab6d9670f) Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8ac1f30c9192cecbe32f8eda3dae8e5ed8d24bb3 Author: Martin Renvoize Date: Wed May 13 10:54:12 2020 +0100 Bug 25478: (25389 backport) Correct stray cases of LOST_RETURNED The original DB update for bug 22563 incorrectly mapped CR to LOST_RETURNED as aposed to LOST_RETURN. This patch catches such cases and updates them in the update for bug 23805 (cherry picked from commit 483e40d2236bbb584022846bd1c85d62f149f096) Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 57bf9fc48d1e996f11a2a25e76232d7048b92b5b Author: Martin Renvoize Date: Wed May 13 10:50:15 2020 +0100 Bug 25478: (25389 backport) Correct original DB update for bug 22563 (cherry picked from commit ed564837a64a45bfd1551ab54417daf0a3b9c559) Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 29 ++++++++++++++++++++++++++++- 2 files changed, 29 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 13 21:47:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 19:47:20 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-206-g4c201630ff Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4c201630ff3c8239c33588a3ffd82156a3c762ec (commit) via 6f9dda2f295a2d25c01ad48fd3f54fb25735f60b (commit) via e21179fd9bad471c931ce0e89cd8f4df145af8f1 (commit) via 180360e3fde1befd73fb0d626d0fc7ddebc057de (commit) via 4550e7c6d90679d6b5a3ed067b43ecc214a22942 (commit) via a64a5311f46f90cc33f6668eb0e4e6e317ca0f76 (commit) via b08fff84bd88e22e1a5eb522a6f11d6db7621f09 (commit) via 44f4267cfc1097b5048cd2e49da73d4cbe7c69ed (commit) via f0ecc011f0d91f86f2994bdda3c7e15d5d52592a (commit) from 1e2cb846ecab70a6bdad0d960e4609c954f6583e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4c201630ff3c8239c33588a3ffd82156a3c762ec Author: Nick Clemens Date: Mon May 11 17:08:35 2020 +0000 Bug 25418: (QA follow-up) Raise size of input box In twelve hour format the length of the string is 20 characters we need the box to fit all of them Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 6f9dda2f295a2d25c01ad48fd3f54fb25735f60b Author: Jonathan Druart Date: Thu May 7 17:18:35 2020 +0200 Bug 25418: (bug 25133 follow-up) Display due date with hours And not as due date, it's not a display-only info, but an input. This patch is a follow-up of Bug 25133: Fix time part of due date for 12hr == Test plan == 1. create checkouts with the following params and results 2. tomorrow 11:59 PM timeformat syspref: 12h - item is due without a specific time, only date (after-checkout green box) 3. backdate 11:59 PM timeformat syspref: 12h - note the yellow confirm box has only the date - item is due at 12:00 PM (after-checkout green box) 4. tomorrow 11:23 AM timeformat syspref: 12h - item is due at 11:23 AM (after-checkout green box) 5. backdate 11:23 AM timeformat syspref: 12h - note the yellow confirm box has the date and time - item is due 11:23 AM (after-checkout green box) 6. tomorrow 23:59 timeformat syspref: 24h - item is due without a specific time, only date (after-checkout green box) 7. backdate 23:59 timeformat syspref: 24h - note the yellow confirm box has only the date - item is due at 00:00 (after-checkout green box) 8. tomorrow 11:23 timeformat syspref: 24h - item is due at 11:23 (after-checkout green box) 9. backdate 11:23 timeformat syspref: 24h - note the yellow confirm box has the date and time - item is due 11:23 (after-checkout green box) 10. apply patch 11. create checkouts with the following params and results 12. tomorrow 11:59 PM timeformat syspref: 12h - item is due without a specific time, only date (after-checkout green box) 13. backdate 11:59 PM timeformat syspref: 12h - note the yellow confirm box has the date and time - CHANGE COMPARED TO BEFORE THE PATCH - item is due without a specific time, only date (after-checkout green box) - CHANGE COMPARED TO BEFORE THE PATCH 14. tomorrow 11:23 AM timeformat syspref: 12h - item is due 11:23 AM (after-checkout green box) 15. backdate 11:23 AM timeformat syspref: 12h - note the yellow confirm box has the date and time - item is due 11:23 AM (after-checkout green box) 16. tomorrow 23:59 timeformat syspref: 24h - item is due without a specific time, only date (after-checkout green box) 17. backdate 23:59 timeformat syspref: 24h - note the yellow confirm box has the date and time - CHANGE COMPARED TO BEFORE THE PATCH - item is due without a specific time, only date (after-checkout green box) - CHANGE COMPARED TO BEFORE THE PATCH 18. tomorrow 11:23 timeformat syspref: 24h - item is due at 11:23 (after-checkout green box) 19. backdate 11:23 timeformat syspref: 24h - note the yellow confirm box has the date and time - item is due 11:23 (after-checkout green box) Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e21179fd9bad471c931ce0e89cd8f4df145af8f1 Author: Slava Shishkin Date: Sun May 10 18:15:09 2020 +0300 Bug 25409: Add missing "Required" text and "required" classes Highlight text with red by adding “required” class to the label and added red “Required” text next to select field in "onboardingstep5.tt" template. To test: 1) Start new installation. During onboarding tool phase you will be requested to create a new circulation rule. 2) Observe that "Units" label has no "required" class and that there’s no “Required” text next to a select field. 3) Apply patch. 4) Repeat step 2 (you can reload circulation rule creation page). 5) Observe the error is gone. Mentored-by: Peter Vashchuk Mentored-by: Andrew Nugged Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 180360e3fde1befd73fb0d626d0fc7ddebc057de Author: Slava Shishkin Date: Thu May 7 14:24:31 2020 +0300 Bug 25409: Add missing "required" class to template Added "required" class to "itemtype" label in "onboardingstep5.tt" template. To test: 1) Start new instalation. During onboarding tool phase you will be requested to create a new circulation rule. 2) Observe that "itemtype" label has no "required" class. 3) Apply patch. 4) Repeat step 2 (you can reload circulation rule creation page). 5) Observe the error is gone. Mentored-by: Peter Vashchuk Mentored-by: Andrew Nugged Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 4550e7c6d90679d6b5a3ed067b43ecc214a22942 Author: Martin Renvoize Date: Tue May 12 09:24:28 2020 +0100 Bug 25417: (QA follow-up) Add integration test for AddReturn Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit a64a5311f46f90cc33f6668eb0e4e6e317ca0f76 Author: Martin Renvoize Date: Mon May 11 21:14:24 2020 +0100 Bug 25417: (QA follow-up) Restore 'fixing' of fines Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b08fff84bd88e22e1a5eb522a6f11d6db7621f09 Author: Martin Renvoize Date: Mon May 11 21:13:47 2020 +0100 Bug 25417: (QA follow-up) Clarify _FixOverduesOnReturn test Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 44f4267cfc1097b5048cd2e49da73d4cbe7c69ed Author: Jonathan Druart Date: Fri May 8 12:28:46 2020 +0200 Bug 25417: Prevent negative debit amount on backdating returns Koha::Account->add_credit is expecting a positive amount. Signed-off-by: Kyle M Hall Signed-off-by: Didier Gautheron Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit f0ecc011f0d91f86f2994bdda3c7e15d5d52592a Author: Kyle M Hall Date: Thu May 7 14:21:59 2020 -0400 Bug 25417: Add unit test Signed-off-by: David Nind Signed-off-by: Didier Gautheron Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 4 +- .../prog/en/modules/circ/circulation.tt | 6 +- .../prog/en/modules/onboarding/onboardingstep5.tt | 5 +- t/db_dependent/Circulation.t | 66 +++++++++++++++++++++- 4 files changed, 71 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 13 23:35:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 21:35:44 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-30-g76b470f035 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 76b470f0352acb25b9635aea45f5b42bd2ff2fc3 (commit) via 3c419c007c538cff8a233e6b5777fc57ae022f1f (commit) from 0bbaf0d1e67d343beba5b043408c488db30db8bd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 76b470f0352acb25b9635aea45f5b42bd2ff2fc3 Author: Kyle M Hall Date: Wed Apr 8 10:52:23 2020 -0400 Bug 22778: Add unit test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit 0c64138dd1787dd35c06cad1512dd1a2de470bfb) Signed-off-by: Lucas Gass commit 3c419c007c538cff8a233e6b5777fc57ae022f1f Author: Kyle M Hall Date: Thu Apr 25 15:50:35 2019 -0400 Bug 22778: Suggestions with no "suggester" can cause errors If one tries to modify a suggestion that has no suggester you will get the following error: Can't call method "lang" on an undefined value at /usr/share/koha/lib/C4/Suggestions.pm line 506 Koha assumes that every suggestion has a borrowernumber in suggestedby Test Plan: 1) Create a suggestion with an unpopulated suggestedby 2) Attempt to modify that suggestion 3) Note the error 4) Apply this patch 5) Restart all teh things 6) Attempt to modify that suggestion 7) No error! Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit cac73b47ef221b32a6254fd25f22c86bcdd20c20) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Suggestions.pm | 3 ++- t/db_dependent/Suggestions.t | 35 ++++++++++++++++++++++++++++++++++- 2 files changed, 36 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 13 23:39:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 21:39:25 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-31-g681b87e168 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 681b87e1686a5bc1dc4560ebd8bfae04a2a8262a (commit) from 76b470f0352acb25b9635aea45f5b42bd2ff2fc3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 681b87e1686a5bc1dc4560ebd8bfae04a2a8262a Author: Kyle M Hall Date: Thu Apr 9 08:24:44 2020 -0400 Bug 25095: Remove warn left in FeePayment.pm It appears that a debugging statement was accidentally left in FeePayment.pm by bug 5605. Signed-off-by: Devinim Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit de56296d36ef8102f1d90e90e1617bd87c9879d8) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Transaction/FeePayment.pm | 2 -- 1 file changed, 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 13 23:43:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 21:43:26 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-32-g00493587e3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 00493587e3a00633ed2b0224b5659acf9b11d23f (commit) from 681b87e1686a5bc1dc4560ebd8bfae04a2a8262a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 00493587e3a00633ed2b0224b5659acf9b11d23f Author: Aleisha Amohia Date: Mon Mar 16 22:09:51 2020 +0000 Bug 24266: (alternate patch) Only use defined borrowernumbers in reconcile_balances.pl cron I believe the error is triggered when borrowernumbers are left empty in the accountlines table. Not sure why this would happen, but it appears to be what causes the problem. Do not apply the first patch if testing this patch. To test: 1) sudo koha-mysql INSTANCENAME 2) Create a test borrower, add any payment etc to create an accountline, then delete this borrower 3) ensure the AccountAutoReconcile syspref is disabled 4) Go to another borrower's accounting tab 5) Create a manual credit or debit. Confirm this shows in the 'Make a payment' tab as an amount that COULD be applied, but isn't automatically applied 6) in your terminal, run the reconcile_balances.pl script 7) Confirm the error does not show in the logs and the balance for the borrower is correctly reconciled. Sponsored-by: Horowhenua District Council Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c6c6c57400a9941a027ce8f919c652567ed37710) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/reconcile_balances.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 00:05:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 22:05:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-34-g11b8184338 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 11b8184338167765dd1e3af9be72b3575392101e (commit) via e54c8d088476b8c7aad346ba677d676125eec13b (commit) from 00493587e3a00633ed2b0224b5659acf9b11d23f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 11b8184338167765dd1e3af9be72b3575392101e Author: Kyle M Hall Date: Fri Apr 10 06:43:51 2020 -0400 Bug 24966: Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 93d95ac1b3feaf5482b6a1a25c9d4198837e675c) Signed-off-by: Lucas Gass commit e54c8d088476b8c7aad346ba677d676125eec13b Author: Marcel de Rooy Date: Fri Apr 10 09:50:13 2020 +0000 Bug 24966: (QA follow-up) Fix return value of hold_patron_bcode It is used in list context, but we need a scalar value. Can be fixed by adding scalar's, or returning empty string as here. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 48d42a68794c3bf85c087adf2185d979929a13bc) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Item.pm | 4 ++-- t/db_dependent/SIP/Message.t | 32 +++++++++++++++++++++++++++++++- 2 files changed, 33 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 00:10:57 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 22:10:57 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-207-gb8ac29fa8a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b8ac29fa8ad26248fb06cee81782ff7fa2ca912f (commit) from 4c201630ff3c8239c33588a3ffd82156a3c762ec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b8ac29fa8ad26248fb06cee81782ff7fa2ca912f Author: Joy Nelson Date: Wed May 13 21:43:32 2020 +0000 DBRev: RMaint (follow-up) correct Koha.pm version Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 00:13:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 22:13:26 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-36-g2f48fb0d38 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 2f48fb0d38334d0d5fd241f4c0a05b825b52fbf6 (commit) via c14cd6d6459ad73e6de3056eba43fef7c53d4943 (commit) from 11b8184338167765dd1e3af9be72b3575392101e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2f48fb0d38334d0d5fd241f4c0a05b825b52fbf6 Author: Marcel de Rooy Date: Thu Mar 19 14:39:14 2020 +0100 Bug 24903: Add tests for _handle_seqno Trivial tests. Test plan: Run t/Serials/ModSerialStatus.t Signed-off-by: Marcel de Rooy Signed-off-by: Laurence Rault Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 71eb787fbd34294ff6df995fa74d930dec4f4057) Signed-off-by: Lucas Gass commit c14cd6d6459ad73e6de3056eba43fef7c53d4943 Author: Marcel de Rooy Date: Thu Mar 19 14:20:38 2020 +0100 Bug 24903: Special characters like parentheses in numbering pattern cause duplication in recievedlist Test plan: Use serial with a numbering pattern with parentheses like "2018 (No. 1)". Mark serial issue as arrived, check receivedlist on summary. Edit issue again, check if not duplicated on receivedlist. Mark issue as missing or not available, check missinglist. Mark missing issue as not missing, check list again. Signed-off-by: Marcel de Rooy Signed-off-by: Laurence Rault Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 82bee9fe6a28e70393d382b03db884d1eb142ddf) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 29 ++++++++++++++++++++++------- t/Serials/ModSerialStatus.t | 38 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+), 7 deletions(-) create mode 100755 t/Serials/ModSerialStatus.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 00:18:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 22:18:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-37-g0d06d789f7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0d06d789f7fa6dfaee7b208d2775a3f51e60477d (commit) from 2f48fb0d38334d0d5fd241f4c0a05b825b52fbf6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d06d789f7fa6dfaee7b208d2775a3f51e60477d Author: Lucas Gass Date: Thu Mar 26 22:46:26 2020 +0000 Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature TEST PLAN: 1. Make a new news item and use the TinyMCE editor, click on the <> icon to go to the Source code editor 2. Add some HTML like and save it. 3. Go back in and notice that TinyMCE has changed it to:

TEST

4. It should not auto clean up and also it should not autowrap with

tag. 5. Apply patch patch, and repeat step 2. Save again. 6. It should not have automatiicly changed any HTML or added any

wrapper. Signed-off-by: David Cook Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 0b7d3b4331c69238ae04fdb895baeae9ce0742cf) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt | 5 +++++ 1 file changed, 5 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 00:34:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 22:34:15 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-40-gd1db7aeca5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via d1db7aeca5a238d5b7cc172778d142b45dd073bf (commit) via 427f564c4de3e4e71c183bc793260b16fdb05c93 (commit) via da64d7ceb9bed580f4bf6230312c94a00d8fdbc3 (commit) from 0d06d789f7fa6dfaee7b208d2775a3f51e60477d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d1db7aeca5a238d5b7cc172778d142b45dd073bf Author: Tomas Cohen Arazi Date: Mon Mar 30 10:06:43 2020 -0300 Bug 25008: Overload Koha::RecordProcessor->options to update filters This patch overloads the 'options' accessor generated by Class:Accessor. It does so the passed options are used to refresh the loaded filters. Tests are added for this overloaded method as well. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/RecordProcessor.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b4f47c9a06af45a1524c210f073c07523ff94ce9) Signed-off-by: Lucas Gass commit 427f564c4de3e4e71c183bc793260b16fdb05c93 Author: Tomas Cohen Arazi Date: Mon Mar 30 10:20:11 2020 -0300 Bug 25008: Tests for ->options Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b2b36b6f447890ec2972cd2b397a23c53fd183f3) Signed-off-by: Lucas Gass commit da64d7ceb9bed580f4bf6230312c94a00d8fdbc3 Author: Tomas Cohen Arazi Date: Fri Mar 27 17:53:32 2020 -0300 Bug 25008: Regression tests This patch highlights a behaviour of Koha::RecordProcessor that is unexpected: if you change the original options using ->options, the loaded filters don't pick the change. That's because the filter objects are loaded on ->new, and they are never updated. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/RecordProcessor.t => FAIL: Test prove ->options doesn't update the filters! Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 008b09ce057e117766a95c03f551cab82e90c424) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/RecordProcessor.pm | 23 +++++++++++++++++++++ t/RecordProcessor.t | 54 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 77 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 00:39:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 22:39:07 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-43-g064343336f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 064343336fc11e833397f14cc257e5eaf3e0c0f5 (commit) via 2194810dd8c5f147466658e608e32aa8815c3988 (commit) via 24abcfbb52d32e4659fb126d01b884b94216c33e (commit) from d1db7aeca5a238d5b7cc172778d142b45dd073bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 064343336fc11e833397f14cc257e5eaf3e0c0f5 Author: Liz Rea Date: Thu Apr 9 15:50:04 2020 +0000 Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. Signed-off-by: Jonathan Druart Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit cfd8e38fd8c01d0ab1dfd9e1b828b283b1dac64d) Signed-off-by: Lucas Gass commit 2194810dd8c5f147466658e608e32aa8815c3988 Author: Jonathan Druart Date: Wed Apr 8 11:57:06 2020 +0200 Bug 24993: Make sure we are not going to loop indefinitely Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 121ea7e96cdaf0e620858ec04ab80213a09a3d44) Signed-off-by: Lucas Gass commit 24abcfbb52d32e4659fb126d01b884b94216c33e Author: Jonathan Druart Date: Thu Apr 2 12:36:16 2020 +0200 Bug 24993: Make sure SIP server is stopped before restarting it Sometimes doing koha-sip --restart instance happens too fast and the SIP server is not started. To test: - have SIP enabled and running for your instance - issue a restart, make sure it restarts sudo koha-sip --restart inst Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 317d2c1de7c7ef234517b99e65df3cab361fc1bb) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-sip | 10 ++++++++++ 1 file changed, 10 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 00:41:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 22:41:52 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-44-g02cccad3cf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 02cccad3cf5f889f226f8cea4ed81f6ea00a6543 (commit) from 064343336fc11e833397f14cc257e5eaf3e0c0f5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 02cccad3cf5f889f226f8cea4ed81f6ea00a6543 Author: David Roberts Date: Mon Apr 13 01:22:07 2020 +0000 Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it This patch changes the wording of the comment To test: 1) Check the wording of Line 67 of Koha/AuthUtils.pm 2) Apply the patch 3) Check that the wording has changed from "Encrypt it" to "Hash it" Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5576bf647dda24a4f7da56bf86656fe58f05b80d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/AuthUtils.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 00:44:35 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 22:44:35 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-45-g86822a5bc5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 86822a5bc540a5fa88cf57aa626f0f0c5f7d458e (commit) from 02cccad3cf5f889f226f8cea4ed81f6ea00a6543 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 86822a5bc540a5fa88cf57aa626f0f0c5f7d458e Author: Jonathan Druart Date: Tue Mar 31 16:39:12 2020 +0200 Bug 25027: Use localStorage instead of sessionStorage for results browser Staff side, when a search a done and a result clicked, a browser appears on the left, to navigate between the different results. We use sessionStorage to know the list of biblionumber from the result. As sessionStorage is only for the current tab, we do some ugly things, to catch the click events, then open the new tab, attach it to the current window, and put the focus back on the result list. We really should not do that, and let the user decide what they want to do with their clicks! To do so, let use the correct storage, localStorage, and have the results shared between the windows. We may need to clear that at some point, isn't it? Test plan: Launch a search, click result (left or middle), confirm you see the browser and that the window/tab opened like any other websites (depending on your web browser settings). Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 0ac67146b97123c2d408c0c72547d92e13368313) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/js/browser.js | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 00:47:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 22:47:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-46-g41f64e0b82 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 41f64e0b82094aa23381a68f6033a3a49d711f3a (commit) from 86822a5bc540a5fa88cf57aa626f0f0c5f7d458e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 41f64e0b82094aa23381a68f6033a3a49d711f3a Author: Kyle M Hall Date: Thu Jan 30 10:29:05 2020 -0500 Bug 24547: Add more action logs for holds It seems like ModReserveFill and ModReserveAffect should both produce action logs for holds. Test Plan: 1) Apply this patch 2) Place a hold 3) Check in the item to trap the hold 4) Check out the item to fill the hold 5) Check the action logs for that reserve id 6) Note the new logs! Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d3e3a3757dc3e9d97e3204767409e1d39d637255) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 6 ++++++ 1 file changed, 6 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 00:52:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 13 May 2020 22:52:32 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-47-g5abd166791 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5abd166791fe2121e8e38e472007cbb2bf7ca659 (commit) from 41f64e0b82094aa23381a68f6033a3a49d711f3a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5abd166791fe2121e8e38e472007cbb2bf7ca659 Author: David Roberts Date: Sat Apr 4 23:13:00 2020 +0000 Bug 25053: Clarify the description of syspref PatronSelfRegistrationExpireTemporaryAccountsDelay This patch changes the wording of this system preference. To test: 1) Check the current wording of this system preference. 2) Install the patch. 3) Check that the wording of this system preference has changed to "Delete patrons still in the category indicated by PatronSelfRegistrationDefaultCategory X days after account creation." Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 2b8f6f62af9c262bec4a4ce88ddae3d706727fb1) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 17:05:19 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 15:05:19 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-48-gb2a046f25d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via b2a046f25d0a48d1262778b76958f8c9382752f1 (commit) from 5abd166791fe2121e8e38e472007cbb2bf7ca659 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b2a046f25d0a48d1262778b76958f8c9382752f1 Author: Lucas Gass Date: Thu May 14 14:37:05 2020 +0000 Bug 20882: (Rmaint follow-up) fix shebang typo Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 17:26:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 15:26:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-52-g4ce9cf2d50 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 4ce9cf2d500129d3ea3b9833ddbb2e5284bec871 (commit) via de3dcc4904379fd4ac8ece1840ab0cee50441201 (commit) via 63914840c620fda1b7edf5e831602db1bce179c1 (commit) via 655958ca124d9969abfde40876a496f8f5a173f9 (commit) from b2a046f25d0a48d1262778b76958f8c9382752f1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4ce9cf2d500129d3ea3b9833ddbb2e5284bec871 Author: Fridolin Somers Date: Wed Mar 11 17:39:18 2020 +0300 Bug 21865: allow test arg alone Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 8523817dcc4d2219138b1c8600f289cbe9a009ee) Signed-off-by: Lucas Gass commit de3dcc4904379fd4ac8ece1840ab0cee50441201 Author: Fridolin Somers Date: Mon Nov 19 15:45:49 2018 +0100 Bug 21865: add confirm to remove_unused_authorities.pl script Like in most scripts in misc, add confirm argument to ensure script is not run without knowing what it does. Test plan: 1) Run misc/migration_tools/remove_unused_authorities.pl -h 2) You see help line for confirm 3) Run misc/migration_tools/remove_unused_authorities.pl 4) You see help and script does nothing 5) Run misc/migration_tools/remove_unused_authorities.pl -c 6) Script runs like wanted Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ace1f665dfdcb7dd2fe1e864191556432e9c5ef6) Signed-off-by: Lucas Gass commit 63914840c620fda1b7edf5e831602db1bce179c1 Author: Fridolin Somers Date: Mon Nov 19 15:19:46 2018 +0100 Bug 21865: ES compatiblity of remove_unused_authorities.pl The script misc/migration_tools/remove_unused_authorities.pl directly checks if Zebra search is OK. This patch changes so that this test is only if Zebra is the search engine. It also adds a test on the search off any authority number indexed (index 'an'). With Zebra its : an,alwaysmatches='' With ES its : an:* This test ensure that biblios records are indexed and that not all autorities will be deleted. Test plan: 1) On a catalog create a new authority 2) Use Zebra in systempreference SearchEngine 3) Stop Zebra server 4) Run misc/migration_tools/remove_unused_authorities.pl -c 5) The script does nothing and says : Zebra server seems not to be available. This script needs Zebra runs. 6) Restart Zebra server 7) Delete biblio index base 8) Run misc/migration_tools/remove_unused_authorities.pl -c 9) The script does nothing and says : Searching authority number in biblio records seems not to be available : an,alwaysmatches='' 10) Use ElasticSearch in systempreference SearchEngine 11) Delete biblio index base 12) Run misc/migration_tools/remove_unused_authorities.pl -c 13) The script does nothing and says : Searching authority number in biblio records seems not to be available : an:* Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ee25606e8a85fb8a95284b6ad678dd18e97dfd02) Signed-off-by: Lucas Gass commit 655958ca124d9969abfde40876a496f8f5a173f9 Author: Fridolin Somers Date: Mon Nov 19 14:46:05 2018 +0100 Bug 21865: improve remove_unused_authorities.pl script remove_unused_authorities.pl script can be improved. This patch changes changes verbosity so than test mode can be used to know the autorities that are used and those that can be deleted. It also writes a line in output if limited authority type(s). This patch also removes the unused vars $thresholdmin and $thresholdmax. It also changes the query to use SQL with parameters for authority types. Test plan : 1) On a catalog create a new authority 2) Be sure catalog is well indexed 3) Run misc/migration_tools/remove_unused_authorities.pl -t 4) You will see the line : *** Testing only, authorities will not be deleted. *** 5) You will see lines of : authid=x type=y : used X time(s) 6) You will see the line for the authority created in 1) : authid=x type=y : can be deleted 7) You will see at the end : x authorities parsed y can be deleted because unused z unchanged because used 8) Run misc/migration_tools/remove_unused_authorities.pl 9) You don't see the line : *** Testing only, authorities will not be deleted. *** 10) You will see lines of : authid=x type=y : used X time(s) 11) You will see the line for the authority created in 1) : authid=x type=y : deleted 12) You will see at the end : x authorities parsed y deleted because unused z unchanged because used 13) Run misc/migration_tools/remove_unused_authorities.pl --auth NP --auth CO 14) You see the line : Restricted to authority type(s) : NP,CO. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 36a84f4264e5c03b900eb850c93cc4eb0befd9e7) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/migration_tools/remove_unused_authorities.pl | 87 +++++++++++++++-------- 1 file changed, 57 insertions(+), 30 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 18:18:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 16:18:53 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-53-g16af0a42e9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 16af0a42e9f663bc0e9019465b5bf03db967a2ca (commit) from 4ce9cf2d500129d3ea3b9833ddbb2e5284bec871 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 16af0a42e9f663bc0e9019465b5bf03db967a2ca Author: Katrin Fischer Date: Mon Apr 13 04:32:56 2020 +0200 Bug 22468: Standardize on labelling ccode table columns as Collections We now display the descriptions everywhere, so we should drop the 'code' from labels. This changes text in a lot of playes in Koha, including: - The relatives checkouts table when displayed for the guarantor - The new order and order receive forms in acquisitoins (item creation) - The description of CCODE in the authorised values table - The column description on results in item search - The branch tranfers page - Course reserves: add reserve items (one and in batch) - Patron account > statistics tab Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 58990eda36c29d09903c2135e76529c6a3accfcc) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/relatives-issues-table.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 6 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 4 ++-- .../prog/en/modules/course_reserves/add_items-step2.tt | 2 +- .../prog/en/modules/course_reserves/batch_add_items.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt | 2 +- 9 files changed, 13 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 18:23:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 16:23:26 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-55-gb04b8d0061 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via b04b8d006172894e132a4c6d2be37498370d0f1a (commit) via 7725c1f9daa604d29355513ad51a70031df6cb5c (commit) from 16af0a42e9f663bc0e9019465b5bf03db967a2ca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b04b8d006172894e132a4c6d2be37498370d0f1a Author: Owen Leonard Date: Sat Mar 28 17:42:50 2020 +0000 Bug 25007: (follow-up) Fix the way image check alters layout A question in the bug report asks: Why is is necessary to change the Bootstrap class to col-xs-12? The JavaScript which checks for the existence of an Amazon cover image is designed to remove the Amazon cover's container if there is none. Changing the class of cover image column is gone. However, the check is incorrect because it doesn't account for Local Covers. There might be both a 1 x 1 pixel Amazon image and a local cover image, so the layout shouldn't be changed unless there are no images present. To test, apply the patch and view the bibliographic details page of various titles including: - Amazon cover present, no local cover - No Amazon cover, local cover image present - Both Amazon and local cover image Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 05c4248721cfcbb9967b42e2bacf1a82eb845f1a) Signed-off-by: Lucas Gass commit 7725c1f9daa604d29355513ad51a70031df6cb5c Author: Lucas Gass Date: Fri Mar 27 20:40:30 2020 +0000 Bug 25007: Check for normaalized ISBN when building Amazon link TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -Apply patch and reload page -The image should be back in its normal spot Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 8c09c5ee80d59aae134454375f260c47a6af2f16) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 18:37:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 16:37:12 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-56-g5741383cf3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5741383cf3ad60efb7dd742334ef51966e2dbfce (commit) from b04b8d006172894e132a4c6d2be37498370d0f1a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5741383cf3ad60efb7dd742334ef51966e2dbfce Author: Kyle M Hall Date: Tue Jan 30 11:10:07 2018 -0500 Bug 20101: Cronjob automatic_item_modification_by_age.pl does not log run in action logs C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. Test Plan: 1) Apply this patch 2) Enable CronjobLog 3) Run automatic_item_modification_by_age.pl succesfully 4) Note the run is noted in the action logs Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 8ed0d57c95f36cfb960a998dc5b2fda6cfa44ef4) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/automatic_item_modification_by_age.pl | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 19:47:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 17:47:03 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-57-g1aef2f34e5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1aef2f34e5fb5602eaf228d9eefc93063be3e276 (commit) from 5741383cf3ad60efb7dd742334ef51966e2dbfce (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1aef2f34e5fb5602eaf228d9eefc93063be3e276 Author: Jonathan Druart Date: Mon Apr 6 12:44:13 2020 +0200 Bug 25069: Fix AddressFormat="fr" behavior Something went wrong during a rebase of bug 13618 commit dcd1f5d48c758aee17b6c6f069c6146b42efe117 Bug 13618: Add html filters to all the variables Several changes related to AddressFormat are wrong: - [% IF Koha.Preference( 'AddressFormat' ) %] - [% INCLUDE "member-main-address-style-${ Koha.Preference( 'AddressFormat' ) }.inc" %] - [% ELSE %] - [% INCLUDE 'member-main-address-style-us.inc' %] - [% END %] + [% SWITCH Koha.Preference( 'AddressFormat' ) %] + [% CASE 'de' %] + [% INCLUDE 'member-main-address-style-de.inc' %] + [% CASE # us %] + [% INCLUDE 'member-main-address-style-us.inc' %] + [% END %] Test plan: Create a patron with all the address fields filled Play with the 3 option values of AddressFormat, and confirm that the address is displayed correctly on the patron's view, and in the patron module (top left) Signed-off-by: Joy Nelson (cherry picked from commit b7e9de9a436d59c811f459758094b9bb1ab86a59) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/circ-menu.inc | 9 ++++----- .../prog/en/modules/members/memberentrygen.tt | 21 ++++++++++----------- 2 files changed, 14 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 20:13:02 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 18:13:02 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-58-gffdd8a7817 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via ffdd8a78175b5afd22d8739cdf637716e56746e3 (commit) from 1aef2f34e5fb5602eaf228d9eefc93063be3e276 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ffdd8a78175b5afd22d8739cdf637716e56746e3 Author: Katrin Fischer Date: Mon Apr 13 03:46:25 2020 +0200 Bug 10561: Rephrase DisplayOPACiconsXSLT and DisplayIconsXSLT slightly As the pref removes the whole 'line' of information, this tries to makes the behaviour a little clearer by adding a 'and descriptions' to the pref text. It now reads: [Show|Don't show] the format, audience, and material type icons and descriptions in XSLT MARC21 results and detail pages in ... To test: - Check both preference descriptions in the staff client - Verify the text reads correctly and this helps things Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 6d02cbad0b8f64293ceae4a3cc2640a149a2756a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 2 +- .../intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 20:15:59 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 18:15:59 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-59-ga6162e45fd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a6162e45fd89adae6cff599393d8f7905c00c505 (commit) from ffdd8a78175b5afd22d8739cdf637716e56746e3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a6162e45fd89adae6cff599393d8f7905c00c505 Author: Katrin Fischer Date: Tue Apr 14 16:57:38 2020 +0000 Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account When using sort1/sort2 with authorised values to create a pull down list, there will be no empty entry unless one is manually added to the authorised values list. This is not a good default behaviour, as it can easily cause errors on patron creation. Without the empty entry, the first alphabetic value is pre-selected and will be saved if not explicitly changed. It also doesn't allow to mark sort1/sort2 as mandatory, as the value is always 'set', the required message won't be triggered. This adds an empty parameter to av-build-dropbox.inc to allow selectively adding this empty entry without causing side-effects in other places this include is used. To test: - Create authorised values for either Bsort1 or Bsort2 authorised value category - Create a new patron: - you should see a pull down list on one and an input field for the other - for the pull down list, there will be no empty entry and the first alphabetic value will be preselected - Make your sort1 and sort2 mandatory using BorrowerMandatoryField - Verify there is still on empty entry - Apply patch - Repeat tests and verify that the behaviour is as expected - There should now be an empty entry - When the field is marked mandatory and empty is left, the required warning will be shown. Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a934499b8cc192781f263b0ba2b3edd5374e64cf) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/av-build-dropbox.inc | 6 ++++-- koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 20:21:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 18:21:04 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-60-g1beb5860f6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1beb5860f605f86eea6f1f552ea09569e0ed1234 (commit) from a6162e45fd89adae6cff599393d8f7905c00c505 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1beb5860f605f86eea6f1f552ea09569e0ed1234 Author: Katrin Fischer Date: Tue Apr 14 13:14:37 2020 +0000 Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs When paging through the patron account in staff, using the tabs on the right, you notice that some pages are missing the patron toolbar on top and that the headings, where they exist, vary in size. This patch adds the patron toolbar to 3 more tabs and changes headings to h1 to be consistent with older tabs. It has also been suggested on another tab that this is preferrable for screen readers. Note: Modification log was left out for now, as this is also used in tools. To test: - Activate ILL (ILLModule pref) - Activate discharges (UseDischarge pref) - Go to any patron account, tab through the tabs... - Verify that discharge, purchase suggestions and ill requests are missing the toolbar - Apply patch - Verify that the toolbar now appears on these pages and works correctly - Also veriy that the headings are now consistently h1 on all pages Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1b9fd03f17cc1d99ea0960173be87ae33d76df40) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt | 6 ++++-- koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt | 5 ++++- .../intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt | 3 ++- koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt | 2 +- 5 files changed, 12 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 20:23:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 18:23:34 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-61-g79da96c9d2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 79da96c9d204c62aaed3ea3df6a91577c382f649 (commit) from 1beb5860f605f86eea6f1f552ea09569e0ed1234 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 79da96c9d204c62aaed3ea3df6a91577c382f649 Author: Katrin Fischer Date: Mon Apr 13 21:45:22 2020 +0000 Bug 13557: Add hint for on-site checkouts to list of current checkouts in OPAC In the list of checkouts it's currently not possible for the patront or tell the difference between normal checkouts (item is at home with them) and on-site checouts (items remained at the library). This patch adds a hint to the list of checkouts to allow differentiating these kinds of checkouts. To test: - In your patron account, have multiple checkouts, some on-site, some others, overdue items, etc. - Go to: OPAC > your summary > Checked out - Verify that there is no hint for the on-site checkouts - Apply patch - Check again, there should now be a note The note also has a class, so would be easy to be hidden or formatted differently: class="onsite_checkout". Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 09b527d717be485b1e4de39a0877ac6d0050a40a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 20:36:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 18:36:13 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-62-g896f4bcf24 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 896f4bcf24b9f4ccc4aaeeb84eb86f2f84242352 (commit) from 79da96c9d204c62aaed3ea3df6a91577c382f649 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 896f4bcf24b9f4ccc4aaeeb84eb86f2f84242352 Author: Nick Clemens Date: Mon Apr 20 18:41:37 2020 +0000 Bug 25223: Make join of aqbasket and aqorders explicit This is simply a SQL change that makes things a bit easier to read and also prevents too much data being returned in a large system To test: 1 - Have some orders in your system in the ordered status 2 - Click the 'Ordered' amount for your budget from Acquisitions home 3 - Note the view of orders, possibly screen shot 4 - Apply patch 5 - Restart all the things 6 - Reload the ordered page 7 - Confirm nothing has changed Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 7d69c0f10c7cb6c8b11baf55f05256684cdb0966) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: acqui/ordered.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 20:40:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 18:40:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-63-gfbcc0b71d5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via fbcc0b71d597bdc96069213ebfb59fe60d7e9ed4 (commit) from 896f4bcf24b9f4ccc4aaeeb84eb86f2f84242352 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fbcc0b71d597bdc96069213ebfb59fe60d7e9ed4 Author: Phil Ringnalda Date: Sun Apr 19 02:37:49 2020 +0000 Bug 20501: Don't cut strings when unhighlighting in intranet search results When you click Unhighlight on the search results of a search in the staff client when the search terms contain the same word twice, like "ma ma", the highlighted words disappear, and don't reappear if you click Highlight. This patch makes the same change to the intranet copy of jquery.highlight-3.js that bug 5844 made to the OPAC copy. Test plan: 1) Without this patch, search in the intranet for ma ma and verify you have at least two matching records. 2) Notice that the Ma in Material type: Book is highlighted. 3) Click Unhighlight, and notice that it has become terial type: Book 4) Apply this patch, repeat the search with a shift+reload to reload the .js 5) Click Unhighlight, and verify that Material type: Book remains Material Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5810b72af96a032fcf3d41b39eb0ad582117d2c1) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.highlight-3.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 20:45:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 18:45:33 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-64-g5fb7e19c73 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5fb7e19c7311486a8777a3307c0a70ae9c6a6c51 (commit) from fbcc0b71d597bdc96069213ebfb59fe60d7e9ed4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5fb7e19c7311486a8777a3307c0a70ae9c6a6c51 Author: Jonathan Druart Date: Mon Apr 20 11:13:40 2020 +0200 Bug 25186: Fix accordion sections height in columns configuration page The height for each section was the height of the highest section. Now the height is set to the length of the section. Test plan: Go to Administration > Column configuration Open the sections and confirm that the height fits its content. QA: note that I guess "autoHeight: false" was meant to achieve that, but it does not exist in the API of the plugin. Signed-off-by: Owen Leonard Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 8641888fa3c2dd460a1cf62855dc65bc1448682c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 23:21:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 21:21:03 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-65-ga307d2143f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a307d2143f6dc4db9121f982015c1abdc346943c (commit) from 5fb7e19c7311486a8777a3307c0a70ae9c6a6c51 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a307d2143f6dc4db9121f982015c1abdc346943c Author: Andrew Fuerste-Henry Date: Tue Apr 21 17:41:29 2020 +0000 Bug 25224: Show large print format in search results XSLT To test: 1: find a bib with 008 type Book (Leader position 6 = 'a' and leader position 7 = 'm' -- use bib number 1 in master data) 2: set 008 position 23 to 'd' for large print 3: check your book record in opac and intranet search results, note that your change is not reflected in the "format" note in line with material type 4: find a bib with 008 type Continuing Resource (Leader position 6 = 'a' and leader position 7 = 's' -- use bib number 44 in master data) 5: set 008 position 23 to 'd' for large print 6: check your continuing resource record in opac and intranet search results, note that your change is not reflected in the "format" note in line with material type 7: apply patch, restart_all 8: reload search results from steps 3 and 6, confirm they now say "format: large print" Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ab5c115d088665b41d3ae03b57fb801f1a63aca3) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl | 3 +++ koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 3 +++ 2 files changed, 6 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 23:26:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 21:26:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-66-g6bbb4fc7c0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 6bbb4fc7c061839edb76f8ecee39f8fdb0732760 (commit) from a307d2143f6dc4db9121f982015c1abdc346943c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6bbb4fc7c061839edb76f8ecee39f8fdb0732760 Author: Owen Leonard Date: Fri Apr 24 11:49:21 2020 +0000 Bug 25274: Don't initialize DataTable if table isn't present This patch modifies the OPAC basket JavaScript so that a check is added for the existence of the "itemst" table. This avoids an error if the "More details" view is selected and hte "itemst" table isn't present. To reproduce the error, add some items to the OPAC cart and open the cart window. Open the JavaScript console in your browser and click the "More details" link. You'll see an error. To test, apply the patch and perform the same test as above. The error should not be present. Test that table sorting in the "brief" view words correctly. Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit 2c9e0ac020c99fbcecfe53e6f5588ce2ece4a1fa) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 41 +++++++++++----------- 1 file changed, 21 insertions(+), 20 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 23:29:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 21:29:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-67-g0fec1317e9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0fec1317e9c3ff028141ac784c03a83850ac8772 (commit) from 6bbb4fc7c061839edb76f8ecee39f8fdb0732760 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0fec1317e9c3ff028141ac784c03a83850ac8772 Author: Katrin Fischer Date: Sun Apr 12 03:19:03 2020 +0000 Bug 21927: Acq - Add blank values in pull downs of mandatory item subfields This is the same fix as on bug 14662, which fixed the behaviour in cataloguing, but for the item form in acquisitions. The code assumes that if a subfield is marked as mandatory, there should be no empty entry in the pull downs. This assumption is not correct, as it leads to the first entry of the pull down being preselected if there is no default set. As the field can never be 'unset', there will never be a 'required' warning. Furthermore, it might be counterproductive to use mandatory fields, as it might be easily forgotten to change the preselected value and those mistakes will be hard to find. Correct behaviour would be to preselect the empty value when there is no default. This means on saving the item an error message is triggered and the cataloger is forced to set the value. To test: - This is best tested with an ACQ framework, but default can be used when no ACQ framework was created. - In your MARC bibliographic framework: - In 952 make itemtype, classification source and some other pull downs like location or collection mandatory and set them to visibel if needed - Create a new basket with 'items created while ordering' - Add a new order, an existing record with 942$c set will work best - Add items for your order line - Verify that the first value of each pull down is preselected, there is no way to trigger the 'required' error - Apply patch - Add a new order line - Verify that classification source is preselected according to the DefaultClassificationSource system preference (try unsetting it later) - Verify all mandatory fields can be set to empty - Verify that you can't save before correctly setting them - Change your frameworks and set a default for itemtype (Ex: BK) and another mandatory and non-mandatory field of your choice - Add a new order line and item and verify the defaults are selected Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit 77a59b5b3ab8a8870ca9bf9842d1ad30104a05d3) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 23:31:00 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 21:31:00 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-68-g845dc6fc2a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 845dc6fc2aa4140f24b2f09cbe468046edfa2551 (commit) from 0fec1317e9c3ff028141ac784c03a83850ac8772 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 845dc6fc2aa4140f24b2f09cbe468046edfa2551 Author: Lucas Gass Date: Tue Apr 21 20:11:17 2020 +0000 Bug 24957: OpenLibrarySearch shouldnt display if nothing is returned TO TEST: 1. Turn on OpenLibrarySearch 2. Do an OPAC search that returns results that have results with Open Library results and some that do not. 3. Notice results that return nothing simpliy say "Open Library:" with nothing afterwards. 4. Some results return a png from OpenLibrary or "Not found" 5. Apply patch and look at records again. 6. The results that return nothing for OpenLibrary API should now to hidden. Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit a656ccf5376287c9a572e2db4771dae12a4c1afa) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 23:33:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 21:33:05 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-69-g2992669c8b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 2992669c8ba3d7499491608bf629e25fd1a6481d (commit) from 845dc6fc2aa4140f24b2f09cbe468046edfa2551 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2992669c8ba3d7499491608bf629e25fd1a6481d Author: Owen Leonard Date: Mon Apr 20 11:38:41 2020 +0000 Bug 25211: Add missing share icon to OPAC lists page This patch adds a Font Awesome icon to the "Share" links on the list of lists in the OPAC. To test, apply the patch and log in to the OPAC as a user who has one or more private lists. - Go to Lists -> Your lists - In the table of your lists, each list should have a "Share" link with an icon. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit 66c0ab283a364f34ca470938b847366d3117153a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 23:41:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 21:41:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-70-gfe19f528ab Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via fe19f528ab06f72512964f929741aa7fee0e31e4 (commit) from 2992669c8ba3d7499491608bf629e25fd1a6481d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fe19f528ab06f72512964f929741aa7fee0e31e4 Author: Lucas Gass Date: Tue Apr 21 21:33:03 2020 +0000 Bug 25233: Staff XSLT material type label "Book" should be "Text" This patch makes the staff client XSLT stylesheets consistent with the ones for the OPAC, it also makes consitent the use of 'Text' when the leader6 = 't' TO TEST: 1. Have a record with leader06 = 'a' and leader07 = 'c' 'd' or 'm'. 2. Check the staff client results and details page. See that the material type label says "Book" 3. Check the OPAC client results and details page. See that the materila type label says "Text" 4. Apply patch. 5. See that both staff client and OPAC results/details all now say "Text" 6. Set the leader6 = 't' and make sure that is says 'Text' on both the staff client and OPAC Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 9018cefc25d330355778f56159459a9f4abcf30a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 14 23:44:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 21:44:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-71-g693069ea1e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 693069ea1e73a3bc421c0a83918da03ec0ace6cc (commit) from fe19f528ab06f72512964f929741aa7fee0e31e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 693069ea1e73a3bc421c0a83918da03ec0ace6cc Author: Joseph Sikowitz Date: Sat Apr 18 16:06:05 2020 -0400 Bug 24750: Instructor Search Results Adds regex to the split() of the passed parameters to improve searching. Test plan 1. Go to Course Reserves module. 2. Press New course button. 3. Make active the instructor search box. 4. Start typing the last name of a patron that exists in your database. 5. At the end of the last name type ", " and try to add a first name. 6. The search should fail. 7. Apply the patch. 8. Follow steps 1-5 again. 9. You should now be able to search using the following methods 9a. surname, firstname 9b. firstname surname Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 85339f38a096c63a9794cab424b4b4d4ce94e291) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: circ/ysearch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 00:21:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 22:21:58 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-77-gdc9b62f8fd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via dc9b62f8fdf8afde4c4986ce9993c0590ca09bae (commit) via bd120a13915499a1dbf813f2221c7a24991fa15e (commit) via 198c7067bd49f2ccfef0a2a4291a960f42d9378e (commit) via 64b72517a03a352648fcd914fb9666f3875343f6 (commit) via b12a6ca9cc86508ba92ff74f61ffd983b7d3daa4 (commit) via 6bef3c3c6987b8ebdc2820a9fdabfb5b34ba2b4b (commit) from 693069ea1e73a3bc421c0a83918da03ec0ace6cc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dc9b62f8fdf8afde4c4986ce9993c0590ca09bae Author: Lucas Gass Date: Thu May 14 21:49:28 2020 +0000 Bug 23081: DBRev 19.05.10.002 Signed-off-by: Lucas Gass commit bd120a13915499a1dbf813f2221c7a24991fa15e Author: Jonathan Druart Date: Mon May 11 16:04:27 2020 +0200 Bug 23081: [19.11.x] Set items.issues to 0 if not provided (AddItem) In master it has been replaced by Koha::Object->store and we deal with the default value. Signed-off-by: Joy Nelson (cherry picked from commit 5a2506a849b3848045482987e166da09e2d72d43) Signed-off-by: Lucas Gass commit 198c7067bd49f2ccfef0a2a4291a960f42d9378e Author: Jonathan Druart Date: Mon Apr 27 11:55:15 2020 +0200 Bug 23081: Adjust tests Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 31dd98d6d418c0f74436a1241dd664f55e5f3d9d) Signed-off-by: Lucas Gass commit 64b72517a03a352648fcd914fb9666f3875343f6 Author: Jonathan Druart Date: Mon Apr 27 11:51:35 2020 +0200 Bug 23081: Revert "Bug 24443: Consider NULL as 0 for issues in items search" This reverts commit 80f1374f262544a750b5d81a7d9605c8708c53b1. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1aefaf9bca2022c806e07ba1cbd170336e85807a) Signed-off-by: Lucas Gass commit b12a6ca9cc86508ba92ff74f61ffd983b7d3daa4 Author: Andrew Fuerste-Henry Date: Sun Apr 26 23:53:26 2020 +0000 Bug 23081: atomicupdate for change to existing installs Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c760d0830054ccf609ea8b78eb8869338d8e288e) Signed-off-by: Lucas Gass commit 6bef3c3c6987b8ebdc2820a9fdabfb5b34ba2b4b Author: Andrew Fuerste-Henry Date: Sun Apr 26 23:51:25 2020 +0000 Bug 23081: set default to 0 for items.issues and deleteditems.issues To test: - save and run this sql query in reports: select sum(if(issues is null,1,0)),sum(if(issues=0,1,0)) from items - you should see a lot of nulls and no zeros - apply patch - updatedatabase - re-run your query and see that your nulls have changed to zeros - create a new item - rerun your query and see your new item is counted in the zeros, not the nulls Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 02896efdf347adbfa0cb262c9b7d46e11dbe4866) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 5 +---- Koha.pm | 2 +- Koha/Schema/Result/Deleteditem.pm | 8 ++++++-- Koha/Schema/Result/Item.pm | 8 ++++++-- installer/data/mysql/kohastructure.sql | 4 ++-- installer/data/mysql/updatedatabase.pl | 10 ++++++++++ t/db_dependent/Items.t | 4 ++-- 7 files changed, 28 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 00:45:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 22:45:51 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-78-ga3569d3217 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a3569d321705afe0e8f75ce2af7db2f0b29ced15 (commit) from dc9b62f8fdf8afde4c4986ce9993c0590ca09bae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a3569d321705afe0e8f75ce2af7db2f0b29ced15 Author: Katrin Fischer Date: Tue Apr 14 10:45:01 2020 +0000 Bug 17232: Make sure all fields are copies when creating a new framework from another Some digging revealed that when you create a new framework and use an old framework as the base, some information would not be copied to the new framework as they were missing from the SQL command used here. - Tag: Important - Subfield: - Important - Default value - Max length - Is a URL - Link To test: - Pick one of the existing frameworks and change the fields listed above. Take note of what you changed. - Create a new framework - Go to "Marc structure" of the new framework - You are offered the option to copy an existing framework - Use your prepared framework - Verify the fields weren't copied - your config was lost - Apply patch - Create another new framework - Repeat the duplication and tests - Verify that now all fields have been copied correctly Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 9cd83a9c4ea6d5499e516270e2b5e70477bb13f8) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: admin/marctagstructure.pl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 00:57:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 22:57:47 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-79-ga97d18534c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a97d18534c445add7d3c7edef9ee49403915a160 (commit) from a3569d321705afe0e8f75ce2af7db2f0b29ced15 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a97d18534c445add7d3c7edef9ee49403915a160 Author: David Cook Date: Tue Apr 28 12:00:15 2020 +1000 Bug 25300: Fix typo in "Edit details" for expiring/expired patron This patch removes a typo in the argument to the "op" parameter for the "Edit details" link when editing an expiring/expired patron on the Details page. Test plan: 0. Do not apply patch yet 1. Create patron 2. Set expiry date to 3 days from now 3. Go to Details tab in patron record 4. Click "Edit details" in "Library use" section 5. Note the form is blank and has no patron data in it 6. Apply the patch 7. Reload the Details page in patron record 8. Click "Edit details" in "Library use" section 9. Note the form now contains your patron data and will work for editing the details Signed-off-by: Frédéric Demians Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1be0d7500cac91457d8f69b437706630d5339a2d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 01:00:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 23:00:38 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-80-g6a56ac1cfc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 6a56ac1cfca8c6fccab96b79541ef642146db0ab (commit) from a97d18534c445add7d3c7edef9ee49403915a160 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6a56ac1cfca8c6fccab96b79541ef642146db0ab Author: David Cook Date: Tue Apr 28 11:40:23 2020 +1000 Bug 25299: Show soon to expire patron date This patch fixes the call to show the patron expiry date on the Details page when the patron is soon to expire. Test plan: 0. Do not apply patch yet 1. Create a patron 2. Set patron's date expiry to 3 days from today 3. Go to Details tab 4. Note message "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5. Apply patch 4. Note message pattern "Expiration: Patron's card will expire soon. Patron's card expires on XX/XX/XXXX Renew or Edit details" Signed-off-by: Frédéric Demians Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5a8067ff09f9679ff836695f3a01619b3c9b763f) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 01:01:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 May 2020 23:01:52 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-81-g1a0bd2c263 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1a0bd2c2636c9d4eae3f1c612ab0bd76a2f1b5ab (commit) from 6a56ac1cfca8c6fccab96b79541ef642146db0ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1a0bd2c2636c9d4eae3f1c612ab0bd76a2f1b5ab Author: Lucas Gass Date: Wed Apr 15 21:42:36 2020 +0000 Bug 25072: Fix details.tt print CSS TO TEST: -Search for something in the catalog and go to the details page. -Try to print either for the Print button in Koha or File->Print... -Notice the large amount of whitespace on the left -Apply patch -Reload detaials page and attempt to print again. -No whitespace on left side Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 32f43c1bdf10d5bce2472e2bfc42055065a25aec) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/css/print.css | 5 +++++ 1 file changed, 5 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 11:26:09 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 09:26:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2213-g883b36da92 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 883b36da925c25dff38a435f648491dbafb1a1a7 (commit) via 741fa0b0065cf3309d02dc709292d71405f2260a (commit) via 9ed284c0a49c280daf217240e03142ac701e8e06 (commit) via 29f797b9808f513ca4ba662729f6a8a81edcda68 (commit) via b720285bdba315944e303ef166e5c89c4c591ddf (commit) via 23dd6651f83e42200185130bd340520ea2e945f1 (commit) via d69ab6ee9185d124e8d282608e279d8590a6180f (commit) via 0524f3b6d6a96e9016802a2a4d4ea3a27ef0d2fa (commit) via 009007b8092d2973e66cbabd782613ee72265763 (commit) via a81b9d3fadd5604cd2cabf44455d563b0f53e7a7 (commit) via 2a216e206c13585308fbfb8897f78f9672bd81e0 (commit) from 7e720e7e820408e7e2b7b03f65cbdd1435a2d031 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 883b36da925c25dff38a435f648491dbafb1a1a7 Author: Kyle M Hall Date: Tue May 12 10:49:51 2020 -0400 Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks! Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 741fa0b0065cf3309d02dc709292d71405f2260a Author: Jonathan Druart Date: Wed May 13 13:05:48 2020 +0200 Bug 25480: Don't hide apache error and display incorrect error When searching if some apache mod are enable we are hiding the error (2> /dev/null) and display an error about the (guessed) missing module. It can lead to wrong tracks, let display the original apache error if there is one. This is linked with https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/119 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 9ed284c0a49c280daf217240e03142ac701e8e06 Author: Nick Clemens Date: Mon Apr 13 15:51:36 2020 +0000 Bug 23403: Catch other cases of ->{patron} Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 29f797b9808f513ca4ba662729f6a8a81edcda68 Author: Jonathan Druart Date: Mon Mar 23 15:57:14 2020 +0100 Bug 23403: List borrowernumber in the ILS::Patron fields Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit b720285bdba315944e303ef166e5c89c4c591ddf Author: Kyle M Hall Date: Mon Mar 23 08:52:58 2020 -0400 Bug 23403: Fix whitespace Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 23dd6651f83e42200185130bd340520ea2e945f1 Author: Jonathan Druart Date: Thu Nov 21 18:39:15 2019 +0100 Bug 23403: Remove cardnumber from SIP == Test plan == 1 - Have two patrons with userids and no cardnumber 2 - Note which of these has the higher borrower number 3 - Use the SIP cli emulator to connect and checkout a book to the patron with higher borrowernumber See example after 4 - Note the book may checkout to the wrong patron! 5 - Apply patch 6 - Checkout to both patrons via sip 7 - The patrons get the correct checkouts === SIP CLI emulator === ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 \ -l CPL --patron 23529001000463 -m checkout --item 39999000001259 translation: via the koha user term1, checkout item 39999000001259 to patron 23529001000463 Signed-off-by: Bouzid Fergani Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit d69ab6ee9185d124e8d282608e279d8590a6180f Author: Tomas Cohen Arazi Date: Mon May 11 10:10:39 2020 -0300 Bug 24458: Use the ViewPolicy filter on search results This patch implements the use of the ViewPolicy record processor filter inside C4::Search::searchResults. The idea is that the $record_processor is instantiated once and reused inside the loop. This leaves options for further optimizations I will do on a follow-up bug. The filter is applied to the MARC data before it is passed to the XSLT processor. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: This is not implemented, tests fail 3. Apply this patch 4. Repeat 2 5. Feel the joy in your body from a long standing bug being solved 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 0524f3b6d6a96e9016802a2a4d4ea3a27ef0d2fa Author: Tomas Cohen Arazi Date: Mon May 11 10:08:36 2020 -0300 Bug 24458: Regression tests This patch introduces tests for searchResults. The idea is to set a subfield as hidden in OPAC and another on the staff interface, and see if searchResults honours this on the XSLTResultsRecord contents. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: This is not really implemented Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 009007b8092d2973e66cbabd782613ee72265763 Author: Tomas Cohen Arazi Date: Tue May 12 09:09:22 2020 -0300 Bug 25416: (follow-up) Remove useless use statement Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit a81b9d3fadd5604cd2cabf44455d563b0f53e7a7 Author: Tomas Cohen Arazi Date: Mon May 11 08:38:49 2020 -0300 Bug 25416: Unit tests This patch adds tests for the new 'feature': i.e. searchResults passes the added $xslt_variables to the XSLTParse4Display method. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 2a216e206c13585308fbfb8897f78f9672bd81e0 Author: Tomas Cohen Arazi Date: Thu May 7 14:23:40 2020 -0300 Bug 25416: Let OPAC XSLTs know if the context is an anonymous session This patch makes use of the 'variables' parameter in XSLTParse4Display method in the different places that it is used in the OPAC. It does by passing this parameter with anonymous_session => 1|0 The value will depend on the output from get_template_and_user (i.e. if there's a returned borrowernumber). A special case takes place in search results, as the call to XSLTParse4Display happens in C4::Search::searchResults. So a new parameter 'xslt_variables' is added to it. To test: 1. Apply the [DO NOT PUSH] patch 2. Open the OPAC in your browser 3. Try detail pages, search results, tags and lists/shelves pages with or without an active session => FAIL: It always says (somewhere) 'Anonymous session: Yes' 4. Apply this patch, restart_all 5. Repeat 3 => SUCCESS: It will tell the Yes/No correctly regarding anonymous sessions! 6. Sign off :-D Sponsored-by: Universidad ORT Uruguay Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS.pm | 16 +++--- C4/SIP/ILS/Item.pm | 8 +-- C4/SIP/ILS/Patron.pm | 1 + C4/SIP/ILS/Transaction/Checkout.pm | 44 ++++++++-------- C4/SIP/ILS/Transaction/Hold.pm | 39 +++++--------- C4/SIP/ILS/Transaction/Renew.pm | 3 +- C4/Search.pm | 15 +++++- debian/scripts/koha-create | 12 ++--- .../intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- opac/opac-detail.pl | 11 ++-- opac/opac-search.pl | 6 ++- opac/opac-shelves.pl | 14 +++-- opac/opac-tags.pl | 12 +++-- t/db_dependent/Search.t | 60 +++++++++++++++++++++- 14 files changed, 158 insertions(+), 85 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 11:35:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 09:35:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2214-gf96a105e87 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f96a105e872fdfda5fa67753663b1d80fd2c4c5b (commit) from 883b36da925c25dff38a435f648491dbafb1a1a7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f96a105e872fdfda5fa67753663b1d80fd2c4c5b Author: Martin Renvoize Date: Thu Mar 26 16:01:37 2020 +0000 Bug 24994: Correct DB Updates Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 196 ++++++++++++++++++--------------- 1 file changed, 105 insertions(+), 91 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 14:15:08 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 12:15:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2217-g2a031b352c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2a031b352c90c3c79cfd0c7c0e132971a82406fb (commit) via f66e253312fc2777cf495a19a61a60867f661d09 (commit) via 810e761660d7424b097a6c6f1d1211513889fa09 (commit) from f96a105e872fdfda5fa67753663b1d80fd2c4c5b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2a031b352c90c3c79cfd0c7c0e132971a82406fb Author: Nick Clemens Date: Thu May 14 10:42:06 2020 +0000 Bug 25482: Explicitly set macros as not shard during tests Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit f66e253312fc2777cf495a19a61a60867f661d09 Author: Tomas Cohen Arazi Date: Wed May 13 19:34:30 2020 -0300 Bug 25482: Fix tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 810e761660d7424b097a6c6f1d1211513889fa09 Author: Tomas Cohen Arazi Date: Wed May 13 19:07:17 2020 -0300 Bug 25482: Wrong permissions specification for adv editor macros The current permissions are defined as a hash, with a duplicate key. This is generally invalid, but Debian 9's Mojolicious::Plugin::OpenAPI lets it go through, even though the results are, random? This patch sets the required permissions right, and following the haspermissions() syntax correctly. Tests for searching macros are not passing. Still trying to figure. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1/AdvancedEditorMacro.pm | 2 -- api/v1/swagger/paths/advancededitormacros.json | 18 ++++++++++++------ t/db_dependent/api/v1/advanced_editor_macros.t | 16 +++++++++------- 3 files changed, 21 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 17:59:19 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 15:59:19 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-82-g9be62c1c43 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 9be62c1c43b2793cb2faa58922d01f24aede862c (commit) from 1a0bd2c2636c9d4eae3f1c612ab0bd76a2f1b5ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9be62c1c43b2793cb2faa58922d01f24aede862c Author: Nick Clemens Date: Tue Apr 21 17:30:00 2020 +0000 Bug 25231: Rename button instead of alert/confirm when replacing record This test plan applies to the basic editor only To test: 1 - Edit an existing record 2 - Click 'Z3950 Search' 3 - Note the confirmation box 4 - Add a new record 5 - Click 'Z3950 Search' 6 - Note no popup 7 - Apply patch 8 - Edit existing record 9 - Note button now says 'Replace record via Z3950 search' 10 - Add a new blank record 11 - Note the button says 'Z3950 search' 12 - Confirm editing/saving/replacing works as in the past Signed-off-by: Phil Ringnalda Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ac3a39bd48be70e8ceadcd42fe0a1086a554d1fc) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/cataloguing/addbiblio.tt | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 18:04:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 16:04:23 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-84-g3f4f576ba0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 3f4f576ba0195010d42d059e83528f8cf085acfd (commit) via ace2e944c483db7ac2a83a294b9bb43d63410b71 (commit) from 9be62c1c43b2793cb2faa58922d01f24aede862c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3f4f576ba0195010d42d059e83528f8cf085acfd Author: Jonathan Druart Date: Fri Feb 21 16:07:23 2020 +0100 Bug 22828: Add tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b5add0dd0556f9468708595860c2833d34eeb433) Signed-off-by: Lucas Gass commit ace2e944c483db7ac2a83a294b9bb43d63410b71 Author: Nick Clemens Date: Thu May 2 11:27:27 2019 +0000 Bug 22828: Elasticsearch - display errors encountered during indexing on the command line To test: 1 - Use the Koha sample data, or insert a blank 245$b into a record (easiest way is using advanced cataloging editor 2 - Reindex elasticsearch 3 - Check the ES count on the about page 4 - Check the count in the DB (SELECT count(*) FROM biblio) 5 - They don't match! 6 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 7 - No errors indicated 8 - Apply patch 9 - perl misc/search_tools/rebuild_elastic_search.pl -v 10 - You should be notified of an error 11 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 12 - You should be notified of the specific biblio with an error and a (somewhat) readable reason 13 - perl misc/search_tools/rebuild_elastic_search.pl 14 - No output Signed-off-by: Ere Maijala Signed-off-by: Séverine QUEUNE Signed-off-by: Bouzid Fergani Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5a0a350ed7d9e1fa5e93500b2eb92ae33589de4a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/Indexer.pm | 6 ++--- misc/search_tools/rebuild_elasticsearch.pl | 30 ++++++++++++++++++++-- .../Koha/SearchEngine/Elasticsearch/Indexer.t | 7 +++-- 3 files changed, 36 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 18:25:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 16:25:22 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-86-g5872bc5a5b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5872bc5a5b8789e5695db843577156bfc06ff64d (commit) via 2715cd95c0bd92d31aae07c3772258db9579666f (commit) from 3f4f576ba0195010d42d059e83528f8cf085acfd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5872bc5a5b8789e5695db843577156bfc06ff64d Author: Josef Moravec Date: Thu Apr 30 11:29:56 2020 +0000 Bug 24043: (QA follow-up) Fix another TypeError when retrieving status name Test plan: 1) Apply first patch, and have the same requests as in previous patch test plan 2) Load ill requests list 2a) You can see another TypeError in console 2b) You can notice, the Placed on and Updated on columns have prepended another columns with unformatted dates and without header label 3) Apply this patch 4) Reload page (be sure it is not loaded from cache - Ctrl+F5) 5) Errors from 2a and 2b are gone Signed-off-by: Josef Moravec Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 243e94598e5f3d84b7b53b67c5bc38a1eecee5e0) Signed-off-by: Lucas Gass commit 2715cd95c0bd92d31aae07c3772258db9579666f Author: Andrew Isherwood Date: Mon Jan 13 10:18:19 2020 +0000 Bug 24043: Fix retrieval of of status name This patch modifies the way in which a request's status name is retrieved. I think the previous way it was done (which can never have worked properly) must have come from a time when we weren't embedding the request's backend capabilities in each request. So now we can just use the current row. Test plan: 1. *Before applying the patch*: 2. Ensure you have at least two requests, from two different backends. One of the backends you are using must have a possible status that doesn't exist in the other. For example, the BLDSS backend has a status of STAT, that doesn't not exist in any other backends. 3. Ensure that the request who's backend has the unique status is *not* the first request in the returned list. 4. Load the "View ILL requests" page 5. Observe that the page JS fails with a "Cannot read property 'name' of undefined" error 6. Apply the patch 7. Reload the page (maybe doing a hard reload to ensure the JS is not cached) 8. TEST: Observe that the error no longer occurs and the requests all have their statuses displayed correctly. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 40f4e9437cb012f93de7ac3b66bcb649617f13f5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 19:58:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 17:58:05 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-87-gd6b29be58e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via d6b29be58e600eb969a2c058a06c88029e32d1ae (commit) from 5872bc5a5b8789e5695db843577156bfc06ff64d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d6b29be58e600eb969a2c058a06c88029e32d1ae Author: Martin Renvoize Date: Wed Dec 11 11:53:51 2019 +0000 Bug 15751: Add ModDateLastSeen to ProcessOfflineReturn Test plan: 1) Before the patch when one checks in something using the KOCT the last seen date is not updated. 2) After the patch when one checks in something using the KOCT the last seen date is updated. Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 47414f97c1358da9cd79e1e884ab1f9d74516014) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 20:04:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 18:04:21 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-88-g7826562073 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 782656207353e72a15a185b9e06578d13747d875 (commit) from d6b29be58e600eb969a2c058a06c88029e32d1ae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 782656207353e72a15a185b9e06578d13747d875 Author: David Roberts Date: Mon Apr 6 23:42:19 2020 +0000 Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a This patch makes the subfield i display before subfield a in the 246 and 730 fields To test: 1) Create a bibliographic record with data in several subfields in tags 246 and 730. 2) See that subfield i displays at the end of the field in the 246 field, and probably not at all in the 730 field. Check in both the OPAC and staff client 3) Apply the patch. 4) Check your bib record again in both clients. Subfield i should now display before subfield a. Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 8dea59bba0c620da41a47698e2142e61f1dba3f9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 15 ++++++++++++--- .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 15 ++++++++++++--- 2 files changed, 24 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 20:12:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 18:12:46 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-89-gcacaebca32 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via cacaebca32de1baa70a0e0ca57d3618a900d5046 (commit) from 782656207353e72a15a185b9e06578d13747d875 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cacaebca32de1baa70a0e0ca57d3618a900d5046 Author: Kyle M Hall Date: Fri Apr 10 06:58:43 2020 -0400 Bug 25107: Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType At some point some calls to maybe_add got an extra $server var in their parameter lists. This doubled parameter does nothing and should be removed. Test Plan: No change in behavior should be noted Signed-off-by: Frédéric Demians Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 6e53814c58be68bf7392395896c7a66a40d12bd1) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/SIP/Sip/MsgType.pm | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 20:26:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 18:26:51 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-91-gc8aaa47e82 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via c8aaa47e828dce6a9632dac671899aadff5a640d (commit) via 0283892d44189b9339f8e4eb230d936d329c9ee8 (commit) from cacaebca32de1baa70a0e0ca57d3618a900d5046 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c8aaa47e828dce6a9632dac671899aadff5a640d Author: Owen Leonard Date: Wed Apr 29 17:57:44 2020 +0000 Bug 21565: (follow-up) Make confirmation buttons more detailed This patch updates the confirmation buttons to be more specific about what each one does. My concern was that it wasn't clear that "No" meant "No receipt" and not "Cancel logging out." The patch also updates the modal confirmation code so that the modal body is removed if no message is passed for it. To test, apply the patch and repeat the previous test plan. When you click "Finish" you should have the options "Print receipt and end session" and "End session." Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit e4e31117e7dcdc769f6c94553165202c49c7e0ae) Signed-off-by: Lucas Gass commit 0283892d44189b9339f8e4eb230d936d329c9ee8 Author: Lucas Gass Date: Fri Apr 24 18:39:02 2020 +0000 Bug 21565: Add modal to SCO confirm This patch uses the confirmModal framework to add a modal confirm to SCO Finish. TO TEST: 1. Enable SCO and go to /cgi-bin/koha/sco/sco-main.pl. Make sure SelfCheckReceiptPrompt is set to 'show' 2. Login and click 'Finish' to see the old print alert box. 3. Apply patch and repeat steps 1 and 2. 4. Make sure the modal works for confirming and denying a receipt. Checkout some items and make sure everything still functions the same. 5. Make sure when printing a receipt that the print dialog automatally shows 6. Set SelfCheckReceiptPrompt to 'Don't show' and confirm behavior is acceptable. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize (cherry picked from commit b325831210dacbb0857f843670eb26b0c5268e6d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 17 +++++++++++------ koha-tmpl/opac-tmpl/bootstrap/js/global.js | 8 ++++++-- 2 files changed, 17 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 20:34:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 18:34:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-92-g5a8cd7fc0d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5a8cd7fc0d8acb1b0b01814442f6845e6df44ac2 (commit) from c8aaa47e828dce6a9632dac671899aadff5a640d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5a8cd7fc0d8acb1b0b01814442f6845e6df44ac2 Author: Nick Clemens Date: Wed Apr 22 12:11:53 2020 +0000 Bug 25247: Only convert data ot objects when displaying on screen To test: 1 - Modify a patron 2 - Circulate some items to the patron 3 - Click 'Modification log' 4 - Verify you see your actions 5 - Under 'Output' select 'To a file' 6 - Save the output to a file 7 - View the file 8 - Not you have references ot objects in stead of patron/item data 9 - Apply patch 10 - Repeat 11 - Note viewing on screen has not changed 12 - Note exporting to file inlcudes borrower/item numbers and not references 13 - Sign off Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 18f3661179e6a556fc1c39a8841edb99e4e97cd9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: tools/viewlog.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 20:39:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 18:39:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-93-gc8da8f1b64 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via c8da8f1b64776134402d76100e2b88c424283541 (commit) from 5a8cd7fc0d8acb1b0b01814442f6845e6df44ac2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c8da8f1b64776134402d76100e2b88c424283541 Author: Owen Leonard Date: Mon Apr 27 13:20:23 2020 +0000 Bug 22515: Improve logic determining how to show OPAC suggestions This patch makes changes to the OPAC suggestions view so that the logic around logged in users and the OPACViewOthersSuggestions preference is more specific. To reproduce the bug you should have pending purchase susggestions in your system from more than one patron. 1. Set the OPACViewOthersSuggestions preference to "Show." 2. Log in to the OPAC as a user who has not submitted any suggestions. 3. Follow the link to the purchase suggestions page from the menu under the search bar. 4. The page will say that there are no purchase suggestions. 5. Add "?suggested_by_anyone=1" to the end of the page URL. 6. You should see suggestions from other users. To test, apply the patch and repeat steps 2-3 above. The suggestions page should show other patrons' suggestions. Test with different combinations of factors: - Logged in user, OPACViewOthersSuggestions off - No logged in user, OPACViewOthersSuggestions on - No logged in user, OPACViewOthersSuggestions off Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 93f37f3a03fc1205b3c3cb54e650081dc3dd79ea) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 6 ++---- .../opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 18 +++++++++++++++--- 2 files changed, 17 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 22:26:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 20:26:40 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-97-g8d1412aff4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8d1412aff4fb880018c3081cc00d9707df2cc635 (commit) via 26e550332e2af0e41656a6ec2634d21aaf1db3d8 (commit) via 7ba8d1752a8950556dd774c397bbaf3a1176ef89 (commit) via 6733535c52320679d517d88fabc71e74792beddf (commit) from c8da8f1b64776134402d76100e2b88c424283541 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d1412aff4fb880018c3081cc00d9707df2cc635 Author: Nick Clemens Date: Mon May 4 11:33:11 2020 +0000 Bug 25133: (follow-up) Move changes to timepicker.inc Witht the changes in calendar.inc there can be a js error where the timepicker is not included. Moving the changes to timepicker.inc should resolve this Note: in previous patches the amnames/pmnames were removed. It is possible they had no effect because they were declared in two files, so I have left them in timepicker.inc Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit f5c7e3fd76f3d08b7b7ed2090f4d822bd3f2e3de) Signed-off-by: Lucas Gass commit 26e550332e2af0e41656a6ec2634d21aaf1db3d8 Author: Nick Clemens Date: Tue Apr 21 12:06:09 2020 +0000 Bug 25133: (follow-up) Remove Names as they do no affect display In testing I couldn't make any changes to the names have an effect and everythign worked as expected without these lines Signed-off-by: Nick Clemens Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 7202498771468b9263474e1255039e3845da64c0) Signed-off-by: Lucas Gass commit 7ba8d1752a8950556dd774c397bbaf3a1176ef89 Author: Jonathan Druart Date: Mon Apr 20 10:59:55 2020 +0200 Bug 25133: Handle 12hr format for dt_from_string Signed-off-by: Nick Clemens Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1adb28bc23b11e4c11b97f0524b829e840c70a74) Signed-off-by: Lucas Gass commit 6733535c52320679d517d88fabc71e74792beddf Author: Jonathan Druart Date: Fri Apr 17 12:11:25 2020 +0200 Bug 25133: Fix time part of due date for 12hr With Timeformat system preference set to 12 hours format: Prior to 19.05.08, when due date was specified at checkout, the time in the box would show in 24hr format (e.g. 15:59) while the due date in the patron's checkouts would show in 12hr format (e.g. 3:59 PM). After 19.05.08, the format in the specify a due date box shows in 24hr format and the due date in 12hr format (in patron checkouts) as before. But when checking out multiple items using the specify due date option for the session, the time changes from PM to AM. To test: - Check out an item with specified due date 15:50 PM - Check out a second item in same transaction - Verify date changed to AM - Apply patch - Repeat - Verify this time the date is kept as set Signed-off-by: Nick Clemens Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1973003eaafd4cc7f7040cc66f946751eb2bacc3) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/DateUtils.pm | 9 +++++++++ circ/circulation.pl | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/timepicker.inc | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 8 ++++++++ t/DateUtils.t | 13 ++++++++++++- 5 files changed, 31 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 22:31:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 20:31:21 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-98-g382c9b4603 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 382c9b4603b16e222e3de8553c7a9074b6943a5c (commit) from 8d1412aff4fb880018c3081cc00d9707df2cc635 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 382c9b4603b16e222e3de8553c7a9074b6943a5c Author: Andrew Fuerste-Henry Date: Thu Apr 30 19:35:51 2020 +0000 Bug 25335: group by authorised_value in addbiblio.pl To Test: 1- Edit your default framework, connect any subfield outside of the 952 to an authorised value (for example, connect the 942$n to the Yes_No auth value) 2 - Find a record in that framework 3 - Edit the record and find your subfield 4 - The subfield shows a dropdown with no contents 5 - check plack log, see "DBD::mysql::st execute failed: 'koha_kohadev.authorised_values.authorised_value' isn't in GROUP BY " 6 - apply patch, restart all 7 - reload edit record page, see your auth value dropdown has contents Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit e49ecdedd87d8796da77adeaa9e864c43ca90763) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: cataloguing/addbiblio.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 22:34:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 20:34:21 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-100-g62e523a50f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 62e523a50f8e9e370e9b10c106e7af71cbe25976 (commit) via 78341c423d8a0e8c837b6817e94342f8fcf69138 (commit) from 382c9b4603b16e222e3de8553c7a9074b6943a5c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 62e523a50f8e9e370e9b10c106e7af71cbe25976 Author: Bernardo Gonzalez Kriegel Date: Sun May 3 19:19:21 2020 -0300 Bug 24636: (follow-up) - move 'by' into include file To ease correct translation. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit f46d88125d48fa21893f77f14584320dc3548a64) Signed-off-by: Lucas Gass commit 78341c423d8a0e8c837b6817e94342f8fcf69138 Author: Bernardo Gonzalez Kriegel Date: Tue Apr 28 21:21:09 2020 -0300 Bug 24636: translate planning sections This patch adds a new inc file to process and translate plannig sections To test: 1) Apply patch 2) Create new language files (cd misc/translator; ./translate create xx-YY) 3) Verify new file is taken into account in translation files egrep -n budget_planning misc/translator/xx-YY*.po check new strings in staff-prog file 4) Go to Administration > Budgets > Founds > Planning select different options, check page title and 'Planning for...' phrase 5) Translate strings, install new language, enable it, verify the text change with options like point 4) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b4c06e171730e1ed5d9b317670f25f01744cf742) ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/budget_planning.inc | 7 +++++++ koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt | 5 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/budget_planning.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 22:45:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 20:45:01 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-101-g341fa8a59d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 341fa8a59ddba280e599ba2ea857b9025c4cb69f (commit) from 62e523a50f8e9e370e9b10c106e7af71cbe25976 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 341fa8a59ddba280e599ba2ea857b9025c4cb69f Author: Owen Leonard Date: Fri May 1 13:23:12 2020 +0000 Bug 24522: Show alert when trying to add nothing to a list in staff This patch modifies the JavaScript which handles the process of adding items to a list in the staff client. Error-handling is added in the case when a set of biblionumbers hasn't been passed to the vShelf function. To test, apply the patch and perform a catalog search in the staff client. On the search results page, select any list from the "Add to list" menu at the top of the search results table without checking any checkboxes. You should get an alert, "No item was selected." Also test that adding to a list works correctly after selecting one or more titles. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 9be2c20c461382ebb6ebed0482b16f3d066c2ea0) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/basket.js | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 22:46:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 20:46:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-102-gb8b31f8ba4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via b8b31f8ba47f9b94bc797a0adc3045814710a614 (commit) from 341fa8a59ddba280e599ba2ea857b9025c4cb69f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b8b31f8ba47f9b94bc797a0adc3045814710a614 Author: Lucas Gass Date: Fri May 1 17:01:11 2020 +0000 Bug 25341: Remove whitespace from barcode in add_items.pl TEST PLAN: 1. Go to course reserves and trying adding a course with a barcode that has some leading/trailing whitespace. 2. It doesnt work 3. Apply patch and restart_all 4. Try again with leading/trailing whitespace, it should work. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d14e25b57ed68637517da323d28108d5ea5b247b) ----------------------------------------------------------------------- Summary of changes: course_reserves/add_items.pl | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 23:49:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 21:49:10 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-103-gc4d93d76f2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via c4d93d76f29d0935f1cad712a463003a45c42ad6 (commit) from b8b31f8ba47f9b94bc797a0adc3045814710a614 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c4d93d76f29d0935f1cad712a463003a45c42ad6 Author: Katrin Fischer Date: Sun Apr 19 13:39:08 2020 +0200 Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files It looks like RewriteLog will no longer work with Apache 2.4 and later. RewriteLog Those familiar with earlier versions of mod_rewrite will no doubt be looking for the RewriteLog and RewriteLogLevel directives. This functionality has been completely replaced by the new per-module logging configuration mentioned above. http://httpd.apache.org/docs/current/mod/mod_rewrite.html All lines removed were commented out, so there should be no change in behaviour or side effects. To test. - Verify every mention of RewriteLog has been removed from Koha - Verify patch by reading it Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 8a8130c0524efd4c211155cecce78392a76804f6) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: debian/templates/apache-site-https.conf.in | 2 -- debian/templates/apache-site.conf.in | 2 -- etc/koha-httpd.conf | 8 -------- 3 files changed, 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 15 23:53:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 21:53:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-104-gcc47b47d4f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via cc47b47d4f7fa34a17d2e04e5537eb0cda633800 (commit) from c4d93d76f29d0935f1cad712a463003a45c42ad6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cc47b47d4f7fa34a17d2e04e5537eb0cda633800 Author: Katrin Fischer Date: Mon Apr 13 04:42:37 2020 +0200 Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql The description on STATUS was incomplete, missing 2 status and the SUGGEST_STATUS category. To test: - Later this will show up in schema.koha-community.org, but for now it can only be verified reading the patch. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit e98dc9494a1bf0307084c5d11bdfb25d49d0b131) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/kohastructure.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 16 00:30:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 22:30:51 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-107-g0d4f529dec Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0d4f529dec3a499daac8fdcefa774d15f782799f (commit) via 0b5c428eed221991443bbffa30bd0f5d5a050b0a (commit) via 19953fc68703b3a8b067153ab5719d14b39ca709 (commit) from cc47b47d4f7fa34a17d2e04e5537eb0cda633800 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d4f529dec3a499daac8fdcefa774d15f782799f Author: Lucas Gass Date: Fri May 15 22:00:59 2020 +0000 Bug 25184: DBRev 19.05.10.003 Signed-off-by: Lucas Gass commit 0b5c428eed221991443bbffa30bd0f5d5a050b0a Author: Kyle M Hall Date: Tue Apr 21 12:52:38 2020 -0400 Bug 25184: Add syspref It's entirely possible that some libraries are relying on the current before for part of their workflow. Do to this possibility, it seems like a good idea to control this behavior via a system preference. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Set TrapHoldsOnOrder to "don't trap" 4) Set an item's notforloan value to -1 5) Place a hold on that item 6) Check in the item 7) Note the item is not trapped for hold 9) Set TrapHoldsOnOrder to "trap" 10) Check in the item 11) Koha should now ask if you'd like to trap the item for the hold! Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit bb3893720d55100380bf431cf6aea8a044a9bd04) Signed-off-by: Lucas Gass commit 19953fc68703b3a8b067153ab5719d14b39ca709 Author: Kyle M Hall Date: Fri Apr 17 14:06:32 2020 -0400 Bug 25184: Items with a negative notforloan status should not be captured for holds Negative notforloan statuses should allow holds to be placed but not captured. Due to coronavirus, we have libraries setting all returned materials to a negative notforloan value of Quarantine for several days. They're using UpdateNotForLoanStatusOnCheckin to set that status automatically. However, those items are still capturing for holds, even though those items cannot be checked out until the notforloan status is removed. In cases like an On Order item where we do want the hold to fill at checkin, UpdateNotForLoanStatusOnCheckin should be used to clear that notforloan status so the hold can fill. In master, if I set an item to a not for loan but holdable status ( < 0 ) I can place the hold, capture the hold and set it to waiting, but *not* check it out to the patron! This does not make sense. I should not be able to trap an item for checkout unless it can be checked out. Test Plan: 1) Set an item's notforloan value to -1 2) Place a hold on that item 3) Check in the item 4) Trap the item for that hold 5) Attempt to check the item out to the patron, you will be unable to because it is notforloan 6) Apply this patch 7) Restart all the things! 8) Repeat steps 1-3 9) The screen should no longer ask if the item should be trapped to fill the hold! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Catherine Ingram Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit aa9a4fc3f64787e536faabd4b49be76d1e8144f1) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 5 ++++- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 10 ++++++++++ .../en/modules/admin/preferences/circulation.pref | 6 ++++++ t/db_dependent/Holds.t | 23 +++++++++++++++++++++- 6 files changed, 44 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 16 00:32:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 22:32:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-108-g68746bb517 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 68746bb517088daabf692c9277671e2d7f8f2e61 (commit) from 0d4f529dec3a499daac8fdcefa774d15f782799f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 68746bb517088daabf692c9277671e2d7f8f2e61 Author: Joy Nelson Date: Mon May 11 21:56:04 2020 +0000 Bug 25184: (follow-up) fix number of tests Signed-off-by: Joy Nelson (cherry picked from commit 75e7861df4834d7172b55552d1b7a03d3ab3b537) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Holds.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 16 00:36:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 22:36:33 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-109-g1e0c9f9716 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1e0c9f97168932e5e2fb8c00c60f53e3a96b3514 (commit) from 68746bb517088daabf692c9277671e2d7f8f2e61 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e0c9f97168932e5e2fb8c00c60f53e3a96b3514 Author: David Roberts Date: Thu May 7 18:07:21 2020 +0000 Bug 25388: There is no link for the "online help" This patch removes a non-existent link to the online help from the marc subfield editor. To test: 1) Go to Admin > MARC Bibliographic framework > Edit MARC structure > Edit subfield (for example /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=000&frameworkcode=AR) 2) Check that the Max Length value in the Advanced constraints area contains text saying "See online help" 3) Apply patch 4) Check that the reference to the online help has disappeared. Remove tabs from start of line Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b48282ba825870f11c10edc7aee44f4b0db52435) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 16 00:38:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 22:38:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-110-gf6a340b60d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via f6a340b60d71310b9f0906cba8cf3c6522f4f276 (commit) from 1e0c9f97168932e5e2fb8c00c60f53e3a96b3514 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f6a340b60d71310b9f0906cba8cf3c6522f4f276 Author: George Veranis Date: Wed Apr 22 11:43:53 2020 +0200 Bug 19312: Fix typo in template This patch fixes a simple typo Test plan: 1) Go to Administration -> MARC bibliographic framework 2) Select a framework and add plugin unimarc_field_121a.pl to 121 field 3) Open cataloguing screen 4) Go to 121 field and check if for subfield a shows two times the value 2-dimensional 5) Apply the patch 6) Go to 121 field again and check if it shows 2 different values Mentored-by: Andreas Roussos Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 96202ca7bb533ddf6bcb1c8486b8ae5a9591f1a1) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/cataloguing/value_builder/unimarc_field_121a.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 16 00:43:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 22:43:12 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-111-gf24092c77e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via f24092c77e5a6c70a35ec166837463c4c0712b9b (commit) from f6a340b60d71310b9f0906cba8cf3c6522f4f276 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f24092c77e5a6c70a35ec166837463c4c0712b9b Author: Jonathan Druart Date: Fri Apr 17 12:24:24 2020 +0200 Bug 25157: Silent patron deletion cmd line script Without -v the script will no longer display messages unless the error is major. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 4bc3fe1c72602c6e3886725836558af8f7b370f2) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/delete_patrons.pl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 16 00:46:02 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 22:46:02 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-112-g4f7d98d591 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 4f7d98d59185d3adfd255c53b5532e4aead2443f (commit) from f24092c77e5a6c70a35ec166837463c4c0712b9b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4f7d98d59185d3adfd255c53b5532e4aead2443f Author: Grace McKenzie Date: Wed Jan 18 22:55:48 2017 +0000 Bug 17853: Don't remove () from 780 link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Felix Hemme Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: David Nind Bug 17853: Don't remove () from 785 link text and restore link value of 780 The only thing we change for 780 and 785 is, that if the display text contains (), they are no longer removed. To test: - Catalogue a record with 785$a some text (including) parenthesis e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Katrin Fischer Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 7560c4581331a6a09f023df38cf04e4e8b4d5b2c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 8 ++++---- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 16 00:58:00 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 22:58:00 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-114-g6d4934ed28 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 6d4934ed28fc45553ea8bc1e3efb64b6281a8e0e (commit) via fac0217787a58175a53452ffdc504b04f5ac92ef (commit) from 4f7d98d59185d3adfd255c53b5532e4aead2443f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6d4934ed28fc45553ea8bc1e3efb64b6281a8e0e Author: Nick Clemens Date: Thu May 7 13:08:14 2020 +0000 Bug 25342: Unit test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5518f9183054a49c672c94c6d98081da41571668) Signed-off-by: Lucas Gass commit fac0217787a58175a53452ffdc504b04f5ac92ef Author: Nick Clemens Date: Fri May 1 14:48:55 2020 +0000 Bug 25342: Force ES id as string To test: 1 - Be using ES 2 - Find a unique record by searchign for title or seomthing 3 - Edit the record 4 - Repeat search and confirm you are returned to the details page 5 - Go to Tools->MARC modification templates 6 - Add a template and define an action 7 - Go to Tools->Batch record modification 8 - Select Enter a list of record numbers 9 - Enter the biblionumber of the record you searched for 10 - Use the marc modification template you setup 11 - Complete the modification 12 - Repeat your search 13 - note you get two results, both pointing to same biblionumber 14 - Check the ES index, note that you have two entries, one with the biblionumber, and the other with #.0, e.g.: curl -XGET 'es:9200/koha_kohadev_biblios/data/14.0?pretty' curl -XGET 'es:9200/koha_kohadev_biblios/data/14?pretty' 15 - Apply patch 16 - Delete and rebuild ES index perl misc/search_tools/rebuild_elasticsearch.pl -d -b 17 - Repeat 2-12 18 - No duplication this time Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1bae59611da3ed166176fc67f5e68980afbb87d0) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/Indexer.pm | 3 +-- .../Koha/SearchEngine/Elasticsearch/Indexer.t | 28 +++++++++++++++++++++- 2 files changed, 28 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 16 01:02:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 23:02:25 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-117-g1738ecc1fe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1738ecc1fe75c3757ce21b2bb63dfaea2f816343 (commit) via bcbabb76937f0fb7dd49ffb188841c16d6906aef (commit) via b5807429f7b75f9a3e5020abecfb4afb135dcc17 (commit) from 6d4934ed28fc45553ea8bc1e3efb64b6281a8e0e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1738ecc1fe75c3757ce21b2bb63dfaea2f816343 Author: Marcel de Rooy Date: Fri May 8 06:46:59 2020 +0000 Bug 22437: (follow-up) Move deletion of merge requests to DelAuthority Lines can be moved. Deletion can be done too if skip_merge is not set. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 2cb01116ee3ed6ce6296cb0ad5e794fd68e58f8a) Signed-off-by: Lucas Gass commit bcbabb76937f0fb7dd49ffb188841c16d6906aef Author: Marcel de Rooy Date: Fri Apr 3 08:55:45 2020 +0000 Bug 22437: Delete older merge requests at new merge time If you merge A to B, we should remove older AA merges (regular merge to itself) in the queue before deleting A. Test plan: [1] Set merge limit in prefs to say X. [2] Find three authorities A, B, C with linkcount >X, >X, Signed-off-by: Phil Ringnalda Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 08aa52c8315c7bec6df9800101c61591892d07dd) Signed-off-by: Lucas Gass commit b5807429f7b75f9a3e5020abecfb4afb135dcc17 Author: Marcel de Rooy Date: Mon Apr 6 13:44:46 2020 +0000 Bug 22437: Add test case to Merge.t Test proves now that a 'destructive merge' is removed by DelAuthority. Test plan: Run t/db_dependent/Authority/Merge.t. Should fail when you do not apply the other two patches and pass with them. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c748b95d57ef625e77742785f8ced5369b326787) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 7 ++++++- authorities/merge.pl | 4 ++-- t/db_dependent/Authority/Merge.t | 15 ++++++++++++++- 3 files changed, 22 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 16 01:12:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 23:12:50 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-119-g55312cd9f8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 55312cd9f8789d03acb9251d342afd5ac76e842c (commit) via 3c27362e3d092ba4d44711b43b01acd11c0ed74b (commit) from 1738ecc1fe75c3757ce21b2bb63dfaea2f816343 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 55312cd9f8789d03acb9251d342afd5ac76e842c Author: Slava Shishkin Date: Sun May 10 18:15:09 2020 +0300 Bug 25409: Add missing "Required" text and "required" classes Highlight text with red by adding “required” class to the label and added red “Required” text next to select field in "onboardingstep5.tt" template. To test: 1) Start new installation. During onboarding tool phase you will be requested to create a new circulation rule. 2) Observe that "Units" label has no "required" class and that there’s no “Required” text next to a select field. 3) Apply patch. 4) Repeat step 2 (you can reload circulation rule creation page). 5) Observe the error is gone. Mentored-by: Peter Vashchuk Mentored-by: Andrew Nugged Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit e21179fd9bad471c931ce0e89cd8f4df145af8f1) Signed-off-by: Lucas Gass commit 3c27362e3d092ba4d44711b43b01acd11c0ed74b Author: Slava Shishkin Date: Thu May 7 14:24:31 2020 +0300 Bug 25409: Add missing "required" class to template Added "required" class to "itemtype" label in "onboardingstep5.tt" template. To test: 1) Start new instalation. During onboarding tool phase you will be requested to create a new circulation rule. 2) Observe that "itemtype" label has no "required" class. 3) Apply patch. 4) Repeat step 2 (you can reload circulation rule creation page). 5) Observe the error is gone. Mentored-by: Peter Vashchuk Mentored-by: Andrew Nugged Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 180360e3fde1befd73fb0d626d0fc7ddebc057de) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 16 01:16:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 15 May 2020 23:16:27 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-121-gce695e0623 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via ce695e062364ceada672f5ced2a258dabb3d4729 (commit) via 60b19648e48f0b6054b7cd82dab743200b14b623 (commit) from 55312cd9f8789d03acb9251d342afd5ac76e842c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ce695e062364ceada672f5ced2a258dabb3d4729 Author: Nick Clemens Date: Mon May 11 17:08:35 2020 +0000 Bug 25418: (QA follow-up) Raise size of input box In twelve hour format the length of the string is 20 characters we need the box to fit all of them Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 4c201630ff3c8239c33588a3ffd82156a3c762ec) Signed-off-by: Lucas Gass commit 60b19648e48f0b6054b7cd82dab743200b14b623 Author: Jonathan Druart Date: Thu May 7 17:18:35 2020 +0200 Bug 25418: (bug 25133 follow-up) Display due date with hours And not as due date, it's not a display-only info, but an input. This patch is a follow-up of Bug 25133: Fix time part of due date for 12hr == Test plan == 1. create checkouts with the following params and results 2. tomorrow 11:59 PM timeformat syspref: 12h - item is due without a specific time, only date (after-checkout green box) 3. backdate 11:59 PM timeformat syspref: 12h - note the yellow confirm box has only the date - item is due at 12:00 PM (after-checkout green box) 4. tomorrow 11:23 AM timeformat syspref: 12h - item is due at 11:23 AM (after-checkout green box) 5. backdate 11:23 AM timeformat syspref: 12h - note the yellow confirm box has the date and time - item is due 11:23 AM (after-checkout green box) 6. tomorrow 23:59 timeformat syspref: 24h - item is due without a specific time, only date (after-checkout green box) 7. backdate 23:59 timeformat syspref: 24h - note the yellow confirm box has only the date - item is due at 00:00 (after-checkout green box) 8. tomorrow 11:23 timeformat syspref: 24h - item is due at 11:23 (after-checkout green box) 9. backdate 11:23 timeformat syspref: 24h - note the yellow confirm box has the date and time - item is due 11:23 (after-checkout green box) 10. apply patch 11. create checkouts with the following params and results 12. tomorrow 11:59 PM timeformat syspref: 12h - item is due without a specific time, only date (after-checkout green box) 13. backdate 11:59 PM timeformat syspref: 12h - note the yellow confirm box has the date and time - CHANGE COMPARED TO BEFORE THE PATCH - item is due without a specific time, only date (after-checkout green box) - CHANGE COMPARED TO BEFORE THE PATCH 14. tomorrow 11:23 AM timeformat syspref: 12h - item is due 11:23 AM (after-checkout green box) 15. backdate 11:23 AM timeformat syspref: 12h - note the yellow confirm box has the date and time - item is due 11:23 AM (after-checkout green box) 16. tomorrow 23:59 timeformat syspref: 24h - item is due without a specific time, only date (after-checkout green box) 17. backdate 23:59 timeformat syspref: 24h - note the yellow confirm box has the date and time - CHANGE COMPARED TO BEFORE THE PATCH - item is due without a specific time, only date (after-checkout green box) - CHANGE COMPARED TO BEFORE THE PATCH 18. tomorrow 11:23 timeformat syspref: 24h - item is due at 11:23 (after-checkout green box) 19. backdate 11:23 timeformat syspref: 24h - note the yellow confirm box has the date and time - item is due 11:23 (after-checkout green box) Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 6f9dda2f295a2d25c01ad48fd3f54fb25735f60b) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 18 13:11:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 18 May 2020 11:11:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2219-gbc421faa0d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bc421faa0d90da91a14d1d900103d732b732b5bf (commit) via 85243da0b437b30676a6d4d4f490be7c917d5d10 (commit) from 2a031b352c90c3c79cfd0c7c0e132971a82406fb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bc421faa0d90da91a14d1d900103d732b732b5bf Author: Martin Renvoize Date: Mon May 18 11:43:55 2020 +0100 Bug 13881: DBRev 19.12.00.090 Signed-off-by: Martin Renvoize commit 85243da0b437b30676a6d4d4f490be7c917d5d10 Author: Martin Renvoize Date: Mon May 18 11:40:14 2020 +0100 Bug 13881: (RM follow-up) Make 'Desks' feature optional This patch adds a new 'UseIssueDesks' preference which defaults to "Don't use" to enabled/disable the 'Desks' functionality added with this bug. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 13 +++++++++++++ koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt | 6 ++++-- .../prog/en/modules/admin/preferences/circulation.pref | 6 ++++++ 5 files changed, 25 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 18 14:21:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 18 May 2020 12:21:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2221-g9223a483f1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9223a483f1695ea73ee199bd7a001722ecf47f8f (commit) via f32789be1396817da459493693f4d36f663d4e95 (commit) from bc421faa0d90da91a14d1d900103d732b732b5bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9223a483f1695ea73ee199bd7a001722ecf47f8f Author: Martin Renvoize Date: Mon May 18 12:50:44 2020 +0100 Bug 24080: Add sponsorship details Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize commit f32789be1396817da459493693f4d36f663d4e95 Author: Martin Renvoize Date: Mon May 18 12:49:22 2020 +0100 Bug 23442: Add sponsorship details Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 18 16:17:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 18 May 2020 14:17:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2225-g1cde48f92f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1cde48f92f5823dea3a8867fcaeab5b7a1902e8f (commit) via 7a425ec395cc96c6bb88528ad34ff7ff60f5337a (commit) via a00ca6a9d96aa9e9c01fe30619d883b4f50ee58d (commit) via fdea1cbd22f2a51cd8269aa9f7db57acfd295e6c (commit) from 9223a483f1695ea73ee199bd7a001722ecf47f8f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1cde48f92f5823dea3a8867fcaeab5b7a1902e8f Author: Martin Renvoize Date: Mon May 18 14:28:26 2020 +0100 Bug 24255: Add sponsorship details Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize commit 7a425ec395cc96c6bb88528ad34ff7ff60f5337a Author: Martin Renvoize Date: Mon May 18 14:27:40 2020 +0100 Bug 24252: Add sponsorship details Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize commit a00ca6a9d96aa9e9c01fe30619d883b4f50ee58d Author: Martin Renvoize Date: Mon May 18 13:51:47 2020 +0100 Bug 23593: Add sponsorship details Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Martin Renvoize commit fdea1cbd22f2a51cd8269aa9f7db57acfd295e6c Author: Martin Renvoize Date: Mon May 18 13:49:32 2020 +0100 Bug 23592: Add sponsorship details Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 18 16:51:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 18 May 2020 14:51:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2226-g5117fab489 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5117fab4890f86b8f11a129485917db3d357b920 (commit) from 1cde48f92f5823dea3a8867fcaeab5b7a1902e8f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5117fab4890f86b8f11a129485917db3d357b920 Author: Martin Renvoize Date: Mon May 18 15:21:09 2020 +0100 Bug 22970: Add sponsorship details Sponsored-by: Université de Lyon 3 Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 18 16:56:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 18 May 2020 14:56:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2236-g067aa1c5f7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 067aa1c5f731bc9eac40ff53e6c3be2e58ef1c0f (commit) via 0899d99b7c2ce5920664f4d4710869b2f0d25b81 (commit) via 3f4ae28cd8de3ae60ab85bc914840a59ae4b1ec2 (commit) via f04129ca45171f8e9c115ca8e25b7dc4b9f9686e (commit) via 48ea8edb6188045f24aa3508a4fdb209369b1720 (commit) via 68bcc31dfcdfd48614843ff27a4594a69ef95ed7 (commit) via 0a24e721dda54e67759c7c10d956ee63da6b8ec5 (commit) via 8371d10fa5639690a3deb77b64f8079325993ff4 (commit) via 05705ab2ad12aff3627eb53e7e4d56d6a4b20bcd (commit) via 48e3e6aafb04fbe6eea33da8550c9952a3f52a11 (commit) from 5117fab4890f86b8f11a129485917db3d357b920 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 067aa1c5f731bc9eac40ff53e6c3be2e58ef1c0f Author: Nick Clemens Date: Fri May 15 11:46:07 2020 +0000 Bug 25278: add clear_search_fields_cache method Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0899d99b7c2ce5920664f4d4710869b2f0d25b81 Author: Nick Clemens Date: Mon Apr 27 14:05:46 2020 +0000 Bug 25278: (follow-up) Fix other occurrences Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 3f4ae28cd8de3ae60ab85bc914840a59ae4b1ec2 Author: Nick Clemens Date: Fri Apr 24 15:52:50 2020 +0000 Bug 25278: Retrieve correct search fields for authorities Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit f04129ca45171f8e9c115ca8e25b7dc4b9f9686e Author: Nick Clemens Date: Fri Apr 24 16:32:06 2020 +0000 Bug 25278: Unit tests Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 48ea8edb6188045f24aa3508a4fdb209369b1720 Author: Nick Clemens Date: Fri Apr 24 16:08:44 2020 +0000 Bug 25277: Unit test Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 68bcc31dfcdfd48614843ff27a4594a69ef95ed7 Author: Nick Clemens Date: Fri Apr 24 13:34:31 2020 +0000 Bug 25277: Don't specify a field in query if none passed == test plan == To test: 0 - Have Koha running with ES 6 enabled 1 - Launch the z3950 responder: perl misc/z3950_responder.pl --config-dir /kohadevbox/koha/etc/z3950 --debug 2 - Connect using yaz-client: yaz-client localhost:2100 2.1 Alternative, if you add the responder as a Z39.50 server in Koha and do a catalogue Z39.50 search. Don't forget to search in the keywords field. Not the title field. 3 - base biblios 4 - find bruce 5 - No results 6 - Stop the responder 7 - Apply patch 8 - Repeat 9 - This time you get results Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0a24e721dda54e67759c7c10d956ee63da6b8ec5 Author: Phil Ringnalda Date: Tue Apr 28 17:16:51 2020 -0700 Bug 25308: Escape querystring for Z39.50 popup from cataloging Test plan: 1. For bonus fun, Administration -> MARC Frameworks -> New framework, with the code A&B and description Ants & Bees 2. In the A&B Actions menu, choose MARC structure since Import won't work 3. Accept the offer to copy in structure from default 4. Cataloging -> New record -> Ants & Bees 5. Type This & That in the 245$a (and for extra credit, in 020$a, and create an author authority with an & in it so you can put it in the 100/110) 6. Click Z39.50/SRU search, make sure everything you typed is prefilled including the parts after & 7. Search for anything that will retrieve a record (the ISBN This & That probably won't), choose Import 8. Check that the record came back, and verify in the Settings menu that it's still in the Ants & Bees framework. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 8371d10fa5639690a3deb77b64f8079325993ff4 Author: Phil Ringnalda Date: Fri Apr 24 11:34:29 2020 -0700 Bug 11446: Use encodeURIComponent on search terms in authority lookup plugin While adding the data from the existing field to the auth_finder URI, we're using encodeURI(), which is meant for an entire URI and thus doesn't escape &. Things that are going into a querystring need encodeURIComponent() instead. Test plan: 1. Enable the system preference EnableAdvancedCatalogingEditor 2. Clear your browser cache, even a shift+reload won't get you a fresh marc-editor.js for the advanced editor 3. Create a Topical Term authority with 150 $aThis & That$xStuff & Junk 4. In the Basic editor, use the authority plugin on the 650 field to select that authority. 5. Click the authority plugin again, verify that the popup contains This & That and Stuff & Junk rather than just This and Stuff 6. From the Cataloging home page choose Advanced editor 7. In a new line paste 650 _ _ ‡aThis & That‡xStuff & Junk 8. Type ctrl+shift+L and verify the popup shows both words in both fields 9. When you remember the plugin exists there too, edit your Stuff & Junk authority, and in a 550 tag type One & Two in $a and Three & Four in $x and click the plugin link, verify that the search window has your search terms not cut off. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 05705ab2ad12aff3627eb53e7e4d56d6a4b20bcd Author: Tomas Cohen Arazi Date: Mon May 18 09:26:09 2020 -0300 Bug 25527: Add logger to Koha::ExternalContent This patch makes Koha::Logger initialization happen in the ->new method for the Koha::ExternalContent-derived classes. In the case of RecordedBooks, it doesn't look like it is used at all. In the case of OverDrive, it will now use the Koha::ExternalContent exported logger accessor. I added tests for this addition to Koha::ExternalContent to the OverDrive tests. I also removed references to Test::DBIx::Class as it is not used at all. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha_ExternalContent_OverDrive.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 48e3e6aafb04fbe6eea33da8550c9952a3f52a11 Author: Tomas Cohen Arazi Date: Mon May 18 09:23:42 2020 -0300 Bug 25527: Initialize the logger when required In an OO package, the logger initialization should happen in the constructor. This is not an OO package and the initialization is happening on loading it. This is a wrong behaviour and certainly breaks in environments where initialization cannot happen (package building, for example). There could be several options to solve this, as it is used in a single sub on this package, I opted for initializing on that sub. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/ImportBatch.pm | 4 +- Koha/ExternalContent.pm | 6 ++- Koha/ExternalContent/OverDrive.pm | 4 +- Koha/ExternalContent/RecordedBooks.pm | 3 -- Koha/SearchEngine/Elasticsearch.pm | 22 ++++++-- Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +- Koha/Z3950Responder/RPN.pm | 13 +++-- admin/searchengine/elasticsearch/mappings.pl | 4 +- etc/z3950/attribute_mappings.yaml | 2 - .../lib/koha/cateditor/marc-editor.js | 2 +- .../prog/en/modules/cataloguing/addbiblio.tt | 4 +- koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 2 +- .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 44 +++++++++++++--- .../Koha/SearchEngine/Elasticsearch/Reset.t | 4 +- .../Koha/Z3950Responder/GenericSession.t | 7 ++- t/db_dependent/Koha_ExternalContent_OverDrive.t | 61 +++++++++++----------- 16 files changed, 114 insertions(+), 70 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 18 18:24:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 18 May 2020 16:24:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2243-g7587975da2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7587975da2fbc470a4c336ad8fdb5afef8b88926 (commit) via 6a4372c2d579b070335108bce7ea728f3cc206fb (commit) via 3acd1bce91e4d43c4abb2317d6650654d2e4ace8 (commit) via 4debe59d276926691d866c9c594ca6e0327a8a1a (commit) via d37e3d81da34be89c6d3c65df5fa14bdd16eae93 (commit) via be34c35d60267a6ff972bfd9a526696702876308 (commit) via 4492fad72adc746b956c5f80684db0061df2dae0 (commit) from 067aa1c5f731bc9eac40ff53e6c3be2e58ef1c0f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7587975da2fbc470a4c336ad8fdb5afef8b88926 Author: Martin Renvoize Date: Mon May 18 16:56:22 2020 +0100 Bug 25188: Sponsorship details Sponsored-by: PTFS Europe Mentored-by: Martin Renvoize Signed-off-by: Martin Renvoize commit 6a4372c2d579b070335108bce7ea728f3cc206fb Author: Martin Renvoize Date: Mon May 18 16:55:03 2020 +0100 Bug 20847: Add sponsorship details Sponsored-by: PTFS Europe Mentored-by: Martin Renvoize Signed-off-by: Martin Renvoize commit 3acd1bce91e4d43c4abb2317d6650654d2e4ace8 Author: Martin Renvoize Date: Mon May 18 16:53:11 2020 +0100 Bug 25130: Add sponsorship details Sponsored-by: PTFS Europe Mentored-by: Martin Renvoize Signed-off-by: Martin Renvoize commit 4debe59d276926691d866c9c594ca6e0327a8a1a Author: Martin Renvoize Date: Mon May 18 16:51:55 2020 +0100 Bug 20370: Add sponsorship details Sponsored-by: PTFS Europe Signed-off-by: Martin Renvoize commit d37e3d81da34be89c6d3c65df5fa14bdd16eae93 Author: Martin Renvoize Date: Mon May 18 16:51:03 2020 +0100 Bug 23119: Add sponsorship details Sponsored-by: PTFS Europe Signed-off-by: Martin Renvoize commit be34c35d60267a6ff972bfd9a526696702876308 Author: Martin Renvoize Date: Mon May 18 16:49:59 2020 +0100 Bug 24976: Add sponsorship details Sponsored-by: PTFS Europe Mentored-by: Martin Renvoize Signed-off-by: Martin Renvoize commit 4492fad72adc746b956c5f80684db0061df2dae0 Author: Martin Renvoize Date: Mon May 18 16:49:21 2020 +0100 Bug 24484: Add sponsorship details Sponsored-by: PTFS Europe Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 19 09:47:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 19 May 2020 07:47:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2245-g291d8a5ee3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 291d8a5ee3639cbc1318853c5eb4e024bd7fdc31 (commit) via 94470aa7c3525e9d1019639f30ad7008890ecfdc (commit) from 7587975da2fbc470a4c336ad8fdb5afef8b88926 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 291d8a5ee3639cbc1318853c5eb4e024bd7fdc31 Author: Martin Renvoize Date: Tue May 19 08:17:56 2020 +0100 Bug 13881: (RM follow-up) Fix terminology Signed-off-by: Martin Renvoize commit 94470aa7c3525e9d1019639f30ad7008890ecfdc Author: Martin Renvoize Date: Tue May 19 08:17:17 2020 +0100 Bug 13881: DBRev 19.12.00.091 Correction to preference terminology Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 10 ++++++++++ koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt | 6 +++--- .../prog/en/modules/admin/preferences/circulation.pref | 4 ++-- 5 files changed, 17 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 19 09:52:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 19 May 2020 07:52:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2246-gba59f81d2f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ba59f81d2fb947e9cf1ec0e2b74e9bce64168ff8 (commit) from 291d8a5ee3639cbc1318853c5eb4e024bd7fdc31 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ba59f81d2fb947e9cf1ec0e2b74e9bce64168ff8 Author: Martin Renvoize Date: Tue May 19 08:24:46 2020 +0100 Bug 13881: Add Sponsorship details Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 19 09:58:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 19 May 2020 07:58:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2251-g96b4f6802b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 96b4f6802b4b6b195d09f9b7dc9db29288a2b885 (commit) via 8efa607ae58ecb83e4b6088633f4b302abfe4822 (commit) via 048a6cfc02e7f72159e3345a36e8496528fe68ca (commit) via 36f671090af9c0728aa5afdbb677f9e390e18117 (commit) via da1a85b3a7a134c8eccc24a06828727c258db60f (commit) from ba59f81d2fb947e9cf1ec0e2b74e9bce64168ff8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 96b4f6802b4b6b195d09f9b7dc9db29288a2b885 Author: Kyle M Hall Date: Mon May 18 14:14:42 2020 -0400 Bug 25535: Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize commit 8efa607ae58ecb83e4b6088633f4b302abfe4822 Author: Petro Vashchuk Date: Mon May 18 14:45:56 2020 +0300 Bug 25516: Fix for "Can't call method unblessed on unblessed reference" Software error: Can't call method "unblessed" on unblessed reference at ../reserve/request.pl line 581. was caused by recent commit with `wantarray` removal in sub pickup_locations in ‘Item.pm’ and visible on fresher Perls (where experimental feature "autoderef" removed https://www.effectiveperlprogramming.com/2010/11/use-array-references-with-the-array-operators/ ) To test: 1) Get a clean dev environment after "reset_all" 2) Add an empty record for “Default checkout, hold and return policy” on /cgi-bin/koha/admin/smart-rules.pl. 3) Open item record, like /cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=1 4) Observe the error (Can't call method "unblessed" on unblessed reference at ../reserve/request.pl line 581.) 5) Apply patch. 6) Repeat steps 2 and 3. 7) Observe that the error is gone. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 048a6cfc02e7f72159e3345a36e8496528fe68ca Author: David Cook Date: Mon May 18 06:23:07 2020 +0000 Bug 25510: Put space between negation operator and function name This patch puts a space between the negation operator ! and the function name (ie log4perl_component). Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 36f671090af9c0728aa5afdbb677f9e390e18117 Author: Jonathan Druart Date: Fri May 15 10:12:46 2020 +0200 Bug 25510: Fix syntax error in koha-common.postinst Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit da1a85b3a7a134c8eccc24a06828727c258db60f Author: David Cook Date: Mon May 18 03:02:05 2020 +0000 Bug 25068: Fix koha-common.install directives Bug 24735 removed etc/searchengine/queryparser.yml, which removed the need for koha-common.install to install the following file: debian/tmp/etc/koha/searchengine This patch removes that line and causes the Koha packages to build correctly again. To test: 0) Apply patch 1) Build a Koha package using one of the following methods: - https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way - https://hub.docker.com/r/koha/koha-dpkg - https://gitlab.com/minusdavid/koha-deb-builder-docker Signed-off-by: Mason James Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Hold.pm | 2 +- api/v1/swagger/definitions/hold.json | 2 +- api/v1/swagger/paths/holds.json | 2 +- debian/koha-common.install | 1 - debian/koha-common.postinst | 8 ++++---- reserve/request.pl | 11 +++++------ 6 files changed, 12 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 19 16:32:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 19 May 2020 14:32:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2252-g8994ded2c4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8994ded2c47d22fd46ea46f6e7855da52826b351 (commit) from 96b4f6802b4b6b195d09f9b7dc9db29288a2b885 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8994ded2c47d22fd46ea46f6e7855da52826b351 Author: Jonathan Druart Date: Thu May 14 16:04:20 2020 +0200 Bug 25481: Pass --user to start-stop-daemon when a pidfile is used Since D10, the behaviour of start-stop-daemon changed, see from its manual: """ Warning: using this match option with a world-writable pidfile or using it alone with a daemon that writes the pidfile as an unprivileged (non-root) user will be refused with an error (since version 1.19.3) as this is a security risk, because either any user can write to it, or if the daemon gets compromised, the contents of the pidfile cannot be trusted, and then a privileged runner (such as an init script executed as root) would end up acting on any system process. Using /dev/null is exempt from these checks. """ Test plan: koha-plack --restart kohadev should success with this patch. Without this patch you get: start-stop-daemon: matching only on non-root pidfile /var/run/koha/kohadev/plack.pid is insecure Signed-off-by: Nick Clemens Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-functions.sh | 2 ++ debian/scripts/koha-plack | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 19 16:49:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 19 May 2020 14:49:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2255-g7a4cf3569d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7a4cf3569d4c9c49aba43e3c524d8ac09474740a (commit) via b3ed9a40426bec52c1da9334818c49a6cbcfb464 (commit) via c97921bb68849a2c7dd5f2f5ad8f5b97789df5c1 (commit) from 8994ded2c47d22fd46ea46f6e7855da52826b351 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7a4cf3569d4c9c49aba43e3c524d8ac09474740a Author: Tomas Cohen Arazi Date: Thu May 14 09:06:51 2020 -0300 Bug 25502: Adapt Advanced macros routes to current guidelines The original development started before the changes we introduced in the guidelines in late 2019, and the major code changes that took place in January 2020. - Attribute mapping logic is now on the Koha::Object-level (the patches implement that, but are not using it) - Related to the above, some helper methods like to_api and to_model are kept, the same for the mappings in the controller, they should all go away - Related to the above, set_from_api and new_from_api should be used instead of using helper to_api and to_model methods in the controller - $c->objects->search doesn't use the to_model and to_api params - Response status codes need to be changed, at least for DELETE operations Those are fixed by this patch. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/advanced_editor_macros.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize commit b3ed9a40426bec52c1da9334818c49a6cbcfb464 Author: Tomas Cohen Arazi Date: Wed May 13 17:17:21 2020 -0300 Bug 25493: Make ->unhandled_exception use Koha::Logger To test: 1. Edit the Koha/REST/V1/Cities.pm 'list' method adding die("Nada"); before the render step. 2. Restart plack and try the endpoint => SUCCESS: The message is generic, but you see something is logged in /var/log/koha/kohadev/api-error.log 3. Change die("Nada"); for a real exception like: use Koha::Exceptions; Koha::Exceptions::DuplicateObject->throw("Nada"); 4. Repeat 2. => SUCCESS: The message is generic, but a meaningful text is added to the logs. 5. Point your browser to the /api/v1/hola route from your dev environment => FAIL: Wow, such a weird error 6. Apply this patch 7. Restart plack and repeat 2, 3 and 4 => SUCCESS: No behaviour change 8. Repeat 5 => SUCCESS: The regular Mojolicious 404 weird page 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit c97921bb68849a2c7dd5f2f5ad8f5b97789df5c1 Author: Julian Maurice Date: Tue May 19 10:05:41 2020 -0300 Bug 25501: Supress warnings on installing translation To test: 1) Verify the error installing translations for any language 2) Apply the patch 3) Repeat 1), check warning is gone Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/REST/Plugin/Exceptions.pm | 3 +- Koha/REST/V1.pm | 3 - Koha/REST/V1/AdvancedEditorMacro.pm | 180 +++++++------------------ api/v1/swagger/paths/advancededitormacros.json | 4 +- misc/translator/tmpl_process3.pl | 4 +- t/db_dependent/api/v1/advanced_editor_macros.t | 12 +- 6 files changed, 57 insertions(+), 149 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 19 18:17:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 19 May 2020 16:17:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2257-gf8f890621e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f8f890621e8ce99c36f4117eb018bbb3ec3da960 (commit) via d7066e8cfb50df6e78e8bb1dd491736b1aadcde6 (commit) from 7a4cf3569d4c9c49aba43e3c524d8ac09474740a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f8f890621e8ce99c36f4117eb018bbb3ec3da960 Author: Jonathan Druart Date: Mon May 18 17:50:11 2020 +0200 Bug 25531: Debar patron if needed when checkin is backdated If think this case does not apply to real-life, but the logic needs to be fixed. If an item is due now, and AddReturn is called now with a return date in the future, the issue is overdue and the patron must be debarred. However it is not as we compare with now and not the return date Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize commit d7066e8cfb50df6e78e8bb1dd491736b1aadcde6 Author: Jonathan Druart Date: Mon May 18 17:49:37 2020 +0200 Bug 25531: Add tests Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- t/db_dependent/Circulation.t | 14 +++++++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 00:40:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 19 May 2020 22:40:28 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-210-g27a11c566f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 27a11c566f783d2a365cada8c38255049dd20e77 (commit) via 77caf35337728e57ee23dc90d4162c1b7184fbf3 (commit) via 4e2078d81b3ccb17e9794a6452578c5e87817e70 (commit) from b8ac29fa8ad26248fb06cee81782ff7fa2ca912f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 27a11c566f783d2a365cada8c38255049dd20e77 Author: Martin Renvoize Date: Thu Mar 26 16:01:37 2020 +0000 Bug 24994: Correct DB Updates Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 77caf35337728e57ee23dc90d4162c1b7184fbf3 Author: Kyle M Hall Date: Tue May 12 10:49:51 2020 -0400 Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks! Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 4e2078d81b3ccb17e9794a6452578c5e87817e70 Author: Jonathan Druart Date: Wed May 13 13:05:48 2020 +0200 Bug 25480: Don't hide apache error and display incorrect error When searching if some apache mod are enable we are hiding the error (2> /dev/null) and display an error about the (guessed) missing module. It can lead to wrong tracks, let display the original apache error if there is one. This is linked with https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/119 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-create | 12 +- installer/data/mysql/updatedatabase.pl | 168 +++++++++++---------- .../intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- 3 files changed, 97 insertions(+), 85 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 01:29:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 19 May 2020 23:29:40 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-218-gc38eea3da3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c38eea3da3a24e207fcdff4e129c8ba7125927cf (commit) via 1ea9aac1085fae84de0f9c7341d0efef0562da81 (commit) via 1a0df6b40b46a0bffe0f5d70a1949bc9b2373c44 (commit) via 9d12eb0a75f3da282b014faa716aa04022f55fce (commit) via faab45536170972298a6f588e59dd3437399f3e3 (commit) via 1f71114d9b56e1aed8fc8582d7fbcbdb41a18e8e (commit) via 25ad50b252941e96541dc2d056559159b7d9dcc2 (commit) via 048894ffa5b7eb8dc1f5f9517be5834a3a889e1c (commit) from 27a11c566f783d2a365cada8c38255049dd20e77 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c38eea3da3a24e207fcdff4e129c8ba7125927cf Author: Nick Clemens Date: Fri May 15 11:46:07 2020 +0000 Bug 25278: add clear_search_fields_cache method Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1ea9aac1085fae84de0f9c7341d0efef0562da81 Author: Nick Clemens Date: Mon Apr 27 14:05:46 2020 +0000 Bug 25278: (follow-up) Fix other occurrences Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1a0df6b40b46a0bffe0f5d70a1949bc9b2373c44 Author: Nick Clemens Date: Fri Apr 24 15:52:50 2020 +0000 Bug 25278: Retrieve correct search fields for authorities Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 9d12eb0a75f3da282b014faa716aa04022f55fce Author: Nick Clemens Date: Fri Apr 24 16:32:06 2020 +0000 Bug 25278: Unit tests Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit faab45536170972298a6f588e59dd3437399f3e3 Author: Nick Clemens Date: Fri Apr 24 16:08:44 2020 +0000 Bug 25277: Unit test Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1f71114d9b56e1aed8fc8582d7fbcbdb41a18e8e Author: Nick Clemens Date: Fri Apr 24 13:34:31 2020 +0000 Bug 25277: Don't specify a field in query if none passed == test plan == To test: 0 - Have Koha running with ES 6 enabled 1 - Launch the z3950 responder: perl misc/z3950_responder.pl --config-dir /kohadevbox/koha/etc/z3950 --debug 2 - Connect using yaz-client: yaz-client localhost:2100 2.1 Alternative, if you add the responder as a Z39.50 server in Koha and do a catalogue Z39.50 search. Don't forget to search in the keywords field. Not the title field. 3 - base biblios 4 - find bruce 5 - No results 6 - Stop the responder 7 - Apply patch 8 - Repeat 9 - This time you get results Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 25ad50b252941e96541dc2d056559159b7d9dcc2 Author: Phil Ringnalda Date: Tue Apr 28 17:16:51 2020 -0700 Bug 25308: Escape querystring for Z39.50 popup from cataloging Test plan: 1. For bonus fun, Administration -> MARC Frameworks -> New framework, with the code A&B and description Ants & Bees 2. In the A&B Actions menu, choose MARC structure since Import won't work 3. Accept the offer to copy in structure from default 4. Cataloging -> New record -> Ants & Bees 5. Type This & That in the 245$a (and for extra credit, in 020$a, and create an author authority with an & in it so you can put it in the 100/110) 6. Click Z39.50/SRU search, make sure everything you typed is prefilled including the parts after & 7. Search for anything that will retrieve a record (the ISBN This & That probably won't), choose Import 8. Check that the record came back, and verify in the Settings menu that it's still in the Ants & Bees framework. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 048894ffa5b7eb8dc1f5f9517be5834a3a889e1c Author: Phil Ringnalda Date: Fri Apr 24 11:34:29 2020 -0700 Bug 11446: Use encodeURIComponent on search terms in authority lookup plugin While adding the data from the existing field to the auth_finder URI, we're using encodeURI(), which is meant for an entire URI and thus doesn't escape &. Things that are going into a querystring need encodeURIComponent() instead. Test plan: 1. Enable the system preference EnableAdvancedCatalogingEditor 2. Clear your browser cache, even a shift+reload won't get you a fresh marc-editor.js for the advanced editor 3. Create a Topical Term authority with 150 $aThis & That$xStuff & Junk 4. In the Basic editor, use the authority plugin on the 650 field to select that authority. 5. Click the authority plugin again, verify that the popup contains This & That and Stuff & Junk rather than just This and Stuff 6. From the Cataloging home page choose Advanced editor 7. In a new line paste 650 _ _ ‡aThis & That‡xStuff & Junk 8. Type ctrl+shift+L and verify the popup shows both words in both fields 9. When you remember the plugin exists there too, edit your Stuff & Junk authority, and in a 550 tag type One & Two in $a and Three & Four in $x and click the plugin link, verify that the search window has your search terms not cut off. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch.pm | 22 +++++++++-- Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +- Koha/Z3950Responder/RPN.pm | 13 +++++-- admin/searchengine/elasticsearch/mappings.pl | 4 +- etc/z3950/attribute_mappings.yaml | 2 - .../lib/koha/cateditor/marc-editor.js | 2 +- .../prog/en/modules/cataloguing/addbiblio.tt | 4 +- koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 2 +- .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 44 ++++++++++++++++++---- .../Koha/SearchEngine/Elasticsearch/Reset.t | 4 +- .../Koha/Z3950Responder/GenericSession.t | 7 +++- 11 files changed, 76 insertions(+), 30 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 01:47:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 19 May 2020 23:47:16 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-219-g359b9f2029 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 359b9f2029a8171d673bbc84d21797283822b7e8 (commit) from c38eea3da3a24e207fcdff4e129c8ba7125927cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 359b9f2029a8171d673bbc84d21797283822b7e8 Author: Jonathan Druart Date: Fri May 8 12:14:07 2020 +0200 Bug 25400: [< 20.05] Fix cloning of circulation rules This patch is for 19.11 and anterior versions. The clone functionnality does not clone the "already moved rules" maxissueqty and maxonsiteissueqty. Test plan: Clone some circ rules from one branch to another Confirm that all the rules have been copied correctly Signed-off-by: Bernardo Gonzalez Kriegel Tested on 19.11, no errors Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: admin/clone-rules.pl | 11 +++++++++++ 1 file changed, 11 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 01:57:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 19 May 2020 23:57:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-225-g5f8d94c98a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5f8d94c98a1f8df817fb4df07574fc20ee125107 (commit) via 301488f66dd81ba5d585400a41b4c58d893bc744 (commit) via 07eefd07b635cc50b5210bccf5c56e283db63680 (commit) via c42e3d94ac42389b6ede92bb56cc1e2288c9fa00 (commit) via d8b49065d1b86cb49e9c894db5640d4eb33db4c6 (commit) via dcae6b8b940df6855e1200aedcafe3b2978146c2 (commit) from 359b9f2029a8171d673bbc84d21797283822b7e8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5f8d94c98a1f8df817fb4df07574fc20ee125107 Author: Martin Renvoize Date: Thu Feb 20 17:15:57 2020 +0000 Bug 23727: (QA follow-up) Fix for boolean flags Signed-off-by: Marcel de Rooy Signed-off-by: Joy Nelson commit 301488f66dd81ba5d585400a41b4c58d893bc744 Author: Martin Renvoize Date: Thu Feb 20 17:10:49 2020 +0000 Bug 23727: (QA follow-up) Fix script tags Signed-off-by: Marcel de Rooy Signed-off-by: Joy Nelson commit 07eefd07b635cc50b5210bccf5c56e283db63680 Author: Kyle M Hall Date: Fri Feb 14 15:22:17 2020 -0500 Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c42e3d94ac42389b6ede92bb56cc1e2288c9fa00 Author: Kyle M Hall Date: Fri Feb 14 08:57:05 2020 -0500 Bug 23727: Add Koha Object(s) related to course reserves Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Joy Nelson commit d8b49065d1b86cb49e9c894db5640d4eb33db4c6 Author: Kyle M Hall Date: Fri Feb 14 08:45:11 2020 -0500 Bug 23727: Update Schema Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Joy Nelson commit dcae6b8b940df6855e1200aedcafe3b2978146c2 Author: Kyle M Hall Date: Fri Feb 14 08:41:28 2020 -0500 Bug 23727: Add new columns Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/CourseReserves.pm | 172 +++++++++++---------- Koha/{Tag.pm => Course.pm} | 6 +- Koha/{Tags/Approval.pm => Course/Instructor.pm} | 6 +- Koha/{Tags/Approvals.pm => Course/Instructors.pm} | 10 +- .../Routinglist.pm => Course/Item.pm} | 51 +++--- Koha/{Tags.pm => Course/Items.pm} | 10 +- Koha/{Tag.pm => Course/Reserve.pm} | 6 +- Koha/{ApiKeys.pm => Course/Reserves.pm} | 13 +- Koha/{Tags.pm => Courses.pm} | 10 +- Koha/Schema/Result/CourseItem.pm | 74 ++++++++- course_reserves/add_items.pl | 32 +++- course_reserves/batch_add_items.pl | 19 ++- installer/data/mysql/atomicupdate/bug_23727.perl | 69 +++++++++ installer/data/mysql/kohastructure.sql | 8 + .../en/modules/course_reserves/add_items-step2.tt | 91 +++++++++-- .../en/modules/course_reserves/batch_add_items.tt | 41 +++-- .../en/modules/course_reserves/course-details.tt | 24 ++- t/db_dependent/CourseReserves/CourseItems.t | 101 +++++++----- 18 files changed, 514 insertions(+), 229 deletions(-) copy Koha/{Tag.pm => Course.pm} (91%) copy Koha/{Tags/Approval.pm => Course/Instructor.pm} (87%) copy Koha/{Tags/Approvals.pm => Course/Instructors.pm} (81%) copy Koha/{Subscription/Routinglist.pm => Course/Item.pm} (63%) copy Koha/{Tags.pm => Course/Items.pm} (84%) copy Koha/{Tag.pm => Course/Reserve.pm} (88%) copy Koha/{ApiKeys.pm => Course/Reserves.pm} (83%) copy Koha/{Tags.pm => Courses.pm} (87%) create mode 100644 installer/data/mysql/atomicupdate/bug_23727.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 02:16:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 20 May 2020 00:16:49 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-231-gc441ee3c3f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c441ee3c3f98a03e9abb5508385d9bf385f9761e (commit) via 45a798f013ef1198f41bfcebdbcbafb5f3ba3e6e (commit) via 3983c20403d8a4565b68226178d6e427cd15219b (commit) via 1393088acb97d24421f5b2c8476c256c91bf0e64 (commit) via aaff66c07a7a3053060ca05183d255304cf85748 (commit) via dcff4dbf53e00a26dfc01d2c7fd4560281429547 (commit) from 5f8d94c98a1f8df817fb4df07574fc20ee125107 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c441ee3c3f98a03e9abb5508385d9bf385f9761e Author: Joy Nelson Date: Tue May 19 23:47:21 2020 +0000 Revert "Bug 23727: Add new columns" This reverts commit dcae6b8b940df6855e1200aedcafe3b2978146c2. commit 45a798f013ef1198f41bfcebdbcbafb5f3ba3e6e Author: Joy Nelson Date: Tue May 19 23:47:11 2020 +0000 Revert "Bug 23727: Update Schema" This reverts commit d8b49065d1b86cb49e9c894db5640d4eb33db4c6. commit 3983c20403d8a4565b68226178d6e427cd15219b Author: Joy Nelson Date: Tue May 19 23:46:50 2020 +0000 Revert "Bug 23727: Add Koha Object(s) related to course reserves" This reverts commit c42e3d94ac42389b6ede92bb56cc1e2288c9fa00. commit 1393088acb97d24421f5b2c8476c256c91bf0e64 Author: Joy Nelson Date: Tue May 19 23:46:46 2020 +0000 Revert "Bug 23727: Editing course reserve items is broken" This reverts commit 07eefd07b635cc50b5210bccf5c56e283db63680. commit aaff66c07a7a3053060ca05183d255304cf85748 Author: Joy Nelson Date: Tue May 19 23:46:41 2020 +0000 Revert "Bug 23727: (QA follow-up) Fix script tags" This reverts commit 301488f66dd81ba5d585400a41b4c58d893bc744. commit dcff4dbf53e00a26dfc01d2c7fd4560281429547 Author: Joy Nelson Date: Tue May 19 23:46:32 2020 +0000 Revert "Bug 23727: (QA follow-up) Fix for boolean flags" This reverts commit 5f8d94c98a1f8df817fb4df07574fc20ee125107. ----------------------------------------------------------------------- Summary of changes: C4/CourseReserves.pm | 172 ++++++++++----------- Koha/Course.pm | 42 ----- Koha/Course/Instructor.pm | 42 ----- Koha/Course/Instructors.pm | 52 ------- Koha/Course/Item.pm | 78 ---------- Koha/Course/Items.pm | 52 ------- Koha/Course/Reserve.pm | 42 ----- Koha/Course/Reserves.pm | 52 ------- Koha/Courses.pm | 52 ------- Koha/Schema/Result/CourseItem.pm | 74 +-------- course_reserves/add_items.pl | 32 +--- course_reserves/batch_add_items.pl | 19 +-- installer/data/mysql/atomicupdate/bug_23727.perl | 69 --------- installer/data/mysql/kohastructure.sql | 8 - .../en/modules/course_reserves/add_items-step2.tt | 91 ++--------- .../en/modules/course_reserves/batch_add_items.tt | 41 ++--- .../en/modules/course_reserves/course-details.tt | 24 +-- t/db_dependent/CourseReserves/CourseItems.t | 101 +++++------- 18 files changed, 177 insertions(+), 866 deletions(-) delete mode 100644 Koha/Course.pm delete mode 100644 Koha/Course/Instructor.pm delete mode 100644 Koha/Course/Instructors.pm delete mode 100644 Koha/Course/Item.pm delete mode 100644 Koha/Course/Items.pm delete mode 100644 Koha/Course/Reserve.pm delete mode 100644 Koha/Course/Reserves.pm delete mode 100644 Koha/Courses.pm delete mode 100644 installer/data/mysql/atomicupdate/bug_23727.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 02:20:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 20 May 2020 00:20:23 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-235-ged219bda7e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via ed219bda7e0ff0cbd888c2c8c4318201472fb17d (commit) via 1d0bcbac9aa24f89d146133fd017100238d4c0db (commit) via 22825f95811d679cae0f87fdc0b6cdef3a2db264 (commit) via 60d890a2b70cc0a15e985d9044ac18ce72a7ce7f (commit) from c441ee3c3f98a03e9abb5508385d9bf385f9761e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ed219bda7e0ff0cbd888c2c8c4318201472fb17d Author: Jonathan Druart Date: Wed Apr 29 14:57:57 2020 +0200 Bug 25309: Limit size of streetnumber field to 10 It's its size in DB (varchar(10)) Test plan: Create or editing a patron and confirm that you fill in more than 10 characters in the streetnumber field Save => The patron has been correctly created/updated Signed-off-by: David Roberts Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1d0bcbac9aa24f89d146133fd017100238d4c0db Author: Katrin Fischer Date: Fri May 1 22:04:15 2020 +0000 Bug 25311: (QA follow-up) Add misssing filter Signed-off-by: Katrin Fischer Signed-off-by: Joy Nelson commit 22825f95811d679cae0f87fdc0b6cdef3a2db264 Author: Jonathan Druart Date: Wed Apr 29 14:48:38 2020 +0200 Bug 25311: Better error handling when updating a patron Same as the precedent patch for patron's modification Test plan is identical but with an existing patron Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Joy Nelson commit 60d890a2b70cc0a15e985d9044ac18ce72a7ce7f Author: Jonathan Druart Date: Wed Apr 29 14:38:41 2020 +0200 Bug 25311: Better error handling when creating a patron This is still not ideal but brings a bit of enhancement. One possible problem is that the patron creation will fail if the streetnumber field is too long (borrowers.streetnumber is varchar(10). Test plan: 0. Don't apply this patch 1. Create a new patron with a streetnumber longer than 10 characters 2. Save => The patron has not been created and the app explodes The error is about extended_attributes and not meaningful Can't call method "extended_attributes" on an undefined value at /kohadevbox/koha/members/memberentry.pl line 560 3. Apply the patch 4. Repeat 1. and 2 => You get a warning on the interface and you still see the creation form 5. Check the logs => The error is meaningful "Data too long for column 'streetnumber'" Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: .../en/includes/member-main-address-style-de.inc | 2 +- .../en/includes/member-main-address-style-fr.inc | 2 +- .../en/includes/member-main-address-style-us.inc | 2 +- .../prog/en/modules/members/memberentrygen.tt | 13 +++ members/memberentry.pl | 125 ++++++++++++--------- 5 files changed, 88 insertions(+), 56 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 10:46:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 20 May 2020 08:46:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2262-g5f9cc8ada9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5f9cc8ada9a3186265f7c4fff1529775f03ac969 (commit) via d517453d95b3a16f9cdc61910a53433310ca2c7f (commit) via f342b0b617237f05287518b6bbf749c7db533a5c (commit) via 067f1b8b556015bbd0f35f36aac700d79467786b (commit) via c6ed5b5da125347ef95ae439eaf21858410f7edf (commit) from f8f890621e8ce99c36f4117eb018bbb3ec3da960 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5f9cc8ada9a3186265f7c4fff1529775f03ac969 Author: Jonathan Druart Date: Tue May 19 14:26:56 2020 +0200 Bug 25284: chown /var/log/koha log files on koha-create To prevent Apache to create intranet-error.log and opac-error.log with root permission we chown them after it has been restarted (and so created them) when a new Koha instance is created Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit d517453d95b3a16f9cdc61910a53433310ca2c7f Author: David Cook Date: Mon May 18 05:41:34 2020 +0000 Bug 25485: Remove tiny_mce symlink during pre install of deb package This patch removes the tiny_mce symlink before Koha package installation using the same method that we used when we removed the YUI symlink in 2015. Signed-off-by: David Cook Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit f342b0b617237f05287518b6bbf749c7db533a5c Author: David Cook Date: Mon May 18 03:28:56 2020 +0000 Bug 25485: Remove all mention of tiny_mce in debian/rules This patch removes the removal of the following during the build process: /usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce Signed-off-by: David Cook Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 067f1b8b556015bbd0f35f36aac700d79467786b Author: Kyle M Hall Date: Tue May 12 14:19:53 2020 -0400 Bug 25485: TinyMCE broken in Debian package installs When installing the Debian package of Koha, we install the Debian tinymce package and symlink over our own tinymce libs that are in the Koha codebase. This version of tinymce does not have the same files and because of this, tinymce does not get loaded. We should remove the use of the tinymce Debian package, and just use our own version of TinyMCE. Test Plan: 1) Install Koha 19.11 from package 2) Browse to the news editor 4) Note the WYSIWYG editor is missing 5) Build a new Koha package with this patch applied, install it 6) Reload the news editor 7) Note the WYSIWYG editor is back! Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit c6ed5b5da125347ef95ae439eaf21858410f7edf Author: David Cook Date: Mon May 18 07:08:18 2020 +0000 Bug 25524: Remove --line-regexp option in log4perl_component() The current grep expression uses -x|--line-regexp, but that causes the regexp to fail to match since we're not specifying a regexp that can match a whole line. We can either provide a better regexp, or remove that --line-regexp option. This patch removes the --line-regexp (ie -x) option from the grep in log4perl_component, so that it detects logger components correctly. To Test: 0) Apply patch 1) Build Koha package 2) Look at /etc/koha/sites/kohadev/log4perl.conf in an existing Koha instance (e.g. on koha-testing-docker), and note it has components for z3950, api, and sip 3) Install package 4) Note that /etc/koha/sites/kohadev/log4perl.conf is the same as before 5) Remove the "log4perl.logger.sip and log4perl.appender.SIP lines from /etc/koha/sites/kohadev/log4perl.conf 6) Reinstall package 7) Note that the missing lines have been appended to the file at /etc/koha/sites/kohadev/log4perl.conf Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: debian/control.in | 2 -- debian/koha-common.postinst | 2 +- debian/koha-common.preinst | 3 +++ debian/rules | 4 ---- debian/scripts/koha-create | 2 ++ 5 files changed, 6 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 17:10:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 20 May 2020 15:10:51 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-237-g8e51e6d968 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8e51e6d968d2ceecfee298cb313ce74ae373d2f0 (commit) via d4f6f65cb73d9c9e78cca16a8b246e72bb661f9d (commit) from ed219bda7e0ff0cbd888c2c8c4318201472fb17d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8e51e6d968d2ceecfee298cb313ce74ae373d2f0 Author: David Cook Date: Mon May 18 06:23:07 2020 +0000 Bug 25510: Put space between negation operator and function name This patch puts a space between the negation operator ! and the function name (ie log4perl_component). Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joy Nelson commit d4f6f65cb73d9c9e78cca16a8b246e72bb661f9d Author: Jonathan Druart Date: Fri May 15 10:12:46 2020 +0200 Bug 25510: Fix syntax error in koha-common.postinst Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: debian/koha-common.postinst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 17:28:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 20 May 2020 15:28:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-239-ga17ea63d02 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a17ea63d028fe500f80ff75b42a4fa1a511fe708 (commit) via 12b91faa040d9b0fd166074df587f7394959b0e9 (commit) from 8e51e6d968d2ceecfee298cb313ce74ae373d2f0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a17ea63d028fe500f80ff75b42a4fa1a511fe708 Author: Joy Nelson Date: Wed May 20 14:59:21 2020 +0000 Bug 24854: DBRev 19.11.05.007 Signed-off-by: Joy Nelson commit 12b91faa040d9b0fd166074df587f7394959b0e9 Author: Jonathan Druart Date: Wed May 20 15:01:54 2020 +0200 Bug 24854: Disable IDreamBooks sysprefs Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 19:39:08 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 20 May 2020 17:39:08 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-240-gdbcae29fa7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via dbcae29fa74f592deb8ef638179eae1bd451c076 (commit) from a17ea63d028fe500f80ff75b42a4fa1a511fe708 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dbcae29fa74f592deb8ef638179eae1bd451c076 Author: Joy Nelson Date: Wed May 20 17:11:03 2020 +0000 Bug 24854: DBRev correction Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 23:18:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 20 May 2020 21:18:28 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-242-g4178233de1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4178233de18d8bb94ebc65e7a8d1f6afec6aeff2 (commit) via 0ab0f61657d7a93b5eab1fe4327b7254c10032e3 (commit) from dbcae29fa74f592deb8ef638179eae1bd451c076 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4178233de18d8bb94ebc65e7a8d1f6afec6aeff2 Author: Tomas Cohen Arazi Date: Mon May 11 08:38:49 2020 -0300 Bug 25416: Unit tests This patch adds tests for the new 'feature': i.e. searchResults passes the added $xslt_variables to the XSLTParse4Display method. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Joy Nelson commit 0ab0f61657d7a93b5eab1fe4327b7254c10032e3 Author: Tomas Cohen Arazi Date: Thu May 7 14:23:40 2020 -0300 Bug 25416: Let OPAC XSLTs know if the context is an anonymous session This patch makes use of the 'variables' parameter in XSLTParse4Display method in the different places that it is used in the OPAC. It does by passing this parameter with anonymous_session => 1|0 The value will depend on the output from get_template_and_user (i.e. if there's a returned borrowernumber). A special case takes place in search results, as the call to XSLTParse4Display happens in C4::Search::searchResults. So a new parameter 'xslt_variables' is added to it. To test: 1. Apply the [DO NOT PUSH] patch 2. Open the OPAC in your browser 3. Try detail pages, search results, tags and lists/shelves pages with or without an active session => FAIL: It always says (somewhere) 'Anonymous session: Yes' 4. Apply this patch, restart_all 5. Repeat 3 => SUCCESS: It will tell the Yes/No correctly regarding anonymous sessions! 6. Sign off :-D Sponsored-by: Universidad ORT Uruguay Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 4 ++-- opac/opac-detail.pl | 11 ++++++++--- opac/opac-search.pl | 6 ++++-- opac/opac-shelves.pl | 14 +++++++++++--- opac/opac-tags.pl | 12 +++++++++--- t/db_dependent/Search.t | 12 +++++++++++- 6 files changed, 45 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 23:29:02 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 20 May 2020 21:29:02 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-244-ge78231f3f6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via e78231f3f63ed49fc65ac653e57159a8aba7fbe2 (commit) via 448915cc3d8dcd92ce93736bea09a5a0a113dc03 (commit) from 4178233de18d8bb94ebc65e7a8d1f6afec6aeff2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e78231f3f63ed49fc65ac653e57159a8aba7fbe2 Author: Tomas Cohen Arazi Date: Mon May 11 10:10:39 2020 -0300 Bug 24458: Use the ViewPolicy filter on search results This patch implements the use of the ViewPolicy record processor filter inside C4::Search::searchResults. The idea is that the $record_processor is instantiated once and reused inside the loop. This leaves options for further optimizations I will do on a follow-up bug. The filter is applied to the MARC data before it is passed to the XSLT processor. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: This is not implemented, tests fail 3. Apply this patch 4. Repeat 2 5. Feel the joy in your body from a long standing bug being solved 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 448915cc3d8dcd92ce93736bea09a5a0a113dc03 Author: Tomas Cohen Arazi Date: Mon May 11 10:08:36 2020 -0300 Bug 24458: Regression tests This patch introduces tests for searchResults. The idea is to set a subfield as hidden in OPAC and another on the staff interface, and see if searchResults honours this on the XSLTResultsRecord contents. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: This is not really implemented Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 11 +++++++++++ t/db_dependent/Search.t | 50 ++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 60 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 20 23:57:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 20 May 2020 21:57:33 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-246-ga2e8131dc2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a2e8131dc2bd1e9b38e836744e0fc0fa67ebf6ce (commit) via df41ff4a9c54c0e958bbdb49acec671c024ec29e (commit) from e78231f3f63ed49fc65ac653e57159a8aba7fbe2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a2e8131dc2bd1e9b38e836744e0fc0fa67ebf6ce Author: David Cook Date: Mon May 18 07:08:18 2020 +0000 Bug 25524: Remove --line-regexp option in log4perl_component() The current grep expression uses -x|--line-regexp, but that causes the regexp to fail to match since we're not specifying a regexp that can match a whole line. We can either provide a better regexp, or remove that --line-regexp option. This patch removes the --line-regexp (ie -x) option from the grep in log4perl_component, so that it detects logger components correctly. To Test: 0) Apply patch 1) Build Koha package 2) Look at /etc/koha/sites/kohadev/log4perl.conf in an existing Koha instance (e.g. on koha-testing-docker), and note it has components for z3950, api, and sip 3) Install package 4) Note that /etc/koha/sites/kohadev/log4perl.conf is the same as before 5) Remove the "log4perl.logger.sip and log4perl.appender.SIP lines from /etc/koha/sites/kohadev/log4perl.conf 6) Reinstall package 7) Note that the missing lines have been appended to the file at /etc/koha/sites/kohadev/log4perl.conf Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit df41ff4a9c54c0e958bbdb49acec671c024ec29e Author: Kyle M Hall Date: Mon May 18 14:14:42 2020 -0400 Bug 25535: Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/Hold.pm | 2 +- api/v1/swagger/definitions/hold.json | 2 +- api/v1/swagger/paths/holds.json | 2 +- debian/koha-common.postinst | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 21 18:35:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 21 May 2020 16:35:18 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-249-g40f8cba93b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 40f8cba93b5ec052fd0de1f41a85d5f03dd3a147 (commit) via 8dceed40687df7acbfb1df2e2cc988e96194c6fd (commit) via 62a448b5d778907978b117611e7d26c9a58fc399 (commit) from a2e8131dc2bd1e9b38e836744e0fc0fa67ebf6ce (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 40f8cba93b5ec052fd0de1f41a85d5f03dd3a147 Author: David Cook Date: Mon May 18 05:41:34 2020 +0000 Bug 25485: Remove tiny_mce symlink during pre install of deb package This patch removes the tiny_mce symlink before Koha package installation using the same method that we used when we removed the YUI symlink in 2015. Signed-off-by: David Cook Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8dceed40687df7acbfb1df2e2cc988e96194c6fd Author: David Cook Date: Mon May 18 03:28:56 2020 +0000 Bug 25485: Remove all mention of tiny_mce in debian/rules This patch removes the removal of the following during the build process: /usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce Signed-off-by: David Cook Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 62a448b5d778907978b117611e7d26c9a58fc399 Author: Kyle M Hall Date: Tue May 12 14:19:53 2020 -0400 Bug 25485: TinyMCE broken in Debian package installs When installing the Debian package of Koha, we install the Debian tinymce package and symlink over our own tinymce libs that are in the Koha codebase. This version of tinymce does not have the same files and because of this, tinymce does not get loaded. We should remove the use of the tinymce Debian package, and just use our own version of TinyMCE. Test Plan: 1) Install Koha 19.11 from package 2) Browse to the news editor 4) Note the WYSIWYG editor is missing 5) Build a new Koha package with this patch applied, install it 6) Reload the news editor 7) Note the WYSIWYG editor is back! Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: debian/control.in | 2 -- debian/koha-common.preinst | 3 +++ debian/rules | 4 ---- 3 files changed, 3 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 21 23:18:00 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 21 May 2020 21:18:00 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-257-g0c238db2f5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 0c238db2f5763db48fe3d451b599ffd6b0e42869 (commit) via 6066bb39a5ed9b284bf2344e4b98394e89f809a3 (commit) via b0551cfd178565b5b30980096f53d4fffcfca454 (commit) via 403c2a4753db50897370442f907438357bc5f03b (commit) via 840b417890cdd341922cb3a086b08946bb96736d (commit) via 20a6b0f7dbe6db1f5b47b8bb7371b7b0cd192062 (commit) via dbc4e4c63d83beed132a4d9b20ef47b2327f4f67 (commit) via 7e4296c4194afaa722a20b114cf928e2f17d7ad0 (commit) from 40f8cba93b5ec052fd0de1f41a85d5f03dd3a147 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0c238db2f5763db48fe3d451b599ffd6b0e42869 Author: Jonathan Druart Date: Mon May 18 17:50:11 2020 +0200 Bug 25531: Debar patron if needed when checkin is backdated If think this case does not apply to real-life, but the logic needs to be fixed. If an item is due now, and AddReturn is called now with a return date in the future, the issue is overdue and the patron must be debarred. However it is not as we compare with now and not the return date Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 6066bb39a5ed9b284bf2344e4b98394e89f809a3 Author: Jonathan Druart Date: Mon May 18 17:49:37 2020 +0200 Bug 25531: Add tests Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b0551cfd178565b5b30980096f53d4fffcfca454 Author: Jonathan Druart Date: Mon Mar 16 17:19:22 2020 +0100 Bug 24881: [19.11.x] Try to fix random failure from Circulation.t This is a follow-up of bug 22917. Signed-off-by: Joy Nelson commit 403c2a4753db50897370442f907438357bc5f03b Author: Jonathan Druart Date: Thu May 14 16:04:20 2020 +0200 Bug 25481: Pass --user to start-stop-daemon when a pidfile is used Since D10, the behaviour of start-stop-daemon changed, see from its manual: """ Warning: using this match option with a world-writable pidfile or using it alone with a daemon that writes the pidfile as an unprivileged (non-root) user will be refused with an error (since version 1.19.3) as this is a security risk, because either any user can write to it, or if the daemon gets compromised, the contents of the pidfile cannot be trusted, and then a privileged runner (such as an init script executed as root) would end up acting on any system process. Using /dev/null is exempt from these checks. """ Test plan: koha-plack --restart kohadev should success with this patch. Without this patch you get: start-stop-daemon: matching only on non-root pidfile /var/run/koha/kohadev/plack.pid is insecure Signed-off-by: Nick Clemens Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 840b417890cdd341922cb3a086b08946bb96736d Author: Nick Clemens Date: Mon Apr 13 15:51:36 2020 +0000 Bug 23403: Catch other cases of ->{patron} Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Joy Nelson commit 20a6b0f7dbe6db1f5b47b8bb7371b7b0cd192062 Author: Jonathan Druart Date: Mon Mar 23 15:57:14 2020 +0100 Bug 23403: List borrowernumber in the ILS::Patron fields Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Joy Nelson commit dbc4e4c63d83beed132a4d9b20ef47b2327f4f67 Author: Kyle M Hall Date: Mon Mar 23 08:52:58 2020 -0400 Bug 23403: Fix whitespace Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Joy Nelson commit 7e4296c4194afaa722a20b114cf928e2f17d7ad0 Author: Jonathan Druart Date: Thu Nov 21 18:39:15 2019 +0100 Bug 23403: Remove cardnumber from SIP == Test plan == 1 - Have two patrons with userids and no cardnumber 2 - Note which of these has the higher borrower number 3 - Use the SIP cli emulator to connect and checkout a book to the patron with higher borrowernumber See example after 4 - Note the book may checkout to the wrong patron! 5 - Apply patch 6 - Checkout to both patrons via sip 7 - The patrons get the correct checkouts === SIP CLI emulator === ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 \ -l CPL --patron 23529001000463 -m checkout --item 39999000001259 translation: via the koha user term1, checkout item 39999000001259 to patron 23529001000463 Signed-off-by: Bouzid Fergani Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- C4/SIP/ILS.pm | 16 ++++---- C4/SIP/ILS/Item.pm | 8 ++-- C4/SIP/ILS/Patron.pm | 1 + C4/SIP/ILS/Transaction/Checkout.pm | 22 +++++----- C4/SIP/ILS/Transaction/Hold.pm | 39 ++++++------------ C4/SIP/ILS/Transaction/Renew.pm | 3 +- debian/scripts/koha-functions.sh | 2 + debian/scripts/koha-plack | 2 +- t/db_dependent/Circulation.t | 82 +++++++++++++++++++++++--------------- 10 files changed, 90 insertions(+), 87 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 00:51:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 21 May 2020 22:51:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-258-gd3a009efcc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via d3a009efcc37a8aa4ad2dd4a3fdd17657d305b7b (commit) from 0c238db2f5763db48fe3d451b599ffd6b0e42869 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d3a009efcc37a8aa4ad2dd4a3fdd17657d305b7b Author: Joy Nelson Date: Thu May 21 22:23:33 2020 +0000 Increment version for 19.11.06 release Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 01:03:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 21 May 2020 23:03:13 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-259-g1ee852d09c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 1ee852d09c001259f9d6cd34897c614f2bd10ecd (commit) from d3a009efcc37a8aa4ad2dd4a3fdd17657d305b7b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1ee852d09c001259f9d6cd34897c614f2bd10ecd Author: Joy Nelson Date: Thu May 21 22:35:29 2020 +0000 Update release notes for 19.11.06 release Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: misc/release_notes/release_notes_19_11_06.html | 861 +++++++++++++++++++++++++ misc/release_notes/release_notes_19_11_06.md | 681 +++++++++++++++++++ 2 files changed, 1542 insertions(+) create mode 100644 misc/release_notes/release_notes_19_11_06.html create mode 100644 misc/release_notes/release_notes_19_11_06.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 01:04:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 21 May 2020 23:04:50 +0000 Subject: [koha-commits] main Koha release repository annotated tag v19.11.06 created. v19.11.06 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v19.11.06 has been created at 03e54fb2810a3106c5a393c3ef2cfb19da4bff5f (tag) tagging 1ee852d09c001259f9d6cd34897c614f2bd10ecd (commit) replaces v19.11.05 tagged by Joy Nelson on Thu May 21 15:37:05 2020 -0700 - Log ----------------------------------------------------------------- Koha release 19.11.06 -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEoK5tmgY9tfjnUxz9nJetzohwl0IFAl7HApEACgkQnJetzohw l0LN+gwA0ErCDetsiNmcD/+qfzsCgUHEh9c4RIEhNF9pnP3r9DF3K+coKYIl38C0 p5cK4e06IoSmGMRIoyRyVRgEMyrpOf5E6lbRz96OfogGurgIH5003ozszHTukD55 pz5XclUMAOZ63YmLzRt60jiMaZ5mxZgmn9IUpBZ06JWjgnga/TJXUvLZPZsROdIp 5lSR3ZFPm0Z7l9daciKaHm4HkSDvIjhP0NFT71sdPevl/yWT4D//AwBYJgtqU+9D fvvWtDNLI5N8mjhwRoFOGNwbIDRzIAXrQdEZJ8EvMHWUr+FD9hV26gl4fIylFZ/r THwXU1E12L4bJXsnz6aFIX2o5bZfshaju7s/HmVFwBu8vXrKEWV9XN+xHVg6CFDh k6xTnsP6tM5cMSdoINBvpPhXY5ARI3z81pVNaYpUEZnG91uyCwa9qjhTubuQup0M 40QZqIP3YD2Wu+PqQGDSLveKHhGVbX5OGGRQeYvyrogBIEt1KPVMUvSGT1wabovL EmuQob50 =2o+1 -----END PGP SIGNATURE----- Agustin Moyano (1): Bug 25086: Set changed_fields column as nullable Aleisha Amohia (1): Bug 24266: (alternate patch) Only use defined borrowernumbers in reconcile_balances.pl cron Andreas Roussos (1): Bug 25046: Include borrowers.othernames in SELECT statement Andrew Fuerste-Henry (4): Bug 25224: Show large print format in search results XSLT Bug 23081: set default to 0 for items.issues and deleteditems.issues Bug 23081: atomicupdate for change to existing installs Bug 25335: group by authorised_value in addbiblio.pl Andrew Isherwood (1): Bug 24043: Fix retrieval of of status name Bernardo González Kriegel (3): Bug 25257: Preserve prolog on translated XML files Bug 24636: translate planning sections Bug 24636: (follow-up) - move 'by' into include file David Cook (6): Bug 25300: Fix typo in "Edit details" for expiring/expired patron Bug 25299: Show soon to expire patron date Bug 25510: Put space between negation operator and function name Bug 25524: Remove --line-regexp option in log4perl_component() Bug 25485: Remove all mention of tiny_mce in debian/rules Bug 25485: Remove tiny_mce symlink during pre install of deb package David Roberts (6): Bug 24940: Serials statistics wizard: order vendor list alphabetically Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it Bug 25053: Clarify the description of syspref PatronSelfRegistrationExpireTemporaryAccountsDelay Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a Bug 25388: There is no link for the "online help" Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) Didier Gautheron (2): Bug 25291: Escape barcode in ReturnClaims table display Bug 24740: Use biblio title rather than biblio number in OPAC search result cover images tooltips Emmi Takkinen (2): Bug 19475: Add unit tests Bug 19475: Don't copy holiday if it already exists in target calendar Fridolin Somers (4): Bug 21865: improve remove_unused_authorities.pl script Bug 21865: ES compatiblity of remove_unused_authorities.pl Bug 21865: add confirm to remove_unused_authorities.pl script Bug 21865: allow test arg alone George Veranis (1): Bug 19312: Fix typo in template Grace McKenzie (1): Bug 17853: Don't remove () from 780 link text Janusz Kaczmarek (1): Bug 25081: Fix creation of new item for a received issue Jonathan Druart (45): Bug 19475: Clear the caches at the end of the tests Bug 24964: [19.11.x] Add tests Bug 24964: [19.11.x] Do not filter patrons after they have been fetched Bug 24964: [19.11.x] Prevent random failures sorting by borrowernumber Bug 24964: [19.11.x] Do not fetch all patrons for owner/users of funds Bug 25024: Do not escape $ Bug 24826: Remove warnings from Sendmail Bug 25046: Add test Bug 25081: Fix wrong comment Bug 25038: Fix tabs on the OPAC reading history view Bug 24993: Make sure SIP server is stopped before restarting it Bug 24993: Make sure we are not going to loop indefinitely Bug 25027: Use localStorage instead of sessionStorage for results browser Bug 25069: Fix AddressFormat="fr" behavior Bug 24800: Handle inexistent return date on self checking Bug 24800: Add tests Bug 25186: Fix accordion sections height in columns configuration page Bug 23081: Revert "Bug 24443: Consider NULL as 0 for issues in items search" Bug 23081: Adjust tests Bug 24339: Do not assume there are exactly 3 SIP* AVs Bug 22828: Add tests Bug 23137: Move cache flushing to the method Bug 23081: [19.11.x] Set items.issues to 0 if not provided (AddItem) Bug 24801: Display all the categories - Selenium fix Bug 24801: Display all the libraries - Selenium fix Bug 24801: (follow-up) Display all the libraries - Selenium fix Bug 25133: Fix time part of due date for 12hr Bug 25133: Handle 12hr format for dt_from_string Bug 25157: Silent patron deletion cmd line script Bug 25301: Removed URI parameter "categorycode" from the toolbar Bug 25417: Prevent negative debit amount on backdating returns Bug 25418: (bug 25133 follow-up) Display due date with hours Bug 25480: Don't hide apache error and display incorrect error Bug 25400: [< 20.05] Fix cloning of circulation rules Bug 25311: Better error handling when creating a patron Bug 25311: Better error handling when updating a patron Bug 25309: Limit size of streetnumber field to 10 Bug 25510: Fix syntax error in koha-common.postinst Bug 24854: Disable IDreamBooks sysprefs Bug 23403: Remove cardnumber from SIP Bug 23403: List borrowernumber in the ILS::Patron fields Bug 25481: Pass --user to start-stop-daemon when a pidfile is used Bug 24881: [19.11.x] Try to fix random failure from Circulation.t Bug 25531: Add tests Bug 25531: Debar patron if needed when checkin is backdated Josef Moravec (1): Bug 24043: (QA follow-up) Fix another TypeError when retrieving status name Joseph Sikowitz (1): Bug 24750: Instructor Search Results Joy Nelson (22): Bug 25010: DBRev 19.11.05.001 Bug 20754: DBRev 19.11.05.002 Bug 25086: DBRev 19.11.05.003 Bug 25176: Compiled CSS Bug 25276: Compiled CSS Bug 23081: DBRev 19.11.05.004 DBIC update Bug 23081: followup remove atomicupdate file Bug 25184: DBRev 19.11.05.005 Bug 25184: (follow-up) fix number of tests Bug 25478: DBRev 19.11.05.006 DBRev: RMaint (follow-up) correct Koha.pm version Revert "Bug 23727: (QA follow-up) Fix for boolean flags" Revert "Bug 23727: (QA follow-up) Fix script tags" Revert "Bug 23727: Editing course reserve items is broken" Revert "Bug 23727: Add Koha Object(s) related to course reserves" Revert "Bug 23727: Update Schema" Revert "Bug 23727: Add new columns" Bug 24854: DBRev 19.11.05.007 Bug 24854: DBRev correction Increment version for 19.11.06 release Update release notes for 19.11.06 release Julian Maurice (1): Bug 24604: Add 'Pay' button under Transactions tab in patron accounting Katrin Fischer (24): Bug 9422: Don't allow access to 'Upload patron images' when patronimages syspref is off Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options Bug 25013: Fix capitalization: Edit Items on batch item edit Bug 25012: Fix class on OPAC view link in staff detail page Bug 24941: Serials - Fix link to basket from acquisition details information Bug 17938: Fix display of label for repeated MARC 583 - Action note fields Bug 25010: Fix typo 'rewewal' in debit types Bug 25120: Make accounting the default tab when opening the pref editor Bug 22468: Standardize on labelling ccode table columns as Collections Bug 10561: Rephrase DisplayOPACiconsXSLT and DisplayIconsXSLT slightly Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs Bug 13557: Add hint for on-site checkouts to list of current checkouts in OPAC Bug 14369: Only show 'Create labels' link on staged records import when status is imported Bug 24768: Add 'Return claims' to column configuration for checkouts tables Bug 21927: Acq - Add blank values in pull downs of mandatory item subfields Bug 17232: Make sure all fields are copies when creating a new framework from another Bug 24995: (QA follow-up) Terminology: Use checkin and checkout Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql Bug 15727: Add MARC21 385 - Audience to detail pages Bug 25082: Make 041 descriptions display, if authorised value list is used Bug 25082: Don't remove characters from string Bug 25311: (QA follow-up) Add misssing filter Kyle M Hall (23): Bug 24964: [19.11.x] Fix perl critic warning Bug 22937: Add hint to groups editor Bug 22778: Suggestions with no "suggester" can cause errors Bug 22778: Add unit test Bug 25095: Remove warn left in FeePayment.pm Bug 24966: Add unit tests Bug 24547: Add more action logs for holds Bug 20101: Cronjob automatic_item_modification_by_age.pl does not log run in action logs Bug 25227: Add unit tests Bug 25227: Display correct message if item is lost and lost returns are allowed Bug 25227: Display correct message if item is withdrawn and withdrawn returns are allowed Bug 25107: Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType Bug 25184: Items with a negative notforloan status should not be captured for holds Bug 25184: Add syspref Bug 25417: Add unit test Bug 25468: Preserve line breaks in hold notes Bug 23727: Add new columns Bug 23727: Update Schema Bug 23727: Add Koha Object(s) related to course reserves Bug 23727: Editing course reserve items is broken Bug 25535: Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date Bug 25485: TinyMCE broken in Debian package installs Bug 23403: Fix whitespace Liz Rea (1): Bug 24993: fix increment Lucas Gass (8): Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature Bug 25007: Check for normaalized ISBN when building Amazon link Bug 24957: OpenLibrarySearch shouldnt display if nothing is returned Bug 25233: Staff XSLT material type label "Book" should be "Text" Bug 25072: Fix details.tt print CSS Bug 21565: Add modal to SCO confirm Bug 25341: Remove whitespace from barcode in add_items.pl Bug 24995: Add issuedate to table_account_fines and finest Marcel de Rooy (7): Bug 20754: DB revision to remove double accepted shares Bug 24966: (QA follow-up) Fix return value of hold_patron_bcode Bug 24903: Special characters like parentheses in numbering pattern cause duplication in recievedlist Bug 24903: Add tests for _handle_seqno Bug 22437: Add test case to Merge.t Bug 22437: Delete older merge requests at new merge time Bug 22437: (follow-up) Move deletion of merge requests to DelAuthority Martin Renvoize (20): Bug 9422: (RM follow-up) Rebase Correction Bug 24183: Add before_send_messages hook Bug 25040: monkeypatch Schema::Loader for recent MariaDB Bug 20484: (RM follow-up) Highlight ES disablement Bug 25123: (QA follow-up) Re-used variable name Bug 24768: (RM follow-up) Add missing koha_object_class's Bug 24339: Add SIP2 payment types for installation Bug 24339: Remove SIP payment types from staff pay screens Bug 25127: Correction to tests Bug 25127: Use Koha::Number::Price->round for comparison Bug 15751: Add ModDateLastSeen to ProcessOfflineReturn Bug 25478: (25389 backport) Correct original DB update for bug 22563 Bug 25478: (25389 backport) Correct stray cases of LOST_RETURNED Bug 25478: (25389 backport) Catch errant cases of LOST_RETURNED Bug 25417: (QA follow-up) Clarify _FixOverduesOnReturn test Bug 25417: (QA follow-up) Restore 'fixing' of fines Bug 25417: (QA follow-up) Add integration test for AddReturn Bug 24994: Correct DB Updates Bug 23727: (QA follow-up) Fix script tags Bug 23727: (QA follow-up) Fix for boolean flags Nick Clemens (35): Bug 19014: [19.11.x] Prevent auto_renew notices form sending if too early to renew Bug 23601: Prevent default for auxclick Bug 25024: Make grep match full string Bug 25050: Unit tests Bug 25050: Adjust marc_records_to_documents to search entire mapping array Bug 24620: [19.11.x] Close existing transfer when hold set to waiting (squashed) Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string Bug 20484: Allow configuration of ES before switching to ES Bug 20484: Implement blocking_errors for ES config page Bug 25123: Unit tests Bug 25123: Count the current fine when reducing for maxFine Bug 25223: Make join of aqbasket and aqorders explicit Bug 25229: Unit test Bug 25229: Return authid of record rather than 001 Bug 25229: (follow-up) Move QueryBuilder test to Elasticsearch dir Bug 25231: Rename button instead of alert/confirm when replacing record Bug 22828: Elasticsearch - display errors encountered during indexing on the command line Bug 23137: Add reset option to rebuild_elasticsearch.pl Bug 23137: Add reset and delete to koha-elasticsearch Bug 23137: Add documentation Bug 25127: Unit tests Bug 25247: Only convert data ot objects when displaying on screen Bug 20816: [19.11.x] Add ability to define custom templated fields in SIP patron responses Bug 25133: (follow-up) Remove Names as they do no affect display Bug 25133: (follow-up) Move changes to timepicker.inc Bug 25342: Force ES id as string Bug 25342: Unit test Bug 25418: (QA follow-up) Raise size of input box Bug 25277: Don't specify a field in query if none passed Bug 25277: Unit test Bug 25278: Unit tests Bug 25278: Retrieve correct search fields for authorities Bug 25278: (follow-up) Fix other occurrences Bug 25278: add clear_search_fields_cache method Bug 23403: Catch other cases of ->{patron} Nicolas Legrand (1): Bug 25099: Sending a LANG variable to plug-in template Olli-Antti Kivilahti (1): Bug 18227: Handle utf8 in Koha::Logger Owen Leonard (13): Bug 25022: Display problem in authority editor with repeatable field Bug 25007: (follow-up) Fix the way image check alters layout Bug 25176: Fix style of checkout form Bug 25016: Coce should not return a 1-pixel Amazon cover image Bug 25118: Return claims has some translation issues Bug 25274: Don't initialize DataTable if table isn't present Bug 25211: Add missing share icon to OPAC lists page Bug 25276: Correct hover style of list share button in the OPAC Bug 21565: (follow-up) Make confirmation buttons more detailed Bug 22515: Improve logic determining how to show OPAC suggestions Bug 25340: Pass biblio object to OPAC comments template Bug 24522: Show alert when trying to add nothing to a list in staff Bug 25343: Use of item in review/comment feature is misleading Petro Vashchuk (2): Bug 25301: removed useless URI parameter "categorycode" from template Bug 25301: removed URI parameter "categorycode" from "circulation.tt" Phil Ringnalda (4): Bug 20501: Don't cut strings when unhighlighting in intranet search results Bug 25235: Rename the button instead of alerting when replacing an existing record Bug 11446: Use encodeURIComponent on search terms in authority lookup plugin Bug 25308: Escape querystring for Z39.50 popup from cataloging Slava Shishkin (2): Bug 25409: Add missing "required" class to template Bug 25409: Add missing "Required" text and "required" classes Theodoros Theodoropoulos (1): Bug 23514: Split Call Numbers for all layout types Tomás Cohen Arazi (13): Bug 25006: Regression tests Bug 25006: Make Koha::Item->as_marc_field skip undefined subfields Bug 18227: (QA follow-up) Add fix to koha-common.postinst Bug 25019: Make the ViewPolicy filter initialization standard Bug 25008: Regression tests Bug 25008: Tests for ->options Bug 25008: Overload Koha::RecordProcessor->options to update filters Bug 24908: Unit tests Bug 24908: Add text-formatted MARC support in /biblios/{biblio_id} Bug 25416: Let OPAC XSLTs know if the context is an anonymous session Bug 25416: Unit tests Bug 24458: Regression tests Bug 24458: Use the ViewPolicy filter on search results ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 11:02:09 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 09:02:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2279-g85ab68c07f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 85ab68c07f9240eba08d74b232be8434e65e9afb (commit) via 9e665fb9a753032fed711959f1d8cc5780655b8c (commit) via 4e945dff87a8bc4badb605361c1db63f71b04a07 (commit) via 7ce6f7895610913f35fb1531faa1a40cefcd5f88 (commit) via bbe6b07f4340afca18763724194fbc577b77959d (commit) via 10af741387a75d29c6b7782c6ce3d2c07cad9517 (commit) via 70ae2eaf9cdc7708f85b1724e5bc89623355b585 (commit) via aa1f0fd73fa2a8dadd86ef5defc390e164845429 (commit) via e9e8b635e14fe1229006b556e8aa0babf61455c7 (commit) via d864c5640a3e3b02cbb64bde034935fa746a09ce (commit) via 1bcc45be621b19dc602d675ca10d844301496b06 (commit) via 635242a69a5ed049801d018a6be712d8dcbabb07 (commit) via 67ff0f72854d4dabdda8cb59696f15e7b5d88c2a (commit) via 37370c415ab5e59422aff46be14ccfec0cf8c373 (commit) via 5169c5fab8cd8ada5442b66bfa2f2165e540b9ec (commit) via 8d0c44578524dc2bd7b380dac56a53382b5aca7e (commit) via 84bd1ac370db07d2b05c1c39433cb7963a98be71 (commit) from 5f9cc8ada9a3186265f7c4fff1529775f03ac969 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 85ab68c07f9240eba08d74b232be8434e65e9afb Author: Tomas Cohen Arazi Date: Wed May 20 19:04:24 2020 -0300 Bug 24229: Avoid fetching ALL items in test I'm not sure what we need to test here, besides we get results. I'm pretty sure we shouldn't allow a plain GET return all objects because it could cause a DOS very easily. But it certainly belongs to a separate bug/discussion. In this case, I put a constraint on the items domain (by using _per_page=10 in the query params) so it won't happen that under certain conditions the user agent used by Test::Mojo time outs. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 9e665fb9a753032fed711959f1d8cc5780655b8c Author: Owen Leonard Date: Thu May 14 11:47:51 2020 +0000 Bug 25473: Move JavaScript out of the footer of addorderiso2709.tt This patch undoes the move of the JavaScript block to the footer made in Bug 22734. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 4e945dff87a8bc4badb605361c1db63f71b04a07 Author: Jonathan Druart Date: Thu May 21 15:35:33 2020 +0200 Bug 25567: Fix typo categorycode vs category_code Well, this is actually the real root of the error! Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 7ce6f7895610913f35fb1531faa1a40cefcd5f88 Author: Jonathan Druart Date: Thu May 21 15:30:35 2020 +0200 Bug 25567: Prevent patron category type's categorycode to be created with "" It must be NULL/undef, the default from the DB. The method Koha::Patron::Attribute::Type->categorycode is not covered by tests! To recreate: Create a new patron attribute type, don't select a patron's category (and not repeatable or unique) Go to the batch patron modification tool, enter a cardnumber, next. => boom! Apply the patch, edit the patron attribute, save Go to the batch patron modification tool, enter a cardnumber, next. => success! Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit bbe6b07f4340afca18763724194fbc577b77959d Author: Jonathan Druart Date: Wed May 13 15:18:29 2020 +0200 Bug 24413: Add tests Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 10af741387a75d29c6b7782c6ce3d2c07cad9517 Author: Jonathan Druart Date: Fri Feb 21 12:37:44 2020 +0100 Bug 24413: Do not remove the restrictions from AddReturn As we are now removing them from MarkIssueReturned they should not be removed from AddReturn as well. Also I think this will fix a regression, if $doreturn is not set (in case the item is withdrawn and BlockReturnOfWithdrawnItems or the item is lost and BlockReturnOfLostItems, and other specific cases). Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 70ae2eaf9cdc7708f85b1724e5bc89623355b585 Author: Jonathan Druart Date: Mon Feb 17 16:27:57 2020 +0100 Bug 24413: Apply AutoRemoveOverduesRestrictions for lost items It's quite hard to know where this need to be fixed. it can be either MarkIssueReturned or LostItem, depending on the different cases we want to handle. This patch picked MarkIssueReturned, but maybe the similar code in AddReturn needs to be removed then. == Test plan == 1. Set MarkLostItemsAsReturned to 'from items tab of the catalog module' 2. Set AutoRemoveOverduesRestrictions to 'Do' 3. Set up an overdues restriction in the notice triggers 4. Check out an item and let the overdues process restrict the account 5. Navigate to the moredetail.pl page (items tab) for the overdue item 6. Mark the item lost 7. Return to the account in question - notice the item has been returned, but the restriction remains 8. Clean state: remove restriction + remove item lost status 9. Apply patch 10. Redo the test but this time in addition to the item being returned, the restriction will be lifted. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit aa1f0fd73fa2a8dadd86ef5defc390e164845429 Author: Jonathan Druart Date: Mon Apr 13 13:42:02 2020 +0200 Bug 24612: Use the reserve_id to identify a reserve when building a notice Now that we have the reserve_id PK on the reserves table we should use it (instead of the couple borrowernumber, biblionumber) Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit e9e8b635e14fe1229006b556e8aa0babf61455c7 Author: Jonathan Druart Date: Mon Apr 13 13:10:55 2020 +0200 Bug 24612: Add tests ReserveSlip call need to be adjusted in test. We also add a new reserve (same biblio, same patron) to highlight the problem. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d864c5640a3e3b02cbb64bde034935fa746a09ce Author: Jonathan Druart Date: Wed Feb 12 10:02:56 2020 +0100 Bug 24612: Make hold-transfer-slip take reserve_id To make sure we are going to display the correct hold's info we need to pass the reserve_id. == Test plan == 1. Add some content to HOLD_SLIP notice, e.g.

[% branch.branchname %]

[% biblio.author %]
[% biblio.title %]
[% item.barcode %]
  • Reserve ID: [% hold.reserve_id %]
  • Expiration date: [% hold.expirationdate %]
2. Add 2 holds for 1 patron to a single record 3. Check the reserve IDs in the reserves table - on a clean sandbox, they will be 1 and 2 4. Check in one of the items from the record and print the slip 5. Note that the reserve ID on the slip is 2 and the expiration date is blank 6. Repeated check ins do not change this 7. Check in a second item from the record 8. Note that the reserve ID for this hold is also 2, but this time the expiration date is filled in 9. Check in the first item again - the reserve ID stays as 2, but this time the expiration date is filled in 10. Apply patch 11. cancel the holds to come back to a clean state (and maybe ensure items aren't in transit) 12. redo the test and see the following differences 13. 1st checkin: 1. expiration date ok 2. the reserve ID is the one of the first hold 14. 2nd checkin: 1. expiration date ok 2. the reserve ID is the one of the second hold Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 1bcc45be621b19dc602d675ca10d844301496b06 Author: Owen Leonard Date: Fri May 8 16:13:40 2020 +0000 Bug 25428: Correctly encode link if authority subfield is a URL This patch modifies the script and template for showing the details of an authority record so that if the authority subfield is configured to be a link the link is correctly output in the template. To test you must have an authority type configured with at least one subfield designated as a URL: - Go to Administration -> Authority types - Select "MARC structure" from the actions menu for the authority type you want to modify. - Select "Subfields" from the actions menu for the tag containing the subfield you want to modify (for instance 856). - Edit the subfield you want to display as a link (e.g. subfield u). - In the subfield configuration form under "Advanced constraints" check the "Is a URL" checkbox and save your changes. - Apply the patch and go to Authorities in the staff interface. - Search for or create an authority record which contains URL information in the right subfield (for instance 856$u). - View the details for the record. Using the 856 example, the "8" tab should contain an active link pointing to the correct URL. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 635242a69a5ed049801d018a6be712d8dcbabb07 Author: Jonathan Druart Date: Mon May 11 10:58:15 2020 +0200 Bug 25452: Restore alternate address email display Broken since commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d Bug 18789: Send Koha::Patron object to the templates Test plan: Create or modify a patron, fill the "email" field of the "alternate address" block (B_email) Go to the detail view of the patron => Without this patch the email is not display => With this patch applied you see it! Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 67ff0f72854d4dabdda8cb59696f15e7b5d88c2a Author: Slava Shishkin Date: Thu May 14 17:53:47 2020 +0300 Bug 25506: Fix for "Use of uninitialized value" in about.pl Perl warning on the "About Koha" page: Use of uninitialized value in string eq at /home/vagrant/kohaclone/about.pl line 220. Fixed by adding additional precheck for C4::Context->config('zebra_auth_index_mode') being Perl's "true". To test: 1) Ensure you don't have "... " in your koha-conf.xml so you will have "C4::Context->config" returning "undef" 2) Go to the "About Koha" page. 3) Observe the warning in the log file. 4) Apply patch. 5) Repeat step 2. 6) Check that previous warning was suppressed. Signed-off-by: Andreas Roussos Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 37370c415ab5e59422aff46be14ccfec0cf8c373 Author: Jonathan Druart Date: Thu May 21 12:00:34 2020 +0200 Bug 25563: (bug 24386 follow-up) Don't disable submit button if form has not been submitted yet On bug 24386 we prevent double form submission using the our own preventDoubleFormSubmit JS function. The problem is that we are checking some conditions, and prevent the form submission if something is not filled (for instance no checkbox checked, or no fund selected). Technically it means that: - click the submit button - it submits the form - we disable the submit button - we prevent the form to be submitted before something is wrong At this stage the button is disabled and the form cannot be longer be submitted. This patch replaces the "on submit" event of the form with the "on click" event of the submit button. Which means we are going to: - click the submit button - we prevent the form to be submitted before something is wrong => The button will only be disabled if the form is really submitted Test plan: - stage a marc record - acquisitions: have a basket - click on "Add to basket" - "From a staged file" - Don't tick the record - Save - You should see an expected error message - Tick the record - Save - You should see an expected error message - Choose a fund - Click the "Save" button as many times as you can, to try double submit it. => The order is saved Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 5169c5fab8cd8ada5442b66bfa2f2165e540b9ec Author: Jonathan Druart Date: Wed May 20 17:12:56 2020 +0200 Bug 25411: Group conditions in if elsif Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8d0c44578524dc2bd7b380dac56a53382b5aca7e Author: Tomas Cohen Arazi Date: Thu May 14 19:09:04 2020 -0300 Bug 25411: Add special handling for public plugin routes This patch implements the required logic in the API code so plugins are not affected by the new RESTPublicAnonymousRequests system preference. It is up to the plugin develpers to handle this To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t => FAIL: Notice the tests fail 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Yay! Not bad for a friday evening! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 84bd1ac370db07d2b05c1c39433cb7963a98be71 Author: Tomas Cohen Arazi Date: Thu May 14 15:15:52 2020 -0300 Bug 25411: Regression tests This patch adds tests the new RESTPublicAnonymousRequests syspref doesn't apply to routes added by plugins. It is up to the plugin developer to handle those conditions. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t => FAIL: Notice the tests fail Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 25 +++++---- C4/Letters.pm | 2 +- C4/Reserves.pm | 36 +++---------- Koha/REST/V1/Auth.pm | 14 +++-- about.pl | 5 +- admin/patron-attr-types.pl | 2 +- authorities/detail.pl | 3 +- circ/circulation.pl | 3 +- circ/hold-transfer-slip.pl | 10 +--- circ/returns.pl | 11 +--- .../prog/en/modules/acqui/addorderiso2709.tt | 32 +++++------- .../prog/en/modules/authorities/detail.tt | 6 ++- .../prog/en/modules/circ/circulation.tt | 4 +- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 4 +- .../prog/en/modules/members/moremember.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js | 8 ++- t/db_dependent/Circulation/MarkIssueReturned.t | 38 +++++++++++++- t/db_dependent/Koha/REST/Plugin/PluginRoutes.t | 61 ++++++++++++++++++---- t/db_dependent/Letters/TemplateToolkit.t | 26 +++++---- t/db_dependent/api/v1/items.t | 10 ++-- t/lib/Koha/Plugin/Test.pm | 61 ++++++++++++++++------ .../lib/Koha/Plugin/Test/Controller.pm | 26 ++++----- tools/modborrowers.pl | 4 +- 23 files changed, 245 insertions(+), 148 deletions(-) copy Koha/BiblioFramework.pm => t/lib/Koha/Plugin/Test/Controller.pm (73%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 11:05:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 09:05:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2281-gc6dc178f2e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c6dc178f2e4de65e753c6a62c9550c9361120173 (commit) via 3e597a1fade7079bf51708e7935c16d704daa5b8 (commit) from 85ab68c07f9240eba08d74b232be8434e65e9afb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c6dc178f2e4de65e753c6a62c9550c9361120173 Author: Martin Renvoize Date: Mon May 18 19:08:20 2020 +0100 Add 20.11 release team Signed-off-by: Martin Renvoize commit 3e597a1fade7079bf51708e7935c16d704daa5b8 Author: Martin Renvoize Date: Mon May 18 16:42:54 2020 +0100 Update Contributors for 20.05 Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: docs/contributors.yaml | 185 +++++++++++++++++++++++++++++++------------------ docs/history.txt | 16 +++++ docs/teams.yaml | 72 ++++++++++++++++++- 3 files changed, 205 insertions(+), 68 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 13:09:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 11:09:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2286-ga2af51d688 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a2af51d688fd72e1f38dd687649f31d8d97d529a (commit) via 0b651295f92c9f11f91302a2a99bdbd56a96da70 (commit) via 40c562fa52d1243950c7e3ee3548e0aadaa732ad (commit) via 1b7acc052a640e4f38ee6e0bb6c29c7f40c20804 (commit) via 9364ddad0e5bcc77535cc86c920453267e4a0536 (commit) from c6dc178f2e4de65e753c6a62c9550c9361120173 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a2af51d688fd72e1f38dd687649f31d8d97d529a Author: Martin Renvoize Date: Fri May 22 11:20:28 2020 +0100 Increment version for 20.05.00 alpha release Signed-off-by: Martin Renvoize commit 0b651295f92c9f11f91302a2a99bdbd56a96da70 Author: Martin Renvoize Date: Fri May 22 11:39:37 2020 +0100 Teams fixes Signed-off-by: Martin Renvoize commit 40c562fa52d1243950c7e3ee3548e0aadaa732ad Author: Martin Renvoize Date: Fri May 22 11:12:22 2020 +0100 Translation Fixes Signed-off-by: Martin Renvoize commit 1b7acc052a640e4f38ee6e0bb6c29c7f40c20804 Author: Martin Renvoize Date: Fri May 22 10:40:26 2020 +0100 Clean up 'John Doe' Signed-off-by: Martin Renvoize commit 9364ddad0e5bcc77535cc86c920453267e4a0536 Author: Koha translators <> Date: Fri May 22 06:18:12 2020 -0300 Translation updates for Koha 20.05.00 Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- docs/contributors.yaml | 7 +- docs/history.txt | 27 +- docs/teams.yaml | 12 +- installer/data/mysql/updatedatabase.pl | 5 + .../intranet-tmpl/prog/en/includes/about-team.inc | 19 +- misc/translator/po/am-Ethi-installer-MARC21.po | 229 +- misc/translator/po/am-Ethi-installer.po | 282 +- misc/translator/po/am-Ethi-marc-MARC21.po | 3095 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 358 +- misc/translator/po/am-Ethi-messages-js.po | 145 +- misc/translator/po/am-Ethi-messages.po | 71 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 3333 +- misc/translator/po/am-Ethi-pref.po | 2550 +- misc/translator/po/am-Ethi-staff-prog.po | 17007 +++++---- misc/translator/po/ar-Arab-installer-MARC21.po | 229 +- misc/translator/po/ar-Arab-installer.po | 282 +- misc/translator/po/ar-Arab-marc-MARC21.po | 4188 ++- misc/translator/po/ar-Arab-marc-NORMARC.po | 10 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 368 +- misc/translator/po/ar-Arab-messages-js.po | 145 +- misc/translator/po/ar-Arab-messages.po | 79 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 3500 +- misc/translator/po/ar-Arab-pref.po | 2834 +- misc/translator/po/ar-Arab-staff-prog.po | 18878 +++++----- misc/translator/po/as-IN-installer-MARC21.po | 229 +- misc/translator/po/as-IN-installer.po | 282 +- misc/translator/po/as-IN-marc-MARC21.po | 3095 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 358 +- misc/translator/po/as-IN-messages-js.po | 145 +- misc/translator/po/as-IN-messages.po | 71 +- misc/translator/po/as-IN-opac-bootstrap.po | 3310 +- misc/translator/po/as-IN-pref.po | 2550 +- misc/translator/po/as-IN-staff-prog.po | 16874 +++++---- misc/translator/po/az-AZ-installer-MARC21.po | 229 +- misc/translator/po/az-AZ-installer.po | 282 +- misc/translator/po/az-AZ-marc-MARC21.po | 3095 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 358 +- misc/translator/po/az-AZ-messages-js.po | 145 +- misc/translator/po/az-AZ-messages.po | 71 +- misc/translator/po/az-AZ-opac-bootstrap.po | 3335 +- misc/translator/po/az-AZ-pref.po | 2548 +- misc/translator/po/az-AZ-staff-prog.po | 16962 +++++---- misc/translator/po/be-BY-installer-MARC21.po | 229 +- misc/translator/po/be-BY-installer.po | 282 +- misc/translator/po/be-BY-marc-MARC21.po | 3094 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 358 +- misc/translator/po/be-BY-messages-js.po | 145 +- misc/translator/po/be-BY-messages.po | 72 +- misc/translator/po/be-BY-opac-bootstrap.po | 3346 +- misc/translator/po/be-BY-pref.po | 2592 +- misc/translator/po/be-BY-staff-prog.po | 17038 +++++---- misc/translator/po/bg-Cyrl-installer-MARC21.po | 229 +- misc/translator/po/bg-Cyrl-installer.po | 282 +- misc/translator/po/bg-Cyrl-marc-MARC21.po | 3143 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 358 +- misc/translator/po/bg-Cyrl-messages-js.po | 145 +- misc/translator/po/bg-Cyrl-messages.po | 71 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 3328 +- misc/translator/po/bg-Cyrl-pref.po | 2572 +- misc/translator/po/bg-Cyrl-staff-prog.po | 16998 +++++---- misc/translator/po/bn-IN-installer-MARC21.po | 87 +- misc/translator/po/bn-IN-installer.po | 282 +- misc/translator/po/bn-IN-marc-MARC21.po | 3099 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 358 +- misc/translator/po/bn-IN-messages-js.po | 145 +- misc/translator/po/bn-IN-messages.po | 71 +- misc/translator/po/bn-IN-opac-bootstrap.po | 3345 +- misc/translator/po/bn-IN-pref.po | 2548 +- misc/translator/po/bn-IN-staff-prog.po | 17013 +++++---- misc/translator/po/ca-ES-installer-MARC21.po | 229 +- misc/translator/po/ca-ES-installer.po | 282 +- misc/translator/po/ca-ES-marc-MARC21.po | 3107 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 358 +- misc/translator/po/ca-ES-messages-js.po | 145 +- misc/translator/po/ca-ES-messages.po | 71 +- misc/translator/po/ca-ES-opac-bootstrap.po | 3357 +- misc/translator/po/ca-ES-pref.po | 2550 +- misc/translator/po/ca-ES-staff-prog.po | 16972 +++++---- misc/translator/po/cs-CZ-installer-MARC21.po | 136 +- misc/translator/po/cs-CZ-installer.po | 295 +- misc/translator/po/cs-CZ-marc-MARC21.po | 3485 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 6 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 368 +- misc/translator/po/cs-CZ-messages-js.po | 157 +- misc/translator/po/cs-CZ-messages.po | 82 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 3584 +- misc/translator/po/cs-CZ-pref.po | 2850 +- misc/translator/po/cs-CZ-staff-prog.po | 17401 +++++---- misc/translator/po/cy-GB-installer-MARC21.po | 229 +- misc/translator/po/cy-GB-installer.po | 282 +- misc/translator/po/cy-GB-marc-MARC21.po | 3095 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 358 +- misc/translator/po/cy-GB-messages-js.po | 145 +- misc/translator/po/cy-GB-messages.po | 71 +- misc/translator/po/cy-GB-opac-bootstrap.po | 3310 +- misc/translator/po/cy-GB-pref.po | 2550 +- misc/translator/po/cy-GB-staff-prog.po | 16874 +++++---- misc/translator/po/da-DK-installer-MARC21.po | 229 +- misc/translator/po/da-DK-installer.po | 282 +- misc/translator/po/da-DK-marc-MARC21.po | 3097 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 358 +- misc/translator/po/da-DK-messages-js.po | 145 +- misc/translator/po/da-DK-messages.po | 71 +- misc/translator/po/da-DK-opac-bootstrap.po | 3347 +- misc/translator/po/da-DK-pref.po | 2614 +- misc/translator/po/da-DK-staff-prog.po | 17067 +++++---- misc/translator/po/de-CH-installer-MARC21.po | 102 +- misc/translator/po/de-CH-installer.po | 282 +- misc/translator/po/de-CH-marc-MARC21.po | 3097 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 358 +- misc/translator/po/de-CH-messages-js.po | 145 +- misc/translator/po/de-CH-messages.po | 71 +- misc/translator/po/de-CH-opac-bootstrap.po | 3348 +- misc/translator/po/de-CH-pref.po | 2656 +- misc/translator/po/de-CH-staff-prog.po | 17169 +++++---- misc/translator/po/de-DE-marc-MARC21.po | 3103 +- misc/translator/po/de-DE-marc-NORMARC.po | 8 +- misc/translator/po/de-DE-marc-UNIMARC.po | 364 +- misc/translator/po/de-DE-messages-js.po | 156 +- misc/translator/po/de-DE-messages.po | 75 +- misc/translator/po/de-DE-opac-bootstrap.po | 3615 +- misc/translator/po/de-DE-pref.po | 2835 +- misc/translator/po/de-DE-staff-prog.po | 17616 +++++---- misc/translator/po/dz-installer-MARC21.po | 229 +- misc/translator/po/dz-installer.po | 282 +- misc/translator/po/dz-marc-MARC21.po | 3095 +- misc/translator/po/dz-marc-NORMARC.po | 4 +- misc/translator/po/dz-marc-UNIMARC.po | 360 +- misc/translator/po/dz-messages-js.po | 145 +- misc/translator/po/dz-messages.po | 71 +- misc/translator/po/dz-opac-bootstrap.po | 3310 +- misc/translator/po/dz-pref.po | 2550 +- misc/translator/po/dz-staff-prog.po | 16862 +++++---- misc/translator/po/el-GR-installer-MARC21.po | 229 +- misc/translator/po/el-GR-installer.po | 282 +- misc/translator/po/el-GR-marc-MARC21.po | 3117 +- misc/translator/po/el-GR-marc-NORMARC.po | 10 +- misc/translator/po/el-GR-marc-UNIMARC.po | 383 +- misc/translator/po/el-GR-messages-js.po | 145 +- misc/translator/po/el-GR-messages.po | 77 +- misc/translator/po/el-GR-opac-bootstrap.po | 3467 +- misc/translator/po/el-GR-pref.po | 2677 +- misc/translator/po/el-GR-staff-prog.po | 17442 +++++---- misc/translator/po/en-GB-installer-MARC21.po | 229 +- misc/translator/po/en-GB-installer.po | 282 +- misc/translator/po/en-GB-marc-MARC21.po | 3095 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 358 +- misc/translator/po/en-GB-messages-js.po | 145 +- misc/translator/po/en-GB-messages.po | 71 +- misc/translator/po/en-GB-opac-bootstrap.po | 3332 +- misc/translator/po/en-GB-pref.po | 2580 +- misc/translator/po/en-GB-staff-prog.po | 17096 +++++---- misc/translator/po/en-NZ-installer-MARC21.po | 229 +- misc/translator/po/en-NZ-installer.po | 282 +- misc/translator/po/en-NZ-marc-MARC21.po | 3097 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 358 +- misc/translator/po/en-NZ-messages-js.po | 145 +- misc/translator/po/en-NZ-messages.po | 71 +- misc/translator/po/en-NZ-opac-bootstrap.po | 3358 +- misc/translator/po/en-NZ-pref.po | 2652 +- misc/translator/po/en-NZ-staff-prog.po | 17142 +++++---- misc/translator/po/eo-installer-MARC21.po | 229 +- misc/translator/po/eo-installer.po | 282 +- misc/translator/po/eo-marc-MARC21.po | 3095 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 358 +- misc/translator/po/eo-messages-js.po | 145 +- misc/translator/po/eo-messages.po | 71 +- misc/translator/po/eo-opac-bootstrap.po | 3970 +- misc/translator/po/eo-pref.po | 2550 +- misc/translator/po/eo-staff-prog.po | 17001 +++++---- misc/translator/po/es-ES-installer-MARC21.po | 155 +- misc/translator/po/es-ES-installer.po | 1977 +- misc/translator/po/es-ES-marc-MARC21.po | 3747 +- misc/translator/po/es-ES-marc-NORMARC.po | 6 +- misc/translator/po/es-ES-marc-UNIMARC.po | 370 +- misc/translator/po/es-ES-messages-js.po | 156 +- misc/translator/po/es-ES-messages.po | 79 +- misc/translator/po/es-ES-opac-bootstrap.po | 3597 +- misc/translator/po/es-ES-pref.po | 2842 +- misc/translator/po/es-ES-staff-prog.po | 17772 +++++---- misc/translator/po/eu-installer-MARC21.po | 229 +- misc/translator/po/eu-installer.po | 282 +- misc/translator/po/eu-marc-MARC21.po | 3095 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 358 +- misc/translator/po/eu-messages-js.po | 145 +- misc/translator/po/eu-messages.po | 71 +- misc/translator/po/eu-opac-bootstrap.po | 3334 +- misc/translator/po/eu-pref.po | 2648 +- misc/translator/po/eu-staff-prog.po | 17109 +++++---- misc/translator/po/fa-Arab-installer-MARC21.po | 229 +- misc/translator/po/fa-Arab-installer.po | 282 +- misc/translator/po/fa-Arab-marc-MARC21.po | 3095 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 358 +- misc/translator/po/fa-Arab-messages-js.po | 145 +- misc/translator/po/fa-Arab-messages.po | 71 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 3344 +- misc/translator/po/fa-Arab-pref.po | 2618 +- misc/translator/po/fa-Arab-staff-prog.po | 17025 +++++---- misc/translator/po/fi-FI-installer-MARC21.po | 102 +- misc/translator/po/fi-FI-installer.po | 282 +- misc/translator/po/fi-FI-marc-MARC21.po | 3097 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 358 +- misc/translator/po/fi-FI-messages-js.po | 145 +- misc/translator/po/fi-FI-messages.po | 71 +- misc/translator/po/fi-FI-opac-bootstrap.po | 3346 +- misc/translator/po/fi-FI-pref.po | 2658 +- misc/translator/po/fi-FI-staff-prog.po | 17139 +++++---- misc/translator/po/fo-FO-installer-MARC21.po | 229 +- misc/translator/po/fo-FO-installer.po | 282 +- misc/translator/po/fo-FO-marc-MARC21.po | 3095 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 358 +- misc/translator/po/fo-FO-messages-js.po | 145 +- misc/translator/po/fo-FO-messages.po | 71 +- misc/translator/po/fo-FO-opac-bootstrap.po | 3316 +- misc/translator/po/fo-FO-pref.po | 2550 +- misc/translator/po/fo-FO-staff-prog.po | 16874 +++++---- misc/translator/po/fr-CA-marc-MARC21.po | 3933 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 358 +- misc/translator/po/fr-CA-messages-js.po | 145 +- misc/translator/po/fr-CA-messages.po | 71 +- misc/translator/po/fr-CA-opac-bootstrap.po | 3401 +- misc/translator/po/fr-CA-pref.po | 2697 +- misc/translator/po/fr-CA-staff-prog.po | 17492 +++++---- misc/translator/po/fr-FR-marc-MARC21.po | 3115 +- misc/translator/po/fr-FR-marc-NORMARC.po | 6 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 372 +- misc/translator/po/fr-FR-messages-js.po | 145 +- misc/translator/po/fr-FR-messages.po | 71 +- misc/translator/po/fr-FR-opac-bootstrap.po | 3477 +- misc/translator/po/fr-FR-pref.po | 2752 +- misc/translator/po/fr-FR-staff-prog.po | 17854 +++++---- misc/translator/po/ga-installer-MARC21.po | 229 +- misc/translator/po/ga-installer.po | 282 +- misc/translator/po/ga-marc-MARC21.po | 3095 +- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 358 +- misc/translator/po/ga-messages-js.po | 145 +- misc/translator/po/ga-messages.po | 72 +- misc/translator/po/ga-opac-bootstrap.po | 3314 +- misc/translator/po/ga-pref.po | 2550 +- misc/translator/po/ga-staff-prog.po | 16874 +++++---- misc/translator/po/gd-installer-MARC21.po | 229 +- misc/translator/po/gd-installer.po | 282 +- misc/translator/po/gd-marc-MARC21.po | 3095 +- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 358 +- misc/translator/po/gd-messages-js.po | 145 +- misc/translator/po/gd-messages.po | 71 +- misc/translator/po/gd-opac-bootstrap.po | 3310 +- misc/translator/po/gd-pref.po | 2550 +- misc/translator/po/gd-staff-prog.po | 16874 +++++---- misc/translator/po/gl-installer-MARC21.po | 229 +- misc/translator/po/gl-installer.po | 282 +- misc/translator/po/gl-marc-MARC21.po | 3095 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 358 +- misc/translator/po/gl-messages-js.po | 145 +- misc/translator/po/gl-messages.po | 71 +- misc/translator/po/gl-opac-bootstrap.po | 3332 +- misc/translator/po/gl-pref.po | 2568 +- misc/translator/po/gl-staff-prog.po | 16977 +++++---- misc/translator/po/he-Hebr-installer-MARC21.po | 229 +- misc/translator/po/he-Hebr-installer.po | 282 +- misc/translator/po/he-Hebr-marc-MARC21.po | 3095 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 358 +- misc/translator/po/he-Hebr-messages-js.po | 145 +- misc/translator/po/he-Hebr-messages.po | 71 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 3335 +- misc/translator/po/he-Hebr-pref.po | 2550 +- misc/translator/po/he-Hebr-staff-prog.po | 16973 +++++---- misc/translator/po/hi-installer-MARC21.po | 3709 +- misc/translator/po/hi-installer.po | 1770 +- misc/translator/po/hi-marc-MARC21.po | 3105 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 362 +- misc/translator/po/hi-messages-js.po | 157 +- misc/translator/po/hi-messages.po | 76 +- misc/translator/po/hi-opac-bootstrap.po | 3590 +- misc/translator/po/hi-pref.po | 3026 +- misc/translator/po/hi-staff-prog.po | 17614 +++++---- misc/translator/po/hr-HR-installer-MARC21.po | 229 +- misc/translator/po/hr-HR-installer.po | 282 +- misc/translator/po/hr-HR-marc-MARC21.po | 3099 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 358 +- misc/translator/po/hr-HR-messages-js.po | 145 +- misc/translator/po/hr-HR-messages.po | 72 +- misc/translator/po/hr-HR-opac-bootstrap.po | 3347 +- misc/translator/po/hr-HR-pref.po | 2550 +- misc/translator/po/hr-HR-staff-prog.po | 17021 +++++---- misc/translator/po/hu-HU-installer-MARC21.po | 229 +- misc/translator/po/hu-HU-installer.po | 282 +- misc/translator/po/hu-HU-marc-MARC21.po | 3242 +- misc/translator/po/hu-HU-marc-NORMARC.po | 18 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 404 +- misc/translator/po/hu-HU-messages-js.po | 145 +- misc/translator/po/hu-HU-messages.po | 71 +- misc/translator/po/hu-HU-opac-bootstrap.po | 4374 ++- misc/translator/po/hu-HU-pref.po | 2548 +- misc/translator/po/hu-HU-staff-prog.po | 18961 +++++----- misc/translator/po/hy-Armn-installer-MARC21.po | 158 +- misc/translator/po/hy-Armn-installer.po | 1772 +- misc/translator/po/hy-Armn-marc-MARC21.po | 4183 ++- misc/translator/po/hy-Armn-marc-NORMARC.po | 10 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 368 +- misc/translator/po/hy-Armn-messages-js.po | 157 +- misc/translator/po/hy-Armn-messages.po | 79 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 3499 +- misc/translator/po/hy-Armn-pref.po | 2946 +- misc/translator/po/hy-Armn-staff-prog.po | 19074 +++++----- misc/translator/po/ia-installer-MARC21.po | 229 +- misc/translator/po/ia-installer.po | 282 +- misc/translator/po/ia-marc-MARC21.po | 3099 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 358 +- misc/translator/po/ia-messages-js.po | 145 +- misc/translator/po/ia-messages.po | 71 +- misc/translator/po/ia-opac-bootstrap.po | 3310 +- misc/translator/po/ia-pref.po | 2550 +- misc/translator/po/ia-staff-prog.po | 16874 +++++---- misc/translator/po/id-ID-installer-MARC21.po | 229 +- misc/translator/po/id-ID-installer.po | 282 +- misc/translator/po/id-ID-marc-MARC21.po | 3099 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 358 +- misc/translator/po/id-ID-messages-js.po | 145 +- misc/translator/po/id-ID-messages.po | 71 +- misc/translator/po/id-ID-opac-bootstrap.po | 3334 +- misc/translator/po/id-ID-pref.po | 2594 +- misc/translator/po/id-ID-staff-prog.po | 17023 +++++---- misc/translator/po/iq-CA-installer-MARC21.po | 229 +- misc/translator/po/iq-CA-installer.po | 282 +- misc/translator/po/iq-CA-marc-MARC21.po | 3095 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 358 +- misc/translator/po/iq-CA-messages-js.po | 145 +- misc/translator/po/iq-CA-messages.po | 71 +- misc/translator/po/iq-CA-opac-bootstrap.po | 3310 +- misc/translator/po/iq-CA-pref.po | 2550 +- misc/translator/po/iq-CA-staff-prog.po | 16874 +++++---- misc/translator/po/is-IS-installer-MARC21.po | 229 +- misc/translator/po/is-IS-installer.po | 282 +- misc/translator/po/is-IS-marc-MARC21.po | 3095 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 358 +- misc/translator/po/is-IS-messages-js.po | 145 +- misc/translator/po/is-IS-messages.po | 71 +- misc/translator/po/is-IS-opac-bootstrap.po | 3334 +- misc/translator/po/is-IS-pref.po | 2586 +- misc/translator/po/is-IS-staff-prog.po | 16973 +++++---- misc/translator/po/it-IT-marc-MARC21.po | 3327 +- misc/translator/po/it-IT-marc-NORMARC.po | 12 +- misc/translator/po/it-IT-marc-UNIMARC.po | 366 +- misc/translator/po/it-IT-messages-js.po | 145 +- misc/translator/po/it-IT-messages.po | 75 +- misc/translator/po/it-IT-opac-bootstrap.po | 3464 +- misc/translator/po/it-IT-pref.po | 2672 +- misc/translator/po/it-IT-staff-prog.po | 17206 +++++---- misc/translator/po/iu-CA-installer-MARC21.po | 229 +- misc/translator/po/iu-CA-installer.po | 282 +- misc/translator/po/iu-CA-marc-MARC21.po | 3095 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 358 +- misc/translator/po/iu-CA-messages-js.po | 145 +- misc/translator/po/iu-CA-messages.po | 71 +- misc/translator/po/iu-CA-opac-bootstrap.po | 3310 +- misc/translator/po/iu-CA-pref.po | 2550 +- misc/translator/po/iu-CA-staff-prog.po | 16874 +++++---- misc/translator/po/ja-Jpan-JP-installer-MARC21.po | 229 +- misc/translator/po/ja-Jpan-JP-installer.po | 282 +- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 3099 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 358 +- misc/translator/po/ja-Jpan-JP-messages-js.po | 145 +- misc/translator/po/ja-Jpan-JP-messages.po | 70 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 3350 +- misc/translator/po/ja-Jpan-JP-pref.po | 2550 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 17017 +++++---- misc/translator/po/ka-installer-MARC21.po | 229 +- misc/translator/po/ka-installer.po | 282 +- misc/translator/po/ka-marc-MARC21.po | 3095 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 358 +- misc/translator/po/ka-messages-js.po | 145 +- misc/translator/po/ka-messages.po | 71 +- misc/translator/po/ka-opac-bootstrap.po | 3310 +- misc/translator/po/ka-pref.po | 2550 +- misc/translator/po/ka-staff-prog.po | 16958 +++++---- misc/translator/po/km-KH-installer-MARC21.po | 229 +- misc/translator/po/km-KH-installer.po | 282 +- misc/translator/po/km-KH-marc-MARC21.po | 3095 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 358 +- misc/translator/po/km-KH-messages-js.po | 145 +- misc/translator/po/km-KH-messages.po | 71 +- misc/translator/po/km-KH-opac-bootstrap.po | 3310 +- misc/translator/po/km-KH-pref.po | 2550 +- misc/translator/po/km-KH-staff-prog.po | 16958 +++++---- misc/translator/po/kn-Knda-installer-MARC21.po | 229 +- misc/translator/po/kn-Knda-installer.po | 282 +- misc/translator/po/kn-Knda-marc-MARC21.po | 3095 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 358 +- misc/translator/po/kn-Knda-messages-js.po | 145 +- misc/translator/po/kn-Knda-messages.po | 71 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 3335 +- misc/translator/po/kn-Knda-pref.po | 2550 +- misc/translator/po/kn-Knda-staff-prog.po | 16987 +++++---- misc/translator/po/ko-Kore-KP-installer-MARC21.po | 229 +- misc/translator/po/ko-Kore-KP-installer.po | 282 +- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 3097 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 358 +- misc/translator/po/ko-Kore-KP-messages-js.po | 145 +- misc/translator/po/ko-Kore-KP-messages.po | 70 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 3335 +- misc/translator/po/ko-Kore-KP-pref.po | 2616 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 17045 +++++---- misc/translator/po/ku-Arab-installer-MARC21.po | 229 +- misc/translator/po/ku-Arab-installer.po | 282 +- misc/translator/po/ku-Arab-marc-MARC21.po | 3095 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 358 +- misc/translator/po/ku-Arab-messages-js.po | 145 +- misc/translator/po/ku-Arab-messages.po | 71 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 3336 +- misc/translator/po/ku-Arab-pref.po | 2602 +- misc/translator/po/ku-Arab-staff-prog.po | 17023 +++++---- misc/translator/po/lo-Laoo-installer-MARC21.po | 229 +- misc/translator/po/lo-Laoo-installer.po | 282 +- misc/translator/po/lo-Laoo-marc-MARC21.po | 3095 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 358 +- misc/translator/po/lo-Laoo-messages-js.po | 145 +- misc/translator/po/lo-Laoo-messages.po | 71 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 3334 +- misc/translator/po/lo-Laoo-pref.po | 2572 +- misc/translator/po/lo-Laoo-staff-prog.po | 16982 +++++---- misc/translator/po/lv-installer-MARC21.po | 229 +- misc/translator/po/lv-installer.po | 282 +- misc/translator/po/lv-marc-MARC21.po | 3095 +- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 358 +- misc/translator/po/lv-messages-js.po | 145 +- misc/translator/po/lv-messages.po | 72 +- misc/translator/po/lv-opac-bootstrap.po | 3318 +- misc/translator/po/lv-pref.po | 2550 +- misc/translator/po/lv-staff-prog.po | 16874 +++++---- misc/translator/po/mi-NZ-installer-MARC21.po | 229 +- misc/translator/po/mi-NZ-installer.po | 282 +- misc/translator/po/mi-NZ-marc-MARC21.po | 3095 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 358 +- misc/translator/po/mi-NZ-messages-js.po | 145 +- misc/translator/po/mi-NZ-messages.po | 71 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 3345 +- misc/translator/po/mi-NZ-pref.po | 2550 +- misc/translator/po/mi-NZ-staff-prog.po | 16971 +++++---- misc/translator/po/ml-installer-MARC21.po | 229 +- misc/translator/po/ml-installer.po | 282 +- misc/translator/po/ml-marc-MARC21.po | 3095 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 358 +- misc/translator/po/ml-messages-js.po | 145 +- misc/translator/po/ml-messages.po | 71 +- misc/translator/po/ml-opac-bootstrap.po | 3310 +- misc/translator/po/ml-pref.po | 2550 +- misc/translator/po/ml-staff-prog.po | 16874 +++++---- misc/translator/po/mon-installer-MARC21.po | 229 +- misc/translator/po/mon-installer.po | 282 +- misc/translator/po/mon-marc-MARC21.po | 3095 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 358 +- misc/translator/po/mon-messages-js.po | 145 +- misc/translator/po/mon-messages.po | 71 +- misc/translator/po/mon-opac-bootstrap.po | 3335 +- misc/translator/po/mon-pref.po | 2548 +- misc/translator/po/mon-staff-prog.po | 16968 +++++---- misc/translator/po/mr-installer-MARC21.po | 229 +- misc/translator/po/mr-installer.po | 282 +- misc/translator/po/mr-marc-MARC21.po | 3095 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 358 +- misc/translator/po/mr-messages-js.po | 145 +- misc/translator/po/mr-messages.po | 71 +- misc/translator/po/mr-opac-bootstrap.po | 3333 +- misc/translator/po/mr-pref.po | 2548 +- misc/translator/po/mr-staff-prog.po | 16986 +++++---- misc/translator/po/ms-MY-installer-MARC21.po | 229 +- misc/translator/po/ms-MY-installer.po | 282 +- misc/translator/po/ms-MY-marc-MARC21.po | 3099 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 358 +- misc/translator/po/ms-MY-messages-js.po | 145 +- misc/translator/po/ms-MY-messages.po | 71 +- misc/translator/po/ms-MY-opac-bootstrap.po | 3339 +- misc/translator/po/ms-MY-pref.po | 2576 +- misc/translator/po/ms-MY-staff-prog.po | 17354 +++++---- misc/translator/po/my-installer-MARC21.po | 229 +- misc/translator/po/my-installer.po | 282 +- misc/translator/po/my-marc-MARC21.po | 3095 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 358 +- misc/translator/po/my-messages-js.po | 145 +- misc/translator/po/my-messages.po | 71 +- misc/translator/po/my-opac-bootstrap.po | 3318 +- misc/translator/po/my-pref.po | 2550 +- misc/translator/po/my-staff-prog.po | 16874 +++++---- misc/translator/po/nb-NO-marc-MARC21.po | 3097 +- misc/translator/po/nb-NO-marc-NORMARC.po | 10 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 376 +- misc/translator/po/nb-NO-messages-js.po | 156 +- misc/translator/po/nb-NO-messages.po | 75 +- misc/translator/po/nb-NO-opac-bootstrap.po | 3360 +- misc/translator/po/nb-NO-pref.po | 2654 +- misc/translator/po/nb-NO-staff-prog.po | 17153 +++++---- misc/translator/po/ne-NE-installer-MARC21.po | 229 +- misc/translator/po/ne-NE-installer.po | 282 +- misc/translator/po/ne-NE-marc-MARC21.po | 3095 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 358 +- misc/translator/po/ne-NE-messages-js.po | 145 +- misc/translator/po/ne-NE-messages.po | 71 +- misc/translator/po/ne-NE-opac-bootstrap.po | 3310 +- misc/translator/po/ne-NE-pref.po | 2574 +- misc/translator/po/ne-NE-staff-prog.po | 16991 +++++---- misc/translator/po/nl-BE-installer-MARC21.po | 229 +- misc/translator/po/nl-BE-installer.po | 282 +- misc/translator/po/nl-BE-marc-MARC21.po | 3097 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 358 +- misc/translator/po/nl-BE-messages-js.po | 145 +- misc/translator/po/nl-BE-messages.po | 75 +- misc/translator/po/nl-BE-opac-bootstrap.po | 3395 +- misc/translator/po/nl-BE-pref.po | 2672 +- misc/translator/po/nl-BE-staff-prog.po | 17237 +++++---- misc/translator/po/nl-NL-installer-MARC21.po | 229 +- misc/translator/po/nl-NL-installer.po | 282 +- misc/translator/po/nl-NL-marc-MARC21.po | 3095 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 358 +- misc/translator/po/nl-NL-messages-js.po | 145 +- misc/translator/po/nl-NL-messages.po | 95 +- misc/translator/po/nl-NL-opac-bootstrap.po | 5345 +-- misc/translator/po/nl-NL-pref.po | 2548 +- misc/translator/po/nl-NL-staff-prog.po | 17568 +++++---- misc/translator/po/nn-NO-installer-MARC21.po | 229 +- misc/translator/po/nn-NO-installer.po | 282 +- misc/translator/po/nn-NO-marc-MARC21.po | 3095 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 358 +- misc/translator/po/nn-NO-messages-js.po | 145 +- misc/translator/po/nn-NO-messages.po | 71 +- misc/translator/po/nn-NO-opac-bootstrap.po | 3333 +- misc/translator/po/nn-NO-pref.po | 2572 +- misc/translator/po/nn-NO-staff-prog.po | 16971 +++++---- misc/translator/po/oc-installer-MARC21.po | 229 +- misc/translator/po/oc-installer.po | 282 +- misc/translator/po/oc-marc-MARC21.po | 3097 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 358 +- misc/translator/po/oc-messages-js.po | 145 +- misc/translator/po/oc-messages.po | 71 +- misc/translator/po/oc-opac-bootstrap.po | 3335 +- misc/translator/po/oc-pref.po | 2620 +- misc/translator/po/oc-staff-prog.po | 17101 +++++---- misc/translator/po/pbr-installer-MARC21.po | 229 +- misc/translator/po/pbr-installer.po | 282 +- misc/translator/po/pbr-marc-MARC21.po | 3095 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 358 +- misc/translator/po/pbr-messages-js.po | 145 +- misc/translator/po/pbr-messages.po | 71 +- misc/translator/po/pbr-opac-bootstrap.po | 3310 +- misc/translator/po/pbr-pref.po | 2548 +- misc/translator/po/pbr-staff-prog.po | 16961 +++++---- misc/translator/po/pl-PL-marc-MARC21.po | 3105 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 358 +- misc/translator/po/pl-PL-messages-js.po | 145 +- misc/translator/po/pl-PL-messages.po | 72 +- misc/translator/po/pl-PL-opac-bootstrap.po | 3359 +- misc/translator/po/pl-PL-pref.po | 2658 +- misc/translator/po/pl-PL-staff-prog.po | 17178 +++++---- misc/translator/po/prs-installer-MARC21.po | 229 +- misc/translator/po/prs-installer.po | 282 +- misc/translator/po/prs-marc-MARC21.po | 3095 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 358 +- misc/translator/po/prs-messages-js.po | 145 +- misc/translator/po/prs-messages.po | 71 +- misc/translator/po/prs-opac-bootstrap.po | 3328 +- misc/translator/po/prs-pref.po | 2586 +- misc/translator/po/prs-staff-prog.po | 16974 +++++---- misc/translator/po/pt-BR-installer-MARC21.po | 1157 +- misc/translator/po/pt-BR-installer.po | 293 +- misc/translator/po/pt-BR-marc-MARC21.po | 3131 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 358 +- misc/translator/po/pt-BR-messages-js.po | 153 +- misc/translator/po/pt-BR-messages.po | 81 +- misc/translator/po/pt-BR-opac-bootstrap.po | 3632 +- misc/translator/po/pt-BR-pref.po | 2699 +- misc/translator/po/pt-BR-staff-prog.po | 17505 +++++---- misc/translator/po/pt-PT-installer-MARC21.po | 229 +- misc/translator/po/pt-PT-installer.po | 282 +- misc/translator/po/pt-PT-marc-MARC21.po | 4163 ++- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 358 +- misc/translator/po/pt-PT-messages-js.po | 153 +- misc/translator/po/pt-PT-messages.po | 75 +- misc/translator/po/pt-PT-opac-bootstrap.po | 3596 +- misc/translator/po/pt-PT-pref.po | 2775 +- misc/translator/po/pt-PT-staff-prog.po | 17316 +++++---- misc/translator/po/ro-RO-installer-MARC21.po | 229 +- misc/translator/po/ro-RO-installer.po | 282 +- misc/translator/po/ro-RO-marc-MARC21.po | 3095 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 358 +- misc/translator/po/ro-RO-messages-js.po | 145 +- misc/translator/po/ro-RO-messages.po | 72 +- misc/translator/po/ro-RO-opac-bootstrap.po | 3345 +- misc/translator/po/ro-RO-pref.po | 2574 +- misc/translator/po/ro-RO-staff-prog.po | 17015 +++++---- misc/translator/po/ru-RU-marc-MARC21.po | 3098 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 378 +- misc/translator/po/ru-RU-messages-js.po | 145 +- misc/translator/po/ru-RU-messages.po | 86 +- misc/translator/po/ru-RU-opac-bootstrap.po | 3555 +- misc/translator/po/ru-RU-pref.po | 2634 +- misc/translator/po/ru-RU-staff-prog.po | 17860 +++++---- misc/translator/po/rw-RW-installer-MARC21.po | 229 +- misc/translator/po/rw-RW-installer.po | 282 +- misc/translator/po/rw-RW-marc-MARC21.po | 3095 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 358 +- misc/translator/po/rw-RW-messages-js.po | 145 +- misc/translator/po/rw-RW-messages.po | 71 +- misc/translator/po/rw-RW-opac-bootstrap.po | 3310 +- misc/translator/po/rw-RW-pref.po | 2550 +- misc/translator/po/rw-RW-staff-prog.po | 16874 +++++---- misc/translator/po/sd-PK-installer-MARC21.po | 229 +- misc/translator/po/sd-PK-installer.po | 282 +- misc/translator/po/sd-PK-marc-MARC21.po | 3095 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 358 +- misc/translator/po/sd-PK-messages-js.po | 145 +- misc/translator/po/sd-PK-messages.po | 71 +- misc/translator/po/sd-PK-opac-bootstrap.po | 3318 +- misc/translator/po/sd-PK-pref.po | 2548 +- misc/translator/po/sd-PK-staff-prog.po | 16998 +++++---- misc/translator/po/sk-SK-installer-MARC21.po | 229 +- misc/translator/po/sk-SK-installer.po | 282 +- misc/translator/po/sk-SK-marc-MARC21.po | 4513 ++- misc/translator/po/sk-SK-marc-NORMARC.po | 12 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 380 +- misc/translator/po/sk-SK-messages-js.po | 145 +- misc/translator/po/sk-SK-messages.po | 86 +- misc/translator/po/sk-SK-opac-bootstrap.po | 3630 +- misc/translator/po/sk-SK-pref.po | 2686 +- misc/translator/po/sk-SK-staff-prog.po | 17351 +++++---- misc/translator/po/sl-SI-installer-MARC21.po | 229 +- misc/translator/po/sl-SI-installer.po | 282 +- misc/translator/po/sl-SI-marc-MARC21.po | 3095 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 358 +- misc/translator/po/sl-SI-messages-js.po | 145 +- misc/translator/po/sl-SI-messages.po | 73 +- misc/translator/po/sl-SI-opac-bootstrap.po | 3310 +- misc/translator/po/sl-SI-pref.po | 2586 +- misc/translator/po/sl-SI-staff-prog.po | 16874 +++++---- misc/translator/po/sq-AL-installer-MARC21.po | 229 +- misc/translator/po/sq-AL-installer.po | 282 +- misc/translator/po/sq-AL-marc-MARC21.po | 3095 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 358 +- misc/translator/po/sq-AL-messages-js.po | 145 +- misc/translator/po/sq-AL-messages.po | 71 +- misc/translator/po/sq-AL-opac-bootstrap.po | 3689 +- misc/translator/po/sq-AL-pref.po | 2574 +- misc/translator/po/sq-AL-staff-prog.po | 17029 +++++---- misc/translator/po/sr-Cyrl-installer-MARC21.po | 229 +- misc/translator/po/sr-Cyrl-installer.po | 282 +- misc/translator/po/sr-Cyrl-marc-MARC21.po | 3095 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 358 +- misc/translator/po/sr-Cyrl-messages-js.po | 145 +- misc/translator/po/sr-Cyrl-messages.po | 72 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 3333 +- misc/translator/po/sr-Cyrl-pref.po | 2548 +- misc/translator/po/sr-Cyrl-staff-prog.po | 17009 +++++---- misc/translator/po/sv-SE-installer-MARC21.po | 229 +- misc/translator/po/sv-SE-installer.po | 295 +- misc/translator/po/sv-SE-marc-MARC21.po | 3119 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 358 +- misc/translator/po/sv-SE-messages-js.po | 153 +- misc/translator/po/sv-SE-messages.po | 88 +- misc/translator/po/sv-SE-opac-bootstrap.po | 3640 +- misc/translator/po/sv-SE-pref.po | 2714 +- misc/translator/po/sv-SE-staff-prog.po | 19015 +++++----- misc/translator/po/sw-KE-installer-MARC21.po | 229 +- misc/translator/po/sw-KE-installer.po | 282 +- misc/translator/po/sw-KE-marc-MARC21.po | 3099 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 358 +- misc/translator/po/sw-KE-messages-js.po | 145 +- misc/translator/po/sw-KE-messages.po | 71 +- misc/translator/po/sw-KE-opac-bootstrap.po | 3310 +- misc/translator/po/sw-KE-pref.po | 2550 +- misc/translator/po/sw-KE-staff-prog.po | 16876 +++++---- misc/translator/po/ta-LK-installer-MARC21.po | 229 +- misc/translator/po/ta-LK-installer.po | 282 +- misc/translator/po/ta-LK-marc-MARC21.po | 3095 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 358 +- misc/translator/po/ta-LK-messages-js.po | 145 +- misc/translator/po/ta-LK-messages.po | 71 +- misc/translator/po/ta-LK-opac-bootstrap.po | 3310 +- misc/translator/po/ta-LK-pref.po | 2572 +- misc/translator/po/ta-LK-staff-prog.po | 16963 +++++---- misc/translator/po/ta-installer-MARC21.po | 229 +- misc/translator/po/ta-installer.po | 282 +- misc/translator/po/ta-marc-MARC21.po | 3095 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 358 +- misc/translator/po/ta-messages-js.po | 145 +- misc/translator/po/ta-messages.po | 71 +- misc/translator/po/ta-opac-bootstrap.po | 3310 +- misc/translator/po/ta-pref.po | 2550 +- misc/translator/po/ta-staff-prog.po | 16966 +++++---- ...-installer-MARC21.po => te-installer-MARC21.po} | 231 +- .../po/{am-Ethi-installer.po => te-installer.po} | 284 +- .../po/{as-IN-marc-MARC21.po => te-marc-MARC21.po} | 3259 +- .../po/{gd-marc-NORMARC.po => te-marc-NORMARC.po} | 2 +- .../po/{gd-marc-UNIMARC.po => te-marc-UNIMARC.po} | 358 +- misc/translator/po/te-messages-js.po | 160 + misc/translator/po/te-messages.po | 158 + ...l-GR-opac-bootstrap.po => te-opac-bootstrap.po} | 7780 ++-- misc/translator/po/{gd-pref.po => te-pref.po} | 2550 +- .../po/{hi-staff-prog.po => te-staff-prog.po} | 36527 ++++++++++--------- misc/translator/po/tet-installer-MARC21.po | 229 +- misc/translator/po/tet-installer.po | 282 +- misc/translator/po/tet-marc-MARC21.po | 3097 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 358 +- misc/translator/po/tet-messages-js.po | 145 +- misc/translator/po/tet-messages.po | 71 +- misc/translator/po/tet-opac-bootstrap.po | 3337 +- misc/translator/po/tet-pref.po | 2548 +- misc/translator/po/tet-staff-prog.po | 17064 +++++---- misc/translator/po/th-TH-installer-MARC21.po | 229 +- misc/translator/po/th-TH-installer.po | 282 +- misc/translator/po/th-TH-marc-MARC21.po | 3095 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 358 +- misc/translator/po/th-TH-messages-js.po | 145 +- misc/translator/po/th-TH-messages.po | 71 +- misc/translator/po/th-TH-opac-bootstrap.po | 3334 +- misc/translator/po/th-TH-pref.po | 2548 +- misc/translator/po/th-TH-staff-prog.po | 16996 +++++---- misc/translator/po/tl-PH-installer-MARC21.po | 229 +- misc/translator/po/tl-PH-installer.po | 282 +- misc/translator/po/tl-PH-marc-MARC21.po | 3095 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 358 +- misc/translator/po/tl-PH-messages-js.po | 145 +- misc/translator/po/tl-PH-messages.po | 71 +- misc/translator/po/tl-PH-opac-bootstrap.po | 3318 +- misc/translator/po/tl-PH-pref.po | 2602 +- misc/translator/po/tl-PH-staff-prog.po | 17037 +++++---- misc/translator/po/tr-TR-installer-MARC21.po | 104 +- misc/translator/po/tr-TR-installer.po | 282 +- misc/translator/po/tr-TR-marc-MARC21.po | 4199 ++- misc/translator/po/tr-TR-marc-NORMARC.po | 10 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 368 +- misc/translator/po/tr-TR-messages-js.po | 145 +- misc/translator/po/tr-TR-messages.po | 75 +- misc/translator/po/tr-TR-opac-bootstrap.po | 3574 +- misc/translator/po/tr-TR-pref.po | 2840 +- misc/translator/po/tr-TR-staff-prog.po | 19339 +++++----- misc/translator/po/tvl-installer-MARC21.po | 229 +- misc/translator/po/tvl-installer.po | 282 +- misc/translator/po/tvl-marc-MARC21.po | 3095 +- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 358 +- misc/translator/po/tvl-messages-js.po | 145 +- misc/translator/po/tvl-messages.po | 71 +- misc/translator/po/tvl-opac-bootstrap.po | 3310 +- misc/translator/po/tvl-pref.po | 2550 +- misc/translator/po/tvl-staff-prog.po | 16874 +++++---- misc/translator/po/uk-UA-marc-MARC21.po | 3417 +- misc/translator/po/uk-UA-marc-NORMARC.po | 12 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 376 +- misc/translator/po/uk-UA-messages-js.po | 156 +- misc/translator/po/uk-UA-messages.po | 76 +- misc/translator/po/uk-UA-opac-bootstrap.po | 3782 +- misc/translator/po/uk-UA-pref.po | 3406 +- misc/translator/po/uk-UA-staff-prog.po | 19241 +++++----- misc/translator/po/ur-Arab-installer-MARC21.po | 229 +- misc/translator/po/ur-Arab-installer.po | 282 +- misc/translator/po/ur-Arab-marc-MARC21.po | 3097 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 358 +- misc/translator/po/ur-Arab-messages-js.po | 145 +- misc/translator/po/ur-Arab-messages.po | 71 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 3321 +- misc/translator/po/ur-Arab-pref.po | 2548 +- misc/translator/po/ur-Arab-staff-prog.po | 16973 +++++---- misc/translator/po/vi-VN-installer-MARC21.po | 229 +- misc/translator/po/vi-VN-installer.po | 282 +- misc/translator/po/vi-VN-marc-MARC21.po | 3095 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 358 +- misc/translator/po/vi-VN-messages-js.po | 145 +- misc/translator/po/vi-VN-messages.po | 70 +- misc/translator/po/vi-VN-opac-bootstrap.po | 3544 +- misc/translator/po/vi-VN-pref.po | 2616 +- misc/translator/po/vi-VN-staff-prog.po | 17058 +++++---- misc/translator/po/zh-Hans-CN-installer-MARC21.po | 229 +- misc/translator/po/zh-Hans-CN-installer.po | 282 +- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 3097 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 358 +- misc/translator/po/zh-Hans-CN-messages-js.po | 145 +- misc/translator/po/zh-Hans-CN-messages.po | 71 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 3422 +- misc/translator/po/zh-Hans-CN-pref.po | 2624 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 17059 +++++---- misc/translator/po/zh-Hant-TW-installer-MARC21.po | 102 +- misc/translator/po/zh-Hant-TW-installer.po | 282 +- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 3103 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 12 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 370 +- misc/translator/po/zh-Hant-TW-messages-js.po | 145 +- misc/translator/po/zh-Hant-TW-messages.po | 70 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 3626 +- misc/translator/po/zh-Hant-TW-pref.po | 2712 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 17396 +++++---- 860 files changed, 1405429 insertions(+), 1021213 deletions(-) copy misc/translator/po/{dz-installer-MARC21.po => te-installer-MARC21.po} (97%) copy misc/translator/po/{am-Ethi-installer.po => te-installer.po} (90%) copy misc/translator/po/{as-IN-marc-MARC21.po => te-marc-MARC21.po} (87%) copy misc/translator/po/{gd-marc-NORMARC.po => te-marc-NORMARC.po} (99%) copy misc/translator/po/{gd-marc-UNIMARC.po => te-marc-UNIMARC.po} (98%) create mode 100644 misc/translator/po/te-messages-js.po create mode 100644 misc/translator/po/te-messages.po copy misc/translator/po/{el-GR-opac-bootstrap.po => te-opac-bootstrap.po} (53%) copy misc/translator/po/{gd-pref.po => te-pref.po} (83%) copy misc/translator/po/{hi-staff-prog.po => te-staff-prog.po} (61%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 13:38:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 11:38:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2287-g4c579207d9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4c579207d90cfba4290a42a06156d0556a56a16f (commit) from a2af51d688fd72e1f38dd687649f31d8d97d529a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4c579207d90cfba4290a42a06156d0556a56a16f Author: Martin Renvoize Date: Fri May 22 12:09:29 2020 +0100 Bug 23975: (RM follow-up) Comment example configuration As promised, I am commenting out the configuration for git repositories to use for searches by default prior to release. To enable the feature, simply uncomment the relevant github repositories or add your own. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: debian/templates/koha-conf-site.xml.in | 2 ++ etc/koha-conf.xml | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt | 2 ++ plugins/plugins-home.pl | 1 + 4 files changed, 7 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 14:04:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 12:04:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2288-g8ec729dc01 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8ec729dc01ab185fb9d72915783e997fcc3d3d17 (commit) from 4c579207d90cfba4290a42a06156d0556a56a16f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ec729dc01ab185fb9d72915783e997fcc3d3d17 Author: Jonathan Druart Date: Fri May 22 11:20:00 2020 +0200 Bug 24612: Fix existing ReserveSlip tests Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Reserves.t | 6 +++--- t/db_dependent/Reserves/ReserveSlip.t | 38 +++-------------------------------- 2 files changed, 6 insertions(+), 38 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 16:33:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 14:33:50 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2290-g17cd698b46 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 17cd698b46e45aff36b1a28fc44b5c775f385b21 (commit) via e1fbb8f3874a4ab203022ad500344c96455e829e (commit) from 8ec729dc01ab185fb9d72915783e997fcc3d3d17 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 17cd698b46e45aff36b1a28fc44b5c775f385b21 Author: Martin Renvoize Date: Fri May 22 14:49:06 2020 +0100 Bug 24380: (RM follow-up) Fix update statement to prevent regression The update statement did not respect the original value of CalcalateFinesOnReturn and so would result in an unexpected functional change during upgrades. Signed-off-by: Martin Renvoize commit e1fbb8f3874a4ab203022ad500344c96455e829e Author: Martin Renvoize Date: Fri May 22 13:15:55 2020 +0100 Bug 24347: Add sponsorship details Sponsored-by: Athens County Public Libraries Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 16:43:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 14:43:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-122-g3077bc733e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 3077bc733ea5290d6dda0b0fea0b501389070074 (commit) from ce695e062364ceada672f5ced2a258dabb3d4729 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3077bc733ea5290d6dda0b0fea0b501389070074 Author: Jonathan Druart Date: Wed May 13 13:05:48 2020 +0200 Bug 25480: Don't hide apache error and display incorrect error When searching if some apache mod are enable we are hiding the error (2> /dev/null) and display an error about the (guessed) missing module. It can lead to wrong tracks, let display the original apache error if there is one. This is linked with https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/119 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 4e2078d81b3ccb17e9794a6452578c5e87817e70) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-create | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 16:54:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 14:54:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-123-g422ce53bb7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 422ce53bb78c7dfa13ed706d973233b97a147e8d (commit) from 3077bc733ea5290d6dda0b0fea0b501389070074 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 422ce53bb78c7dfa13ed706d973233b97a147e8d Author: Phil Ringnalda Date: Fri Apr 24 11:34:29 2020 -0700 Bug 11446: Use encodeURIComponent on search terms in authority lookup plugin While adding the data from the existing field to the auth_finder URI, we're using encodeURI(), which is meant for an entire URI and thus doesn't escape &. Things that are going into a querystring need encodeURIComponent() instead. Test plan: 1. Enable the system preference EnableAdvancedCatalogingEditor 2. Clear your browser cache, even a shift+reload won't get you a fresh marc-editor.js for the advanced editor 3. Create a Topical Term authority with 150 $aThis & That$xStuff & Junk 4. In the Basic editor, use the authority plugin on the 650 field to select that authority. 5. Click the authority plugin again, verify that the popup contains This & That and Stuff & Junk rather than just This and Stuff 6. From the Cataloging home page choose Advanced editor 7. In a new line paste 650 _ _ ‡aThis & That‡xStuff & Junk 8. Type ctrl+shift+L and verify the popup shows both words in both fields 9. When you remember the plugin exists there too, edit your Stuff & Junk authority, and in a 550 tag type One & Two in $a and Three & Four in $x and click the plugin link, verify that the search window has your search terms not cut off. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 048894ffa5b7eb8dc1f5f9517be5834a3a889e1c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-editor.js | 2 +- koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 17:04:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 15:04:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-124-g8c2056fcc0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8c2056fcc04c4053e746e32db6be7d26df75e118 (commit) from 422ce53bb78c7dfa13ed706d973233b97a147e8d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8c2056fcc04c4053e746e32db6be7d26df75e118 Author: Phil Ringnalda Date: Tue Apr 28 17:16:51 2020 -0700 Bug 25308: Escape querystring for Z39.50 popup from cataloging Test plan: 1. For bonus fun, Administration -> MARC Frameworks -> New framework, with the code A&B and description Ants & Bees 2. In the A&B Actions menu, choose MARC structure since Import won't work 3. Accept the offer to copy in structure from default 4. Cataloging -> New record -> Ants & Bees 5. Type This & That in the 245$a (and for extra credit, in 020$a, and create an author authority with an & in it so you can put it in the 100/110) 6. Click Z39.50/SRU search, make sure everything you typed is prefilled including the parts after & 7. Search for anything that will retrieve a record (the ISBN This & That probably won't), choose Import 8. Check that the record came back, and verify in the Settings menu that it's still in the Ants & Bees framework. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 25ad50b252941e96541dc2d056559159b7d9dcc2) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 17:10:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 15:10:16 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-125-g6ca88cb50e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 6ca88cb50e2135094b9dad51781a971f31613c9e (commit) from 8c2056fcc04c4053e746e32db6be7d26df75e118 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6ca88cb50e2135094b9dad51781a971f31613c9e Author: Jonathan Druart Date: Fri May 8 12:14:07 2020 +0200 Bug 25400: [< 20.05] Fix cloning of circulation rules This patch is for 19.11 and anterior versions. The clone functionnality does not clone the "already moved rules" maxissueqty and maxonsiteissueqty. Test plan: Clone some circ rules from one branch to another Confirm that all the rules have been copied correctly Signed-off-by: Bernardo Gonzalez Kriegel Tested on 19.11, no errors Signed-off-by: Joy Nelson (cherry picked from commit 359b9f2029a8171d673bbc84d21797283822b7e8) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: admin/clone-rules.pl | 11 +++++++++++ 1 file changed, 11 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 22:34:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 20:34:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-127-g742460549f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 742460549f925a9cf031d48fb656a3702fa0bc94 (commit) via 983c95db2a9ad5032526a937d83b81e8d71e0b1f (commit) from 6ca88cb50e2135094b9dad51781a971f31613c9e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 742460549f925a9cf031d48fb656a3702fa0bc94 Author: Lucas Gass Date: Fri May 22 20:06:03 2020 +0000 Increment version for 19.05.11 release Signed-off-by: Lucas Gass commit 983c95db2a9ad5032526a937d83b81e8d71e0b1f Author: Koha translators <> Date: Fri May 22 16:58:06 2020 -0300 Translation updates for Koha 19.05.11 Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + misc/translator/po/am-Ethi-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 315 ++--- misc/translator/po/am-Ethi-pref.po | 8 +- misc/translator/po/am-Ethi-staff-prog.po | 1005 ++++++++------- misc/translator/po/ar-Arab-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 316 ++--- misc/translator/po/ar-Arab-pref.po | 16 +- misc/translator/po/ar-Arab-staff-prog.po | 1009 ++++++++------- misc/translator/po/as-IN-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 315 ++--- misc/translator/po/as-IN-pref.po | 8 +- misc/translator/po/as-IN-staff-prog.po | 1001 ++++++++------- misc/translator/po/az-AZ-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 316 ++--- misc/translator/po/az-AZ-pref.po | 8 +- misc/translator/po/az-AZ-staff-prog.po | 1001 ++++++++------- misc/translator/po/be-BY-marc-MARC21.po | 1497 +++++++++++----------- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 316 ++--- misc/translator/po/be-BY-pref.po | 8 +- misc/translator/po/be-BY-staff-prog.po | 1003 ++++++++------- misc/translator/po/bg-Cyrl-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 315 ++--- misc/translator/po/bg-Cyrl-pref.po | 8 +- misc/translator/po/bg-Cyrl-staff-prog.po | 1005 ++++++++------- misc/translator/po/bn-IN-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 318 ++--- misc/translator/po/bn-IN-pref.po | 8 +- misc/translator/po/bn-IN-staff-prog.po | 1001 ++++++++------- misc/translator/po/ca-ES-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 316 ++--- misc/translator/po/ca-ES-pref.po | 8 +- misc/translator/po/ca-ES-staff-prog.po | 1003 ++++++++------- misc/translator/po/cs-CZ-marc-MARC21.po | 1504 +++++++++++----------- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 320 ++--- misc/translator/po/cs-CZ-pref.po | 16 +- misc/translator/po/cs-CZ-staff-prog.po | 1036 ++++++++-------- misc/translator/po/cy-GB-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 315 ++--- misc/translator/po/cy-GB-pref.po | 8 +- misc/translator/po/cy-GB-staff-prog.po | 1001 ++++++++------- misc/translator/po/da-DK-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 316 ++--- misc/translator/po/da-DK-pref.po | 16 +- misc/translator/po/da-DK-staff-prog.po | 1005 ++++++++------- misc/translator/po/de-CH-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 316 ++--- misc/translator/po/de-CH-pref.po | 16 +- misc/translator/po/de-CH-staff-prog.po | 1007 ++++++++------- misc/translator/po/de-DE-marc-MARC21.po | 1500 +++++++++++----------- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 8 +- misc/translator/po/de-DE-opac-bootstrap.po | 321 ++--- misc/translator/po/de-DE-pref.po | 46 +- misc/translator/po/de-DE-staff-prog.po | 1105 ++++++++--------- misc/translator/po/dz-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/dz-marc-NORMARC.po | 2 +- misc/translator/po/dz-marc-UNIMARC.po | 2 +- misc/translator/po/dz-opac-bootstrap.po | 315 ++--- misc/translator/po/dz-pref.po | 8 +- misc/translator/po/dz-staff-prog.po | 1001 ++++++++------- misc/translator/po/el-GR-marc-MARC21.po | 1508 +++++++++++----------- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 316 ++--- misc/translator/po/el-GR-pref.po | 8 +- misc/translator/po/el-GR-staff-prog.po | 1007 ++++++++------- misc/translator/po/en-GB-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 316 ++--- misc/translator/po/en-GB-pref.po | 10 +- misc/translator/po/en-GB-staff-prog.po | 1009 ++++++++------- misc/translator/po/en-NZ-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 316 ++--- misc/translator/po/en-NZ-pref.po | 16 +- misc/translator/po/en-NZ-staff-prog.po | 1007 ++++++++------- misc/translator/po/eo-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 316 ++--- misc/translator/po/eo-pref.po | 8 +- misc/translator/po/eo-staff-prog.po | 1001 ++++++++------- misc/translator/po/es-ES-marc-MARC21.po | 1504 +++++++++++----------- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 323 ++--- misc/translator/po/es-ES-pref.po | 40 +- misc/translator/po/es-ES-staff-prog.po | 1020 ++++++++------- misc/translator/po/eu-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 316 ++--- misc/translator/po/eu-pref.po | 16 +- misc/translator/po/eu-staff-prog.po | 1005 ++++++++------- misc/translator/po/fa-Arab-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 316 ++--- misc/translator/po/fa-Arab-pref.po | 10 +- misc/translator/po/fa-Arab-staff-prog.po | 1003 ++++++++------- misc/translator/po/fi-FI-marc-MARC21.po | 1506 +++++++++++----------- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 362 +++--- misc/translator/po/fi-FI-pref.po | 16 +- misc/translator/po/fi-FI-staff-prog.po | 1030 ++++++++------- misc/translator/po/fo-FO-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 315 ++--- misc/translator/po/fo-FO-pref.po | 8 +- misc/translator/po/fo-FO-staff-prog.po | 1001 ++++++++------- misc/translator/po/fr-CA-marc-MARC21.po | 1504 +++++++++++----------- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 316 ++--- misc/translator/po/fr-CA-pref.po | 16 +- misc/translator/po/fr-CA-staff-prog.po | 1009 ++++++++------- misc/translator/po/fr-FR-marc-MARC21.po | 1500 +++++++++++----------- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 6 +- misc/translator/po/fr-FR-opac-bootstrap.po | 324 ++--- misc/translator/po/fr-FR-pref.po | 50 +- misc/translator/po/fr-FR-staff-prog.po | 1031 ++++++++------- misc/translator/po/ga-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 2 +- misc/translator/po/ga-opac-bootstrap.po | 315 ++--- misc/translator/po/ga-pref.po | 8 +- misc/translator/po/ga-staff-prog.po | 1001 ++++++++------- misc/translator/po/gd-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 2 +- misc/translator/po/gd-opac-bootstrap.po | 315 ++--- misc/translator/po/gd-pref.po | 8 +- misc/translator/po/gd-staff-prog.po | 1001 ++++++++------- misc/translator/po/gl-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 316 ++--- misc/translator/po/gl-pref.po | 8 +- misc/translator/po/gl-staff-prog.po | 1001 ++++++++------- misc/translator/po/he-Hebr-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 316 ++--- misc/translator/po/he-Hebr-pref.po | 8 +- misc/translator/po/he-Hebr-staff-prog.po | 1001 ++++++++------- misc/translator/po/hi-marc-MARC21.po | 1500 +++++++++++----------- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 319 ++--- misc/translator/po/hi-pref.po | 33 +- misc/translator/po/hi-staff-prog.po | 1031 ++++++++------- misc/translator/po/hr-HR-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 316 ++--- misc/translator/po/hr-HR-pref.po | 8 +- misc/translator/po/hr-HR-staff-prog.po | 1003 ++++++++------- misc/translator/po/hu-HU-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 316 ++--- misc/translator/po/hu-HU-pref.po | 8 +- misc/translator/po/hu-HU-staff-prog.po | 1003 ++++++++------- misc/translator/po/hy-Armn-marc-MARC21.po | 1500 +++++++++++----------- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 319 ++--- misc/translator/po/hy-Armn-pref.po | 44 +- misc/translator/po/hy-Armn-staff-prog.po | 1026 ++++++++------- misc/translator/po/ia-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 315 ++--- misc/translator/po/ia-pref.po | 8 +- misc/translator/po/ia-staff-prog.po | 1001 ++++++++------- misc/translator/po/id-ID-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 316 ++--- misc/translator/po/id-ID-pref.po | 8 +- misc/translator/po/id-ID-staff-prog.po | 1003 ++++++++------- misc/translator/po/iq-CA-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 315 ++--- misc/translator/po/iq-CA-pref.po | 8 +- misc/translator/po/iq-CA-staff-prog.po | 1001 ++++++++------- misc/translator/po/is-IS-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 316 ++--- misc/translator/po/is-IS-pref.po | 8 +- misc/translator/po/is-IS-staff-prog.po | 1001 ++++++++------- misc/translator/po/it-IT-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 316 ++--- misc/translator/po/it-IT-pref.po | 16 +- misc/translator/po/it-IT-staff-prog.po | 1007 ++++++++------- misc/translator/po/iu-CA-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 315 ++--- misc/translator/po/iu-CA-pref.po | 8 +- misc/translator/po/iu-CA-staff-prog.po | 1001 ++++++++------- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 320 ++--- misc/translator/po/ja-Jpan-JP-pref.po | 8 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 1001 ++++++++------- misc/translator/po/ka-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 316 ++--- misc/translator/po/ka-pref.po | 8 +- misc/translator/po/ka-staff-prog.po | 1007 ++++++++------- misc/translator/po/km-KH-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 315 ++--- misc/translator/po/km-KH-pref.po | 8 +- misc/translator/po/km-KH-staff-prog.po | 1001 ++++++++------- misc/translator/po/kn-Knda-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 316 ++--- misc/translator/po/kn-Knda-pref.po | 8 +- misc/translator/po/kn-Knda-staff-prog.po | 1001 ++++++++------- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 316 ++--- misc/translator/po/ko-Kore-KP-pref.po | 16 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 1007 ++++++++------- misc/translator/po/ku-Arab-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 316 ++--- misc/translator/po/ku-Arab-pref.po | 8 +- misc/translator/po/ku-Arab-staff-prog.po | 1001 ++++++++------- misc/translator/po/lo-Laoo-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 316 ++--- misc/translator/po/lo-Laoo-pref.po | 8 +- misc/translator/po/lo-Laoo-staff-prog.po | 1001 ++++++++------- misc/translator/po/lv-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 2 +- misc/translator/po/lv-opac-bootstrap.po | 315 ++--- misc/translator/po/lv-pref.po | 8 +- misc/translator/po/lv-staff-prog.po | 1001 ++++++++------- misc/translator/po/mi-NZ-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 316 ++--- misc/translator/po/mi-NZ-pref.po | 8 +- misc/translator/po/mi-NZ-staff-prog.po | 1001 ++++++++------- misc/translator/po/ml-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 315 ++--- misc/translator/po/ml-pref.po | 8 +- misc/translator/po/ml-staff-prog.po | 1001 ++++++++------- misc/translator/po/mon-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 316 ++--- misc/translator/po/mon-pref.po | 8 +- misc/translator/po/mon-staff-prog.po | 1001 ++++++++------- misc/translator/po/mr-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 316 ++--- misc/translator/po/mr-pref.po | 8 +- misc/translator/po/mr-staff-prog.po | 1001 ++++++++------- misc/translator/po/ms-MY-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 316 ++--- misc/translator/po/ms-MY-pref.po | 8 +- misc/translator/po/ms-MY-staff-prog.po | 1005 ++++++++------- misc/translator/po/my-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 315 ++--- misc/translator/po/my-pref.po | 8 +- misc/translator/po/my-staff-prog.po | 1001 ++++++++------- misc/translator/po/nb-NO-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 316 ++--- misc/translator/po/nb-NO-pref.po | 16 +- misc/translator/po/nb-NO-staff-prog.po | 1015 ++++++++------- misc/translator/po/ne-NE-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 315 ++--- misc/translator/po/ne-NE-pref.po | 8 +- misc/translator/po/ne-NE-staff-prog.po | 1005 ++++++++------- misc/translator/po/nl-BE-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 316 ++--- misc/translator/po/nl-BE-pref.po | 16 +- misc/translator/po/nl-BE-staff-prog.po | 1005 ++++++++------- misc/translator/po/nl-NL-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 316 ++--- misc/translator/po/nl-NL-pref.po | 8 +- misc/translator/po/nl-NL-staff-prog.po | 1017 ++++++++------- misc/translator/po/nn-NO-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 316 ++--- misc/translator/po/nn-NO-pref.po | 8 +- misc/translator/po/nn-NO-staff-prog.po | 1001 ++++++++------- misc/translator/po/oc-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 316 ++--- misc/translator/po/oc-pref.po | 16 +- misc/translator/po/oc-staff-prog.po | 1007 ++++++++------- misc/translator/po/pbr-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 315 ++--- misc/translator/po/pbr-pref.po | 8 +- misc/translator/po/pbr-staff-prog.po | 1001 ++++++++------- misc/translator/po/pl-PL-marc-MARC21.po | 1504 +++++++++++----------- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 316 ++--- misc/translator/po/pl-PL-pref.po | 16 +- misc/translator/po/pl-PL-staff-prog.po | 1007 ++++++++------- misc/translator/po/prs-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 316 ++--- misc/translator/po/prs-pref.po | 16 +- misc/translator/po/prs-staff-prog.po | 1001 ++++++++------- misc/translator/po/pt-BR-marc-MARC21.po | 1514 ++++++++++++----------- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 328 ++--- misc/translator/po/pt-BR-pref.po | 70 +- misc/translator/po/pt-BR-staff-prog.po | 1028 ++++++++------- misc/translator/po/pt-PT-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 316 ++--- misc/translator/po/pt-PT-pref.po | 21 +- misc/translator/po/pt-PT-staff-prog.po | 1011 ++++++++------- misc/translator/po/ro-RO-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 316 ++--- misc/translator/po/ro-RO-pref.po | 8 +- misc/translator/po/ro-RO-staff-prog.po | 1001 ++++++++------- misc/translator/po/ru-RU-marc-MARC21.po | 1497 +++++++++++----------- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 316 ++--- misc/translator/po/ru-RU-pref.po | 8 +- misc/translator/po/ru-RU-staff-prog.po | 1003 ++++++++------- misc/translator/po/rw-RW-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 315 ++--- misc/translator/po/rw-RW-pref.po | 8 +- misc/translator/po/rw-RW-staff-prog.po | 1001 ++++++++------- misc/translator/po/sd-PK-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 315 ++--- misc/translator/po/sd-PK-pref.po | 8 +- misc/translator/po/sd-PK-staff-prog.po | 1005 ++++++++------- misc/translator/po/sk-SK-marc-MARC21.po | 1511 +++++++++++----------- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 316 ++--- misc/translator/po/sk-SK-pref.po | 16 +- misc/translator/po/sk-SK-staff-prog.po | 1027 ++++++++------- misc/translator/po/sl-SI-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 315 ++--- misc/translator/po/sl-SI-pref.po | 16 +- misc/translator/po/sl-SI-staff-prog.po | 1001 ++++++++------- misc/translator/po/sq-AL-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 316 ++--- misc/translator/po/sq-AL-pref.po | 8 +- misc/translator/po/sq-AL-staff-prog.po | 1005 ++++++++------- misc/translator/po/sr-Cyrl-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 315 ++--- misc/translator/po/sr-Cyrl-pref.po | 8 +- misc/translator/po/sr-Cyrl-staff-prog.po | 1005 ++++++++------- misc/translator/po/sv-SE-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 331 ++--- misc/translator/po/sv-SE-pref.po | 16 +- misc/translator/po/sv-SE-staff-prog.po | 1025 +++++++-------- misc/translator/po/sw-KE-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 315 ++--- misc/translator/po/sw-KE-pref.po | 8 +- misc/translator/po/sw-KE-staff-prog.po | 1001 ++++++++------- misc/translator/po/ta-LK-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 315 ++--- misc/translator/po/ta-LK-pref.po | 8 +- misc/translator/po/ta-LK-staff-prog.po | 1001 ++++++++------- misc/translator/po/ta-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 315 ++--- misc/translator/po/ta-pref.po | 8 +- misc/translator/po/ta-staff-prog.po | 1001 ++++++++------- misc/translator/po/tet-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 316 ++--- misc/translator/po/tet-pref.po | 8 +- misc/translator/po/tet-staff-prog.po | 1007 ++++++++------- misc/translator/po/th-TH-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 315 ++--- misc/translator/po/th-TH-pref.po | 8 +- misc/translator/po/th-TH-staff-prog.po | 1001 ++++++++------- misc/translator/po/tl-PH-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 316 ++--- misc/translator/po/tl-PH-pref.po | 16 +- misc/translator/po/tl-PH-staff-prog.po | 1001 ++++++++------- misc/translator/po/tr-TR-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 316 ++--- misc/translator/po/tr-TR-pref.po | 32 +- misc/translator/po/tr-TR-staff-prog.po | 1078 ++++++++-------- misc/translator/po/tvl-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 2 +- misc/translator/po/tvl-opac-bootstrap.po | 315 ++--- misc/translator/po/tvl-pref.po | 8 +- misc/translator/po/tvl-staff-prog.po | 1001 ++++++++------- misc/translator/po/uk-UA-marc-MARC21.po | 1498 +++++++++++----------- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 8 +- misc/translator/po/uk-UA-opac-bootstrap.po | 331 ++--- misc/translator/po/uk-UA-pref.po | 16 +- misc/translator/po/uk-UA-staff-prog.po | 1346 ++++++++++---------- misc/translator/po/ur-Arab-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 315 ++--- misc/translator/po/ur-Arab-pref.po | 8 +- misc/translator/po/ur-Arab-staff-prog.po | 1001 ++++++++------- misc/translator/po/vi-VN-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 316 ++--- misc/translator/po/vi-VN-pref.po | 16 +- misc/translator/po/vi-VN-staff-prog.po | 1003 ++++++++------- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 1496 +++++++++++----------- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 316 ++--- misc/translator/po/zh-Hans-CN-pref.po | 16 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 1007 ++++++++------- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 1502 +++++++++++----------- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 8 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 8 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 332 ++--- misc/translator/po/zh-Hant-TW-pref.po | 16 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 1032 ++++++++------- 518 files changed, 123494 insertions(+), 121160 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 22:39:57 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 20:39:57 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.10-128-g2c9c228514 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 2c9c228514ceb4aed26ae6b1b9ff0e22a3085807 (commit) from 742460549f925a9cf031d48fb656a3702fa0bc94 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2c9c228514ceb4aed26ae6b1b9ff0e22a3085807 Author: Lucas Gass Date: Fri May 22 20:11:24 2020 +0000 Update release notes for 19.05.11 release Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/release_notes/release_notes_19_05_11.html | 699 +++++++++++++++++++++++++ misc/release_notes/release_notes_19_05_11.md | 547 +++++++++++++++++++ 2 files changed, 1246 insertions(+) create mode 100644 misc/release_notes/release_notes_19_05_11.html create mode 100644 misc/release_notes/release_notes_19_05_11.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 22 22:42:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 22 May 2020 20:42:44 +0000 Subject: [koha-commits] main Koha release repository annotated tag v19.05.11 created. v19.05.11 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v19.05.11 has been created at 075ba0aa9fa54f358964d87ec2eeb846e2342049 (tag) tagging 2c9c228514ceb4aed26ae6b1b9ff0e22a3085807 (commit) replaces v19.05.10 tagged by Lucas Gass on Fri May 22 14:14:49 2020 -0600 - Log ----------------------------------------------------------------- Koha release 19.05.11 -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEiuLrhIFCDD7BMEVj+cc4/xIeRdoFAl7IMrkACgkQ+cc4/xIe RdrltQgAmxRKHnb9vl3tEHbdH0FIVgEXy8UBstRoBdQhDxVZ6EYZwyJtxbvgxF/O dfptciFYr7YoOGJqcPRLT/AUXkeHY3FJ48Z+iudiWl6divR4KDyGiD+CGR0+MA3A zczpVKTPnDqyMLVdPaT/MD+EXD0oM4q82F5G3Q12KbZTkVv0pSGO2dSi9yDdjWj5 mcVFs8VCcFXzr48aGStbnWSDzvFyiH5l2l8mSVf6utiQ52dZF/pi8D7DCIGtUVvq M+S/cLzU7GOADn083NUY+7MkfJTGFKGT65Eu6TqTcSUK62F8QI2LxSY85bLoDhsU xt6+ZPyuVzb6ELnw0rCY+NL4O47/AQ== =8gGZ -----END PGP SIGNATURE----- Aleisha Amohia (1): Bug 24266: (alternate patch) Only use defined borrowernumbers in reconcile_balances.pl cron Andreas Roussos (1): Bug 25046: Include borrowers.othernames in SELECT statement Andrew Fuerste-Henry (4): Bug 25224: Show large print format in search results XSLT Bug 23081: set default to 0 for items.issues and deleteditems.issues Bug 23081: atomicupdate for change to existing installs Bug 25335: group by authorised_value in addbiblio.pl Andrew Isherwood (1): Bug 24043: Fix retrieval of of status name Bernardo González Kriegel (2): Bug 24636: translate planning sections Bug 24636: (follow-up) - move 'by' into include file David Cook (2): Bug 25300: Fix typo in "Edit details" for expiring/expired patron Bug 25299: Show soon to expire patron date David Roberts (5): Bug 24940: Serials statistics wizard: order vendor list alphabetically Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it Bug 25053: Clarify the description of syspref PatronSelfRegistrationExpireTemporaryAccountsDelay Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a Bug 25388: There is no link for the "online help" Fridolin Somers (4): Bug 21865: improve remove_unused_authorities.pl script Bug 21865: ES compatiblity of remove_unused_authorities.pl Bug 21865: add confirm to remove_unused_authorities.pl script Bug 21865: allow test arg alone George Veranis (1): Bug 19312: Fix typo in template Grace McKenzie (1): Bug 17853: Don't remove () from 780 link text Jonathan Druart (24): Bug 24013: Add tests Bug 24013: Fix transferbook if item is checked out Bug 24964: [19.11.x] Add tests Bug 24964: [19.11.x] Do not filter patrons after they have been fetched Bug 24964: [19.11.x] Prevent random failures sorting by borrowernumber Bug 24964: [19.11.x] Do not fetch all patrons for owner/users of funds Bug 25024: Do not escape $ Bug 24826: Remove warnings from Sendmail Bug 25046: Add test Bug 24993: Make sure SIP server is stopped before restarting it Bug 24993: Make sure we are not going to loop indefinitely Bug 25027: Use localStorage instead of sessionStorage for results browser Bug 25069: Fix AddressFormat="fr" behavior Bug 25186: Fix accordion sections height in columns configuration page Bug 23081: Revert "Bug 24443: Consider NULL as 0 for issues in items search" Bug 23081: Adjust tests Bug 23081: [19.11.x] Set items.issues to 0 if not provided (AddItem) Bug 22828: Add tests Bug 25133: Fix time part of due date for 12hr Bug 25133: Handle 12hr format for dt_from_string Bug 25157: Silent patron deletion cmd line script Bug 25418: (bug 25133 follow-up) Display due date with hours Bug 25480: Don't hide apache error and display incorrect error Bug 25400: [< 20.05] Fix cloning of circulation rules Josef Moravec (1): Bug 24043: (QA follow-up) Fix another TypeError when retrieving status name Joseph Sikowitz (1): Bug 24750: Instructor Search Results Joy Nelson (1): Bug 25184: (follow-up) fix number of tests Julian Maurice (1): Bug 24604: Add 'Pay' button under Transactions tab in patron accounting Katrin Fischer (14): Bug 9422: Don't allow access to 'Upload patron images' when patronimages syspref is off Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options Bug 25013: Fix capitalization: Edit Items on batch item edit Bug 25012: Fix class on OPAC view link in staff detail page Bug 17938: Fix display of label for repeated MARC 583 - Action note fields Bug 22468: Standardize on labelling ccode table columns as Collections Bug 10561: Rephrase DisplayOPACiconsXSLT and DisplayIconsXSLT slightly Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs Bug 13557: Add hint for on-site checkouts to list of current checkouts in OPAC Bug 21927: Acq - Add blank values in pull downs of mandatory item subfields Bug 17232: Make sure all fields are copies when creating a new framework from another Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql Koha translators (1): Translation updates for Koha 19.05.11 Kyle M Hall (11): Bug 24964: [19.11.x] Fix perl critic warning Bug 22937: Add hint to groups editor Bug 22778: Suggestions with no "suggester" can cause errors Bug 22778: Add unit test Bug 25095: Remove warn left in FeePayment.pm Bug 24966: Add unit tests Bug 24547: Add more action logs for holds Bug 20101: Cronjob automatic_item_modification_by_age.pl does not log run in action logs Bug 25107: Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType Bug 25184: Items with a negative notforloan status should not be captured for holds Bug 25184: Add syspref Liz Rea (1): Bug 24993: fix increment Lucas Gass (13): Bug 20754: DBRev 19.05.11.001 Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature Bug 20882: (Rmaint follow-up) fix shebang typo Bug 25007: Check for normaalized ISBN when building Amazon link Bug 24957: OpenLibrarySearch shouldnt display if nothing is returned Bug 25233: Staff XSLT material type label "Book" should be "Text" Bug 23081: DBRev 19.05.10.002 Bug 25072: Fix details.tt print CSS Bug 21565: Add modal to SCO confirm Bug 25341: Remove whitespace from barcode in add_items.pl Bug 25184: DBRev 19.05.10.003 Increment version for 19.05.11 release Update release notes for 19.05.11 release Marcel de Rooy (7): Bug 20754: DB revision to remove double accepted shares Bug 24966: (QA follow-up) Fix return value of hold_patron_bcode Bug 24903: Special characters like parentheses in numbering pattern cause duplication in recievedlist Bug 24903: Add tests for _handle_seqno Bug 22437: Add test case to Merge.t Bug 22437: Delete older merge requests at new merge time Bug 22437: (follow-up) Move deletion of merge requests to DelAuthority Martin Renvoize (2): Bug 9422: (RM follow-up) Rebase Correction Bug 15751: Add ModDateLastSeen to ProcessOfflineReturn Nick Clemens (12): Bug 25262: [19.05.x] Do not truncate MANUAL_INV in dropdown Bug 23601: Prevent default for auxclick Bug 25024: Make grep match full string Bug 25223: Make join of aqbasket and aqorders explicit Bug 25231: Rename button instead of alert/confirm when replacing record Bug 22828: Elasticsearch - display errors encountered during indexing on the command line Bug 25247: Only convert data ot objects when displaying on screen Bug 25133: (follow-up) Remove Names as they do no affect display Bug 25133: (follow-up) Move changes to timepicker.inc Bug 25342: Force ES id as string Bug 25342: Unit test Bug 25418: (QA follow-up) Raise size of input box Owen Leonard (7): Bug 25022: Display problem in authority editor with repeatable field Bug 25007: (follow-up) Fix the way image check alters layout Bug 25274: Don't initialize DataTable if table isn't present Bug 25211: Add missing share icon to OPAC lists page Bug 21565: (follow-up) Make confirmation buttons more detailed Bug 22515: Improve logic determining how to show OPAC suggestions Bug 24522: Show alert when trying to add nothing to a list in staff Phil Ringnalda (3): Bug 20501: Don't cut strings when unhighlighting in intranet search results Bug 11446: Use encodeURIComponent on search terms in authority lookup plugin Bug 25308: Escape querystring for Z39.50 popup from cataloging Slava Shishkin (2): Bug 25409: Add missing "required" class to template Bug 25409: Add missing "Required" text and "required" classes Theodoros Theodoropoulos (1): Bug 23514: Split Call Numbers for all layout types Tomás Cohen Arazi (4): Bug 25019: Make the ViewPolicy filter initialization standard Bug 25008: Regression tests Bug 25008: Tests for ->options Bug 25008: Overload Koha::RecordProcessor->options to update filters ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 23 09:58:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 23 May 2020 07:58:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2291-gf87317af7f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f87317af7fc5d45d1a826c953b53c7ea821d2447 (commit) from 17cd698b46e45aff36b1a28fc44b5c775f385b21 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f87317af7fc5d45d1a826c953b53c7ea821d2447 Author: Mason James Date: Sat May 23 08:56:00 2020 +1200 Bug 25591: Update debian/control for debian 10 This patch updates the debian/control for koha 20.05 on debian 10 Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: debian/control | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 23 09:59:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 23 May 2020 07:59:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2292-g6028c92c7b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6028c92c7b299b85d871605cd46d5bb97b760f7b (commit) from f87317af7fc5d45d1a826c953b53c7ea821d2447 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6028c92c7b299b85d871605cd46d5bb97b760f7b Author: Julian Maurice Date: Fri May 22 16:45:02 2020 +0200 Bug 25517: Look in all possible places for MO files On a 'dev' install, MO files will be installed in /misc/translator/po On 'standard' and 'single' installs, they will be installed in /../../misc/translator/po This patch makes Koha::I18N try to use the "dev" directory first, and fallback to the "standard" directory. If none of these directories exist, it dies. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/I18N.pm | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat May 23 10:02:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 23 May 2020 08:02:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2294-g721d925c58 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 721d925c58db26d432faf4b7ef37c23343bd3ac0 (commit) via cdfcc5430fe8241559d081054d69d3d4adbc497d (commit) from 6028c92c7b299b85d871605cd46d5bb97b760f7b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 721d925c58db26d432faf4b7ef37c23343bd3ac0 Author: Jonathan Druart Date: Fri May 22 15:33:36 2020 +0200 Bug 25540: Default for branches.pickup_location must be 0 This is a try to fix failures in both t/db_dependent/Template/Plugin/Branches.t t/db_dependent/Koha/Biblio.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit cdfcc5430fe8241559d081054d69d3d4adbc497d Author: Jonathan Druart Date: Tue May 19 15:31:43 2020 +0200 Bug 25540: Use build_sample_item Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Biblio.t | 36 ++++++++---------------------------- t/lib/TestBuilder.pm | 3 +++ 2 files changed, 11 insertions(+), 28 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 25 16:28:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 25 May 2020 14:28:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2296-gfc0292195b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fc0292195bc9d85159dbd5fae6cfaf57f7d55115 (commit) via 6fd3b974fc9d13cafb0c7e426c6a9c92b1339e28 (commit) from 721d925c58db26d432faf4b7ef37c23343bd3ac0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fc0292195bc9d85159dbd5fae6cfaf57f7d55115 Author: Jonathan Druart Date: Mon May 25 10:25:52 2020 +0200 Bug 22630: Display correct "in storage" value Signed-off-by: Jonathan Druart commit 6fd3b974fc9d13cafb0c7e426c6a9c92b1339e28 Author: Jonathan Druart Date: Mon May 25 10:14:19 2020 +0200 Bug 24413: (follow-up) Add tests Add missing transaction. Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/course_reserves/course-details.tt | 2 +- t/db_dependent/Circulation/MarkIssueReturned.t | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 26 15:11:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 26 May 2020 13:11:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2298-g0b5a8f6c19 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0b5a8f6c19c2705ed72c57185aee12b1333cf5ae (commit) via 652b0ec817e1c3e9d25c9a2945c721c8cb896cf8 (commit) from fc0292195bc9d85159dbd5fae6cfaf57f7d55115 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0b5a8f6c19c2705ed72c57185aee12b1333cf5ae Author: Jonathan Druart Date: Tue May 26 14:41:04 2020 +0200 Bug 20116: Fix package install path for clear_cache.pl root at koha-debian10:~# koha-translate --install es-ES /bin/bash: /usr/share/koha/misc/bin/clear_cache.pl: No such file or directory The script is in /usr/share/koha/bin/clear_cache.pl Signed-off-by: Jonathan Druart commit 652b0ec817e1c3e9d25c9a2945c721c8cb896cf8 Author: Petro Vashchuk Date: Mon May 25 17:39:58 2020 +0300 Bug 25556: fix for unnecessary empty name/value pairs creation During the web-install onboarding process, when the default circulation rule gets created, "circulation_rules" table gets populated with empty rule_name/rule_value items. This behavior differs from how the "unset" button on the smart-rules.pl page in "Default checkout, hold and return policy" group acts and leads to unpredictable bug when empty "holdallowed" rule_name prevents holds from any user. This fix removes creation of these empty name/value pairs. To reproduce: 1) Start with an empty installation (or delete all circulation rules and press "unset" in hold and return policy section on /cgi-bin/koha/admin/smart-rules.pl page). This is to have the circulation_rules table empty so onboarding.pl will work. 2) Go through the onboarding.pl process and create a default circulation rule. 3) Make sure that circulation_rules table contains will contain empty "patron_maxonsiteissueqty", "max_holds", "patron_maxissueqty", "returnbranch", "holdallowed" and "hold_fulfillment_policy" fields. 4) Apply the patch. 5) Repeat steps 1 and 2. 6) Observe that there are none of six mentioned above name/value pairs appeared. To reproduce the bug with empty "holdallowed" rule_name: 1) Repeat steps 1, 2 and 3 that are listed in the previous instruction of reproduction, in order to get empty "holdallowed" field. 2) Find existing or create a new book with available status and place a holding on it. 3) Observe the yellow notification window with "Cannot place hold. No items are available to be placed on hold." warning. 4) Apply the patch. 5) Repeat steps 1 and 2. 6) Observe that hold was successfully placed and yellow notification does not appear anymore. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-translate | 2 +- installer/onboarding.pl | 22 ---------------------- 2 files changed, 1 insertion(+), 23 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 29 01:16:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 28 May 2020 23:16:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.11-1-g0578902e91 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0578902e9151f66763b05da58db6387c753fdb93 (commit) from 2c9c228514ceb4aed26ae6b1b9ff0e22a3085807 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0578902e9151f66763b05da58db6387c753fdb93 Author: Lucas Gass Date: Thu May 28 22:48:12 2020 +0000 Bug 25184: Rmaint follow-up: fix updatedatabase typo Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 29 12:15:00 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 29 May 2020 10:15:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2310-ga7778ed858 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a7778ed8586b00bdf79dbd5db02c525d108ea8ea (commit) via 7b1e8c59fe0edc2faab878c6bd9d45de9f720e81 (commit) via 46e23b3a035e9c326c50aaa2dfba62667a9aca4b (commit) via dd0c7c55fc2b5f0a312055d0c051b166d75ea82d (commit) via a79cf4150e8a08e743acc7d7147af91757d7a9b8 (commit) via 9d8f9f1d3b0a10bc677904cd39764acbf4f75e13 (commit) via f1cc9d6b599ae423d8024fb11f3f601d57ab9963 (commit) via 218322597e7a7104a15229e333ae7c1a917a675c (commit) via 051b2d014241ea6f71084227b05023808cff0212 (commit) via 6b1a53da6d38e5bba7317e8b24be1df501ed0db0 (commit) via 84230706499b4673d9061adc2d2ac025fa31a342 (commit) via 5818d900e8e7927bc437dc60cd992c6a18ceb16f (commit) from 0b5a8f6c19c2705ed72c57185aee12b1333cf5ae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a7778ed8586b00bdf79dbd5db02c525d108ea8ea Author: Devinim Date: Fri May 22 22:11:31 2020 +0000 Bug 25592: Add Devinim to about page This adds Devinim to the 'Contributing companies and institutions' section on Koha's about page. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 7b1e8c59fe0edc2faab878c6bd9d45de9f720e81 Author: Jonathan Druart Date: Thu May 28 15:30:02 2020 +0200 Bug 25618: Fix wrong package install path for misc dir root at koha-debian9:/# koha-z3950-responder --start d9 [....] Starting Z39.50/SRU daemon for d9:Can't open perl script "/usr/share/koha/bin/z3950_responder.pl/z3950_responder.pl": Not a directory failed! Test plan: On a dev install, copy the debian script and run it Same on a package install Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart commit 46e23b3a035e9c326c50aaa2dfba62667a9aca4b Author: Nick Clemens Date: Thu May 28 17:37:20 2020 +0000 Bug 25617: (QA follow-up) Add responses to tests Signed-off-by: Nick Clemens Signed-off-by: Julian Maurice Signed-off-by: Alex Arnaud Signed-off-by: Jonathan Druart commit dd0c7c55fc2b5f0a312055d0c051b166d75ea82d Author: Jonathan Druart Date: Thu May 28 16:12:57 2020 +0200 Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0 There was an error in the precedent code, in 12hr format, 12PM is actually 00:00 Signed-off-by: Nick Clemens Signed-off-by: Julian Maurice Signed-off-by: Alex Arnaud Signed-off-by: Jonathan Druart commit a79cf4150e8a08e743acc7d7147af91757d7a9b8 Author: Jonathan Druart Date: Fri May 22 14:29:20 2020 +0200 Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON This patch removes a problematic integer casting happening in TO_JSON. The original need for this cast (a DBD::mysql bug) is now fixed. We remove the cast as it is causing random failures. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail with select high values (i.e. casting gives wrong results) 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests now pass! 5. Sign off :-D Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 9d8f9f1d3b0a10bc677904cd39764acbf4f75e13 Author: Tomas Cohen Arazi Date: Wed May 27 09:55:16 2020 -0300 Bug 25513: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit f1cc9d6b599ae423d8024fb11f3f601d57ab9963 Author: Jonathan Druart Date: Tue May 26 10:10:52 2020 +0200 Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return policy for $branch" returnbranch has to pass an itemtype key when setting the rule (here setting it to unlimited for any item types) Test plan: 1. Go the "Circulation and fine rules" admin page 2. Set a rule for "Default checkout, hold and return policy" 3. Unset it 4. Select a library 5. Set a rule for "Default checkout, hold and return policy" 6. Unset it Display should be consistent with what you selected Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 218322597e7a7104a15229e333ae7c1a917a675c Author: Didier Gautheron Date: Wed May 27 04:18:58 2020 +0200 Bug 25608: (bug 23463 follow-up) Fix inventory regression Follow-up work commit bbb504c86f5ca0a474365d4839177412f415c4ee Bug 23463: Replace ModItem with Koha::Item->store Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Submit => without patch, you get an error trace - Apply patch, it works Signed-off-by: Jonathan Druart Amended commit title. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 051b2d014241ea6f71084227b05023808cff0212 Author: Kyle M Hall Date: Wed May 27 06:28:40 2020 -0400 Bug 25444: More minor improvements to simplified loop Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 6b1a53da6d38e5bba7317e8b24be1df501ed0db0 Author: Jonathan Druart Date: Wed May 27 10:25:15 2020 +0200 Bug 25444: Simplify the code using a loop In order to prevent typos or further regressions it is better (I think) to have this code into a loop Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 84230706499b4673d9061adc2d2ac025fa31a342 Author: Kyle M Hall Date: Tue May 26 09:08:15 2020 -0400 Bug 25444: Backup/restore course items fields correctly This patch makes the code set the *_storage fields when adding new fields to an existing course item. And reverts those fields correctly when removing the item from the course. If a new field is enabled on an existing course reserve, the storage field is not given a value, so when the item goes off reserve, the item field will always be updated to NULL. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/CourseReserves/CourseItems.t => FAIL: Tests fail, data is not reverted correctly 3. Apply this patch and repeat 2 => SUCCESS: Tests pass! Data is correctly reverted 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 5818d900e8e7927bc437dc60cd992c6a18ceb16f Author: Kyle M Hall Date: Tue May 26 13:04:11 2020 -0400 Bug 25444: Add unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/CourseReserves.pm | 38 +++++-- Koha/DateUtils.pm | 9 +- Koha/Object.pm | 9 -- admin/smart-rules.pl | 3 +- debian/scripts/koha-z3950-responder | 8 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 1 + t/DateUtils.t | 27 ++++- t/db_dependent/CourseReserves/CourseItems.t | 133 ++++++++++++++++++++++- t/db_dependent/api/v1/acquisitions_orders.t | 19 +++- tools/inventory.pl | 7 +- 10 files changed, 220 insertions(+), 34 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 29 21:38:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 29 May 2020 19:38:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-2311-g9c5ff1df9d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9c5ff1df9de387ba6bb5f47c27f84c2d6108d3a8 (commit) from a7778ed8586b00bdf79dbd5db02c525d108ea8ea (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9c5ff1df9de387ba6bb5f47c27f84c2d6108d3a8 Author: Martin Renvoize Date: Fri May 29 20:04:16 2020 +0100 Bug 24846: Add sponsorship details Sponsored-by: PTFS Europe Sponsored-by: ByWater Solutions Sponsored-by: BibLibre Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun May 31 23:41:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 31 May 2020 21:41:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v20.05.00 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d148412c1dae1465fb310958ec2b3afae4eccea5 (commit) via bcea97744b7c753368ff78829441e1b8df752246 (commit) via aef33d840c78e82013940cf74b597e2ba8c526d0 (commit) via 50d619d15625a3fecff9e0383798fa0e19ba0586 (commit) from 9c5ff1df9de387ba6bb5f47c27f84c2d6108d3a8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d148412c1dae1465fb310958ec2b3afae4eccea5 Author: Martin Renvoize Date: Sun May 31 22:01:13 2020 +0100 Update release notes for 20.05.00 release Signed-off-by: Martin Renvoize commit bcea97744b7c753368ff78829441e1b8df752246 Author: Martin Renvoize Date: Sun May 31 21:37:41 2020 +0100 Update contributors Signed-off-by: Martin Renvoize commit aef33d840c78e82013940cf74b597e2ba8c526d0 Author: Martin Renvoize Date: Sun May 31 21:33:04 2020 +0100 Translation fixes Signed-off-by: Martin Renvoize commit 50d619d15625a3fecff9e0383798fa0e19ba0586 Author: Koha translators <> Date: Sun May 31 16:54:51 2020 -0300 Translation updates for Koha 20.05.00 Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: docs/contributors.yaml | 22 +- misc/release_notes/release_notes_20_05_00.html | 2968 +++ misc/release_notes/release_notes_20_05_00.md | 2376 ++ misc/translator/po/ar-Arab-messages.po | 10 +- misc/translator/po/ca-ES-staff-prog.po | 27988 ++++++++++++---------- misc/translator/po/cs-CZ-installer.po | 80 +- misc/translator/po/cs-CZ-messages-js.po | 7 +- misc/translator/po/cs-CZ-messages.po | 9 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 42 +- misc/translator/po/cs-CZ-staff-prog.po | 36 +- misc/translator/po/de-DE-opac-bootstrap.po | 6 +- misc/translator/po/de-DE-staff-prog.po | 10 +- misc/translator/po/eo-opac-bootstrap.po | 5 +- misc/translator/po/es-ES-installer.po | 1772 +- misc/translator/po/es-ES-messages.po | 4 +- misc/translator/po/es-ES-opac-bootstrap.po | 297 +- misc/translator/po/es-ES-pref.po | 351 +- misc/translator/po/es-ES-staff-prog.po | 1740 +- misc/translator/po/hi-staff-prog.po | 10 +- misc/translator/po/hu-HU-installer-MARC21.po | 13 +- misc/translator/po/hu-HU-marc-MARC21.po | 94 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 30 +- misc/translator/po/hu-HU-messages-js.po | 10 +- misc/translator/po/hu-HU-opac-bootstrap.po | 75 +- misc/translator/po/hu-HU-staff-prog.po | 145 +- misc/translator/po/hy-Armn-messages.po | 2 +- misc/translator/po/pl-PL-messages-js.po | 70 +- misc/translator/po/pl-PL-messages.po | 16 +- misc/translator/po/pl-PL-opac-bootstrap.po | 104 +- misc/translator/po/pl-PL-staff-prog.po | 102 +- misc/translator/po/pt-BR-installer-MARC21.po | 2015 +- misc/translator/po/pt-BR-installer.po | 1512 +- misc/translator/po/pt-BR-marc-MARC21.po | 808 +- misc/translator/po/pt-BR-pref.po | 10 +- misc/translator/po/pt-BR-staff-prog.po | 24 +- misc/translator/po/pt-PT-marc-MARC21.po | 24 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 8 +- misc/translator/po/pt-PT-messages-js.po | 65 +- misc/translator/po/pt-PT-messages.po | 16 +- misc/translator/po/pt-PT-opac-bootstrap.po | 91 +- misc/translator/po/pt-PT-pref.po | 7 +- misc/translator/po/sk-SK-staff-prog.po | 8 +- misc/translator/po/sq-AL-opac-bootstrap.po | 41 +- misc/translator/po/te-staff-prog.po | 16 +- misc/translator/po/uk-UA-marc-MARC21.po | 20 +- misc/translator/po/uk-UA-marc-NORMARC.po | 10 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 12 +- misc/translator/po/uk-UA-opac-bootstrap.po | 85 +- misc/translator/po/uk-UA-pref.po | 85 +- misc/translator/po/uk-UA-staff-prog.po | 897 +- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 4 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 4 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 7 +- misc/translator/po/zh-Hant-TW-pref.po | 9 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 244 +- 56 files changed, 26613 insertions(+), 17805 deletions(-) create mode 100644 misc/release_notes/release_notes_20_05_00.html create mode 100644 misc/release_notes/release_notes_20_05_00.md hooks/post-receive -- main Koha release repository